| Time |
S |
Nick |
Message |
| 00:00 |
|
|
KodoKorkalo[m] joined #koha |
| 00:00 |
|
|
paulderscheid[m] joined #koha |
| 00:00 |
|
|
Joubu joined #koha |
| 00:00 |
|
|
void09 joined #koha |
| 00:03 |
|
|
davewood joined #koha |
| 00:03 |
|
|
paxed joined #koha |
| 00:03 |
|
|
jo joined #koha |
| 00:03 |
|
|
kivilahtio joined #koha |
| 00:03 |
|
|
zb joined #koha |
| 00:03 |
|
|
tcohen joined #koha |
| 00:03 |
|
|
eythian joined #koha |
| 00:03 |
|
|
Joubu joined #koha |
| 00:03 |
|
|
fredericd joined #koha |
| 00:03 |
|
|
lari joined #koha |
| 00:03 |
|
|
matts joined #koha |
| 00:03 |
|
|
Nemo_bis joined #koha |
| 00:03 |
|
|
mtj[m] joined #koha |
| 00:03 |
|
|
domm[m] joined #koha |
| 00:04 |
|
|
domm joined #koha |
| 00:05 |
|
|
slef joined #koha |
| 00:06 |
|
|
KotH joined #koha |
| 00:06 |
|
|
void09 joined #koha |
| 00:09 |
|
|
jajm joined #koha |
| 00:14 |
|
|
KodoKorkalo[m] joined #koha |
| 00:18 |
|
|
eythian_ joined #koha |
| 00:19 |
|
|
kivilahtio joined #koha |
| 00:20 |
|
|
slef joined #koha |
| 00:20 |
|
|
Joubu joined #koha |
| 00:20 |
|
|
fredericd joined #koha |
| 00:20 |
|
|
lari joined #koha |
| 00:20 |
|
|
matts joined #koha |
| 00:20 |
|
|
mtj[m] joined #koha |
| 00:20 |
|
|
domm[m] joined #koha |
| 00:20 |
|
|
claw joined #koha |
| 00:21 |
|
|
zb joined #koha |
| 00:29 |
|
|
Nemo_bis joined #koha |
| 00:37 |
|
mtj |
hi wajasu, regarding your install problem with a trailing apt repo line of '...22.05 main bullseye' |
| 00:38 |
|
mtj |
it makes no difference :) |
| 00:39 |
|
mtj |
so your difference between installations is caused by something else |
| 01:36 |
|
|
alexbuckley joined #koha |
| 01:37 |
|
|
KodoKorkalo[m] joined #koha |
| 01:37 |
|
|
kivilahtio joined #koha |
| 01:38 |
|
|
matts joined #koha |
| 01:39 |
|
|
lari joined #koha |
| 01:40 |
|
|
zb joined #koha |
| 02:11 |
|
|
paulderscheid[m] joined #koha |
| 03:01 |
|
wajasu |
mtj: i'll play around with it next time I mess with my builds script. I'll put bullseye back in. |
| 03:03 |
|
wajasu |
ashimema: glad to know I can keep << >> for now. |
| 03:35 |
|
dcook |
Can't wait for us to get rid of << >> hehe |
| 03:37 |
|
wajasu |
i'm laying around learning about the plack/starman/mojolicious |
| 03:43 |
|
dcook |
bug 6936 |
| 03:43 |
|
huginn` |
Bug https://bugs.koha-community.or[…]w_bug.cgi?id=6936 enhancement, P5 - low, ---, dcook, Needs Signoff , Allow to limit on multiple itemtypes when exporting bibliographic records |
| 03:43 |
|
dcook |
wajasu: Good thing to learn about! |
| 03:44 |
|
dcook |
The plack/starman/mojolicious that is |
| 03:44 |
|
dcook |
Conceptually, it's a good thing to know in regards to any language really.. |
| 03:44 |
|
dcook |
Just has different names elsewhere |
| 03:51 |
|
wajasu |
yea. same concepts in app servers best practices. |
| 03:52 |
|
wajasu |
i have 512 swap. i made plack requests 3 and workers 15. no go. swapped... mariadb crashed :) |
| 03:52 |
|
wajasu |
i think i'll add a 4G swapfile. and stick with 1 worker and 50 requests. |
| 03:53 |
|
wajasu |
i can see why it might be better to deploy mariadb on a second server. |
| 03:55 |
|
wajasu |
plack/starman can blowup, and maybe recover. |
| 03:56 |
|
wajasu |
i will probably play with strace/strac/dtruss to maybe see what eats cpu in opac-search |
| 03:56 |
|
wajasu |
it might just be too many tasks. |
| 03:57 |
|
wajasu |
things work without crashing on my constrained 1cpu 2GB ram VPS. |
| 03:58 |
|
wajasu |
college students will hit the server tuesday during orientation. crosses-fingers. |
| 04:29 |
|
|
dpk__ joined #koha |
| 05:09 |
|
dcook |
If anyone wants an easy sign off to fix master: bug 31303 |
| 05:09 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31303 critical, P5 - low, ---, dcook, Needs Signoff , Fatal error when viewing OPAC user account with waiting holds |
| 06:01 |
|
|
cait joined #koha |
| 06:11 |
|
|
cait joined #koha |
| 06:21 |
|
|
cait joined #koha |
| 06:22 |
|
|
cait joined #koha |
| 06:28 |
|
|
cait joined #koha |
| 06:30 |
|
|
cait joined #koha |
| 06:45 |
|
|
alex_ joined #koha |
| 06:45 |
|
alex_ |
Bonjour |
| 06:49 |
|
|
magnuse joined #koha |
| 06:54 |
|
magnuse |
\o/ |
| 06:59 |
|
|
lds joined #koha |
| 07:03 |
|
|
cait joined #koha |
| 07:04 |
|
|
_hagud joined #koha |
| 07:06 |
|
_hagud |
good morning, I am facing an issue with LDAP's authentication, it was working before , but after a certificate change in customer's ldap is not working anymore.. I am getting ldap_sasl_bind(SIMPLE): Can't contact LDAP server (-1) although is reachable via telnet... the customer has sent me a ssl certificate, but I do not know If I can apply to koha, any help on this, please? or any tip or suggestion? |
| 07:40 |
|
paulderscheid[m] |
morning #koha |
| 08:09 |
|
|
MarkHofstetter joined #koha |
| 09:47 |
|
paulderscheid[m] |
Got another question concerning plugins. |
| 09:47 |
|
paulderscheid[m] |
I found a supposed Variable in a comment saying that [% PLUGIN_PATH %] gives the path to the plugins root dir. |
| 09:48 |
|
paulderscheid[m] |
Doesn't seem to work though. |
| 09:49 |
|
paulderscheid[m] |
What I want to achieve is sharing JS between pages. |
| 09:50 |
|
paulderscheid[m] |
And CSS. |
| 09:50 |
|
paulderscheid[m] |
Morning ashimema |
| 09:50 |
|
paulderscheid[m] |
Could you elaborate? |
| 09:51 |
|
paulderscheid[m] |
BTW could we move the Koha Advent plugin stuff into the docs? |
| 09:52 |
|
paulderscheid[m] |
The wiki page I suppose |
| 09:53 |
|
paulderscheid[m] |
Will you be @ kohacon? |
| 09:53 |
|
paulderscheid[m] |
Would be a great opportunity to discuss stuff like that |
| 09:54 |
|
paulderscheid[m] |
Haha, I just remembered that I asked the same question couple months ago and you gave me the same answer ^^ |
| 10:00 |
|
paulderscheid[m] |
Alright |
| 10:01 |
|
paulderscheid[m] |
Next hackfest will be fun as I can do stuff now ^^ |
| 10:02 |
|
paulderscheid[m] |
Likewise |
| 10:21 |
|
paulderscheid[m] |
Now it complains about the mimetype |
| 10:22 |
|
paulderscheid[m] |
Do I have to specify the mimetype in staticapi.json? |
| 10:27 |
|
paulderscheid[m] |
I did something wrong. Its mimetype was text/html because of the 404 page. |
| 10:27 |
|
paulderscheid[m] |
Nevermind |
| 10:30 |
|
|
oleonard joined #koha |
| 10:35 |
|
paulderscheid[m] |
Now it works |
| 10:35 |
|
paulderscheid[m] |
ashimema++ |
| 10:38 |
|
|
magnuse joined #koha |
| 11:00 |
|
|
oleonard joined #koha |
| 11:00 |
|
|
irc_oftc_net_66 joined #koha |
| 11:06 |
|
cait |
... I don't see ashimema talking... interesting |
| 11:08 |
|
cait |
paulderscheid[m]: were you talking to a ghost? |
| 11:08 |
|
paulderscheid[m] |
Haha, no |
| 11:08 |
|
paulderscheid[m] |
He just pointed me to the right koha advent api page ^^ |
| 11:09 |
|
cait |
but there is nothing in the logs... |
| 11:09 |
|
paulderscheid[m] |
oh |
| 11:09 |
|
paulderscheid[m] |
That's weird |
| 11:09 |
|
cait |
http://irc.koha-community.org/koha/2022-08-08 |
| 11:10 |
|
cait |
very spooky |
| 11:10 |
|
cait |
ashimema? can you hear us? |
| 11:11 |
|
oleonard |
It doesn't look to me like he's here |
| 11:12 |
|
cait |
paulderscheid[m]: so the ghost theory still stands |
| 11:12 |
|
cait |
youa re both using elment, aren't you? |
| 11:12 |
|
paulderscheid[m] |
Me too |
| 11:14 |
|
paulderscheid[m] |
I just looked at the logs. If you don't know it looks like I'm insane ^^ |
| 11:14 |
|
magnuse |
i could not see ashimema talking in my irc client either |
| 11:15 |
|
paulderscheid[m] |
ashimema: makes a sad face |
| 11:16 |
|
paulderscheid[m] |
Is this some kind of sixth sense situation where only I can see him ^^ |
| 11:19 |
|
paulderscheid[m] |
Did you already restart element? |
| 11:19 |
|
paulderscheid[m] |
Strange |
| 11:21 |
|
paulderscheid[m] |
!whois ashimema |
| 11:21 |
|
oleonard |
@seen ashimema |
| 11:21 |
|
huginn` |
oleonard: ashimema was last seen in #koha 23 hours, 55 minutes, and 9 seconds ago: <ashimema> They support slightly different options though, some of the newer notices rely on TT feature not available in our custom <<>> replacements wtuff |
| 11:26 |
|
paulderscheid[m] |
I can see you everywhere |
| 11:27 |
|
cait |
ashimema ashimema ashimema (worked for beetlejuice?) |
| 11:38 |
|
tcohen |
hi all FTR I'm about to make some maintenance work on the *git server* to fix some issue we are currently facing |
| 11:40 |
|
|
lds joined #koha |
| 11:49 |
|
cait |
tcohen: fingers crossed tcohen |
| 12:08 |
|
Joubu |
tcohen: can you record it there? https://tree.taiga.io/project/koha-ils/us/92 |
| 13:10 |
|
|
Dyrcona joined #koha |
| 13:21 |
|
|
SlackIntegration[m] joined #koha |
| 13:27 |
|
|
Lea[m] joined #koha |
| 13:28 |
|
|
SushiJames[m] joined #koha |
| 13:43 |
|
caroline_crazycatlady |
Is anyone good at cataloging authorities? I'm trying to make have this display, with the broader headings above, and I can't seem to do it https://koha-community.org/man[…]playHierarchy.png |
| 13:46 |
|
caroline_crazycatlady |
I catalogued authorities with broader/narrower headings https://snipboard.io/woW3qR.jpg |
| 13:49 |
|
caroline_crazycatlady |
I put the control number (001, assigned by Koha) of the other authority in 551$0. But as you can see the tree at the top only contains the authority I'm in right now https://snipboard.io/Y9QNpn.jpg |
| 13:53 |
|
cait |
I think here are indicators or a subfield you need to set to |
| 13:53 |
|
cait |
o |
| 13:53 |
|
Joubu |
caroline_crazycatlady: when I need to test this I always read the related commit |
| 13:53 |
|
Joubu |
83370c519c4291e81a76c02d5142a818f940fa50 |
| 13:53 |
|
Joubu |
there is an example at the end |
| 13:54 |
|
caroline_crazycatlady |
thanks! I will check it out |
| 13:55 |
|
cait |
caroline_crazycatlady: as you are here... Bernardo tells me in order to have the 22.05 manual on pootle it needs tohave the 22.05 branch |
| 13:55 |
|
cait |
are there any plans on branching yet? |
| 13:56 |
|
Joubu |
bug 23190 |
| 13:56 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=23190 major, P5 - low, ---, koha-bugs, NEW , Authority hierarchy display appears to be broken |
| 13:56 |
|
caroline_crazycatlady |
Not sure, davidnind is DM right now... 22.05 is not well documented yet, so the 22.05 manual would mostly be good for 21.11 |
| 13:57 |
|
Joubu |
caroline_crazycatlady: see Marcel's comment, you need to create the authority |
| 13:58 |
|
caroline_crazycatlady |
Ok yes it works |
| 13:59 |
|
caroline_crazycatlady |
I will document it. Authid not in $0, but in $9 |
| 13:59 |
|
caroline_crazycatlady |
thanks Joubu ! |
| 14:00 |
|
cait |
caroline_crazycatlady: makes sense... so we should wait? |
| 14:00 |
|
cait |
but doesn't it mean the manual links are broken now from inside Koha? |
| 14:01 |
|
caroline_crazycatlady |
I don't know. We have this discussion every cycle, but I don't think we've come to a decision yet |
| 14:01 |
|
cait |
hm it looks like the website balances it by still using hte master branch in the background |
| 14:01 |
|
cait |
https://koha-community.org/manual//22.05/en/html/ |
| 14:03 |
|
caroline_crazycatlady |
We don't have the resources to backport every commit to the correct manual branch so new commits are only merged to the master branch |
| 14:07 |
|
caroline_crazycatlady |
therefore the master branch is the most up to date with the current version. If we branch at the same time as Koha, all the changes we make for 22.05 changes will only be in the 22.11 manual basically |
| 14:15 |
|
huginn` |
News from kohagit: Bug 29983: Fix xt/author/valid-templates.t <https://git.koha-community.org[…]db15dc08b05164064> |
| 14:19 |
|
cait |
caroline_crazycatlady: it's difficult |
| 14:19 |
|
cait |
but as we don't have po files... there are no translated manuals then that are actually translated |
| 14:19 |
|
cait |
they are just copies of the previous with the english changes that are freshly merged |
| 14:20 |
|
caroline_crazycatlady |
true, so do we prefer to have translated but not up-to-date manuals, or up-to-date-ish english manuals? |
| 14:21 |
|
caroline_crazycatlady |
at the same time, the manuals are never 100% up-to-date so... maybe that shouldn't be considered |
| 14:25 |
|
huginn` |
News from kohagit: Revert "Bug 31104: Add a selenium test" <https://git.koha-community.org[…]9b287c2b9845c209e> |
| 14:26 |
|
caroline_crazycatlady |
Honestly, I'll go with whatever is decided... If we decide we branch at the same time as Koha, that's fine but people should know to look for information on new features in the dev branch manual and not their own version |
| 14:40 |
|
|
Oak joined #koha |
| 14:41 |
|
tcohen |
wizzyrea++ |
| 14:41 |
|
cait |
caroline_crazycatlady: not sure right now... it |
| 14:41 |
|
cait |
about the manuals - it's difficult overall |
| 14:53 |
|
caroline_crazycatlady |
It is... we are not a big enough team to keep up with the devs, so we are always behind and we can't catch up (we're like the little sibling trying to play with the older sibling and their friends XD) |
| 14:56 |
|
cait |
heh |
| 14:56 |
|
cait |
thanks btw for your recent work caroline_crazycatlady++ |
| 14:56 |
|
|
oleonard joined #koha |
| 15:00 |
|
|
bag joined #koha |
| 15:05 |
|
|
tuxayo joined #koha |
| 15:27 |
|
oleonard |
Joubu: Besides running tests is there anything else I can to do test Bug 31306? |
| 15:27 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31306 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Add Koha::Items->search_ordered method |
| 15:28 |
|
|
davidnind[m] joined #koha |
| 15:48 |
|
oleonard |
I guess I'll go with: If Bug 31308 seems to work, that's probably a good sign. |
| 15:48 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31308 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Remove GetItemsInfo from basket/basket |
| 16:10 |
|
oleonard |
When debug mode is enabled for an SMTP server where do errors get logged? |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31296: (QA follow-up) Fix trivial spelling errors <https://git.koha-community.org[…]336f8dc7f9f8940f0> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31303: (follow-up) Use get_effective_rule_value instead <https://git.koha-community.org[…]41ef3af7b4244d127> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31303: Prevent fatal errors when missing "waiting hold cancellation" rule <https://git.koha-community.org[…]d5d053e9c22bcee73> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31292: Untranslatable string in sample_notices.yaml <https://git.koha-community.org[…]493b299a715eabd68> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31296: (QA follow-up) Add to debian templates <https://git.koha-community.org[…]5c3c69e3838f491c4> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes <https://git.koha-community.org[…]599a72d55e1ee8005> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31155: Document --since option in help of borrowers-force-messaging-defaults.pl <https://git.koha-community.org[…]bacc4ade2107b4c7e> |
| 16:21 |
|
huginn` |
News from kohagit: Bug 31305: Remove type= from detail.pl <https://git.koha-community.org[…]21306c0a90c93079d> |
| 16:22 |
|
tcohen |
oleonard: that depends, maybe process_message_queue.pl output |
| 16:22 |
|
tcohen |
or in plack.log? |
| 16:23 |
|
oleonard |
I was able to work around it when testing Bug 31309 |
| 16:23 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31309 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Remove GetItemsInfo from basket/sendbasket |
| 16:23 |
|
oleonard |
I thought I had all my GMail info in there correctly. |
| 16:24 |
|
|
ashimema joined #koha |
| 16:24 |
|
ashimema |
ooh.. ooh.. am I online now |
| 16:25 |
|
oleonard |
tcohen: Did you just feel a cold chill? |
| 16:25 |
|
tcohen |
yeah, I thought I was the only one |
| 16:25 |
|
tcohen |
i heard there's a ghost on the channel |
| 16:25 |
|
tcohen |
hahaha |
| 16:25 |
|
oleonard |
:D |
| 16:25 |
|
tcohen |
wb ashimema |
| 16:26 |
|
ashimema |
woopie |
| 16:26 |
|
ashimema |
did nothing at this end to fix it.. it just suddenly said it connected |
| 16:27 |
|
tcohen |
what is it? matrix? znc? |
| 16:27 |
|
cait |
he is BACK! confetti! |
| 16:27 |
|
ashimema |
matrix |
| 16:27 |
|
tcohen |
confetti! |
| 16:27 |
|
wahanui |
o/`'`'`'`'`'`'`'`'`'`'`'` |
| 16:27 |
|
tcohen |
wahanui: you should've been set a regex |
| 16:27 |
|
wahanui |
tcohen: i'm not following you... |
| 16:27 |
|
tcohen |
nm |
| 16:29 |
|
cait |
bye all :) |
| 16:29 |
|
|
cait left #koha |
| 16:35 |
|
ashimema |
right.. and now it's time to clock off.. |
| 16:35 |
|
ashimema |
see you all tommorrow |
| 16:35 |
|
ashimema |
🙂 |
| 16:35 |
|
oleonard |
I hope ghost hours count on your time card ashimema |
| 16:41 |
|
tcohen |
hahaha |
| 16:51 |
|
huginn` |
News from kohagit: Bug 27779: DBRev 22.06.00.033 <https://git.koha-community.org[…]886304a13e0cd7941> |
| 16:51 |
|
huginn` |
News from kohagit: Bug 27779: (QA follow-up) Fix database update <https://git.koha-community.org[…]6efd8f888b9a95cd3> |
| 16:51 |
|
huginn` |
News from kohagit: Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission <https://git.koha-community.org[…]af3090d9eb9747a33> |
| 16:51 |
|
huginn` |
News from kohagit: Bug 27779: (QA follow-up) Fix translation issue with 'against' <https://git.koha-community.org[…]975fee47f93d96021> |
| 16:51 |
|
huginn` |
News from kohagit: Bug 27779: New atomic update syntax <https://git.koha-community.org[…]b78c3cce5b6cf4141> |
| 16:51 |
|
huginn` |
News from kohagit: Bug 27779: Update 'REFUND' description in the database <https://git.koha-community.org[…]c587cb948c27a7a52> |
| 16:52 |
|
huginn` |
News from kohagit: Bug 27779: Group payouts by type of debit they're applied against <https://git.koha-community.org[…]e02ed8dca67fe7d29> |
| 16:54 |
|
|
cait joined #koha |
| 16:54 |
|
tcohen |
Joubu: please check the tests for bug 28787 ASAP |
| 16:54 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28787 enhancement, P5 - low, ---, jonathan.druart+koha, Failed QA , Send a notice with the TOTP token |
| 16:55 |
|
* tcohen |
would like to push it doay |
| 16:55 |
|
tcohen |
today |
| 16:56 |
|
tcohen |
oleonard++ # rocking it as usual |
| 16:56 |
|
tcohen |
rijksmuseum++ # sponsoring cool stuff |
| 16:56 |
|
tcohen |
orex++ # sponsoring cool stuff |
| 16:59 |
|
|
dpk_ joined #koha |
| 17:35 |
|
|
marie-luce joined #koha |
| 18:08 |
|
|
fridolin joined #koha |
| 18:20 |
|
tuxayo |
tcohen: hi :) there is a follow-up to fix a typo on bug 30992 |
| 18:20 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30992 minor, P5 - low, ---, jonathan.druart+koha, Pushed to master , Hard to translate single word strings |
| 18:37 |
|
tcohen |
tuxayo: great you are here |
| 18:38 |
|
tcohen |
I wanted you to look at a follow-up I'm about to upload for bug 27779 |
| 18:38 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27779 enhancement, P5 - low, ---, martin.renvoize, Pushed to master , Cashup summary 'refunds' should denote what the refund was actioned against |
| 18:38 |
|
tcohen |
(if possible) |
| 18:43 |
|
tcohen |
there's no precedent use of __x |
| 18:43 |
|
tcohen |
that's why I ask |
| 18:46 |
|
huginn` |
News from kohagit: Bug 30992: (follow-up) Fix semicolon at line ending <https://git.koha-community.org[…]3992eab11d61c384b> |
| 19:09 |
|
fridolin |
tuxayo: yellow there, do you have a minute ? |
| 19:11 |
|
|
rangi[m] joined #koha |
| 19:14 |
|
tuxayo |
tcohen: looking at 27779 |
| 19:14 |
|
tuxayo |
fridolin: hi :) |
| 19:14 |
|
tuxayo |
what's up? |
| 19:28 |
|
fridolin |
tuxayo: yey I have a package problem on Ubuntu, not related to Koha |
| 20:01 |
|
tuxayo |
tcohen: finally found some doc about __x |
| 20:01 |
|
tuxayo |
https://metacpan.org/pod/Locale::TextDomain |
| 20:01 |
|
tuxayo |
https://bugs.koha-community.or[…]cgi?id=15395#c131 |
| 20:01 |
|
huginn` |
Bug 15395: enhancement, P5 - low, ---, julian.maurice, CLOSED FIXED, Internationalization: plural forms, context, and more |
| 20:01 |
|
tuxayo |
so your usage of __x looks ðŸ‘ï¸ |
| 20:16 |
|
tuxayo |
tcohen: about whether if there are enough format_price or escape_str, it can't say |
| 20:22 |
|
tuxayo |
*I can't say |
| 20:22 |
|
tcohen |
no worries about that |
| 20:22 |
|
tcohen |
they are needed heh |
| 20:23 |
|
tuxayo |
So let's roll with that or still another pair of eyes needed for the things other than __x? |
| 20:24 |
|
tcohen |
some tests are failing with that patchset |
| 20:24 |
|
tcohen |
so I asked ashimema to provide a follow-up |
| 20:24 |
|
tcohen |
once it is submitted, I'll push both |
| 20:55 |
|
|
dpk__ joined #koha |
