| Time |
S |
Nick |
Message |
| 02:10 |
|
koha-jenkins |
Project Koha_Master_D12 build #37: ABORTED in 16 hr: https://jenkins.koha-community[…]ha_Master_D12/37/ |
| 03:35 |
|
koha-jenkins |
Project Koha_Master_D12 build #38: ABORTED in 41 min: https://jenkins.koha-community[…]ha_Master_D12/38/ |
| 03:39 |
|
koha-jenkins |
Project Koha_Master_D11 build #415: FAILURE in 3 min 23 sec: https://jenkins.koha-community[…]a_Master_D11/415/ |
| 04:04 |
|
koha-jenkins |
Project Koha_21.05_D12 build #5: SUCCESS in 49 min: https://jenkins.koha-community[…]Koha_21.05_D12/5/ |
| 04:19 |
|
koha-jenkins |
Project Koha_19.11_D10 build #201: ABORTED in 57 min: https://jenkins.koha-community[…]ha_19.11_D10/201/ |
| 04:27 |
|
koha-jenkins |
Project Koha_Master_D11 build #416: NOW UNSTABLE in 33 min: https://jenkins.koha-community[…]a_Master_D11/416/ |
| 04:53 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #281: STILL UNSTABLE in 58 min: https://jenkins.koha-community[…]ter_U_Stable/281/ |
| 05:00 |
|
koha-jenkins |
Project Koha_Master build #1777: ABORTED in 40 min: https://jenkins.koha-community[…]Koha_Master/1777/ |
| 05:01 |
|
koha-jenkins |
Project Koha_Master_D12 build #39: ABORTED in 44 min: https://jenkins.koha-community[…]ha_Master_D12/39/ |
| 05:04 |
|
koha-jenkins |
Project Koha_20.05_U16 build #328: STILL FAILING in 3 min 46 sec: https://jenkins.koha-community[…]ha_20.05_U16/328/ |
| 05:05 |
|
koha-jenkins |
Project Koha_Master_U20 build #210: FAILURE in 4 min 32 sec: https://jenkins.koha-community[…]a_Master_U20/210/ |
| 05:06 |
|
|
chriss joined #koha |
| 05:08 |
|
koha-jenkins |
Project Koha_Master_D11 build #417: STILL UNSTABLE in 32 min: https://jenkins.koha-community[…]a_Master_D11/417/ |
| 05:08 |
|
|
Oak joined #koha |
| 05:18 |
|
koha-jenkins |
Project Koha_Master_D9 build #1788: STILL UNSTABLE in 42 min: https://jenkins.koha-community[…]a_Master_D9/1788/ |
| 05:33 |
|
koha-jenkins |
Project Koha_19.11_D11 build #17: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_19.11_D11/17/ |
| 05:36 |
|
koha-jenkins |
Project Koha_19.11_D10 build #202: UNSTABLE in 1 hr 16 min: https://jenkins.koha-community[…]ha_19.11_D10/202/ |
| 05:48 |
|
koha-jenkins |
Yippee, build fixed! |
| 05:48 |
|
wahanui |
Congratulations! |
| 05:48 |
|
koha-jenkins |
Project Koha_20.05_U20 build #366: FIXED in 43 min: https://jenkins.koha-community[…]ha_20.05_U20/366/ |
| 05:49 |
|
koha-jenkins |
Project Koha_19.11_U_Stable build #53: SUCCESS in 31 min: https://jenkins.koha-community[…]9.11_U_Stable/53/ |
| 05:53 |
|
|
lmstrand joined #koha |
| 06:14 |
|
koha-jenkins |
Project Koha_20.05_D10 build #325: ABORTED in 1 hr 9 min: https://jenkins.koha-community[…]ha_20.05_D10/325/ |
| 06:21 |
|
|
reiveune joined #koha |
| 06:21 |
|
reiveune |
hello |
| 06:29 |
|
koha-jenkins |
Project Koha_21.05_D11 build #91: SUCCESS in 52 min: https://jenkins.koha-community[…]oha_21.05_D11/91/ |
| 06:38 |
|
koha-jenkins |
Project Koha_21.05_D12 build #6: UNSTABLE in 49 min: https://jenkins.koha-community[…]Koha_21.05_D12/6/ |
| 06:51 |
|
|
alex_a joined #koha |
| 06:53 |
|
|
lds joined #koha |
| 07:06 |
|
|
cait joined #koha |
| 07:15 |
|
|
alex_a_ joined #koha |
| 07:22 |
|
koha-jenkins |
Project Koha_19.11_D10 build #203: STILL UNSTABLE in 1 hr 8 min: https://jenkins.koha-community[…]ha_19.11_D10/203/ |
| 07:38 |
|
koha-jenkins |
Project Koha_21.05_U16 build #74: FAILURE in 2 min 50 sec: https://jenkins.koha-community[…]oha_21.05_U16/74/ |
| 07:40 |
|
|
Jeremy_b joined #koha |
| 07:46 |
|
huginn` |
News from kohagit: Bug 28211: Fix test <https://git.koha-community.org[…]e19ff5e6ef7e19ab1> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29263: (bug 24387 follow-up) Fix 'Cancel' link when editing a html custom <https://git.koha-community.org[…]6e9a43b6a2606f5b0> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29254: Fix date formatting on the additional contents form <https://git.koha-community.org[…]3c4c98fd862a8b5fd> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29153: Fix CodeMirror textareas to work with all languages <https://git.koha-community.org[…]30cbd9269819b28ef> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29233: Correct missed jQueryUI datepicker in serials search sidebar <https://git.koha-community.org[…]e9b2a001435f52691> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29232: Clean up obsolete jQueryUI datepicker code from cash register stats template <https://git.koha-community.org[…]a67200f9d2106bc09> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29020: Add link on the admin module <https://git.koha-community.org[…]6e6db9aeda4e66842> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 29020: Add link on the mainpage for users without admin access <https://git.koha-community.org[…]33e52c17dd021dffa> |
| 07:46 |
|
huginn` |
News from kohagit: Bug 20277: Improve 773 link when $a is present <https://git.koha-community.org[…]092d8025df64fe943> |
| 07:56 |
|
ashimema |
morning #koha |
| 08:01 |
|
ashimema |
marcelr around? |
| 08:04 |
|
ashimema |
or anyone else whose at all close to how 773's work |
| 08:04 |
|
ashimema |
cait around? |
| 08:04 |
|
wahanui |
i heard cait around was cait cait1 cait2 cait3 cait4 cait5 |
| 08:06 |
|
|
mike joined #koha |
| 08:11 |
|
koha-jenkins |
Project Koha_21.05_U20 build #78: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_21.05_U20/78/ |
| 08:14 |
|
koha-jenkins |
Project Koha_21.05_D11 build #92: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_21.05_D11/92/ |
| 08:18 |
|
cait |
a little bit around, what's up? |
| 08:20 |
|
cait |
ashimema: ^ |
| 08:25 |
|
koha-jenkins |
Yippee, build fixed! |
| 08:25 |
|
wahanui |
Congratulations! |
| 08:25 |
|
koha-jenkins |
Project Koha_21.05_D12 build #7: FIXED in 49 min: https://jenkins.koha-community[…]Koha_21.05_D12/7/ |
| 08:28 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #282: FAILURE in 3 min 22 sec: https://jenkins.koha-community[…]ter_U_Stable/282/ |
| 08:29 |
|
ashimema |
trying to get to grips with searches again |
| 08:29 |
|
ashimema |
for the 773 control number + identifier stuff |
| 08:31 |
|
ashimema |
the searches that bug 27507 and bug 20310 are entirely different |
| 08:31 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27507 enhancement, P5 - low, ---, joonas.kylmala, Failed QA , Search host record using control number identifier / organization code |
| 08:31 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=20310 enhancement, P5 - low, ---, m.de.rooy, RESOLVED FIXED, Article requests: Use details from the host record when submitting an article request on an analytic record without attached items |
| 08:31 |
|
ashimema |
but I think they should match |
| 08:31 |
|
ashimema |
they're both using the 773$w to try to look up the host |
| 08:32 |
|
ashimema |
one looks for 'rcn:controlnumber AND rci:identifier' |
| 08:32 |
|
ashimema |
whilst the other looks for `rcn:(identifier)controlnumber` |
| 08:32 |
|
ashimema |
I think the former is right (assuming identifier is present in the $w) |
| 08:32 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #70: SUCCESS in 57 min: https://jenkins.koha-community[…]1.05_U_Stable/70/ |
| 08:33 |
|
ashimema |
the `(identifier)controlnumber` form is for looking in the oposite direction isn't it.. i.e doing the components search not the host search |
| 08:35 |
|
koha-jenkins |
Project Koha_21.05_D9 build #74: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]Koha_21.05_D9/74/ |
| 08:38 |
|
koha-jenkins |
Project Koha_21.05_U18 build #72: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]oha_21.05_U18/72/ |
| 08:43 |
|
koha-jenkins |
Yippee, build fixed! |
| 08:43 |
|
wahanui |
Congratulations! |
| 08:43 |
|
koha-jenkins |
Project Koha_20.05_U16 build #329: FIXED in 32 min: https://jenkins.koha-community[…]ha_20.05_U16/329/ |
| 08:53 |
|
ashimema |
man 773 is weird |
| 08:53 |
|
ashimema |
773 is repeatable itself and it looks lie $w is also repeatable |
| 08:53 |
|
koha-jenkins |
Yippee, build fixed! |
| 08:53 |
|
wahanui |
Congratulations! |
| 08:53 |
|
koha-jenkins |
Project Koha_Master_D11 build #418: FIXED in 39 min: https://jenkins.koha-community[…]a_Master_D11/418/ |
| 08:53 |
|
ashimema |
so we're already not iterating enough |
| 09:00 |
|
|
MikeLake joined #koha |
| 09:09 |
|
ashimema |
marcelr, cait see final comment on bug 27507 |
| 09:09 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27507 enhancement, P5 - low, ---, joonas.kylmala, Failed QA , Search host record using control number identifier / organization code |
| 09:14 |
|
koha-jenkins |
Project Koha_21.05_U16 build #75: STILL FAILING in 24 min: https://jenkins.koha-community[…]oha_21.05_U16/75/ |
| 09:19 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:19 |
|
wahanui |
Congratulations! |
| 09:19 |
|
koha-jenkins |
Project Koha_Master_D11_CPAN build #451: FIXED in 50 min: https://jenkins.koha-community[…]ter_D11_CPAN/451/ |
| 09:22 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #283: STILL FAILING in 3 min 3 sec: https://jenkins.koha-community[…]ter_U_Stable/283/ |
| 09:24 |
|
|
vfernandes joined #koha |
| 09:28 |
|
cait |
ashimema: yes $w is repeatable |
| 09:28 |
|
cait |
in an ideal world we'd need a way to define whch prefix we want to look for |
| 09:29 |
|
cait |
in our data we delete all the additional $w - the original data will have up to 3 |
| 09:29 |
|
cait |
we are slowly getting there by adding the prefix support i guess |
| 09:30 |
|
ashimema |
so you agree with my final comment on the bug then? |
| 09:30 |
|
ashimema |
we can pass MarcOrgCode easily enough to the xslt's as a variable |
| 09:30 |
|
ashimema |
so we can do that comparison in xslt fairly easil |
| 09:30 |
|
ashimema |
s/easil/easily/ |
| 09:31 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:31 |
|
wahanui |
Congratulations! |
| 09:31 |
|
koha-jenkins |
Project Koha_Master_D10_My8 build #666: FIXED in 38 min: https://jenkins.koha-community[…]ster_D10_My8/666/ |
| 09:35 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:35 |
|
wahanui |
Congratulations! |
| 09:36 |
|
koha-jenkins |
Project Koha_Master_D9 build #1789: FIXED in 1 hr 0 min: https://jenkins.koha-community[…]a_Master_D9/1789/ |
| 09:40 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:40 |
|
wahanui |
Congratulations! |
| 09:40 |
|
koha-jenkins |
Project Koha_Master_U20 build #211: FIXED in 1 hr 7 min: https://jenkins.koha-community[…]a_Master_U20/211/ |
| 09:51 |
|
koha-jenkins |
Project Koha_20.05_U16 build #330: SUCCESS in 30 min: https://jenkins.koha-community[…]ha_20.05_U16/330/ |
| 10:22 |
|
oleonard |
Hi all |
| 10:33 |
|
koha-jenkins |
Project Koha_Master_U20 build #212: SUCCESS in 52 min: https://jenkins.koha-community[…]a_Master_U20/212/ |
| 10:36 |
|
koha-jenkins |
Yippee, build fixed! |
| 10:36 |
|
wahanui |
Congratulations! |
| 10:36 |
|
koha-jenkins |
Project Koha_21.05_U16 build #76: FIXED in 1 hr 14 min: https://jenkins.koha-community[…]oha_21.05_U16/76/ |
| 10:39 |
|
magnuse |
hiya oleonard |
| 10:45 |
|
oleonard |
Anyone else seeing updatedatabase errors? |
| 10:45 |
|
oleonard |
DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`borrower_message_preferences`, CONSTRAINT `borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`) ON DELETE CASCADE ON UPDAT) |
| 11:00 |
|
Joubu |
oleonard: certainly related to bug 28153 |
| 11:00 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28153 enhancement, P5 - low, ---, nick, Pushed to master , Add 'Hold reminder' messaging preference |
| 11:00 |
|
oleonard |
Yes, but I don't know if it's a quirk of my data or a problem we need to be aware of. |
| 11:01 |
|
oleonard |
Changing the "INSERT" to "INSERT IGNORE" in the update allows the process to complete. |
| 11:01 |
|
Joubu |
the last query I guess? |
| 11:02 |
|
Joubu |
kidclamp: ^^ |
| 11:02 |
|
Joubu |
lunch time for me :) |
| 11:03 |
|
|
awazez joined #koha |
| 11:12 |
|
koha-jenkins |
Project Koha_19.11_D10 build #204: ABORTED in 1 hr 58 min: https://jenkins.koha-community[…]ha_19.11_D10/204/ |
| 11:39 |
|
tcohen |
morning |
| 11:57 |
|
|
marcelr joined #koha |
| 11:57 |
|
marcelr |
hi #koha |
| 11:58 |
|
marcelr |
oleonard: please have a look if bug 24223 is still what you expected from it :) |
| 11:58 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=24223 enhancement, P5 - low, ---, oleonard, Passed QA , Convert OpacNav system preference to news block |
| 12:05 |
|
|
alex_a_ joined #koha |
| 12:16 |
|
* cait |
waves |
| 12:16 |
|
cait |
ashimema: we can pass it... but it's not that easy |
| 12:17 |
|
cait |
ashimema: MarcOrgCode can be different things - it's a branch level setting |
| 12:17 |
|
cait |
and if you are connected to a union catlaog, the prefix to use might be that one |
| 12:17 |
|
cait |
and not the one of yoru library |
| 12:18 |
|
cait |
not ure we should mix that discussion into the current developments which all seem to still be flexible enough |
| 12:18 |
|
marcelr |
hi cait |
| 12:18 |
|
cait |
hi marcelr |
| 12:18 |
|
ashimema |
humm |
| 12:18 |
|
marcelr |
and ashimema |
| 12:18 |
|
wahanui |
ashimema is probably back on security bugs today.. sorry, it's been a bit of a crazy week |
| 12:18 |
|
marcelr |
another crazy week for ashimema |
| 12:18 |
|
cait |
wahanui: when is it not a crazy week... |
| 12:18 |
|
ashimema |
humm |
| 12:19 |
|
ashimema |
get_marc_host doesn't take branch level org code into account either |
| 12:19 |
|
ashimema |
dang.. |
| 12:19 |
|
ashimema |
I hadn't though of that one either |
| 12:19 |
|
ashimema |
every week is a crazy week at the moment it feels |
| 12:19 |
|
ashimema |
my brain hurts |
| 12:19 |
|
marcelr |
keep off that great sub haha |
| 12:19 |
|
ashimema |
procrastinating on 773 links shoulnd't really be a thing.. the other stuff I had to get on with is even more involved and scary though. |
| 12:20 |
|
ashimema |
hehe |
| 12:20 |
|
marcelr |
it should be C4::Search |
| 12:20 |
|
ashimema |
it's a fun sub marcelr |
| 12:20 |
|
marcelr |
but C4::Auth is a good second one |
| 12:20 |
|
ashimema |
I dunno |
| 12:20 |
|
ashimema |
I think it belongs where it is.. |
| 12:20 |
|
ashimema |
but there's allot of cases it doesn't take account of.. |
| 12:21 |
|
marcelr |
lets move all that debatable stuff in plugins :) |
| 12:21 |
|
ashimema |
branch level MARCOrgCode's, repeatable w subfields, and the search itself I think is wrong.. |
| 12:21 |
|
marcelr |
I wonder if you got the finesses of that search |
| 12:22 |
|
marcelr |
it is a bit obscure |
| 12:22 |
|
ashimema |
I'm sure it should be `control-number=X AND cni=Y` rather than control-number=(Y)X` |
| 12:22 |
|
ashimema |
but hey |
| 12:22 |
|
marcelr |
all that text parsing where marc forces us to |
| 12:24 |
|
ashimema |
indeed |
| 12:24 |
|
ashimema |
fun times |
| 12:24 |
|
* ashimema |
needs more tea |
| 12:24 |
|
cait |
what they do know is looking for a record matching the $w |
| 12:25 |
|
cait |
that's all fine |
| 12:25 |
|
cait |
we just don't check on the marcorgcode |
| 12:25 |
|
cait |
it works on "exists in $w" in one record and "exists in 003" in another record |
| 12:25 |
|
cait |
so we don't have to know which marcorgcode we are looking for |
| 12:25 |
|
cait |
the problem arises when you have repeatable $w... but maybe that#s a problem for another day? that's how i see it |
| 12:26 |
|
ashimema |
huh |
| 12:29 |
|
marcelr |
cait get_marc_host does look at marcorgcode |
| 12:30 |
|
marcelr |
it uses it to pick the right one |
| 12:30 |
|
ashimema |
but not at branch level 😉 |
| 12:30 |
|
marcelr |
but ashimema found another edge case :) |
| 12:30 |
|
ashimema |
and the searches it does are a bit weird |
| 12:30 |
|
marcelr |
hmmm |
| 12:31 |
|
* ashimema |
thinks he probably "helped" lead to the search confusion in the first place |
| 12:31 |
|
* ashimema |
will happily take/share the blame 😛 |
| 12:32 |
|
marcelr |
if you add a loop in the existing loop, we will tackle the various $w subfields alread |
| 12:32 |
|
marcelr |
y |
| 12:32 |
|
ashimema |
indeed |
| 12:32 |
|
ashimema |
I've got a patch in the works for that |
| 12:32 |
|
ashimema |
what I'm still contemplating is the search thing above |
| 12:33 |
|
ashimema |
001 won't ever contain (003)001 will it |
| 12:33 |
|
ashimema |
it's 001 and 003 |
| 12:33 |
|
marcelr |
assumptions are dangerous things |
| 12:33 |
|
ashimema |
I think we got the direction of the query wrong in get_marc_host |
| 12:33 |
|
ashimema |
lol |
| 12:34 |
|
marcelr |
submit your code and i will shoot |
| 12:34 |
|
marcelr |
(in the air) |
| 12:34 |
|
ashimema |
lol |
| 12:36 |
|
cait |
ashimema: from the standard it should be so |
| 12:36 |
|
cait |
i have not seen (003)001 in the wild |
| 12:36 |
|
cait |
but |
| 12:36 |
|
cait |
you might want to link to 035 |
| 12:37 |
|
cait |
the standard is not very clear on if that should be allowed or not |
| 12:37 |
|
ashimema |
nooo.. don't add 035 into the mix |
| 12:37 |
|
ashimema |
i'll lose my mind |
| 12:37 |
|
* cait |
shrugs |
| 12:37 |
|
cait |
but yes, assuming marcorgcode is the one ... would at leat not work for ours |
| 12:37 |
|
cait |
marcorgcode for ours is their own library code, all the data comes in linked with the union catalog org corde |
| 12:37 |
|
* cait |
sputters |
| 12:37 |
|
cait |
can't type today |
| 12:38 |
|
cait |
the initial one i had a look at just looked for what was in 003 matching - so that would have worked, not sure where the marcorgcode system preference came into plac |
| 12:38 |
|
ashimema |
so do you repeat $w or repate the full 773? |
| 12:38 |
|
ashimema |
which bug are you looking at now? |
| 12:39 |
|
cait |
no |
| 12:39 |
|
cait |
only the $w |
| 12:39 |
|
cait |
i am not looking at any bug |
| 12:39 |
|
ashimema |
I see |
| 12:39 |
|
cait |
i am not even sure which one you were talking about (thinking component parts?) |
| 12:39 |
|
ashimema |
component parts got me looking at the opposites again |
| 12:39 |
|
ashimema |
component parts is kinda easier |
| 12:40 |
|
cait |
actually I am not suer how common a repeatable $w would actually be (i know i said differently earlier, but was confusing it with $0) |
| 12:40 |
|
cait |
$0 = links to authorities, but Koha doesn't use that |
| 12:43 |
|
ashimema |
but the search from child to host should be the AND search right.. not a combined string |
| 12:43 |
|
marcelr |
keep it flexible ashimema |
| 12:43 |
|
ashimema |
that's the aim |
| 12:43 |
|
marcelr |
i was searching for either num and (code)num |
| 12:44 |
|
ashimema |
indeed |
| 12:44 |
|
ashimema |
but I think it should be |
| 12:45 |
|
ashimema |
`control-number=num` and `control-number=num and control-number-identifier=code` |
| 12:45 |
|
ashimema |
not `control-number=(code)num` |
| 12:45 |
|
ashimema |
does that make sense |
| 12:45 |
|
marcelr |
and what if you loose results now ? |
| 12:45 |
|
ashimema |
I don't think you will |
| 12:45 |
|
marcelr |
depends on data |
| 12:45 |
|
ashimema |
you think |
| 12:46 |
|
marcelr |
or at least ask |
| 12:46 |
|
ashimema |
my point is I don't think control number.. i.e. 001 ever includes 003 internally. |
| 12:46 |
|
ashimema |
I can ask |
| 12:47 |
|
|
Dyrcona joined #koha |
| 12:52 |
|
cait |
ashimema: or between the combinations |
| 12:52 |
|
cait |
if you really want to deal with repeatalbes |
| 12:52 |
|
ashimema |
? |
| 12:53 |
|
cait |
(cn-A and cni-A) or (cn-B and cni-B) |
| 12:53 |
|
cait |
if you have multiple $w we could do a search with or |
| 12:53 |
|
ashimema |
yikes.. |
| 12:53 |
|
ashimema |
you are right |
| 12:53 |
|
ashimema |
thanks |
| 12:53 |
|
cait |
where we search the cni and number combined |
| 12:54 |
|
cait |
it probably helps we just had a boolean sql expression dispute here lol |
| 12:54 |
|
cait |
crazy_weeks++ |
| 12:54 |
|
* ashimema |
goes back to contemplating whether this can be done in one search query instead of multiple |
| 12:55 |
|
ashimema |
(cn-A and cni-A) or (cn-B and cni-B) or cn-A or cn-B |
| 12:56 |
|
ashimema |
issue being how do we pick the correct match |
| 13:02 |
|
marcelr |
not sure if we are going in the right direction here |
| 13:02 |
|
ashimema |
go on |
| 13:03 |
|
marcelr |
lets see |
| 13:03 |
|
marcelr |
now you are pickign all $ws in the search too |
| 13:03 |
|
marcelr |
think this is really edge cases |
| 13:03 |
|
ashimema |
indeed |
| 13:03 |
|
ashimema |
that's where I struggle |
| 13:03 |
|
ashimema |
'how do we pick the correct match' |
| 13:03 |
|
ashimema |
the search is getting broader |
| 13:03 |
|
marcelr |
i used or same orgcode or no orgcode |
| 13:04 |
|
ashimema |
except as cait just highlighted.. orgcode isn't always at the system level.. it can be narrower at the branch level |
| 13:05 |
|
marcelr |
yeah even nicer |
| 13:05 |
|
|
SoniaB joined #koha |
| 13:05 |
|
marcelr |
a cataloger level would be nice too :) |
| 13:05 |
|
ashimema |
lol |
| 13:15 |
|
cait |
ashimema: i think there will only be one |
| 13:15 |
|
cait |
if you do the combined searches, one will be right, the other will yield no results |
| 13:15 |
|
cait |
you do a broad search, but you are still looking for ids |
| 13:15 |
|
cait |
each shoudl only match one record max |
| 13:15 |
|
cait |
and in a normal catalog, it will be one |
| 13:15 |
|
cait |
one is the "right one" |
| 13:16 |
|
ashimema |
okies |
| 13:16 |
|
cait |
so i think if we don't acutally "know" which one is the right orgcode - it can still work |
| 13:17 |
|
cait |
what we might want to do is tell koha if we use cni or not... |
| 13:17 |
|
cait |
because if we do a search for combined and uncombined at the same time that could yield some unexpected results |
| 13:17 |
|
cait |
(combined = cni + cn) |
| 13:19 |
|
ashimema |
indeed |
| 13:21 |
|
marcelr |
we could add some prefs lol |
| 13:27 |
|
cait |
either that or make guesses/assumptions :) |
| 13:27 |
|
cait |
actually... we removed the marcorgcode from w but have the 003 |
| 13:28 |
|
cait |
so... we are a problem case |
| 13:28 |
|
cait |
that's why joonas accounted for that case in his components when i last checked |
| 13:29 |
|
ashimema |
or we continue to do what marcelr did and do a search for with and if it doesn't get anything fall back |
| 13:29 |
|
Joubu |
@later tell fridolin Hey your proposal is still empty! Should we postpone tomorrow's vote? |
| 13:29 |
|
huginn` |
Joubu: The operation succeeded. |
| 13:29 |
|
ashimema |
rather than us the OR and risk getting multiple hits |
| 13:38 |
|
marcelr |
ashimema: i would agree only with improvements ;) |
| 13:39 |
|
ashimema |
iv'e decided my brain hurts too much for this right now 😜 |
| 13:40 |
|
ashimema |
I'll swing round some other time |
| 13:40 |
|
marcelr |
ashimema++ |
| 13:40 |
|
* ashimema |
hopes 11175 is close enough to go through |
| 13:40 |
|
marcelr |
bug 11175 |
| 13:40 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=11175 enhancement, P5 - low, ---, joonas.kylmala, Signed Off , Show the parent record's component parts in the detailed views |
| 13:41 |
|
marcelr |
ah 40 qa follow-ups |
| 13:41 |
|
marcelr |
not much chance |
| 13:42 |
|
ashimema |
I ended up adopting it to help it get moving |
| 13:42 |
|
marcelr |
could you squash some stuff |
| 13:42 |
|
marcelr |
to make it more attractive to qa |
| 13:42 |
|
ashimema |
but it needed more work that I was comfortable with just making pqa |
| 13:42 |
|
ashimema |
Joubu was on the case working through it as a squashed set |
| 13:42 |
|
ashimema |
it's not too bad if you look at it as a whole |
| 13:42 |
|
ashimema |
i.e diff the result against master |
| 13:43 |
|
ashimema |
it would be the road to madness to look at the individual commits |
| 13:43 |
|
marcelr |
i love to qa patchsets that are a bit smaller |
| 13:43 |
|
Joubu |
lazy marcelr |
| 13:43 |
|
ashimema |
but I didn't want to loose all the authors by squashing in one |
| 13:43 |
|
marcelr |
you should be |
| 13:43 |
|
marcelr |
these authors have patches in, so no big deal? |
| 13:44 |
|
ashimema |
bug 26314 might be more up your street marcelr 😜 |
| 13:44 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=26314 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , "Volumes: show volumes" showing regardless of whether there are volumes linked to the record |
| 13:44 |
|
ashimema |
it all adds to overall stats 😉 |
| 13:44 |
|
marcelr |
stats tell everything and nothing |
| 13:45 |
|
marcelr |
maybe i just should pick 11175 on friday |
| 13:45 |
|
Joubu |
are you looking for bugs that need love?! |
| 13:45 |
|
ashimema |
personally.. it makes a difference to my end of year report if I can say X commits of mine got in in the last year to the bosses 😉 |
| 13:45 |
|
Joubu |
marcelr: https://link.infini.fr/koha_bz[…]l_21_11_candidate |
| 13:45 |
|
ashimema |
nope |
| 13:45 |
|
marcelr |
ashimema: make sure it applies on friday |
| 13:45 |
|
marcelr |
i will squash it and add 10 followups |
| 13:45 |
|
ashimema |
don't worry too much |
| 13:46 |
|
marcelr |
just use git reset |
| 13:46 |
|
ashimema |
I've been flogging that horse for a while.. I know there are plenty in the queue to keep people busy 😉 |
| 13:46 |
|
ashimema |
nice to see the flatpickr console issue pushed |
| 13:46 |
|
ashimema |
suppose I best get back to the request.tt bit of it some time soon |
| 13:51 |
|
|
marie-luce joined #koha |
| 13:55 |
|
cait |
marcelr: it's still their code |
| 13:56 |
|
marcelr |
did you look at that report? |
| 13:56 |
|
cait |
patches in or not... i don't think that's the point |
| 13:56 |
|
marcelr |
if a report has 20-40 qa followups, then you know there is something wrong |
| 13:56 |
|
cait |
but the squash will not change the code |
| 13:56 |
|
cait |
:) |
| 13:56 |
|
cait |
just how it appears |
| 13:57 |
|
marcelr |
thats exactly the point |
| 13:57 |
|
ashimema |
in allot of cases it's simply that time has passed.. so lots of follow-ups are needed to catch up with current guidelines |
| 13:57 |
|
cait |
one of the issues, yes |
| 13:57 |
|
cait |
i am not against suqashing per se |
| 13:57 |
|
cait |
i just think that authorship is important |
| 13:58 |
|
cait |
so maybe some could be squashed if that helps with keeping that in mind |
| 13:58 |
|
marcelr |
qa team and rm may squash if they have good reasons to do so |
| 14:00 |
|
cait |
I just feel it's squishy... i think in copyright law you never lose authorship of wahtever, you just give away rights |
| 14:01 |
|
cait |
that's how i think about the code too - if authors agree you may, but I still don't really see a reason with git |
| 14:01 |
|
marcelr |
its interesting to be author of line A which was refactored in commit B, C, D and removed in E :) |
| 14:01 |
|
* ashimema |
wonders why we're debating this.. `git diff upstream/master` is enough to really easily see the diff over the whole patchest |
| 14:02 |
|
marcelr |
it makes your brain relax? |
| 14:02 |
|
marcelr |
lol |
| 14:02 |
|
ashimema |
personally I actually find it pretty helpful to be able to work backwards through a blame series to understand the authors intent |
| 14:03 |
|
marcelr |
yes, but that does not prevent the qaer from squashing afterwards |
| 14:04 |
|
cait |
blame = finding a bug later |
| 14:04 |
|
cait |
already pushed |
| 14:04 |
|
cait |
i am with Martin |
| 14:04 |
|
cait |
you can "squash" virtually with git easily, but you can never unsquash |
| 14:04 |
|
marcelr |
he's fighting for his patches :) |
| 14:05 |
|
marcelr |
dont worry |
| 14:05 |
|
marcelr |
ashimema: this is already part of the qa session haha - how involved is the author? |
| 14:07 |
|
ashimema |
each commit has an explicit comment so is helpful in my mind.. but I'm not too worried really |
| 14:07 |
|
huginn` |
News from kohagit: Bug 28211: (QA follow-up) Test for hook calls properly <https://git.koha-community.org[…]c8a3a5f34e147198a> |
| 14:07 |
|
huginn` |
News from kohagit: Bug 28153: (follow-up) Ensure update is idempotent <https://git.koha-community.org[…]8ad222a6aa7ecb10c> |
| 14:07 |
|
huginn` |
News from kohagit: Bug 29240: Rename start_for with date_to <https://git.koha-community.org[…]fcdbebc5fe5ff10a4> |
| 14:07 |
|
huginn` |
News from kohagit: Bug 29240: (follow-up) Correct more instances <https://git.koha-community.org[…]25eaf19cf208485f0> |
| 14:07 |
|
huginn` |
News from kohagit: Bug 29240: Centralise from/to handling <https://git.koha-community.org[…]8983b17e9ad06b46a> |
| 14:07 |
|
ashimema |
just imagine they might be helpful to someone trying to unravel in a years time 😉 |
| 14:08 |
|
ashimema |
school run.. back in a bit |
| 14:10 |
|
Joubu |
I don't mind if each commit does something. But I don't like when things are added, modified, removed, added again |
| 14:10 |
|
Joubu |
commits like that should be squashed |
| 14:10 |
|
Joubu |
what I usually do on push |
| 14:20 |
|
marcelr |
Joubu++ |
| 14:20 |
|
Joubu |
tcohen, ashimema, kidclamp: we need a desision on bug 28700 |
| 14:20 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28700 major, P5 - low, ---, stalkernoid, In Discussion , "Unblessed" method in Object.pm has blessed values for keys in some cases |
| 14:21 |
|
marcelr |
you could also wonder about the following question: could this commit live on its own? and would we like that? but this applies to much more.. |
| 14:42 |
|
koha-jenkins |
Project Koha_Master_D11_CPAN build #452: SUCCESS in 34 min: https://jenkins.koha-community[…]ter_D11_CPAN/452/ |
| 14:55 |
|
|
SoniaB left #koha |
| 15:00 |
|
koha-jenkins |
Project Koha_Master_U20 build #213: SUCCESS in 51 min: https://jenkins.koha-community[…]a_Master_U20/213/ |
| 15:05 |
|
|
alex_a joined #koha |
| 15:07 |
|
koha-jenkins |
Project Koha_Master_D10_My8 build #667: SUCCESS in 56 min: https://jenkins.koha-community[…]ster_D10_My8/667/ |
| 15:12 |
|
reiveune |
bye |
| 15:12 |
|
|
reiveune left #koha |
| 15:16 |
|
koha-jenkins |
Project Koha_Master_D11 build #419: SUCCESS in 33 min: https://jenkins.koha-community[…]a_Master_D11/419/ |
| 15:16 |
|
|
aaru_swartz[m] joined #koha |
| 15:24 |
|
koha-jenkins |
Project Koha_Master_D9 build #1790: SUCCESS in 1 hr 15 min: https://jenkins.koha-community[…]a_Master_D9/1790/ |
| 15:34 |
|
koha-jenkins |
Yippee, build fixed! |
| 15:34 |
|
wahanui |
Congratulations! |
| 15:34 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #284: FIXED in 41 min: https://jenkins.koha-community[…]ter_U_Stable/284/ |
| 15:37 |
|
|
cait left #koha |
| 15:52 |
|
|
caroline_crazycatlady joined #koha |
| 16:33 |
|
koha-jenkins |
Project Koha_Master_D12 build #40: ABORTED in 1 hr 11 min: https://jenkins.koha-community[…]ha_Master_D12/40/ |
| 16:33 |
|
koha-jenkins |
Project Koha_20.05_D10 build #326: ABORTED in 1 hr 4 min: https://jenkins.koha-community[…]ha_20.05_D10/326/ |
| 16:34 |
|
koha-jenkins |
Project Koha_Master build #1778: ABORTED in 1 hr 4 min: https://jenkins.koha-community[…]Koha_Master/1778/ |
| 16:34 |
|
koha-jenkins |
Project Koha_Master_D12 build #41: ABORTED in 59 sec: https://jenkins.koha-community[…]ha_Master_D12/41/ |
| 16:35 |
|
|
IGS joined #koha |
| 16:37 |
|
IGS |
Yesterday I got SQL code that will show me a list of instances of local use. The list shows me the item number, but that's not very helpful. How can I get it to show me book titles and call numbers? |
| 16:48 |
|
|
cait joined #koha |
| 16:51 |
|
pastebot |
"oleonard" at 127.0.0.1 pasted "IGS try this" (9 lines) at http://paste.koha-community.org/3582 |
| 16:56 |
|
|
ashimema joined #koha |
| 16:56 |
|
|
black23[m] joined #koha |
| 16:56 |
|
|
darkharmony9999[m] joined #koha |
| 16:56 |
|
|
jpahd[m] joined #koha |
| 16:56 |
|
|
manjukaliany[m] joined #koha |
| 16:56 |
|
|
mtj[m] joined #koha |
| 16:56 |
|
|
SlackIntegration[m] joined #koha |
| 16:56 |
|
|
stefanberndtsson[m] joined #koha |
| 16:56 |
|
|
StefanBerndtsson[m]1 joined #koha |
| 16:56 |
|
|
tamirci[m] joined #koha |
| 16:56 |
|
|
Tezcatlipocae-Maya[m] joined #koha |
| 16:56 |
|
|
tubaclarinet[m] joined #koha |
| 16:56 |
|
|
tuxayo joined #koha |
| 16:56 |
|
|
urra[m] joined #koha |
| 16:59 |
|
IGS |
Thank you, oleonard! |
| 17:18 |
|
koha-jenkins |
Project Koha_Master_D12 build #42: ABORTED in 42 min: https://jenkins.koha-community[…]ha_Master_D12/42/ |
| 17:19 |
|
koha-jenkins |
Project Koha_Master build #1779: ABORTED in 35 min: https://jenkins.koha-community[…]Koha_Master/1779/ |
| 17:39 |
|
|
fridolin joined #koha |
| 20:53 |
|
|
alohalog` joined #koha |
| 20:54 |
|
|
mtj joined #koha |
| 21:35 |
|
koha-jenkins |
Project Koha_20.11_D10 build #149: ABORTED in 4 hr 15 min: https://jenkins.koha-community[…]ha_20.11_D10/149/ |
| 22:20 |
|
koha-jenkins |
Project Koha_Master_U21 build #1: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_Master_U21/1/ |
| 22:38 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #285: SUCCESS in 58 min: https://jenkins.koha-community[…]ter_U_Stable/285/ |
