| Time |
S |
Nick |
Message |
| 01:50 |
|
koha-jenkins |
Project Koha_19.11_U2010 build #14: FAILURE in 1 min 7 sec: https://jenkins.koha-community[…]a_19.11_U2010/14/ |
| 01:52 |
|
|
AndrewFH joined #koha |
| 01:56 |
|
koha-jenkins |
Project Koha_19.11_D9 build #325: FAILURE in 10 min: https://jenkins.koha-community[…]oha_19.11_D9/325/ |
| 02:00 |
|
koha-jenkins |
Project Koha_19.11_U16 build #74: ABORTED in 14 min: https://jenkins.koha-community[…]oha_19.11_U16/74/ |
| 02:06 |
|
koha-jenkins |
Project Koha_19.11_D9 build #326: STILL FAILING in 10 min: https://jenkins.koha-community[…]oha_19.11_D9/326/ |
| 02:13 |
|
|
tuxayo-read-only joined #koha |
| 02:16 |
|
koha-jenkins |
Project Koha_19.11_D9 build #327: STILL FAILING in 10 min: https://jenkins.koha-community[…]oha_19.11_D9/327/ |
| 02:24 |
|
|
tuxayo-read-only left #koha |
| 02:26 |
|
koha-jenkins |
Project Koha_19.11_U20 build #217: SUCCESS in 40 min: https://jenkins.koha-community[…]ha_19.11_U20/217/ |
| 02:26 |
|
koha-jenkins |
Project Koha_19.11_U18 build #318: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_19.11_U18/318/ |
| 02:26 |
|
koha-jenkins |
Project Koha_19.11_D9 build #328: STILL FAILING in 10 min: https://jenkins.koha-community[…]oha_19.11_D9/328/ |
| 02:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 02:28 |
|
koha-jenkins |
Project Koha_19.11_D8 build #390: FIXED in 43 min: https://jenkins.koha-community[…]oha_19.11_D8/390/ |
| 02:36 |
|
koha-jenkins |
Project Koha_19.11_D9 build #329: STILL FAILING in 10 min: https://jenkins.koha-community[…]oha_19.11_D9/329/ |
| 02:47 |
|
koha-jenkins |
Project Koha_19.11_D9 build #330: STILL FAILING in 10 min: https://jenkins.koha-community[…]oha_19.11_D9/330/ |
| 03:08 |
|
koha-jenkins |
Project Koha_19.11_D10 build #168: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_19.11_D10/168/ |
| 03:21 |
|
koha-jenkins |
Yippee, build fixed! |
| 03:21 |
|
koha-jenkins |
Project Koha_19.11_D9 build #331: FIXED in 34 min: https://jenkins.koha-community[…]oha_19.11_D9/331/ |
| 03:51 |
|
koha-jenkins |
Project Koha_19.11_D9 build #332: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.11_D9/332/ |
| 04:31 |
|
dcook |
Wow I didn't know that Steve Tonnesen was Canadian |
| 04:32 |
|
dcook |
January 5 2001Steve Tonnesen becomes the 5th committer to Koha and the first outside of Katipo, Koha has 874 commits at this point |
| 05:00 |
|
|
josef_moravec joined #koha |
| 05:03 |
|
tuxayo |
I was 7 years old 😃 |
| 05:06 |
|
|
chriss joined #koha |
| 05:50 |
|
mtj |
folks, how you you start the zebtaidx process again? |
| 06:36 |
|
|
reiveune joined #koha |
| 06:37 |
|
reiveune |
hello |
| 06:47 |
|
|
alex_a joined #koha |
| 06:47 |
|
alex_a |
Bonjour |
| 06:50 |
|
|
lds joined #koha |
| 07:01 |
|
|
cait joined #koha |
| 07:03 |
|
|
cait1 joined #koha |
| 07:04 |
|
|
lmstrandatdesk joined #koha |
| 07:04 |
|
cait1 |
good morning #koha :) |
| 07:20 |
|
magnuse |
ooh, koha is ~21. that probably means we have a number of contributors who weren't born when koha started :-) |
| 07:21 |
|
|
fridolin joined #koha |
| 07:28 |
|
fridolin |
hi thre |
| 07:30 |
|
|
magnuse joined #koha |
| 07:50 |
|
cait1 |
magnuse: I was... |
| 08:14 |
|
huginn |
News from kohagit: Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory <https://git.koha-community.org[…]19b902b9830e4460c> |
| 08:14 |
|
Joubu |
storm is coming |
| 08:21 |
|
koha-jenkins |
Project Koha_Master_D11 build #319: FAILURE in 5 min 13 sec: https://jenkins.koha-community[…]a_Master_D11/319/ |
| 08:23 |
|
cait1 |
hopeflly not |
| 08:26 |
|
cait1 |
Just for info - strings on pootle have been updated already |
| 08:26 |
|
cait1 |
adn 2 bugs for terminology/typos filed ;P |
| 08:28 |
|
ashimema |
cait1, could you varify my comment on bug 28514 |
| 08:28 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28514 enhancement, P5 - low, ---, jonathan.druart+koha, BLOCKED , C4::Letters::getletter must be rewritten |
| 08:28 |
|
ashimema |
I think marcelr has misunderstood the method |
| 08:34 |
|
ashimema |
oh, he's online lots this morning :) |
| 08:35 |
|
ashimema |
marcelr, has your QA day moved this week :) |
| 08:49 |
|
|
marcelr joined #koha |
| 08:49 |
|
marcelr |
hi #koha |
| 08:49 |
|
marcelr |
ashimema around? |
| 08:49 |
|
ashimema |
hi |
| 08:49 |
|
marcelr |
shall i add the patch myself and let you sign ? |
| 08:49 |
|
marcelr |
or did you write it already ? |
| 08:50 |
|
marcelr |
:) |
| 08:51 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #611: STILL UNSTABLE in 33 min: https://jenkins.koha-community[…]9_MDB_Latest/611/ |
| 08:52 |
|
|
RudyW joined #koha |
| 08:53 |
|
ashimema |
I'm happy either way |
| 08:53 |
|
ashimema |
I had an editor open and was part way through the POD update to clarify things ;) |
| 08:53 |
|
ashimema |
I can always add that as a QA followup :) |
| 08:54 |
|
RudyW |
Hi, I am migrating Koha 18 to Koha 21. My opahheader is now not supporting bootstrap elements like <ul class="nav nav-tabs"> any more. How to make the header use bootstrap? |
| 08:56 |
|
marcelr |
ashimema: i will write it, please submit what you have |
| 08:56 |
|
marcelr |
i found another issue in Suggestionts |
| 08:56 |
|
ashimema |
okies.. will submit momentarily.. just commiting |
| 08:57 |
|
marcelr |
hm Suggestions is ok, too quick |
| 08:58 |
|
* ashimema |
needs to add a unit test to that patch |
| 08:58 |
|
koha-jenkins |
Project Koha_Master_U20 build #127: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_U20/127/ |
| 08:59 |
|
ashimema |
I'll write a unit test for 'from_email_address'.. I think it's a useful addition.. we have that fallback pattern in a bunch of places already |
| 09:01 |
|
|
severine_q joined #koha |
| 09:01 |
|
severine_q |
hello #Koha :) |
| 09:04 |
|
Joubu |
RudyW: we switched to Bootstrap v4 |
| 09:04 |
|
severine_q |
is the wonderful trick introduce with bug 14004 supposed to work for "generic" menus only or oor pages refering to id too ? |
| 09:04 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=14004 enhancement, P5 - low, ---, fridolin.somers, Pushed to oldoldstable , Add ability to temporarily disable added CSS and Javascript in OPAC and interface |
| 09:04 |
|
severine_q |
I can't get it work on a patron account for example :/ |
| 09:05 |
|
Joubu |
RudyW: https://getbootstrap.com/docs/[…]onents/navs/#tabs that should work. What problem do you have? |
| 09:06 |
|
Joubu |
severine_q: OPAC? |
| 09:06 |
|
RudyW |
let me check |
| 09:07 |
|
marcelr |
thx ashimema i will have a look |
| 09:09 |
|
marcelr |
ashimema: we should probably throw an exception if from is empty at some point in sending the mail |
| 09:09 |
|
marcelr |
in = before |
| 09:10 |
|
ashimema |
yeah, I think that's a good idea |
| 09:10 |
|
ashimema |
though.. often we don't actually set the from address until just prior to sending |
| 09:11 |
|
ashimema |
at which point it's in a cron.. so throwing an exception could be interesting |
| 09:11 |
|
ashimema |
love unit tests.. just spotted an error in my patch :) |
| 09:12 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #190: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]ter_U_Stable/190/ |
| 09:12 |
|
koha-jenkins |
Project Koha_Master_D10_CPAN build #355: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]ter_D10_CPAN/355/ |
| 09:13 |
|
Joubu |
storm is here, don't pull |
| 09:14 |
|
Joubu |
mtj: around? |
| 09:14 |
|
ashimema |
hmm |
| 09:14 |
|
RudyW |
In my opacheader the tags <div class="container"> <ul class="nav nav-tabs"> do not work. Something must be different. New bootstrap version? |
| 09:14 |
|
ashimema |
queue_notice isn't all that well tested.. I should have noticed that before now :( |
| 09:15 |
|
Joubu |
stupid timezones |
| 09:16 |
|
mtj |
hi Joubu, sort of :) |
| 09:17 |
|
Joubu |
mtj: didn't you tell me the staging repo rebuild every... 5min? |
| 09:17 |
|
ashimema |
marcelr, coming up with a test plan to actually trigger queue_notice and checking for the correct behaviour is fun.. it's currently only used within the holds_reminder cronjob |
| 09:17 |
|
Joubu |
mtj: I've just pushed the lib directory, but now "lib" is missing from PERL5LIB in the apache config |
| 09:18 |
|
Joubu |
mtj: https://debian.koha-community.[…]taging/dists/dev/ last change is from 20210611 |
| 09:18 |
|
Joubu |
maybe I just need to wait a bit more, but I'd like to be sure :) |
| 09:20 |
|
Joubu |
RudyW: we have only one occurrence of nav-tabs in our codebase, sco/sco-main.tt. Have a look there |
| 09:20 |
|
Joubu |
(but maybe it's broken there as well!) |
| 09:20 |
|
RudyW |
opacheader in the 'preview content' is looking ok, but not on the actual page |
| 09:20 |
|
mtj |
Joubu: builds every hour at XX:15 |
| 09:21 |
|
Joubu |
so it should have been triggered 5min ago |
| 09:21 |
|
marcelr |
ashimema: seeing only silent returns |
| 09:22 |
|
marcelr |
but we could warn and make the logs a bit bigger ;) |
| 09:22 |
|
marcelr |
i am touching EnqueueLetter now too |
| 09:23 |
|
ashimema |
yeah.. a warn somewhere would be good.. I have a vague feeling we may already warn in the about page if KohaAdminEmail is missing |
| 09:24 |
|
* ashimema |
goes to try |
| 09:24 |
|
Joubu |
mtj: maybe it's actually not coming from the pkg |
| 09:24 |
|
Joubu |
mtj: there was a change in koha-gitify for that, I pushed it |
| 09:24 |
|
Joubu |
but it's not in the image, maybe ktd images need to be rebuilt |
| 09:24 |
|
ashimema |
seems not |
| 09:25 |
|
marcelr |
yes i saw a reference to kohaadmin there |
| 09:25 |
|
Joubu |
(I thought we git cloned it at startup) |
| 09:25 |
|
marcelr |
but we could warn again for such a vital missing element |
| 09:25 |
|
ashimema |
I agree.. it's not a bad idea :) |
| 09:25 |
|
koha-jenkins |
Project Koha_Master_D9 build #1681: STILL UNSTABLE in 33 min: https://jenkins.koha-community[…]a_Master_D9/1681/ |
| 09:26 |
|
marcelr |
i will add a patch so i have changed status again |
| 09:26 |
|
ashimema |
cool |
| 09:26 |
|
ashimema |
pleasure working with you marcelr.. I love peer coding, collaboration is cool |
| 09:27 |
|
RudyW |
Or some changes with jQuery and that's why <div class="container"> <ul class="nav nav-tabs"> are not working? |
| 09:27 |
|
Joubu |
mtj: ok, I am going to push to ktd to rebuild the images. It should fix the problem. Sorry, false alarm |
| 09:27 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #592: STILL UNSTABLE in 1 hr 10 min: https://jenkins.koha-community[…]aster_D9_My8/592/ |
| 09:28 |
|
marcelr |
ashimema: found a few spots where we could insert your new routine rightaway |
| 09:28 |
|
ashimema |
:) |
| 09:30 |
|
mtj |
Joubu: there is some error with the pkg build, ill fix |
| 09:31 |
|
|
magnuse joined #koha |
| 09:31 |
|
marcelr |
ArticleRequests: warn "can't enqueue letter $letter" becomes can't enqueue letter HASH(0x55edf1806850) which is quite readible |
| 09:32 |
|
ashimema |
oop |
| 09:32 |
|
severine_q |
Joubu : nope, this page for example https://kohapro.bulac.fr/cgi-b[…]orrowernumber=xxx |
| 09:33 |
|
severine_q |
I thought I was because I cant use 2 ? in the same uri and to replace by & but still doesn't work |
| 09:33 |
|
marcelr |
Joubu: i though you fixed all the bugs ? |
| 09:33 |
|
marcelr |
thought |
| 09:33 |
|
Joubu |
severine_q: yes I confirm, but cannot debug right now. fridolin? |
| 09:34 |
|
Joubu |
marcelr: I fixed, but added more later ;) |
| 09:35 |
|
severine_q |
thanks Joubu for checking, i can add a comment on bz i you want |
| 09:35 |
|
severine_q |
*if you want |
| 09:35 |
|
Joubu |
severine_q: yep! |
| 09:36 |
|
fridolin |
Joubu: severine_q sorry busy here |
| 09:37 |
|
severine_q |
oh no prob fridolin ! I completely understand ! |
| 09:37 |
|
severine_q |
I just wanted t obe sure I didn't do something wrong before adding a comment on bz |
| 09:38 |
|
fridolin |
severine_q: which BZ pleas E? |
| 09:38 |
|
severine_q |
bug 14004 |
| 09:38 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=14004 enhancement, P5 - low, ---, fridolin.somers, Pushed to oldoldstable , Add ability to temporarily disable added CSS and Javascript in OPAC and interface |
| 09:39 |
|
fridolin |
severine_q: ah so open a new bug report |
| 09:41 |
|
severine_q |
ok ! thanks for your time :) |
| 09:50 |
|
Joubu |
mtj: it's working with the new ktd images! |
| 09:51 |
|
koha-jenkins |
Project Koha_Master_D11 build #320: ABORTED in 38 min: https://jenkins.koha-community[…]a_Master_D11/320/ |
| 09:51 |
|
koha-jenkins |
Project Koha_Master build #1675: ABORTED in 40 min: https://jenkins.koha-community[…]Koha_Master/1675/ |
| 09:57 |
|
koha-jenkins |
Project Koha_Master build #1676: FAILURE in 5 min 15 sec: https://jenkins.koha-community[…]Koha_Master/1676/ |
| 10:03 |
|
|
RudyW joined #koha |
| 10:03 |
|
RudyW |
How do I change the Athens County logo on the Staff Login page with my own logo? |
| 10:09 |
|
RudyW |
got it: IntranetUserCSS |
| 10:09 |
|
|
khall joined #koha |
| 10:12 |
|
koha-jenkins |
Project Koha_Master build #1677: ABORTED in 11 min: https://jenkins.koha-community[…]Koha_Master/1677/ |
| 10:13 |
|
|
khall joined #koha |
| 10:17 |
|
|
cait joined #koha |
| 10:24 |
|
|
alex_a joined #koha |
| 10:31 |
|
koha-jenkins |
Project Koha_Master build #1678: STILL FAILING in 5 min 12 sec: https://jenkins.koha-community[…]Koha_Master/1678/ |
| 10:40 |
|
mtj |
congrats Joubu  ヽ( ´ ∇ ｀ )ノ |
| 10:51 |
|
Joubu |
well, still failing :D |
| 10:51 |
|
koha-jenkins |
Project Koha_Master build #1679: ABORTED in 13 min: https://jenkins.koha-community[…]Koha_Master/1679/ |
| 10:51 |
|
Joubu |
I missed one occurrence in ktd.. |
| 10:55 |
|
cait |
tuxayo++ |
| 10:56 |
|
cait |
because of your email to koha-translate some translators got in touch with me - so hopefully we can get their permissions fixed now |
| 10:59 |
|
|
AndrewFH joined #koha |
| 11:01 |
|
tuxayo |
cait: great! 😃 |
| 11:11 |
|
|
Dyrcona joined #koha |
| 11:11 |
|
koha-jenkins |
Project Koha_Master build #1680: STILL FAILING in 5 min 16 sec: https://jenkins.koha-community[…]Koha_Master/1680/ |
| 11:19 |
|
Joubu |
tcohen: can you have a look at https://gitlab.com/koha-commun[…]erge_requests/214 please? Is it relevant? |
| 11:20 |
|
|
janPasi joined #koha |
| 11:20 |
|
|
janPasi left #koha |
| 11:31 |
|
|
marcelr joined #koha |
| 11:32 |
|
marcelr |
back |
| 11:37 |
|
Joubu |
https://bugs.koha-community.or[…].cgi?id=28519#c19 |
| 11:37 |
|
huginn |
Bug 28519: enhancement, P5 - low, ---, dcook, Pushed to master , Add a 2nd directory for Perl modules |
| 11:37 |
|
Joubu |
still broken, I have to leave for about 1 hour or 2, will be back to that ASAP |
| 11:50 |
|
|
magnuse joined #koha |
| 11:53 |
|
koha-jenkins |
Project Koha_19.11_U2010 build #15: NOW UNSTABLE in 54 min: https://jenkins.koha-community[…]a_19.11_U2010/15/ |
| 12:10 |
|
koha-jenkins |
Project Koha_Master build #1681: NOW UNSTABLE in 54 min: https://jenkins.koha-community[…]Koha_Master/1681/ |
| 12:12 |
|
|
AndrewFH joined #koha |
| 12:13 |
|
marcelr |
ashimema: i signed off your patch on 28581, if you could do mine? |
| 12:13 |
|
ashimema |
certainly :) |
| 12:15 |
|
tcohen |
morning |
| 12:15 |
|
marcelr |
hola tcohen |
| 12:16 |
|
ashimema |
hmm. I'm not entirely sure about the middle patch marcelr |
| 12:17 |
|
ashimema |
I might be mistaken, but I have a recollection of some calls to EnqueueLetter deliberately not passing from_address and leaving it to _send_message_by_email to pick the correct address? |
| 12:18 |
|
marcelr |
ahh i vaguely recollect |
| 12:18 |
|
marcelr |
let me have a look again |
| 12:18 |
|
ashimema |
also.. remember EnqueueLetter doesn't only queue email notices.. it also enqueues sms, print, phone etc.. not all of those require the from |
| 12:18 |
|
ashimema |
it may well be that all the calls now pass it |
| 12:22 |
|
marcelr |
yeah i will move it to that routine somehow |
| 12:22 |
|
marcelr |
" |
| 12:22 |
|
marcelr |
if initial message address was empty, coming here means that a to address was found and |
| 12:22 |
|
marcelr |
etc |
| 12:22 |
|
ashimema |
:) |
| 12:22 |
|
ashimema |
thanks dude |
| 12:22 |
|
ashimema |
it's certainly a somewhat confusing route the messaging stuff |
| 12:23 |
|
marcelr |
from => $message->{'from_address'} || $branch_email, |
| 12:24 |
|
marcelr |
to_address may be empty ? |
| 12:24 |
|
marcelr |
_update_message_to_address( $message->{'message_id'}, $email->email->header('To') ) |
| 12:25 |
|
marcelr |
we could leave it to the try catch block around sending the mail but it isnt nice? |
| 12:34 |
|
|
Dyrcona joined #koha |
| 12:41 |
|
ashimema |
oop, sorry.. was getting a cuppa |
| 12:42 |
|
tuxayo |
cait1: IIUC, just checking if the suggestions are pilling up and if one of the active people can review them is enough to detect a "stuck language", is that correct? |
| 12:42 |
|
tuxayo |
https://translate.koha-communi[…]g/projects/21.05/ |
| 12:44 |
|
marcelr |
hmm ashimema Leaving to try catch doesnt work; Email:Stuffer now does the dying; think I will still add a test |
| 12:46 |
|
ashimema |
it's a shame this stuff is spread out all over the place so much |
| 12:46 |
|
ashimema |
Koha::Email does a bunch of fallback logic.. as does C4::Letter in various places.. and allot of the calling code does too |
| 12:46 |
|
ashimema |
makes it very difficult to know when each case is actually getting utilised |
| 12:56 |
|
tcohen |
ashimema: the new Koha::Email tried to be an easy replacement for the old one, but the callers need to be reviewed more |
| 12:56 |
|
ashimema |
yup.. i totally understand |
| 12:57 |
|
ashimema |
I think allot of the problem was that people adding code that called EnqueueLetter didn't necessarily read the POD or the code in EnqueuLetter to realise how the addresses fit together |
| 12:57 |
|
ashimema |
there are actually rather few cases where you really need to pass that stuff.. the Enqueu function will usually get it right. |
| 12:57 |
|
tcohen |
the fallbacks in Koha::Email should all respect the current configuration, and overridden locally if required |
| 12:57 |
|
ashimema |
yup |
| 12:58 |
|
ashimema |
Koha::Email is great.. |
| 12:58 |
|
tcohen |
I find the OPAC controller scripts in need of rewrite regarding this |
| 12:58 |
|
ashimema |
I'm just looking at all the callers |
| 12:58 |
|
ashimema |
hell yes |
| 12:59 |
|
ashimema |
in a massive number of cases.. one could really get away with simply passing letter, borrowernumber and message_transport_type |
| 12:59 |
|
ashimema |
all other fields would get filled for you |
| 13:01 |
|
marcelr |
ashimema: submitted changes |
| 13:06 |
|
ashimema |
hmm |
| 13:06 |
|
ashimema |
I think for some cases you can end up here without a patron.. self registration perhaps |
| 13:07 |
|
ashimema |
in that case your code will fail as we don't have defined library to call from_email_address upon ;) |
| 13:07 |
|
ashimema |
sorry dude.. this code if fraught with peril ;) |
| 13:07 |
|
* ashimema |
has been here a few times |
| 13:10 |
|
marcelr |
ashimema: in that case the current code fails exactly the same |
| 13:10 |
|
marcelr |
it already depends on library but only IF from was empty |
| 13:10 |
|
marcelr |
so it also depends on the caller |
| 13:11 |
|
marcelr |
note that we now check from OR branchemail |
| 13:11 |
|
ashimema |
I have a tiny followup that'll resolve that case |
| 13:12 |
|
marcelr |
submit it :) |
| 13:14 |
|
ashimema |
just have |
| 13:14 |
|
ashimema |
I'll continue to review the rest.. any reason you chose the simple cases you did? |
| 13:14 |
|
ashimema |
I can see a few others that seem clear cut to me |
| 13:16 |
|
marcelr |
simple git grep results |
| 13:18 |
|
marcelr |
you dont need + || C4::Context->preference('KohaAdminEmailAddress'); |
| 13:18 |
|
marcelr |
it is already in the from_email_address |
| 13:19 |
|
marcelr |
o wait ignore that |
| 13:19 |
|
ashimema |
:) |
| 13:20 |
|
marcelr |
the whole thing is crazy |
| 13:21 |
|
marcelr |
suppose you could even test on library too (besides patron) |
| 13:22 |
|
marcelr |
if you still need KohaAdminEmail , i would stick to the changed line $message->{'from_address'} || $library->from_email_address; |
| 13:22 |
|
marcelr |
it is too warm |
| 13:23 |
|
marcelr |
thats not true either |
| 13:23 |
|
marcelr |
above 26C |
| 13:24 |
|
marcelr |
if we dont comment this change, the next change will bring regressions surely |
| 13:24 |
|
ashimema |
haha |
| 13:25 |
|
ashimema |
I'll comment it momentarily to make sure it's clear |
| 13:25 |
|
ashimema |
I'm thinking of a general POD update for EnqueueLetter as a start |
| 13:27 |
|
marcelr |
yeah |
| 13:30 |
|
|
AndrewFH joined #koha |
| 13:48 |
|
|
alex_a joined #koha |
| 13:49 |
|
ashimema |
tcohen, kidclamp.. I'm sure bug 28581 would appreciate your QA touch ;) |
| 13:49 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28581 normal, P5 - low, ---, martin.renvoize, Signed Off , Patron's queue_notice uses inbound_email_address incorrectly |
| 13:51 |
|
marcelr |
ashimema: misc/cronjobs/notice_unprocessed_suggestions.pl |
| 13:52 |
|
marcelr |
do you intently leave from now empty ?? |
| 13:52 |
|
|
magnuse joined #koha |
| 13:52 |
|
marcelr |
+ my $admin_email_address = $library->from_email_address |
| 13:52 |
|
marcelr |
no comma at the end |
| 13:52 |
|
marcelr |
in overdue |
| 13:53 |
|
marcelr |
same question for suggestion as for unprocessed sugg |
| 13:53 |
|
marcelr |
from is empty now |
| 13:55 |
|
ashimema |
in both cases they were sending from patron library |
| 13:56 |
|
ashimema |
so we fill from at send time |
| 13:57 |
|
marcelr |
ok then only the ; |
| 13:57 |
|
marcelr |
shall i amend and sign |
| 13:57 |
|
ashimema |
thanks |
| 14:00 |
|
ashimema |
if we displayed 'from' in the patron 'Sent notices for' table then perhaps it's worth filling it as early as possible.. but as we don't I think it's safe to leave it as late as possible to define it.. i.e only pass from where actually necessary.. for example where the context sets it from the item branch instead of the patron branch.. or your sending from a patron to the library or whatever other cases. |
| 14:00 |
|
huginn |
News from kohagit: Bug 28519: Add lib to koha-shell <https://git.koha-community.org[…]a7bce6177260f73e6> |
| 14:00 |
|
ashimema |
in some ways.. I must admit it's tempting in a future rework to dump the fallbacks inside here and require an explicit to and from whenever it's created.. it may well be clearer that way in the end. |
| 14:01 |
|
ashimema |
but I don't think we're there yet |
| 14:01 |
|
marcelr |
thats true |
| 14:02 |
|
marcelr |
when i resolve one bug i always find two new ones |
| 14:04 |
|
ashimema |
haha, yup.. that does appear to be the way |
| 14:04 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #191: FAILURE in 2 min 22 sec: https://jenkins.koha-community[…]ter_U_Stable/191/ |
| 14:05 |
|
Joubu |
yeah, another error, thanks jenkins |
| 14:07 |
|
Joubu |
mtj: Koha_Master/1682 failures are not coming from you |
| 14:08 |
|
Joubu |
mtj: a new build has been triggered with the last push |
| 14:21 |
|
|
collum joined #koha |
| 14:26 |
|
Joubu |
AndrewFH: Are you using D11/bullseye? |
| 14:27 |
|
AndrewFH |
Joubu I must admit I do not know what you mean |
| 14:28 |
|
koha-jenkins |
Project Koha_Master build #1682: STILL UNSTABLE in 56 min: https://jenkins.koha-community[…]Koha_Master/1682/ |
| 14:28 |
|
Joubu |
mtj: https://jenkins.koha-community[…]r_U20/128/console => "HtmlToText: plugin not found". This seems to be coming from you |
| 14:28 |
|
Joubu |
AndrewFH: did you test bug 28271 on koha-testing-docker? |
| 14:28 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28271 normal, P5 - low, ---, jonathan.druart+koha, Failed QA , Add the ability to set a new lost status when a claim is resolved |
| 14:28 |
|
AndrewFH |
yes |
| 14:29 |
|
Joubu |
you need to set KOHA_IMAGE when you run it, to the OS you want to test |
| 14:29 |
|
Joubu |
but you can know with `more /etc/debian_version` from the container |
| 14:29 |
|
Joubu |
D11 is experiencing issues with the REST API, maybe it's what you hit this morning |
| 14:31 |
|
Joubu |
mtj: I confirm that libtemplate-plugin-htmltotext-perl is not installed |
| 14:33 |
|
koha-jenkins |
Project Koha_Master_D11 build #321: NOW UNSTABLE in 32 min: https://jenkins.koha-community[…]a_Master_D11/321/ |
| 14:33 |
|
Joubu |
this day is chaotic |
| 14:36 |
|
AndrewFH |
ahha! ok, will think about that some more |
| 14:44 |
|
Joubu |
AndrewFH: it's bug 28586 |
| 14:44 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28586 major, P5 - low, ---, koha-bugs, NEW , Cannot resolve a claim |
| 14:44 |
|
Joubu |
tcohen: ^ |
| 14:45 |
|
tcohen |
I'll take care |
| 14:47 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #612: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]9_MDB_Latest/612/ |
| 14:51 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #192: STILL FAILING in 4 min 4 sec: https://jenkins.koha-community[…]ter_U_Stable/192/ |
| 14:52 |
|
fridolin |
see u |
| 14:52 |
|
|
fridolin left #koha |
| 14:56 |
|
koha-jenkins |
Project Koha_Master_U20 build #128: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_U20/128/ |
| 15:05 |
|
koha-jenkins |
Project Koha_Master_D9 build #1682: STILL UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]a_Master_D9/1682/ |
| 15:10 |
|
Joubu |
when I was saying that the storm was coming this morning, I was not expecting a real one, there is a flood!.. |
| 15:10 |
|
ashimema |
oh dear |
| 15:14 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #593: STILL UNSTABLE in 1 hr 12 min: https://jenkins.koha-community[…]aster_D9_My8/593/ |
| 15:14 |
|
reiveune |
bye |
| 15:14 |
|
|
reiveune left #koha |
| 15:16 |
|
koha-jenkins |
Project Koha_Master_D10_CPAN build #356: STILL UNSTABLE in 48 min: https://jenkins.koha-community[…]ter_D10_CPAN/356/ |
| 15:30 |
|
koha-jenkins |
Project Koha_Master_D10_CPAN build #357: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]ter_D10_CPAN/357/ |
| 15:31 |
|
Joubu |
@later tell mtj tldr; forget everything but the libtemplate-plugin-htmltotext-perl bit: it's not pulled and some tests are failing (and sending basket/list is broken) |
| 15:31 |
|
huginn |
Joubu: The operation succeeded. |
| 15:32 |
|
cait1 |
tuxayo: about stuck languages - yes and no |
| 15:32 |
|
cait1 |
tuxayo: lots of suggestions can also be added by uploading files |
| 15:32 |
|
cait1 |
if a translator works offline |
| 15:32 |
|
cait1 |
it's a first indicator, but not a perfect clue |
| 15:35 |
|
|
Lorna joined #koha |
| 15:35 |
|
Lorna |
hi everyone, i am trying to calculate the statistics of how many users logged in per day, or month, but i am not finding the correct sql query. someone did it or can guide me how to do it. thanks a lot! |
| 15:37 |
|
ashimema |
@later tall rangi do you know how the kudos.json file is created for the dashboard.. I can't see how it works from the dashboard code.. perhaps a cronjob or something in the background on the server? |
| 15:37 |
|
huginn |
ashimema: I'll give you the answer just as soon as RDA is ready |
| 15:37 |
|
ashimema |
@later tell rangi do you know how the kudos.json file is created for the dashboard.. I can't see how it works from the dashboard code.. perhaps a cronjob or something in the background on the server? |
| 15:37 |
|
huginn |
ashimema: The operation succeeded. |
| 15:39 |
|
ashimema |
@later tell rangi Joubu pointed me to the repo now.. just trying to work out why it's not there on dashboard live right now. |
| 15:39 |
|
huginn |
ashimema: The operation succeeded. |
| 16:09 |
|
koha-jenkins |
Project Koha_Master build #1683: STILL UNSTABLE in 53 min: https://jenkins.koha-community[…]Koha_Master/1683/ |
| 16:53 |
|
|
AndrewFH joined #koha |
| 16:57 |
|
|
JesseM_ joined #koha |
| 17:21 |
|
|
cait1 left #koha |
| 17:45 |
|
|
cait joined #koha |
| 17:47 |
|
|
Lorna joined #koha |
| 17:47 |
|
Lorna |
[12:35] <Lorna> hi everyone, i am trying to calculate the statistics of how many users logged in per day, or month, but i am not finding the correct sql query. someone did it or can guide me how to do it. thanks a lot! |
| 17:58 |
|
|
khall joined #koha |
| 18:58 |
|
tuxayo |
Lorna: |
| 18:58 |
|
tuxayo |
hi :) |
| 18:58 |
|
tuxayo |
https://wiki.koha-community.or[…]L_Reports_Library |
| 18:58 |
|
tuxayo |
https://wiki.koha-community.or[…]L_Reports_Library |
| 18:59 |
|
tuxayo |
You should find some stuff in these huge SQL query libraries |
| 19:00 |
|
tuxayo |
cait: thanks for the details. It's hard to tell if there is an issue :( |
| 19:00 |
|
tuxayo |
Same as with translating an old version and loosing stuff as the major release happen. |
| 19:39 |
|
|
josef_moravec1 joined #koha |
| 19:43 |
|
Lorna |
tuxayo> thank you! |
| 20:22 |
|
koha-jenkins |
Project Koha_20.05_U20 build #332: SUCCESS in 29 min: https://jenkins.koha-community[…]ha_20.05_U20/332/ |
| 20:31 |
|
koha-jenkins |
Project Koha_20.05_U2010 build #198: SUCCESS in 40 min: https://jenkins.koha-community[…]_20.05_U2010/198/ |
| 20:31 |
|
koha-jenkins |
Project Koha_20.05_D11 build #684: UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_20.05_D11/684/ |
| 20:43 |
|
koha-jenkins |
Project Koha_20.05_D9 build #297: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_20.05_D9/297/ |
| 20:48 |
|
koha-jenkins |
Project Koha_20.05_U16 build #302: SUCCESS in 54 min: https://jenkins.koha-community[…]ha_20.05_U16/302/ |
| 20:49 |
|
koha-jenkins |
Project Koha_20.05_D10 build #301: SUCCESS in 52 min: https://jenkins.koha-community[…]ha_20.05_D10/301/ |
| 20:51 |
|
tuxayo |
A test failure due to http://swagger.io/v2/schema.json not being available. Wasn't that dependency fixed? |
| 20:51 |
|
* tuxayo |
digs |
| 20:52 |
|
tuxayo |
ho bug 23653 wasn't backported to 20.05.x |
| 20:52 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=23653 major, P5 - low, ---, dcook, RESOLVED FIXED, Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing |
| 21:05 |
|
|
AndrewFH joined #koha |
| 21:12 |
|
koha-jenkins |
Project Koha_20.05_U18 build #169: SUCCESS in 1 hr 19 min: https://jenkins.koha-community[…]ha_20.05_U18/169/ |
| 23:38 |
|
koha-jenkins |
Project Koha_Master build #1684: ABORTED in 2 min 50 sec: https://jenkins.koha-community[…]Koha_Master/1684/ |
