| Time |
S |
Nick |
Message |
| 00:49 |
|
koha-jenkins |
Project Koha_Master build #1685: STILL UNSTABLE in 54 min: https://jenkins.koha-community[…]Koha_Master/1685/ |
| 01:08 |
|
mtj |
hi Joubu, libtemplate-plugin-htmltotext-perl is fixed now |
| 01:09 |
|
mtj |
master builds look happier -> https://jenkins.koha-community[…]Build/testReport/ |
| 01:17 |
|
|
AndrewFH joined #koha |
| 01:18 |
|
koha-jenkins |
Yippee, build fixed! |
| 01:18 |
|
koha-jenkins |
Project Koha_Master_D11 build #322: FIXED in 1 hr 6 min: https://jenkins.koha-community[…]a_Master_D11/322/ |
| 01:58 |
|
|
AndrewFH joined #koha |
| 02:12 |
|
|
AndrewFH joined #koha |
| 02:24 |
|
|
AndrewFH joined #koha |
| 02:51 |
|
|
AndrewFH joined #koha |
| 03:29 |
|
|
AndrewFH joined #koha |
| 03:46 |
|
mtj |
Joubu: master fixed ^ |
| 05:20 |
|
koha-jenkins |
Yippee, build fixed! |
| 05:20 |
|
koha-jenkins |
Project Koha_Master_U20 build #129: FIXED in 47 min: https://jenkins.koha-community[…]a_Master_U20/129/ |
| 05:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 05:28 |
|
koha-jenkins |
Project Koha_Master build #1686: FIXED in 55 min: https://jenkins.koha-community[…]Koha_Master/1686/ |
| 05:29 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #193: NOW UNSTABLE in 55 min: https://jenkins.koha-community[…]ter_U_Stable/193/ |
| 05:54 |
|
|
janPasi joined #koha |
| 06:02 |
|
|
sophie_m joined #koha |
| 06:02 |
|
koha-jenkins |
Yippee, build fixed! |
| 06:02 |
|
koha-jenkins |
Project Koha_Master_D9 build #1683: FIXED in 1 hr 29 min: https://jenkins.koha-community[…]a_Master_D9/1683/ |
| 06:11 |
|
|
marcelr joined #koha |
| 06:11 |
|
marcelr |
hi #koha |
| 06:30 |
|
|
fridolin joined #koha |
| 06:33 |
|
fridolin |
hi thre |
| 06:44 |
|
|
reiveune joined #koha |
| 06:44 |
|
reiveune |
hello |
| 06:44 |
|
|
alex_a joined #koha |
| 06:45 |
|
alex_a |
Bonjour |
| 06:57 |
|
marcelr |
hi fridolin alex_a reiveune |
| 06:59 |
|
ashimema |
morning |
| 07:00 |
|
|
lds joined #koha |
| 07:00 |
|
|
cait joined #koha |
| 07:02 |
|
|
cait1 joined #koha |
| 07:02 |
|
marcelr |
hi ashimema cait1 |
| 07:03 |
|
* ashimema |
is finally trying to wrap his head around 'alert/error/messages' again so he can finally write that guidelines that's been promised on the last however many dev meetings.. |
| 07:03 |
|
ashimema |
seems we have a few rather similar ways of doing it :( |
| 07:03 |
|
ashimema |
... |
| 07:04 |
|
ashimema |
Koha::Object::Messages.. but that's vaguely different.. then direct in template.. and finally with loads of cases of 'push @messages, { type => 'alert', code => 'does_not_exist' }' type controller code (or even module code) |
| 07:04 |
|
ashimema |
be nice to ratify that lot |
| 07:06 |
|
* cait1 |
waves |
| 07:06 |
|
cait1 |
marcelr: hi marcel, how are yo doing? |
| 07:08 |
|
marcelr |
fine cait1 |
| 07:13 |
|
marcelr |
hmm new(): failed: couldn't load CGI::Session::Serialize::yamlxs: Can't locate CGI/Session/Serialize/yamlxs.pm in @INC |
| 07:14 |
|
marcelr |
missing the lib path ? |
| 07:16 |
|
ashimema |
Isn't that what David's patch did |
| 07:16 |
|
ashimema |
Add lib to the post |
| 07:16 |
|
ashimema |
Path... Even |
| 07:17 |
|
ashimema |
Bug 28519 |
| 07:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28519 enhancement, P5 - low, ---, dcook, Pushed to master , Add a 2nd directory for Perl modules |
| 07:17 |
|
dcook |
ashimema: In theory |
| 07:17 |
|
dcook |
Where's the issue? |
| 07:18 |
|
* dcook |
is trying to get out of the office but curious |
| 07:18 |
|
ashimema |
Pass, marcelr just brought it up |
| 07:18 |
|
ashimema |
Nice to see you dcook.. been s little while :) |
| 07:18 |
|
ashimema |
Have a great evening |
| 07:19 |
|
dcook |
marcelr: Is this a dev environment? |
| 07:19 |
|
dcook |
nice to see you too ashimema |
| 07:19 |
|
dcook |
Life's just been hectic lately |
| 07:19 |
|
Joubu |
mtj: what happened with the missing pkg? |
| 07:19 |
|
dcook |
Hoping maybe from July onwards that I'll be more active |
| 07:20 |
|
Joubu |
marcelr: are you using ktd? |
| 07:20 |
|
|
cait joined #koha |
| 07:20 |
|
Joubu |
marcelr: you need the latest ktd images |
| 07:21 |
|
Joubu |
if you are not using ktd you need to adjust the PERL5LIB (apache config and, certainly, your bashrc) |
| 07:21 |
|
ashimema |
Sans here dcook, I'm way behind on Koha stuff right now.. friends and code |
| 07:21 |
|
marcelr |
dcook: yes |
| 07:22 |
|
marcelr |
i am updating apache-shared now and koha-functions |
| 07:22 |
|
ashimema |
That's gonna be fun come upgrades.. |
| 07:22 |
|
ashimema |
Did we add something into the makefile to try and update that PERL5LIB? |
| 07:22 |
|
dcook |
ashimema: Yep |
| 07:22 |
|
marcelr |
there goes my qa morning :) |
| 07:22 |
|
dcook |
marcelr: Is it ktd or not? |
| 07:23 |
|
marcelr |
no |
| 07:23 |
|
dcook |
Ahh |
| 07:23 |
|
marcelr |
its my own dev container |
| 07:23 |
|
Joubu |
marcelr: There is a change in koha-shell needed, see the last patch in master |
| 07:23 |
|
dcook |
Do a "make upgrade" for your dev install |
| 07:23 |
|
ashimema |
Excellent |
| 07:23 |
|
ashimema |
We have a few Dev and standard installs still knocking around |
| 07:23 |
|
dcook |
ashimema / marcelr: If you've done a custom Apache config, you'll need to do a custom one |
| 07:23 |
|
dcook |
Or get the latest koha-gitify |
| 07:23 |
|
marcelr |
i will fix it; but it always comes on a bad time |
| 07:23 |
|
dcook |
marcelr: Story of my life heh |
| 07:24 |
|
ashimema |
Lol |
| 07:24 |
|
dcook |
ashimema: We're aggressively moving away from ours |
| 07:25 |
|
ashimema |
I've tried a number of times.. all we seem to end up doing is becoming even more fragmented with our install types. |
| 07:25 |
|
dcook |
While web servers are great, generating config for them suucks |
| 07:25 |
|
dcook |
Noo that's no good |
| 07:25 |
|
dcook |
At this point, we're basically Debian package or get out |
| 07:25 |
|
dcook |
Running across multiple versions of Debian and Ubuntu though |
| 07:26 |
|
ashimema |
Now it's a mix of package for those without customisation and standard for those with.. Dev is only me at that point.. I use ktd and a local Dev install for some reason.. habbit I guess |
| 07:26 |
|
marcelr |
distributed risk by various installation types :) |
| 07:26 |
|
dcook |
I used to use the standard install to build a RPM package, but moved away from that too (even if I vastly prefer RPM packaging over DEB packaging) |
| 07:27 |
|
dcook |
I technically still have a local dev install, but I've been moving everything to ktd. I don't really use the local dev install anymore (and by anymore I mean like the past few weeks lol) |
| 07:27 |
|
ashimema |
We still have too many customisations.. they get submitted upstream but often take a number of cycles to get in... Customers need them 'NOW' |
| 07:27 |
|
dcook |
I do maintain a few different packages though.. |
| 07:27 |
|
dcook |
Yeah I hear ya |
| 07:27 |
|
dcook |
I'm working on localized versions of 15565 and 15516 because it's just too slow |
| 07:28 |
|
dcook |
Also Koha community quality is higher than local. Like we know the configuration of the local environment and that it will work there |
| 07:28 |
|
dcook |
Don't have to take into account as many permutations.. |
| 07:28 |
|
* dcook |
glares at holds/reserves |
| 07:28 |
|
dcook |
Actually, I think I package all my software for all my many many projects |
| 07:28 |
|
dcook |
Use automated builds where possible.. |
| 07:28 |
|
* dcook |
still wants to automate more things |
| 07:28 |
|
dcook |
And upstream more things.. |
| 07:28 |
|
* dcook |
sends another patch to Koha |
| 07:29 |
|
ashimema |
Yeah, know the feeling |
| 07:29 |
|
dcook |
It's 5:30pm on a Friday. What's wrong with me? haha |
| 07:29 |
|
ashimema |
My brain ran out of capacity for building lots of packages |
| 07:29 |
|
cait1 |
we have one package for all the installations -but it has some small customizations, thankfully nothing that's really heavy |
| 07:29 |
|
marcelr |
dcook slow down |
| 07:29 |
|
marcelr |
we cannot catch up with your stuff |
| 07:29 |
|
ashimema |
And I never got round to automating it.. hence the switch back to standard installs |
| 07:30 |
|
ashimema |
Hate to say it, but I must admit I used to find the Dev install the easiest to work with.. still find that allot of the time.. but I general it's not really well supported in community these days... Packages are certainly the first class citizen and everything else suffers |
| 07:31 |
|
ashimema |
Ooh, school run in a moment... In the pooring rain |
| 07:31 |
|
dcook |
ashimema: You could check out my gitlab. I have a Docker-based package builder. It works quite nicely. I can fire off multiple commands to build multiple versions in parallel. |
| 07:31 |
|
dcook |
marcelr: heh |
| 07:31 |
|
dcook |
good luck ashimema |
| 07:32 |
|
ashimema |
Tcohen has something very similar I think |
| 07:32 |
|
ashimema |
You guys should collaborate ;) |
| 07:33 |
|
Joubu |
koha-dpkg-docker |
| 07:35 |
|
Joubu |
cait1: do you know how the status change (from "pushed to master" to "close") was done by Chris? |
| 07:35 |
|
cait1 |
it was done by me - but rangi turned off the email for it |
| 07:35 |
|
cait1 |
i marked it on Taiga |
| 07:35 |
|
cait1 |
any problem? |
| 07:36 |
|
Joubu |
things need to be backported |
| 07:36 |
|
Joubu |
" The bug is 'Pushed to master' or 'Pushed to stable' and was not touched in the last 3 months (changed between x and y days) => RESOLVED FIXED " |
| 07:36 |
|
Joubu |
ok, make sense |
| 07:37 |
|
dcook |
ashimema: I've gone a different route from the koha-dpkg-docker. I like mine better :p |
| 07:37 |
|
Joubu |
just saw bug 23653, but it has been forgotten by rmaint |
| 07:37 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=23653 major, P5 - low, ---, dcook, REOPENED , Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing |
| 07:37 |
|
dcook |
Anyway, I have to run |
| 07:37 |
|
dcook |
Hoping you all have a good Friday |
| 07:40 |
|
Joubu |
Enjoy your weekend, dcook |
| 07:41 |
|
marcelr |
get away from your laptop hahaha |
| 07:46 |
|
cait1 |
Joubu: this one is probably a bit of a hard one yes... I assumed 3 months was enouhg |
| 07:48 |
|
Joubu |
yes, that should be enough! |
| 07:49 |
|
cait1 |
ok, but let me know if you have a suggestion to change it, it's all ont he wiki, was about to post you the link, but you already had quoted it :) |
| 08:20 |
|
|
cait joined #koha |
| 08:23 |
|
koha-jenkins |
Project Koha_19.11_U16 build #75: ABORTED in 20 min: https://jenkins.koha-community[…]oha_19.11_U16/75/ |
| 08:26 |
|
|
davidnind joined #koha |
| 09:37 |
|
koha-jenkins |
Project Koha_19.11_U16 build #76: ABORTED in 56 min: https://jenkins.koha-community[…]oha_19.11_U16/76/ |
| 09:47 |
|
Joubu |
marcelr: looks like I forgot to run add_missing_filters.pl on bug 27526, sorry about that |
| 09:47 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27526 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Remove Mod/AddItemFromMarc from additem.pl |
| 09:48 |
|
marcelr |
additem is certainly a nightmare |
| 09:52 |
|
marcelr |
I still do not like this warn: DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /usr/share/koha/Koha/Objects.pm line 210 |
| 09:53 |
|
marcelr |
See bug 28561 |
| 09:53 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28561 normal, P5 - low, ---, m.de.rooy, In Discussion , Order_by triggers a DBIx warning Unable to properly collapse has_many results |
| 09:55 |
|
Joubu |
marcelr: can you cc me please? I wasn't aware of it |
| 09:55 |
|
marcelr |
it is an old warn already |
| 09:55 |
|
marcelr |
from opac-shelves |
| 10:14 |
|
koha-jenkins |
Project Koha_19.11_U16 build #77: FAILURE in 2 min 20 sec: https://jenkins.koha-community[…]oha_19.11_U16/77/ |
| 10:16 |
|
|
khall joined #koha |
| 10:28 |
|
|
cait joined #koha |
| 10:54 |
|
|
davidnind left #koha |
| 10:58 |
|
|
khall joined #koha |
| 11:03 |
|
|
khall joined #koha |
| 11:13 |
|
koha-jenkins |
Project Koha_21.05_U16 build #4: SUCCESS in 33 min: https://jenkins.koha-community[…]Koha_21.05_U16/4/ |
| 11:20 |
|
koha-jenkins |
Project Koha_21.05_U18 build #4: SUCCESS in 40 min: https://jenkins.koha-community[…]Koha_21.05_U18/4/ |
| 11:23 |
|
|
AndrewFH joined #koha |
| 11:24 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #5: ABORTED in 44 min: https://jenkins.koha-community[…]21.05_U_Stable/5/ |
| 11:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 11:28 |
|
koha-jenkins |
Project Koha_19.11_U16 build #78: FIXED in 1 hr 0 min: https://jenkins.koha-community[…]oha_19.11_U16/78/ |
| 11:29 |
|
koha-jenkins |
Project Koha_19.11_U16 build #79: SUCCESS in 59 min: https://jenkins.koha-community[…]oha_19.11_U16/79/ |
| 11:29 |
|
koha-jenkins |
Project Koha_21.05_U20 build #5: SUCCESS in 50 min: https://jenkins.koha-community[…]Koha_21.05_U20/5/ |
| 11:29 |
|
koha-jenkins |
Project Koha_21.05_U20 build #6: FAILURE in 4 min 43 sec: https://jenkins.koha-community[…]Koha_21.05_U20/6/ |
| 11:29 |
|
magnuse |
anyone else getting a login-screen followed by an internal server error when paying through an opac online payment plugin? started happening to us after upgrading to 20.11. looks like the CGISESSID cookie changes it's value, forcing the login screen |
| 11:30 |
|
|
fridolin joined #koha |
| 11:31 |
|
|
enkidu joined #koha |
| 11:32 |
|
magnuse |
bug 28592 |
| 11:32 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28592 major, P5 - low, ---, oleonard, NEW , ISE after paying through opac payment plugin |
| 11:35 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #6: FAILURE in 2 min 44 sec: https://jenkins.koha-community[…]21.05_U_Stable/6/ |
| 11:47 |
|
koha-jenkins |
Project Koha_21.05_D9 build #5: SUCCESS in 33 min: https://jenkins.koha-community[…]/Koha_21.05_D9/5/ |
| 11:54 |
|
|
janPasi joined #koha |
| 11:58 |
|
koha-jenkins |
Project Koha_21.05_D11 build #12: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]oha_21.05_D11/12/ |
| 12:01 |
|
koha-jenkins |
Project Koha_21.05_D11 build #13: FAILURE in 3 min 35 sec: https://jenkins.koha-community[…]oha_21.05_D11/13/ |
| 12:05 |
|
koha-jenkins |
Project Koha_21.05_U20 build #7: STILL FAILING in 3 min 18 sec: https://jenkins.koha-community[…]Koha_21.05_U20/7/ |
| 12:16 |
|
koha-jenkins |
Project Koha_21.05_U18 build #5: FAILURE in 46 min: https://jenkins.koha-community[…]Koha_21.05_U18/5/ |
| 12:16 |
|
koha-jenkins |
Project Koha_21.05_U18 build #6: STILL FAILING in 29 min: https://jenkins.koha-community[…]Koha_21.05_U18/6/ |
| 12:18 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #7: STILL FAILING in 2 min 38 sec: https://jenkins.koha-community[…]21.05_U_Stable/7/ |
| 12:20 |
|
koha-jenkins |
Project Koha_21.05_D9 build #6: FAILURE in 2 min 3 sec: https://jenkins.koha-community[…]/Koha_21.05_D9/6/ |
| 12:25 |
|
koha-jenkins |
Project Koha_21.05_U16 build #5: SUCCESS in 56 min: https://jenkins.koha-community[…]Koha_21.05_U16/5/ |
| 12:25 |
|
koha-jenkins |
Project Koha_21.05_U16 build #6: FAILURE in 9 min 38 sec: https://jenkins.koha-community[…]Koha_21.05_U16/6/ |
| 12:32 |
|
tcohen |
morning |
| 12:38 |
|
|
koha-jenkins joined #koha |
| 12:43 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #8: STILL FAILING in 4 min 23 sec: https://jenkins.koha-community[…]21.05_U_Stable/8/ |
| 13:03 |
|
Joubu |
khall: to move atomicupdate files, you can use the script from bug 27903. |
| 13:03 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27903 enhancement, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Script to move atomic updates to updatedatabase.pl |
| 13:04 |
|
Joubu |
it will automatically move the content to updatedatabase.pl, adjust the Koha version, and commit the changes |
| 13:10 |
|
fridolin |
Bug 27850 is willing to be in usage, looks for a QA ;) |
| 13:10 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27850 enhancement, P5 - low, ---, fridolin.somers, Signed Off , Search link for 260 a and c in MARC21 XSLT display |
| 13:10 |
|
|
mihai joined #koha |
| 13:15 |
|
koha-jenkins |
Project Koha_21.05_U18 build #7: NOW UNSTABLE in 35 min: https://jenkins.koha-community[…]Koha_21.05_U18/7/ |
| 13:22 |
|
koha-jenkins |
Project Koha_21.05_D11 build #15: NOW UNSTABLE in 39 min: https://jenkins.koha-community[…]oha_21.05_D11/15/ |
| 13:30 |
|
|
khall joined #koha |
| 13:45 |
|
koha-jenkins |
Project Koha_21.05_U16 build #7: NOW UNSTABLE in 1 hr 6 min: https://jenkins.koha-community[…]Koha_21.05_U16/7/ |
| 13:56 |
|
khall |
Joubu thanks! |
| 13:59 |
|
magnuse |
this is just about the weirdest thing i have seen so far. if i try to pu this into intranetuserjs i get "internal server error, please reload the page": $('#patron_attr_1').parent().insertBefore('li label[for="dateofbirth"]'); |
| 14:00 |
|
magnuse |
the log says [Fri Jun 18 15:57:48.525159 2021] [proxy_http:error] [pid x] (70008)Partial results are valid but processing is incomplete: [client x.x.x.x:60112] AH01095: prefetch request body failed to 0.0.0.0:0 (httpd-UDS) from x.x.x.x (), referer: https://<intranet>/cgi-bin/koha/admin/preferences.pl?tab=staff_interface |
| 14:00 |
|
magnuse |
but if iremove the equals sign (=) it works! |
| 14:01 |
|
magnuse |
and with that gem i bid y'all a nice weekend! |
| 14:08 |
|
ashimema |
Oh, 27903 looks cool |
| 14:08 |
|
koha-jenkins |
Project Koha_21.05_D9 build #7: NOW UNSTABLE in 1 hr 30 min: https://jenkins.koha-community[…]/Koha_21.05_D9/7/ |
| 14:10 |
|
|
koha-jenkins joined #koha |
| 14:16 |
|
koha-jenkins |
Project Koha_21.05_U20 build #9: STILL FAILING in 5 min 11 sec: https://jenkins.koha-community[…]Koha_21.05_U20/9/ |
| 14:34 |
|
|
AndrewFH joined #koha |
| 14:42 |
|
Joubu |
thanks ashimema, happy to see those easy ones not stuck for months :) |
| 14:42 |
|
ashimema |
:) |
| 14:42 |
|
ashimema |
pleasure |
| 14:43 |
|
ashimema |
I don't think they'll sit long in the QA queue.. I just wanted a second pair of eyes to agree with the change.. looks great to me. |
| 14:43 |
|
ashimema |
Nick or Tomas I'm sure will pick it up asap :) |
| 14:43 |
|
ashimema |
bug 28589 looks nice too.. i wondered if someone might suggest it :() |
| 14:43 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28589 enhancement, P5 - low, ---, koha-bugs, In Discussion , Move C4 and Koha to lib |
| 14:43 |
|
ashimema |
:) |
| 14:44 |
|
* ashimema |
wonders if bug 27903 aught to be in the dev tools repo.. |
| 14:44 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27903 enhancement, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Script to move atomic updates to updatedatabase.pl |
| 14:44 |
|
ashimema |
or should be NSO to get into koha proper?.. |
| 14:45 |
|
ashimema |
would be nice to not loose it in bugzilla obscurity? |
| 14:45 |
|
Joubu |
I have it in misc/devel and in .git/info/exclude |
| 14:45 |
|
koha-jenkins |
Project Koha_21.05_U18 build #8: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]Koha_21.05_U18/8/ |
| 14:45 |
|
Joubu |
but happy to put it wherever you think it would be useful |
| 14:45 |
|
ashimema |
though actually.. we're still looking at shaking up updatedatebase dramatically aren't we |
| 14:45 |
|
Joubu |
yes |
| 14:45 |
|
Joubu |
well, hopefully |
| 14:46 |
|
ashimema |
so perhaps I'm being a bit prior... especially as at the minute.. as I'm neither an RM or RMaint it doesn't really affect me.. :) |
| 14:46 |
|
ashimema |
it's just nice to see you wrote it. |
| 14:47 |
|
Joubu |
ashimema: I sent en email to rmaints about it already, no idea if they are using it |
| 14:47 |
|
Joubu |
nobody else should need it |
| 14:47 |
|
reiveune |
bye |
| 14:47 |
|
ashimema |
indeed |
| 14:47 |
|
|
reiveune left #koha |
| 14:47 |
|
Joubu |
but yeah, after bug 25078 would be better anyway |
| 14:47 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=25078 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Update DB process - wrap each DBRev inside a transaction and better error handling |
| 14:48 |
|
ashimema |
well.. I have another hour left of my day before the weekend.. |
| 14:48 |
|
ashimema |
thought I might take another look at 25078 to go out on a high :S |
| 14:57 |
|
koha-jenkins |
Project Koha_21.05_D11 build #16: STILL UNSTABLE in 47 min: https://jenkins.koha-community[…]oha_21.05_D11/16/ |
| 15:01 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #9: ABORTED in 44 min: https://jenkins.koha-community[…]21.05_U_Stable/9/ |
| 15:04 |
|
koha-jenkins |
Project Koha_21.05_U18 build #9: FAILURE in 3 min 23 sec: https://jenkins.koha-community[…]Koha_21.05_U18/9/ |
| 15:08 |
|
koha-jenkins |
Project Koha_21.05_U16 build #8: STILL UNSTABLE in 57 min: https://jenkins.koha-community[…]Koha_21.05_U16/8/ |
| 15:10 |
|
ashimema |
ooh, that's moved a fair bit since I last looked |
| 15:16 |
|
koha-jenkins |
Project Koha_21.05_U20 build #10: NOW UNSTABLE in 30 min: https://jenkins.koha-community[…]oha_21.05_U20/10/ |
| 15:17 |
|
Joubu |
thx ashimema! Enjoy, it's a fun one to test :) |
| 15:18 |
|
Joubu |
see you next week, #koha! |
| 15:18 |
|
ashimema |
I'm also now trying to wrap my brain around jajm's alternative.. which is now not alternative but a subsequent change.. right? |
| 15:18 |
|
ashimema |
or are they still alternatives? |
| 15:22 |
|
Joubu |
jajm's version is removing the version and relying on the DB to know what has been executed |
| 15:22 |
|
Joubu |
it's something else |
| 15:22 |
|
Joubu |
we should go first with my version IMO |
| 15:23 |
|
Joubu |
and then discuss if we want to go further |
| 15:23 |
|
Joubu |
but we will need to split the file anyway, the sooner the better |
| 15:25 |
|
ashimema |
yes |
| 15:25 |
|
ashimema |
I see now |
| 15:26 |
|
ashimema |
updatedatabase has become massive |
| 15:29 |
|
|
fridolin left #koha |
| 15:32 |
|
ashimema |
I think I like jajm's $report stuff.. somehow it feels a bit cleaner |
| 15:38 |
|
|
cait joined #koha |
| 15:38 |
|
ashimema |
report is always printed after description right.. never before |
| 15:39 |
|
ashimema |
I think I like that... we don't offer any way for end users to opt in/out of a update.. so no real reason to not just report after the fact |
| 15:40 |
|
ashimema |
'about to update 8 million lines' vs 'updated 8 million lines'.. the former might be useful to know before the update proceeds.. so know if it's likely to take ages. |
| 15:40 |
|
ashimema |
but.. I digress. |
| 15:40 |
|
koha-jenkins |
Project Koha_21.05_D9 build #8: STILL UNSTABLE in 1 hr 30 min: https://jenkins.koha-community[…]/Koha_21.05_D9/8/ |
| 15:41 |
|
koha-jenkins |
Project Koha_21.05_D11 build #17: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]oha_21.05_D11/17/ |
| 15:41 |
|
ashimema |
so.. with this approach we leave updatedatabase 'as-is' for updates to date right.. |
| 15:41 |
|
ashimema |
it's just all new updates that take the new route |
| 15:41 |
|
ashimema |
hence the re-introduction of NewVersion etc |
| 15:42 |
|
ashimema |
right? |
| 15:43 |
|
ashimema |
also.. |
| 15:43 |
|
ashimema |
the force param you can pass to updatedatabase Joubu |
| 15:44 |
|
ashimema |
I sort of wonder if it might be useful to have a force_first as an alternative.. |
| 15:45 |
|
ashimema |
I could imagine someone wanting to force through the first error but want subsequent ones to kill the upgrade again. |
| 15:45 |
|
ashimema |
in that way you could step through and fix/ignore each one |
| 15:45 |
|
ashimema |
rather than hit one. force it and accidently force all? |
| 15:48 |
|
jajm |
or --force=VERSION (or --force=FILENAME) ? |
| 15:50 |
|
ashimema |
sounds like a good option |
| 15:51 |
|
ashimema |
I imagine cases where you have a list of db optimisations you know will make certain updates fail in non-critical ways.. once you know your list, passing that list of names in subsequent upgrades could be great. |
| 15:51 |
|
ashimema |
save getting stopped at each step.. |
| 15:52 |
|
ashimema |
but at the same time getting stopped for unexpected ones is a positive in my book |
| 15:52 |
|
ashimema |
cool :) |
| 15:52 |
|
ashimema |
I've just commented on the bug to show my support again.. I'm not entirely sure how to progress it though.. |
| 15:52 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #10: ABORTED in 44 min: https://jenkins.koha-community[…]1.05_U_Stable/10/ |
| 15:53 |
|
ashimema |
I can test and SO of course.. but is that actually where we're at.. or should we make the decision to add in your report commit as at least 2 of us now agree it feels cleaner? |
| 15:54 |
|
* ashimema |
hasn't seen $fh->say() syntax for a while.. took me a quick double take |
| 15:55 |
|
koha-jenkins |
Project Koha_21.05_U18 build #10: STILL FAILING in 2 min 6 sec: https://jenkins.koha-community[…]oha_21.05_U18/10/ |
| 15:56 |
|
koha-jenkins |
Project Koha_21.05_U20 build #11: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]oha_21.05_U20/11/ |
| 15:56 |
|
jajm |
i'm not sure about the --force option... why should users be able to skip a failed update ? surely there is something wrong with their data or in the code, and it should be fixed |
| 15:57 |
|
ashimema |
mmm.. I'm jsut trying to think of cases you might want to skip and failing to do so too |
| 15:57 |
|
ashimema |
might be nice to have different levels of report output though.. |
| 15:58 |
|
ashimema |
'info', 'warn' ? |
| 15:59 |
|
ashimema |
we have got cases where we tell people to go clean something up after the update right now.. for those cases where we deliberately leave something behind it could be nice to highlight it |
| 16:01 |
|
ashimema |
ooh.. I can't remember what our minimum perl is now.. but your in-memory filehandle open claims to only work with 5.16 and above ;) |
| 16:02 |
|
jajm |
ah... i missed that part of the docs :) |
| 16:03 |
|
ashimema |
I had to look it up.. I learnt something new today.. hadn't ever thought about doing that sort of thing |
| 16:03 |
|
ashimema |
it's an interesting approach |
| 16:04 |
|
jajm |
https://wiki.koha-community.or[…]d_recommendations says 5.14 |
| 16:04 |
|
jajm |
so close... :) |
| 16:04 |
|
ashimema |
was also looking for docs for the calling say on a filehandle using that notation as I've not really come accros that either.. failed to find docs for that though.. everyone seems to do the usual 'say $fh "whatever"' |
| 16:05 |
|
ashimema |
there was a big debate about it recently.. I have no idea how up to date that page ended up |
| 16:05 |
|
* ashimema |
would love to up it allot more |
| 16:05 |
|
koha-jenkins |
Project Koha_21.05_U16 build #9: STILL UNSTABLE in 1 hr 7 min: https://jenkins.koha-community[…]Koha_21.05_U16/9/ |
| 16:06 |
|
ashimema |
tucayo did loads of research.. looks like it got updated in line with his findings :) |
| 16:06 |
|
jajm |
ashimema, i think it's https://metacpan.org/pod/IO::Handle that add methods to filehandle |
| 16:06 |
|
ashimema |
5.14 it is then |
| 16:06 |
|
ashimema |
nice one, thanks |
| 16:06 |
|
ashimema |
I'll have a little read.. feels like a nice elegant way of coding |
| 16:06 |
|
jajm |
anyway, we should probably use 'say $fh $msg' |
| 16:07 |
|
* ashimema |
should probably do some perl away from Koha again at some point.. it's easy to get swept along with the tide on "the koha way".. I loved working with Mojo without the Koha baggage for a while.. it really improved my coding.. think I've gone backwards a bit again of late. |
| 16:08 |
|
ashimema |
probably.. just to keep the general style for the majority.. your right.. |
| 16:08 |
|
ashimema |
but it was certainly interesting to me to see it :) |
| 16:08 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #11: STILL FAILING in 2 min 44 sec: https://jenkins.koha-community[…]1.05_U_Stable/11/ |
| 16:08 |
|
* ashimema |
should also go deep dive on javascript again.. I'm also feeling woefully behind there :( |
| 16:09 |
|
ashimema |
but.. on those notes.. |
| 16:09 |
|
ashimema |
it's the weekend.. time to clock off |
| 16:09 |
|
ashimema |
have a great one jajm |
| 16:09 |
|
jajm |
thanks, you too ashimema |
| 16:24 |
|
|
khall joined #koha |
| 16:34 |
|
koha-jenkins |
Project Koha_21.05_D9 build #9: STILL UNSTABLE in 33 min: https://jenkins.koha-community[…]/Koha_21.05_D9/9/ |
| 16:42 |
|
|
cait1 left #koha |
| 16:47 |
|
koha-jenkins |
Yippee, build fixed! |
| 16:47 |
|
koha-jenkins |
Project Koha_21.05_D11 build #18: FIXED in 51 min: https://jenkins.koha-community[…]oha_21.05_D11/18/ |
| 16:47 |
|
koha-jenkins |
Yippee, build fixed! |
| 16:47 |
|
koha-jenkins |
Project Koha_21.05_U20 build #12: FIXED in 1 hr 7 min: https://jenkins.koha-community[…]oha_21.05_U20/12/ |
| 16:53 |
|
koha-jenkins |
Yippee, build fixed! |
| 16:53 |
|
koha-jenkins |
Project Koha_21.05_U16 build #10: FIXED in 58 min: https://jenkins.koha-community[…]oha_21.05_U16/10/ |
| 16:56 |
|
|
khall_ joined #koha |
| 17:06 |
|
|
enkidu joined #koha |
| 17:14 |
|
koha-jenkins |
Project Koha_21.05_U16 build #11: SUCCESS in 1 hr 6 min: https://jenkins.koha-community[…]oha_21.05_U16/11/ |
| 17:23 |
|
|
davidnind joined #koha |
| 17:39 |
|
|
khall joined #koha |
| 17:42 |
|
|
khall_ joined #koha |
| 18:23 |
|
|
enkidu joined #koha |
| 19:18 |
|
|
MarkHofstetter joined #koha |
| 19:23 |
|
tcohen |
@seen gmcharlt |
| 19:23 |
|
huginn |
tcohen: gmcharlt was last seen in #koha 7 weeks, 4 days, 5 hours, 11 minutes, and 9 seconds ago: <gmcharlt> Joubu: OK, i've confirmed that the config change I made to params.json appears to avoid the bug you ran into, so the act of making an email change request then cancelling it should no longer cause issues |
| 19:24 |
|
tcohen |
gmcharlt are you aware of any encoding-related annoyances with MARC::Record::MiJ? |
| 19:28 |
|
|
khall joined #koha |
| 19:32 |
|
|
khall joined #koha |
| 19:36 |
|
|
khall joined #koha |
| 19:37 |
|
|
khall joined #koha |
| 19:39 |
|
|
khall joined #koha |
| 19:41 |
|
|
khall joined #koha |
| 19:42 |
|
|
khall joined #koha |
| 19:43 |
|
|
khall joined #koha |
| 19:44 |
|
|
khall joined #koha |
| 19:46 |
|
|
khall joined #koha |
| 19:47 |
|
|
khall joined #koha |
| 19:48 |
|
|
khall joined #koha |
| 19:49 |
|
|
khall joined #koha |
| 19:49 |
|
koha-jenkins |
Yippee, build fixed! |
| 19:49 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #12: FIXED in 30 min: https://jenkins.koha-community[…]1.05_U_Stable/12/ |
| 19:52 |
|
|
khall joined #koha |
| 19:55 |
|
|
khall joined #koha |
| 19:57 |
|
|
khall joined #koha |
| 19:58 |
|
|
khall joined #koha |
| 19:59 |
|
|
khall joined #koha |
| 20:00 |
|
|
khall joined #koha |
| 20:02 |
|
|
khall joined #koha |
| 20:02 |
|
|
khall joined #koha |
| 20:04 |
|
|
khall joined #koha |
| 20:07 |
|
|
khall joined #koha |
| 20:09 |
|
|
marie-luce joined #koha |
| 20:10 |
|
|
khall joined #koha |
| 20:12 |
|
|
khall joined #koha |
| 20:14 |
|
|
khall joined #koha |
| 20:15 |
|
|
khall joined #koha |
| 20:18 |
|
|
khall joined #koha |
| 20:19 |
|
|
khall joined #koha |
| 20:22 |
|
|
khall joined #koha |
| 20:25 |
|
|
khall joined #koha |
| 20:26 |
|
|
khall joined #koha |
| 20:27 |
|
|
khall joined #koha |
| 20:27 |
|
koha-jenkins |
Yippee, build fixed! |
| 20:27 |
|
koha-jenkins |
Project Koha_21.05_U18 build #11: FIXED in 1 hr 7 min: https://jenkins.koha-community[…]oha_21.05_U18/11/ |
| 20:29 |
|
|
khall joined #koha |
| 20:31 |
|
|
khall joined #koha |
| 20:33 |
|
|
khall joined #koha |
| 20:36 |
|
|
khall joined #koha |
| 20:38 |
|
|
khall joined #koha |
| 20:39 |
|
|
khall joined #koha |
| 20:39 |
|
|
khall joined #koha |
| 20:40 |
|
|
khall joined #koha |
| 20:42 |
|
|
khall joined #koha |
| 20:44 |
|
|
khall joined #koha |
| 20:45 |
|
|
khall joined #koha |
| 20:47 |
|
|
khall joined #koha |
| 20:48 |
|
|
khall joined #koha |
| 20:50 |
|
|
khall joined #koha |
| 20:53 |
|
|
khall joined #koha |
| 20:54 |
|
|
khall joined #koha |
| 20:57 |
|
|
khall joined #koha |
| 20:58 |
|
|
khall joined #koha |
| 20:59 |
|
|
khall joined #koha |
| 21:00 |
|
|
khall joined #koha |
| 21:02 |
|
|
khall joined #koha |
| 21:03 |
|
|
khall joined #koha |
| 21:04 |
|
|
khall joined #koha |
| 21:05 |
|
|
khall joined #koha |
| 21:08 |
|
|
khall joined #koha |
| 21:10 |
|
|
khall joined #koha |
| 21:11 |
|
|
khall joined #koha |
| 21:12 |
|
|
khall joined #koha |
| 21:14 |
|
|
khall joined #koha |
| 21:15 |
|
|
khall joined #koha |
| 21:16 |
|
|
khall joined #koha |
| 21:17 |
|
|
khall joined #koha |
| 21:20 |
|
|
khall joined #koha |
| 21:24 |
|
|
khall joined #koha |
| 21:26 |
|
|
khall joined #koha |
| 21:27 |
|
|
khall joined #koha |
| 21:29 |
|
|
khall joined #koha |
| 21:30 |
|
|
khall joined #koha |
| 21:31 |
|
|
khall joined #koha |
| 21:33 |
|
|
khall joined #koha |
| 21:34 |
|
|
khall joined #koha |
| 21:36 |
|
|
khall joined #koha |
| 21:37 |
|
|
davidnind left #koha |
| 21:38 |
|
|
khall joined #koha |
| 21:39 |
|
|
khall joined #koha |
| 21:40 |
|
|
khall joined #koha |
| 21:42 |
|
|
khall joined #koha |
| 21:43 |
|
|
khall joined #koha |
| 21:44 |
|
|
tuxayo-read-only joined #koha |
| 21:44 |
|
|
tuxayo-read-only left #koha |
| 21:57 |
|
tuxayo |
wow, Jenkins got it's looks changed ^^ |
| 21:57 |
|
tuxayo |
facy icons |
| 22:32 |
|
|
khall joined #koha |
| 22:32 |
|
|
khall joined #koha |
| 22:35 |
|
|
khall joined #koha |
| 22:36 |
|
|
khall joined #koha |
| 22:38 |
|
|
khall joined #koha |
| 22:40 |
|
|
khall joined #koha |
| 22:41 |
|
|
khall joined #koha |
| 22:42 |
|
|
khall joined #koha |
| 22:45 |
|
|
khall joined #koha |
| 22:47 |
|
|
khall joined #koha |
| 22:48 |
|
|
khall joined #koha |
| 22:50 |
|
|
khall joined #koha |
| 22:51 |
|
|
khall joined #koha |
| 22:56 |
|
|
khall joined #koha |
| 22:58 |
|
|
khall joined #koha |
| 23:00 |
|
|
khall joined #koha |
| 23:01 |
|
|
khall joined #koha |
| 23:04 |
|
|
khall joined #koha |
| 23:05 |
|
|
khall joined #koha |
| 23:10 |
|
|
khall joined #koha |
| 23:12 |
|
|
khall joined #koha |
| 23:15 |
|
|
khall joined #koha |
| 23:15 |
|
|
khall joined #koha |
| 23:18 |
|
|
khall joined #koha |
| 23:22 |
|
|
khall joined #koha |
| 23:25 |
|
|
khall joined #koha |
| 23:28 |
|
|
khall joined #koha |
| 23:30 |
|
|
khall joined #koha |
| 23:31 |
|
|
khall joined #koha |
| 23:32 |
|
|
khall joined #koha |
| 23:34 |
|
|
khall joined #koha |
| 23:37 |
|
|
khall joined #koha |
| 23:38 |
|
|
khall joined #koha |
| 23:40 |
|
|
khall joined #koha |
| 23:42 |
|
|
khall joined #koha |
| 23:45 |
|
|
khall joined #koha |
| 23:47 |
|
|
khall joined #koha |
