Time |
S |
Nick |
Message |
00:04 |
|
|
inlibro joined #koha |
00:24 |
|
|
talljoy joined #koha |
01:05 |
|
|
inlibro joined #koha |
01:31 |
|
|
jo joined #koha |
01:57 |
|
|
wizzyrea joined #koha |
02:05 |
|
|
inlibro joined #koha |
03:05 |
|
|
inlibro joined #koha |
04:05 |
|
|
inlibro joined #koha |
04:07 |
|
|
wizzyrea joined #koha |
04:07 |
|
wizzyrea |
hi |
04:42 |
|
|
kathryn joined #koha |
05:05 |
|
|
inlibro joined #koha |
05:36 |
|
|
raiz joined #koha |
05:36 |
|
raiz |
hi... |
05:37 |
|
Guest11354 |
hi |
05:37 |
|
wahanui |
niihau, Guest11354 |
05:37 |
|
Guest11354 |
can somebady help me. |
05:39 |
|
Guest11354 |
i've just intall koha on ubuntu 18.02. After completed. when i try search catalog. Koha return with "No result found" |
05:57 |
|
Guest11354 |
hello guys |
05:57 |
|
|
chris1 joined #koha |
06:05 |
|
|
inlibro joined #koha |
06:29 |
|
|
cait joined #koha |
06:36 |
|
|
davidnind joined #koha |
06:40 |
|
|
fridolin joined #koha |
06:41 |
|
fridolin |
hi there |
06:41 |
|
wahanui |
bonjour, fridolin |
06:42 |
|
fridolin |
wahanui: un croissant s'il-vous-plait |
06:42 |
|
wahanui |
fridolin: what? |
06:42 |
|
fridolin |
et café |
06:48 |
|
|
calire joined #koha |
07:06 |
|
|
inlibro joined #koha |
07:26 |
|
cait |
hi fridolin - the mailing list server is acting up again - emailed L on Saturday - hope he is aorund? |
07:27 |
|
fridolin |
not yet but ill catch him |
07:30 |
|
ashimema |
mornin' #koha |
07:30 |
|
ashimema |
mornin' fridolin |
07:32 |
|
ashimema |
ooh.. when did Moo get introduced as a dependancy? |
07:34 |
|
ashimema |
ooh.. it's for Sitemapper and nothing else by the looks |
07:34 |
|
ashimema |
:confused:.. I don't remember that discussion.. I thought we were steering clear of making a decision on an object system.. |
07:41 |
|
fridolin |
ashimema: thanks a lot ;) |
07:42 |
|
* ashimema |
contemplates whether to use moo or mojo objects for a class he's developing |
07:43 |
|
ashimema |
Or.. whether to introduce a new dependency he was about to rule out because it depends on moo |
07:45 |
|
|
andreashm joined #koha |
07:52 |
|
|
paul_p joined #koha |
07:53 |
|
|
alex_a joined #koha |
07:53 |
|
alex_a |
Bonjour |
07:56 |
|
|
reiveune joined #koha |
07:57 |
|
reiveune |
hello |
07:57 |
|
wahanui |
que tal, reiveune |
08:01 |
|
|
cait joined #koha |
08:05 |
|
|
sophie_m joined #koha |
08:06 |
|
kohaputti |
About Bug 24137. I find it strange that the russian and ukrainian language's default bibliographic frameworks has the local 097 MARC field defined for including Оператор / Operator information. Are the no rules to be consistent across bib frameworks between languages? |
08:06 |
|
|
inlibro joined #koha |
08:06 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24137 major, P3, ---, jonathan.druart, Signed Off , Marc21 bibliographic fails to install for ru-Ru and uk-UA |
08:06 |
|
|
liliputech_asu joined #koha |
08:06 |
|
kohaputti |
I mean no other language's bib framework defines 097 as the Operator field |
08:07 |
|
liliputech_asu |
hi |
08:08 |
|
Joubu |
ru-RU and uk-UA diverged from others, they started differently and so are hard to keep up-to-date, especially because there is nobody maintaining them |
08:28 |
|
|
andreashm joined #koha |
08:29 |
|
kohaputti |
Joubu, ok! The patch you provide in the bug might fix one problem but when I try to run the SQL file I keep getting errors like: |
08:29 |
|
kohaputti |
$ koha-mysql kohadev < installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql |
08:30 |
|
kohaputti |
ERROR 1366 (HY000) at line 9: Incorrect integer value: '' for column 'repeatable' at row 1 |
08:30 |
|
kohaputti |
though, I wonder if the installer will somehow survive that error |
08:35 |
|
Joubu |
kohaputti: yes you are right. That's weird, I am pretty sure I tried it before submitting the patch |
08:36 |
|
kohaputti |
I will try with the installer then |
08:36 |
|
kohaputti |
the installer might convert '' to 0 |
08:38 |
|
Joubu |
I did not try the web installer for sure, but using the MariaDB CLI directly |
08:38 |
|
kohaputti |
I might have a newer mariadb version than you so maybe there is more strict checks |
08:39 |
|
kohaputti |
I used kohadevbox |
08:39 |
|
kohaputti |
oh, this seems to be mysql and not mariadb |
08:40 |
|
kohaputti |
yes, it is mysql |
08:41 |
|
Joubu |
That seems tricky to fix |
08:42 |
|
|
josef_moravec joined #koha |
08:43 |
|
kohaputti |
Joubu, so I tested with MariaDB and there is no problem, it only fails with MySQL |
08:45 |
|
Joubu |
if fails with MariaDB 10.4.10 |
08:45 |
|
ashimema |
MySQL 5.5 is still the default in koha-testing-docker |
08:45 |
|
cait |
ashimema: Moo - years ago |
08:45 |
|
cait |
you asked earlier |
08:46 |
|
ashimema |
but there are easy aliases for other db versions |
08:46 |
|
ashimema |
kohaputti.. see the aliases file in koha-testing-docker for details |
08:47 |
|
ashimema |
indeed |
08:47 |
|
kohaputti |
Mysql 5.7.28-0ubuntu0.18.04.4 is what fails in kohadevbox |
08:47 |
|
ashimema |
2013 cait |
08:47 |
|
ashimema |
but I was surprised to see it. |
08:47 |
|
kohaputti |
Mariadb 10.1.43-MariaDB-0ubuntu0.18.04.1 works |
08:48 |
|
ashimema |
when we barely use it.. I've actively avoided it for years not wanting to get into a debate on around it |
08:48 |
|
ashimema |
well.. we can kill off mysql5.5 support as of this release in my opinion |
08:48 |
|
ashimema |
but I think we need to maintain support for it in 19.11, 19.05 and 18.11 up until the next feature release |
08:48 |
|
ashimema |
i.e. may |
08:49 |
|
kohaputti |
ashimema, I checked the aliases file but I'm not sure what info you think I should get from it |
08:49 |
|
ashimema |
i.e how to run koha-testing-docker with different sql servers |
08:50 |
|
kohaputti |
aah, I don't use the docker thing so I cannot test different databases on the fly easily |
08:50 |
|
ashimema |
oh.. I thought I read above that you were using koha-testing-docker to run the tests? |
08:50 |
|
kohaputti |
kohadevbox |
08:50 |
|
* ashimema |
must have mis-read |
08:50 |
|
ashimema |
oops.. my bad |
08:50 |
|
ashimema |
you said kohdevbox |
08:50 |
|
ashimema |
sorry to have confused you |
08:50 |
|
Joubu |
kohaputti: you can FQA it, not sure how/if I will get back to it however |
08:51 |
|
Joubu |
that's a super annoying work.. |
08:52 |
|
Joubu |
well, it actually fixes something, so maybe worth having a first fix in quickly, then wait for the other one |
08:53 |
|
cait |
ashimema: I remember we discussed on IRC, but would need some tracking down to see what the exact decision was |
08:54 |
|
ashimema |
well.. it's there and has been there for years |
08:54 |
|
cait |
yeah but the decision on 'usage' |
08:54 |
|
ashimema |
It would be trivial to remove it now.. but I'm not sure I see any reason to |
08:54 |
|
cait |
but yep, it's old |
08:54 |
|
|
andreashm joined #koha |
08:54 |
|
kohaputti |
Joubu, I marked it already as FQA... |
08:54 |
|
magnuse |
ashimema: if you or andrew (or others) have opinions on bug 23391 or bug 22833 i'm all ears |
08:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23391 enhancement, P5 - low, ---, koha-bugs, NEW , Hide finished ILL requests |
08:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22833 normal, P5 - low, ---, magnus, NEW , Don't let users cancel holds connected with ILLs |
08:55 |
|
* cait |
misses bug mails |
08:57 |
|
magnuse |
bug 11081 |
08:57 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11081 enhancement, P5 - low, ---, frederic, CLOSED WONTFIX, Port Koha::Contrib::Tamil indexer into Koha code base |
08:57 |
|
magnuse |
looks like there was discussion about moose there at least |
08:58 |
|
magnuse |
http://irc.koha-community.org/[…]6-03-01#i_1794287 |
08:59 |
|
ashimema |
I remember various discussions.. just never noticed that we already have Moo before.. |
08:59 |
|
ashimema |
lol |
09:00 |
|
ashimema |
Authen::OATH depends on Moo magnuse (and I was thinking of using it for 2FA) |
09:03 |
|
ashimema |
how flexible do you want this magnuse.. just for auth at login.. or do you think it would be helpful to have it available as a 'verify me' call for any other actions? |
09:06 |
|
|
inlibro joined #koha |
09:35 |
|
|
josef_moravec1 joined #koha |
09:38 |
|
|
fridolin joined #koha |
09:42 |
|
|
vfernandes joined #koha |
09:52 |
|
magnuse |
ashimema: never thought that far... if it's not too much extra hassle i guess "have it available" sounds nice |
09:52 |
|
ashimema |
it may well be the simplest route now I'm looking into it. |
09:53 |
|
ashimema |
C4::Auth is just plain scary :( |
09:53 |
|
magnuse |
:-( |
09:53 |
|
ashimema |
indeed |
09:53 |
|
ashimema |
getting a proof of concept going was easy.. trying to tie it into our existing auth.. not so much |
09:54 |
|
ashimema |
a few lunchtimes I reckon instead of just the one. |
10:06 |
|
|
inlibro joined #koha |
10:07 |
|
* magnuse |
cheers ashimema on |
10:13 |
|
|
andreashm joined #koha |
10:14 |
|
|
nlegrand joined #koha |
10:15 |
|
nlegrand |
Salut #koha |
10:27 |
|
eythian |
ashimema: I always wanted to rewrite C4::Auth, but it never happened. |
10:27 |
|
|
davidnind left #koha |
10:27 |
|
eythian |
@later tell wizzyrea you're welcome :) |
10:27 |
|
huginn |
eythian: The operation succeeded. |
10:28 |
|
ashimema |
many a person has wanted to ;) |
10:28 |
|
eythian |
@later tell wizzyrea it's worth noting that she's done a whole lot of them |
10:28 |
|
huginn |
eythian: The operation succeeded. |
10:28 |
|
nlegrand |
there are changes scheduled for C4::Auth? |
10:29 |
|
ashimema |
I don't know that anyone has the time or sponsorship to rework C4::Auth any time soon nlegrand.. |
10:29 |
|
ashimema |
just lots of us would like to ;) |
10:30 |
|
ashimema |
the context of the conversation was that I'm looking to add basic 2FA support |
10:30 |
|
eythian |
you should rewrite C4::Auth so it can have plugins or something |
10:31 |
|
nlegrand |
{sct}U2FsdGVkX187JcuOHXfDYNw8SeoAUDybnSs8IRSgKOwQZ/2TP9wpj7H0bsW1bqQZN94Sy0TqF/XCy8F7imzhJQW+8fAq50CR1gxCq2FyQTwI/4K9uJswgJD7qipr7rRjs9TQTmtdYEuH0nQB2ahAfw== |
10:31 |
|
ashimema |
indeed |
10:31 |
|
nlegrand |
oups sorry. |
10:31 |
|
nlegrand |
I meant: I'm working right now on adding bloat to C4::Auth. It'll be soon on bugzilla. |
10:31 |
|
ashimema |
making it modular and pluggable would be awesome |
10:31 |
|
ashimema |
what you adding nlegrand? |
10:32 |
|
nlegrand |
storing desks into sessions. |
10:32 |
|
ashimema |
desks... ? |
10:32 |
|
ashimema |
interesting.. |
10:33 |
|
nlegrand |
It adds parameters to C4::Context::set_userenv |
10:34 |
|
nlegrand |
the goal is to attach a waiting reserve to a desk. So you know your book is waiting at the entrance or at the fourth floor. |
10:34 |
|
ashimema |
interesting idea |
10:35 |
|
Joubu |
why do you need to add parameters to set_userenv? |
10:35 |
|
nlegrand |
it's more or less the way we manage closed stacks with multiple desks. |
10:36 |
|
nlegrand |
Joubu: to set the desk_id, a bit like you set the homebranch. |
10:36 |
|
ashimema |
I wanted to do similar when I added cash registers.. but the customer decided against it.. |
10:36 |
|
ashimema |
they're now wishing they'd taken my advice in the first place |
10:36 |
|
ashimema |
but hey |
10:45 |
|
huginn |
News from kohagit: Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly <http://git.koha-community.org/[…]9b2f284f03e81ca2d> |
10:45 |
|
huginn |
News from kohagit: Bug 20948: Add missing html filter <http://git.koha-community.org/[…]c7469a57996e8b312> |
10:46 |
|
|
andreashm joined #koha |
10:49 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #38: STILL FAILING in 1 min 54 sec: https://jenkins.koha-community[…]Master_D9_My8/38/ |
11:06 |
|
|
inlibro joined #koha |
11:13 |
|
Joubu |
nlegrand, ashimema: why not using $logged_in_user instead? |
11:13 |
|
ashimema |
+1 |
11:13 |
|
ashimema |
when I was looking at adding to the session it was 5 or so years ago ;) |
11:13 |
|
Joubu |
the only reason to use user_env would be to get the desk_id from modules, but we are close to decide it's a bad idea |
11:13 |
|
ashimema |
been a while since I've messed around in that area |
11:14 |
|
ashimema |
$logged_in_user is certainly our more modern approach |
11:14 |
|
ashimema |
and should work nicely with REST api's down the line |
11:14 |
|
ashimema |
usr_env will not work nice with api's |
11:21 |
|
Joubu |
logged_in_user is only for TT and controllers scripts |
11:26 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #6: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]_D9_MDB_Latest/6/ |
11:28 |
|
koha-jenkins |
Yippee, build fixed! |
11:28 |
|
wahanui |
Congratulations! |
11:28 |
|
koha-jenkins |
Project Koha_Master_D8 build #558: FIXED in 39 min: https://jenkins.koha-community[…]ha_Master_D8/558/ |
11:28 |
|
koha-jenkins |
Yippee, build fixed! |
11:28 |
|
wahanui |
Congratulations! |
11:28 |
|
koha-jenkins |
Project Koha_Master_U18 build #501: FIXED in 43 min: https://jenkins.koha-community[…]a_Master_U18/501/ |
11:40 |
|
cait |
ashimema: did you see the accounts related blocker? |
11:41 |
|
ashimema |
ooh, yes.. but promptly forgot it |
11:41 |
|
ashimema |
remind me of the bug number and I'll stick it next in my queue |
11:41 |
|
cait |
bug 24177 |
11:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24177 blocker, P5 - low, ---, josef.moravec, Needs Signoff , Internal Server error when clicking cash register (Report) |
11:42 |
|
cait |
ther has also been a 19.11 guarantors broke email on the mailn glist |
11:42 |
|
cait |
... that I can't access right now |
11:42 |
|
|
fridolin joined #koha |
11:42 |
|
cait |
but it might still be in your inboxes, from last week |
11:42 |
|
cait |
it sounded like a potential update problem |
11:44 |
|
|
fridolin joined #koha |
11:47 |
|
|
khall_ joined #koha |
11:49 |
|
|
khall joined #koha |
11:52 |
|
|
khall_ joined #koha |
12:06 |
|
koha-jenkins |
Yippee, build fixed! |
12:06 |
|
wahanui |
Congratulations! |
12:06 |
|
koha-jenkins |
Project Koha_Master_D9 build #1027: FIXED in 39 min: https://jenkins.koha-community[…]a_Master_D9/1027/ |
12:07 |
|
|
inlibro joined #koha |
12:08 |
|
|
andreashm joined #koha |
12:29 |
|
|
alex_a joined #koha |
12:30 |
|
|
oleonard joined #koha |
12:31 |
|
oleonard |
Hi #koha |
12:36 |
|
eythian |
hi oleopard |
12:39 |
|
oleonard |
Mailing lists still struggling eh |
12:39 |
|
* oleonard |
misses his Bugzillas |
12:43 |
|
|
andreashm joined #koha |
12:47 |
|
cait |
oleonard: me too.... |
12:52 |
|
cait |
looking for a quick and dirty fix for bug 21853 |
12:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21853 critical, P5 - low, ---, julian.maurice, RESOLVED FIXED, Internal software error when exporting basket group as PDF with Perl > 5.24.1 |
12:52 |
|
cait |
.. coudl you just add the additional path to the INC variable? |
13:07 |
|
|
inlibro joined #koha |
13:10 |
|
oleonard |
Anyone around from Biblibre who can tell us about what's going on with lists.koha-community.org ? |
13:10 |
|
cait |
oleonard: I emailed L and asked fridolin earlier... |
13:11 |
|
|
calire left #koha |
13:13 |
|
cait |
hm looks like i got some email |
13:14 |
|
cait |
ok, i think just our mail thing is strange about dates |
13:15 |
|
cait |
no new emails |
13:15 |
|
|
sev_q joined #koha |
13:15 |
|
fridolin |
cait: i've told Laurent on our chat |
13:16 |
|
tcohen |
morning |
13:16 |
|
ashimema |
tcohen.. just the man |
13:17 |
|
tcohen |
can I get coffee first? LOL |
13:17 |
|
ashimema |
we're using the same DBD::mysql in all testing right.. it's in the testing container side not the db container right.. |
13:17 |
|
ashimema |
just checking my own sanity for how koha-testing-docker works |
13:17 |
|
nlegrand |
tcohen: nu, you're not drinking mate? |
13:17 |
|
ashimema |
haha.. enjoy |
13:17 |
|
ashimema |
I'm reporting a bug up to dbic maints |
13:18 |
|
tcohen |
each docker image contains the distro's DBD::mysql |
13:18 |
|
tcohen |
which are probably outdated |
13:18 |
|
oleonard |
That'll teach you not to say good morning *before* coffee tcohen |
13:19 |
|
ashimema |
poop |
13:19 |
|
ashimema |
so I was wrong |
13:19 |
|
fridolin |
lists.koha-community.org has hardware issues |
13:20 |
|
ashimema |
hang on.. that doesn't make sense |
13:20 |
|
ashimema |
oh.. each distro.. |
13:20 |
|
ashimema |
my brain hurts |
13:21 |
|
* oleonard |
donates a Jaz® drive to the lists hardware fund |
13:25 |
|
tcohen |
oleonard: LOL |
13:25 |
|
tcohen |
nlegrand: all sorted https://snipboard.io/a5Z46A.jpg |
13:26 |
|
nlegrand |
<3 |
13:26 |
|
oleonard |
Just kidding tcohen I never had a Jaz drive. But I definitely had a Zip drive. |
13:28 |
|
* tcohen |
had a printer port CD recorder |
13:28 |
|
ashimema |
one side effect of us testing again latest mariadb versions.. we uncover bugs upstream before they do... |
13:29 |
|
ashimema |
looks like something maria have done has broken dbd::mysql or dbic's use of it. |
13:29 |
|
fridolin |
cait: mailling lists are back |
13:30 |
|
|
blou__ joined #koha |
13:32 |
|
|
calire joined #koha |
13:34 |
|
tcohen |
it is time for DBD::mariadb |
13:34 |
|
tcohen |
I think I read discussions about it |
13:34 |
|
ashimema |
haha.. that's exactly what I'm just reading |
13:39 |
|
Joubu |
it happens when `type` is in the condition list |
13:39 |
|
Joubu |
ashimema: it happens when `type` is in the condition list |
13:39 |
|
|
andreashm joined #koha |
13:40 |
|
ashimema |
so it's `type` that hurts us is it. |
13:41 |
|
|
Dyrcona joined #koha |
13:42 |
|
Joubu |
nope, it's not that |
13:42 |
|
Joubu |
it's the order by `datetime` (maybe) |
13:46 |
|
|
khall joined #koha |
13:46 |
|
cait |
fridolin: thx! |
13:47 |
|
Joubu |
ashimema: see bug 24148 commment 2, that's quite fun |
13:47 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24148 normal, P5 - low, ---, chris, NEW , black magic in Circulation/Returns.t |
13:55 |
|
ashimema |
oh wow.. |
13:55 |
|
ashimema |
that is scary |
13:56 |
|
ashimema |
btw.. we can't easily switch to DBD::mariadb yet.. DBIx::Class doesn't yet support it.. |
13:56 |
|
ashimema |
though i'm told it wouldn't be too hard to add support superficially.. but spotting all the divergences could be so doing a good job could be rather labour intensive |
13:57 |
|
ashimema |
right.. I need to scarper.. have a carol service to attend |
14:04 |
|
|
andreashm joined #koha |
14:07 |
|
|
inlibro joined #koha |
14:11 |
|
|
dersmon joined #koha |
14:11 |
|
dersmon |
hi everyone |
14:15 |
|
dersmon |
i want to customize the Notices & slips |
14:16 |
|
dersmon |
für my acquisitions, the euro values always have 6 numbers after the decimal point |
14:17 |
|
dersmon |
as defined in the mariadb: DECIMAL(28,6) |
14:17 |
|
dersmon |
i wonder why you chose to use that many numbers instead of 2? |
14:17 |
|
dersmon |
is there a way to crop the trailing zeros in my slip/mail definition? |
14:18 |
|
caroline_catlady |
I think there is a filter you can use |
14:19 |
|
caroline_catlady |
https://wiki.koha-community.or[…]le:_Format_prices |
14:22 |
|
dersmon |
ah |
14:24 |
|
|
bdonnahue joined #koha |
14:25 |
|
dersmon |
no i get 0.00 |
14:25 |
|
dersmon |
:D |
14:26 |
|
dersmon |
*now |
14:26 |
|
caroline_catlady |
yay! |
14:27 |
|
dersmon |
yeah, but those is not the actual listprice |
14:27 |
|
dersmon |
:D |
14:27 |
|
dersmon |
(Anzahl: <<aqorders.quantity>>, je [% aqorders.listprice | $Price %] <<aqbooksellers.currency>>) |
14:28 |
|
caroline_catlady |
oops... |
14:30 |
|
dersmon |
(Anzahl: <<aqorders.quantity>>, je [% <<aqorders.listprice>> | $Price %] <<aqbooksellers.currency>>) seems to do the trick |
14:30 |
|
dersmon |
thank you :) |
14:30 |
|
caroline_catlady |
strange... |
14:33 |
|
|
wizzyrea joined #koha |
14:34 |
|
wizzyrea |
hi |
14:34 |
|
Joubu |
it can indeed work. A first pass is done to replace the our former syntax, so [% <<aqorders.listprice>> | $Price %] will become [% 12345.6789 | $Price %], then second pass will evaluate it and the Price filter will use the float as entry. |
14:34 |
|
Joubu |
hi wizzyrea |
14:36 |
|
cait |
fridolin++ Laurent++ |
14:37 |
|
caroline_catlady |
but why doesn't [% aqorders.listprice | $Price %] work? |
14:39 |
|
cait |
caroline_catlady: because they are not 1:1 translations :( |
14:39 |
|
cait |
often the objects are named differently |
14:39 |
|
cait |
https://wiki.koha-community.or[…]_Template_Toolkit |
14:40 |
|
cait |
see: variables available only in old syntax |
14:40 |
|
cait |
according to the table Josef has made the only object variable is branch |
14:44 |
|
caroline_catlady |
ah! I understand |
14:52 |
|
|
lukeG left #koha |
14:53 |
|
dersmon |
another detail just emerged: |
14:53 |
|
Joubu |
[% order.listprice | $Price %] should work |
14:53 |
|
Joubu |
cait: no 1:1 translations, what do you mean? |
14:53 |
|
dersmon |
i have this <order></order> block which creates the list of different items |
14:54 |
|
cait |
Joubu: you can't just leave off the << |
14:54 |
|
cait |
and expect the TT variables to be the same format as we had |
14:54 |
|
dersmon |
the block is followed by a final greeting |
14:54 |
|
cait |
we are missing real documentaiton on what you can use |
14:54 |
|
cait |
like here, you need to know the object is order |
14:54 |
|
dersmon |
but the greeting gets added to each order |
14:54 |
|
cait |
and then you can 'guess' what the attributes are... not ideal |
14:54 |
|
|
andreashm joined #koha |
14:54 |
|
cait |
and hope they are the same as the databse columsn... but they might not... or they might be additonal ones |
14:55 |
|
Joubu |
the wiki page is quite complete I think |
14:55 |
|
Joubu |
it's written that the variable is named "order[s]" |
14:55 |
|
dersmon |
https://pastebin.com/mdEmLFu5 |
14:56 |
|
cait |
Joubu: it's not listed n variables available in each notice |
14:56 |
|
cait |
i am not sure how libraries are ever supposed to understand - we need more documentaiton |
14:56 |
|
Joubu |
no, but the variables that were available before must be available with the TT syntax |
14:58 |
|
dersmon |
it seems to me this template-in-template hack may cause the multiple (unwanted) greetings |
15:01 |
|
Joubu |
dersmon: I would replace the <<orders>> with a loop using the template toolkit syntax. Somethink like : [% FOR order IN orders %][% order.ordernumber %]: [% order.listprice | $Price %][% END %] |
15:06 |
|
dersmon |
can i use that also with the biblio data? |
15:07 |
|
|
inlibro joined #koha |
15:08 |
|
Joubu |
which notice template are you editing? |
15:10 |
|
dersmon |
still the same one |
15:10 |
|
dersmon |
but i was wondering if your solution will work for <<biblio.author>>. <<biblio.title>> <<biblioitems.place>> etc. |
15:11 |
|
Joubu |
which notice? :) |
15:12 |
|
Joubu |
I guess you can init the biblio with [% SET biblio = order.biblio %], inside the loop |
15:12 |
|
Joubu |
maybe the biblio variable is set, it depends on the notice |
15:16 |
|
dersmon |
the notice is ACQORDER |
15:19 |
|
dersmon |
this is my template now: https://pastebin.com/SnxvuA3j |
15:19 |
|
dersmon |
but i get |
15:19 |
|
dersmon |
FEHLER! - ERROR PROCESSING TEMPLATE: file error - parse error - input text line 23: unexpected token (END) [% END %] at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 182. |
15:19 |
|
Joubu |
at first glance it will not work, sorry about that |
15:19 |
|
Joubu |
orders is not passed for ACQORDER |
15:20 |
|
Joubu |
I found bug 16883. That should have been fixed when the TT syntax work has been pushed. But got lost |
15:20 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16883 normal, P5 - low, ---, koha-bugs, NEW , TT syntax for notices should take aqorders, aqbooksellers, biblioitems tables into account |
15:20 |
|
|
alex_a joined #koha |
15:28 |
|
ashimema |
Oh, I didn't realise that either |
15:28 |
|
|
wizzycray joined #koha |
15:28 |
|
ashimema |
We should fix that |
15:28 |
|
|
wizzycray joined #koha |
15:31 |
|
|
wizzycray joined #koha |
15:35 |
|
|
davidnind joined #koha |
15:41 |
|
|
calire left #koha |
16:00 |
|
|
cait left #koha |
16:05 |
|
|
lisettelatah joined #koha |
16:06 |
|
oleonard |
Hi lisettelatah |
16:07 |
|
|
inlibro joined #koha |
16:08 |
|
lisettelatah |
hi oleonard |
16:08 |
|
wahanui |
hi oleopard |
16:20 |
|
huginn |
News from kohagit: Bug 24177: (QA follow-up) Fix warning <http://git.koha-community.org/[…]c7719d16ccd6866c4> |
16:20 |
|
huginn |
News from kohagit: Bug 21761: Do not call $self->store in ->set_password <http://git.koha-community.org/[…]c3ed17f7c56751b81> |
16:20 |
|
huginn |
News from kohagit: Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl <http://git.koha-community.org/[…]397a3bea277eb7cd5> |
16:20 |
|
huginn |
News from kohagit: Bug 24191: Make objects.search pass to_model to dbic_merge_sorting <http://git.koha-community.org/[…]7c148b158b82e5db0> |
16:20 |
|
huginn |
News from kohagit: Bug 24191: Add to_model param to _build_order_atom and dbic_merge_sorting <http://git.koha-community.org/[…]bc80b5c01d5712c07> |
16:20 |
|
huginn |
News from kohagit: Bug 24191: Regression tests <http://git.koha-community.org/[…]bccfbbfa4b0fdf926> |
16:20 |
|
huginn |
News from kohagit: Bug 24138: Fix calculation of suspension days when a limit is set <http://git.koha-community.org/[…]1129eb3725e3fe99a> |
16:20 |
|
huginn |
News from kohagit: Bug 24138: Move the calculation out of the sub <http://git.koha-community.org/[…]99d66b2ac8afdcf51> |
16:20 |
|
huginn |
News from kohagit: Bug 23970: Make search with "Publication date" field work at any position <http://git.koha-community.org/[…]51ef2c81193d0607e> |
16:20 |
|
huginn |
News from kohagit: Bug 21761: Call set + store as update <http://git.koha-community.org/[…]87e15aa268f5fb331> |
16:21 |
|
|
josef_moravec joined #koha |
16:22 |
|
oleonard |
Hi josef_moravec |
16:22 |
|
josef_moravec |
hi oleonard |
16:22 |
|
wahanui |
hi oleopard |
16:28 |
|
reiveune |
bye |
16:28 |
|
|
reiveune left #koha |
16:31 |
|
|
alex_a joined #koha |
16:49 |
|
wizzycray |
eythian, I know I love her comics <3 so handy and accessible |
16:53 |
|
oleonard |
eh? |
16:54 |
|
koha-jenkins |
Project Koha_Master_D9 build #1028: UNSTABLE in 35 min: https://jenkins.koha-community[…]a_Master_D9/1028/ |
16:56 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #39: STILL FAILING in 1 min 53 sec: https://jenkins.koha-community[…]Master_D9_My8/39/ |
16:58 |
|
koha-jenkins |
Project Koha_Master_U18 build #502: UNSTABLE in 38 min: https://jenkins.koha-community[…]a_Master_U18/502/ |
16:59 |
|
|
fridolin left #koha |
17:07 |
|
|
inlibro joined #koha |
17:12 |
|
koha-jenkins |
Project Koha_19.11_D9 build #2: STILL UNSTABLE in 50 min: https://jenkins.koha-community[…]/Koha_19.11_D9/2/ |
17:13 |
|
tcohen |
back |
17:13 |
|
tcohen |
oleonard: have you played with datatables and the 'empty table' message? |
17:13 |
|
oleonard |
No |
17:27 |
|
koha-jenkins |
Project Koha_Master_D8 build #559: UNSTABLE in 28 min: https://jenkins.koha-community[…]ha_Master_D8/559/ |
17:32 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #7: STILL UNSTABLE in 35 min: https://jenkins.koha-community[…]_D9_MDB_Latest/7/ |
17:37 |
|
koha-jenkins |
Project Koha_19.11_D8 build #1: FAILURE in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/1/ |
17:50 |
|
koha-jenkins |
Project Koha_19.11_D8 build #2: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/2/ |
17:58 |
|
ashimema |
wierd.. seems to be logins failing |
17:58 |
|
ashimema |
didn't think any of those patches touched auth |
18:02 |
|
koha-jenkins |
Project Koha_19.11_U18 build #2: STILL UNSTABLE in 50 min: https://jenkins.koha-community[…]Koha_19.11_U18/2/ |
18:03 |
|
Joubu |
selenium_1 | org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@id=\"toolbar\"]/div[@class=\"btn-group\"][last()]"} |
18:03 |
|
Joubu |
ashimema: this is the relevant line |
18:04 |
|
* ashimema |
thought it would spit out screenshots of the page when an element wasn't found.. |
18:05 |
|
koha-jenkins |
Project Koha_19.11_D8 build #3: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/3/ |
18:06 |
|
davidnind |
:q:q |
18:07 |
|
davidnind |
sorry, in wrong window (trying to exit with vi!) :-[ |
18:08 |
|
|
inlibro joined #koha |
18:11 |
|
Joubu |
ashimema: tests pass for me |
18:11 |
|
Joubu |
at least patrons_search.t |
18:12 |
|
Joubu |
ho but you pushed bug 21761 |
18:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21761 critical, P1 - high, ---, martin.renvoize, Pushed to master , Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' |
18:12 |
|
Joubu |
pretty sure it comes from there |
18:15 |
|
koha-jenkins |
Project Koha_19.11_D8 build #4: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/4/ |
18:22 |
|
davidnind |
FYI - something in the latest master 'breaks' koha-testing-docker, can no longer login with koha (for both username and password), works fine on 19.05.x and 19.11.x |
18:23 |
|
Joubu |
https://gitlab.com/koha-commun[…]merge_requests/35 |
18:23 |
|
Joubu |
davidnind: this one |
18:23 |
|
wahanui |
somebody said this one was big enough as is |
18:23 |
|
Joubu |
just merged |
18:24 |
|
davidnind |
thanks Joubu! |
18:24 |
|
Joubu |
you can update the misc4dev repo, or wait for the new images to be generated |
18:25 |
|
Joubu |
cd /kohadevbox/misc4dev/; git pull |
18:25 |
|
Joubu |
then reset_all |
18:25 |
|
koha-jenkins |
Project Koha_19.11_D8 build #5: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/5/ |
18:28 |
|
davidnind |
Joubu: I will wait for images to be updated (had just done and update, and was checking a preference name) |
18:28 |
|
ashimema |
Thought something might break after that one.. supposed people noticed that quick though in daily use |
18:28 |
|
ashimema |
Koha-testing-docker is getting popular 😀 |
18:29 |
|
Joubu |
I sent an email to the list |
18:29 |
|
davidnind |
koha-testing-docker++ |
18:30 |
|
ashimema |
Ta |
18:30 |
|
davidnind |
email just ame through |
18:34 |
|
corilynn |
:( Bug 24205 |
18:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24205 normal, P5 - low, ---, koha-bugs, NEW , Advanced editor - Save to .mrc hangs when 00X fields have delimeters |
18:35 |
|
koha-jenkins |
Project Koha_19.11_D8 build #6: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/6/ |
18:45 |
|
koha-jenkins |
Project Koha_19.11_D8 build #7: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/7/ |
18:55 |
|
koha-jenkins |
Project Koha_19.11_D8 build #8: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/8/ |
19:05 |
|
koha-jenkins |
Project Koha_19.11_D8 build #9: STILL FAILING in 10 min: https://jenkins.koha-community[…]/Koha_19.11_D8/9/ |
19:08 |
|
|
inlibro joined #koha |
19:14 |
|
oleonard |
The way the Koha news version of OpacNavRight works right now a "news_lang" variable is sent to opac-main.tt in order to get the right language |
19:15 |
|
oleonard |
If I want that to work for something like opacheader I'd need to add $news_lang to every OPAC template |
19:15 |
|
oleonard |
What's the most efficient way to accomplish this? |
19:15 |
|
koha-jenkins |
Project Koha_19.11_D8 build #10: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/10/ |
19:16 |
|
oleonard |
Better to set it in Auth.pm? In KohaNews.pm? |
19:21 |
|
oleonard |
Is $news_lang any different than the lang variable used in doc-head-open.inc to set the HTML language attribute? |
19:21 |
|
ashimema |
I was just wondering that.. |
19:22 |
|
ashimema |
surely they should match and thus surely one can be removed |
19:25 |
|
oleonard |
Where does the lang variable in doc-head-open.inc come from? |
19:25 |
|
ashimema |
I'm imagining Auth.pm |
19:25 |
|
ashimema |
but that's a guess |
19:25 |
|
koha-jenkins |
Project Koha_19.11_D8 build #11: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/11/ |
19:26 |
|
ashimema |
Auth.pm does waaaaaay too much |
19:26 |
|
oleonard |
Auth.pm appears to be doing language-getting for an altogether different purpose |
19:27 |
|
ashimema |
oh |
19:27 |
|
ashimema |
interesting |
19:34 |
|
|
corilynn_ joined #koha |
19:35 |
|
koha-jenkins |
Project Koha_19.11_D8 build #12: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/12/ |
19:36 |
|
Joubu |
oleonard: yes,you certainly want to send C4::Languages::getlanguage from C4::Auth |
19:36 |
|
oleonard |
Joubu: Any thoughts about the "lang" variable used by the OPAC's doc-head-open.inc? |
19:40 |
|
Joubu |
I was expecting to see it in C4::Auth, but... I am not |
19:40 |
|
rangi |
C4::Templates |
19:40 |
|
rangi |
and themelanguage in there |
19:41 |
|
|
khall_ joined #koha |
19:41 |
|
oleonard |
rangi: What do you mean? |
19:42 |
|
Joubu |
oleonard: C4::Templates |
19:42 |
|
rangi |
thats the bit that sets the language |
19:42 |
|
Joubu |
ha! you beat me |
19:42 |
|
Joubu |
84 $self->lang($lang); |
19:43 |
|
Joubu |
so, this is certainly wrong: tools/koha-news.pl:$template->param( lang => $lang ); |
19:43 |
|
rangi |
yep |
19:43 |
|
Joubu |
or useless |
19:43 |
|
rangi |
not used |
19:43 |
|
rangi |
$vars->{themelang} .= '/' . $self->preferredtheme . '/' . $self->lang; |
19:44 |
|
oleonard |
And line 53 of opac-main.pl redundant? |
19:44 |
|
rangi |
is what actually gets the path to the tt |
19:45 |
|
rangi |
yeah you should be able to get that without calling themelanguage again |
19:45 |
|
rangi |
$template->lang |
19:45 |
|
rangi |
should work |
19:46 |
|
koha-jenkins |
Project Koha_19.11_D8 build #13: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/13/ |
19:47 |
|
rangi |
$news_lang = $template->lang; (or just use $template->lang) i think anyway, havent tested but it should work |
19:47 |
|
rangi |
cos C4::Templates->new sets that accessor up |
19:48 |
|
oleonard |
It appears to work |
19:48 |
|
rangi |
sweet |
19:49 |
|
rangi |
i figured id have made that work cos im lazy and wouldn't want to have to call a routine, when the object already contains that info |
19:49 |
|
oleonard |
Thanks rangi and Joubu |
19:50 |
|
ashimema |
Nice work |
19:51 |
|
koha-jenkins |
Yippee, build fixed! |
19:51 |
|
wahanui |
Congratulations! |
19:51 |
|
koha-jenkins |
Project Koha_Master_D9 build #1029: FIXED in 42 min: https://jenkins.koha-community[…]a_Master_D9/1029/ |
19:52 |
|
oleonard |
By the way Joubu, I'm not crazy about Bug 24088 but I'm not sure what to suggest instead |
19:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24088 enhancement, P5 - low, ---, fridolin.somers, Signed Off , Add link to item search in staff client main page |
19:52 |
|
oleonard |
...Other than 'Don't do that.' |
19:53 |
|
wizzycray |
mm no I don't like that |
19:53 |
|
wizzycray |
point out that the item search is available under the dropdown |
19:53 |
|
wizzycray |
in the header |
19:53 |
|
wizzycray |
bc it is. |
19:53 |
|
wizzycray |
it's on every page. |
19:53 |
|
wizzycray |
already |
19:53 |
|
oleonard |
wizzycray: You talk like clicks are FREE |
19:54 |
|
wizzycray |
¯\_(ツ)_/¯ |
19:55 |
|
Joubu |
I only like it because it restores the same number of columns between left and right :) |
19:56 |
|
wizzycray |
nope cannot cosign |
19:56 |
|
Joubu |
oleonard: could you comment? |
19:56 |
|
koha-jenkins |
Project Koha_19.11_D8 build #14: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/14/ |
19:56 |
|
wizzycray |
I did :) |
19:56 |
|
wizzycray |
oleonard can too of course |
19:56 |
|
Joubu |
thx |
19:58 |
|
* oleonard |
did too |
19:58 |
|
oleonard |
and with that I shall away |
19:59 |
|
oleonard |
See y'all later |
20:04 |
|
|
davidnind left #koha |
20:06 |
|
koha-jenkins |
Project Koha_19.11_D8 build #15: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/15/ |
20:08 |
|
|
inlibro joined #koha |
20:16 |
|
koha-jenkins |
Project Koha_19.11_D8 build #16: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/16/ |
20:22 |
|
|
hizzycray joined #koha |
20:26 |
|
koha-jenkins |
Project Koha_19.11_D8 build #17: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/17/ |
20:39 |
|
koha-jenkins |
Project Koha_19.11_D9 build #3: STILL UNSTABLE in 43 min: https://jenkins.koha-community[…]/Koha_19.11_D9/3/ |
20:40 |
|
koha-jenkins |
Project Koha_19.11_D8 build #18: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/18/ |
20:42 |
|
koha-jenkins |
Project Koha_19.11_U18 build #3: STILL UNSTABLE in 42 min: https://jenkins.koha-community[…]Koha_19.11_U18/3/ |
20:43 |
|
|
andreashm joined #koha |
20:50 |
|
|
andreashm joined #koha |
20:55 |
|
koha-jenkins |
Project Koha_19.11_D8 build #19: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/19/ |
20:56 |
|
* andreashm |
waves |
21:04 |
|
|
bdonnahue joined #koha |
21:04 |
|
rangi |
its bdonnahue !! |
21:05 |
|
koha-jenkins |
Project Koha_19.11_D8 build #20: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/20/ |
21:08 |
|
|
inlibro joined #koha |
21:13 |
|
|
andreash_ joined #koha |
21:15 |
|
koha-jenkins |
Project Koha_19.11_D8 build #21: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/21/ |
21:25 |
|
koha-jenkins |
Project Koha_19.11_D8 build #22: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/22/ |
21:34 |
|
|
bdonnahue joined #koha |
21:35 |
|
koha-jenkins |
Project Koha_19.11_D8 build #23: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/23/ |
21:45 |
|
bdonnahue |
hey rangi |
21:45 |
|
bdonnahue |
whats new |
21:45 |
|
wahanui |
i think new is 'not sent to vendor' |
21:45 |
|
koha-jenkins |
Project Koha_19.11_D8 build #24: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/24/ |
21:55 |
|
koha-jenkins |
Project Koha_19.11_D8 build #25: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/25/ |
22:08 |
|
|
inlibro joined #koha |
22:10 |
|
koha-jenkins |
Project Koha_19.11_D8 build #26: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/26/ |
22:32 |
|
|
cait joined #koha |
22:33 |
|
koha-jenkins |
Project Koha_19.05_D8 build #62: STILL UNSTABLE in 28 min: https://jenkins.koha-community[…]Koha_19.05_D8/62/ |
22:37 |
|
koha-jenkins |
Project Koha_19.05_U18 build #63: STILL UNSTABLE in 35 min: https://jenkins.koha-community[…]oha_19.05_U18/63/ |
22:38 |
|
wizzyrea |
aw I missed @bdonnahue |
22:43 |
|
koha-jenkins |
Project Koha_19.11_D8 build #27: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/27/ |
22:53 |
|
koha-jenkins |
Project Koha_19.05_D9 build #64: STILL UNSTABLE in 43 min: https://jenkins.koha-community[…]Koha_19.05_D9/64/ |
23:03 |
|
koha-jenkins |
Project Koha_19.11_D8 build #28: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/28/ |
23:05 |
|
koha-jenkins |
Project Koha_19.05_D8 build #63: STILL UNSTABLE in 27 min: https://jenkins.koha-community[…]Koha_19.05_D8/63/ |
23:08 |
|
|
inlibro joined #koha |
23:15 |
|
koha-jenkins |
Project Koha_19.11_D8 build #29: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/29/ |
23:24 |
|
koha-jenkins |
Project Koha_19.05_U18 build #64: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]oha_19.05_U18/64/ |
23:34 |
|
koha-jenkins |
Project Koha_19.11_D8 build #30: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/30/ |
23:44 |
|
koha-jenkins |
Project Koha_19.05_D8 build #64: STILL UNSTABLE in 28 min: https://jenkins.koha-community[…]Koha_19.05_D8/64/ |
23:48 |
|
|
aleisha joined #koha |
23:49 |
|
koha-jenkins |
Project Koha_19.05_D9 build #65: STILL UNSTABLE in 45 min: https://jenkins.koha-community[…]Koha_19.05_D9/65/ |
23:54 |
|
koha-jenkins |
Project Koha_19.11_D8 build #31: STILL FAILING in 10 min: https://jenkins.koha-community[…]Koha_19.11_D8/31/ |