IRC log for #koha, 2019-08-08

All times shown according to UTC.

Time S Nick Message
00:21 Mandersoon joined #koha
00:25 inlibro joined #koha
00:37 dpk_ joined #koha
01:26 inlibro joined #koha
02:26 inlibro joined #koha
03:26 inlibro joined #koha
04:26 inlibro joined #koha
04:50 sophie_m joined #koha
05:07 chris joined #koha
05:26 inlibro joined #koha
05:32 davidnind joined #koha
05:54 calire joined #koha
06:22 fridolin joined #koha
06:22 fridolin hi
06:26 marcelr joined #koha
06:26 marcelr hi #koha
06:26 inlibro joined #koha
06:34 reiveune joined #koha
06:34 reiveune hello
06:34 wahanui hello, reiveune
06:42 cait joined #koha
06:50 cait good morning #koha
06:54 laurence joined #koha
07:01 cait joined #koha
07:02 alex_a joined #koha
07:03 alex_a Bonjour
07:06 * magnuse waves
07:13 ashimema Good morning my #koha friends
07:22 magnuse kia ora ashimema
07:27 inlibro joined #koha
07:34 andreashm joined #koha
07:49 calire morning
07:58 magnuse trying to set -- RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName föo" -- in Apache config, but the ö is double encoded in Koha. anyone happen to know a fix?
07:58 magnuse (yeah, i know that is an apache question)
08:01 JesseM_ joined #koha
08:27 inlibro joined #koha
09:14 andreashm joined #koha
09:17 andreashm joined #koha
09:21 laurence joined #koha
09:27 inlibro joined #koha
09:49 cait joined #koha
10:07 cait I am trying to figure out why the itemsearch is broken in German :(
10:07 cait not a clue really yet
10:08 kohaputti joined #koha
10:10 cait Unsupported format html at /home/vagrant/kohaclone/catalogue/ line 89
10:14 paxed cait: better look at the page html source, maybe the translation tool messed up
10:15 cait yeah i wondered about that
10:15 cait but not spotting it :(
10:15 cait been staring at the source code and did a search for itemsearch and looked at all the strings in the po
10:15 paxed (i've had couple cases where the tool failed on me after making couple modifications to pages)
10:17 cait this is reported for later 18.11, 19.05 and master
10:17 cait so kinda urgent to fix
10:21 koha-jenkins Project Koha_19.05_U18 build #25: SUCCESS in 29 min: https://jenkins.koha-community[…]oha_19.05_U18/25/
10:26 fridolin joined #koha
10:27 inlibro joined #koha
10:32 cait the format html - the checkbox has the value html in english an german
10:36 koha-jenkins Project Koha_19.05_D8 build #24: SUCCESS in 42 min: https://jenkins.koha-community[…]Koha_19.05_D8/24/
10:36 koha-jenkins Project Koha_19.05_D9 build #26: SUCCESS in 41 min: https://jenkins.koha-community[…]Koha_19.05_D9/26/
10:56 cait joined #koha
11:03 m23 joined #koha
11:04 cait ... still got no clue
11:06 cait Joubu: around?
11:12 ashimema anyone fancy a, hopefully trivial, QA?
11:12 ashimema bug 6759
11:12 huginn` Bug[…]w_bug.cgi?id=6759 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Use a different account type for account renewals than for new accounts
11:14 cait fah
11:14 cait gah
11:14 cait Status für "Nicht ausleihbar""
11:14 cait found it
11:15 cait adding " to a string that is part of javascript will do it...
11:18 davidnind cait++
11:19 cait thx davidnind :)
11:20 davidnind Sounded very frustrating trying to find it - I have no idea  about how to help with that one, excellent work finding the source of the problem!
11:25 cait :)
11:27 inlibro joined #koha
11:45 huginn` News from kohagit: Bug 22741: Add a test <[…]ce38f5f3f04e96c51>
11:45 huginn` News from kohagit: Bug 23405: Circulation autocomplete for patron lookup broken if cardnumber is empty <[…]f2075936de7b0c431>
11:45 huginn` News from kohagit: Bug 22741: Make updated_on timezone aware in Koha::Patron <[…]060e6595226047eea>
11:49 oleonard joined #koha
11:49 oleonard Hi all
11:50 alex_a joined #koha
12:02 ashimema Hi oleonard :)
12:08 oleonard ashimema, you've been busy :) Thanks!
12:10 ashimema ;)
12:10 huginn` News from kohagit: Bug 23286: Compiled CSS <[…]4bd4771b1cb95f21c>
12:10 huginn` News from kohagit: Bug 23431: Don't nullify DOB if it's hidden by sysprefs <[…]66dba2657a2aecf14>
12:10 huginn` News from kohagit: Bug 23399: (follow-up) Markup comments and corrections <[…]fad78ae99c8006f9e>
12:10 huginn` News from kohagit: Bug 23399: Reindent <[…]097f8971b9cc68e21>
12:10 huginn` News from kohagit: Bug 23322: Correct case for boolean in ES search <[…]ee7061ebb5b93919a>
12:10 huginn` News from kohagit: Bug 23286: Improve style of hold confirmation modal <[…]6fd4d03711f6c6349>
12:10 ashimema I would say you're the one whose been busy.. I've just followed you along ;)
12:11 ashimema It does feel very quiet at the moment QA wise though :(...
12:11 ashimema I don't really like doing QA as RM.. it introduces less resiliance :(
12:11 ashimema but.. if it keeps us moving forward.. hopefully my QAing isn't too bad ;)
12:15 oleonard As always ashimema let me know if I can help
12:15 ashimema funny you should say that . . .
12:16 ashimema hehe.. nah, only kidding..
12:16 ashimema not got anything coming to mind right at this second
12:17 ashimema I would love some UX views on my point of sale stuff at some point.. but I aught to write a test plan first so it's not a mission to work out how it works before you can actually look at any of the screens
12:17 oleonard I would be happy to follow you test plan :)
12:18 oleonard ...but I've never worked retail ;)
12:18 koha-jenkins Project Koha_Master_D9 build #834: SUCCESS in 29 min: https://jenkins.koha-community[…]ha_Master_D9/834/
12:18 ashimema it all tries to follow koha UI patturns really.. not many librarians have worked in retail either ;)
12:19 ashimema there's a few subtle things that have me confused.. like at the moment I have some datatable styling issues which i'm surprised to see at all.
12:19 oleonard Maybe they'll be fixed by Bug 23013 :D
12:19 huginn` Bug[…]_bug.cgi?id=23013 enhancement, P5 - low, ---, oleonard, Needs Signoff , Upgrade DataTables in the staff client
12:20 ashimema oh wow
12:20 ashimema that's big
12:22 ashimema erm.. silly question..
12:22 ashimema you don't say what version we're going from and to?
12:23 oleonard Yeah sorry I just noticed that!
12:23 oleonard The new version is 1.10.18
12:24 ashimema oh.. it's in the commit message.. I missed it somehow
12:24 ashimema 1.10.18.. aren't there some fairly significant API changes going from 1.09 to 1.10?
12:26 koha-jenkins Project Koha_Master_U18 build #320: UNSTABLE in 41 min: https://jenkins.koha-community[…]a_Master_U18/320/
12:26 ashimema ooh.. interesting.. they aim for backwards compatability..
12:26 oleonard Yes, I was just about to say :)
12:26 ashimema also.. it may explain the difference we've been seeing between .dataTable and .DataTable
12:27 oleonard Yup
12:27 oleonard confusing
12:27 inlibro joined #koha
12:27 ashimema cool.. so as long as the old code sticks to dataTable we don't need to update all the crazy fnWhatever calls we have
12:28 ashimema that's sort of nice
12:28 ashimema oh, this will be so nice to have.. the new API is so much more intuitive
12:29 ashimema are you already working to resolve Joubu's findings?
12:29 ashimema I'd be happy to do the next round of testing.
12:30 koha-jenkins Project Koha_Master_D8 build #343: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_Master_D8/343/
12:32 oleonard Joubu is a very exacting tester. If one or two pixels of misalignment is all he found then I'm actually quite happy
12:32 ashimema hehe
12:32 oleonard (the misalignment is perplexing though)
12:36 ashimema
12:36 ashimema any clues as to why the table on the left ends up with lots of whitespace above it..
12:36 ashimema and the table on the right has the toolbars misalligned?
12:37 oleonard Yeah you simply don't have enough space for all those components
12:38 ashimema I was thinking of moving the datatable search filter out of the top bar and into it's own search box above
12:39 ashimema I want search to be upfront and center as such.. not so hidden off to the side.. although that would be breaking consistency..
12:39 ashimema hmm
12:40 davidnind left #koha
12:42 ashimema hmm.. where does the pager get it's width from.. it's odd
12:42 oleonard What does the "Add" button do in the table of items to purchase?
12:43 oleonard ashimema: If you don't have it, try adding "autoWidth": false to your table configuration. That might help?
12:43 ashimema so the table of 'Items for purchase' lists all manual_inv values.. clicking 'add' adds one of thos to the 'Tis sale' table
12:43 oleonard Ah, got it
12:44 ashimema already got `"bAutoWidth": false,` :(
12:44 ashimema I think `"autoWidth": false,` is the new api's version of the same..
12:44 ashimema tried both
12:47 koha-jenkins Project Koha_Master_D9 build #835: SUCCESS in 29 min: https://jenkins.koha-community[…]ha_Master_D9/835/
12:48 oleonard ashimema: I wonder if you could have the whole table display (unpaginated), but have it scroll like in an iframe
12:49 * oleonard will be back in a few
12:57 magnuse t'would be awesome if someone from the qa team could have a look at bug 19008 and see if my rebase + followup warrants a new signoff or not
12:57 huginn` Bug[…]_bug.cgi?id=19008 enhancement, P5 - low, ---, fridolin.somers, Needs Signoff , More database cleanups
13:02 koha-jenkins Yippee, build fixed!
13:02 wahanui Congratulations!
13:02 koha-jenkins Project Koha_Master_U18 build #321: FIXED in 36 min: https://jenkins.koha-community[…]a_Master_U18/321/
13:11 andreashm joined #koha
13:12 caroline_catlady bonjour!
13:13 koha-jenkins Project Koha_Master_D8 build #344: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_Master_D8/344/
13:22 cait joined #koha
13:28 inlibro joined #koha
13:30 wizzyrea joined #koha
13:49 caroline_catlady joined #koha
14:13 JesseM joined #koha
14:28 inlibro joined #koha
14:28 cait ashimema: trying to flex my qa muscles a bit...
14:30 ashimema thanks cait :)
14:32 huginn` News from kohagit: Bug 23228: DBRev <[…]8d1785dfcd7fb7e68>
14:32 huginn` News from kohagit: Bug 23228: (QA follow-up) Add required filters <[…]8f328b07b413f0aea>
14:32 huginn` News from kohagit: Bug 23228: (QA follow-up) Fix the DB update <[…]c8d1068527d0d1a05>
14:32 huginn` News from kohagit: Bug 23228: Add option to automatically display payment receipt for printing after... <[…]155c2dc2a64e2c7ef>
14:42 cait t
14:42 calire left #koha
14:42 cait hm missed oleonard
14:42 caroline_catlady ashimema: any chance you can give direction for bug 17140? It's been open since 2016 and "Major" since 2018
14:42 huginn` Bug[…]_bug.cgi?id=17140 major, P5 - low, ---, philippe.blouin, Failed QA , Incorrect rounding in total fines calculations, part 2
14:43 ashimema this is the accounts side isn't it..
14:43 ashimema kidclamp did loads of similar fixes around the acq side
14:43 caroline_catlady we had a problem yesterday at one of our clients', they had typed 0.251 (unintentionnaly) in the circulation rules fines and it messed everything up when it came to payment
14:44 caroline_catlady it was not obvious because everywhere the display is cut off at 2 decimals, but in the db, there were 3 decimals
14:44 ashimema mm, I know the problem well ;)
14:44 caroline_catlady okay! sorry!
14:44 ashimema I'll add it to my list to look at
14:44 caroline_catlady thanks!
14:45 ashimema the issues we kept ending up with were that differnt countries us different numbers of decimals and different rounding schemes :(
14:45 ashimema there's certainly somewhere that uses three decimals.. can't remembe where
14:45 caroline_catlady ok, I wasn't sure if there were currencies where they use more than 2 decimals
14:45 eythian wahanui: the cake is alive
14:45 wahanui OK, eythian.
14:46 caroline_catlady should'nt that go with currency format?
14:46 ashimema and there's countries who always round up.. other countries who round up for even and down for odds
14:46 ashimema and other things on top too
14:46 ashimema indeed
14:46 ashimema it should
14:47 caroline_catlady I understand it's a big thing to take on...
14:47 ashimema kidclamp wrote a pluggable rounding system for acq.. we probably need to look at using some of that code here too
14:47 ashimema it's important to fix though.. i agree
14:48 ashimema we also have the added fun of the input masks bug (where people input amounts in different styles.. i.e. decomal and thausand separators)
14:48 caroline_catlady yes! one of our interns worked on that one in acq
14:48 cait I am not sur ethe current problem is really rounding here
14:48 ashimema and.. we're not greatly consistent in our maths.. sometimes it's clientside in JS, other times is serveside in perl and other times again it's done in the DB
14:48 cait the problem is you can enter 3 decimals, but koha then only displays 2 everywhere
14:49 cait and uses a html5 thing (that i hate, other story) to enforce 2 when paying
14:49 cait so you can never pay the fine off
14:49 ashimema does it not display more than two if you have your currency setup to show more than two?
14:49 cait you can't do anything about that in currencies
14:49 * ashimema dones't even know how you'd go about doing that
14:49 wizzyrea good morning
14:49 ashimema ok.. so it needs a proper looking at again :(
14:50 caroline_catlady hi wizzyrea!
14:50 cait caroline_catlady: i think yours is a new bug
14:50 ashimema as I say.. I'll stick it on my list.. I'm in an accounts mode still at the moment
14:50 cait it appears there are a few with 3 [[…]_ISO_4217.php?P=3]
14:50 cait but we have hardcoded 2 in the prices tt thing
14:50 cait it could be changed there for display
14:50 cait but it leaves the hardcoded inputs
14:50 caroline_catlady cait: really? I can create a new bug if you want
14:51 caroline_catlady I just didn't want to divide efforts
14:51 cait i think we should not allow to enter more than 2 decimals as fines atm
14:51 ashimema oh dear.. i had no idea we'd hard coded it'.. that's naughty of us
14:51 cait in the circ matrix
14:51 cait yes... story of my life with i18n issues...
14:57 caroline_catlady ashimema: just to clarify, do you want me to create a new bug for my problem? Or just comment on the existing one?
14:57 ashimema a comment should suffice :)
14:58 caroline_catlady ok will do! :)
15:03 ashimema thanks
15:10 huginn` News from kohagit: Bug 23307: Add columns configuration to cataloguing/ <[…]cf44e8caa7613a00b>
15:10 huginn` News from kohagit: Bug 22209: Move stock rotation stage and item forms into modals <[…]3ea2cd52a701d8302>
15:12 koha-jenkins Project Koha_Master_D9 build #836: UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_Master_D9/836/
15:13 cait was that me?
15:15 koha-jenkins Project Koha_Master_D8 build #345: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_Master_D8/345/
15:15 ashimema I've just re-uploaded 23434 cait.. hopefully that'll be happier for you to QA
15:16 cait ok
15:17 ashimema shout if it fails.. I hate it when sha1 issue arrise.. they're a bugger to fix :(
15:19 * ashimema would love to see bug 6759 qa'd.. it's the last outstanding one in my accounts queue before the new features and enhancements set
15:19 huginn` Bug[…]w_bug.cgi?id=6759 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Use a different account type for account renewals than for new accounts
15:28 inlibro joined #koha
15:28 caroline_catlady goodness that's an old one!
15:29 koha-jenkins Project Koha_Master_U18 build #322: UNSTABLE in 29 min: https://jenkins.koha-community[…]a_Master_U18/322/
15:32 reiveune bye
15:32 reiveune left #koha
15:36 * ashimema has been working through accounts and trying to fix up old ones whilst working on new stuff too
15:36 oleonard joined #koha
15:36 * oleonard is in Windows update hell
15:38 ashimema good luck oleonard
15:41 cait good luck and take the cookie jar
15:43 ashimema remind me when you get a chance oleonard.. whats the magic dance one has to do to add a new icon to the staff client home page buttons
15:44 ashimema aha.. generate staff-home-icons-sprite.png by the looks :(
15:44 oleonard Okay first you'll need a goat
15:44 ashimema be nice if that was as easy as font awesome icons
15:44 ashimema hehe
15:45 oleonard FA icons is something we should investigate
15:47 ashimema[…]ister?style=solid is what I'm thinking
15:47 wahanui i think thinking is so much easier
15:49 oleonard ashimema: Not available in the Font Awesome version we're on (4.7.0)
15:49 cait the current ones are from the noun project
15:49 cait maybe you can find something similar there?
15:50 ashimema cool.. wasn't aware of that
15:50 cait don't forget to update the about page :)
15:50 ashimema loads of options:[…]q=cash%20register
15:50 ashimema :)
15:51 cait oleonard: scary amoutn of removed code on bug 23434
15:51 huginn` Bug[…]_bug.cgi?id=23434 normal, P5 - low, ---, oleonard, Signed Off , Hold confirmation dialog problem if HoldsAutoFill is enabled
15:51 oleonard I was scared too
15:52 ashimema did it apply ok this time around then cait? :)
15:52 cait yep, qa tools pass too
15:52 cait testing now
15:52 oleonard All I know to do is test as many check-in scenarios as I can think of
15:52 koha-jenkins Project Koha_Master_D9 build #837: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_Master_D9/837/
15:52 ashimema that's what I did
15:53 ashimema they all seemed to work.. but I'm not sure how good my test data is for such a case
15:53 koha-jenkins Project Koha_Master_D8 build #346: UNSTABLE in 24 min: https://jenkins.koha-community[…]ha_Master_D8/346/
15:53 ashimema oh noes.. what did I break
15:54 cait hm
15:55 cait there is the autofil print thing
15:55 cait chould this not bring up the print screen right away?
15:55 cait HoldsAutoFillPrintSlip
15:56 cait ah now it worked
15:57 ashimema ?
15:57 cait the print screen
15:59 ashimema are you talking about the auto reciept printing thing I just pushed?
15:59 ashimema no.. holds
15:59 ashimema my brain is slow this afternoon
16:04 cait all good
16:04 cait just pqa
16:06 ashimema :)
16:06 laurence left #koha
16:14 ashimema grrr.. selenium tests.. I don't get why this one is now suddenly failing :9
16:20 chris_n` joined #koha
16:26 cait never liked them
16:28 inlibro joined #koha
16:28 bpmcneilly joined #koha
16:29 cait hm no kidclamp
16:37 cait oleonard-away: could we add borrowrenumber to the batch report magic too? :)
16:40 cait oh it already works on cardnumer
16:44 koha-jenkins Project Koha_Master_U18 build #323: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_U18/323/
16:49 bpmcneilly left #koha
16:55 cait ashimema: are we still using insert ignore when adding new systempreferences?
16:56 cait wiki says so
16:56 * cait continues
17:18 cait oh
17:19 cait method names in Koha... lowercase with _ right?
17:26 oleonard joined #koha
17:28 inlibro joined #koha
17:31 oleonard cait did you see a use for borrowernumber in the batch report actions?
17:33 cait i found out carnumber allows patron batch edit
17:33 cait i had tried borrowernumber first as it seemed more logical
17:33 cait cardnumber :)
17:33 cait given we use itemnumber and not barcode... but maybe it's because of what the tool accepts
17:49 Mandersoon_ joined #koha
18:28 inlibro joined #koha
19:29 inlibro joined #koha
19:35 kidclamp joined #koha
19:51 andreashm joined #koha
20:02 kathryn joined #koha
20:13 kathryn joined #koha
20:29 inlibro joined #koha
20:56 alexbuckley joined #koha
20:57 kathryn joined #koha
21:00 andreashm joined #koha
21:29 inlibro joined #koha
22:25 chris_n joined #koha
22:29 inlibro joined #koha
23:11 papa joined #koha
23:29 inlibro joined #koha
23:48 khall joined #koha

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary