Time |
S |
Nick |
Message |
00:06 |
|
|
sameee joined #koha |
00:30 |
|
|
inlibro joined #koha |
01:00 |
|
|
dpk_ joined #koha |
01:25 |
|
|
irma__ joined #koha |
01:30 |
|
|
inlibro joined #koha |
02:05 |
|
|
alexbuckley_ joined #koha |
02:30 |
|
|
inlibro joined #koha |
03:30 |
|
|
inlibro joined #koha |
04:21 |
|
|
chris_n joined #koha |
04:30 |
|
|
inlibro joined #koha |
05:07 |
|
|
chris joined #koha |
05:19 |
|
|
eythian joined #koha |
05:30 |
|
|
inlibro joined #koha |
05:38 |
|
|
marcelr joined #koha |
05:38 |
|
marcelr |
hi #koha |
05:49 |
|
|
calire joined #koha |
05:51 |
|
|
alexbuckley joined #koha |
06:02 |
|
|
eythian joined #koha |
06:13 |
|
|
fridolin joined #koha |
06:14 |
|
fridolin |
hi |
06:17 |
|
|
kohaputti joined #koha |
06:25 |
|
|
laurence joined #koha |
06:27 |
|
|
cait joined #koha |
06:31 |
|
|
inlibro joined #koha |
06:31 |
|
* magnuse |
waves |
06:37 |
|
|
reiveune joined #koha |
06:37 |
|
reiveune |
hello |
06:56 |
|
|
alex_a joined #koha |
06:58 |
|
* cait |
waves |
07:00 |
|
alex_a |
Bonjour |
07:18 |
|
cait |
hi alex_a - just started working on your bug 23436 |
07:18 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23436 normal, P5 - low, ---, alex.arnaud, Signed Off , Save to 'undefined' showing in Advanced cataloging editor |
07:19 |
|
alex_a |
cait, very tiny patch as you can see |
07:20 |
|
cait |
it certainly improves it |
07:20 |
|
cait |
but i wonder if it shoul dshow when i am workng on a new record? |
07:20 |
|
cait |
might be a separte bug |
07:22 |
|
cait |
what do you think? should it show when I am not working on an already saved record? (pondering to file a new bug, this one will pass) |
07:24 |
|
cait |
alex_a++ # nice test plan |
07:26 |
|
alex_a |
cait, it could better that the duplicate backend doesn't appear. But i am not sûr the code allows that for now |
07:26 |
|
alex_a |
Need to be checked |
07:27 |
|
cait |
i am passing yours and making a new bug as we speak :) |
07:27 |
|
alex_a |
Doesn't when editing a new record i mean |
07:31 |
|
alex_a |
cait, could you add me to the cc list once you are done with the new bug please ? |
07:31 |
|
|
inlibro joined #koha |
07:31 |
|
cait |
sure |
07:31 |
|
alex_a |
thx :) |
07:34 |
|
cait |
done |
07:36 |
|
* ashimema |
should take lessons on writing test plans from alex_a |
07:36 |
|
* ashimema |
is terrible with test plans |
07:37 |
|
ashimema |
yeay.. I have a PQA queue again :) |
07:38 |
|
ashimema |
boo.. the selenium test didn't magically fix itself over night |
07:38 |
|
|
andreashm joined #koha |
07:42 |
|
alex_a |
Test plan: |
07:42 |
|
alex_a |
- apply the patch |
07:42 |
|
alex_a |
- check it works |
07:44 |
|
ashimema |
hehe |
07:44 |
|
ashimema |
indeed |
07:44 |
|
cait |
:) |
07:55 |
|
|
alexbuckley joined #koha |
08:02 |
|
ashimema |
https://bugs.koha-community.or[…]_bug.cgi?id=23307 - George Williams comment should be recorded as a new bug right? |
08:02 |
|
huginn` |
Bug 23307: enhancement, P5 - low, ---, oleonard, Pushed to master , Add columns configuration to cataloguing/z3950_search.tt |
08:02 |
|
ashimema |
or is there already one for that |
08:03 |
|
cait |
ashimema: i tihnk you are right |
08:03 |
|
cait |
I think the patch is good, but these could be dealt with separately |
08:03 |
|
cait |
will you? or should I? |
08:04 |
|
ashimema |
I can submit the bug |
08:06 |
|
|
fridolin1 joined #koha |
08:06 |
|
ashimema |
bug 23441 |
08:06 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23441 enhancement, P5 - low, ---, oleonard, NEW , Export should not include the 'actions' column in Z3950 results. |
08:07 |
|
cait |
oh good catch |
08:07 |
|
ashimema |
:) |
08:07 |
|
cait |
i think i misread that one as being able to toggle it |
08:08 |
|
cait |
which could make sens eif you only want to use the context menu |
08:08 |
|
ashimema |
and now back to trying to work out how/why this particualt patch seems to break the selenium tests for a totally unrelated table |
08:08 |
|
ashimema |
fair |
08:09 |
|
cait |
ok to update to trivial? |
08:09 |
|
ashimema |
sure |
08:31 |
|
|
inlibro joined #koha |
08:44 |
|
|
fridolin joined #koha |
08:45 |
|
|
davidnind joined #koha |
08:57 |
|
|
andreashm joined #koha |
08:57 |
|
|
andreashm joined #koha |
08:59 |
|
|
andreashm joined #koha |
09:01 |
|
|
alex_a_ joined #koha |
09:02 |
|
ashimema |
@later tell Joubu any chance you could guide me through fixing the current failing selenium test.. I can't see why it's failing at the moment.. |
09:02 |
|
huginn` |
ashimema: The operation succeeded. |
09:03 |
|
ashimema |
thanks huggin` |
09:03 |
|
ashimema |
* thanks huginn` |
09:11 |
|
magnuse |
yay for bug 23173 |
09:11 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23173 enhancement, P5 - low, ---, andrew.isherwood, Needs Signoff , ILL should be able to search third party sources prior to request creation |
09:13 |
|
ashimema |
:) |
09:14 |
|
ashimema |
i was hopeing you'd pick this up magnuse |
09:14 |
|
|
vfernandes joined #koha |
09:17 |
|
magnuse |
yeah, i hope to find the time next week |
09:18 |
|
|
laurence joined #koha |
09:28 |
|
ashimema |
:) |
09:30 |
|
|
cait joined #koha |
09:31 |
|
|
inlibro joined #koha |
09:57 |
|
|
kidclamp joined #koha |
10:09 |
|
|
laurence joined #koha |
10:19 |
|
|
mirkh joined #koha |
10:31 |
|
|
inlibro joined #koha |
10:53 |
|
|
alexbuckley joined #koha |
10:54 |
|
|
andreashm joined #koha |
10:55 |
|
|
andreashm joined #koha |
11:04 |
|
|
magnuse joined #koha |
11:28 |
|
|
oleonard joined #koha |
11:28 |
|
oleonard |
Hi #koha |
11:31 |
|
|
inlibro joined #koha |
11:33 |
|
calire |
hi oleonard |
11:33 |
|
wahanui |
hi oleopard |
11:34 |
|
oleonard |
Happy almost weekend |
11:35 |
|
calire |
\o/ |
11:36 |
|
oleonard |
Are all your friends and neighbors on vacation calire? That's what Europe does in August, right? |
11:36 |
|
calire |
yeah except the neighbour upstairs is having guests for like a month so I look forward to the stamping |
11:42 |
|
oleonard |
Heavy-footed outsiders |
12:04 |
|
|
alex_a joined #koha |
12:07 |
|
ashimema |
I've just found a completely different way of implimenting bug 23228 |
12:07 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23228 enhancement, P5 - low, ---, kyle, Pushed to master , Add option to automatically display payment receipt for printing after making a payment |
12:08 |
|
ashimema |
but I'm not sure if it's better or not.. I 'think' it prevents the need to allow popups for your koha domain in your browsers.. which would be nice |
12:08 |
|
ashimema |
did you look at how bug 23228 was implimented at all oleonard ? |
12:09 |
|
oleonard |
I tested it at one point but I don't remember how it was done |
12:13 |
|
ashimema |
khalls implimentation uses a document.onload on the parent page (i.e pay rather than paycollect for example).. inside that there's a listener that looks for a params presence.. if present it will window.open(url, _blank).. |
12:13 |
|
ashimema |
the window.open gets caught by most popup blockers.. |
12:13 |
|
ashimema |
I couldn't think of a nicer way so I PQA'd it and added a note to the release notes |
12:13 |
|
ashimema |
but.. |
12:14 |
|
ashimema |
I've now seen the same thing achieved with an 'onsubmit' function in the 'paycollect' page itself.. |
12:14 |
|
ashimema |
wondering whether to convert to that method.. |
12:14 |
|
ashimema |
as someone more familier with JS that me.. any thoughts on onsubmit vs window.open ? |
12:15 |
|
ashimema |
oh.. hang on.. they both do window.open |
12:15 |
|
ashimema |
but marginally differently.. |
12:15 |
|
* ashimema |
is confusing himself |
12:15 |
|
oleonard |
I don't really think it's an issue simply because we open pop-up windows all over the place... Users are going to run into it one way or the other. |
12:22 |
|
ashimema |
ta |
12:28 |
|
|
davidnind left #koha |
12:28 |
|
|
corilynn joined #koha |
12:32 |
|
|
inlibro joined #koha |
12:41 |
|
magnuse |
oleonard: in norway, july is the big month for holidays |
12:42 |
|
oleonard |
magnuse: Sure, gotta be back home manning the stores in time for the French tourists |
12:42 |
|
koha-jenkins |
Project Koha_19.05_U18 build #26: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_U18/26/ |
12:46 |
|
oleonard |
Could someone help me understand some code? I'm not sure why there's a $template-param() at line 204 of Breeding.pm |
12:46 |
|
oleonard |
How can you have that inside a while loop? |
12:51 |
|
koha-jenkins |
Project Koha_19.05_D8 build #25: SUCCESS in 42 min: https://jenkins.koha-community[…]Koha_19.05_D8/25/ |
12:51 |
|
koha-jenkins |
Project Koha_19.05_D9 build #27: UNSTABLE in 41 min: https://jenkins.koha-community[…]Koha_19.05_D9/27/ |
12:52 |
|
magnuse |
oleonard: yup |
12:54 |
|
magnuse |
oleonard: that param seems like it would overwrite the previous values every time it runs... |
12:58 |
|
oleonard |
Okay, I'm glad to hear I'm not crazy to think so |
13:02 |
|
|
fridolin joined #koha |
13:11 |
|
koha-jenkins |
Project Koha_19.05_U18 build #27: SUCCESS in 29 min: https://jenkins.koha-community[…]oha_19.05_U18/27/ |
13:24 |
|
|
magnuse joined #koha |
13:30 |
|
koha-jenkins |
Yippee, build fixed! |
13:30 |
|
wahanui |
Congratulations! |
13:30 |
|
koha-jenkins |
Project Koha_19.05_D9 build #28: FIXED in 38 min: https://jenkins.koha-community[…]Koha_19.05_D9/28/ |
13:32 |
|
|
inlibro joined #koha |
13:33 |
|
koha-jenkins |
Project Koha_19.05_D8 build #26: SUCCESS in 41 min: https://jenkins.koha-community[…]Koha_19.05_D8/26/ |
13:40 |
|
oleonard |
Anyone else getting a JS error in the console when using the alphabet links on the Patrons home page? |
13:41 |
|
oleonard |
"TypeError: dtMemberResults.fnDraw is not a function" |
13:41 |
|
oleonard |
...only the problem goes away when I'm in git bisect :| |
13:42 |
|
|
wizzyrea joined #koha |
13:53 |
|
oleonard |
Hi wizzyrea |
13:55 |
|
wizzyrea |
good morning :D |
14:12 |
|
|
calire left #koha |
14:12 |
|
* oleonard |
keeps getting himself into trouble today |
14:28 |
|
|
lukeG joined #koha |
14:32 |
|
|
inlibro joined #koha |
14:49 |
|
oleonard |
fridolin++ |
14:51 |
|
* fridolin |
on fire ;) |
14:51 |
|
ashimema |
nice :) |
14:56 |
|
reiveune |
bye |
14:56 |
|
|
reiveune left #koha |
15:20 |
|
|
lisettelatah joined #koha |
15:26 |
|
koha-jenkins |
Project Koha_19.05_U18 build #28: SUCCESS in 29 min: https://jenkins.koha-community[…]oha_19.05_U18/28/ |
15:30 |
|
|
laurence left #koha |
15:31 |
|
|
fridolin left #koha |
15:32 |
|
|
inlibro joined #koha |
15:33 |
|
koha-jenkins |
Project Koha_19.05_D9 build #29: SUCCESS in 37 min: https://jenkins.koha-community[…]Koha_19.05_D9/29/ |
15:36 |
|
koha-jenkins |
Project Koha_19.05_D8 build #27: SUCCESS in 42 min: https://jenkins.koha-community[…]Koha_19.05_D8/27/ |
16:06 |
|
|
lukeG joined #koha |
16:08 |
|
corilynn |
anyone else notice that all of the sandboxes are borked? |
16:26 |
|
ashimema |
:( |
16:31 |
|
|
Mandersoon_ joined #koha |
16:32 |
|
|
inlibro joined #koha |
17:32 |
|
|
inlibro joined #koha |
17:36 |
|
wizzyrea |
yes the sandboxes are borked |
17:40 |
|
|
lisettelatah joined #koha |
17:41 |
|
|
JesseM joined #koha |
18:16 |
|
|
amoyano joined #koha |
18:31 |
|
caroline_catlady |
Does it bother anyone else that in the adv search, the ccodes, itemtypes and locations are ordered horizontally instead of vertically? |
18:32 |
|
oleonard |
I'm used to it caroline_catlady, but I can understand why it might |
18:33 |
|
|
inlibro joined #koha |
18:33 |
|
oleonard |
The layout was limited by limitations in HTML/CSS which have now changed, so it could be revisited |
18:33 |
|
caroline_catlady |
I fell like since they are in columns, my eye is drawn vertically |
18:34 |
|
caroline_catlady |
how could I do it in css? |
18:34 |
|
oleonard |
using flexbox or CSS grids, but I'm not sure you could work with the existing HTML. It may require template changes |
18:35 |
|
oleonard |
I don't know off the top of my head because I'm not fluent in either one |
18:35 |
|
caroline_catlady |
ah ok never mind then, but thanks for confirming i'm not too crazy :) |
18:35 |
|
oleonard |
caroline_catlady: It might be worth filing a bug |
18:36 |
|
ashimema |
what's wrong with the sandboxes caroline_catlady |
18:36 |
|
ashimema |
? |
18:37 |
|
caroline_catlady |
uh not sure, I don't use them |
18:37 |
|
caroline_catlady |
but others seem to think they are not working |
18:37 |
|
oleonard |
wizzyrea and corilynn noticed |
18:37 |
|
ashimema |
I have one provissioning right now.. so far looks like it's all going to plan |
18:37 |
|
ashimema |
oh sorry.. it was corilynn who asked |
18:37 |
|
caroline_catlady |
no worries, our names are similar, I wonder if she's a cat lady too |
18:38 |
|
ashimema |
hehe |
18:38 |
|
corilynn |
i'm not, hubby is alergic |
18:38 |
|
corilynn |
ashima, when i use the links for the europe ones off of the sandboxes page it gives me an error |
18:38 |
|
caroline_catlady |
aw, poor him! |
18:39 |
|
ashimema |
http://sandboxes.ptfs-europe.co.uk/ |
18:39 |
|
ashimema |
those? |
18:39 |
|
wahanui |
those are all sensible |
18:39 |
|
corilynn |
for the bywater ones it puts me in the installer after everything is done |
18:39 |
|
corilynn |
oh, no, that link i haven't tried |
18:40 |
|
ashimema |
the older style one's aren't well maintained here.. |
18:40 |
|
corilynn |
I don't know what "all sensible" means |
18:40 |
|
ashimema |
I need to deprecate them |
18:41 |
|
ashimema |
I just can't keep up with maintaining them on top of everything else :( |
18:41 |
|
corilynn |
I was talking about the links off of here: https://wiki.koha-community.org/wiki/Sandboxes |
18:41 |
|
ashimema |
the first link is the same as the one I gave you above |
18:41 |
|
ashimema |
there are two other which do indeed lead to an error |
18:41 |
|
ashimema |
I will take a look at those at some point |
18:42 |
|
corilynn |
The Biblibre ones: http://pro.user05-koha.sandbox[…]n/koha/sandbox.pl |
18:42 |
|
corilynn |
say "Software error" |
18:42 |
|
ashimema |
same error.. somethings changed in master to break them i reckon |
18:43 |
|
corilynn |
ah |
18:43 |
|
corilynn |
well, thus "borked" |
18:43 |
|
corilynn |
I'll try the docker europe one |
18:44 |
|
ashimema |
does the same thing as bywater.. |
18:44 |
|
ashimema |
drops into the installer |
18:44 |
|
ashimema |
which is odd |
18:46 |
|
corilynn |
sad trombone sound... |
18:46 |
|
ashimema |
khall about? |
18:46 |
|
corilynn |
I think kidclamp said they were away on break |
18:47 |
|
kidclamp |
he is back monday |
18:47 |
|
kidclamp |
ashimema: our issue is some mysql setting |
18:47 |
|
kidclamp |
too big packets? |
18:47 |
|
ashimema |
in a different note.. you can get past the webinstaller |
18:47 |
|
ashimema |
just run through it.. |
18:47 |
|
* oleonard |
is startled out of his chair as kidclamp appears out of nowhere |
18:47 |
|
corilynn |
i am unaware of the user/pass as koha/koha isn't working |
18:47 |
|
ashimema |
login = 'koha_intsancename', password is always 'password' |
18:47 |
|
corilynn |
ah |
18:48 |
|
ashimema |
so.. for the instance I just setup.. it's `koha_mine`/`password` |
18:48 |
|
corilynn |
look at that millisecond difference between question and answer |
18:48 |
|
kidclamp |
BD::mysql::st execute failed: Got a packet bigger than 'max_allowed_packet' bytes at /usr/share/perl5/DBIx/RunSQL.pm line 273. |
18:48 |
|
corilynn |
yeah, i saw that error |
18:48 |
|
corilynn |
max_allowed_packet is a php setting, isn't it? |
18:48 |
|
* kidclamp |
is always watching oleonard |
18:49 |
|
kidclamp |
unless it would be convenient, then you won't find me for days |
18:49 |
|
* oleonard |
agrees and glares at the dishes piling up in the sink |
18:50 |
|
ashimema |
very odd |
18:50 |
|
ashimema |
we're just using koha-testing-docker under the hood and I'm not seeing any issues with that like this |
18:58 |
|
oleonard |
Have a good weekend everyone |
19:31 |
|
|
Mandersoon joined #koha |
19:33 |
|
|
inlibro joined #koha |
20:00 |
|
wizzyrea |
hey kidclamp i've kinda solved that sandboxes thing |
20:00 |
|
wizzyrea |
but I don't know if I solved it the right way |
20:00 |
|
wizzyrea |
and i don't know why it's suddenly doing that thing |
20:01 |
|
wizzyrea |
it's testing docker, but with one db server for all of the sandboxes, I think |
20:01 |
|
wizzyrea |
one db docker server |
20:01 |
|
wizzyrea |
at least, that's what it looked like |
20:02 |
|
wizzyrea |
:/ |
20:26 |
|
|
papa joined #koha |
20:33 |
|
|
inlibro joined #koha |
20:39 |
|
wizzyrea |
hi papa |
20:50 |
|
|
cait joined #koha |
20:53 |
|
wizzyrea |
hi cait |
21:09 |
|
kidclamp |
Go wizzy! |
21:33 |
|
|
inlibro joined #koha |
21:33 |
|
|
davidnind joined #koha |
22:33 |
|
|
inlibro joined #koha |
22:52 |
|
caroline_catlady |
have a good weekend everyone! |
22:58 |
|
|
kathryn joined #koha |
23:34 |
|
|
inlibro joined #koha |