IRC log for #koha, 2019-06-25

All times shown according to UTC.

Time S Nick Message
00:23 inlibro joined #koha
01:09 dpk__ joined #koha
01:15 lukeG joined #koha
01:23 inlibro joined #koha
01:33 AnnaBoten joined #koha
01:42 irma_ joined #koha
02:23 inlibro joined #koha
03:11 Nemo_bis joined #koha
03:15 aleisha_ joined #koha
03:23 inlibro joined #koha
04:02 clrh joined #koha
04:23 inlibro joined #koha
05:21 dpk__ joined #koha
05:23 inlibro joined #koha
05:35 calire joined #koha
05:46 cait joined #koha
05:47 JesseM_ joined #koha
06:13 ashimema Morning #koha
06:24 inlibro joined #koha
06:26 AndrewIsh joined #koha
06:31 slef joined #koha
06:47 reiveune joined #koha
06:47 reiveune hello
06:58 alex_a joined #koha
06:58 alex_a Bonjour
07:06 laurence joined #koha
07:11 paul_p joined #koha
07:11 ashimema Anyone here any good with selenium
07:12 ashimema I have absolutely not idea why I have a failing test
07:12 ashimema Testing manually the case it's testing works perfectly
07:12 ashimema Reading the test it looks like it should still be working
07:12 ashimema Yet.. it's failing really concsistently
07:12 fridolin joined #koha
07:13 fridolin hi
07:24 liliputech_asu hi koha :)
07:24 inlibro joined #koha
07:32 greenjimll joined #koha
07:33 calire morning
07:41 alex_a_ joined #koha
08:20 sophie_m joined #koha
08:24 inlibro joined #koha
08:28 sophie_m joined #koha
08:34 calire anyone had any issues with devbox? Specifically - mine is currently hanging when I try to go to localhost in the browser, so I cannot open Koha
08:36 calire at one point it  gave me a 502 Proxy Error - but since then it just hangs if I retry, anyone know what that means? I'm only accessing it via localhost
08:40 ashimema sorry.. not I
08:40 * ashimema uses koha-testing-docker prediminantly now instead
08:40 ashimema any SRU pro's here..
08:40 ashimema do we allow filtering by item location via SRU?
08:41 * ashimema thinks not.. but doesn't want to report the wrong thing and hasn't found any code that says either way yet
08:43 calire it worked yesterday and I changed nothing in between :(
08:43 ashimema grr
08:43 ashimema sounds much like my failing selenium test
08:43 ashimema nothing around it has changed in the code.. yet it now fails every time
08:45 ashimema I've added a followup to bug 23191 to address the confusing output alex_a. would appreciate any further feedback you may have :)
08:45 huginn` Bug[…]_bug.cgi?id=23191 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Administrators should be able to install plugins from the command line
08:52 ashimema calire still here
08:53 ashimema can i pick you're brains about expectations for the action_logs with regards borrower change details?
08:53 ashimema I 'think' I remember you getting excited about this one when it was first pushed
08:55 calire errrm
08:55 calire doesn't ring a bell
08:56 ashimema my question is.. given action_logs records a timestamp for when the action took place.. is the 'updated_on' field change from the borrowers table worth recording.
08:58 calire still doesn't ring a bell - is there a bug this is related to?
08:59 ashimema https://bugs.koha-community.or[…]_bug.cgi?id=22741
08:59 huginn` Bug 22741: normal, P5 - low, ---, martin.renvoize, Needs Signoff , Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity
09:00 ashimema bug 3820 is the original where we introduced the more detailed logging
09:00 calire I don't think it was me that was excited. I've not seen this before
09:00 huginn` Bug[…]w_bug.cgi?id=3820 enhancement, P5 - low, ---, martin.renvoize, RESOLVED FIXED, More detailed patron record changes log
09:01 ashimema no worries
09:02 calire sorry
09:24 inlibro joined #koha
09:33 vfernandes joined #koha
09:43 kidclamp morning
09:43 * calire waves
10:05 sophie_m joined #koha
10:24 inlibro joined #koha
10:25 Joubu joined #koha
10:32 fridolin left #koha
10:41 ashimema mental note.. don't do a `git gc --agressive --prune=now` on your koha git clone
10:41 alex_a joined #koha
10:41 ashimema it managed to fill all 16gb of ram of my i7 desktop and bring it to it's knees
10:52 khall joined #koha
11:17 oleonard joined #koha
11:19 oleonard Hi folks
11:20 ashimema hi oleonard
11:20 wahanui hi oleopard
11:20 calire hi oleonard
11:20 wahanui hi oleopard
11:24 inlibro joined #koha
11:41 alex_a joined #koha
11:56 fridolin joined #koha
12:15 oleonard_ joined #koha
12:17 ashimema can anyone out there double check for me that on master the add to basket and remove from basket features both work in the opac
12:18 * ashimema is still doing battle with selenium and is starting to doubt his own eys
12:18 alex_a_ joined #koha
12:20 oleonard_ Works for me ashimema
12:20 oleonard That oleonard_ fellow is so helpful. I should be more like him.
12:23 ashimema thanks
12:25 inlibro joined #koha
12:33 ashimema did you change how the cart functionality works at all in your patch to make the toolbar float oleonard?
12:33 oleonard Not intentionally  :|
12:33 ashimema selenium no longer seems to be able to select the remove button for any items in the cart
12:34 ashimema looking at the failure screenshot it's as though it's trying to select it just before it's actually been unhidden
12:38 ashimema ps.. now I'm looking at that bar in minute detail the 'Unhighlight' option appears slightly mis-aligned vertically ;)
12:40 * ashimema wonders if it's because it's a div rather than a span like the other clickables in that toolbar
12:40 ashimema oleonard ^
12:41 oleonard I may be misunderstanding what exactly you're testing
12:41 oleonard (aside from the icon thing which I've seen too)
12:41 ashimema I think you're probably testing right.. I got the same result
12:42 ashimema I just can't get selenium to be happy.. it gets a different result
12:42 oleonard But what exactly is selenium testing
12:42 ashimema I'll pester Joubu or tcohen about it when they appear
12:42 ashimema so..
12:43 ashimema selenium tests that you can click 'Add to your cart' on an item and then tests that the number of items in the cart display is updated up top
12:43 oleonard Click add to cart for an individual title in search results?
12:43 ashimema it then 'clicks' the 'remove' (which appears next to 'In your cart' on the item once you've added said item to the cart
12:43 ashimema currently selenium explodes at this point being unable to perform the click as it can no longer find the 'remove'
12:44 ashimema individual title in search results.. yep
12:44 ashimema it's works 100% of the time for me in the UI.. but yeah.. selenium can no longer catch the remove button
12:44 ashimema the XPath hasn't changed as far as I can tell
12:45 ashimema and testing the XPath in the browsre shows it's still correct
12:46 ashimema but.. the screenshot at the time of failure is indeed somewhat funky:
12:47 oleonard Is this a new test or something which changed with Bug 5287?
12:47 huginn` Bug[…]w_bug.cgi?id=5287 enhancement, P5 - low, ---, oleonard, Pushed to Master , Add floating toolbar to search results in OPAC
12:48 ashimema its started failing with 5287
12:48 ashimema test has been there for at leat 6 months
12:49 ashimema have we ever had selenium tests start to fail before because a floating toolbar started to get in the way of the click?
12:50 oleonard Not that I've been told. I've been stubbornly avoiding learning to make selenium tests, so I'm out of the loop. Please come to KohaCon 2020, tie me to a chair, and teach me.
12:51 ashimema hehe
12:51 ashimema would be a pleasure
12:51 ashimema once you get your head around them they're not so terrible.. untill they do things like this of course
12:52 ashimema is that the same floating lib we use in the staff client?
12:52 ashimema I saw you had to add a whole JS lib to do it
12:52 oleonard It's new to the OPAC but we've had it in the staff client for a little bit
12:52 ashimema okies
12:53 ashimema I thought that was the case
13:00 oleonard FWIW... Selenium is correct in that sometimes you can't click something because it's behind the toolbar...
13:01 ashimema indeed
13:12 mtompset joined #koha
13:14 mtompset Greetings, #koha.
13:15 ashimema this is driving me nuts
13:21 caroline_catlady joined #koha
13:21 caroline_catlady good morning!
13:24 oleonard Hi caroline_catlady
13:25 inlibro joined #koha
13:26 ashimema selenium click = scroll to element then click
13:26 oleonard Right... and if the element is scrolled to the top of the viewport it's suddenly hidden!
13:27 ashimema in this case.. scroll to element pops the floating toolbar for us.. which low and behind ends up sitting right over the element I want to click so bang.. selenium says "Hey, you can't click that.. it's underneath a toolbar"
13:27 ashimema yup
13:27 ashimema but the way click appears to work is I can't scroll and click independantly
13:27 oleonard I ran into that problem with the in-page links in the basic MARC editor
13:28 ashimema oh really
13:28 ashimema that's funny
13:28 ashimema did you resolve it?
13:29 oleonard I can't remember exactly what I did but I assume it isn't relevant to the way Selenium does it :(
13:29 tcohen morning
13:30 ashimema morning tcohen
13:30 caroline_catlady ho tcohen!
13:30 * caroline_catlady meant hi, but ho is good too...
13:31 oleonard Rustic
13:35 oleonard
13:51 khall joined #koha
13:56 mtompset Greetings, ashimema caroline_catlady oleonard tcohen
13:56 mtompset Greetings khall
13:56 caroline_catlady hi mtompset!
13:56 mtompset ashimema, selenium drives me nuts period.
13:57 mtompset If you have to write selenium tests, you haven't written your code properly. ;)
13:57 mtompset Controllers should be as bare as possible.
13:57 oleonard Wow
13:57 oleonard I guess technically speaking if you've written your Perl correctly you don't need tests either
13:58 mtompset Oh no... unit tests with prove you need.
13:58 ashimema lol
13:58 mtompset but the whole configure a system to pretend to click this and that...
13:58 mtompset only necessary if your controllers have too much code in them.
13:59 mtompset Sadly, Koha does.
13:59 mtompset (in places)
13:59 oleonard Way too much code all over the place
13:59 mtompset That's true.
13:59 oleonard The place is littered with it!
14:00 mtompset It's worse when people write the same function and stick it in two different places. ;)
14:00 mtompset I haven't hit that much.
14:00 mtompset But I have started to see TT optimizations along those lines.
14:01 mtompset Anyways, I do hope you solve your selenium pains, ashimema.
14:01 ashimema kidclamp and I are currently rubber ducking all sorts of weird and wacky ways to try and resolve it..
14:02 ashimema so far the least nasty one I think is to try and set a huge vertical for the window size in the hope that prevents the scroll action in selenium
14:02 mtompset I was looking at a bug this morning and thinking, "We don't have a 'decent localized number string to something usable in perl' function/method" -- anyone know of such a thing? If not, I have an attempt at one. :)
14:03 mtompset I was thinking of corrupting tcohen's code-baby Koha::Util::Normalize with it. :)
14:09 lukeG joined #koha
14:21 fridolin joined #koha
14:25 inlibro joined #koha
14:28 calire left #koha
14:28 tcohen mtompset: I think Joubu will kick you
14:30 wizzycray joined #koha
14:33 mtompset tcohen, so where should such a function be then?
14:46 laurence left #koha
14:49 oleonard Y'all should try Bug 23197. I think it's fun
14:49 huginn` Bug[…]_bug.cgi?id=23197 enhancement, P5 - low, ---, oleonard, Needs Signoff , Add more batch operation options to SQL report results
15:24 wizzycray joined #koha
15:24 huginn` News from kohagit: Bug 5287: (RM follow-up) Make tests basket compatible <[…]008af0c59d79edfe0>
15:25 inlibro joined #koha
15:31 ashimema :party:
15:38 ashimema ooh.. Dashboard got a cool update :)
15:38 ashimema
15:39 * ashimema like the 'Rescues' count.. much cooler than 'Pushed to' in my opinion.. gamifcation on!
15:41 mtompset But I don't understand how the Rescues counts.
15:42 ashimema Take a bug from 'Failed QA' or 'Patch doesn't apply' back to a more positive status and is counts as a 'Rescue'
15:42 ashimema it's my trying to game people into looking at some of the older stuck bugs and bring them back to life
15:43 ashimema could probably also include 'In Discussion'
15:43 wizzyrea joined #koha
15:43 ashimema but I didn't get that far yet
15:45 caroline_catlady bugs be like
15:45 ashimema hehe
15:58 koha-jenkins Yippee, build fixed!
15:58 wahanui Congratulations!
15:58 koha-jenkins Project Koha_Master_D9 build #789: FIXED in 29 min: https://jenkins.koha-community[…]ha_Master_D9/789/
16:01 koha-jenkins Yippee, build fixed!
16:01 wahanui Congratulations!
16:01 koha-jenkins Project Koha_Master_U18 build #286: FIXED in 36 min: https://jenkins.koha-community[…]a_Master_U18/286/
16:01 mtompset ashimema, Ah... sadly, I've moved some from doesn't apply to failed. :)
16:01 ashimema lol
16:02 mtompset because doesn't apply... tend to not get looked at again.
16:02 ashimema well.. that sorta counts I think.. I don't check what you go too.. just what you go from
16:02 mtompset failed... kind of moves it to a place where it is more likely to be looked at.
16:02 huginn` News from kohagit: Bug 22566: (QA follow-up) Fix pod complaint <[…]85669ba13deb38c7d>
16:02 huginn` News from kohagit: Bug 23082: Fatal error editing a restricted patron <[…]443d392b9df17e2aa>
16:02 huginn` News from kohagit: Bug 22566: Add 'branch' key to GetPreparedLetter <[…]02e9609e2d89f7be9>
16:02 huginn` News from kohagit: Bug 22566: Clarify intent of reports and add warnings <[…]347cc741d456c20c5>
16:02 huginn` News from kohagit: Bug 22566: Rename 'report_email' to 'report_by_branch' <[…]365dbe2b3d1d22d23>
16:02 huginn` News from kohagit: Bug 22566: Accept 'all' in the branch params <[…]8ebf4f2960af199fa>
16:02 huginn` News from kohagit: Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an... <[…]5b96a3cf439e0126c>
16:02 huginn` News from kohagit: Bug 22566: Fix some more issues <[…]3d0d1d4a9d7295c5a>
16:02 huginn` News from kohagit: Bug 22949: Markup error in OPAC course reserves template <[…]596d33f1bd184fb9b>
16:02 huginn` News from kohagit: Bug 22566: Fix some problems <[…]ec4d73267a0070447>
16:02 ashimema indeed
16:03 mtompset arg... vagrant box update...
16:03 mtompset 6-7 minute wait.
16:03 mtompset I wish I had faster internet.
16:04 mtompset But the ISP here keeps telling us about fiber optic internet in Toronto... but they don't offer it here in a suburban/rural place.
16:05 ashimema mtompset.. it's the git clone that takes all the time right?
16:05 ashimema joubu and I are actually working on that at the minute.. attempting to shrink the repo
16:06 ashimema I'm slightly worried about the method at the moment but haven't come up with a better one
16:06 ashimema we're pretty much attempting to follow through on 'option 3' here: https://wiki.koha-community.or[…]ing_and_Shrinking
16:09 koha-jenkins Yippee, build fixed!
16:09 wahanui Congratulations!
16:09 koha-jenkins Project Koha_Master_D8 build #301: FIXED in 41 min: https://jenkins.koha-community[…]ha_Master_D8/301/
16:15 mtompset ashimema, No, vagrant box update is downloading the base box.
16:15 mtompset Bionic changed.
16:15 mtompset Even though I don't use it.
16:15 ashimema oh fun
16:16 mtompset Because vagrant needs to have the base boxes downloaded in the first place, so that vagrant up's based on the base box are "fast", otherwise you would be constantly downloading.
16:21 fridolin joined #koha
16:22 huginn` News from kohagit: Bug 23191: (follow-up) Improve output <[…]048c3c1aec62986d3>
16:22 huginn` News from kohagit: Bug 23126: Add tests <[…]00e490d87f8d60401>
16:22 huginn` News from kohagit: Bug 23191: Add commandline script to install plugins <[…]197994a7fff0410d8>
16:22 huginn` News from kohagit: Bug 23179: Add 'edit subfields' button to framework management <[…]ab02d3767c926ff08>
16:22 huginn` News from kohagit: Bug 23126: Remove more unnecessary linebreak processing from serial collection <[…]c1a51ca81a0017a8e>
16:22 huginn` News from kohagit: Bug 23156: Add pagination to checkouts in ILS-DI GetPatronInfo service <[…]d75951abee8df0116>
16:22 huginn` News from kohagit: Bug 23126: Display multi-line entries in subscrpitions correctly <[…]27e85fd79c6895237>
16:22 huginn` News from kohagit: Bug 23096: Add floating toolbar to OPAC lists <[…]191e07a5e7e13054a>
16:25 inlibro joined #koha
16:30 kidclamp ashimema++
16:31 kidclamp @karma
16:31 huginn` kidclamp: Highest karma: "Joubu" (754), "cait" (722), and "oleonard" (438).  Lowest karma: "-" (-59), "failed" (-41), and "ie" (-38).  You (kidclamp) are ranked 6 out of 950.
16:31 mtompset @karma
16:31 huginn` mtompset: Highest karma: "Joubu" (754), "cait" (722), and "oleonard" (438).  Lowest karma: "-" (-59), "failed" (-41), and "ie" (-38).  You (mtompset) are ranked 25 out of 950.
16:31 mtompset That's pretty good since I dropped off the map for a few months.
16:33 koha-jenkins Project Koha_Master_D9 build #790: SUCCESS in 29 min: https://jenkins.koha-community[…]ha_Master_D9/790/
16:39 reiveune bye
16:39 reiveune left #koha
16:41 koha-jenkins Project Koha_Master_U18 build #287: SUCCESS in 36 min: https://jenkins.koha-community[…]a_Master_U18/287/
16:51 koha-jenkins Project Koha_Master_D8 build #302: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_Master_D8/302/
17:03 fridolin left #koha
17:14 oleonard See y'all later
17:17 ashimema @karma
17:17 huginn` ashimema: Highest karma: "Joubu" (754), "cait" (722), and "oleonard" (438).  Lowest karma: "-" (-59), "failed" (-41), and "ie" (-38).  You (ashimema) are ranked 5 out of 950.
17:17 ashimema Woopie, all passing
17:18 * ashimema tries to remember how to get the other karma bot
17:18 ashimema Karma
17:19 ashimema Karma?
17:19 ashimema huginn` karma
17:19 huginn` ashimema: Highest karma: "Joubu" (754), "cait" (722), and "oleonard" (438).  Lowest karma: "-" (-59), "failed" (-41), and "ie" (-38).  You (ashimema) are ranked 5 out of 950.
17:19 ashimema Hmm.. that's the same one
17:19 ashimema I'm sure there's two
17:19 koha-jenkins Project Koha_Master_D9 build #791: UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_Master_D9/791/
17:20 ashimema Noooooo
17:26 inlibro joined #koha
17:27 koha-jenkins Project Koha_Master_D8 build #303: SUCCESS in 24 min: https://jenkins.koha-community[…]ha_Master_D8/303/
17:28 mtompset @karma ashimema
17:28 huginn` mtompset: Karma for "ashimema" has been increased 377 times and decreased 0 times for a total karma of 377.
17:28 mtompset Is that what you were looking for ashimema?
17:28 mtompset @karma mtompset
17:28 huginn` mtompset: Karma for "mtompset" has been increased 68 times and decreased 0 times for a total karma of 68.
17:44 ashimema Maybe.. I'm thought we have two different karma bots here.. one which hasn't been reset in many years and another which has.. they used to give fairly different but interesting results
17:44 alex_a joined #koha
17:47 koha-jenkins Project Koha_Master_U18 build #288: UNSTABLE in 56 min: https://jenkins.koha-community[…]a_Master_U18/288/
17:52 mtompset ashimema, I don't think so. I believe they reset the karma every calendar year or so.
18:01 cait joined #koha
18:04 ashimema Fair enough, perhaps I imagined it
18:19 ashimema karma ashimema
18:19 wahanui ashimema has karma of 187
18:19 ashimema @karma ashimema
18:19 huginn` ashimema: Karma for "ashimema" has been increased 377 times and decreased 0 times for a total karma of 377.
18:19 ashimema told ya!
18:19 ashimema ;)
18:19 ashimema is it really sad that I went miles back in the irc logs to find where I'd had that conversation
18:19 ashimema karma koha-testing-docker
18:19 wahanui koha-testing-docker has neutral karma
18:20 ashimema @karma koha-testing-docker
18:20 huginn` ashimema: Karma for "koha-testing-docker" has been increased 2 times and decreased 0 times for a total karma of 2.
18:20 ashimema karma++
18:26 inlibro joined #koha
18:57 cait kidclamp: just commented on bug 23201
18:57 huginn` Bug[…]_bug.cgi?id=23201 normal, P5 - low, ---, koha-bugs, NEW , Changing languages on the OPAC redirects to opac-main which logs out SCO/SCI users
18:59 cait kidclamp: i haven't checked for sco... but we do preserve location for staff and opac for sure
18:59 kidclamp I have base url set in my testing docker
19:00 kidclamp but I get redirected to home every time I change
19:00 cait on the normal opac pages too?
19:00 * kidclamp nods
19:00 cait can you double check base url?
19:00 kidclamp I would believe a setup provlem
19:00 cait firing up my system
19:00 cait do you look at master or 18.11?
19:01 kidclamp master
19:01 cait i just tested in our 18.11 - definitely works there
19:03 cait ent to search opac authorities... then switched language
19:04 cait stayed on authorities
19:04 kidclamp kk, may be my setup
19:04 cait still waiting for my devbox
19:05 cait just worried we broke that (again)
19:05 cait we did in the past :)
19:05 kidclamp 18,11 I see it works
19:05 cait more like :(
19:05 kidclamp test sco please though, as it is fussy
19:05 cait i need another user for htat, takes a moment
19:05 cait master or18.11?
19:05 kidclamp maste
19:05 kidclamp r
19:06 kidclamp I would be happy to be wrong
19:07 ashimema Selenium tests needed for that me reckons
19:10 cait it appears to log me out of sco
19:11 cait actually
19:11 cait I forgot to fix my baseurl trying agian
19:12 cait it appears broken
19:12 cait that makes me grumpy
19:12 kidclamp do pther areas work?
19:13 cait opac doesn't
19:13 kidclamp sorry
19:13 cait hm i had my base urls wrong... and again
19:14 cait sorry, not testing well tonight :(
19:14 cait it happens still
19:14 cait :(
19:14 cait gr.
19:14 cait i think you can make your bug more general
19:14 cait i can't test in 19.05 easily - someone has an installation around?
19:26 inlibro joined #koha
19:27 cait ashimema: kidclamp no longer here? :)
19:29 kidclamp running away soon
19:30 cait ok, just commented... ths might be a bigger bug
19:31 paul_p joined #koha
19:31 cait i tried to go back in time a bit... but couldn't find it working on devbox several 100 commits past... might be something config/setup related, ont sure
19:44 paul_p joined #koha
19:52 ashimema What bug number?
19:52 ashimema Also mostly not here, but watching in the background
20:10 cait bug 23201 seems to have a wider scope
20:10 huginn` Bug[…]_bug.cgi?id=23201 normal, P5 - low, ---, koha-bugs, NEW , Changing languages on the OPAC redirects to opac-main which logs out SCO/SCI users
20:10 cait and it's late
20:10 cait you should not be here
20:26 inlibro joined #koha
20:40 alex_a joined #koha
20:52 alexbuckley joined #koha
21:26 inlibro joined #koha
22:19 JesseM joined #koha
22:24 caroline_catlady good night everyone!
22:26 inlibro joined #koha
23:16 killer_bee[m] joined #koha
23:27 inlibro joined #koha
23:30 papa joined #koha

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary