IRC log for #koha, 2015-12-01

All times shown according to UTC.

Time S Nick Message
00:47 pianohacker hi dcook
00:50 dcook yo pianohacker
01:01 JoshB joined #koha
02:12 tcohen joined #koha
02:14 tcohen hi
02:37 wizzyrea hi tcohen :)
02:41 JoshB joined #koha
02:43 rocio left #koha
03:30 chrisvella joined #koha
03:53 chrisvella joined #koha
04:10 cdickinson joined #koha
05:22 STACY joined #koha
05:24 cait joined #koha
05:39 mario joined #koha
06:12 cdickinson_ joined #koha
06:18 cait left #koha
06:55 * magnuse waves
06:59 rangi hi magnuse
07:06 magnuse kia ora rangi
07:09 magnuse @wunder wellington
07:09 huginn magnuse: Error: No such location could be found.
07:09 magnuse @wunder wellington, nz
07:09 huginn magnuse: The current temperature in Wellington, New Zealand is 17.0°C (8:00 PM NZDT on December 01, 2015). Conditions: Light Rain Showers. Humidity: 94%. Dew Point: 16.0°C. Pressure: 30.33 in 1027 hPa (Steady).
07:10 magnuse @wunder boo
07:10 huginn magnuse: The current temperature in Bodo, Norway is -1.0°C (7:50 AM CET on December 01, 2015). Conditions: Snow Showers. Humidity: 100%. Dew Point: -1.0°C. Windchill: -6.0°C. Pressure: 29.15 in 987 hPa (Rising).
07:10 eythian @wunder alexandra, nz
07:10 huginn eythian: The current temperature in Molyneux Estate, Alexandra, New Zealand is 23.3°C (8:09 PM NZDT on December 01, 2015). Conditions: Mostly Cloudy. Humidity: 58%. Dew Point: 15.0°C. Pressure: 29.99 in 1015 hPa (Falling).
07:10 eythian my parents were telling me all about it :/
07:10 magnuse lulz, where is that? in the north?
07:11 * magnuse wanders over to google maps
07:11 rangi heya eythian, how's living above a canal going?
07:12 magnuse oh, way down in the south!
07:12 eythian magnuse: yeah, where my parents live, it's inland enough to get hot (and cold in winter)
07:13 eythian rangi: it's OK, cept I have a terrible cold right on my first week of work.
07:13 magnuse ouch!
07:13 eythian just emailed to start looking for a real apt though, that'll be good
07:13 eythian (this one is a bit out of the way, in the next city over.)
07:13 magnuse @wunder amstelveen
07:13 huginn magnuse: The current temperature in v. H. Goedhartlaan, Amstelveen - North, Amstelveen, Netherlands is 7.8°C (8:13 AM CET on December 01, 2015). Conditions: Overcast. Humidity: 90%. Dew Point: 6.0°C. Windchill: 8.0°C. Pressure: 30.12 in 1020 hPa (Steady).
07:15 magnuse clutha river - any trout in there?
07:15 eythian yes
07:15 eythian (well, I'm pretty sure - there's trout in many rivers around there.)
07:27 magnuse yay
07:28 * magnuse read books about fishing trout in nz while growing up
07:33 eythian I used to go fishing for trout in NZ while growing up ☺
07:37 magnuse lucky you :-)
07:37 magnuse on the other hand, i used to go fishing for trout in norway while growing up ;-)
07:37 magnuse i hope i can pass that interest on to my 3.5 year old...
07:44 reiveune joined #koha
07:45 reiveune hello
07:47 fridolin joined #koha
07:47 magnuse bonjour reiveune et fridolin
07:50 reiveune salut magnuse
07:50 alex_a joined #koha
07:51 alex_a bonjour
07:51 wahanui niihau, alex_a
07:55 fridolin joined #koha
08:03 Joubu hello
08:29 sophie_m joined #koha
08:30 paul_p joined #koha
08:37 laurence joined #koha
09:02 mario joined #koha
09:09 laurence left #koha
09:17 magnuse this is weird. i am helping out with an installation someone else did. when we go to "about koha" we get the error "DBIC result type  isn't of the type Borrower at /usr/share/koha/lib/Koha/Objects.pm line 87"
09:17 magnuse anyone else seen that?
09:18 magnuse everything else seems normal
09:18 magnuse and it's not using the "database user"
09:19 magnuse and it's version 3.20.5, installed using the debian packages
09:19 magnuse i can not reproduce on other 3.20.5 installs
09:22 andreashm joined #koha
09:23 Joubu magnuse: check the pref AnonymousPatron
09:23 * andreashm waves
09:23 Joubu magnuse: it's certainly related to l.91&92 of about.pl
09:25 magnuse it is set to 0123456 which looks kind of random...
09:26 magnuse there is a patron with that cardnumber, but AnonymousPatron should take the borrowernumber, right?
09:27 Joubu magnuse: yes it's a borrowernumber, but I have tested with a nonexistent borrowernumber and I didn't get the dbic error
09:28 magnuse well it worked for me! i changed from the cardnumber to the borrowernumber, and now "about koha" displays as it should
09:28 magnuse Joubu++
09:31 Joubu hum, weird :)
09:31 Joubu There is a bug anyway
09:35 magnuse i'll see if i can reproduce
09:35 magnuse hiya andreashm
09:36 andreashm hey magnuse!
09:36 wahanui magnuse is a Norwegian giant.
09:37 magnuse mohahaha
09:37 andreashm that never gets old, does it? =)
09:41 magnuse :-)
09:42 khall joined #koha
09:42 andreashm hi khall
09:53 magnuse hm, i cant reproduce it either (on my master/dev install). Joubu: do you still think i should report it as a bug?
09:54 magnuse ah, i *can* reproduce on 3.20.5
09:55 Joubu magnuse: if you manage to understand when it fails, it could be good to get a patch for it, yes :)
09:55 Joubu I have tried with a non existent borrowernumber and didn't get the error
09:56 Joubu ha, I get the error  with "0123456" :)
10:00 Joubu magnuse: fixed by 6882949b1b3bd1284e3d2877244a64edee3883ca
10:01 Joubu well no, forget that. It's fixed by this patch on master, but it's not a standalone patch
10:04 magnuse bug 13967
10:04 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=13967 enhancement, P5 - low, ---, kyle, Pushed to Master , Add package for System preferences
10:07 magnuse i'll report it as a bug in 3.20.5 then
10:07 Joubu magnuse: I am on it
10:07 Joubu 2sec
10:08 Joubu magnuse: bug 15270
10:08 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=15270 normal, P5 - low, ---, jonathan.druart, ASSIGNED , Koha::Objects->find can exploded if searching for nonexistent record
10:09 magnuse ah, cool!
10:17 drojf joined #koha
10:17 drojf hi #koha
10:19 Joubu magnuse: it's now waiting for a signoff ;)
10:21 magnuse Joubu: i'll see what i can do after lunch
10:21 magnuse tanks for a quick fix!
10:25 Francesca joined #koha
10:49 Joubu magnuse: what does the save op in members/nl-search.pl?
10:50 mveron joined #koha
10:50 mveron Hi #koha
11:00 sophie_m joined #koha
11:55 drojf Joubu: thanks for trying the tests without 11842. on the plus side, we have more room for optimizing if its not relevant ;)
11:57 Joubu drojf: it's not for the selenium tests, but it could be for something else :)
11:58 drojf it is definitely for opac searching
11:59 drojf but what looks like huge improvements on the raspi may not be much on a real server ;) anyway its pretty good to test these things
12:00 drojf i am trying to have a little less loops in search. like getting xml records immediately instead of a blog (which is actually xml too) and convert it several times later. looks like it still works, i only broke facets ;)
12:00 drojf *blob
12:13 drojf later #koha
12:23 mveron-away joined #koha
12:32 laurence joined #koha
12:47 tcohen joined #koha
12:50 tcohen joined #koha
12:50 oleonard joined #koha
12:50 oleonard Hi #koha
12:54 chris_n heya oleonard
12:54 wahanui hmmm... oleonard is still here, if you just wish hard enough. or Koha's master UI designer
12:56 tcohen hi
12:56 wahanui salut, tcohen
12:58 tcohen joined #koha
12:58 tcohen morning
12:59 * magnuse waves
13:00 laurence left #koha
13:01 magnuse Joubu: sorry for the delay. it takes data from the national patron database and saves it as a new user in koha
13:03 Joubu magnuse: I was wondering if erasing the existing patron attributes was the expected behavior
13:07 wnickc joined #koha
13:11 magnuse Joubu: does it do that?
13:12 Joubu 141         SetBorrowerAttributes($borrowernumber, [ { code => 'fnr', value => $cgi->param('fnr_hash') }, ] );
13:13 Joubu SetBorrowerAttributes does a DELETE FROM attr where borrowernumber=$borrowernumber
13:13 Joubu So yes, I think it does
13:14 magnuse yeah, but it is done for a patron that was created a few lines before, so i don't think that is a problem
13:16 Joubu magnuse: ha yes, exact! I thought it was called on update too.
13:18 khall left #koha
13:18 khall joined #koha
13:19 magnuse it is just the save that is special, because it gets the data from the national database. updates are not treated in a special way, as far as i remember
13:21 fridolin left #koha
13:22 fridolin joined #koha
13:31 fridolin joined #koha
13:34 gaetan_B joined #koha
13:39 nengard joined #koha
13:41 xarragon So when I am implementing something specific to certain country, can I just hardcode any message strings in that countrys language, or should I use some translation facilities?
13:42 magnuse xarragon: i have done it english and let it be picked up by the translation tools. but there might be a better way
13:42 xarragon magnuse: Well that sounds more proper than hardcoding it.
13:43 xarragon I have looked at the libraries integrated with this service, some use english, some use swedish and the interface itself is available in english and swedish, but there is no way to request a specific language it seems (for the requests tot he local library for item status)
13:49 andreashm joined #koha
13:54 Dyrcona joined #koha
13:55 wilfrid joined #koha
13:55 talljoy joined #koha
14:05 JoshB joined #koha
14:07 mario joined #koha
14:09 NateC joined #koha
14:11 mveron-away joined #koha
14:12 mario joined #koha
14:18 sophie_m joined #koha
14:26 magnuse wow, nso is below 200!
14:27 fridolin left #koha
14:28 Dyrcona joined #koha
14:29 meliss joined #koha
14:30 meliss left #koha
14:33 cma joined #koha
14:36 nengard morning all
14:37 oleonard Hi nengard
14:37 nengard oleonard!!!!!!!!
14:37 wahanui oleonard is not really here.  He said so.  He did!
14:37 nengard WOOO HOO :) hehe
14:37 * nengard missed oleonard
14:38 oleonard Thanks nengard I missed you too!
14:38 nengard how are things?
14:39 oleonard Things are fine. My web site rebuilding project is done so I get to be "distracted" by Koha again :)
14:39 sophie_m joined #koha
14:50 xarragon Hmm, how are item statuses defined in Koha anyway?
14:50 xarragon I see that some item hashes have specific keys for 'damaged' etc.
14:50 xarragon Is there some formal definition for the status?
14:52 fridolin joined #koha
14:54 drojf joined #koha
14:54 nengard oleonard koha distractions are good :)
14:54 oleonard No argument from me
15:01 amyk joined #koha
15:22 nengard drawing a blank - what is the sys pref that lets you decide if the name or barcode shows on the patron circ history  ....
15:23 stacy joined #koha
15:25 fridolin left #koha
15:29 meliss joined #koha
15:32 mario joined #koha
15:39 cma joined #koha
15:42 mario joined #koha
15:57 pianohacker joined #koha
15:57 pianohacker mornin'
15:58 mveron Hi again everybody
15:59 mveron t/db_dependent/Reserves.t fails with test 14  - is it only me or can anybody confirm?
15:59 mveron Bug 15244
15:59 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=15244 normal, P5 - low, ---, koha-bugs, NEW , t/db_dependent/Reserves.t fails with test 14
16:01 phasefx joined #koha
16:03 burdsjm joined #koha
16:03 drojf joined #koha
16:07 barton joined #koha
16:08 TGoat joined #koha
16:10 reiveune bye
16:10 reiveune left #koha
16:10 pianohacker mveron: so just prove on that test?
16:10 mveron pianohacker: Thet would be great!
16:10 mveron Thanks!
16:10 * mveron is called to a meeting...
16:21 pianohacker mveron: responded to the bug
16:30 pianohacker mveron: did that make sense?
16:31 mveron I'm still exploring...
16:35 mveron pianohacker: Commented on bug...
16:37 pianohacker well, okay, so it's not gremlins
16:37 pianohacker mveron: we'll have to bounce this off of srdjan or khall since they know the holds code
16:40 mveron khall: ^^   It would be great if you could have a look at Bug 15244
16:40 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=15244 normal, P5 - low, ---, koha-bugs, NEW , t/db_dependent/Reserves.t fails with test 14
16:40 khall I'll see what I can do mveron!
16:41 mveron Thanks!
16:41 mveron khall++
16:41 mveron pianohacker++
16:46 cdickinson_ joined #koha
16:48 janPasi__ is there documentation for borrower_permissions somewere?
16:48 janPasi__ i.e. which permission_module_id/permission_id is which permission?
16:49 oleonard Not strictly a Koha question, but if anyone has a moment: What could be a cause for incorrect sorting of simple (english) varchar data in mysql?
16:50 janPasi__ the change from flags/user_permissions broke some of our migration scripts severely, so I need to rewrite all the stuff that deals with setting permissions for the personnel
16:51 pianohacker oleonard: check the collation, could be swedish
16:51 pianohacker (really)
16:52 janPasi__ since the new permission system doesn't use clear "code" like the old user_permissions did, this seems to be a very laboursome task
16:52 janPasi__ unless it's properly documented somewere ofcourse
16:52 oleonard Thanks pianohacker I've checked the collation on the table column. Tried utf8_general_ci and utf8mb4_unicode_ci.
16:52 pianohacker janPasi__: are you talking about the 2.2 purely numeric permissions, or what change do you mean?
16:53 pianohacker huh, okay. That's odd, oleonard
16:53 janPasi__ pianohacker: nope, I recently did an upgrade to a newer koha-version from our national koha-git repository
16:54 pianohacker janPasi__: from which version to which version?
16:54 janPasi__ pianohacker: well that's the weird thing, from 3.16 to 3.16 :D
16:54 pianohacker odd. Which minor versions?
16:54 janPasi__ pianohacker: but this new "3.16" seems to have a completely different permission system from the old 3.16
16:56 janPasi__ they both report 3.16.04.000
16:56 pianohacker wut
16:56 janPasi__ yeah, weird :D
16:56 Joubu janPasi__: what do you call a new permission system?
16:56 janPasi__ the old permission system that had "flags" in borrowers table and a separate user_permissions table seems to have gone
16:57 janPasi__ they're replaced with a new table called borrower_permissions
16:57 Joubu no, it's still present in current master
16:57 Joubu there is no borrower_permissions table
16:57 janPasi__ well we do :D
16:57 Joubu where do you see that?
16:58 janPasi__ well I see it in koha database :D
16:58 Joubu in your Koha database :)
16:58 janPasi__ plus that the user_permissions table is gone
16:58 janPasi__ as well as flags column from borrowers table
16:58 Joubu because you removed it?
16:58 janPasi__ nope, i think some database update removed it
16:58 janPasi__ i didn't touch it
16:59 Joubu a "borrower" permission has been removed recently
16:59 Joubu no, "borrow"
16:59 janPasi__ so this must have something to do with our national koha version
16:59 pianohacker janPasi__: it must, because community 3.16.04 does not have any mention of borrower_permissions
17:00 Joubu you have lost the user_permissions and the borrower.flags column? outch
17:00 Joubu I hope you have backup somewhere
17:00 pianohacker janPasi__: do you have a weird atomicupdate sitting around?
17:01 janPasi__ Joubu: yeah, but there is no problem with losing them :D the permissions got migrated to the new permission system, they seem to be correct
17:01 janPasi__ the problem is that I have to add some users and some permissions and I have no clue how to do that with borrower_permissions
17:02 janPasi__ i know how to do that with borrower.flags and user_permissions :D
17:02 Joubu Same for us, we cannot help you :)
17:03 janPasi__ i really dislike this new borrower_permissions table :D
17:03 janPasi__ it's horrible
17:04 pianohacker janPasi__: yeah, you need to poke your developer and tell them not to do crazy stuff and not send it to community
17:04 pianohacker we want all the crazy stuff!
17:04 janPasi__ http://pastebin.com/xXMC9nhc
17:04 janPasi__ i believe it's this
17:05 janPasi__ but i can't seem to find any documentation for it
17:06 Joubu janPasi__: Are you a Olli colleague?
17:07 janPasi__ sort of, yeah
17:07 janPasi__ I work in Oulu, he works in Joensuu
17:08 Joubu Maybe he was involved in this change
17:08 janPasi__ Unfortunately he is in cambodia, so I can't really ask him at the moment :D
17:08 janPasi__ but I'll try bugging someone in Joensuu
17:12 Joubu janPasi__: http://bugs.koha-community.org[…]_bug.cgi?id=14540
17:12 huginn Bug 14540: enhancement, P5 - low, ---, olli-antti.kivilahti, Needs Signoff , Move member-flags.pl to PermissionsManager to better manage permissions for testing.
17:12 Joubu here is your doc
17:12 Joubu good luck
17:16 janPasi__ we're in the middle of migration from old PallasPro system to Koha
17:16 janPasi__ these kind of things are exactly what we don't need right now
17:17 Joubu this is one of the risks when you use a fork and not the official version
17:17 janPasi__ well the fork has some other things that we absolutely need
17:19 pianohacker and there's the tradeoff...
17:21 janPasi__ :D
17:22 janPasi__ well i'll just call it a day for now and worry about it tomorrow
17:23 janPasi__ it's almost half past seven, we'll be closing at eight o'clock anyway
17:43 xarragon So what category would I stick a Sweden-specific item availability retrieval function in ILSDI?
17:44 xarragon "Level 1: Basic discovery interfaces"? It is basically a clone of GetAvailability
18:14 BobB joined #koha
18:18 wnickc joined #koha
18:27 rocio joined #koha
18:38 drojf i think its confusing when people on mailing lists state their problem and then don't ask anything.
18:57 Joubu have a good evening #koha
19:01 rangi morning
19:05 mveron joined #koha
19:11 drojf hi rangi
19:25 mario joined #koha
19:50 drojf left #koha
19:50 drojf joined #koha
19:50 drojf left #koha
19:50 drojf joined #koha
19:51 pianohacker mveron: nice catch on bug 15244
19:51 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=15244 normal, P5 - low, ---, koha-bugs, NEW , t/db_dependent/Reserves.t depends on external data/configuration
19:53 mveron pianohacker: I needed some patience to catch this fish...   :-)
19:56 aleisha joined #koha
20:02 wnickc_lunch joined #koha
20:15 kathryn joined #koha
21:13 wnickc joined #koha
21:15 alex_ joined #koha
21:15 rangi hey alex_
21:15 * wizzyrea waves to alex_
21:16 aleisha alex_: https://wiki.wgtn.cat-it.co.nz[…]ting_in_Koha_Team
21:17 Francesca joined #koha
21:22 rangi alex_: http://wiki.koha-community.org[…]atalyst_Koha_team
21:27 drojf is alex_ the successor of eythian at catalyst?
21:28 rangi only for this week :)
21:28 tcohen joined #koha
21:28 tcohen hi
21:28 drojf oh ok :) hi alex_
21:28 drojf hi tcohen
21:30 drojf wizzyrea: did you get pbuilder to work?
21:31 wizzyrea Yes!
21:31 wizzyrea it was a combination of things. :)
21:31 sophie_m joined #koha
21:31 drojf oh, the worst ;)
21:31 wizzyrea the version number was wrong, and there was a missing-but-not-required dependency in the pbuilder environment
21:32 wizzyrea (ttf-dejavu)
21:32 cdickinson hi alex_
21:32 wizzyrea (which apparently we assume is installed, and that's probably pretty daft)
21:32 drojf oh. that one is new
21:32 wizzyrea not that new
21:32 drojf no i mean that as a source of error
21:32 drojf i thought i had all of them regarding pbuilder ;)
21:32 wizzyrea ^.^
21:32 alex_ Is bugzilla  for keeping track of malware threats to koha? What does it actually do?
21:33 wizzyrea bugzilla is for keeping track of all bugs in Koha
21:33 wizzyrea there's a security area
21:33 wizzyrea https://koha-community.org/security/ < about that
21:39 magnuse joined #koha
21:42 Francesca joined #koha
21:51 alex_ There is no ubuntu OS version of Vagrant only Mac OSX, Windows, Debian, Centos. Is it ok to download vagrant debian version 64 bit?
21:51 rangi yup that should be fine
21:51 alex_ Thanks
21:52 cdickinson alex_: usually the Debian versions of packages are compatible with Ubuntu, anything that doesn't will usually have a Ubuntu-specific one anyway
21:52 ibeardslee There is vagrant in Ubuntu, make sure you have the Universe repository enabled.
21:52 ibeardslee and then you can just 'sudo apt-get install vagrant'
21:52 rangi ibeardslee: we want to grab the version from the vagrant site
21:53 ibeardslee ahh ok
21:53 rangi the one packaged is a bit too old
21:53 rangi or it was .. it might be fine now
21:55 ibeardslee not ideal if you end up with Virtual Box 5.0, need to use the Vagrant website one, the trusty one works fine with Virtual Box 4.3
21:55 ibeardslee I mean "The Ubuntu version is .. "
21:55 Francesca joined #koha
21:59 misilot joined #koha
21:59 wizzyrea the instructions on devbox are pretty ok
22:00 tcohen wizzyrea: I updated the ansible branch's one, so it mentions installing ansible :-P
22:00 wizzyrea :D
22:00 misilot joined #koha
22:00 wizzyrea I am sorry I haven't had a chance to try the ansible one yet >.<
22:00 * wizzyrea fails
22:00 aleisha how do i set a patron's privacy settings to "never" for keeping a circulation history
22:01 rangi hmm i think in the opac
22:02 aleisha wait i figured it out
22:02 aleisha 'Help' is useful
22:02 rangi :)
22:09 Traumatan joined #koha
22:11 mveron drojf: Did you see the following? "Ausleihen sind GESPERRT weil Gebührenkonto ist ÜBER BEGRENZUNG. " Hmm, that is very ugly...
22:11 nengard left #koha
22:11 tcohen joined #koha
22:12 drojf mveron: no i didn't
22:12 drojf but i agree
22:25 mveron drojf: Bug 15274
22:25 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=15274 enhancement, P5 - low, ---, koha-bugs, NEW , Better translatability for circulation.pl / circulation.tt
22:26 mveron Oh, it's late. Good night / daytime #koha
22:29 irma_ joined #koha
22:31 cait joined #koha
22:33 rangi ibeardslee: do we have any bootable media down there with a recent ubuntu on it?
22:34 cait joined #koha
22:44 talljoy joined #koha
22:56 ibeardslee yes
22:57 ibeardslee did he break it?
23:28 alex__ joined #koha
23:33 drojf joined #koha
23:33 BobB joined #koha
23:33 thd-away` joined #koha
23:33 kivilahtio_ joined #koha
23:33 mtj joined #koha
23:33 alohalog` joined #koha
23:33 clrh joined #koha
23:33 bumby joined #koha
23:33 kathryn joined #koha
23:33 cdickinson joined #koha
23:33 Joubu joined #koha
23:33 dcook joined #koha
23:33 irma joined #koha
23:33 jenkins_koha joined #koha
23:33 janPasi__ joined #koha
23:33 irma_ joined #koha
23:33 sad-hu_ joined #koha
23:33 eythian joined #koha
23:33 slef joined #koha
23:33 cait joined #koha
23:33 Traumatan joined #koha
23:33 wizzyrea joined #koha
23:33 gmcharlt joined #koha
23:33 z0k joined #koha
23:33 lari joined #koha
23:33 magnuse joined #koha
23:33 aleisha joined #koha
23:33 matts_away joined #koha
23:33 ribasushi joined #koha
23:33 ibeardslee joined #koha
23:34 ashimema joined #koha
23:34 liw joined #koha
23:34 jajm joined #koha
23:34 fredericd joined #koha
23:40 wizzyrea alex_: http://pastebin.com/pahy9qbm
23:45 cait waves
23:45 aleisha http://wiki.koha-community.org[…]_bz_configuration
23:48 wizzyrea hi cait
23:49 cait hi all :)

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary