Time |
S |
Nick |
Message |
00:35 |
|
|
BobB joined #koha |
00:39 |
|
|
edveal joined #koha |
00:42 |
|
|
kivilahtio joined #koha |
01:03 |
|
wizzyrea |
that depends on your settings, but probably |
01:03 |
|
wizzyrea |
lost things don't usually accrue daily fines |
01:03 |
|
|
maximep left #koha |
01:03 |
|
wizzyrea |
sometimes marking them lost causes the cost of the item to be charged |
01:03 |
|
wizzyrea |
sometimes marking things lost causes the book to come off of the borrower's account |
01:03 |
|
wizzyrea |
those two behaviours are controlled by syspref. |
01:15 |
|
|
schnydszch joined #koha |
01:17 |
|
schnydszch |
Hello koha community! I can't seem find it, how do I export holdings that includes biblionumber |
01:17 |
|
schnydszch |
when I export right now, biblionumber is excluded |
01:18 |
|
|
edveal left #koha |
01:20 |
|
eythian |
I'd expect it to be in 999$c and $d |
01:21 |
|
schnydszch |
yep |
01:22 |
|
schnydszch |
is it in system preference? |
01:22 |
|
schnydszch |
i'm trying to find it |
01:22 |
|
eythian |
Is what? |
01:23 |
|
schnydszch |
I'm in 3.14 |
01:23 |
|
schnydszch |
trying to find if it's system preference, that it will include 999$c and $d in export |
01:24 |
|
wizzyrea |
I suspect you'd have to modify the export function to get this. |
01:24 |
|
wizzyrea |
afaik there is no syspref to say "export koha-internal fields" |
01:24 |
|
rangi |
works for me |
01:25 |
|
eythian |
you don't |
01:25 |
|
eythian |
it works already |
01:25 |
|
eythian |
999 _c1 |
01:25 |
|
eythian |
_d1 |
01:25 |
|
wizzyrea |
nm then |
01:26 |
|
schnydszch |
i'll try again |
01:26 |
|
rangi |
i just tested on 3.14.02 |
01:26 |
|
rangi |
999 _c100 _d100 |
01:26 |
|
rangi |
seems to be working |
01:26 |
|
|
dani joined #koha |
01:26 |
|
|
dani left #koha |
01:28 |
|
schnydszch |
thanks. it was just an oversight :) |
01:33 |
|
|
ebegin joined #koha |
01:50 |
|
|
kathryn joined #koha |
01:55 |
|
|
rocio left #koha |
02:26 |
|
mtompset |
schnydszch: Only certain types of exports include the 999$c and $d. |
02:26 |
|
mtompset |
I'm talking about the OPAC 'Save Record' drop down. |
02:27 |
|
ebegin |
hey dcook :-) |
02:31 |
|
mtompset |
Greetings, ebegin. |
02:31 |
|
dcook |
hey, ebegin :) |
02:34 |
|
ebegin |
Hi guys |
02:35 |
|
ebegin |
just want to say hi ;-) |
02:36 |
|
ebegin |
@wunder montreal quebec |
02:36 |
|
huginn |
ebegin: The current temperature in Montreal, Quebec is -16.0°C (9:00 PM EST on January 27, 2014). Conditions: Scattered Clouds. Humidity: 61%. Dew Point: -22.0°C. Windchill: -24.0°C. Pressure: 29.95 in 1014 hPa (Rising). |
02:36 |
|
ebegin |
see you tomorrow ! |
02:36 |
|
mtompset |
@wunder l7e 5y5 |
02:36 |
|
huginn |
mtompset: The current temperature in Schomberg, Ontario is -16.6°C (9:36 PM EST on January 27, 2014). Conditions: Low Drifting Snow. Humidity: 63%. Dew Point: -22.0°C. Windchill: -23.0°C. Pressure: 30.09 in 1019 hPa (Rising). |
02:40 |
|
dcook |
Sure thing. See you tomorrow, ebegin :) |
02:46 |
|
schnydszch |
@mtompset, yep, i exported as admin. thanks |
02:46 |
|
huginn |
schnydszch: I'll give you the answer just as soon as RDA is ready |
02:46 |
|
schnydszch |
cheers! |
02:47 |
|
mtompset |
schnydszch: I wasn't talking about WHO. I was talking about type: MARCXML, MARC Unicode, MARc-8, BIBTEX, etc. |
02:47 |
|
schnydszch |
@huginn just as soon as RDA is ready? |
02:47 |
|
huginn |
schnydszch: I'll give you the answer just as soon as RDA is ready |
02:47 |
|
mtompset |
You are putting @ in front. |
02:47 |
|
mtompset |
This isn't twitter. |
02:48 |
|
schnydszch |
mtompset, sorry and thanks. cheers! :) |
02:49 |
|
mtompset |
No problem. |
02:49 |
|
mtompset |
Glad you got what you needed working. :) |
02:54 |
|
|
ibeardslee joined #koha |
03:15 |
|
dcook |
pudding? |
03:18 |
|
mtompset |
because pudding is nice? |
03:18 |
|
mtompset |
Greetings, dcook. |
03:18 |
|
pudding |
it's tasty and doesn't have to know stuff. |
03:19 |
|
mtompset |
as in "my brain is pudding". |
03:19 |
|
pudding |
mmm pudding brain. |
03:19 |
|
* mtompset |
gets the shotgun to protect his brain from zombies. :P |
03:21 |
|
* mtompset |
frowns, "Just when I was hoping to sign off 2 things. They both have problems." |
03:21 |
|
mtompset |
anyone have a bug they'd like signed off that doesn't require secretive librarian knowledge? ;) |
03:21 |
|
pudding |
oh probably. |
03:22 |
|
pudding |
i have one out to do with fines. |
03:23 |
|
mtompset |
secretive librarian knowledge. :P |
03:28 |
|
dcook |
hey mtompset |
03:28 |
|
wahanui |
mtompset is, like, catching up in the non-coding aspects of his ministry |
03:28 |
|
pudding |
naw, it's about the display of the fine descriptions. |
03:28 |
|
dcook |
Yep, I got one, just a moment. |
03:28 |
|
dcook |
11465 |
03:28 |
|
dcook |
bug 11465 |
03:29 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11465 enhancement, P5 - low, ---, dcook, Needs Signoff , Show counts and amounts on OPAC your summary tabs |
03:29 |
|
dcook |
:) |
03:29 |
|
mtompset |
you just added 00?! |
03:38 |
|
eythian |
wahanui: shut up is <reply>http://www.topatoco.com/mercha[…]ry_Code=DRINKWARE |
03:38 |
|
wahanui |
OK, eythian. |
03:39 |
|
mtompset |
Where do you find this stuff, eythian? |
03:39 |
|
eythian |
internet |
03:39 |
|
wahanui |
somebody said internet was http://youtu.be/iDbyYGrswtg |
03:39 |
|
* mtompset |
laughs. |
03:39 |
|
mtompset |
I've seen that episode before. |
03:43 |
|
mtompset |
So when will wahanui point to that link? |
03:43 |
|
mtompset |
shut up, wahanui. |
03:43 |
|
wahanui |
http://www.topatoco.com/mercha[…]ry_Code=DRINKWARE |
03:43 |
|
mtompset |
shut up? |
03:43 |
|
wahanui |
http://www.topatoco.com/mercha[…]ry_Code=DRINKWARE |
03:44 |
|
mtompset |
oh shut it? |
03:44 |
|
mtompset |
There we go. ;) |
04:07 |
|
|
tgoatley joined #koha |
04:58 |
|
mtompset |
Hmmm... |
04:58 |
|
mtompset |
Why are my checked out items not listed?! |
04:59 |
|
mtompset |
Patron -> person who I know has something checked out -> choose the biblio checked out -> items tab -> view checkout history |
04:59 |
|
mtompset |
all zeros. |
05:00 |
|
|
brendan_ joined #koha |
05:00 |
|
brendan_ |
evening |
05:01 |
|
mtompset |
Greetings, brendan_. |
05:01 |
|
brendan_ |
heya |
05:34 |
|
|
cait joined #koha |
05:44 |
|
mtompset |
Greetings, cait. |
05:44 |
|
cait |
morning mtompset |
05:45 |
|
mtompset |
@later tell tcohen 10580 -- I was thinking perhaps the fixing the indentation could be a separate commit? (http://wiki.koha-community.org[…]#Refactoring_code) |
05:45 |
|
huginn |
mtompset: The operation succeeded. |
05:49 |
|
mtompset |
cait: I was wondering about bug 5010 |
05:49 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5010 normal, P5 - low, ---, katrin.fischer, Needs Signoff , Incomplete links in carts and lists sent from the staff client |
05:49 |
|
cait |
yes? |
05:49 |
|
mtompset |
You actually create a system preference for https vs. http. |
05:49 |
|
mtompset |
... just a second let me find that... |
05:49 |
|
cait |
yes |
05:50 |
|
cait |
because there i sno way to determine that from the intranet for the OPAC |
05:50 |
|
mtompset |
CGI->https() ? "https://" : "http://" |
05:50 |
|
mtompset |
doesn't something like that work? |
05:50 |
|
cait |
it won't work from the intranet if you try to figure out what to use for the OPAC link |
05:51 |
|
mtompset |
DOH! You're right. |
05:51 |
|
mtompset |
but it would seem strange to have difference between staff and OPAC. |
05:51 |
|
cait |
not really |
05:51 |
|
mtompset |
case of no logins in OPAC? |
05:51 |
|
cait |
i think it might be that people run staff in https and opac not... although they shouldn't |
05:52 |
|
cait |
yeah, then they wouldn't need to run https in OPAC really |
05:52 |
|
cait |
this whole url topic is a bit messy |
05:52 |
|
mtompset |
yes, yes it is. |
05:52 |
|
cait |
i tried to make it work a bit better, not claiming on having the perfect solution |
05:52 |
|
cait |
gmcharlt advised on the sys pref as a possible solution |
05:52 |
|
cait |
so i did that |
05:53 |
|
mtompset |
Okay, the system preference makes good sense now. |
05:53 |
|
mtompset |
Not the happiest way of doing it, but a reasonably good one. |
05:53 |
|
cait |
there might still be something wrong with the patches... :) |
05:53 |
|
cait |
it seemed a little better than hardcoding http |
05:53 |
|
cait |
I am hoping maybe dcook makes i ta bit better |
05:54 |
|
cait |
sometimes it seems quite too hard to get small things like that right |
05:54 |
|
mtompset |
actually, cait.... |
05:54 |
|
mtompset |
With the access to system preferences from within the Template, there is no need to build them in the .pl |
05:55 |
|
cait |
probably true |
05:58 |
|
dcook |
Hmm? |
05:59 |
|
mtompset |
Don't worry, dcook. You're name was only being taken in vain for horrific reasons. ;) |
05:59 |
|
dcook |
Seems like it :p |
05:59 |
|
mtompset |
YIKES! Bad grammer and spelting, mesa need to sleep. |
05:59 |
|
dcook |
Yeah, it's one of those things that can't really have a perfect solution |
06:01 |
|
mtompset |
Yes, but a system preference between staff to OPAC seems like a reasonable thing. |
06:02 |
|
mtompset |
I don't see any reason currently for an OPAC link going to staff. |
06:04 |
|
mtompset |
So, cait. If I was going to look at trying to sign off 5010, should I attempt the first one, or the last two? And if the last two, perhaps I should obsolete the first one? |
06:04 |
|
cait |
if you think the last 2 are better obsolte the first :) |
06:04 |
|
cait |
i was proposing an alternate solution |
06:05 |
|
cait |
but yeah, I think it's either or |
06:08 |
|
mtompset |
oh... wait... your patches require the previous one. |
06:09 |
|
* mtompset |
cringes. |
06:09 |
|
cait |
hm no they should not |
06:09 |
|
mtompset |
sendbasket.pl |
06:09 |
|
mtompset |
the first one adds a block. |
06:09 |
|
mtompset |
yours removes that block. |
06:10 |
|
cait |
hm not really |
06:10 |
|
cait |
if you look at te patches |
06:10 |
|
cait |
i only adda lock in sendbasket |
06:10 |
|
cait |
might be a conflict |
06:11 |
|
cait |
http://bugs.koha-community.org[…]ment.cgi?id=23457 |
06:11 |
|
cait |
and be aware we have 2 sendbasket |
06:13 |
|
dcook |
night for me |
06:13 |
|
dcook |
laterz |
06:15 |
|
mtompset |
one in intranet and one in opac, right? |
06:16 |
|
mtompset |
BTW, you have some whitespace errors in the merging. |
06:19 |
|
mtompset |
fresh install: system preference created. :) |
06:21 |
|
mtompset |
upgrade: system preference created. :) |
06:22 |
|
mtompset |
passes qa tool. :) |
06:22 |
|
cait |
would be kind of embarassing if it didn't |
06:22 |
|
cait |
but that has happened.. |
06:29 |
|
mtompset |
got distracted by bug 11623 -- someone complaining that upgrading from 3.0.x to 3.14.x didn't work. |
06:29 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11623 normal, P5 - low, ---, koha-bugs, NEW , Errors with upgrade from 3.00.00.070 to 3.14.02.000 |
06:30 |
|
mtompset |
so private list or public list, cait, for 5010? |
06:30 |
|
cait |
it shouldn't matter |
06:30 |
|
cait |
the difference is in sending it from staff or from opac |
06:32 |
|
mtompset |
oh joys... "Problem sending the list" |
06:32 |
|
mtompset |
I bet my mailing configuration is busted or something. |
06:41 |
|
mtompset |
Yep... busted email configuration in this VM... |
06:42 |
|
mtompset |
I do find it yucky that sendmail is called directly. |
06:42 |
|
mtompset |
I think I best call it a night. |
06:43 |
|
mtompset |
Have a great day (24 hour period), #koha. |
06:49 |
|
rangi |
its not |
06:51 |
|
rangi |
http://search.cpan.org/~mivkov[…]pm#sendmail%28%29 is called |
06:51 |
|
rangi |
which sends mail, using whatever mta you have listening on port 25 (or even other ports if you want to configure it) |
07:05 |
|
|
dpk1 joined #koha |
07:13 |
|
cait |
time to go to work - bbl |
07:13 |
|
|
cait left #koha |
07:39 |
|
|
reiveune joined #koha |
07:40 |
|
reiveune |
hello |
07:49 |
|
|
cait joined #koha |
08:24 |
|
nlegrand |
Hey ! |
08:25 |
|
|
sophie_m joined #koha |
08:26 |
|
sophie_m |
hi #koha |
08:30 |
|
|
alex_a joined #koha |
09:20 |
|
|
Oak joined #koha |
09:20 |
|
Oak |
kia ora #koha |
09:21 |
|
Oak |
Guten morgen cait |
09:23 |
|
kivilahtio |
In the bootstrap theme where do I put my feature dependent javascript files? |
09:24 |
|
kivilahtio |
is there a general guide for that? |
09:25 |
|
kivilahtio |
hmm separate files.. |
09:27 |
|
kivilahtio |
I am modifyin the opac-detail.tt for the bootstrap theme regarding bug 11175. I need a small script of javascript to set the height of a container to match the height of a neighbouring container |
09:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11175 enhancement, P5 - low, ---, olli-antti.kivilahti, Failed QA , Show the parent record's component parts in the detailed views. |
09:28 |
|
kivilahtio |
can I just add a componentParts.js file to bootstrap/js/ and include it in the template if systempreference is ok |
09:34 |
|
kivilahtio |
was there a super easyway of calling the system preferences directly from the .tt files? |
09:44 |
|
|
alex_a_ joined #koha |
10:07 |
|
kivilahtio |
If I directly include <script type="javascript" src="..."> a javascript file in the bootstrap -> opac-detail.tt, I can't access jQuery functions? Everybody else seems to be using .inc files to include .js files? |
10:08 |
|
kivilahtio |
thus $(document).ready(function() { THROWS Uncaught ReferenceError: $ is not defined |
10:08 |
|
kivilahtio |
my script file is below the jQuery-files in the html source |
10:08 |
|
kivilahtio |
not even jQuery(document).ready() is defined |
10:20 |
|
kivilahtio |
ok I got it |
10:20 |
|
kivilahtio |
the jQuery libraries are loaded in the end of the HTML document |
11:27 |
|
|
trendynick joined #koha |
11:40 |
|
|
BobB joined #koha |
12:11 |
|
kivilahtio |
Wow, the Koha's built in label creator looks pretty great! |
12:11 |
|
kivilahtio |
I was wondering if we could style the labels with css? |
12:12 |
|
cait |
i think for the quick editor yes |
12:12 |
|
cait |
not sure for the labels |
12:13 |
|
cait |
quick spine label pritn = html |
12:13 |
|
cait |
the other label print is pdf, so i think css is not possible there |
12:14 |
|
cait |
it depends if you want to print batches or single labels |
12:14 |
|
kivilahtio |
batches |
12:14 |
|
kivilahtio |
we have two different label sizes on one paper |
12:14 |
|
kivilahtio |
2x6 lables + 1x12 spine lables in one A4 sticker paper |
12:15 |
|
kivilahtio |
so this is not doable with the Koha's lable creator |
12:15 |
|
kivilahtio |
but I think I will make a local modification to solve this issue |
12:15 |
|
kivilahtio |
it is a really simple task and I can just add a new custom module to facilitate these label printings |
12:16 |
|
kivilahtio |
+ Koha has already tons of great code to hack this functionality from :) |
12:25 |
|
Oak |
kivilahtio++ |
12:25 |
|
Oak |
later guys |
12:35 |
|
cait |
kivilahtio: hm actually there was functionality for that back in the old module |
12:35 |
|
cait |
there is a special lable that is 2 labels |
12:35 |
|
cait |
with different sizes, i just can't remember how that works |
12:41 |
|
|
oleonard joined #koha |
12:43 |
|
oleonard |
@wunder 45701 |
12:43 |
|
huginn |
oleonard: The current temperature in Windy Ridge, Athens, Ohio is -25.0°C (7:43 AM EST on January 28, 2014). Conditions: Clear. Humidity: 48%. Dew Point: -33.0°C. Windchill: -25.0°C. Pressure: 30.45 in 1031 hPa (Rising). Wind chill warning in effect until 1 PM EST this afternoon... |
12:44 |
|
oleonard |
I guess we're lucky there's no wind at the moment. |
12:48 |
|
|
petter joined #koha |
12:48 |
|
petter |
hi folks! |
12:48 |
|
kivilahtio |
hi petter! |
12:48 |
|
oleonard |
Hi petter |
12:48 |
|
kivilahtio |
how is life |
12:49 |
|
kivilahtio |
how is life? |
12:49 |
|
petter |
its good, more or less |
12:49 |
|
petter |
maybe more less than more? |
12:49 |
|
petter |
hard to say |
12:49 |
|
kivilahtio |
nice to hear :) |
12:49 |
|
petter |
How was your vacation, olli? |
12:49 |
|
kivilahtio |
awsome! |
12:49 |
|
petter |
great |
12:49 |
|
kivilahtio |
we rode with Camels in the desert night |
12:49 |
|
petter |
wow |
12:49 |
|
petter |
where did you go? |
12:49 |
|
kivilahtio |
visited Petra, Dead Sea, Masada. Lots of stuff |
12:49 |
|
kivilahtio |
Eilat |
12:49 |
|
kivilahtio |
Israel |
12:49 |
|
petter |
aha, cool |
12:49 |
|
petter |
sunny |
12:50 |
|
kivilahtio |
29 deg max, around 25 deg |
12:50 |
|
petter |
perfect! |
12:50 |
|
wahanui |
rumour has it perfect is the enemy of good |
12:50 |
|
kivilahtio |
not a drop of rain |
12:50 |
|
kivilahtio |
so yeah ! :) |
12:50 |
|
kivilahtio |
+ food was good |
12:50 |
|
kivilahtio |
and people had assault rifles ;) |
12:51 |
|
petter |
yea, they can be a bit tense in that region! |
12:52 |
|
kivilahtio |
so very safe |
12:54 |
|
|
meliss joined #koha |
12:58 |
|
|
NateC joined #koha |
13:07 |
|
oleonard |
paxed here? |
13:07 |
|
paxed |
yes? |
13:07 |
|
|
alex_a joined #koha |
13:07 |
|
oleonard |
What page does Bug 11624 refer to? |
13:07 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11624 enhancement, P5 - low, ---, koha-bugs, NEW , Impossible to style MARC display via CSS |
13:08 |
|
paxed |
MARCdetail.pl |
13:10 |
|
oleonard |
Okay thanks |
13:12 |
|
paxed |
also, just noticed that in tab 0 the subfield letter is not bold, but in the other tabs it is in bold. |
13:23 |
|
|
alex_a joined #koha |
13:27 |
|
|
druthb left #koha |
13:28 |
|
|
druthb joined #koha |
13:36 |
|
|
Dyrcona joined #koha |
13:57 |
|
|
paul_p joined #koha |
14:10 |
|
|
collum joined #koha |
14:16 |
|
|
mtompset joined #koha |
14:36 |
|
|
laurence joined #koha |
14:46 |
|
druthb |
o/ |
14:52 |
|
|
maximep joined #koha |
14:56 |
|
rhcl |
@wunder 64507 |
14:56 |
|
huginn |
rhcl: The current temperature in Wyatt Park, St Joseph, Missouri is -15.4°C (8:55 AM CST on January 28, 2014). Conditions: Clear. Humidity: 72%. Dew Point: -19.0°C. Windchill: -15.0°C. Pressure: 30.57 in 1035 hPa (Rising). |
14:56 |
|
druthb |
@wunder 77098 |
14:56 |
|
huginn |
druthb: The current temperature in Greenway Plaza, Houston, Texas is 0.0°C (8:56 AM CST on January 28, 2014). Conditions: Mostly Cloudy. Humidity: 80%. Dew Point: -3.0°C. Windchill: -5.0°C. Pressure: 30.27 in 1025 hPa (Steady). Winter Weather Advisory in effect until noon CST today... |
15:11 |
|
mtompset |
@wunder l7e 5y5 |
15:11 |
|
huginn |
mtompset: The current temperature in Schomberg, Ontario is -15.1°C (10:11 AM EST on January 28, 2014). Conditions: Partly Cloudy. Humidity: 65%. Dew Point: -20.0°C. Windchill: -20.0°C. Pressure: 30.31 in 1026 hPa (Rising). |
15:18 |
|
oleonard |
Dear Canada: Please stop sending weather. Thanks. |
15:18 |
|
* druthb |
blames mtompset |
15:21 |
|
|
laurence joined #koha |
15:23 |
|
rhcl |
@wunder pyongyang |
15:23 |
|
huginn |
rhcl: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
15:23 |
|
rhcl |
@wunder pyongyang North Korea |
15:23 |
|
huginn |
rhcl: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
15:25 |
|
rhcl |
@wunder pyongyang dprk |
15:25 |
|
huginn |
rhcl: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
15:26 |
|
rhcl |
@wunder FNJ |
15:26 |
|
huginn |
rhcl: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
15:26 |
|
rhcl |
SY |
15:31 |
|
oleonard |
@wunder Pyonggang, North Korea |
15:31 |
|
huginn |
oleonard: The current temperature in Yangyang Airport, North Korea is 3.0°C (12:00 AM KST on January 29, 2014). Conditions: Clear. Humidity: 24%. Dew Point: -16.0°C. Windchill: -2.0°C. Pressure: 30.21 in 1023 hPa (Steady). |
15:31 |
|
|
talljoy joined #koha |
15:37 |
|
oleonard |
https://twitter.com/vmstan/sta[…]723955200/photo/1 |
15:38 |
|
druthb |
oleonard++ |
15:38 |
|
* mtompset |
blames the pollution coming up the jet stream from the USA. :P |
15:39 |
|
mtompset |
oleonard: I'd like to test that patch, but I can't for the life of me figure out how to trigger a late order. |
15:39 |
|
mtompset |
I can get to the late order screen, but without actual data to show, it's pointless. |
15:41 |
|
mtompset |
Nice link, oleonard. :) |
15:42 |
|
oleonard |
My favorite part of that image is Florida |
15:44 |
|
mtompset |
Well, you have to get blaming the president in there somewhere. ;) |
15:47 |
|
mtompset |
So, oleonard (or anyone) how do I trigger something that will show up in late orders? |
15:50 |
|
oleonard |
mtompset: I share your frustration with trying to figure out how to trigger some of these acquisitions pages. Sometimes it requires tracking down the SQL that generates the page contents |
15:50 |
|
oleonard |
I think it has to do with "estimated delivery date?" |
15:50 |
|
cait |
oleonard: i can help mst of the time |
15:51 |
|
cait |
if i am around |
15:51 |
|
oleonard |
cait++ |
15:51 |
|
cait |
try unsetting the date filter |
15:51 |
|
cait |
and add 0 for the days since or something like that |
15:52 |
|
mtompset |
still nothing. Perhaps I should attempt placing an order? |
15:52 |
|
|
rocio joined #koha |
15:52 |
|
oleonard |
mtompset: You would need some existing orders, yes. |
15:53 |
|
mtompset |
I went into acquisitions, and did a search for a vendor. |
15:53 |
|
mtompset |
I found an entry with a date of 2012-06-21 |
15:53 |
|
mtompset |
It hasn |
15:53 |
|
mtompset |
't been received. |
15:54 |
|
mtompset |
It isn't closed. |
15:54 |
|
mtompset |
It isn't in a basket group. |
15:55 |
|
mtompset |
I received it today... and... still nothing. |
15:56 |
|
mtompset |
This is the silly "secretive library stuff" thing I was saying I didn't want. :P |
15:56 |
|
oleonard |
Hunh? Secretive? |
15:56 |
|
cait |
yes you need to lcose it |
15:56 |
|
mtompset |
if I don't know it, it must be mystically acquired knowledge. |
15:56 |
|
cait |
only closed orders count as ordered - else they are still open for adding new order lines |
15:58 |
|
mtompset |
closed and still nothing. |
15:58 |
|
mtompset |
oh, I closed after received. |
15:58 |
|
mtompset |
should I close BEFORE received? |
15:58 |
|
cait |
well that won't work |
15:58 |
|
cait |
a late order is something you didn't get... |
15:59 |
|
oleonard |
mtompset: I hope you're not saying that someone is being secretive about how acquisitions works |
15:59 |
|
cait |
you order it, you close the basket.... you adjust the filters on late orders so it matches. |
16:00 |
|
cait |
because by default it will not look for a order orderd today.. that would not be really late :) but i think you can make it work with 0 days or something iirc |
16:02 |
|
mtompset |
YAY! I got data. |
16:03 |
|
oleonard |
Did something change in the way Koha does tests? New dependency? I'm getting errors from running the prove command |
16:06 |
|
cait |
which test oleonard? because i had problems too recently |
16:06 |
|
oleonard |
prove t xt |
16:06 |
|
mtompset |
I usually include -v :) |
16:06 |
|
oleonard |
For a more verbose error message? |
16:07 |
|
mtompset |
Yes. |
16:07 |
|
oleonard |
Cannot detect source of 't'! at /usr/share/perl/5.14/TAP/Parser/IteratorFactory.pm line 263 |
16:16 |
|
cait |
oleonard: hm looks like a new dependency |
16:16 |
|
cait |
maybe? |
16:16 |
|
wahanui |
rumour has it maybe is a momentaneous error |
16:16 |
|
cait |
i had problems with search.t |
16:29 |
|
mtompset |
blou: -- you forgot to change the bug status. |
16:29 |
|
mtompset |
(i.e. Needs Signoff) |
16:50 |
|
mtompset |
HMMM?! What do you mean there's no late orders?! |
16:51 |
|
reiveune |
bye |
16:51 |
|
|
reiveune left #koha |
16:53 |
|
mtompset |
okay... *whew* wrong branch. |
16:54 |
|
|
rhcl joined #koha |
16:55 |
|
mtompset |
BTW, it seems weird to give staff access and acquisition access, but then log in and get told I can't access that page. |
17:00 |
|
mtompset |
YAY! |
17:00 |
|
mtompset |
I finally tested it, oleonard. |
17:01 |
|
mtompset |
I figured out the magical incantations to do it. |
17:01 |
|
mtompset |
Now to reproduce them, so I can make a fuller TEST PLAN. |
17:05 |
|
mtompset |
EEEEEW! I just looked at it without the patch. Thank you, oleonard! That's a massive improvement. |
17:11 |
|
mtompset |
ARG! I can't reproduce the magical incantation. |
17:12 |
|
|
laurence left #koha |
17:13 |
|
mtompset |
AH! Must close with the basket group. |
17:34 |
|
|
cait left #koha |
17:50 |
|
oleonard |
If you're talking about the patch for Bug 11027 mtompset that's not mine |
17:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11027 enhancement, P5 - low, ---, mathsabypro, Signed Off , add a column for basketgroups in late orders table |
17:50 |
|
mtompset |
I must be in a daze. |
17:50 |
|
mtompset |
You're right. |
17:51 |
|
mtompset |
Seeing prog/en also makes me thing OPAC, even when it is intranet-tmpl. |
17:51 |
|
mtompset |
^thing^think^ |
17:52 |
|
mtompset |
is matts_away the same person, oleonard? |
17:53 |
|
oleonard |
msaby I think? |
17:53 |
|
mtompset |
@seen msaby |
17:53 |
|
huginn |
mtompset: msaby was last seen in #koha 14 weeks, 1 day, 23 hours, 14 minutes, and 0 seconds ago: <msaby> cait:so if I understant, if these fields are not harmful, better not touching it... |
18:06 |
|
|
pianohacker joined #koha |
18:07 |
|
pianohacker |
yo |
18:07 |
|
mtompset |
yo yo yo pianohacker? ;) |
18:07 |
|
mtompset |
How are you? |
18:08 |
|
pianohacker |
decent, busy as hell with school but decent |
18:08 |
|
pianohacker |
you? |
18:08 |
|
wahanui |
you is, like, smart |
18:08 |
|
mtompset |
wahanui: forgot you |
18:08 |
|
wahanui |
mtompset: excuse me? |
18:08 |
|
mtompset |
wahanui: forget you |
18:08 |
|
wahanui |
mtompset: I forgot you |
18:09 |
|
mtompset |
NOOOO! Don't forget me when I'm gone. :P |
18:09 |
|
mtompset |
Doing pretty good. #3 in sign offs for January. :) |
18:09 |
|
mtompset |
i fear I'll drop back to #5 shortly. |
18:10 |
|
mtompset |
Also depressing... I'm working hard at sign offs, and yet the number of things needing signoffs stays relatively constant. |
18:14 |
|
* pianohacker |
makes note to break up future patches for ease of testing |
18:15 |
|
pianohacker |
one patch per line of code? |
18:15 |
|
mtompset |
NO! |
18:16 |
|
mtompset |
one patch per logical break point: bootstrap changes, prog changes, program changes. |
18:16 |
|
mtompset |
that sort of thing. |
18:16 |
|
pianohacker |
logical break points? so one patch per word? |
18:18 |
|
|
cait joined #koha |
18:19 |
|
mtompset |
pianohacker: want a small patch to sign off on? :) |
18:19 |
|
pianohacker |
mtompset: not at the moment, sorry. I'm being snarky because I'm in the middle of breaking up a really thorny patch |
18:20 |
|
mtompset |
ah, okay. |
18:20 |
|
pianohacker |
8133 is the bane of my existence |
18:20 |
|
mtompset |
YIKES! |
18:20 |
|
mtompset |
That's worse than my 7567. |
18:20 |
|
cait |
bug 8133 |
18:20 |
|
wahanui |
i guess bug 8133 is what started libsysguy's quest |
18:20 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8133 enhancement, P5 - low, ---, jweaver, Failed QA , hourly loans doesn't know when library closed |
18:21 |
|
cait |
aaaaah |
18:21 |
|
pianohacker |
pfft |
18:21 |
|
* cait |
sends cookies |
18:21 |
|
pianohacker |
yay :) |
18:22 |
|
pianohacker |
At this point, I'm submitting an entire module full of code that has to be marked "Warning: This is only for temporary compatibility, and is not suitable for small children. Side effects may include existential angst and a perverse urge to learn Haskell." |
18:24 |
|
jcamins |
pianohacker: "WARNING: may cause irrational and highly inappropriate urges regarding monads." |
18:24 |
|
pianohacker |
Nobody was supposed to know about the monads! :( |
18:24 |
|
|
tcohen joined #koha |
18:25 |
|
tcohen |
hi there! |
18:25 |
|
cait |
pianohacker: was that for qa ears? |
18:25 |
|
cait |
or eyes...? |
18:26 |
|
|
tcohen joined #koha |
18:26 |
|
pianohacker |
cait: Well, partially. :) I'm making C4::Calendar have an API that matches the new calendar setup but interacts with the old DB layout, so there's some ugly emulation code. |
18:26 |
|
cait |
oh |
18:27 |
|
cait |
why? |
18:27 |
|
pianohacker |
At some point in making the hourly loans code, I just tossed the entire diseased mess of the old admin page out the window, so I'm trying not to undo too much of my own work in the process of splitting up the patch |
18:28 |
|
pianohacker |
(kept the template, praise ye oleonard, but the backend was a mess) |
18:30 |
|
cait |
why not fix the backend step by step to support the current feature set and enhance on that? |
18:30 |
|
mtompset |
http://youtu.be/I0i-whGHf-Y |
18:31 |
|
pianohacker |
cait: It would be possible, but a lot of work. I'm submitting code that is suboptimal, but the actual 8133 patch will true it up, and it does at least work reasonably well |
18:31 |
|
cait |
i will leave you to it... and ask someone else to qa :P |
18:32 |
|
tcohen |
hi cait |
18:32 |
|
cait |
don't take me serious,just not having the best week |
18:32 |
|
cait |
hi tcohen |
18:32 |
|
cait |
how is vacation? :) |
18:33 |
|
tcohen |
awesome |
18:34 |
|
pianohacker |
cait: thanks. trying to make the best out of something that would have had to have been made as a patch series from the beginning |
18:56 |
|
mtompset |
blou? *ping* |
18:56 |
|
mtompset |
@see blou |
18:56 |
|
huginn |
mtompset: I'll give you the answer as soon as RDA is ready |
18:56 |
|
mtompset |
@seen blou |
18:56 |
|
huginn |
mtompset: blou was last seen in #koha 5 days, 23 hours, 43 minutes, and 45 seconds ago: <blou> I'll explore that. Thanks a LOT! |
19:07 |
|
pianohacker |
cait: take a look at C4::Calendar::delete_holiday |
19:07 |
|
cait |
too risky |
19:07 |
|
pianohacker |
just trying to give you an idea of why I went all scorched-earth |
19:19 |
|
|
rhcl joined #koha |
19:29 |
|
tcohen |
cait: remebeer to give me your dev DB to try to reproduce your problem |
19:29 |
|
mtompset |
pianohacker: Why are there so many cursed delete_{blah} functions in the old code?! |
19:29 |
|
mtompset |
(with respect to holiday) |
19:30 |
|
cait |
tcohen: i wanted to try it on the unimarc databaes first |
19:30 |
|
tcohen |
the failing tests are MARC21 tests |
19:30 |
|
pianohacker |
dammit fire alarm brb |
19:30 |
|
tcohen |
good luck pianohacker !!! |
19:33 |
|
cait |
tcohen: mostly to see if it the database... or maybe something else? |
19:34 |
|
pianohacker |
heh, some numbnut just bumped the alarm in the kitche |
19:34 |
|
pianohacker |
good excuse for a change of scenery |
19:34 |
|
cait |
hmmmm |
19:36 |
|
cait |
tcohen: maybe some more clues: http://paste.koha-community.org/98 |
19:39 |
|
tcohen |
cait: it must be some scenario the tests don't explicitly cover (sysprefs I guess) |
19:39 |
|
tcohen |
with a default setup I cannot reproduce it |
19:39 |
|
cait |
hm |
19:40 |
|
tcohen |
I mean, I tried lots of combinations with no luck |
19:40 |
|
cait |
when you look at the search prefs: |
19:41 |
|
cait |
don't include, don't use, automatically, try, try, enable, don't force, don't include, not using, do not try |
19:41 |
|
cait |
looks pretty standard |
19:41 |
|
pianohacker |
sorry about that, the search prefs are a hot mess... |
19:42 |
|
tcohen |
yeah, have the same options actually |
19:47 |
|
tcohen |
cait, is it possible that you have a modified version of t/db_dependent/data/marc21/zebraexport/large_biblio_ |
19:48 |
|
cait |
hm i don't think so |
19:48 |
|
cait |
i think git should show it? |
19:48 |
|
cait |
i have you test records in my database, should that make a difference? |
19:51 |
|
cait |
hm |
19:51 |
|
cait |
ah |
19:51 |
|
cait |
i copied only the last error |
19:51 |
|
cait |
all those tests fail |
19:52 |
|
cait |
even the first on line 831 |
19:52 |
|
cait |
is($results_hashref->{biblioserver}->{hits}, 1, "can do a search that retrieves an over-large bib record (bug 11096)"); |
19:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11096 major, P5 - low, ---, gmcharlt, Failed QA , Koha cannot retrieve big records from Zebra |
19:53 |
|
cait |
tcohen: let's try something |
19:53 |
|
cait |
i will give you the full output of the tests |
19:55 |
|
tcohen |
ok |
19:56 |
|
tcohen |
i can tell I generated Squeeze and Ubuntu 12.04 VM to run the tests on, which did successfuly |
19:56 |
|
tcohen |
I think having the full log might help. yes |
19:57 |
|
cait |
hm |
19:57 |
|
cait |
not sure what it's doing |
19:57 |
|
cait |
trying to write the results to a file |
19:58 |
|
tcohen |
2> file 1>&2 |
19:58 |
|
cait |
thx :) |
19:59 |
|
cait |
search.t takes a bit |
19:59 |
|
cait |
let's see if it works |
20:04 |
|
mtompset |
Ah, redirecting stderr and stdout to a file. :) |
20:04 |
|
cait |
tcohen: http://paste.koha-community.org/99 |
20:09 |
|
|
chris_n` joined #koha |
20:27 |
|
oleonard |
Bye #koha |
20:29 |
|
mtompset |
REBOOT! |
20:34 |
|
|
dani joined #koha |
20:50 |
|
tcohen |
cait, I saw those errors in a previous patch series |
20:52 |
|
tcohen |
basically because they didn't have the right count of bib |
20:52 |
|
tcohen |
s |
20:57 |
|
|
mtompset joined #koha |
20:58 |
|
mtompset |
And that driver went kaboom. |
21:01 |
|
pianohacker |
that's what drivers do |
21:01 |
|
pianohacker |
the whole making your hardware work seems to be an inconvenient bug from their perspective |
21:02 |
|
mtompset |
serves me right for trying to install a beta driver while using a VM with 3D whatever it was enabled. |
21:09 |
|
|
meliss joined #koha |
21:17 |
|
eythian |
hi |
21:23 |
|
cait |
hi eythian |
21:23 |
|
rhcl |
hihi |
21:24 |
|
eythian |
wahanui: planning is <reply>http://imgur.com/WGDg5KB |
21:24 |
|
wahanui |
...but planning is still going on, but there are lots of people signed up so it will happen!... |
21:24 |
|
eythian |
no wahanui, planning is <reply>http://imgur.com/WGDg5KB |
21:24 |
|
wahanui |
okay, eythian. |
21:26 |
|
pianohacker |
hahaha nice |
21:27 |
|
pianohacker |
wahanui: C4::Koha is <reply>http://i.imgur.com/uGHA6u0.gif |
21:27 |
|
wahanui |
OK, pianohacker. |
21:29 |
|
mtompset |
planning C4::Koha? |
21:29 |
|
pianohacker |
wahanui ain't that smart |
21:29 |
|
wahanui |
pianohacker: excuse me? |
21:29 |
|
pianohacker |
you heard me |
21:30 |
|
mtompset |
So, what are you planning for C4::Koha? |
21:30 |
|
pianohacker |
oh, nothing. Just documenting facts |
21:30 |
|
pianohacker |
C4::Koha? |
21:30 |
|
wahanui |
http://i.imgur.com/uGHA6u0.gif |
21:34 |
|
mtompset |
C4::Koha planning? |
21:34 |
|
mtompset |
koha planning? |
21:34 |
|
mtompset |
oh well. |
21:37 |
|
pianohacker |
I am failing at what seems like a simple task. I have a patch on a bug that I want to apply, but not commit, as I want to roll it into an existing set of changes |
21:38 |
|
cait |
hm |
21:38 |
|
cait |
what about applying it |
21:38 |
|
pudding |
well you do want to commit it |
21:38 |
|
cait |
then do a git reset --soft |
21:38 |
|
cait |
and then a git commit --amend? |
21:38 |
|
pudding |
you can rebase -i and roll it up |
21:38 |
|
pudding |
with the other stuff |
21:38 |
|
pudding |
dropping it's commit message in the process |
21:38 |
|
cait |
pudding: why are you pudding? :) |
21:38 |
|
tcohen |
hi eythian mtompset |
21:38 |
|
pianohacker |
step 1: How to get the patch? Copy and paste the raw into a file? |
21:39 |
|
pudding |
naw, just apply it normally |
21:39 |
|
jcamins |
I recommend pudding's approach. |
21:39 |
|
mtompset |
Greetings, tcohen. |
21:39 |
|
mtompset |
So, you are on vacation? |
21:39 |
|
cait |
sounds reasonable to me too |
21:39 |
|
jcamins |
Lots of sugar and chocolate. |
21:39 |
|
pianohacker |
It's a small bugfix patch that's being rolled into one part of a broken-up patch |
21:39 |
|
tcohen |
mtompset: indeed |
21:40 |
|
pudding |
yea that's fine |
21:40 |
|
mtompset |
git rebase -i is really cool! :) |
21:40 |
|
pudding |
you can drop it's commit message and roll it back with the other stuff with rebase -i |
21:40 |
|
mtompset |
You can use it to drop an old version of the bug and git bz the newer version. ;) |
21:40 |
|
tcohen |
git_rebase_interactive++ |
21:40 |
|
pianohacker |
applying it and rebasing it is more work than just downloading the patch and using git apply, is that really the only way? |
21:41 |
|
tcohen |
don't u have to do both actually? |
21:41 |
|
pudding |
basically you're just squashing it yea? |
21:41 |
|
pianohacker |
here, context. I'm trying to roll wizzyrea's patch on bug 8133 into the broken-out patch for bug 11211 |
21:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8133 enhancement, P5 - low, ---, jweaver, Failed QA , hourly loans doesn't know when library closed |
21:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11211 enhancement, P5 - low, ---, jweaver, NEW , Move calculation code out of C4::Calendar |
21:41 |
|
pudding |
maybe I don't understand what exactly you're trying to do |
21:41 |
|
jcamins |
pianohacker: git apply will apply the patch. If it doesn't apply, you're SOL either way. |
21:42 |
|
pianohacker |
I am squashing it, yes, and what you're describing would work. I just don't know how to download the patch :) |
21:42 |
|
jcamins |
To squash patches, you use git rebase -i HEAD^^^ |
21:42 |
|
jcamins |
git bz apply 8133. |
21:42 |
|
jcamins |
But if wizzyrea wrote the patch but not the others that are being squashed, the patches should be kept separate anyway. |
21:42 |
|
pudding |
or just download the thing and apply it |
21:43 |
|
pianohacker |
how do you do that in bugzilla? |
21:43 |
|
* wizzyrea |
waves |
21:43 |
|
pianohacker |
oh! hi, hahahaha |
21:43 |
|
wizzyrea |
>.> |
21:43 |
|
wizzyrea |
<.< |
21:43 |
|
jcamins |
wizzyrea: right, if you want to do two steps. ;) |
21:43 |
|
wizzyrea |
but now I have to go to a meeting. |
21:43 |
|
wizzyrea |
well yea |
21:43 |
|
pianohacker |
bye, thanks wizzyrea |
21:43 |
|
cait |
pianohacker: you can do git bz apply and then choose the i option |
21:43 |
|
* wizzyrea |
only answers what is asked |
21:44 |
|
cait |
if you want only one specific patch in a series |
21:44 |
|
wizzyrea |
ok byeeee ttyl |
21:44 |
|
cait |
or you can just download it and do a git am -iu3 file |
21:44 |
|
cait |
that would be 'the old way' |
21:44 |
|
pianohacker |
jcamins: I have uncommitted changes, is the other part. It's easy enough to commit, rebase -i, etc, just hoping for a way to do it quickly in situations like this |
21:45 |
|
pianohacker |
And I can't find a way to download a .patch anymore. |
21:45 |
|
pianohacker |
I am entirely willing to believe I'm blind. |
21:45 |
|
cait |
click on the patch subject |
21:45 |
|
cait |
wget this link |
21:46 |
|
cait |
ithink that's how i did it... but it's been a whlie |
21:46 |
|
pianohacker |
cait: that's how it used to work, but I think you just have to copy and paste now |
21:46 |
|
cait |
i don't see a reason why it would not work now |
21:46 |
|
jcamins |
pianohacker: same way you always downloaded the patch. |
21:46 |
|
jcamins |
Just use wget. |
21:47 |
|
jcamins |
For example, `wget -O bug_11096.patch http://bugs.koha-community.org[…]ment.cgi?id=24492` |
21:47 |
|
pianohacker |
Oh, you click details then view at the bottom! That's what I was missing. Dammit |
21:47 |
|
jcamins |
And use git stash. |
21:47 |
|
* cait |
nods |
21:47 |
|
jcamins |
No need to click details. Just click the name of the file. |
21:48 |
|
pianohacker |
Gaahhhh |
21:48 |
|
cait |
pianohacker: or click on the subject/title - that brings you directly to the 'raw' version |
21:48 |
|
pianohacker |
jcamins++ |
21:48 |
|
pianohacker |
cait?? |
21:48 |
|
wahanui |
cait is probably a bit worried about lumping all code into a single file a sa first step |
21:48 |
|
cait |
not using oneof the three links at the end, but the link on the title |
21:48 |
|
pianohacker |
cait++ |
21:48 |
|
cait |
also you have a pm from me :P |
21:48 |
|
pianohacker |
thank you both... |
21:49 |
|
cait |
i think you are not the first to ask that question |
21:49 |
|
cait |
and not the last |
21:49 |
|
pianohacker |
My brain was stuck on "This is how it worked in old bugzilla, but things are different, I can't do it that way now" |
21:50 |
|
pianohacker |
jesus christ. |
21:50 |
|
* cait |
sends more cookies |
21:51 |
|
* pianohacker |
tries to eat cookies, shoves them all in eye |
21:51 |
|
* pianohacker |
cries |
21:52 |
|
rhcl |
well, ya gotta dip 'em in milk first, then they won't hurt |
21:52 |
|
pianohacker |
jcamins: I owe you and gmcharlt a beer or something for the number of rock-stupid things you've helped me with |
21:56 |
|
* cait |
takes the cookies away |
22:14 |
|
|
papa joined #koha |
22:15 |
|
|
dcook joined #koha |
22:22 |
|
|
francharb joined #koha |
22:25 |
|
tcohen |
vacation auto-gift http://www.hanxo.com/en/produc[…]es/2_0/blake.html |
22:26 |
|
|
maximep left #koha |
22:38 |
|
dani |
@later tell meliss last ticket for Bennington cleared up. They can go into support. |
22:38 |
|
huginn |
dani: The operation succeeded. |
22:38 |
|
tcohen |
rangi aroung? |
22:38 |
|
tcohen |
around? |
22:38 |
|
dani |
ha, wrong window |
22:39 |
|
cait |
tcohen: i think he might be home - see facebook |
22:39 |
|
tcohen |
ah, thanks |
22:39 |
|
|
cait left #koha |
23:15 |
|
pianohacker |
is there a policy on using given/when, given the warnings it triggers? |
23:18 |
|
mtompset |
What do you mean given/when? in template toolkit? |
23:18 |
|
dcook |
http://perldoc.perl.org/perlsy[…]Switch-Statements |
23:18 |
|
dcook |
pianohacker: I didn't even know Perl could do that! |
23:18 |
|
mtompset |
*cringe* "experimental" |
23:19 |
|
mtompset |
Let's avoid that in the base code. |
23:19 |
|
pianohacker |
It's pretty awesome, but guess what, mtompset? |
23:19 |
|
pianohacker |
[Tue Jan 28 15:49:41 2014] calendar.pl: when is experimental at /home/feoh3/p/koha/tools/calendar.pl line 201 |
23:19 |
|
pianohacker |
waaaaaaaarnin's |
23:20 |
|
* dcook |
thinks this is likely a gmcharlt question |
23:20 |
|
mtompset |
Yes, looks like a very useful thing though. |
23:20 |
|
pianohacker |
probably. gmcharlt: around? |
23:20 |
|
* dcook |
knows that he has used "goto" sometime in the past few months, but cannot remember where... |
23:20 |
|
gmcharlt |
pianohacker: given/when is no good, alas, given the smartmatch mess in Perl |
23:21 |
|
gmcharlt |
so, don't use it, remove them if you see them |
23:21 |
|
* dcook |
had a feeling that might be the sitch |
23:21 |
|
gmcharlt |
and hope that the next time the pumpkin-crew try to implement a switch statement, it actually works |
23:21 |
|
pianohacker |
gmcharlt: curses, yeah, that makes sense, given http://perldoc.perl.org/perlsy[…]on-given-and-when |
23:21 |
|
dcook |
^^ |
23:22 |
|
pianohacker |
it would be really nice to have a rock-stupid version for just basic string-comparison-switch |
23:22 |
|
dcook |
What's the minimum version of Perl that Koha supports? |
23:22 |
|
pianohacker |
"I know smartmatch is complicated as hell, but I don't want it, just given/when" |
23:22 |
|
gmcharlt |
dcook: 5.10 |
23:22 |
|
dcook |
thanks |
23:22 |
|
gmcharlt |
pianohacker: I sympathize |
23:23 |
|
gmcharlt |
I also view it as an object lession is the risk of trying to be too fancy |
23:24 |
|
pianohacker |
absolutely |
23:24 |
|
pianohacker |
gmcharlt: feelings about http://search.cpan.org/~mauke/[…]b/Switch/Plain.pm ? |
23:24 |
|
|
rhcl joined #koha |
23:25 |
|
pianohacker |
(or one of the similar CPAN modules) |
23:25 |
|
gmcharlt |
TBH, not unless one of them becomes a core module |
23:26 |
|
gmcharlt |
absent a very strong argument that the syntax sugar is necessary, not just a preference |
23:26 |
|
pianohacker |
understandable. Guess I'll do the usual hash of anonymous subs then |
23:26 |
|
pianohacker |
wait, would that cause Plack problems? |
23:34 |
|
|
dani left #koha |
23:37 |
|
rangi |
it wont cause plack any |
23:37 |
|
rangi |
however it may well cause the cgi emulation thingy we are using with plack problems |
23:37 |
|
rangi |
ps cellulitis is balls |
23:37 |
|
pianohacker |
amen... |
23:38 |
|
wizzyrea |
oh rangi, is it feeling any better at all? |
23:38 |
|
pianohacker |
rangi: Yeah, realized I need to make these ours or local ours |
23:39 |
|
rangi |
wizzyrea: stopped growing, hopefully will start shrinking & hurting less soon |
23:39 |
|
* dcook |
thought "ours" weren't desirable |
23:39 |
|
rangi |
if the pain hasnt subsided by tomorrow i have to go back |
23:39 |
|
wizzyrea |
:( that is, in fact, balls. |
23:39 |
|
rangi |
dcook: we are using them as a bit of a hack, the way we are using them isnt really desirable |
23:39 |
|
rangi |
what happens |
23:40 |
|
rangi |
is the way we are using plack |
23:40 |
|
rangi |
is that it wraps every script in a subroutine |
23:41 |
|
rangi |
(this is not how you should really use plack of course this is just a zillion times easier than writing our scripts to work natively under it) |
23:41 |
|
rangi |
which messes with scope of variables |
23:42 |
|
bag |
damn man rangi |
23:43 |
|
bag |
about the crazyness (and plack to I guess) |
23:43 |
|
rangi |
bacteria are the single most effective form of life |
23:43 |
|
rangi |
and after this, i can see why |
23:43 |
|
rangi |
speedy little buggers |
23:44 |
|
jcamins |
pianohacker: if you can avoid using our by putting your variables in an explicit subroutine, please do. |
23:44 |
|
bag |
well rangi besides the form of life known as pianohacker |
23:44 |
|
pianohacker |
haha wat |
23:45 |
|
rangi |
hehe |
23:46 |
|
pianohacker |
jcamins: I'm using a hash of anonymous subs as a replacement for a switch statement, so I don't think that's an option (it's the usual set of code blocks for each 'op' in an admin script) |
23:46 |
|
jcamins |
pianohacker: in a .pl file? |
23:46 |
|
jcamins |
In that case, don't use our. |
23:47 |
|
jcamins |
If there's no explicit subroutine in the .pl file, you can treat the *entire file* as a sub. |
23:47 |
|
pianohacker |
Even for scalars? |
23:47 |
|
jcamins |
Point out the admin script? |
23:47 |
|
jcamins |
I'll point to it for my explanation. |
23:48 |
|
jcamins |
And you are required to picture me jumping up and down and pointing at the code after it's been written on a whiteboard. |
23:48 |
|
pianohacker |
It's all of the holidays code cleaned up and put in a single .pl, let me get you a link |
23:48 |
|
jcamins |
Thanks. |
23:49 |
|
pianohacker |
jcamins: http://bugs.koha-community.org[…]&attachment=19326 , tools/calendar.pl |
23:49 |
|
rangi |
nice |
23:49 |
|
pianohacker |
I'm trying to excise the given/whens while doing it a bit more nicely than an if/else chain |
23:50 |
|
jcamins |
Right, so here's where the way we use Plack makes things confusing. |
23:50 |
|
jcamins |
Skip to line 29, after the use statements. |
23:51 |
|
jcamins |
We'll ignore use statements for now because I still don't understand how they work. |
23:52 |
|
jcamins |
Starting at line 29, what scope are declarations? |
23:52 |
|
jcamins |
Hint: there's no such thing as file scope under CGIBin. |
23:52 |
|
|
tcohen joined #koha |
23:53 |
|
jcamins |
Basically, starting at line 29, that entire file is wrapped in sub __plack_tools_calendar.pl_SILLYNONSENSETHATMAKESNOSENSETOANYONEOTHERTHANTHECOMPILER { ... } |
23:53 |
|
jcamins |
So that code will get rerun per request. |
23:53 |
|
jcamins |
But not recompiled. |
23:53 |
|
jcamins |
Which is why use is weird to me. |
23:55 |
|
jcamins |
Does that make sense? |
23:56 |
|
jcamins |
I mean, did what I said make sense, not the way it behaves. |