| Time |
S |
Nick |
Message |
| 00:04 |
|
|
fredy joined #koha |
| 00:30 |
|
gmcharlt |
@quote random |
| 00:30 |
|
huginn |
gmcharlt: Quote #102: "<druthb> harrrumph!" (added by gmcharlt at 07:42 PM, November 11, 2010) |
| 00:30 |
|
gmcharlt |
oldie but goodie |
| 00:33 |
|
jenkins_koha |
Project Koha_3.10.x build #77: SUCCESS in 40 min: http://jenkins.koha-community.[…]b/Koha_3.10.x/77/ |
| 00:33 |
|
jenkins_koha |
* Mathieu Saby: Bug 8853: Suppress links in basketgroups list |
| 00:33 |
|
jenkins_koha |
* Owen Leonard: Bug 9695 - Use alphabet system preference on page used to browse patrons for patron card batches |
| 00:33 |
|
jenkins_koha |
* Liz Rea: bug 9784: add koha-shell to the koha-common man page |
| 00:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8853 major, P5 - low, ---, mathieu.saby, Pushed to Stable , clicking basketgroup name in closed basketgroups reopens it |
| 00:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9695 normal, P5 - low, ---, oleonard, Pushed to Stable , Use alphabet system preference on page used to browse patrons for patron card batches |
| 00:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9784 minor, P5 - low, ---, liz, Pushed to Stable , koha-shell missing from koha-common man page |
| 00:33 |
|
jenkins_koha |
Starting build #281 for job Koha_3.8.x (previous build: SUCCESS) |
| 00:49 |
|
|
tcohen joined #koha |
| 01:11 |
|
jenkins_koha |
Project Koha_3.8.x build #281: SUCCESS in 37 min: http://jenkins.koha-community.[…]b/Koha_3.8.x/281/ |
| 01:11 |
|
jenkins_koha |
* Owen Leonard: Bug 9695 - Use alphabet system preference on page used to browse patrons for patron card batches |
| 01:11 |
|
jenkins_koha |
* Liz Rea: bug 9784: add koha-shell to the koha-common man page |
| 01:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9695 normal, P5 - low, ---, oleonard, Pushed to Stable , Use alphabet system preference on page used to browse patrons for patron card batches |
| 01:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9784 minor, P5 - low, ---, liz, Pushed to Stable , koha-shell missing from koha-common man page |
| 01:33 |
|
jcamins |
Drat. The old attachments were not obsoleted. |
| 02:07 |
|
jenkins_koha |
Starting build #1079 for job Koha_master (previous build: FIXED) |
| 02:07 |
|
huginn |
New commit(s) kohagit: Merge branch 'bug_4906' into 3.12-master <http://git.koha-community.org/[…]46536d75cdfa9d2e2> / Bug 4906: Increment version number <http://git.koha-community.org/[…]57aab3be0e1e10fb8> / Bug 4906: Allow fine calculation to exclude grace period <http://git.koha-community.org/[…]iff;h=aba4f05b809 |
| 03:01 |
|
|
fredy joined #koha |
| 03:03 |
|
|
qu-bit joined #koha |
| 03:17 |
|
jenkins_koha |
Project Koha_master build #1079: UNSTABLE in 1 hr 9 min: http://jenkins.koha-community.[…]Koha_master/1079/ |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239: Add QueryParser module to Koha |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239: Introduce QueryParser driver for PQF |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239: Add syspref to enable QueryParser |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239: Allow the use of QueryParser for all queries |
| 03:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9239 enhancement, P5 - low, ---, jcamins, Pushed to Master , Koha should share Evergreen's QueryParser module for parsing queries |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 follow-up: POD and perlcritic fixes |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 follow-up: update koha-conf.xml |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: fix highlighting and merge error |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA-follow-up: quiet warnings and fix problem with limits |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: escape CGI input |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: the last QA follow-up was missing a require |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: don't fall back to kw if field is specified |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: remove stray debug code |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: better error handling |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: escape quotes in searches |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: amend error handling |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239 QA follow-up: fix overeager quote escaping |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239: Disable QP by default |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 9239: Increment version number |
| 03:17 |
|
jenkins_koha |
* Kyle M Hall: Bug 4906: Allow fine calculation to exclude grace period |
| 03:17 |
|
jenkins_koha |
* Jared Camins-Esakov: Bug 4906: Increment version number |
| 03:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4906 enhancement, P5 - low, ---, kyle, Pushed to Master , Allow fine calculation to exclude grace period |
| 03:30 |
|
|
fredy joined #koha |
| 04:47 |
|
|
cait joined #koha |
| 05:34 |
|
cait |
@wunder marseille |
| 05:34 |
|
huginn |
cait: The current temperature in Marseille, France is 11.0°C (6:00 AM CET on March 17, 2013). Conditions: Overcast. Humidity: 67%. Dew Point: 5.0°C. Pressure: 29.77 in 1008 hPa (Steady). |
| 05:34 |
|
cait |
@wunder Konstanz |
| 05:34 |
|
huginn |
cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 0.2°C (6:30 AM CET on March 17, 2013). Conditions: Mostly Cloudy. Humidity: 86%. Dew Point: -2.0°C. Windchill: 0.0°C. Pressure: 29.71 in 1006 hPa (Steady). |
| 05:34 |
|
cait |
over 10 degrees difference... hmpf :) |
| 05:37 |
|
|
druthb joined #koha |
| 05:53 |
|
jenkins_koha |
Starting build #78 for job Koha_3.10.x (previous build: SUCCESS) |
| 06:34 |
|
jenkins_koha |
Project Koha_3.10.x build #78: SUCCESS in 41 min: http://jenkins.koha-community.[…]b/Koha_3.10.x/78/ |
| 06:34 |
|
jenkins_koha |
Mathieu Saby: Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt |
| 06:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4266 major, P5 - low, ---, mathieu.saby, Pushed to Stable , encumbrance and expenditure not used in code |
| 06:34 |
|
jenkins_koha |
Starting build #282 for job Koha_3.8.x (previous build: SUCCESS) |
| 07:11 |
|
jenkins_koha |
Project Koha_3.8.x build #282: SUCCESS in 37 min: http://jenkins.koha-community.[…]b/Koha_3.8.x/282/ |
| 07:11 |
|
jenkins_koha |
* Mathieu Saby: Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt |
| 07:11 |
|
jenkins_koha |
* Owen Leonard: Bug 7596 - System prefs editor JS contains untranslatable English string |
| 07:11 |
|
jenkins_koha |
* Owen Leonard: Bug 9765 - Remove unused include file: budgetperiods-admin.inc |
| 07:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4266 major, P5 - low, ---, mathieu.saby, Pushed to Stable , encumbrance and expenditure not used in code |
| 07:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7596 normal, P5 - low, ---, oleonard, Pushed to Stable , System preferences editor JavaScript contains untranslatable English string |
| 07:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9765 enhancement, P5 - low, ---, oleonard, Pushed to Stable , Remove unused include file: budgetperiods-admin.inc |
| 07:12 |
|
jenkins_koha |
Starting build #79 for job Koha_3.10.x (previous build: SUCCESS) |
| 07:16 |
|
|
fredy joined #koha |
| 07:51 |
|
jenkins_koha |
Project Koha_3.10.x build #79: SUCCESS in 39 min: http://jenkins.koha-community.[…]b/Koha_3.10.x/79/ |
| 07:51 |
|
jenkins_koha |
* Owen Leonard: Bug 7596 - System prefs editor JS contains untranslatable English string |
| 07:51 |
|
jenkins_koha |
* Owen Leonard: Bug 9765 - Remove unused include file: budgetperiods-admin.inc |
| 07:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7596 normal, P5 - low, ---, oleonard, Pushed to Stable , System preferences editor JavaScript contains untranslatable English string |
| 07:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9765 enhancement, P5 - low, ---, oleonard, Pushed to Stable , Remove unused include file: budgetperiods-admin.inc |
| 07:58 |
|
|
wizzyrea joined #koha |
| 08:01 |
|
|
cait-m_ joined #koha |
| 08:02 |
|
rangi |
hi wizzyrea and cait-m_ |
| 08:02 |
|
wizzyrea |
whaddup |
| 08:02 |
|
cait-m_ |
hello :) |
| 08:02 |
|
cait-m_ |
on a train |
| 08:02 |
|
cait-m_ |
the usual |
| 08:02 |
|
rangi |
heh |
| 08:02 |
|
wizzyrea |
:) |
| 08:03 |
|
cait-m_ |
on my way to marseille! |
| 08:06 |
|
rangi |
yay! |
| 08:07 |
|
|
fredy joined #koha |
| 08:08 |
|
cait-m_ |
yay! |
| 08:08 |
|
cait-m_ |
zürich soon switching trains there |
| 08:14 |
|
cait-m_ |
@wunder marseille |
| 08:14 |
|
huginn |
cait-m_: The current temperature in Marseille, France is 10.0°C (9:00 AM CET on March 17, 2013). Conditions: Light Rain. Humidity: 71%. Dew Point: 5.0°C. Pressure: 29.74 in 1007 hPa (Steady). |
| 08:17 |
|
|
cait-m_ joined #koha |
| 08:32 |
|
* cait-m_ |
waves again |
| 08:59 |
|
wizzyrea |
wow things coming from the US are really very slow tonight. |
| 08:59 |
|
wizzyrea |
internet things, that is |
| 09:11 |
|
|
paul_p joined #koha |
| 09:17 |
|
rangi |
hi paul_p |
| 09:22 |
|
wizzyrea |
we did finally upgrade our license to gpl3 right? |
| 09:22 |
|
rangi |
yep |
| 09:23 |
|
wizzyrea |
cool, will fix the about page which just says 2+ |
| 09:23 |
|
wizzyrea |
unless that doesn't need to be done |
| 09:23 |
|
* wizzyrea |
is never sure what actually matters |
| 09:26 |
|
wizzyrea |
also should we be concerned that the sudoc icon set is a by-sa-nc license? |
| 09:43 |
|
rangi |
hmm yes, yes we should |
| 09:44 |
|
rangi |
if that is the only license, then we need to remove it |
| 09:45 |
|
rangi |
stupid nc |
| 09:48 |
|
rangi |
at least we havent done a release with them yet |
| 09:49 |
|
rangi |
jcamins: something we need to sort out before 3.12 released http://www.abes.fr/Sudoc/Boite[…]/Les-icones-Sudoc |
| 09:50 |
|
rangi |
right bed time |
| 09:51 |
|
wizzyrea |
gnite :) |
| 10:19 |
|
|
cait-m_ joined #koha |
| 10:21 |
|
cait-m_ |
@wunder marseille |
| 10:21 |
|
huginn |
cait-m_: The current temperature in Marseille, France is 9.0°C (11:00 AM CET on March 17, 2013). Conditions: Light Rain. Humidity: 76%. Dew Point: 5.0°C. Pressure: 29.71 in 1006 hPa (Steady). |
| 10:22 |
|
cait-m_ |
hm |
| 11:42 |
|
|
cait-m_ joined #koha |
| 11:42 |
|
cait-m_ |
@wunder geneve |
| 11:42 |
|
huginn |
cait-m_: The current temperature in GRAND-SACONNEX, Switzerland is 5.3°C (12:36 PM CET on March 17, 2013). Conditions: Light Rain. Humidity: 88%. Dew Point: 3.0°C. Windchill: 5.0°C. Pressure: 29.56 in 1001 hPa (Steady). |
| 11:43 |
|
cait-m_ |
@wunder konstanz |
| 11:43 |
|
huginn |
cait-m_: The current temperature in Taegerwilen, Taegerwilen, Germany is 6.9°C (12:40 PM CET on March 17, 2013). Conditions: Mostly Cloudy. Humidity: 68%. Dew Point: 1.0°C. Windchill: 7.0°C. Pressure: 29.56 in 1001 hPa (Steady). |
| 11:43 |
|
cait-m_ |
@wunder marseille |
| 11:43 |
|
huginn |
cait-m_: The current temperature in Marseille, France is 10.0°C (12:30 PM CET on March 17, 2013). Conditions: Mostly Cloudy. Humidity: 71%. Dew Point: 5.0°C. Pressure: 29.68 in 1005 hPa (Steady). |
| 11:46 |
|
jcamins |
Blergh. |
| 11:48 |
|
cait-m_ |
huh? |
| 11:48 |
|
jcamins |
Sudoc icons are licensed CC-BY-NC-SA. |
| 12:03 |
|
|
cait-m_ joined #koha |
| 12:34 |
|
|
fredy joined #koha |
| 13:29 |
|
huginn |
New commit(s) kohagit: Correct order of updatedatabase entries <http://git.koha-community.org/[…]d0f2cbeee75954a4a> |
| 13:29 |
|
|
cait-m_ joined #koha |
| 13:31 |
|
|
cait-m_ joined #koha |
| 13:31 |
|
* cait-m_ |
waves from the train again |
| 13:31 |
|
cait-m_ |
@wunder marseille |
| 13:31 |
|
huginn |
cait-m_: The current temperature in Marseille, France is 10.0°C (2:00 PM CET on March 17, 2013). Conditions: Light Rain. Humidity: 71%. Dew Point: 5.0°C. Pressure: 29.65 in 1004 hPa (Steady). |
| 13:38 |
|
jenkins_koha |
Starting build #1080 for job Koha_master (previous build: UNSTABLE -- last SUCCESS #1078 17 hr ago) |
| 13:41 |
|
|
tcohen joined #koha |
| 13:42 |
|
* jcamins |
wonders if saying "liw" three times will summon the master Debian packager. |
| 13:43 |
|
liw |
why would say my name summon eythian? |
| 13:48 |
|
jcamins |
I was thinking of you. :P |
| 13:49 |
|
jcamins |
Sorry for the pause, I was walking about the apartment cogitating on version numbers. |
| 13:49 |
|
jcamins |
I want to prepare a 3.12-alpha release, with packages. |
| 13:49 |
|
jcamins |
The packages will naturally go in the squeeze-dev repo. |
| 13:50 |
|
jcamins |
What I can't figure out is how to version them so that they are considered older than the 3.12.0 release. |
| 13:50 |
|
jcamins |
(by apt) |
| 13:52 |
|
jcamins |
3.12 will be released as 3.12.00-1. |
| 13:53 |
|
jcamins |
I'm thinking maybe the thing to do is version it 3.11.00.100~3.12alpha-1. |
| 13:53 |
|
jcamins |
Does that make sense? |
| 13:54 |
|
tcohen |
its me or rangi is trying to hurry things to leave as RMaint? |
| 13:54 |
|
tcohen |
jcamins, I like the latter |
| 13:56 |
|
jcamins |
tcohen: everyone is very ready for the 3.12 release cycle to be over, I think. |
| 13:57 |
|
jcamins |
tcohen: the problem is making the versions work with Debian's package numbering checker thing. |
| 13:57 |
|
jcamins |
So that entire thing would be the version number. |
| 13:57 |
|
tcohen |
yes, that's whyi like the second one, it resembles how alpha and beta KDE's releases are spreaded |
| 13:58 |
|
jcamins |
Oh, excellent! |
| 13:58 |
|
jcamins |
That's perfect. :) |
| 14:03 |
|
jcamins |
Let's see how many times I can roll a tarball today, shall we? |
| 14:04 |
|
tcohen |
heh |
| 14:05 |
|
jcamins |
(hint: many, many, many times) |
| 14:08 |
|
|
NateC joined #koha |
| 14:09 |
|
huginn |
New commit(s) kohagit: Increment version for 3.12-alpha release <http://git.koha-community.org/[…]909db31d20d12461b> / Add release notes for 3.12-alpha <http://git.koha-community.org/[…]6037ae6cfb0307471> |
| 14:10 |
|
jcamins |
Oh, good news: I didn't push the tag yet so I can try again if I made a mistake. |
| 14:13 |
|
jcamins |
And I'm pretty sure I did. |
| 14:14 |
|
jcamins |
Wait, no, I did push it, and I did make a mistake. |
| 14:14 |
|
jcamins |
Oh well. |
| 14:16 |
|
* jcamins |
decides to ignore it. |
| 14:30 |
|
jcamins |
Does Marseille have an 's' at the end? |
| 14:30 |
|
jcamins |
No, right? |
| 14:31 |
|
|
bgkriegel joined #koha |
| 14:32 |
|
jcamins |
Does anyone know how many people will be in Marseille? |
| 14:42 |
|
|
tcohen joined #koha |
| 14:45 |
|
liw |
jcamins, I'd do 3.12~alpha-1-1 for the Debian package number, actually |
| 14:45 |
|
jcamins |
liw: but will that file before 3.12.00? |
| 14:46 |
|
jenkins_koha |
Project Koha_master build #1080: STILL UNSTABLE in 1 hr 8 min: http://jenkins.koha-community.[…]Koha_master/1080/ |
| 14:46 |
|
jenkins_koha |
Jared Camins-Esakov: Correct order of updatedatabase entries |
| 14:47 |
|
liw |
jcamins, you try it like this: if dpkg --compare-versions 3.12~alpha-1-1 lt 3.12.00; then echo less than; else echo greater than; fi |
| 14:47 |
|
jcamins |
Cool! |
| 14:47 |
|
jenkins_koha |
Starting build #1081 for job Koha_master (previous build: STILL UNSTABLE -- last SUCCESS #1078 18 hr ago) |
| 14:47 |
|
jcamins |
Thanks. |
| 14:47 |
|
liw |
jcamins, basically, in Debian, ~ (tilde) sorts as less than anything else (including dot and empty string) |
| 14:48 |
|
|
NateC joined #koha |
| 14:48 |
|
jcamins |
That --compare-versions flag is great to know about. |
| 15:07 |
|
jcamins |
@later tell eythian Ping me when you're around, please. I want to upload a new package to squeeze-dev. |
| 15:07 |
|
huginn |
jcamins: The operation succeeded. |
| 15:13 |
|
|
Dyrcona joined #koha |
| 15:13 |
|
tcohen |
#koha, what do u think of signing Koha for static analysis by Coverity? |
| 15:14 |
|
tcohen |
several FOSS projects like Linux, Firefox, LibreOffice use that service |
| 15:14 |
|
jcamins |
I think it would be difficult to convince anyone to pay for it. |
| 15:15 |
|
tcohen |
its free for Open Source projects |
| 15:15 |
|
Dyrcona |
tcohen: I have no opinion, but would you mind supplying a URL for reference? |
| 15:15 |
|
tcohen |
Commercial site: http://www.coverity.com/ |
| 15:15 |
|
Dyrcona |
tcohen: ty |
| 15:15 |
|
jcamins |
Where do you get that, tcohen? |
| 15:15 |
|
* Dyrcona |
is lazy. ;) |
| 15:15 |
|
tcohen |
Coverity Scan (for FOSS code) http://scan.coverity.com/ |
| 15:15 |
|
jcamins |
I see only "request a free trial." |
| 15:16 |
|
jcamins |
Ah. |
| 15:16 |
|
jcamins |
I spoke to quickly. |
| 15:16 |
|
tcohen |
np jcamins |
| 15:16 |
|
jcamins |
*too |
| 15:16 |
|
jcamins |
I think it would be a good idea. |
| 15:16 |
|
* Dyrcona |
is trying to figure out how to add dual license headers to source files: GPLv2 and MPL 2.0. |
| 15:17 |
|
tcohen |
jcamins, I still didn't figure it out how to test for persistence-related problems, and was digging around for this kind of tools |
| 15:18 |
|
jcamins |
Dyrcona: should I ask why you'd want to? |
| 15:19 |
|
Dyrcona |
Yeah. I'm copying some MPL 2.0 code into a larger work covered by the GPL v2. |
| 15:19 |
|
Dyrcona |
MPL 2.0 allows that, as long as the originally MPL'd code is effectively dual-licensed. |
| 15:20 |
|
Dyrcona |
So the person who receives the code has the option of GPL or MPL for the specific code in question. |
| 15:22 |
|
jcamins |
Ah. |
| 15:22 |
|
tcohen |
jcamins, hsuold i try to register? |
| 15:22 |
|
tcohen |
maybe I'd better ask at koha-devel first |
| 15:22 |
|
jcamins |
tcohen: I'd ask on the mailing list first. |
| 15:23 |
|
jcamins |
Do they do Perl projects, though? |
| 15:23 |
|
jcamins |
Well, I think 3.12-alpha is thoroughly released. |
| 15:23 |
|
tcohen |
i should ask |
| 15:32 |
|
jcamins |
tcohen++ |
| 15:50 |
|
tcohen |
#koha, if I was to propose a major source reorganization (a.k.a. sanitizing the source structure), should I start a RFC wiki first? |
| 15:53 |
|
|
NateC joined #koha |
| 15:53 |
|
tcohen |
jcamins++ for the marketing campaign to get more signers |
| 15:54 |
|
jcamins |
tcohen: RFCs are always a good idea, but better to do things gradually, I think. |
| 15:54 |
|
jcamins |
(and submit patches that do things in very small chunks) |
| 15:54 |
|
tcohen |
yes, of course |
| 15:54 |
|
jenkins_koha |
Project Koha_master build #1081: STILL UNSTABLE in 1 hr 7 min: http://jenkins.koha-community.[…]Koha_master/1081/ |
| 15:55 |
|
jenkins_koha |
* Jared Camins-Esakov: Add release notes for 3.12-alpha |
| 15:55 |
|
jenkins_koha |
* Jared Camins-Esakov: Increment version for 3.12-alpha release |
| 15:55 |
|
tcohen |
but I wouldn't do that if there was no consensus about how to achieve it |
| 15:55 |
|
jcamins |
There will never be much in the way of consensus. |
| 15:56 |
|
jcamins |
Person A will insist that we must use Moose for EVERYTHING. |
| 15:56 |
|
jcamins |
Person B will insist that we should just use Dancer. |
| 15:56 |
|
jcamins |
Person C mojolicious. |
| 15:56 |
|
jcamins |
Person D Catalyst. |
| 15:56 |
|
jcamins |
Etc. |
| 15:57 |
|
tcohen |
I just want to propose something like: create a src/lib dir to put C4 and Koha in |
| 15:57 |
|
tcohen |
src/opac src/intranet |
| 15:58 |
|
jcamins |
Oh. |
| 15:58 |
|
tcohen |
that will make things like Makefiles and install scripts easier to maintain |
| 15:58 |
|
tcohen |
of course I will mimic Dancer way of organizing stuf :-P :-P |
| 15:59 |
|
jcamins |
Hehe. |
| 16:09 |
|
|
cait joined #koha |
| 16:12 |
|
tcohen |
any thoughts about sphinx? |
| 16:14 |
|
jcamins |
tcohen: none. |
| 16:14 |
|
cait |
th eone with the riddles? :P |
| 16:14 |
|
* cait |
waves from a hotel in marseille!! |
| 16:14 |
|
cait |
no more trains today, so glad |
| 16:14 |
|
jcamins |
Yay! |
| 16:15 |
|
cait |
so um. does someeone else remember when bag said he will arrive in marseille? :P |
| 16:15 |
|
jcamins |
No. |
| 16:15 |
|
jcamins |
logs? |
| 16:15 |
|
wahanui |
logs is http://irc.koha-community.org/irclog/koha/ |
| 16:16 |
|
|
NateC joined #koha |
| 16:16 |
|
cait |
i tried |
| 16:16 |
|
cait |
hi NateC |
| 16:16 |
|
jcamins |
Ask NateC? |
| 16:16 |
|
cait |
have yo uheard from bag eventually? |
| 16:16 |
|
NateC |
hi cait and jcamins |
| 16:16 |
|
cait |
jcamins: I am :) |
| 16:17 |
|
NateC |
bag is in Paris at the hackfest me thinks |
| 16:17 |
|
NateC |
i just got back from vacation |
| 16:17 |
|
NateC |
so im a little out of touch myself |
| 16:17 |
|
tcohen |
isn't bag logged here actually? |
| 16:18 |
|
cait |
NateC: the hackfest is in marseille ;) |
| 16:18 |
|
jcamins |
tcohen: yeah, but that's just bip. |
| 16:18 |
|
cait |
and I am here at the hotel, wondering when they might be in :) |
| 16:18 |
|
NateC |
see out of touch :) |
| 16:18 |
|
NateC |
ah |
| 16:18 |
|
NateC |
cant help you there unfortunately :( |
| 16:20 |
|
cait |
ok |
| 16:20 |
|
cait |
i left a note at the hackfest google spreadshee thingy |
| 16:20 |
|
tcohen |
http://blogs.perl.org/users/mi[…]r-and-sphinx.html |
| 16:20 |
|
jcamins |
How many people will be there? |
| 16:20 |
|
cait |
I think around 30 |
| 16:20 |
|
cait |
dpavlin is here to take me for coffee |
| 16:20 |
|
cait |
talk to you all later :) |
| 16:20 |
|
jcamins |
Bye. |
| 16:27 |
|
tcohen |
jcamins, what is moose the common factor for dancer, mojolicious, catalyst and moose itself? |
| 16:27 |
|
tcohen |
s/what// |
| 16:28 |
|
jcamins |
I'm not sure if mojolicious uses moose, but certainly the other three do. |
| 16:29 |
|
jcamins |
Mouse would probably be a better goal for 3.14. |
| 16:30 |
|
jcamins |
We're making our way toward persistence, but only slowly. |
| 16:33 |
|
jcamins |
Speaking of which... |
| 16:33 |
|
* jcamins |
goes looking for the nginx/Plack bug. |
| 16:33 |
|
tcohen |
persistence as in ORM or DBIx::Class? |
| 16:34 |
|
jcamins |
Persistence as in Plack. |
| 16:35 |
|
libsysguy |
so I think that the difference between moose moo and mouse is trivial |
| 16:35 |
|
tcohen |
"solve variable persistence problems that arise when running Koha under Plack" |
| 16:35 |
|
libsysguy |
in terms of actual application use |
| 16:35 |
|
tcohen |
Moo and Mouse are similar, and Moose is heavy? |
| 16:35 |
|
libsysguy |
just use the immutable function in moose and you'll be fine |
| 16:35 |
|
jcamins |
libsysguy: yeah, but in terms of overhead, mouse is a lot more practical under CGI. |
| 16:36 |
|
libsysguy |
I don't know if I'd consider any of them under CGI :p |
| 16:36 |
|
jcamins |
Oh, you said moo. |
| 16:36 |
|
jcamins |
tcohen: right. I don't care which one. |
| 16:36 |
|
jcamins |
(mouse or moo) |
| 16:36 |
|
libsysguy |
moo and mouse are basically truncated versions of Moose |
| 16:36 |
|
libsysguy |
which is heavy |
| 16:37 |
|
tcohen |
libsysguy: would they run fine under mod_perl¡ |
| 16:37 |
|
tcohen |
? |
| 16:37 |
|
libsysguy |
I'm not sure that is the right direction to take |
| 16:37 |
|
jcamins |
tcohen: better to focus on Plack. |
| 16:37 |
|
libsysguy |
I think to successfully run them you are going to want plack |
| 16:37 |
|
libsysguy |
yeah…what jcamins said |
| 16:37 |
|
jcamins |
We are closer to Plack compatibility than mod_perl compatibility. |
| 16:38 |
|
jcamins |
By a longshot. |
| 16:38 |
|
tcohen |
moose + immutable looks fine me :-P |
| 16:38 |
|
libsysguy |
there are going to be several iterations of refactors before any of them are going to work |
| 16:39 |
|
* libsysguy |
knows since he has been pushing for this for…a year? |
| 16:39 |
|
libsysguy |
is a year about right jcamins? |
| 16:39 |
|
jcamins |
Something like that. |
| 16:40 |
|
libsysguy |
tcohen I pushed for catalyst |
| 16:40 |
|
libsysguy |
but I just didn't have the time to do it myself |
| 16:40 |
|
libsysguy |
and without a successful proof of concept I didn't make it far with discussion alone :p |
| 16:44 |
|
libsysguy |
anywho thats my two cents on the subject :p |
| 16:44 |
|
* libsysguy |
goes back down the hole |
| 16:44 |
|
jcamins |
tcohen: pity about Coverity. |
| 16:45 |
|
jcamins |
Dyrcona: Coverity supports C/C++/Java only, but EG has a fair amount of that, so it might be worth looking into. |
| 17:08 |
|
Dyrcona |
jcamins: Thanks. I'll make a note of that. |
| 17:42 |
|
* jcamins |
waves vigorously to druthb. |
| 17:43 |
|
* druthb |
waves back, slightly less-vigorously. |
| 17:44 |
|
druthb |
@later tell wizzyrea "oh, he's good on longer trips," she says, and ho ho ho...Pixel meowed worriedly pretty-much nonstop for eighteen hours. |
| 17:44 |
|
huginn |
druthb: The operation succeeded. |
| 17:44 |
|
jcamins |
lol |
| 17:44 |
|
druthb |
Cap was givin' him the stink eye, like "will you PUH-LEASE STFU?" :P |
| 17:44 |
|
jcamins |
lol |
| 17:47 |
|
druthb |
They seem to be adapting well, though. They've discovered how to perch in my bedroom window, which has a decent-ish view of the pool (and our AC unit, which makes interesting noises) |
| 17:48 |
|
jcamins |
If they're anything like Myshkin, they can perch on *anything* if it gives them a view of birds. |
| 17:48 |
|
druthb |
oh, wait...I'm sorry...jcamins, didn't you say yesterday that it was *snowing* there? We've got folks laying out by the pool in eeety-bitty things. |
| 17:48 |
|
druthb |
tsk. |
| 17:48 |
|
* druthb |
thinks about jcamins' snow, and is not-jelly. |
| 17:48 |
|
jcamins |
Hehe. |
| 17:48 |
|
jcamins |
It's not snowing today, at least. |
| 18:45 |
|
rangi |
jcamins++ #good newsletter and 3.12-alpha |
| 18:46 |
|
rangi |
!jenkins build koha_master now |
| 18:46 |
|
jenkins_koha |
rangi: job koha_master build scheduled now |
| 18:46 |
|
jcamins |
Thanks. |
| 18:47 |
|
jenkins_koha |
Starting build #1082 for job Koha_master (previous build: STILL UNSTABLE -- last SUCCESS #1078 22 hr ago) |
| 18:50 |
|
libsysguy_afk |
druthb? |
| 18:50 |
|
wahanui |
druthb is our translation manager for 3.12 |
| 18:50 |
|
rangi |
@later tell tcohen ive already started that https://gitorious.org/koha/mai[…]its/tidy_intranet |
| 18:50 |
|
huginn |
rangi: The operation succeeded. |
| 18:50 |
|
druthb |
libsysguy? |
| 18:50 |
|
wahanui |
libsysguy is koha's hottest developer or partying with Swedes on his deck |
| 18:51 |
|
libsysguy_afk |
druthb you made it?!?! |
| 18:51 |
|
libsysguy_afk |
welcome to the H! |
| 18:51 |
|
druthb |
No. I am a well-defined figment of your imagination. |
| 18:51 |
|
jcamins |
Is that well-defined in the Haskell or PHP sense? |
| 18:51 |
|
druthb |
:P |
| 18:51 |
|
druthb |
"Yes." |
| 18:51 |
|
jcamins |
PHP, then. |
| 18:52 |
|
libsysguy_afk |
I prefer to think of it as a well defined set in mathematics |
| 19:02 |
|
|
ibeardslee joined #koha |
| 19:09 |
|
|
kathryn joined #koha |
| 19:10 |
|
rangi |
right time to take the kids to school then off to work |
| 19:28 |
|
|
drojf joined #koha |
| 19:29 |
|
drojf |
jcamins: i just updated master. when i turn on UseQueryParser my search is broken |
| 19:29 |
|
|
wizzyrea joined #koha |
| 19:29 |
|
jcamins |
drojf: !!! |
| 19:29 |
|
jcamins |
How so? |
| 19:30 |
|
drojf |
Software error: Can't call method "new" on an undefined value at /home/mirko/koha/C4/Context.pm line 959. |
| 19:30 |
|
|
tcohen joined #koha |
| 19:30 |
|
drojf |
when i turn ot off all is fine again |
| 19:30 |
|
jcamins |
Uhhh... |
| 19:30 |
|
* jcamins |
scratches his head. |
| 19:31 |
|
jcamins |
Did you restart plack? |
| 19:33 |
|
drojf |
it's apache, i have not tried plack yet |
| 19:33 |
|
jcamins |
Hrm. |
| 19:33 |
|
jcamins |
Definitely working for me. |
| 19:33 |
|
drojf |
weird |
| 19:33 |
|
jcamins |
You could fix it by changing that line to "return defined($context->{"queryparser"}) ? $context->{"queryparser"}->new : undef" |
| 19:34 |
|
jcamins |
But that doesn't explain why there's a problem. |
| 19:34 |
|
* jcamins |
thinks. |
| 19:34 |
|
jcamins |
Ummm... |
| 19:35 |
|
jcamins |
I know! QueryParser must be missing. |
| 19:35 |
|
jcamins |
Do you have QueryParser.pm anywhere? |
| 19:35 |
|
jcamins |
(locate QueryParser.pm) |
| 19:36 |
|
drojf |
doing the updatedb at the moment |
| 19:36 |
|
drojf |
/home/mirko/koha/OpenILS/QueryParser.pm |
| 19:36 |
|
drojf |
that looks ok |
| 19:36 |
|
jcamins |
It does indeed. |
| 19:37 |
|
jcamins |
You are using a git install, right? |
| 19:37 |
|
drojf |
yes |
| 19:37 |
|
jcamins |
Hmmm... |
| 19:37 |
|
jcamins |
Could you try `perl -c /home/mirko/koha/Koha/QueryParser/PQF.pm`? |
| 19:38 |
|
drojf |
that does not exist |
| 19:38 |
|
jcamins |
It doesn't? |
| 19:38 |
|
jcamins |
Oh. |
| 19:38 |
|
jcamins |
No. |
| 19:38 |
|
jcamins |
It doesn't. |
| 19:39 |
|
jcamins |
I will find an actual path and give it to you. |
| 19:39 |
|
drojf |
i have it |
| 19:39 |
|
drojf |
thanks |
| 19:39 |
|
drojf |
mirko debian:~/koha$ perl -c /home/mirko/koha/Koha/QueryParser/Driver/PQF.pm |
| 19:39 |
|
drojf |
/home/mirko/koha/Koha/QueryParser/Driver/PQF.pm syntax OK |
| 19:39 |
|
jcamins |
Oh! |
| 19:39 |
|
jcamins |
Of course. |
| 19:39 |
|
jcamins |
You didn't rerun the installer, did you? |
| 19:40 |
|
jcamins |
There's a new configuration file that koha-conf.xml needs to point to. |
| 19:40 |
|
drojf |
ah. no, i think i didn't. it ran the webinstaller |
| 19:41 |
|
jcamins |
I am updating bug 9239 to note that if you don't run the installer you need to edit koha-conf.xml by hand. |
| 19:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9239 enhancement, P5 - low, ---, jcamins, Pushed to Master , Koha should share Evergreen's QueryParser module for parsing queries |
| 19:42 |
|
jcamins |
Updated with instructions. |
| 19:42 |
|
* tcohen |
thinks upgrade should run smooth for people using 3.10 |
| 19:43 |
|
jcamins |
tcohen: no, if you're using git and don't follow the upgrade instructions, it will be a problem no matter what version. |
| 19:43 |
|
jcamins |
This is not an issue with standard and package installs, though. |
| 19:43 |
|
tcohen |
M-kay |
| 19:44 |
|
* jcamins |
reports a bug that non-updated koha-conf.xml files have issues. |
| 19:44 |
|
bgkriegel |
jcamins: near bottom, but in config block? |
| 19:44 |
|
jcamins |
bgkriegel: right. |
| 19:45 |
|
drojf |
yay, it works \o/ and i can throw onmotivated '!' in there now \o/ |
| 19:45 |
|
drojf |
jcamins++ |
| 19:45 |
|
jcamins |
:) |
| 19:45 |
|
drojf |
unmotivated even |
| 19:46 |
|
drojf |
parenthesis too. nice :) |
| 19:50 |
|
jcamins |
bug 9832 is awaiting your sign-off. |
| 19:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9832 critical, P5 - low, ---, jcamins, Needs Signoff , QueryParser causes software error if koha-conf.xml has not been updated |
| 19:51 |
|
drojf |
will do |
| 19:52 |
|
tcohen |
so, did bag get to the hackfest? |
| 19:53 |
|
jcamins |
I don't think we know. |
| 19:55 |
|
jenkins_koha |
Yippie, build fixed! |
| 19:55 |
|
jenkins_koha |
Project Koha_master build #1082: FIXED in 1 hr 8 min: http://jenkins.koha-community.[…]Koha_master/1082/ |
| 19:58 |
|
drojf |
signed off |
| 19:58 |
|
wahanui |
well, signed off is the queue the QA team should watch |
| 19:58 |
|
jcamins |
Yay! |
| 20:05 |
|
tcohen |
no coverity for us jcamins |
| 20:05 |
|
jcamins |
tcohen: yeah, I saw. |
| 20:05 |
|
tcohen |
will keep an eye on the subject anyway |
| 20:08 |
|
drojf |
in other news, i am very happy that david hasselhoff came to berlin today to save the berlin wall ^^ |
| 20:13 |
|
rangi |
heh |
| 20:21 |
|
|
brylie joined #koha |
| 20:23 |
|
tcohen |
did he bring his super-car drojf ? |
| 20:25 |
|
wizzyrea |
hehe |
| 20:26 |
|
tcohen |
if he broght it, the wall is saved, FOR SURE |
| 20:26 |
|
drojf |
tcohen: you mean this? http://www.youtube.com/watch?v=2jWIq8VowQY |
| 20:26 |
|
wizzyrea |
we don't have a bug for the sudoc icons yet eh |
| 20:27 |
|
jcamins |
wizzyrea: I posted a question on the bug that added them. |
| 20:27 |
|
wizzyrea |
cool |
| 20:27 |
|
jcamins |
If I don't have to revert them, I won't. |
| 20:27 |
|
wizzyrea |
nc is worrysome |
| 20:27 |
|
jcamins |
Yeah. |
| 20:28 |
|
jcamins |
But it's possible that they're dual-licensed and we don't know... see quote 123 for why someone would dual-license icons. ;) |
| 20:30 |
|
wizzyrea |
I guess |
| 20:30 |
|
drojf |
tcohen: my favourite pic is this one https://twitter.com/YaotzinBer[…]824/photo/1/large but someone actually came with this http://instagram.com/p/W9rOZjn4SX/ |
| 20:42 |
|
|
cait joined #koha |
| 20:42 |
|
|
qu-bit joined #koha |
| 20:43 |
|
* cait |
waves |
| 20:43 |
|
tcohen |
r u kidding drojf ? is that the real car??? |
| 20:45 |
|
eythian |
hi |
| 20:45 |
|
drojf |
tcohen: i think it is the same model, but does not have the cool red lights :D |
| 20:46 |
|
drojf |
hi cait and eythian |
| 20:46 |
|
jcamins |
eythian: I would like to provide a 3.12-alpha package on debian.koha-community.org. |
| 20:46 |
|
jcamins |
I can build the package, but what do I do with it once it's built? |
| 20:47 |
|
cait |
hi drojf and jcamins and eythian and tcohen and everyone else :) |
| 20:47 |
|
jcamins |
Also, liw recommended 3.12~alpha1 for the version... thoughts? |
| 20:47 |
|
tcohen |
hi cait, how r our french fellows behaving? |
| 20:47 |
|
cait |
have only met the international lot so far :) |
| 20:47 |
|
cait |
french tomorrow |
| 20:47 |
|
rangi |
my rule of thumb, if liw suggests something to do with debian i do it :-) |
| 20:48 |
|
jcamins |
rangi: mine too. |
| 20:48 |
|
eythian |
jcamins: this is so that people can manually install the alpha from the repo? |
| 20:48 |
|
jcamins |
eythian: right. |
| 20:48 |
|
jcamins |
Sticking it in squeeze-dev so that no one gets upgraded. |
| 20:48 |
|
jcamins |
(automatically) |
| 20:48 |
|
eythian |
though 3.12~alpha1 will superscede 3.11, which is the master build. |
| 20:48 |
|
jcamins |
Hmm. |
| 20:49 |
|
* eythian |
double checks version numbers, but I think that's the case |
| 20:49 |
|
jcamins |
I also thought about 3.11.00.100~3.12alpha1, since 3.11.00.100 is the version of the alpha. |
| 20:50 |
|
eythian |
master versions are formatted like: 3.11-1~git+20130312145747.85385f2e |
| 20:50 |
|
jcamins |
Hm. |
| 20:50 |
|
eythian |
I don't know off the top of my head if 3.11.00 will be less than that. |
| 20:50 |
|
jcamins |
And they're automatically generated daily? |
| 20:51 |
|
eythian |
no, they're semi-manually generated roughly weekly |
| 20:51 |
|
jcamins |
So in other words, we could generate a regular snapshot sometime before I push anything else and we'll have an alpha package for the rest of the week, which was my goal. |
| 20:52 |
|
eythian |
so, master now is what will be your 3.12 branch? |
| 20:52 |
|
jcamins |
Right. |
| 20:53 |
|
eythian |
because if so, that'd be very easy and I could do it right now |
| 20:53 |
|
jcamins |
Yes please! |
| 20:53 |
|
* eythian |
is on it |
| 20:53 |
|
jcamins |
And the version numbers remain 3.11.00.xxx. |
| 20:53 |
|
eythian |
yeah |
| 20:53 |
|
eythian |
well, 3.11-1~git+.... |
| 20:54 |
|
jcamins |
I mean, the version numbers in kohaversion will remain 3.11.00.xxx until release, or at least until string freeze. |
| 20:54 |
|
eythian |
oh right, yeah |
| 20:54 |
|
eythian |
reminds me, need to submit packaging updates for 3.12. Might do that soon too. |
| 20:54 |
|
jcamins |
Thanks. |
| 20:56 |
|
rangi |
the alpha is looking pretty good, (well in the 2 hours ive had it running :)) |
| 20:57 |
|
jcamins |
Yay! |
| 20:58 |
|
cait |
rangi: coul dyou test something for me? |
| 20:58 |
|
cait |
search system preferneces: opactheme |
| 20:58 |
|
cait |
and then change it and hit save |
| 20:58 |
|
cait |
it should be the only pref on that page |
| 20:58 |
|
* eythian |
produces 3.11-1~git+20130318095437.6100d874 |
| 21:00 |
|
rangi |
in master? |
| 21:02 |
|
cait |
yep |
| 21:03 |
|
rangi |
works for me |
| 21:03 |
|
rangi |
what should happen? |
| 21:04 |
|
cait |
perl error explode |
| 21:04 |
|
jcamins |
It should work. :P |
| 21:04 |
|
cait |
hash something in the url |
| 21:04 |
|
jcamins |
Yikes! |
| 21:04 |
|
rangi |
hmm i dont get that |
| 21:05 |
|
cait |
maybe a 3.10 bug then |
| 21:05 |
|
cait |
I had it happen when I was doing the presentations at th booth... like always |
| 21:05 |
|
rangi |
lemme checkout 3.10 and try |
| 21:05 |
|
cait |
oh cool thx |
| 21:05 |
|
cait |
i will be right back |
| 21:06 |
|
rangi |
yep it is there in 3.10.x |
| 21:06 |
|
rangi |
Template process failed: file error - /home/chrisc/git/catalyst-koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/HASH(0x5210998).pref: not found at /home/chrisc/git/catalyst-koha/C4/Templates.pm line 132. |
| 21:07 |
|
cait |
oh right that |
| 21:07 |
|
wahanui |
right that is what I was thinking :D |
| 21:07 |
|
rangi |
preferences.pl?tab=HASH(0x5210998) |
| 21:07 |
|
cait |
yeah, looks not too nice |
| 21:07 |
|
rangi |
somethign is not deferencing |
| 21:07 |
|
cjh |
cait: badluck :( |
| 21:07 |
|
rangi |
where it should |
| 21:07 |
|
* cait |
nods |
| 21:07 |
|
rangi |
always in a demoe |
| 21:07 |
|
rangi |
-e |
| 21:07 |
|
rangi |
ill have a look and fix |
| 21:07 |
|
cait |
cjh: I always find bugs when I show koha to someone - it's just like that *shrug* |
| 21:07 |
|
cait |
awesome rangi |
| 21:08 |
|
eythian |
a) I like my new computer, it's so fast, b) new master packages uploading right now |
| 21:09 |
|
cait |
:) |
| 21:09 |
|
cait |
we like your new computer too |
| 21:09 |
|
cait |
what did you get? |
| 21:09 |
|
cjh |
cait: live demos are always risky, but on the bright side you found an important bug :D |
| 21:09 |
|
eythian |
cait: 4-core i7-3770 |
| 21:09 |
|
cait |
can't avoid people asking for a demo :) |
| 21:10 |
|
cait |
I also foudn the "duplicate message breaks fast add bug" |
| 21:10 |
|
eythian |
(my old work computer was difficult to upgrade to 8GB of RAM, so they gave me a new one instead) |
| 21:10 |
|
cait |
if someone is interested in fixing that in 3.10 if it isn't already |
| 21:10 |
|
cait |
if you enter a fast add that brings up a duplicate message ( i already had a record with title fast add) the checkout does not happen |
| 21:10 |
|
cait |
eythian: hm |
| 21:11 |
|
eythian |
cait: also, I got to install the OS myself, it runs VMs fast, and it's on the real network ;) |
| 21:11 |
|
cait |
eythian: you are such a meany :) |
| 22:57 |
|
|
logbot joined #koha |
| 22:57 |
|
|
Topic for #koha is now Welcome to #koha this channel is for discussion of the Koha project and software http://koha-community.org. Next general IRC meeting 3 April 2013 at 10:00 UTC |
| 23:05 |
|
|
dcook joined #koha |
| 23:07 |
|
|
tcohen joined #koha |
| 23:12 |
|
|
Irma joined #koha |
| 23:48 |
|
|
Irma left #koha |
| 23:58 |
|
gmcharlt |
@quote random |
| 23:58 |
|
huginn |
gmcharlt: Quote #63: "<jwagner> But no one expects the Spammish Inquisition!" (added by jdavidb at 01:50 PM, March 01, 2010) |
| 23:58 |
|
gmcharlt |
*shudder* |
