Time |
S |
Nick |
Message |
01:39 |
|
|
dpk__ joined #koha |
05:43 |
|
|
marcelr joined #koha |
05:43 |
|
marcelr |
o/ |
06:15 |
|
|
thibaud_g joined #koha |
06:28 |
|
|
reiveune joined #koha |
06:28 |
|
reiveune |
hello |
06:29 |
|
magnuse |
\o/ |
06:31 |
|
magnuse |
huh, why can't i use cpanm inside ktd? seems like it only times out |
06:52 |
|
Joubu |
magnuse: it's working for me |
06:54 |
|
|
impeira[m] joined #koha |
06:55 |
|
magnuse |
Joubu: thanks, looks like i'll have to do some more digging |
06:55 |
|
|
alex_ joined #koha |
06:55 |
|
magnuse |
i also had problems using apt, but changing to a norwegian mirror solved it. guess it might be something similar |
07:00 |
|
|
lds joined #koha |
07:04 |
|
|
cait joined #koha |
07:29 |
|
Joubu |
tcohen, ashimema: discussion about JS template literals was during Feb dev meeting - https://irc.koha-community.org[…]3-02-08#i_2471543 |
07:56 |
|
Joubu |
ashimema: https://gitlab.com/koha-commun[…]ocker/-/issues/15 - didn't you work on something similar at some points? |
07:56 |
|
ashimema |
started but didn't get far I think |
07:57 |
|
ashimema |
just never found the time |
08:00 |
|
cait |
caroline: I figured it out, it's 33514 - depends on SearchWithISBNVariations |
08:00 |
|
cait |
bug 33514 |
08:00 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33514 normal, P5 - low, ---, koha-bugs, NEW , SearchWithIS[B|S]NVariations breaks ISBN search in item search |
08:07 |
|
ashimema |
Joubu.. is there a reason we mix rest query styles in our vue components? |
08:07 |
|
* ashimema |
is looking at the cypres tests for a bug |
08:07 |
|
ashimema |
and noticed we sometimes use field level query params |
08:07 |
|
ashimema |
other times use the q= search |
08:09 |
|
ashimema |
actually, ignore that.. i think in this case it's that we added a param to make a particular complex search simpler |
08:10 |
|
paulderscheid[m] |
Morning #koha |
08:13 |
|
PedroAmorim[m] |
o/ |
08:21 |
|
Joubu |
ashimema: here now, do you still have a question? :) |
08:21 |
|
ashimema |
nope |
08:21 |
|
ashimema |
I rubber ducked myself 😜 |
08:21 |
|
Joubu |
ashimema: I've let a comment on koha-sandboxes-docker #15 |
08:22 |
|
ashimema |
good point on the security concerns it could introduce |
08:35 |
|
paulderscheid[m] |
@seen mtj |
08:35 |
|
huginn |
paulderscheid[m]: mtj was last seen in #koha 19 hours, 54 minutes, and 22 seconds ago: <mtj> git checkout v22.05.11 |
08:54 |
|
marcelr |
bug 29185 is ready for signoff |
08:54 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29185 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Show MARC21 tag 765 - Original Language Entry |
08:56 |
|
ashimema |
Joubu still around? |
08:56 |
|
Joubu |
yep |
08:57 |
|
ashimema |
I'm working on a cypress test for bug 33490 |
08:57 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33490 normal, P5 - low, ---, jonathan.druart+koha, Signed Off , Agreements - Filter by expired results in error |
08:57 |
|
ashimema |
still kinda wrapping my head around cypress testing.. |
08:58 |
|
ashimema |
I've got an intercept and I've added tests for max_expiration_date_filter containing the default 'today' value if none is added |
08:58 |
|
ashimema |
however.. |
08:58 |
|
ashimema |
the fix you've makes total sense in code.. |
08:58 |
|
ashimema |
but i can't work out how to test it.. |
08:58 |
|
ashimema |
i.e... how can I assert the order of events.. |
08:59 |
|
Joubu |
First you could simply access /cgi-bin/koha/erm/agreements?by_expired=true |
08:59 |
|
ashimema |
i.e. that the uri actually gets the today date |
08:59 |
|
ashimema |
right now I've got `cy.intercept("GET", "/api/v1/erm/agreements?max_expiration_date="+dates["today_iso"], []);` |
08:59 |
|
Joubu |
ha but we are intercepting anyway |
08:59 |
|
ashimema |
which works and sort of proves the your fix |
09:00 |
|
ashimema |
before your fix it would still 'pass' because we just wouldn't intercept |
09:00 |
|
ashimema |
is there a way to assert that the intercept should happen |
09:00 |
|
ashimema |
or am I misunderstanding something... |
09:00 |
|
* ashimema |
hasn't found it in the docs.. so was hoping you might have already had to do it |
09:01 |
|
ashimema |
I originally had cy.intercept("GET", "/api/v1/erm/agreements?max_expiration_date=*", []); |
09:01 |
|
Joubu |
you could make the intercept return something specific and see if it's displayed in the table, |
09:01 |
|
Joubu |
? |
09:01 |
|
ashimema |
which intercepts both.. with and without a valid date being assigned |
09:02 |
|
Joubu |
you are missing by_expired=true in the intercept |
09:02 |
|
ashimema |
OK.. so you'd mock an additional specific response so we can assert that we got it. |
09:02 |
|
ashimema |
it intercepts without it. |
09:03 |
|
ashimema |
in fact... |
09:03 |
|
ashimema |
it doesn't even have the by_expired=true in the xhr we're intercepting |
09:03 |
|
ashimema |
I assume 'new url' is what we set the browser address bar to |
09:03 |
|
Joubu |
yes, I would 1. intercept /api/v1/erm/agreements?max_expiration_date=${today}* and make it return 1 result with a specific name 2. Hit /cgi-bin/koha/erm/agreements?by_expired=true and confirm that the name appears in the table |
09:03 |
|
ashimema |
I should probably also be testing that.. I've not worked out how to yet however. |
09:04 |
|
Joubu |
3. Same for /cgi-bin/koha/erm/agreements?by_expired=true&max_expiration_date=2023-04-04 |
09:04 |
|
ashimema |
OK.. ta |
09:04 |
|
ashimema |
that gives me some things to go on |
09:04 |
|
Joubu |
exact, by_expired is only for the browse |
09:04 |
|
ashimema |
I'm using this as a learning ground for getting my cypress testing up to scratch |
09:04 |
|
Joubu |
browser* |
09:05 |
|
ashimema |
then I can start helping more on erm 🙂 |
09:05 |
|
Joubu |
don't forget the '*' in the intercept :) |
09:06 |
|
ashimema |
🙂 |
09:09 |
|
ashimema |
I wish there was a way to add to test output the way you can in perl.. it's easy to forgot what your testing for without a note.. |
09:09 |
|
ashimema |
I suppose I can just add // comments as notes intead |
09:10 |
|
marcelr |
ashimema++ all for documenting what you did |
09:10 |
|
marcelr |
especially in this new area :) |
09:15 |
|
ashimema |
cypress is cool.. and fairly easy to write/understand... |
09:15 |
|
ashimema |
but it takes a little wrapping your head around to know how to actually use it to test stuff.. and no just 'drive' an application |
09:16 |
|
ashimema |
it would be easy to write a whole playbook in it, and not assert anything so it doesn't actually test anything. |
09:16 |
|
marcelr |
i should have a look |
09:18 |
|
ashimema |
Joubu.. I presume your running them outside of ktd to get the open to work? |
09:18 |
|
ashimema |
I've not looked into x11 forwarding options properly yet |
09:18 |
|
ashimema |
so I just yarn installed outside my container.. updated cypress.json to point to localhost:8081 |
09:19 |
|
ashimema |
then running yarn run cypress open is magic |
09:19 |
|
ashimema |
but it would be nice not to have to yarn install at all |
09:19 |
|
ashimema |
on the host that is. |
09:20 |
|
Joubu |
yes, outside |
09:20 |
|
ashimema |
okies |
09:20 |
|
ashimema |
so I'm doing that same as you and pedro then |
09:21 |
|
Joubu |
cypress.json should be adjusted |
09:21 |
|
Joubu |
it's a bug |
09:21 |
|
ashimema |
indeed |
09:21 |
|
ashimema |
probably should be set to use a env variable right? |
09:21 |
|
ashimema |
then one can override it inside ktd for CI or set it locally for local running.. right? |
09:21 |
|
ashimema |
anywho |
09:21 |
|
ashimema |
I digress |
09:22 |
|
Joubu |
I think we didn't manage to do that |
09:22 |
|
ashimema |
should really be swatting up for my accessibility meeting in 30 mins instead. |
09:39 |
|
ashimema |
ooooh.. I just found the magic in the docs |
09:39 |
|
ashimema |
cy.wait('@getSearch').its('request.url').should('include', '/search?query=Book') |
10:15 |
|
cait |
oh |
10:15 |
|
|
ArvindNaikwadi[m] joined #koha |
10:15 |
|
cait |
all the matrix users left |
10:20 |
|
|
dpk_ joined #koha |
10:22 |
|
|
rangi[m] joined #koha |
10:58 |
|
tcohen |
hola #koha o/ |
10:58 |
|
oleonard |
hello #koha o/ |
11:06 |
|
magnuse |
kia ora oleonard |
11:09 |
|
cait |
oleonard: just the one I was loookign for :) |
11:09 |
|
cait |
if( $(".tab-pane.active").length < 1 ){ |
11:09 |
|
cait |
$("#bibliotabs a:first").tab("show"); |
11:09 |
|
cait |
} |
11:09 |
|
cait |
this doesn't seem to work on the staff MARC detail page - I think because we also have .tab-pane in the header search |
11:10 |
|
cait |
it#s in 22.11 - do you know if maybe a patch was missed or so? |
11:10 |
|
cait |
the MARC vie opens without an active "marc" tab |
11:10 |
|
oleonard |
cait: I submitted a patch to fix multiple instances of that |
11:10 |
|
cait |
do you know which one maybe? |
11:11 |
|
cait |
bug I mean |
11:11 |
|
oleonard |
Bug 33278 |
11:11 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33278 normal, P5 - low, ---, oleonard, Pushed to stable , Correct JS for activating default tab on various pages |
11:12 |
|
cait |
aah and already pushed for 22.11.05 |
11:12 |
|
cait |
perfect |
11:12 |
|
cait |
thank you! |
11:12 |
|
cait |
oleonard++ |
11:26 |
|
tcohen |
#koha do you think we could schedule the failed dev meeting for next week? |
11:26 |
|
tcohen |
would you accept doing it 30 minutes earlier? |
11:28 |
|
|
AgustinMoyano[m] joined #koha |
11:28 |
|
|
Annelisterman[m] joined #koha |
11:28 |
|
|
ashimema joined #koha |
11:28 |
|
|
aude_c[m] joined #koha |
11:28 |
|
|
biblioteca[m] joined #koha |
11:28 |
|
|
bill-k[m] joined #koha |
11:28 |
|
|
boormanthechauffeur[m] joined #koha |
11:28 |
|
|
casualcatgenerator[m] joined #koha |
11:28 |
|
|
MichaelaSieberBIB[m] joined #koha |
11:28 |
|
|
davidnz joined #koha |
11:28 |
|
|
domm[m] joined #koha |
11:28 |
|
|
EmmiTakkinen[m] joined #koha |
11:28 |
|
|
eric1122[m] joined #koha |
11:28 |
|
|
ProfDrOsmanBarre[m] joined #koha |
11:28 |
|
|
MohamedOmar[m] joined #koha |
11:28 |
|
|
impeira[m] joined #koha |
11:28 |
|
|
jeffhub[m] joined #koha |
11:28 |
|
|
jo[m] joined #koha |
11:29 |
|
|
JohannaGrpler[m] joined #koha |
11:29 |
|
|
KodoKorkalo[m] joined #koha |
11:29 |
|
|
krimsonkharne[m] joined #koha |
11:29 |
|
|
lassmaher[m] joined #koha |
11:29 |
|
|
lauraesca[m] joined #koha |
11:29 |
|
|
RudyHinojosa[m] joined #koha |
11:29 |
|
|
lisette[m] joined #koha |
11:29 |
|
|
lucyvh[m] joined #koha |
11:29 |
|
|
MariaLegrand[m] joined #koha |
11:29 |
|
|
MatthewBlenkinsop[m] joined #koha |
11:29 |
|
|
MenchieBelarmino[m] joined #koha |
11:29 |
|
|
mjkerpan[m] joined #koha |
11:29 |
|
|
MinajNaikawdi[m] joined #koha |
11:29 |
|
|
mason[m] joined #koha |
11:29 |
|
|
paulderscheid[m] joined #koha |
11:29 |
|
|
PedroAmorim[m] joined #koha |
11:29 |
|
|
perplexedtheta joined #koha |
11:29 |
|
|
NarayananNarayanan[m] joined #koha |
11:29 |
|
|
piotrmaj[m] joined #koha |
11:29 |
|
|
NikolayGospodinov[m] joined #koha |
11:29 |
|
|
ShopGeek[m] joined #koha |
11:29 |
|
|
SlackIntegration[m] joined #koha |
11:29 |
|
|
adminucd[m] joined #koha |
11:29 |
|
|
thibaud_g[m] joined #koha |
11:29 |
|
|
tkero[m] joined #koha |
11:29 |
|
|
MohamedTraore[m] joined #koha |
11:29 |
|
|
trivenichandriki1[m] joined #koha |
11:29 |
|
|
TriveniChandriki[m] joined #koha |
11:29 |
|
|
tuxayo joined #koha |
11:29 |
|
|
wrmslibrarian[m] joined #koha |
11:29 |
|
|
zimbo_[m] joined #koha |
11:33 |
|
Joubu |
we rescheduled it twice already |
11:34 |
|
cait |
I think we could do it 1 hour earlier (daylight savings) |
11:34 |
|
|
marcelr joined #koha |
11:35 |
|
marcelr |
o/ |
11:35 |
|
tcohen |
cait: thanks |
11:35 |
|
cait |
hi marcelr |
11:35 |
|
tcohen |
Joubu: yeah, we were a bit f*d up last week |
11:35 |
|
cait |
hm my git pull is stuck - someone else too? |
11:35 |
|
cait |
... and now it started, of course |
11:37 |
|
tcohen |
it is because I logged in the server to check |
11:39 |
|
Joubu |
no, it's because cait asked here, it happened to me yesterday as well. It unstuck only when you are complaining about it. |
11:40 |
|
oleonard |
Then I guess I should complain about the sink in my kitchen being broken? |
11:40 |
|
tcohen |
complain++ |
11:59 |
|
tcohen |
paulderscheid[m]: hi. did you offer to rewrite a page in Vue so it is used as reference by other devs? |
11:59 |
|
tcohen |
are you still willing to? |
11:59 |
|
paulderscheid[m] |
Yes |
11:59 |
|
paulderscheid[m] |
The cities thing! |
12:02 |
|
paulderscheid[m] |
I'll start doing that later today. |
12:05 |
|
Joubu |
Do we agree that the plan is to port what has been done for ERM to a simple page that will serve as an exampe? |
12:08 |
|
tcohen |
\o/ yes |
12:09 |
|
paulderscheid[m] |
Yes |
12:09 |
|
paulderscheid[m] |
@joubu |
12:09 |
|
huginn |
paulderscheid[m]: I'll give you the answer as soon as RDA is ready |
12:10 |
|
Joubu |
paulderscheid[m]: let met know if you have any questions! |
12:12 |
|
paulderscheid[m] |
I will |
12:20 |
|
Joubu |
oleonard: did you lose the odd/even background colours in our tables on purpose? |
12:31 |
|
tcohen |
git grep _get_data_and_patron |
12:31 |
|
tcohen |
<.< |
12:36 |
|
oleonard |
Joubu: Did *I* lose them?? :D |
12:37 |
|
|
Dyrcona joined #koha |
12:40 |
|
oleonard |
Joubu: Checking a couple of admin pages doesn't show table striping to be broken |
12:40 |
|
tcohen |
which page you found broken, Joubu? |
12:44 |
|
Joubu |
right, that's actually my screen that has very bad contrast it seems |
12:45 |
|
oleonard |
Joubu: I'll be right over |
12:47 |
|
|
emlam joined #koha |
12:55 |
|
cait |
Joubu: I have one of those screens too - I was driving ashimema crazy complaining about the background colors :) |
12:56 |
|
ashimema |
haha |
12:56 |
|
cait |
when we reviewed the new design |
12:56 |
|
ashimema |
yup.. I remember |
12:56 |
|
oleonard |
Everyone needs to get back into their dank dark caves where they belong |
12:56 |
|
tcohen |
maybe we just need a slightly higher contrast |
12:56 |
|
ashimema |
silly thing is.. accessability tools actually suggest the contrast is good?! |
12:56 |
|
ashimema |
yeah.. |
12:56 |
|
cait |
not sure how they check for background, maybe only font:background? |
12:57 |
|
cait |
... and what did I complain about? (just read back) |
12:57 |
|
cait |
I can complain about item search killing servers... if that helps any? |
12:59 |
|
tcohen |
you complained about git |
13:00 |
|
* cait |
is still traumatized |
13:00 |
|
cait |
aah |
13:00 |
|
tcohen |
and it worked |
13:00 |
|
tcohen |
maybe the item search stuff is just fixed now |
13:00 |
|
tcohen |
:-P |
13:00 |
|
cait |
yeah, that's how it works... as soon as you embarass yoruself asking something you figure it out |
13:00 |
|
cait |
tcohen: I think not... but I think i will turn off the isbn pref for now :( |
13:00 |
|
cait |
which is sad, because it works perfectly for the catalog |
13:01 |
|
|
caroline joined #koha |
13:03 |
|
oleonard |
Hi caroline |
13:03 |
|
caroline |
Hi oleonard! |
13:10 |
|
davewood |
hi all, I had write code to undelete erroneously deleted biblios&items ... Im pretty sure someone had to to that before. is there a better way to do it or possible koha utils that i should have looked up before doing the work myself? |
13:10 |
|
davewood |
https://www.koha-support.eu/ho[…]lioitems-in-koha/ |
13:12 |
|
oleonard |
https://inlibro.com/en/koha-pl[…]rds-instructions/ |
13:12 |
|
davewood |
sweet |
13:12 |
|
oleonard |
davewood: ^ I don't think I've tried it, but maybe it will work for you |
13:16 |
|
oleonard |
Honestly I don't know why it isn't built into Koha! |
13:17 |
|
* oleonard |
glares at the 400+ templates that could be updated to follow-up bug 33077 |
13:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33077 enhancement, P5 - low, ---, oleonard, Pushed to master , Improve ease of translating template title tags |
13:18 |
|
ashimema |
Joubu ? |
13:19 |
|
ashimema |
is there an 'easy way' to enter a date into a vue flatpickr component using cypress that I'm missing |
13:20 |
|
ashimema |
we hide the input that has an id.. so then actually finding and entering a date using .type ends up... erm.. hard |
13:21 |
|
davewood |
oleonard: builtin undelete would make alot of sense. |
13:22 |
|
caroline |
cait did you have a look at item_priority in the daylight and come to the same conclusion? |
13:22 |
|
caroline |
maybe oleonard you would know how to make this column appear https://snipboard.io/5cF39K.jpg |
13:23 |
|
caroline |
in the holdings table on the opac |
13:23 |
|
cait |
caroline: i think something changed and the templates were not adjusted |
13:24 |
|
cait |
maybe when the code was moved to Koha namespace |
13:24 |
|
cait |
it's wrong |
13:24 |
|
cait |
the defined for sure |
13:24 |
|
cait |
it makes a lot of holds_count.defined and that's alays true |
13:24 |
|
caroline |
ok I will write test plan and file the bug thanks for looking! |
13:27 |
|
oleonard |
caroline: Do you know when it last worked? |
13:28 |
|
caroline |
oleonard, I don't know that it ever did... but I don't see item-level holds that often |
13:28 |
|
Joubu |
ashimema: yes, we do that somewhere I think, let me search for it |
13:29 |
|
Joubu |
ashimema: t/cypress/integration/ERM/Agreements_spec.ts |
13:29 |
|
caroline |
I came across it because I was documenting (in "human" text, in French) what each column is |
13:29 |
|
Joubu |
lines 231 cy.get("#started_on_0+input").click(); |
13:29 |
|
Joubu |
well, that's not what you are asking for, but did you see that? |
13:30 |
|
Joubu |
Did you try cy.get("#started_on_0+input").type("your date")? |
13:31 |
|
* oleonard |
takes the Duolingo course in human |
13:32 |
|
caroline |
lol... it has that? I bet it's so that AI bots can sound more human and overtake us |
13:33 |
|
caroline |
XD |
13:33 |
|
oleonard |
No, I'm just kidding! |
13:34 |
|
caroline |
I read an article about chatGPT4 where it hired a human on fiver or rabbittask or whatever to solve a capchat for it, because it knew it couldn't do it on it's own... and lied to the human about it saying it was a person with a disability and that's why it needed help |
13:35 |
|
caroline |
https://www.vice.com/en/articl[…]taskrabbit-worker |
13:43 |
|
aude_c[m] |
cait: could I ask you how you would say "uniform title" in German please? |
13:44 |
|
aude_c[m] |
(also, my colleague Janet says hello!) |
13:44 |
|
aude_c[m] |
We're having fun with a de-DE XSLT file... |
13:44 |
|
aude_c[m] |
Any other German speaker welcome to help! |
13:44 |
|
paulderscheid[m] |
cait aude_c Einheitssachtitel ? |
13:46 |
|
aude_c[m] |
Thank you! We'll use that for now :) |
14:00 |
|
caroline |
ppl here for docs meeting? |
14:00 |
|
aude_c[m] |
yes |
14:00 |
|
aude_c[m] |
(no lucyvh today) |
14:01 |
|
caroline |
#startmeeting Documentation IRC meeting 13 April 2023 |
14:01 |
|
huginn |
Meeting started Thu Apr 13 14:01:09 2023 UTC. The chair is caroline. Information about MeetBot at http://wiki.debian.org/MeetBot. |
14:01 |
|
huginn |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
14:01 |
|
huginn |
The meeting name has been set to 'documentation_irc_meeting_13_april_2023' |
14:01 |
|
caroline |
#topic Introductions |
14:01 |
|
caroline |
please use "#info" in front of your introduction to have it show up in the automatic minutes |
14:01 |
|
caroline |
#link agenda https://wiki.koha-community.or[…]ing_13_April_2023 |
14:01 |
|
caroline |
#info Caroline Cyr La Rose, inlibro, Québec Canada |
14:01 |
|
aude_c[m] |
#info Aude Charillon, PTFS Europe, UK |
14:02 |
|
cait |
paulderscheid[m]: uniform title? |
14:03 |
|
aude_c[m] |
Sorry cait , that was me asking how you would say "uniform title" in German! |
14:04 |
|
cait |
i think with RDA they killed the sach |
14:04 |
|
cait |
Einheitstitel |
14:04 |
|
cait |
but woudl have to check with my cataloguing coworkers |
14:04 |
|
cait |
I work with one of the authors of the German RDA book :) |
14:05 |
|
aude_c[m] |
Ohh. That's fine, thank you. I've used Einheitssachtitel; the library will tell me if they want something else! |
14:05 |
|
caroline |
#topic Updates - Review of action points |
14:05 |
|
caroline |
cait followup on mailing list close down |
14:05 |
|
caroline |
did you have news from paul? |
14:05 |
|
cait |
no, but was planning to ask again |
14:05 |
|
cait |
sorry, only here with one eye :) |
14:06 |
|
caroline |
lol no problem |
14:06 |
|
cait |
I stil get a moderation request every day, I won't forget :) |
14:06 |
|
caroline |
I thought of reminding you during hackfest, but only thought about it on Friday morning (so friday afternoon for you) a bit too late |
14:07 |
|
caroline |
caroline to send an email to the mailing list about hackfest screenshot update details - I totally forgot about this I'm really sorry! |
14:07 |
|
caroline |
I know it still happened, we'll talk about it in the project updates |
14:07 |
|
caroline |
caroline to ping docs team member friday march 17 to do a test run for screenshot update - I didn't forget this and we did it and it worked well I think? |
14:07 |
|
caroline |
all to look into their own docs for ES related info and submit it to have a starting point in the manual |
14:07 |
|
aude_c[m] |
yes! :) |
14:08 |
|
aude_c[m] |
I gathered my ES doc but haven't submitted anything to the manual yet... |
14:09 |
|
caroline |
Cool thanks aude_c[m] ! |
14:09 |
|
caroline |
I have some stuff about mappings https://inlibro.com/knowledge-[…]he-elasticsearch/ |
14:09 |
|
aude_c[m] |
To clarify: I don't actually have anything ready to submit yet! |
14:10 |
|
aude_c[m] |
ByWater shared an Elastic syntax cheatsheet from SEKLS https://bywatersolutions.com/e[…]es-elastic-search |
14:10 |
|
caroline |
last action point was caroline to add video calls to next agenda which I did just now, it will be in the project updates |
14:11 |
|
caroline |
#topic Project updates |
14:11 |
|
caroline |
#info Hackfest screenshot extravaganza happened headed aby Aude |
14:12 |
|
aude_c[m] |
On-site on the Wednesday: 6 people participating (plus me), 36 screenshots replaced in total. Joining remotely: Lucy replaced another 15. |
14:12 |
|
caroline |
wow! |
14:12 |
|
aude_c[m] |
I had to improvise as I didn't expect that many people on site and wasn't well prepared, but we managed to make it work! |
14:13 |
|
aude_c[m] |
Two Hackfest participants replaced another 7 screenshots the next day. |
14:13 |
|
aude_c[m] |
I think it would be fun to do again. Lucy and I are going to keep going. |
14:13 |
|
caroline |
That's great! |
14:14 |
|
|
AnkeB joined #koha |
14:14 |
|
caroline |
segue into automated screenshots? |
14:14 |
|
aude_c[m] |
Maybe doing everything on GitLab directly (including amending images.rst) would be better next time |
14:14 |
|
AnkeB |
Hi, can anyone help with Zebra indexing? |
14:14 |
|
aude_c[m] |
because it would helps us spot things that have been deleted by mistake a bit quicker |
14:14 |
|
AnkeB |
Esp. the date range search for pubdate? |
14:15 |
|
aude_c[m] |
Also, the "who's doing what" notepad may still be relevant https://mensuel.framapad.org/p[…]ters-9zvo?lang=en |
14:15 |
|
aude_c[m] |
for anyone who wants to continue helping with replacing screenshots |
14:15 |
|
caroline |
Ok the framapad won't be there forever, I only made one for 30 days |
14:15 |
|
caroline |
So maybe we should add it to the docs projects wiki page? |
14:16 |
|
caroline |
https://wiki.koha-community.or[…]ion_Team#Projects |
14:16 |
|
aude_c[m] |
Right, we'll see how many of us continue doing it. If it's not a huge group, it will work without |
14:16 |
|
aude_c[m] |
Yes, that would be the other option |
14:17 |
|
aude_c[m] |
One of the main question from Hackfest participants was: why aren't the new screenshots in the 22.11 manual? |
14:18 |
|
caroline |
oh we'd have to cherry-pick the changes |
14:18 |
|
caroline |
since we're now working on the 23.05 manual |
14:18 |
|
aude_c[m] |
And the answer was: I don't know how to do that, and Martin / Matt B thought weren't sure I could do it with the tools I use |
14:19 |
|
aude_c[m] |
Is that something you do, Caroline? Otherwise I will ask my colleagues again another time |
14:19 |
|
caroline |
Yes it's possible through the gitlab interface, that's how I usually do it |
14:19 |
|
aude_c[m] |
Ohh brilliant! Can we talk another time about how it works please? |
14:19 |
|
caroline |
Sure |
14:20 |
|
caroline |
It's in the commit Options > Cherry pick |
14:20 |
|
aude_c[m] |
This actually led me to the (controversial?) thought: do we still need more than one version of the manual?! |
14:20 |
|
caroline |
https://snipboard.io/ndiU8C.jpg |
14:20 |
|
caroline |
Oof, that is a big question |
14:21 |
|
aude_c[m] |
Maybe one for when more people are around? |
14:21 |
|
caroline |
I know a lot of people look into the manual for their own version |
14:21 |
|
caroline |
I think the Koha interface also links directly to the version manual |
14:21 |
|
aude_c[m] |
It would simplify a lot of things if we only had one version of the manual |
14:22 |
|
aude_c[m] |
It would always be the most up to date, for a start |
14:22 |
|
caroline |
But if something changes, it might not be the same in you koha vs the manual? |
14:22 |
|
caroline |
*your |
14:22 |
|
aude_c[m] |
yes |
14:22 |
|
aude_c[m] |
that's one of the points in the "con" column |
14:22 |
|
* ashimema |
wondered about adding tags into one manual to say when features were added.. as aposed to having a manual per version |
14:23 |
|
ashimema |
but I'm not sure how well it would fly |
14:23 |
|
ashimema |
is this a question around backports.. |
14:23 |
|
ashimema |
I'm late to the party today.. tooooooo many meetings |
14:23 |
|
caroline |
It also links into the reorganization david wants to do |
14:23 |
|
aude_c[m] |
yes, but Caroline also just told me I can cherry pick from the GitLab interface (super useful, thank you!) |
14:24 |
|
caroline |
ashimema : https://snipboard.io/ndiU8C.jpg |
14:24 |
|
ashimema |
we have an rmaint for each koha code branch for a reason.. it's a big job keeping on top of it all... perhaps docs should consider a similar recognition of team organisation |
14:24 |
|
ashimema |
ooh.. cool |
14:24 |
|
ashimema |
I didn't know cherry-picking in the gitlab UI worked 🙂 |
14:25 |
|
ashimema |
nice |
14:25 |
|
caroline |
I only tried it via terminal once... I wanted to stay on top of it this cycle... did not stay on top if it :( |
14:26 |
|
* ashimema |
thinks we need a docs team drive to get some manual rmaints to help with the waterfalling. |
14:26 |
|
aude_c[m] |
Regarding rmaint for Koha manual: it's an idea. Though considering our numbers right now, it sounds rather ambitious! :D |
14:26 |
|
caroline |
aude_c[m], that's what I keep telling ashimema lol! |
14:26 |
|
aude_c[m] |
We do need a Docs team drive |
14:26 |
|
ashimema |
haha.. it's the same in all community. |
14:26 |
|
aude_c[m] |
*recruitment drive |
14:26 |
|
caroline |
we are 3-4 at the most at any point |
14:26 |
|
ashimema |
never enough people, never enough time |
14:27 |
|
aude_c[m] |
yep |
14:27 |
|
caroline |
I thought the screenshot extravaganza might help recruit |
14:28 |
|
ashimema |
how much of a review process is there in the manual submissions.. I gave Aude the permissions to merge stuff at hackfest and hopefully that's helping to spread the load a little |
14:28 |
|
ashimema |
cherry-picking down is in her gift now too with those rights I imagine. .. so at least that's two of you looking at it/thinking about it now. |
14:28 |
|
caroline |
Not much honestly... I merge all my own stuff too |
14:29 |
|
caroline |
If there is an error, we find it down the way and correct it |
14:29 |
|
caroline |
it's not like code where it can break something |
14:29 |
|
aude_c[m] |
Screenshot extravaganza and recruitment: yes. And I think it's a start; we need to sustain it. We could keep in touch with that group, do more to promote Docs in various places, have "intro to Docs" sessions like the bug sign-off ones, ... |
14:29 |
|
ashimema |
well.. if it works, don't knock it I say |
14:29 |
|
ashimema |
I trust you guys 😜 |
14:29 |
|
Joubu |
Do you document the steps to create the screenshots? |
14:30 |
|
aude_c[m] |
Lucy was given the same permissions and we already agreed we should not merge our own requests but merge each others'. So Caroline, happy to merge yours if you want. |
14:30 |
|
caroline |
aude_c[m], ok we can do it that way |
14:31 |
|
aude_c[m] |
@joubu: there are some explanations on the Editing Koha manual page https://wiki.koha-community.or[…]dding_screenshots |
14:31 |
|
huginn |
aude_c[m]: I'll give you the answer as soon as RDA is ready |
14:31 |
|
caroline |
how to add screenshots is here https://wiki.koha-community.or[…]dding_screenshots but I never do it via the interface so not sure if it's still good |
14:31 |
|
aude_c[m] |
s/://, s/Editing_the_Koha_Manual/Editing\_the\_Koha\_Manual/, s/Adding_screenshots/Adding\_screenshots/ |
14:31 |
|
Joubu |
I mean, "for screenshot xxx you need to do that, then..." |
14:31 |
|
aude_c[m] |
I updated that before Hackfest |
14:31 |
|
caroline |
Joubu, no not in that way |
14:32 |
|
Joubu |
it will be useful if we want to automate that later |
14:32 |
|
caroline |
Currently we do it in the human way |
14:32 |
|
Joubu |
wasn't it a plan to automate them? |
14:32 |
|
aude_c[m] |
(Every time I check that page though, I am very tempted to completely change its structure) |
14:32 |
|
aude_c[m] |
That's the next agenda item ;) |
14:33 |
|
caroline |
Joubu, there is idea but no plan |
14:33 |
|
Joubu |
sorry! |
14:33 |
|
caroline |
it's fine we can talk about it |
14:33 |
|
caroline |
#info Automated screenshot idea |
14:34 |
|
* ashimema |
was about to play with Cypress Studio... looks cool. |
14:34 |
|
* ashimema |
must not let himself get distracted |
14:34 |
|
aude_c[m] |
What do we do? Do we need David? And a way to talk other by typing everything? |
14:34 |
|
caroline |
I know you and David have tried it, but there has never been an explanation of how to do it for the rest of us |
14:34 |
|
|
AvengingChicken joined #koha |
14:34 |
|
aude_c[m] |
The four of you interested in getting together to go over the details? |
14:35 |
|
aude_c[m] |
And getting to the point where we in the Docs team can start testing the idea? (and see how we can help to get there) |
14:36 |
|
caroline |
I know long term, it's better for the manual, but we already have trouble recruiting, if we have to program stuff too it will not help our numbers |
14:36 |
|
Joubu |
I would like to (have time and) look at how we (devs) could provide the doc team and easy "framework" to write the steps to generate the screenshots |
14:36 |
|
Joubu |
it will not be proper programming |
14:37 |
|
Joubu |
I am going to show you some easy step, from an existing file: |
14:37 |
|
Joubu |
cy.visit("/cgi-bin/koha/erm/agreements"); (you go there) |
14:37 |
|
caroline |
ok, your answer to the cypress question before the meeting scared me lol! |
14:37 |
|
Joubu |
cy.contains("New agreement").click(); |
14:37 |
|
Joubu |
you click "new agreement" |
14:37 |
|
Joubu |
cy.get("#agreement_name").type("your agreement name"); |
14:37 |
|
Joubu |
you fill the node #agreement_name with "your agreement name" |
14:37 |
|
Joubu |
cy.get("#agreements_add").contains("Submit").click(); |
14:37 |
|
Joubu |
you click the submit button in the #agreements_node |
14:38 |
|
Joubu |
if you have basic knowledge of HTML you can write that |
14:38 |
|
ashimema |
OK.. if I'm understanding it right.. cypress studio will even let you 'record a browser session' and it'll write most of that stuff for you.. |
14:38 |
|
caroline |
Is this all already in the tests you have to write for testing Koha? |
14:38 |
|
caroline |
Could we just add some lines to the existing tests to make screenshots too? |
14:38 |
|
Joubu |
those lines are coming from t/cypress/integration/ERM/Agreements_spec.ts, that is in Koha, yes |
14:39 |
|
ashimema |
so rather than writing the above.. you click 'start' in the studio.. then you browse around the app as normal up to the point where you need the screenshot. then you hit stop and out pops the automated test code to get you to that point.. |
14:39 |
|
Joubu |
only the ERM module is covered by those cypress tests |
14:39 |
|
ashimema |
tieing it in to actually slotting those screenshots into the manual.. that's another thing |
14:39 |
|
aude_c[m] |
... but we could try? |
14:39 |
|
Joubu |
ashimema: the problem with those tools is the selector, if they are too specific it is a nightmare to maintain |
14:39 |
|
ashimema |
good call about adding them into our existing tests.. I like that |
14:39 |
|
ashimema |
yeah.. i've not tried it yet |
14:40 |
|
caroline |
I tried something similar selenium? but it was *that* intuitive |
14:40 |
|
Joubu |
caroline: the idea to to provide you something easy to use/write |
14:40 |
|
caroline |
the second something changes in the page it breaks |
14:40 |
|
Joubu |
is to* |
14:40 |
|
Joubu |
selenium sucks |
14:40 |
|
caroline |
ok lol! |
14:41 |
|
Joubu |
ashimema and I will have a look, but what davidnz started is the way to go |
14:41 |
|
caroline |
can we set up a video meeting with you and david and aude and whoever else wants to try and you can set us up? |
14:41 |
|
caroline |
it's not linked to ktd is it? |
14:42 |
|
Joubu |
yes, but I will need to have a look first |
14:42 |
|
Joubu |
everything is in ktd for that |
14:42 |
|
Joubu |
(almost) |
14:42 |
|
Joubu |
the problem is the sample data, the condition to generate the screenshot, etc. |
14:42 |
|
caroline |
so we can't do it from a local installation |
14:43 |
|
Joubu |
we don't want you to automate that, it should be done an other way |
14:43 |
|
Joubu |
ktd has everything in it, you can setup a local install to make it ready for cypress |
14:44 |
|
ashimema |
I'm happy to join whatever meeting or help wherever I can |
14:44 |
|
ashimema |
though 23.05 is rapidly approaching and I know Joubu and I are busting a gut already trying to get a bunch of stuff into it still.. so time is.. erm.. always a challenge |
14:44 |
|
Joubu |
caroline: I really don't want to force you (the doc team), if you prefer to continue to do that manually I am fine with that |
14:45 |
|
Joubu |
It means more time for other things :) |
14:45 |
|
Joubu |
But I am happy to help if you want to have a try |
14:45 |
|
caroline |
We can meet in the summer maybe? |
14:45 |
|
Joubu |
it's better for the project IMO |
14:45 |
|
caroline |
after 23.05 comes out |
14:45 |
|
ashimema |
I'm game for that |
14:46 |
|
ashimema |
there tends to be a summer lul in activity |
14:46 |
|
aude_c[m] |
end of June? (she says selfishly because she's on holiday until 22 June) |
14:46 |
|
Joubu |
yes |
14:47 |
|
caroline |
week of june 26? I'll have to double check because june 24 and july 1st are holidays and since they fall on a weekend they will be reported sometime that week |
14:48 |
|
aude_c[m] |
works for me. We'll need to find a time David can make |
14:48 |
|
caroline |
does someone want to organize this? |
14:48 |
|
aude_c[m] |
yes, I can |
14:48 |
|
caroline |
cool thanks! |
14:49 |
|
caroline |
I'll double check the holiday dates and email you |
14:49 |
|
aude_c[m] |
So Joubu, Martin, Caroline, David, me, probably Lucy, cait? |
14:49 |
|
aude_c[m] |
Thanks. I'll try and get in touch with David |
14:49 |
|
* ashimema |
has no idea when his hols are yet.. it's been a nuts year |
14:49 |
|
caroline |
will any of you be at kohacon? |
14:49 |
|
aude_c[m] |
Your girls at school until mid-July? |
14:50 |
|
aude_c[m] |
Don't know... Will you? |
14:50 |
|
caroline |
probably... they haven't opened the registration yet afaik, but as soon as they do, i'll start harassing my boss ;) |
14:51 |
|
aude_c[m] |
Haha! I thought I'd heard the call for papers was open |
14:51 |
|
Joubu |
I will try to be there, yes |
14:51 |
|
ashimema |
21 July my girls are off.. |
14:52 |
|
caroline |
ashimema, I think last time you wanted to talk about video calls? |
14:52 |
|
aude_c[m] |
oh, the call for papers closes this week |
14:52 |
|
ashimema |
Well.. not me per say.. |
14:52 |
|
aude_c[m] |
I thought it was on the agenda by popular request :D |
14:52 |
|
ashimema |
I wondered if a different medium would help you guys.. |
14:53 |
|
caroline |
ok I had an action point to add it to the agenda, but I couln't remember who wanted to talk about it |
14:53 |
|
ashimema |
I'm sure we could donate some zoom time.. or there are other tools available |
14:53 |
|
ashimema |
mostly it was a .. would it help to have video calls instead of text meetings? |
14:53 |
|
ashimema |
if you do though.. it would be good to get them minuted by someone who attends 😜 |
14:54 |
|
ashimema |
though I don't know who reads the existing minutes.. we don't often add actions much |
14:54 |
|
caroline |
I sometimes go back to the logs |
14:55 |
|
aude_c[m] |
I mostly use the tagged logs |
14:55 |
|
ashimema |
hell.. there's even jitsi build in to element here |
14:55 |
|
aude_c[m] |
Having someone taking notes shouldn't be too onerous |
14:55 |
|
aude_c[m] |
Oh, that's nice. |
14:57 |
|
caroline |
ok so idea stage at this point |
14:57 |
|
caroline |
#idea use video calls rather that IRC for meetings |
14:57 |
|
aude_c[m] |
We could just do it at the next meeting? |
14:58 |
|
aude_c[m] |
I wonder how it works for people who use the old-fashioned way of getting to the Koha channel |
14:58 |
|
ashimema |
might push them to jump to matrix 😜 |
14:58 |
|
ashimema |
we can certainly give it a go |
14:59 |
|
aude_c[m] |
yes. But otherwise just sharing a Jitsi link via the meeting page on the Wiki should be straightforward |
15:00 |
|
|
bag joined #koha |
15:00 |
|
caroline |
have you used jitsi video before? |
15:00 |
|
aude_c[m] |
yes |
15:00 |
|
aude_c[m] |
On desktop it just works within the browser |
15:01 |
|
caroline |
can you create the link? |
15:01 |
|
aude_c[m] |
Anyone can do it; but if you prefer I do then yes, no problem |
15:01 |
|
caroline |
I've never used it that's why I was asking |
15:01 |
|
caroline |
I use jitsi phone but we use another service for video |
15:03 |
|
caroline |
#info next meeting will be a video call on kitsi |
15:03 |
|
caroline |
#info *jitsi |
15:03 |
|
aude_c[m] |
No problem :) |
15:03 |
|
caroline |
#topic Next meeting |
15:04 |
|
caroline |
should have done that before lol |
15:04 |
|
aude_c[m] |
hehe |
15:04 |
|
caroline |
4 weeks from now is may 11 |
15:05 |
|
caroline |
I've had complaints about the day, apparently some can't make it on thursdays, do we want to try tuesday? |
15:06 |
|
krimsonkharne[m] |
aude_c: can I join you guys for the meeting on using cypress for screenshots? Just to listen in :) I helped with screenshots in Marseille and would be up to try it out |
15:07 |
|
aude_c[m] |
caroline: ok |
15:07 |
|
aude_c[m] |
krimsonkharne: Sure! :) |
15:09 |
|
caroline |
#info Next meeting: 9 May, 2023, 14 UTC |
15:09 |
|
caroline |
#endmeeting |
15:09 |
|
huginn |
Meeting ended Thu Apr 13 15:09:27 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
15:09 |
|
huginn |
Minutes: https://meetings.koha-communit[…]-04-13-14.01.html |
15:09 |
|
huginn |
Minutes (text): https://meetings.koha-communit[…]3-04-13-14.01.txt |
15:09 |
|
huginn |
Log: https://meetings.koha-communit[…]13-14.01.log.html |
15:09 |
|
aude_c[m] |
Thanks, see you next time! |
15:09 |
|
ashimema |
deffo come along krimsonkharne |
15:10 |
|
aude_c[m] |
caroline: I'll add the Jitsi link to the meeting wiki page closer to the time |
15:10 |
|
caroline |
ok thanks! |
15:10 |
|
caroline |
someone has to run a script to create the page anyway, so it wont be there right away |
15:11 |
|
* ashimema |
tests what the jitsi link looks like when you just add one to the channel |
15:11 |
|
aude_c[m] |
ashimema: You're not even in the meeting! |
15:13 |
|
ashimema |
seems we don't get a nice link via the element thing.. so well have to think a little |
15:14 |
|
ashimema |
but all good.. I'm sure we can make it work |
15:16 |
|
krimsonkharne[m] |
cool, thanks! |
15:16 |
|
krimsonkharne[m] |
I'm off for today, bye all |
15:17 |
|
aude_c[m] |
bye! |
15:21 |
|
reiveune |
bye |
15:21 |
|
|
reiveune left #koha |
15:30 |
|
oleonard |
Can we remove the "built in" offline circulation system now? I can't find a browser it works with |
15:40 |
|
|
marie-luce joined #koha |
15:40 |
|
|
lukeg joined #koha |
15:40 |
|
lukeg |
hi |
15:43 |
|
cait |
sorry for mostly missing the meeting - another crazy day |
15:45 |
|
caroline |
does anyone know if CheckPrevCheckout checks the record or the item? bug says it checks the record, but I just tried it on a record with two items and the second item did not trigger the warning |
15:45 |
|
caroline |
bug 20644 |
15:45 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=20644 enhancement, P5 - low, ---, koha-bugs, NEW , Per itemtype setting for CheckPrevCheckout |
15:45 |
|
caroline |
did the behaviour change since 2018? |
15:47 |
|
caroline |
I have an intern working on 20644 and he was a bit confused (so am i tbh, I thought it checked the record since my clients complained about this) |
15:59 |
|
cait |
caroline: is the record a serial? |
15:59 |
|
cait |
or has a subscription? |
15:59 |
|
cait |
I seem to remember there was some time of exception |
15:59 |
|
caroline |
ah yes, that must be it |
16:04 |
|
caroline |
will add a note in the manual... it's a very hidden functionality |
16:06 |
|
caroline |
Do we still want a choice by itemtype then? |
16:06 |
|
caroline |
bug 20644 |
16:06 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=20644 enhancement, P5 - low, ---, koha-bugs, NEW , Per itemtype setting for CheckPrevCheckout |
16:51 |
|
|
cait left #koha |
16:57 |
|
caroline |
Is there a way to translate database updates? For example, in 221200010.pl there is an insert of help text. This is just one example but account types, letters, etc are other examples where they are inserted in english |
17:25 |
|
|
void09 joined #koha |
17:44 |
|
|
JonTech joined #koha |
17:45 |
|
|
void09 joined #koha |
17:47 |
|
JonTech |
Hello, I am hoping to find some online guides or resources on an upgrade path for Koha. We are on a very old version 3.16 to the latest version. Is this even possible? OS is Ubuntu 14. |
17:50 |
|
|
void09 joined #koha |
17:57 |
|
davidnz |
JonTech: it should be possible |
17:59 |
|
davidnz |
I would recommend using a backup of your database on another machine with a fresh install on a supported OS version |
18:00 |
|
davidnz |
Package install instructions: https://wiki.koha-community.or[…]ki/Koha_on_Debian |
18:01 |
|
davidnz |
Note: I haven't done an upgrade like this, but reasonably often there are queries on the mailing list or IRC about this, with even older versions |
18:01 |
|
JonTech |
Would I install version 3.16 on the updated OS? or the newest Koha version? I made a copy of the sql database, copied it over to the new machine. But when I went to update the database schema I got errors |
18:05 |
|
JonTech |
I figured the backup of the sql database was just too old to convert to the new schema |
18:05 |
|
davidnz |
Install the latest version (or the version you want to use) on the new machine with the updated/supported OS |
18:06 |
|
davidnz |
From memory, the installer should work through the database updates to bring up to date |
18:07 |
|
davidnz |
But, I think someone with way more knowledge than I should comment on that, as I don't really understand how it works/should work... |
18:08 |
|
davidnz |
If you are getting errors, then posting them on IRC (use paste.koha-community.org) or the mailing list may get you a more informed response 🙂 |
18:10 |
|
JonTech |
Thanks for your help, I will look into that |
18:13 |
|
davidnz |
Good luck! |
18:16 |
|
davidnz |
JonTech: The other approach that can be used, is to export your data and import it into a fresh install - basically treating it like a migration, but that can involve some more work like setting up your libraries, patron types, circulation rules, authorized values, etc. |
18:29 |
|
|
JonTech joined #koha |
18:54 |
|
JonTech |
Thanks David, I think the route im going to take is make a copy of both the old and new databases, then use a SQL management tool to move data from the old to new without changing the field structure of the new databased, then restore it back to the server |
19:22 |
|
|
cait joined #koha |
20:15 |
|
|
aleisha joined #koha |
20:27 |
|
|
JonTech joined #koha |