IRC log for #koha, 2023-01-30

All times shown according to UTC.

Time S Nick Message
00:05 khall joined #koha
01:58 khall joined #koha
05:41 paxed Base class package "Auth::GoogleAuth" is empty
05:41 paxed ... is this now a requirement or something?
07:20 magnuse \o/
07:32 thibaud_g joined #koha
07:37 reiveune joined #koha
07:38 reiveune hello
07:57 cait joined #koha
07:57 alex_ joined #koha
07:57 alex_ Bonjour
07:57 cait good morning #koha
08:06 liliputech morning :)
08:07 cait1 joined #koha
08:11 matts joined #koha
08:13 lilipute1h joined #koha
08:19 ashimema mornin'
08:36 liliputech joined #koha
08:50 dpk__ joined #koha
11:22 oleonard joined #koha
11:24 oleonard o/
11:49 mtj hi tcohen, i spotted yr openapi email
11:50 mtj i dont know of any recent package changes
11:55 mtj do we have any gitlab or jenkins build with the errors?
11:57 ashimema it's bug 32713 we're talking about mtj
11:57 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=32713 enhancement, P5 - low, ---, koha-bugs, NEW , x-koha-embed appears to no longer properly validate
11:57 ashimema we'll be writing some tests to cover it.. but both tcohen and I are confident we tested it all a while back and confirmed things were working
11:59 mtj hiya, hmm, we need some tests to trigger the bug, hey
12:01 mtj i cant think of any package from the repo, that has been updated recently
12:02 ashimema interesting
12:02 ashimema[…]napi/commits/main
12:03 ashimema the fix was put into OpenAPI on 25th March last year.. released in version 5.05..
12:03 ashimema which is mentioned in our cpanfile
12:08 ashimema ho
12:08 ashimema there is a test
12:08 ashimema query.t should catch it.
12:11 mtj libmojolicious-plugin-openapi-perl         5.99+really5.05-koha1
12:12 mtj ashimema: we do seem to have 5.05 in our koha repo
12:16 mtj t/db_dependent/api/v1/query.t
12:20 tcohen hola #koha
12:22 tcohen him tj
12:24 alex_ joined #koha
12:49 ashimema so confused by the test passing still
12:50 ashimema are Joubu and I going mad
12:51 mtj hmm, we need a test that fails
12:51 mtj what are the koha/os versions of the failing systems?
12:52 ashimema this was in a ktd running with all defaults where I was testing
12:52 ashimema I'll do a little more digging
12:55 mtj ashimema: master/d11 ?
12:55 ashimema Believe so
12:56 ashimema We tried adding a valid method from an object into the x-kohq-embed header but leaving it out if the spec. It called the method regardless
12:57 ashimema Which in this case resulted in a 500.. but it should have got a 400 first and never called the underlying method
13:08 mtj hmm, tests pass with a 400 :/
13:09 pastebot "mtj" at pasted "prove -v t/db_dependent/api/v1/query.t" (36 lines) at
13:09 mtj ok 4 - GET //DkSC1ie9xkPM_II4kzI4bqxzu9eZ7SLuC2nNsdf:thePa​ssword123@/api/v1/patrons?q={"me.patron_id":92}
13:09 mtj ok 5 - 400 Bad Request
13:27 oleonard Bring your fieldset opinions.
13:28 oleonard The top two versions are variations we see in Koha right now. The third is an idea I have for a standardization.
13:28 oleonard But either of the top two could also be what we make standard.
13:29 ashimema Yay oleonard, the inconsistency there has been bugging me
13:30 ashimema Personally, my vote is for the second option, with the buttons outside the fieldset..
13:31 ashimema My reasoning being that you can have multiple fieldsets that make up a whole form.. so to me, to too closely 'fix' the submission buttons to any particular fieldset fields wrong?
13:33 cait1 second for me too
13:48 khall_ joined #koha
13:58 magnuse i kinda like the third one, but have no objections to the second :-)
14:07 Dyrcona joined #koha
14:08 oleonard What I hope to do is fix the markup so that any of the three styles can be done via CSS
14:09 ashimema 🙂
14:10 magnuse oleonard++
14:48 emlam joined #koha
15:10 cait1 bug 32555 is pretty ugly in stable
15:10 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=32555 major, P5 - low, ---, koha-bugs, NEW , Error when viewing serial in OPAC
15:17 thibaut joined #koha
16:00 bag joined #koha
16:01 ashimema oleonard or joubu around still?
16:01 oleonard present
16:02 ashimema pedro could use a little styling hint on bug 30719
16:02 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30719 enhancement, P5 - low, ---, pedro.amorim, Needs Signoff , ILL should provide the ability to create batch requests
16:02 ashimema trying to add a patron_autocomplete within a Modal
16:02 ashimema but due to our z-indexes and things the autocomplete dropdown ends up behind the modal..
16:02 oleonard :|
16:03 ashimema Pedro was a little concerned that any css level fix he looked at could have far reaching affects.. so wanted to work through it with someone who might know what to look for there 😜
16:03 oleonard Yeah I can take a look ashimema
16:04 ashimema thanks dude, much appreciated
16:28 oleonard ashimema: I'm going through the test plan and looking at details... The "Is a system status" line in the batch status form... How does a system status get added?
16:29 ashimema I believe there's an AV set for those
16:32 PedroAmorim[m] Hi Owen, good question. I'll be honestly and have ignored that in my testing, might very well be something worth revisiting
16:32 PedroAmorim[m] I'll be honest, I've ignored that in my testing* can't type today!
16:33 PedroAmorim[m] the batch statuses could also very well be re implemented into their own AV, instead of having their own menu item in the admin
16:33 cait1 which status are we looking at?
16:33 PedroAmorim[m] new statuses for ILL batches
16:34 oleonard cait1: Talking about Bug 30719 and ILL batch statuses
16:34 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30719 enhancement, P5 - low, ---, pedro.amorim, Needs Signoff , ILL should provide the ability to create batch requests
16:34 oleonard PedroAmorim[m]: I've only just started testing but it sounds like an AV is the right choice
16:34 cait1 hm we just implemented a complete backend without figuring out what ILL_STATUS is ued for (and without using it)
16:34 cait1 but I have been wondering
16:35 PedroAmorim[m] ILL_STATUS is used for ILL status aliases
16:35 PedroAmorim[m] that name is very bad!
16:35 cait1 we do have custom status
16:35 cait1 i think they get pulled from the graph or so?
16:35 PedroAmorim[m] I don't mean custom status you put in status_graph in your own backend
16:35 cait1 tcohen woudl know
16:35 cait1 can you explain how the alias work?
16:35 reiveune bye
16:35 reiveune left #koha
16:37 PedroAmorim[m] I don't understand status_alias functionality 100% either, but I think it's some custom statuses users can add through the AV, and then they become as options in the "edit request" page, and also show up as options for the "status" filter on the left
16:37 PedroAmorim[m] I don't think changing the alias through the UI changes the actual status of the ILL request
16:38 ashimema I'm not sure anyone fully understands the status_alias stuff
16:40 oleonard I should have packed food and water for this test plan XD
16:41 lukeg joined #koha
16:42 * cait1 sends a picknick basket to oleonard
16:43 cait1 ashimema: and PedroAmorim[m] thx - happy I am not alone, but it's also a bit scary noone knows :)
16:44 PedroAmorim[m] oleonard: hopefully the instructions are clear enough! I'm happy to help! just let me know if something does go accordingly
16:44 PedroAmorim[m] s/does/doesn´t/
17:01 cait1 lukeg: around maybe? Looking for your bug about the 'permission for changing the library' - I know it's there, but I can't seem to find it
17:01 cait1 ... and now I found it. duh.
17:01 cait1 bug 30624
17:01 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30624 enhancement, P5 - low, ---, lucas, Signed Off , Add a permission to control the ability to change the logged in library
17:03 cait1 can i get some native speaker help?
17:03 cait1 I am looking for a name for a new serial status
17:03 cait1 you wil set it when you send the issues off to be bound
17:03 cait1 so they are temporarily not available in the libraryy
17:04 oleonard "Bindery" or "At bindery" ?
17:06 cait1 and when they come back... boudn into a volume...
17:06 cait1 bound?
17:06 cait1 and thx :)
17:08 cait1 oleonard: what woudl you call it if they are out of the library becuase of running throught the routing list
17:09 oleonard "Bound" sounds correct I think. I don't know about the routing list... It's been too long since I worked in a library with routing lists
17:12 cait1 hm dictionary suggests circulating
17:12 cait1 in circulation
17:12 oleonard Sounds ambiguous in Koha context
17:14 cait1 I agree, but lacking better ideas for now -I've filed as bug 32752 - maybe some new ideas will come up in discussion
17:14 khall joined #koha
17:14 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=32752 enhancement, P5 - low, ---, koha-bugs, NEW , Add new serial issue status: "At bindery", "Bound",
17:16 cait1 I also tried to explain what was meant by each suggestion - hope that will help
17:17 lukeg joined #koha
17:22 oleonard ashimema PedroAmorim[m] I think adding a global z-index setting on .ui-autocomplete is appropriate. A z-index of 1060 would put it above the Bootstrap modal's z-index of 1050.
17:23 oleonard By the way I ran into an error when testing... from the "Add new batch" modal, clicking the "Continue" button triggers an error in the console
17:24 PedroAmorim[m] oleonard: I believe that error you encountered is because you didn't create any batch status
17:24 PedroAmorim[m] but even if that is the case, there should be better error handling, yes
17:25 oleonard I've added several batch statuses
17:25 PedroAmorim[m] oleonard: Cool! Should this be its own bug?
17:26 PedroAmorim[m] what is the error on the console? Have you added the pubmedID enrichment plugin?
17:26 PedroAmorim[m] could it be because of ReprintsDesk credentials, I wonder
17:26 PedroAmorim[m] should not be
17:27 cait1 oleonard++ PedroAmorim++ :)
17:27 oleonard I added the plugin and it is enabled.
17:27 oleonard Can't call method "borrowernumber" on an undefined value at /kohadevbox/koha/Koha/REST/V1/ line 144
17:31 PedroAmorim[m] possible to check through network what's being sent to api/illbatches?
17:31 PedroAmorim[m] also a restart_all and a browser hard refresh just go rule these out
17:31 ashimema thanks oleonard
17:31 ashimema oleonard++
17:33 ashimema @karma oleonard
17:33 huginn ashimema: Karma for "oleonard" has been increased 710 times and decreased 0 times for a total karma of 710.
17:33 ashimema karma?
17:33 pastebot "oleonard" at pasted "Add new ILL batch API request" (7 lines) at
17:34 ashimema @karma
17:34 huginn ashimema: Highest karma: "Joubu" (1152), "cait" (971), and "ashimema" (795).  Lowest karma: "-" (-78), "failed" (-52), and "ie" (-40).  You (ashimema) are ranked 3 out of 1226.
17:37 PedroAmorim[m] hmm payload looks good, same as what's on my end
17:37 PedroAmorim[m] I'm going through each of the steps to see what may be the cause of this error
17:37 PedroAmorim[m] but unable to reproduce yet
17:42 PedroAmorim[m] oleonard: can you please try restarting memcache? I've had problems in the past with new api specs before restarting it
17:42 PedroAmorim[m] double-checking everything I'm a bit puzzled why that endpoint would complain about body being undefined
17:43 oleonard I didn't reset_all before I tested, I will see if that makes a difference.
17:43 caroline ashimema, can I bother you with manual questions? I need a git master :)
17:44 caroline I tried branching out and creating the 22.11 and 23.05 manuals... everything works except when you go to[…]n/html/index.html the title is still 23.05
17:45 caroline I looked at .gitlab-ci.yml and source/ and everything seems ok for both branches (master and manual22.11.x), so there's something I'm missing somewhere
17:46 ashimema Hmm
17:46 ashimema I can take a look first thing in the morning.. I just turned off the computer for the evening.
17:47 ashimema It might be a symlink issue
17:47 caroline yeah no problem... it's been like this for two weeks, so it can wait :)
17:47 ashimema The directories need to be in place on the server for the Dev branch with each release
17:48 tcohen hola PedroAmorim[m] and cait1
17:48 tcohen I'm arriving late to the conversation
17:49 tcohen all I can say is the status_alias code looks wrong at soem point
17:49 ashimema Ok, found the problem
17:53 * cait1 stops filing bugs
17:54 cait1 well.. for now
17:54 ashimema caroline could you check my change on the 22.11.x branch worked in half hour or so in e it's built?
17:54 ashimema It was in the gitlab-ci file
17:54 caroline ok will check! thanks so much!
17:54 ashimema We have one per branch and the 22.11 on had a small mistake.. the code was building against the master branch instead of the version one
17:54 cait1 caroline++ thanks! I noticed and than forgot to file/tell and ashimema++ too
17:55 cait1 I have been catching up on tranaslations in 22.05...
17:55 ashimema Thanks everyone
17:55 cait1 hope we can figure out the po update too soon
17:55 cait1 still not complete, but a lot better than what is ont he website - and there are no 22.11 translation files yet, with the branching Bernardo could generate them now I think
17:56 cait1 I'll have to redo all the system preference linsk... why did I help you change all those? :)
17:56 cait1 and with that horror...I leave for today - have a nice evening all! :)
17:56 caroline cait1, branching was done two weeks ago or so. It was just the link that was working funny
17:56 cait1 hm I can send a quick mail to Bernardo if you want asking for the po files?
17:56 caroline thanks ashimema I see the line now, will make a note of what to changer
17:57 caroline cait1, yes please!
17:57 cait1 I'll do it right now and CC you
17:57 cait1 btw - how awesome is it that your dashboard color is ... rose? :)
17:58 cait1 I got an odd green :)
17:58 caroline lol! I hadn't noticed
18:02 cait1 mail sent - bye all!
18:02 cait1 left #koha
18:19 lukeg joined #koha
18:53 Dyrcona joined #koha
19:15 lukeg joined #koha
20:17 lukeg joined #koha
20:44 khall joined #koha
21:07 cait[m] hm git pull takes a while today
21:15 cait[m] ok, I meant ktd pull
21:16 lukeg joined #koha
21:19 Dyrcona joined #koha
22:02 caroline ashimema, I'm late getting back, but your change worked! Everything is perfect now!
22:03 caroline[…]n/html/index.html goes to 22.11
22:03 caroline[…]n/html/index.html goes to 23.05
22:03 caroline[…]n/html/index.html goes to 22.11
22:03 caroline ashimema++
22:03 cait[m] ashimema++ caroline++
22:13 lukeg joined #koha
22:20 cait[m] I love how fast git so is with the recent changes
22:25 ashimema 🙂
22:26 cait[m] and also, fingers crossed, no more permission issues on files so far
22:41 khall joined #koha
22:59 khall joined #koha
23:54 mtj @later tell khall_, congrats
23:54 huginn mtj: (later tell <nick1[,nick2[,...]]> <text>) -- Tells each <nickX> <text> the next time <nickX> is seen. <nickX> can contain wildcard characters, and the first matching nick will be given the note.

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary