Time |
S |
Nick |
Message |
00:30 |
|
tuxayo |
caroline: "How do I identify the security bugs" they aren't in the release notes :o |
00:31 |
|
tuxayo |
I'll email lukeg |
00:42 |
|
tuxayo |
aleisha rangi[m] Hi :) I just sent an email to Wainui about the big issues on the latest security release. Can you ping them? My previous email might have lead them to a very hard backport attempt that might not be necessary. |
00:48 |
|
mtj |
hi tuxayo |
01:03 |
|
mtj |
..ill try to finish off this jenkins secuirty-build thing today |
02:02 |
|
|
lukeg joined #koha |
06:09 |
|
|
thibaud_g joined #koha |
07:01 |
|
|
philor joined #koha |
07:13 |
|
|
marcelr joined #koha |
07:13 |
|
marcelr |
o/ |
07:30 |
|
|
reiveune joined #koha |
07:31 |
|
reiveune |
hello |
07:32 |
|
marcelr |
hi reiveune |
08:02 |
|
|
cait joined #koha |
08:13 |
|
Joubu |
mtj: Did you see bug 32609? What would be best for you? |
08:13 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32609 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Remove compiled files from src |
08:21 |
|
|
alex_ joined #koha |
08:28 |
|
cait |
hello #koha |
08:28 |
|
marcelr |
hi cait |
08:28 |
|
marcelr |
and alex_ |
08:30 |
|
alex_ |
Salut marcelr and cait |
09:06 |
|
|
cait joined #koha |
09:17 |
|
ashimema |
morning |
09:22 |
|
paulderscheid[m] |
Morning #koha |
09:25 |
|
paulderscheid[m] |
Could someone look at bug 32418. It's not very complex and just needs a sign-off. |
09:25 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32418 normal, P5 - low, ---, paul.derscheid, Needs Signoff , CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl |
09:41 |
|
|
marcelr joined #koha |
09:41 |
|
marcelr |
does anyone know if rabbit queues are persisted (on a volume) on restarting ktd containers? |
09:56 |
|
cait |
pass |
09:57 |
|
ashimema |
they might be.. but I don' think our worker is clever enough to process them |
09:58 |
|
marcelr |
they might? |
10:05 |
|
ashimema |
I don't know rabbit well |
10:06 |
|
ashimema |
The queue data is all available in the database anyway though if you need it.. rabbit is simply used as a Comms piece of the puzzle |
10:06 |
|
ashimema |
All the real data is in the database |
10:07 |
|
* ashimema |
now always uses db polling and doesn't even install rabbit |
10:13 |
|
marcelr |
well it isnt about rabbit itself it is about ktd actually; does ktd use a volume to persist the queues on restarting containers |
10:13 |
|
marcelr |
otherwise you loose your queue and you will have dangling entries in the database |
10:14 |
|
marcelr |
the whole setup needs further thought |
10:19 |
|
paulderscheid[m] |
@seen mtj |
10:19 |
|
huginn |
paulderscheid[m]: mtj was last seen in #koha 9 hours, 15 minutes, and 31 seconds ago: <mtj> ..ill try to finish off this jenkins secuirty-build thing today |
11:10 |
|
|
JBoyer joined #koha |
11:33 |
|
|
khall joined #koha |
11:40 |
|
oleonard |
Hi #koha |
11:42 |
|
mtj |
hi paulderscheid[m], whats up? |
11:43 |
|
paulderscheid[m] |
Was just wondering whether the arm stuff was already merged into mainline ktd mtj |
11:44 |
|
mtj |
short version... no :/ |
11:45 |
|
paulderscheid[m] |
Ok |
11:45 |
|
paulderscheid[m] |
:_) |
11:46 |
|
mtj |
i'll try to get something happening soon |
11:47 |
|
paulderscheid[m] |
Thank you for your service! mtj++ |
11:49 |
|
mtj |
we need to decide on a few 'layout' things, to add it... |
11:50 |
|
paulderscheid[m] |
Yeah, I guess it will be a hassle |
11:52 |
|
mtj |
ive probably been overthinking the problem with merging it |
12:06 |
|
|
jabiertxof joined #koha |
12:10 |
|
jabiertxof |
Hi, Im in debian and make a cron to run koha-run-backups and always use 2 days even editing the script and change days base from 2 to 7 in initial variable and dont pass parameter, can the date code be wrong? |
12:10 |
|
|
JBoyer_ joined #koha |
12:22 |
|
paulderscheid[m] |
You know what would be great.. If ktd included lnav so you could watch the whole log directory. Unforunately you have to compile it for aarch64 'cause they don't provide statically linked binaries for the architecture. |
12:24 |
|
paulderscheid[m] |
Just look at this goodness: https://snipboard.io/7JOHdI.jpg |
12:28 |
|
|
khall joined #koha |
12:30 |
|
paulderscheid[m] |
It just occured to me that you can also watch the directory over ssh |
12:31 |
|
|
marcelr joined #koha |
12:31 |
|
marcelr |
o/ |
12:33 |
|
mtj |
paulderscheid[m]: nice, is that tmux, or other? |
12:33 |
|
paulderscheid[m] |
zellij |
12:34 |
|
|
khall_ joined #koha |
12:37 |
|
mtj |
woo, looks great! |
12:39 |
|
paulderscheid[m] |
It's kinda already configured tmux. :D |
12:42 |
|
* ashimema |
has used byobu for years but always meant to get a bit more familiar with tmux proper |
12:42 |
|
ashimema |
zellij looks interesting |
12:42 |
|
ashimema |
as does lnav.. |
12:43 |
|
* ashimema |
is terrible at always using 'tail -f *' |
12:43 |
|
paulderscheid[m] |
Yeah, me too. But it got very annoying. |
12:45 |
|
ashimema |
perhaps you could add a nice alias to ktd.. |
12:46 |
|
paulderscheid[m] |
Is ktd also developed via bugzilla? |
12:46 |
|
ashimema |
we already have ktd --logs |
12:46 |
|
ashimema |
https://gitlab.com/koha-commun[…]ha-testing-docker |
12:46 |
|
ashimema |
add issues in gitlab |
12:46 |
|
paulderscheid[m] |
Cool. |
12:47 |
|
|
khall joined #koha |
12:48 |
|
paulderscheid[m] |
If you're looking for a bit better keybindings than the default for tmux, check this out ashimema: https://github.com/LMSCloudPau[…]n/tmux/.tmux.conf |
12:49 |
|
ashimema |
my problem is my muscle memory |
12:49 |
|
ashimema |
it knows the byobu keybindings |
12:50 |
|
paulderscheid[m] |
Thankfully vim keybindings are becoming the standard in most dev tools. |
12:50 |
|
ashimema |
those are nice looking at them |
12:51 |
|
paulderscheid[m] |
Yeah, for tmux I have L U D R for left, up, down, right so I can remember them ^^ |
12:51 |
|
paulderscheid[m] |
But hjkl is maybe the saner approach. |
12:52 |
|
ashimema |
it's amazing how hard it is to switch one's mind set once you've used a set of keys |
12:52 |
|
ashimema |
for byobu it's function keys to open new 'tab's and splits.. |
12:53 |
|
paulderscheid[m] |
Ah, that'd be a non-starter for me. Function row is too uncomfortable to reach on my keys. |
12:53 |
|
ashimema |
fair enough |
12:53 |
|
|
khall_ joined #koha |
12:54 |
|
magnuse__ |
kia ora khall_ |
12:54 |
|
* khall_ |
waves |
12:54 |
|
magnuse__ |
\o/ |
13:03 |
|
|
alex__ joined #koha |
13:39 |
|
|
Dyrcona joined #koha |
13:40 |
|
oleonard |
Joubu around? |
13:47 |
|
Joubu |
oleonard: yes |
13:47 |
|
Joubu |
bug 32614 |
13:47 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32614 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Highlight important comments |
13:47 |
|
oleonard |
I'm looking at Bug 32609 |
13:47 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32609 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Remove compiled files from src |
13:48 |
|
oleonard |
I'm curious about the removal of cssnano. What problem was it causing? |
13:49 |
|
Joubu |
it was breaking the command, nothing was generated |
13:49 |
|
Joubu |
that's why 'yarn build' didn't generate the compiled css |
13:50 |
|
oleonard |
What's the difference between "yarn css:build" and "yarn css:build:prod" without the minification step? |
13:50 |
|
Joubu |
the maps |
13:51 |
|
oleonard |
I think the minification step is important. Should I look for an alternative tool? |
13:51 |
|
|
khall joined #koha |
13:51 |
|
Joubu |
we can reintroduce cssnano or similar, but that was not the point of the patch |
13:51 |
|
Joubu |
I just needed it to work |
13:51 |
|
Joubu |
yes please |
13:52 |
|
Joubu |
no idea since when it's broken |
13:52 |
|
ashimema |
if you're doing that is it worthwhile looking at updateing from none-sass or whatever |
13:53 |
|
ashimema |
it's been basically deprecated since nov 2018 apparently. |
13:53 |
|
ashimema |
dart-sass is recommended as the alternative.. |
13:54 |
|
ashimema |
I remember that lib giving me all sorts of issues trying to install other node modules |
13:55 |
|
Joubu |
the whole gulp file needs adjustements |
13:55 |
|
ashimema |
indeed |
13:55 |
|
Joubu |
but after we push that first step please :) |
13:55 |
|
ashimema |
agreed |
13:57 |
|
NikolayGospodinov[m] |
Hello. I am writing from Bulgaria. We are currently working on standardizing the templates for creating bibliographic records in MARC 21. I would like to ask someone who works in a library if they can be contacted and share with us their methodology of creating bibliographic records. |
14:00 |
|
oleonard |
Joubu: the cssnano step works fine for me. Not sure what to make of that. |
14:04 |
|
Joubu |
oleonard: in ktd: `yarn build` => git status does not show anything. `yarn css' => There are changes |
14:04 |
|
Joubu |
on master |
14:05 |
|
Joubu |
`git reset --hard HEAD` then now I remove the 3 lines related to cssnano, `yarn build` => there are changes |
14:06 |
|
|
khall_ joined #koha |
14:06 |
|
oleonard |
Both work for me in master |
14:07 |
|
Joubu |
do you have something in node_modules? |
14:07 |
|
Joubu |
mine is empty, and I am using the one from ktd |
14:08 |
|
oleonard |
I do |
14:10 |
|
Joubu |
Did I dream that you told me one of the two options was not working? like last week? |
14:10 |
|
Joubu |
Or somebody else... memory... |
14:10 |
|
oleonard |
Not me! :D |
14:11 |
|
oleonard |
Why the question about having something in node_modules? |
14:11 |
|
Joubu |
did you yarn install recently? |
14:11 |
|
Joubu |
I just run `yarn install` and same, build is not generating anything |
14:12 |
|
Joubu |
oleonard: if you have /kohadevbox/koha/node_modules (generated using yarn install) then you have something that can differ from me (versions of the modules) |
14:12 |
|
Joubu |
if you don't have it, then 'yarn' commands will use /kohadevbox/node_modules, embeded in ktd |
14:13 |
|
oleonard |
I see |
14:13 |
|
Joubu |
if you remove node_modues then yarn build, you should not see something. If you yarn install then build, you should not see something. |
14:13 |
|
Joubu |
*If* my assumption is correct |
14:15 |
|
caroline |
NikolayGospodinov[m], you should try on the Koha mailing list, I think you'd have more chance of having an answer there |
14:15 |
|
oleonard |
Joubu: I removed /kohadevbox/koha/node_modules and removed staff-global.css. I ran "yarn build" and staff-global.css was generated. |
14:16 |
|
oleonard |
Joubu: Please understand I'm not disagreeing with your patch, I'm just confused about the cssnano problem |
14:17 |
|
Joubu |
oleonard: hum indeed... |
14:17 |
|
Joubu |
my assumption is incorrect then |
14:18 |
|
Joubu |
I was also assuming that master was not up-to-date |
14:18 |
|
Joubu |
if I am on master and run yarn build && git status, I don't see changes |
14:18 |
|
|
khall joined #koha |
14:18 |
|
Joubu |
can you confirm that? |
14:18 |
|
oleonard |
Confirmed |
14:18 |
|
Joubu |
ok! |
14:19 |
|
Joubu |
you are correct, I didn't test correctly |
14:19 |
|
oleonard |
Does git do some kind of caching of gitignore? |
14:20 |
|
Joubu |
I don't think so |
14:22 |
|
Joubu |
oleonard: I've updated the remote branch and restore cssnano |
14:26 |
|
oleonard |
Wait... Running 'yarn build' in master shouldn't result in any changes to staff-global.css! |
14:27 |
|
Joubu |
yes, yes! |
14:27 |
|
Joubu |
but I thought it was running behind |
14:28 |
|
Joubu |
Didn't you... tell tcohen then it was missing compiled CSS changes? Like a couple of days ago?... memory... :-/ |
14:28 |
|
Joubu |
than* |
14:28 |
|
Joubu |
that* |
14:30 |
|
ashimema |
22.11.x was.. |
14:30 |
|
ashimema |
It was suggested we build once at release time, instead of updating with every scss change |
14:32 |
|
ashimema |
of course.. at release time I totally forgot that.. so the top two commits on our branch right now are a resync |
14:33 |
|
Joubu |
something else for the pre-push hook |
14:36 |
|
oleonard |
Joubu: I did say that about missing compiled CSS changes, yes. |
14:38 |
|
jabiertxof |
hi sorry for the double question, anyone has in latest koha on debian use koha-run-backups with more than 2 days? it always delete all except 2 days. Thanks in advance |
14:38 |
|
oleonard |
How should I go about installing a new node module now? the "npm install" command says I don't have permission |
14:39 |
|
Joubu |
oleonard: yarn add |
14:40 |
|
Joubu |
but it won't fix the perm issue |
14:40 |
|
Joubu |
if you run yarn install under root, you need to yarn add under root |
14:48 |
|
Joubu |
jabiertxof: just tried and it looks ok for me |
14:52 |
|
jabiertxof |
more than 2 days? |
14:52 |
|
NikolayGospodinov[m] |
Can i ask in wich tag the Author's mark is put |
14:52 |
|
jabiertxof |
Joubu thanks |
14:53 |
|
|
khall_ joined #koha |
14:53 |
|
jabiertxof |
it is into authoritiies also |
14:53 |
|
caroline |
NikolayGospodinov[m], which MARC flavour are you using? In MARC21, it's 100, and I think in UNIMARC it's 200 but i'm not 100% sure |
14:54 |
|
NikolayGospodinov[m] |
Marc21 |
14:54 |
|
jabiertxof |
100 |
14:54 |
|
caroline |
for cataloging check also https://koha-community.org/man[…]oging-cheat-sheet |
14:55 |
|
caroline |
and https://loc.gov/marc/bibliographic/ |
14:56 |
|
Joubu |
jabiertxof: this is how I tested it: https://paste.koha-community.org/192 |
14:57 |
|
Joubu |
I edited /usr/sbin/koha-run-backups and replace the do loop by echo $backupdir/$name-$date |
14:57 |
|
Joubu |
and also commented the koha-dump line |
14:58 |
|
oleonard |
The fact that Bugzilla's dependency graph uses the same color for "pushed to master" and "signed off" ... Surely there are more colors. |
14:58 |
|
Joubu |
jabiertxof: you... quit too fast |
14:58 |
|
NikolayGospodinov[m] |
And where is the author's mark placed if the book has no author? |
14:58 |
|
Joubu |
jabiertxof: https://paste.koha-community.org/193 |
15:00 |
|
|
lukeg joined #koha |
15:01 |
|
Joubu |
oleonard: SO should be yellow and Pushed to master should be green |
15:02 |
|
|
marie-luce joined #koha |
15:03 |
|
Joubu |
oleonard: indeed, I am emailing rangi[m] with the patch |
15:03 |
|
oleonard |
Joubu++ |
15:12 |
|
Joubu |
mtj: Master_D12 is failing because HTTPD::Bench::ApacheBench is not installed - https://jenkins.koha-community[…]Build/consoleFull |
15:16 |
|
|
jabiertxof joined #koha |
15:17 |
|
jabiertxof |
sorry Mmy pc Dies |
15:21 |
|
Joubu |
jabiertxof: I've used this modified script to test https://paste.koha-community.org/193 |
15:29 |
|
jabiertxof |
but this dont remove old files larger than FX 7 dais |
15:29 |
|
Joubu |
lukeg: https://gitlab.com/koha-commun[…]cker/-/issues/337 th |
15:29 |
|
jabiertxof |
Joubu |
15:29 |
|
Joubu |
lukeg: https://gitlab.com/koha-commun[…]cker/-/issues/337 - this should fix authentication_2fa.t for 22.05 |
15:31 |
|
jabiertxof |
the problem is even I do not use --days and touch this file to harcode initial var days to 7 always keep 2 days |
15:31 |
|
Joubu |
jabiertxof: if you think you found a bug can you report it on our bug tracker with as much info as you can please? |
15:31 |
|
jabiertxof |
thanks I go on |
15:37 |
|
|
philor joined #koha |
15:38 |
|
jabiertxof |
Joubo there is one existing https://bugs.koha-community.or[…]_bug.cgi?id=30627 |
15:38 |
|
huginn |
Bug 30627: normal, P5 - low, ---, koha-bugs, NEW , koha-run-backups delete the backup files after finished its job without caring days option |
15:38 |
|
jabiertxof |
how I suscrive to get feedback on advances? |
15:39 |
|
Joubu |
you will automatically get notifications when something happens there |
15:40 |
|
Joubu |
@later tell liliputech Do you know why is Koha_21.11_D11 disabled on jenkins? |
15:40 |
|
huginn |
Joubu: The operation succeeded. |
15:41 |
|
jabiertxof |
i add a comment also so hope new replies came to my inbox |
15:44 |
|
|
lukeg joined #koha |
15:52 |
|
jabiertxof |
Thanks Joubu for the support! |
15:55 |
|
ashimema |
caroline |
15:55 |
|
wahanui |
i think caroline is there supposed to be a documentation meeting now? |
15:55 |
|
ashimema |
if your using the ptfs-e sandboxes.. beware I'm still in the middle of fixing them |
15:55 |
|
ashimema |
some things are broken |
15:56 |
|
caroline |
wahanui, forget caroline |
15:56 |
|
wahanui |
caroline: I forgot caroline |
15:56 |
|
caroline |
made me panic for a moment |
15:56 |
|
* ashimema |
only asks as I saw mlinlinbro had been created |
15:56 |
|
caroline |
ok I think marie-luce is testing some patches |
15:57 |
|
ashimema |
hopefully stuff is working for her |