| Time |
S |
Nick |
Message |
| 07:06 |
|
ashimema |
dcook++ #bugzilla cleansing |
| 07:13 |
|
Joubu |
dcook: "Closing this due to age" - this is not a valid reason imo |
| 07:16 |
|
ashimema |
The config split one I thought might be nice to get done still |
| 07:17 |
|
ashimema |
But I also don't know whose going to commit to doing it any time |
| 07:28 |
|
|
reiveune joined #koha |
| 07:28 |
|
reiveune |
hello |
| 07:45 |
|
Joubu |
ashimema: I didn't see this one, what's the number? |
| 07:48 |
|
ashimema |
[Bug 26790] Refactor Koha configuration (koha-conf.xml) |
| 07:48 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=26790 enhancement, P5 - low, ---, koha-bugs, RESOLVED WISHLIST, Refactor Koha configuration (koha-conf.xml) |
| 07:49 |
|
ashimema |
Most of the other ones I saw him close were duplicates or no longer relevant because other things had moved on and replaced the need |
| 07:50 |
|
ashimema |
But I'd still love to see config split up and XML::Simple killed off once and for all |
| 07:54 |
|
Joubu |
yes, I would not close reports because they are "too old" |
| 07:55 |
|
ashimema |
I don't like the 'WISHLIST' status.. I hadn't realised that was even a thing |
| 07:55 |
|
ashimema |
it encourages closing |
| 07:55 |
|
ashimema |
as you highlight |
| 07:56 |
|
|
lds joined #koha |
| 07:57 |
|
|
alex_ joined #koha |
| 07:57 |
|
alex_ |
Bonjour |
| 08:14 |
|
|
cait joined #koha |
| 08:20 |
|
* cait |
waves |
| 08:25 |
|
ashimema |
Morning cait |
| 08:58 |
|
cait |
morning ashimema :) |
| 09:49 |
|
paulderscheid[m] |
Morning #koha |
| 09:51 |
|
paulderscheid[m] |
Quick question: How would I setup includes within a plugin? |
| 09:58 |
|
cait |
hi paulderscheid[m] - sadly I don't know but I seem to remember people talking about it |
| 09:59 |
|
paulderscheid[m] |
It's apparently not that trivial and I can also get around it but would be very helpful to know. |
| 10:03 |
|
cait |
maybe soem of the more elaborate plugins have itß |
| 10:03 |
|
cait |
? |
| 10:37 |
|
tcohen |
hola #koha o/ |
| 10:44 |
|
paulderscheid[m] |
Good thinking cait. I'll look at some other plugins. |
| 11:18 |
|
|
tcohen joined #koha |
| 11:20 |
|
tcohen |
am I online? |
| 11:20 |
|
tcohen |
@quote random |
| 11:20 |
|
huginn |
tcohen: Quote #253: "<drojf> buy humble bundle, sign off on koha patches instead of playing. leisure time, i'm doing it right." (added by wizzyrea at 10:15 PM, May 28, 2013) |
| 11:22 |
|
paulderscheid[m] |
Load and clear tcohen |
| 11:22 |
|
paulderscheid[m] |
Loud, not Load ^^ |
| 11:23 |
|
tcohen |
thanks paulderscheid[m] |
| 11:24 |
|
tcohen |
irssi is working *funny* |
| 11:25 |
|
paulderscheid[m] |
Always advocating for element. But I understand the comfort of not leaving the terminal. :D |
| 11:29 |
|
tcohen |
will keep it in mind |
| 11:32 |
|
tcohen |
Joubu: around? |
| 11:33 |
|
tcohen |
Koha/BackgroundJob.pm:99 vs Koha/BackgroundJob.pm:114 |
| 11:33 |
|
tcohen |
job_type vs. type |
| 11:38 |
|
Joubu |
tcohen: ? |
| 11:38 |
|
Joubu |
it's 'type' in db |
| 11:39 |
|
Joubu |
what's the context? patches or master? |
| 11:40 |
|
ashimema |
anyone else here use github |
| 11:40 |
|
ashimema |
I can't seem to push to any of my repo's at the moment.. though github claims to be up and running |
| 11:40 |
|
Joubu |
protected branches? |
| 11:40 |
|
ashimema |
nope |
| 11:40 |
|
ashimema |
branch new branch |
| 11:41 |
|
ashimema |
though existing branches are also affect |
| 11:41 |
|
ashimema |
any kind of push fails without any useful errors. |
| 11:41 |
|
ashimema |
error: failed to push some refs to is all i'm getting.. even with verbose |
| 11:43 |
|
Joubu |
just pushed that - https://github.com/joubu/koha-misc4dev/tree/test |
| 11:43 |
|
Joubu |
works for me |
| 11:44 |
|
ashimema |
damn, ok |
| 11:44 |
|
ashimema |
so it's local to me |
| 11:46 |
|
Joubu |
did you git pull? |
| 11:46 |
|
ashimema |
I've pulled, I've rebased, I've fetched |
| 11:46 |
|
ashimema |
nothing helps |
| 11:46 |
|
Joubu |
silly question but sometimes we miss the obvious :) |
| 11:46 |
|
ashimema |
indeed |
| 11:46 |
|
ashimema |
it's really odd |
| 11:47 |
|
ashimema |
feels permissions related but I'd expect a different error |
| 12:20 |
|
oleonard |
o/ |
| 12:20 |
|
paulderscheid[m] |
khall khall_ around? |
| 12:21 |
|
|
marcelr joined #koha |
| 12:21 |
|
marcelr |
o/ |
| 12:29 |
|
|
alex_ joined #koha |
| 12:31 |
|
paulderscheid[m] |
Nevermind khall. I finally understood the docs of Koha::Plugins::Base ^^ |
| 12:52 |
|
|
magnuse joined #koha |
| 12:56 |
|
magnuse |
oleonard: we got an email from github's "Dependabot" about a vulnerability in something called "minimatch", which was added to package.json in bug 23025. am i right in thinking that is something that is used more to "build" a koha release, and not something that is exposed in a regular koha install? |
| 12:56 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=23025 major, P5 - low, ---, oleonard, CLOSED FIXED, security vulnerability detected in fstream < 1.0.12 defined in yarn.lock |
| 12:57 |
|
oleonard |
Yes, it's a dependency of one of the gulp tasks which are used to build CSS or translations |
| 12:58 |
|
magnuse |
oleonard: awesome, thanks! |
| 13:36 |
|
ashimema |
have we thought about moving from node-sass to sass (formerly known as dart-sass) oleonard? |
| 13:52 |
|
|
caroline joined #koha |
| 14:01 |
|
oleonard |
ashimema: I don't know about that |
| 14:03 |
|
ashimema |
okies |
| 14:03 |
|
ashimema |
man I'm having some serious git woes today.. |
| 14:03 |
|
ashimema |
can't get my darn repo to push to anything now |
| 14:03 |
|
tcohen |
long live to CVS |
| 14:03 |
|
ashimema |
I've been fighting with it all day |
| 14:16 |
|
|
Dyrcona joined #koha |
| 14:22 |
|
|
thibaud_g joined #koha |
| 14:30 |
|
|
magnuse_ joined #koha |
| 14:37 |
|
tcohen |
next meeting? |
| 14:37 |
|
wahanui |
hmmm... next meeting is https://wiki.koha-community.or[…]Next_IRC_meetings |
| 14:40 |
|
cait |
hm we shoudl have general irc today |
| 14:40 |
|
ashimema |
yup |
| 14:41 |
|
cait |
like 40 minutes ago |
| 14:41 |
|
cait |
tuxayo: ? |
| 14:41 |
|
ashimema |
the meeting csripts is stuffed and I have no easy way to fix it.. |
| 14:41 |
|
cait |
what's the isuse, the new wiki version? |
| 14:41 |
|
ashimema |
we depend on a cli google cal integration which won't work with googles newer auth requirements |
| 14:41 |
|
cait |
i think adding the calendar entry manually would beok... but it shudl really do the wiki parts |
| 14:42 |
|
cait |
adding the meeting log links is kinda painful manually |
| 14:42 |
|
cait |
well... ideally calendar should wrk too |
| 14:48 |
|
tcohen |
the wiki says December 7 |
| 14:48 |
|
tcohen |
today is tuesday 6th |
| 14:56 |
|
marcelr |
sharp |
| 14:57 |
|
|
Oak joined #koha |
| 14:58 |
|
tcohen |
cait: does the koha-meetings script fail to add the minutes if the calendar step fails? |
| 15:02 |
|
|
lukeg joined #koha |
| 15:03 |
|
cait |
tcohen: it seemed so last time, yes |
| 15:03 |
|
cait |
tcohen: I think ashimema said that it happened after the calendar part |
| 15:04 |
|
cait |
tcohen: you are right, meeting is tomorrow - phew |
| 15:04 |
|
ashimema |
the calendar stuff explodes badly and screws the rest of the script |
| 15:05 |
|
ashimema |
I've not had time to just rip it out yet |
| 15:06 |
|
tcohen |
I can take a look later today |
| 15:19 |
|
davidnind |
for me it used to run OK until the calendar part as I never figured out how to setup the Google part - it would update the minutes then create the page for the next meeting |
| 15:20 |
|
davidnind |
however, I think for the last few meetings I've tried it hasn't worked updating and creating the Wiki pages |
| 16:21 |
|
|
sahan joined #koha |
| 16:28 |
|
|
sahan joined #koha |
| 16:33 |
|
reiveune |
bye |
| 16:33 |
|
|
reiveune left #koha |
| 16:35 |
|
sahan |
Hello friends, I have a question. I've been searching for a while but can't find any results. how can i make opac accessible over the web in koha that i have set up, how can i do this with a domain |
| 17:01 |
|
|
cait left #koha |
| 19:04 |
|
paulderscheid[m] |
Hi sahan |
| 19:04 |
|
paulderscheid[m] |
What exactly do you mean with your question? |
| 19:08 |
|
paulderscheid[m] |
Ah nevermind, just saw that this was 3 hours ago ^^ |
| 19:10 |
|
davidnind |
tcohen++ |
| 20:09 |
|
|
lukeg joined #koha |
| 20:20 |
|
|
fridolin joined #koha |
| 22:50 |
|
dcook |
@later tell Joubu In the past, I wasn't a fan of closing issues that are "too old", but I do think it's practical. The issues aren't deleted, so they can be re-opened, but if no one is going to work on it and it's not a major/critical bug, I think it helps for overall project maintenance to close them. |
| 22:50 |
|
huginn |
dcook: The operation succeeded. |
| 22:51 |
|
cait[m] |
not sure what you are referring to - but I think there is a lot of real bugs we shoudl fix in the old bugs |
| 22:51 |
|
cait[m] |
and some have come more in reach over time |
| 22:52 |
|
cait[m] |
every release has some of those 4 digit ones and it's great to see those old ones go |
| 22:52 |
|
cait[m] |
I would not be i nfavor of auto-closing without intellectual review |
| 22:55 |
|
dcook |
cait[m] Agreed about not auto-closing |
| 22:55 |
|
dcook |
As you say, some of the really old ones are still valid |
| 22:55 |
|
cait[m] |
ok :) |
| 22:56 |
|
dcook |
I mean more so really old enhancement requests or old bugs that are very minor |
| 22:56 |
|
dcook |
I closed a whole bunch of mine from years ago that I'm never going to work on again |
| 22:57 |
|
cait[m] |
i think people can do that with their own bugs anytime - but for others I'd be careful. We don't want to discourage bug reporting and an idea might be picked up again |
| 22:57 |
|
dcook |
In some cases, I figure if a bug was reported 10 years ago but hasn't been commented on again/duplicated in 10 years, it's not a big problem |
| 22:57 |
|
dcook |
Yeah, I found some pretty cool stuff yesterday from the past |
| 22:58 |
|
dcook |
I liked this one on creating user-defined "pipelines" |
| 22:58 |
|
dcook |
The idea being that you scan an item and it runs through a series of actions |
| 22:58 |
|
dcook |
Rather than clicking around Koha and re-scanning and such a bunch of times |
| 22:58 |
|
cait[m] |
do you have an exampe for the types of actions? |
| 22:59 |
|
dcook |
Christopher Brannon raised it. I'll pull up the report as he had some examples |
| 22:59 |
|
dcook |
bug 11852 |
| 22:59 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=11852 enhancement, P5 - low, ---, koha-bugs, NEW , Allow staff to create pipelines of actions for items |
| 22:59 |
|
dcook |
"the script puts the "Not picked up" message in the patron account, cancels the existing hold for that patron, and checks the item in to trigger the next hold or transfer on that item" |
| 22:59 |
|
dcook |
Although that last one is a bit trickier.. |
| 23:01 |
|
dcook |
For bugs with a status of: "UNCONFIRMED, NEW, REOPENED, ASSIGNED, In Discussion, Patch doesn't apply" I did a sort on "Changed" |
| 23:01 |
|
dcook |
The oldest one was from 2010-09-01. I was really tempted to fix it so that the oldest would be after I started working on Koha.. heh |
| 23:01 |
|
cait[m] |
see? :) |
| 23:01 |
|
dcook |
See what? haha |
| 23:01 |
|
cait[m] |
they have a purpose heh :) |
| 23:02 |
|
dcook |
I mean... that one is arguable haha |
| 23:02 |
|
dcook |
I think I'd mostly want to fix it out of fondness for jcamins |
| 23:02 |
|
cait[m] |
I was temped to start with the bugs assigned to some very old versions |
| 23:02 |
|
cait[m] |
there is one 3.1 and several 3.2 |
| 23:02 |
|
dcook |
Oh that would be interesting |
| 23:02 |
|
dcook |
As I was going through them, I thought it would be interesting to test the validity for all the old ones |
| 23:03 |
|
dcook |
But then there's stuff like bug 9524 |
| 23:03 |
|
huginn |
Bug https://bugs.koha-community.or[…]w_bug.cgi?id=9524 enhancement, P5 - low, ---, gmcharlt, NEW , Let patrons create search groups |
| 23:03 |
|
cait[m] |
there is certainly some areas that could be intersting to test |
| 23:03 |
|
cait[m] |
like we did a lot of work on branchtransfers/transfers |
| 23:03 |
|
cait[m] |
so all old bugs there could be interesting to retest |
| 23:03 |
|
dcook |
Mmm for sure |
| 23:04 |
|
cait[m] |
i could see that people want that for custom search filters... |
| 23:04 |
|
cait[m] |
new 22.11 feature |
| 23:05 |
|
dcook |
The name did make me think of Nick's feature yeah |
| 23:05 |
|
cait[m] |
it would be more flexible and allow you to do that this here wants |
| 23:07 |
|
dcook |
I haven't looked at the feature yet |
| 23:07 |
|
cait[m] |
It's nice :) |
| 23:08 |
|
cait[m] |
also a low bug number actually bug 17170 |
| 23:08 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=17170 new feature, P5 - low, ---, nick, RESOLVED FIXED, Add the ability to create 'saved searches' for use as filters when searching the catalog |
| 23:09 |
|
dcook |
I was thinking about bug numbers the other day |
| 23:10 |
|
dcook |
17170 is only from late 2016. I suppose that's over 6 years ago but it doesn't feel that long ago... hehe |
| 23:10 |
|
cait[m] |
yeah, some of my first bugs were 4 digit still I think |
| 23:10 |
|
cait[m] |
there has also been more activity I guess |
| 23:10 |
|
dcook |
If 4480 was in 2010, it suggest to me that we've had a huge influx of bug reports over the last 5 years or so |
| 23:11 |
|
dcook |
My first one was bug 7618 |
| 23:11 |
|
huginn |
Bug https://bugs.koha-community.or[…]w_bug.cgi?id=7618 minor, P5 - low, ---, dcook, CLOSED FIXED, HTML special characters break result table and incorrectly show SQL in Run This Report |
| 23:12 |
|
dcook |
Yikes... I can't read my comments haha |
| 23:12 |
|
cait[m] |
how did you find it? |
| 23:13 |
|
dcook |
The bug? |
| 23:13 |
|
wahanui |
the bug is that perl code is not activ since its not in PER5LIB |
| 23:13 |
|
dcook |
I looked for my name in the git log hehe |
| 23:13 |
|
cait[m] |
aah |
| 23:13 |
|
cait[m] |
i know what my first patch was |
| 23:13 |
|
cait[m] |
actually quite a big thing - I made sure all the patron addresses had the same fields |
| 23:13 |
|
dcook |
Was that 3464? |
| 23:13 |
|
dcook |
We're old... heh |
| 23:14 |
|
cait[m] |
hey! :) but yes, I guess... |
| 23:14 |
|
dcook |
Or at least we've been doing this a long time |
| 23:15 |
|
cait[m] |
bug 3464 |
| 23:15 |
|
huginn |
Bug https://bugs.koha-community.or[…]w_bug.cgi?id=3464 enhancement, P5 - low, ---, gmcharlt, CLOSED FIXED, borrowers table should contain country information for libraries with international patron populations |
| 23:16 |
|
cait[m] |
this was pre bugzilla migration... so no attached patches. We were still mailing them |
| 23:16 |
|
dcook |
Those were the days, eh |
| 23:17 |
|
cait[m] |
I odn't exactly miss patch-format... |
| 23:17 |
|
dcook |
I think git bz was just starting to take off when I started. Still emailed back then as well a bit. |
| 23:17 |
|
dcook |
git bz was such a game changer |
| 23:17 |
|
cait[m] |
it was |
