IRC log for #koha, 2022-08-26

All times shown according to UTC.

Time S Nick Message
00:22 davidnind[m] joined #koha
02:28 tuxayo @later tell, can't reproduce Koha_Master failure. On Ubuntu 18.04 which fails on that on the CI
02:28 huginn` tuxayo: I've exhausted my database of quotes
02:28 tuxayo @later tell tcohen can't reproduce Koha_Master failure. On Ubuntu 18.04 which fails on that on the CI
02:28 huginn` tuxayo: The operation succeeded.
03:00 rangi[m] joined #koha
06:51 marcelr joined #koha
06:51 marcelr hi #koha
06:57 alex_ joined #koha
06:57 alex_ Bonjour
07:00 dcook allo allo
07:00 dcook marcelr: I was prepared to be lazy and not look at bug 22678 since it's 5pm on a Friday... but now I'm just too curious
07:00 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=22678 enhancement, P5 - low, ---, dcook, ASSIGNED , Set 'Koha::Logger' as the default mojo logger for the REST API
07:01 dcook I'll take a quick peek..
07:01 marcelr great
07:01 dcook That error makes it look like the logger wasn't being loaded in but I'll check..
07:01 dcook Maybe I'm just avoiding going home to clean..
07:01 marcelr $c->helpers ?
07:02 marcelr instead of $c->log in the Mojo code
07:02 marcelr should you do the same for helpers ?
07:03 dcook I don't think so. I think the helper is being set up int he background
07:03 dcook[…]efaultHelpers.txt
07:04 dcook When that DefaultHelpers plugin is loaded automatically, it shoudl set up that $app->log method
07:04 dcook I'm just waiting for my dev env to boot up
07:06 marcelr ok
07:07 dcook bug 31380 is what I'm far more interested in but trying to give back a bit more
07:07 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31380 enhancement, P5 - low, ---, dcook, Signed Off , Build Mojolicious controller for running Koha plugins
07:08 cait joined #koha
07:08 dcook ok env up lessee..
07:10 dcook Ok I'm going to come clean, marcelr
07:10 dcook I actually tried it out initially on 21.11 and not master...
07:10 marcelr there you go
07:11 marcelr current master
07:11 dcook I do love how much Mojolicious breaks between different versions..
07:11 dcook Although maybe it's a Koha issue
07:11 dcook Let's see..
07:11 marcelr yes that could be
07:11 dcook master koha-testing-docker mojolicious... 9.22
07:12 dcook I think I was doing mine with 8.12...
07:12 marcelr all for a reliable foundation
07:12 dcook hehe
07:12 dcook I was using the latest Mojolicious docs so in theory it should've kept working..
07:15 dcook Ok I take out the Koha/REST/ lines and then DEBUG and WARN both go to /var/log/koha/kohadev/plack-error.log
07:15 dcook I suppose because dev env has a trace log level.. and outputs to STDERR which we redirect to plack-error
07:18 dcook Looks like DefaultHelpers didn't have log in the older version..
07:19 marcelr yeah normally they ended up in plack-error.log
07:19 marcelr i have adjusted the log->level in my setup in REST/V1
07:19 marcelr but they should go elsewhere
07:20 marcelr and follow the log level from the log4perl file
07:20 dcook ^
07:24 magnuse_ trying to sign off bug 30262 from dcook. it just adds one line, but i'm getting "sha1 information is lacking or useless". is there some way i can say "never mind, use this patch as it is anyway"?
07:24 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30262 normal, P5 - low, ---, koha-bugs, Needs Signoff , opac/ inconsistent with GetMarcUrls for whitespace
07:25 marcelr magnuse you can feed the diff to linux patch ?
07:25 marcelr patch -p1 ...
07:26 magnuse marcelr: sorry, not sure i understand that...
07:26 marcelr like: patch -p1 --merge --no-backup-if-mismatch -i FILE
07:26 marcelr patch is a linux program
07:26 dcook Ahhh I realize what it is now marcelr..
07:26 marcelr tell dcook
07:27 dcook[…]g/
07:27 dcook magnuse_: Oh boy I think that's quite an old patch now
07:27 marcelr a sub context
07:30 marcelr dcook it works adding a no-op context in Logger
07:30 dcook marcelr: Yeah, Mojolicious doesn't really document anywhere that the logger needs to have the same api as Mojo::Log but in practice I think it does
07:30 dcook marcelr: Probably
07:30 wahanui i guess Probably is too hard.
07:30 marcelr i tested it
07:31 marcelr my patron list returns results now
07:31 dcook It might make sense to use a Koha::Logger::Mojo like (Lari?) suggested which more closely follows the Mojo::Log api
07:31 dcook Test::Mojo makes some suggestions like changing the log level of the logger, and that would break at the moment too
07:31 magnuse dcook: yeah, 5 months, but the context around the one added line has not changed, as far as i can see
07:31 dcook magnuse: I'll look at rebasing :)
07:32 dcook Then I'm offfff
07:32 dcook To go home and vacuum and do the dishes...
07:32 dcook Wild Friday night
07:32 marcelr dcook: i will be playing a bit with it
07:32 marcelr thx dcook
07:32 * dcook is still resting his aching bones or else he'd go to the gym...
07:32 dcook marcelr: Cool :)
07:32 ashimema morning #koha
07:33 dcook hola ashimema
07:33 magnuse kia ora ashimema
07:33 magnuse dcook: that sounds like a crazy friday night!
07:35 dcook :D
07:35 dcook Bizarrely I can't find that branch now..
07:36 dcook Usually I hang on to all my branches until they're pushed
07:36 * dcook has way too many branches
07:36 dcook The commit is in there somewhere though. Huh..
07:38 ashimema sounds like my own methods..
07:38 ashimema I have hundreds of stale branches around here for that reason
07:38 dcook magnuse: All rebased
07:39 magnuse dcook++
07:39 dcook ashimema: You don't want to see my Outlook... haha
07:39 ashimema bet my gmail could give it a run for it's money
07:39 dcook I have so many folders O_O
07:40 dcook ashimema: Also, if you're feeling bored this Friday morning, I'd love if you could look over bug 31380 :D
07:40 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31380 enhancement, P5 - low, ---, dcook, Signed Off , Build Mojolicious controller for running Koha plugins
07:40 dcook Even if it's to say it's garbage haha
07:40 dcook Although I feel pretty good about it...
07:40 ashimema haha.. already have i open
07:41 ashimema looking at the plugin code right now.. then will look at core
07:41 dcook Well, I need to do a few last minute things around the office before I head off, so brb
07:46 dcook I'd better run off now...
07:46 ashimema this is clever code..
07:46 ashimema simple, but clear
07:47 dcook Thanks :)
07:47 dcook The product of a number of previous more gruelling iterations...
07:48 dcook Anyway, I better run. I'll have to stick around later sometime in the next week or two
07:48 dcook o/
07:48 ashimema I should really get back to Mojolicious..
07:48 ashimema I'm so out of touch with it these days..
07:49 ashimema I'd love to see us enforce a cgi deprecation and start coding proper mojo controllers
08:29 paulderscheid[m] morning #koha
08:30 paulderscheid[m] just read about the proper mojo controllers for plugins. very intriguing
09:10 paulderscheid[m] Very nice work on bug 31380
09:10 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31380 enhancement, P5 - low, ---, dcook, Signed Off , Build Mojolicious controller for running Koha plugins
09:10 paulderscheid[m] dcook++
09:45 marcelr ashimema: could you plz put 31468 into the next queue ?
10:05 ashimema bug 31468
10:05 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31468 normal, P5 - low, ---,, Signed Off , Koha::Logger should prefix interface with 'plack'
10:06 ashimema ha, sure
10:34 void09 joined #koha
10:37 void09 joined #koha
11:31 tcohen hola #koha
11:56 thibaud_g joined #koha
12:02 liliputech joined #koha
12:27 khall joined #koha
12:45 khall_ joined #koha
13:39 Dyrcona joined #koha
13:53 lukeg joined #koha
14:05 Oak joined #koha
14:20 liliputech anyone using the script koha-push from the release-tools?
14:21 liliputech having an issue here, the version->codename seems not to be set properly and all the bugs I've pushed to my branch are skipped by the script, none is updated... any clue?
14:22 liliputech (codename seems to be set to master, I want to set it to oldstable, how can i do that?)
14:24 ashimema tcohen ^
14:24 ashimema tuxayo ^
14:24 * ashimema seems to remember it being in a config file in the release tools repo..
14:25 ashimema you copy the config file example and then amend it as approprite
14:25 ashimema but.. it's been a while.. i wrote some of that stuff but then Joubu updated it lots during his cycle..
14:35 liliputech hum... seems there is an option where I'm supposed to set which version is the current master, then the script checks the version of my source to deduce if my version is master or stable or oldstable. either i misconfigured smthg or... heh...
14:37 tcohen you need to set it to the branch, I think
14:38 tcohen master: 22.11
14:38 tcohen remote: origin
14:38 tcohen that's what I have for master
14:40 liliputech hum... thx tcohen I've set the same (exept my remote is called upstream)
14:41 liliputech tcohen: you use this script on a regular basis?
14:42 liliputech tcohen: also the config file u use, what's its name? etc/user.yaml or etc/config.yaml ?
14:45 tcohen I use it all the time
14:45 tcohen on the laptop (macos) I use the docker image
14:45 tcohen and I only touched the user.yaml
14:47 pastebot "tcohen" at pasted "liliputech: my etc/user.yaml file" (23 lines) at
14:49 liliputech tcohen: I have exactly the same conf...
14:50 liliputech (also using the dockerimage, won't work otherwise)
14:52 tcohen maybe lukeg knows how to set it?
14:52 tcohen lukeg: do you?
14:58 liliputech well... have to leave... weekend :) will try to fix on tuesday (free time on monday!) and if not possible will update the bz by hand... :(
14:58 liliputech have a nice one, C U on tuesday!
14:58 tcohen nahw
14:58 tcohen see you!
16:01 khall joined #koha
17:13 cait bye #koha :)
17:14 cait left #koha
17:38 tuxayo @later tell mtj I was waiting for bug 25669 to have ES7 support. So now I can release ^^
17:38 huginn` tuxayo: The operation succeeded.
17:39 khall_ joined #koha
17:41 tuxayo I missed a lot of notifications here lately :o
17:44 tuxayo @later tell cait «do you know how to best get in touch with French translators» We have a mailing list[…]traduction_kohala
17:44 huginn` tuxayo: The operation succeeded.
17:47 tuxayo @later tell liliputech I don't use koha-push, I didn't know there was a version check.
17:47 huginn` tuxayo: The operation succeeded.
17:50 tuxayo tcohen: I'm running Items.t in a loop and yet after 40 runs it doesn't fail on Ubuntu 18.04
17:50 tuxayo flaky-tests--
18:17 cait joined #koha
18:30 tcohen tuxayo: I don't think master supports 18.04, but it is interesting that it doesn't fail
18:30 tcohen I think it is related to the fact Koha_Master runs on a different data set
18:46 tuxayo tcohen: Koha_Master_U18 was passing until 3 builds
18:46 tcohen oh, that's interesting
18:46 tuxayo > I think it is related to the fact Koha_Master runs on a different data set
18:46 tuxayo how to use that on ktd?
18:47 tuxayo Though Items.t fails on many builds, not just Koha_Master
18:48 tuxayo 166 successful local runs, giving up.
18:50 tcohen most builds do LIGHT_RUN
18:51 tuxayo Ok so locally it's the same, it's depends how KTD is started
19:00 tcohen it's a guess
19:00 tcohen that's the difference I see with Koha_Master
19:00 tcohen I always launch KTD with
19:00 tcohen ktd --selenium --es7 --plugin up -d
19:01 tcohen so it is pretty similar
19:01 tcohen the only difference is that flag
19:14 tcohen tuxayo: the error in Items.t is subtle
19:17 tcohen it is probably due to a MySQL/MariaDB change
19:19 tcohen Joubu: around?
19:44 tcohen got it, tuxayo :-D
20:02 tuxayo tcohen++
20:03 tuxayo «ktd --selenium --es7 --plugin up -d»
20:03 tuxayo I don't use that yet, so by default it's a LIGHT_RUN and one must add selenium and es to get the full?
20:03 tcohen well, no heh
20:04 tcohen LIGHT_RUN makes KTD run the jenkins stuff
20:04 tcohen a sec
20:04 tcohen[…]s_config/
20:04 tcohen in the presence of some variables, it will run that
20:04 tcohen that's how we manage the tasks on jenkins
20:05 tcohen through ENV
20:05 tcohen there are several ways to launch KTD
20:05 tcohen for local use
20:05 tcohen ktd is the new wrapper script
20:05 tcohen that lets you (through CLI options) choose what components to load
20:09 tuxayo tcohen: So what does ktd loads by default?
20:09 tuxayo Selenium and ES6?
20:09 tcohen[…]ob/master/bin/ktd
20:09 tcohen only Koha
20:19 tuxayo tcohen: Is it not equivalent to LIGHT_RUN then in terms of expected when running the tests?
20:29 tuxayo mtj around?
20:29 tuxayo I'm backporting bug 25669 but for master it needed manual work from you for Search::Elasticsearch 6.80
20:29 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=25669 normal, P5 - low, ---, kevin.carnes, Pushed to oldstable , ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
20:30 tuxayo So should I wait you before releasing?

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary