Time |
S |
Nick |
Message |
00:25 |
|
|
fridolin joined #koha |
00:46 |
|
|
fridolin left #koha |
01:23 |
|
dcook |
How good is C4::Auth::check_cookie_auth? So grateful to have it in master... |
01:38 |
|
|
thd joined #koha |
01:49 |
|
aleisha |
agreed! |
01:50 |
|
aleisha |
i would love to work away from using language like master. calling it main or something else instead. i believe this was raised in the last couple of years, has there been any movement there? |
02:09 |
|
dcook |
aleisha: I was actually just thinking about that yesterday |
02:09 |
|
dcook |
I'm surprised that we haven't moved away tbh |
02:10 |
|
dcook |
A fair number of other projects I work on have switched to 'main' |
02:10 |
|
dcook |
I wonder.. |
02:10 |
|
aleisha |
me too. i think we should make it a priority! |
02:12 |
|
dcook |
aleisha: I think Joubu runs the Gitea repo that serves https://git.koha-community.org so I suppose he'd be the key person to talk to, and I suppose tcohen as RM |
02:12 |
|
dcook |
I don't know much about branch maintainers. Do you use scripts that reference a master branch? |
02:12 |
|
aleisha |
i havent been rmaint for a while so it's probably changed since, i didnt use any fancy scripts i believe |
02:13 |
|
dcook |
maybe we could make a resolution to start using "main" from 22.11? |
02:16 |
|
dcook |
Actually feeling kind of inspired this morning... |
02:17 |
|
dcook |
After I write a patch for bug 31389, bug 31380 might be able to get off the ground... |
02:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31389 enhancement, P5 - low, ---, dcook, NEW , Calculate user permissions in separate function |
02:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31380 enhancement, P5 - low, ---, dcook, NEW , Build Mojolicious controller for running Koha plugins |
02:46 |
|
wajasu |
on the left sidebar of the opac, i have my authors, collections, etc inthe results. i saw a video where some facets or checkboxes allow one to drill down inthe results. |
02:46 |
|
wajasu |
is that available with zerba? or elasticsearch, or just syspref setting? |
03:31 |
|
tuxayo |
> I don't know much about branch maintainers. Do you use scripts that reference a master branch? |
03:31 |
|
tuxayo |
I don't think so dcook |
03:31 |
|
dcook |
Kewl |
03:31 |
|
tuxayo |
There is in release-tools etc/config.yaml that has a "master" value |
03:31 |
|
tuxayo |
used to know the next release name |
03:32 |
|
tuxayo |
and get the right team from the list team. |
03:32 |
|
tuxayo |
We could forget to change it and would still work |
03:33 |
|
tuxayo |
> I'm surprised that we haven't moved away tbh |
03:33 |
|
tuxayo |
It needs someone to bring the topic in mailing lists and meetings |
03:37 |
|
tuxayo |
Yeah why not changing to something else. |
03:37 |
|
tuxayo |
I haven't read much about the reasons so it seems weird to me to reduce master to it's master-slave sense as there is the "expert" meaning and "The original of a document or of a recording." which fit what we do with git. |
03:37 |
|
tuxayo |
But it doesn't hurt. |
03:39 |
|
tuxayo |
We should just be sure the new term works well in the usual phrases. |
03:39 |
|
tuxayo |
Maybe dev or devel would be less confusing in context than main. |
04:10 |
|
dcook |
"main" seems to be the de facto standard globally I think |
04:10 |
|
dcook |
And I think that systems like Github, Gitlab, etc default to "main" for new HEAD branches these days I think |
04:11 |
|
dcook |
bug And |
04:11 |
|
dcook |
Ack |
04:11 |
|
dcook |
Bug 31380 |
04:11 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31380 enhancement, P5 - low, ---, dcook, Needs Signoff , Build Mojolicious controller for running Koha plugins |
04:11 |
|
dcook |
Pretty excited by this one |
04:21 |
|
dcook |
Oops forgot to update one patch.. |
05:30 |
|
|
cait joined #koha |
06:47 |
|
|
alex_ joined #koha |
06:52 |
|
alex_ |
Bonjour |
06:52 |
|
wahanui |
hola, alex_ |
07:02 |
|
|
cait joined #koha |
07:06 |
|
|
cait1 joined #koha |
07:06 |
|
cait1 |
good morning #koha! |
07:29 |
|
paulderscheid[m] |
morning #koha |
07:29 |
|
paulderscheid[m] |
morning cait1 |
07:34 |
|
cait1 |
morning paulderscheid[m] :) |
07:43 |
|
|
cait joined #koha |
07:46 |
|
|
cait1 joined #koha |
07:51 |
|
|
JBoyer_ joined #koha |
08:09 |
|
Joubu |
dcook: are you using vim? |
08:09 |
|
Joubu |
vmap <F8> :!perltidy -q<CR> |
08:10 |
|
Joubu |
I have this mapping in .vimrc, in visual mode you can select a block and press F8 to perltidy the whole block |
08:18 |
|
|
fridolin joined #koha |
08:48 |
|
|
marcelr joined #koha |
08:48 |
|
marcelr |
hi #koha |
08:51 |
|
marcelr |
@later tell kidclamp could you plz qa 31385 ? |
08:51 |
|
huginn |
marcelr: The operation succeeded. |
09:03 |
|
|
fridolin left #koha |
09:23 |
|
* ashimema |
rolls up sleeves and dives into bug 30718 |
09:23 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30718 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Use flatpickr's altInput option everywhere |
09:23 |
|
ashimema |
@later tell tuxayo, thanks for the vigilant testing of bug 30718.. give's me the confidence to QA now 🙂 |
09:23 |
|
huginn |
ashimema: The operation succeeded. |
09:24 |
|
marcelr |
ashimema: you pick my patch |
09:24 |
|
marcelr |
no problem but i was going to do that one |
09:24 |
|
ashimema |
haha |
09:24 |
|
ashimema |
if you'd like it your welcome to it 😜 |
09:24 |
|
marcelr |
seriously for one time |
09:25 |
|
marcelr |
i have bug 29144 for you |
09:25 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Move branches.opac_info to AdditionalContents allowing multi language |
09:25 |
|
ashimema |
sure.. happy to swap to that if you're happy on datpicker 🙂 |
09:25 |
|
ashimema |
be nice to see both go through |
09:25 |
|
marcelr |
i already started on 30718 before |
09:26 |
|
ashimema |
haha.. me too.. though not for ages.. |
09:26 |
|
ashimema |
it's nice to see it SO'd.. and reading the comments it looks like victor did a pretty good job |
09:26 |
|
ashimema |
I'll leave that one to you then |
09:26 |
|
marcelr |
ok |
09:26 |
|
ashimema |
and focus on 29144 for you 🙂 |
09:26 |
|
ashimema |
teamwork |
09:26 |
|
marcelr |
great |
09:27 |
|
marcelr |
it should still apply with some auto merging.. |
09:29 |
|
|
anne joined #koha |
09:31 |
|
marcelr |
anyone willing to test Joubu's patches on bug 27421; i want to qa it tomorrow |
09:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27421 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Porting tools/stage-marc-import.pl to BackgroundJob |
09:33 |
|
anne |
Hello, I want to change item type to book. I used the batch item modification tool (thanks for the help yesterday). At the end, I got something like this : It will be processed as soon as possible. But nothing happens... Is there anything specific to be run ? |
09:34 |
|
marcelr |
look for background jobs / background worker etc |
09:35 |
|
marcelr |
and check Bugzilla |
09:56 |
|
marcelr |
brb |
10:04 |
|
cait1 |
anne: was there a link to click when you got the message? |
10:04 |
|
cait1 |
you can go here and see the status of your changes maybe: .../cgi-bin/koha/admin/background_jobs.pl |
10:05 |
|
anne |
I remember two links. I had clicked on one of them: 404 error |
10:05 |
|
cait1 |
hm yes, that could be a bug that is soon to be fixed |
10:05 |
|
cait1 |
which version are you on? |
10:05 |
|
cait1 |
you can see it on the 'about Koha' page at the top |
10:06 |
|
anne |
Version 22.05.00.000 |
10:07 |
|
cait1 |
ok |
10:07 |
|
cait1 |
you should try to update to the new 22.05.x version coming out soon (I think next week) |
10:08 |
|
cait1 |
you could also update now to the latest bugfix release of 22.05 which will fix some things, but I think this specific bug might be in the version next week |
10:13 |
|
anne |
Ok cait1 thanks, when I go to .../cgi-bin/koha/admin/background_jobs.pl I got error 404. So, I think I'll wait until the new 22.05.x version is released |
10:34 |
|
|
khall joined #koha |
10:35 |
|
|
cait joined #koha |
10:41 |
|
|
oleonard joined #koha |
11:01 |
|
|
khall_ joined #koha |
11:13 |
|
oleonard |
What's up #koha? |
11:21 |
|
|
khall joined #koha |
11:24 |
|
|
marcelr joined #koha |
11:24 |
|
marcelr |
o/ |
11:24 |
|
oleonard |
Hi marcelr |
11:58 |
|
|
liliputech joined #koha |
11:59 |
|
liliputech |
late hi koha today :p (not working on koha today, rmaint queue is ok) |
12:05 |
|
huginn |
News from kohagit: Bug 28854: (follow-up) Remove errant warning <https://git.koha-community.org[…]2f11d00f35ef90dbd> |
12:05 |
|
tcohen |
hola #koha |
12:05 |
|
huginn |
News from kohagit: Bug 30684: (follow-up) Use log_warning_msg for the "not running" warning <https://git.koha-community.org[…]0265c3e045c039ac0> |
12:06 |
|
huginn |
News from kohagit: Bug 30779: Remove _update_import_record_marc and update tests <https://git.koha-community.org[…]bcc1d842777b67c3b> |
12:06 |
|
huginn |
News from kohagit: Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel images <https://git.koha-community.org[…]df6bbf2ab6623bbcd> |
12:06 |
|
huginn |
News from kohagit: Bug 30684: When a service isn't running koha-* scripts --restart should start it <https://git.koha-community.org[…]e4487004bdd550a04> |
12:06 |
|
huginn |
News from kohagit: Bug 30779: Do not update import marc after importing items <https://git.koha-community.org[…]74b62c8ed77d6afad> |
12:14 |
|
liliputech |
hi cait1 just got your message from huginn, glad translation-team made it through, thanks to those involved :) |
12:20 |
|
cait1 |
:) |
13:01 |
|
marcelr |
ashimema++ # bug 29144 |
13:01 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Passed QA , Move branches.opac_info to AdditionalContents allowing multi language |
13:01 |
|
cait1 |
ashimema++ |
13:02 |
|
ashimema |
took a bit of reading but was clear in the end |
13:02 |
|
ashimema |
I find the whole 'all libraries' and 'best match' stuff a little confusing but couldn't come up with better terms.. |
13:02 |
|
ashimema |
we can certainly refine that in the other bug though.. |
13:03 |
|
ashimema |
I agree with cait though.. 'All libraries' to me is really clearly 'Always display'.. and we have customers using it that way |
13:03 |
|
ashimema |
the difficulty I find is that we have News and Additional contents sharing so much code.. I think I always felt they should be their own code paths as they have enough distinct functionality (like this case) to warrant it in my opinion |
13:04 |
|
marcelr |
yes it is hard to draw the line |
13:05 |
|
ashimema |
indeed |
13:05 |
|
ashimema |
DRY code isn't always the best code.. sometimes slightly modified code is actually clearer and more specifi |
13:06 |
|
ashimema |
anywho.. it's a nice enhancement 🙂 |
13:07 |
|
marcelr |
but lots of copy-paste is so awesome :) |
13:08 |
|
marcelr |
when development is done with sed |
13:08 |
|
ashimema |
haha |
13:08 |
|
ashimema |
fine line |
13:09 |
|
marcelr |
i cced you on 29190 now |
13:28 |
|
tcohen |
we have evolved in good ways lately |
13:29 |
|
tcohen |
now it is really easy to add a table and a class |
13:29 |
|
tcohen |
with just a few specific methods |
13:29 |
|
tcohen |
easy to write tests |
13:30 |
|
|
khall_ joined #koha |
13:30 |
|
tcohen |
we still don't have a scaffolding tool |
13:30 |
|
tcohen |
that'd be awesome |
13:31 |
|
cait1 |
... can a scaffolding tool be explained easily? |
13:32 |
|
tcohen |
some tool you pass some parameters and it generates empty classes and (why not) API entries... |
13:34 |
|
marcelr |
automate writing stupid code :) |
13:34 |
|
marcelr |
is there any scaffolding bug solver too tomas ? |
13:35 |
|
tcohen |
the idea is that you automate broureaucracy and only focus on the important stuff |
13:42 |
|
cait1 |
thx :) |
13:43 |
|
tcohen |
it is quite often that we need to solve minor quirks on QA, related to bad copying and pasting, lack of POD etc |
13:45 |
|
cait1 |
i think the danger of scaffolding is that you still need to make adjustments |
13:45 |
|
cait1 |
so we might still see some oversiths |
13:45 |
|
cait1 |
but maybe it could flag oversights some way |
13:54 |
|
cait1 |
.. like if a placeholder is not replaced with a proper description? (have never used such tools...) |
14:07 |
|
kidclamp |
marcelr - signed off |
14:13 |
|
paulderscheid[m] |
Does anyone know why I'm getting this error?... (full message at https://matrix.org/_matrix/med[…]bFwigznFCuKOYiVU) |
14:14 |
|
paulderscheid[m] |
Well I know what happens, I just don't get why there's no relationship between Biblio and biblio_metadata |
14:14 |
|
marcelr |
thx kidclamp i will go further tomorrow |
14:15 |
|
paulderscheid[m] |
> <@paulderscheid:matrix.org> Does anyone know why I'm getting this error?... (full message at https://matrix.org/_matrix/med[…]AVbbqZnyfYjcbfaA) |
14:21 |
|
liliputech |
paulderscheid[m]: in your call to biblio->Search there is a typo I guess, biblioitems is misspelled as bibliotitems, try to change it :) |
14:22 |
|
paulderscheid[m] |
I just introduced it |
14:22 |
|
paulderscheid[m] |
The problem was there before |
14:23 |
|
paulderscheid[m] |
Actually the error occurs if I try to use the ->next method |
14:23 |
|
paulderscheid[m] |
```while ( my $biblio = $biblios->next ) {``` |
14:24 |
|
paulderscheid[m] |
Any idea liliputech |
14:39 |
|
marcelr |
cu later |
14:43 |
|
cait1 |
sorry paulderscheid[m] - pass |
14:45 |
|
paulderscheid[m] |
@seen tcohen |
14:45 |
|
huginn |
paulderscheid[m]: tcohen was last seen in #koha 1 hour, 2 minutes, and 0 seconds ago: <tcohen> it is quite often that we need to solve minor quirks on QA, related to bad copying and pasting, lack of POD etc |
14:45 |
|
paulderscheid[m] |
No problem cait1 |
15:15 |
|
cait1 |
bye all :) |
15:15 |
|
|
cait1 left #koha |
15:25 |
|
liliputech |
paulderscheid[m]: pass as well... |
16:00 |
|
liliputech |
'evening, see u tomorrow |
16:14 |
|
oleonard |
ashimema around? |
16:18 |
|
|
dpk joined #koha |
16:18 |
|
ashimema |
hi |
16:18 |
|
wahanui |
what's up, ashimema |
16:19 |
|
oleonard |
Hi, I have a question about Bug 31028 |
16:19 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31028 new feature, P5 - low, ---, martin.renvoize, Needs Signoff , Add 'Report a concern' feature for patrons to report concerns about catalog records |
16:19 |
|
oleonard |
The text, "A short summary of what the library policy is for dealing with such concerns and what constitutes a valid concern" is hard-coded in a couple of templates |
16:20 |
|
oleonard |
That seems like it should have a customization method built in |
16:21 |
|
oleonard |
I can add a comment to the bug, but I wondered if I was missing something |
16:23 |
|
ashimema |
bugger.. I forgot to add that feature in |
16:24 |
|
ashimema |
yeah.. it was meant to use the AdditionalContents stuff |
16:24 |
|
ashimema |
but I clearly forgot about it.. haha |
16:24 |
|
ashimema |
thanks |
16:24 |
|
oleonard |
Okay I'll go ahead and leave a comment |
16:24 |
|
ashimema |
thanks |
16:25 |
|
* ashimema |
seems to always be juggling a bit too much these days.. |
16:25 |
|
ashimema |
also need to add unit tests and stuff for QA.. but wanted to get going on refining the feature 😛 |
16:30 |
|
* ashimema |
hopes the follow-up on bug 31373 makes Joubu a bit happier |
16:30 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=31373 normal, P5 - low, ---, martin.renvoize, Signed Off , Notice template validation is missing INCLUDE_PATH |
16:31 |
|
ashimema |
sometimes.. little things end up much bigger 😧 |
16:31 |
|
ashimema |
that was meant to be a tiny bugfix.. |
16:31 |
|
ashimema |
right.. time to now go remind myself how AdditionalContent stuff works.. :! |
16:53 |
|
|
khall joined #koha |
16:59 |
|
|
cait joined #koha |
17:13 |
|
wajasu |
i have Amazonbot GETs in my plack.log. Should I put a robots.txt in the root accordingly. It's been going for a day. |
17:13 |
|
tuxayo |
ashimema: «thanks for the vigilant testing of bug 30718.. give's me the confidence to QA now 🙂» Glad to hear :D |
17:13 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30718 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Use flatpickr's altInput option everywhere |
17:18 |
|
oleonard |
wajasu: I believe a lot of people do |
17:52 |
|
|
khall_ joined #koha |
17:57 |
|
wajasu |
ok. |
18:35 |
|
|
caroline joined #koha |
19:21 |
|
|
khall joined #koha |
19:45 |
|
caroline |
Is there a way to request a transfer from another library without going through holds? |
20:19 |
|
|
fridolin joined #koha |
20:21 |
|
|
fridolin left #koha |
20:27 |
|
cait |
caroline: not sure for request... I think we migh tonly have the 'other direction' |
20:27 |
|
cait |
transfer fom circ start page... |
20:29 |
|
caroline |
It's what I thought... I had a weird request from a client that I don't fully understand, but basically, it was possible in 20.05 to create a transfer to your own library from elsewhere, but it's not possible anymore |
20:29 |
|
* cait |
might have gone down some rabbit hole |
20:29 |
|
cait |
how did you do it? |
20:29 |
|
cait |
I mean in 20.05 |
20:29 |
|
caroline |
You chose your own library in 'destination' and manually wrote in the barcode |
20:30 |
|
cait |
hm, but how would the other library learn about the request? |
20:30 |
|
caroline |
I have no idea... but now we have transfers to send, so they could look at that |
20:31 |
|
cait |
it would updat the item status... but how could you tell it was a request and not something that is already 'travelling' |
20:31 |
|
cait |
not quite |
20:31 |
|
cait |
it's a different status if something is requested to be transferred or in transfer |
20:31 |
|
cait |
i think stock rotation uses that |
20:32 |
|
caroline |
I'm not sure... like I said it's a weird request and their process is not logical with the transfer process |
20:32 |
|
cait |
might be the only feature for now using it - ashimema would know |
20:32 |
|
caroline |
but they used to be able to, and now they're not and they are not happy :( |
20:34 |
|
caroline |
poor marieluce is trying to appease them by finding an alternative way of doing whatever they need to do |
20:34 |
|
cait |
I understand... but I really think they misused the form before |
20:34 |
|
cait |
the form assumes you have the item in your hand and put it in transport (like start sending it) |
20:34 |
|
caroline |
I think so too :) |
20:35 |
|
cait |
but yeah I understand |
20:35 |
|
cait |
sometimes it#s difficult |
20:36 |
|
caroline |
And their message was really weird bc they said that the other library is only opened some days a week and they don't want to wait to put it in transfer... but who sends it? the employee who is there only a couple days a week, right? |
20:36 |
|
cait |
yeah, that si the bit I don't get too |
20:37 |
|
caroline |
I don't fully understand what they're trying to do... |
20:37 |
|
cait |
someone needs to do the physicla sending bit |
20:38 |
|
caroline |
They don't allow holds on available items, so I think it has something to do with that |
20:39 |
|
cait |
hmm |
20:39 |
|
cait |
could you activate the holdoverwrite thing to allow them on staff side? |
20:40 |
|
cait |
or they could just log in as the other library? |
20:40 |
|
caroline |
they already have that, and that will be the workaround marieluce will propose... I just wish I understood the underlying need |
20:40 |
|
cait |
hm yes |
20:41 |
|
caroline |
yeah they don't want to log into the other library bc then they forget and all transactions are done in the other library and it's a mess |
20:42 |
|
cait |
it's a valid concern |
20:53 |
|
|
fridolin joined #koha |
20:53 |
|
|
fridolin left #koha |
21:16 |
|
* cait |
feels like patching koha sometimes is like pulling a string on your knitting |
21:17 |
|
cait |
davidnind++ thx :) |
21:17 |
|
caroline |
I can relate to that XD |
21:21 |
|
cait |
:) |
22:04 |
|
|
alexbuckley joined #koha |