Time |
S |
Nick |
Message |
00:03 |
|
|
cait joined #koha |
00:14 |
|
|
fridolin joined #koha |
00:52 |
|
|
dcook joined #koha |
05:16 |
|
|
cait joined #koha |
05:40 |
|
|
cait joined #koha |
05:51 |
|
|
cait joined #koha |
05:54 |
|
|
cait1 joined #koha |
05:56 |
|
cait1 |
good morning #koha :) |
06:04 |
|
|
reiveune joined #koha |
06:04 |
|
reiveune |
hello |
06:04 |
|
wahanui |
hi, reiveune |
06:05 |
|
|
cait1 joined #koha |
06:13 |
|
ashimema |
Morning #koha |
06:17 |
|
fridolin |
yellow |
06:19 |
|
magnuse |
\o/ |
06:33 |
|
ashimema |
We need to do something about bug 29963 :-( |
06:33 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29963 enhancement, P5 - low, ---, stalkernoid, Needs Signoff , Date picker automatically fills today's date on cataloging screens |
06:34 |
|
ashimema |
Could do with some feedback from the original authors.. I think it's clearly wrong with unintended consequences.. but not sure how best to resolve |
07:01 |
|
|
alex_ joined #koha |
07:01 |
|
alex_ |
Bonjour |
07:02 |
|
|
lds joined #koha |
08:10 |
|
cait1 |
Maybe we should just "roll-back" |
08:11 |
|
cait1 |
and add a visual hint that today's date is used automatically |
08:11 |
|
cait1 |
the pre-fill seems problematic, but Koha always used today's date on saving an item automatically, I think the basic idea was to make this behaviour visible |
08:18 |
|
Joubu |
liliputech: on bug 29828 - the "versions released in" field is incorrect. You forgot the minor part |
08:18 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29828 major, P5 - low, ---, jonathan.druart+koha, Pushed to stable , If no content is added to default, but a translation, news/additional content entries don't show in list |
08:18 |
|
Joubu |
liliputech: you should have a look at the release_tools script, koha-push is adding a "is pushed to" comment AND update this field automatically. |
08:19 |
|
Joubu |
not sure it's used by rmaints, but RMs are using it and it's very convenient |
08:20 |
|
cait1 |
I have an import issue here because in import_bilbios the title is limited to varchar(128) |
08:20 |
|
cait1 |
anyone reckon things will explode if I just make that field bigger for an immediate fix? |
08:20 |
|
cait1 |
manuscripts... I think shortening the title is not really an option here :) |
08:22 |
|
cait1 |
biblio.title is mediumtext |
08:23 |
|
ashimema |
I wrote that script as an rmaint originally 😜 |
08:23 |
|
ashimema |
so I certainly used to use it.. |
08:23 |
|
ashimema |
and I adapted it so it should have worked for both whilst I was RM.. it may well have moved on a bit since then though. |
08:24 |
|
ashimema |
I can't see any issues with that change cait1 |
08:24 |
|
ashimema |
may be worth a submission too |
08:25 |
|
Joubu |
import_biblios columns should match biblio's |
08:26 |
|
cait1 |
i just filed 30916 but need to fix this ipmort now... we'll see how it goes :) |
08:26 |
|
cait1 |
bug 30916 |
08:26 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30916 normal, P5 - low, ---, koha-bugs, NEW , Staged import fails if a title is longer than 128 characters |
08:35 |
|
cait1 |
it looks like I can't make it mediumtext because there is a key on the field |
08:46 |
|
Joubu |
cait1: drop the index, update the column, recreate the index |
08:46 |
|
Joubu |
cait1: see 17.06.00.011 |
08:48 |
|
cait1 |
oh! |
08:50 |
|
cait1 |
not sure if that will work "TEXT columns can only be indexed over a specified length. This means that they cannot be used as the primary key of a table norm until MariaDB 10.4, can a unique index be created on them." |
08:54 |
|
cait1 |
I've updated to varchar(250) which just fits my record for now - it has 238 characters... |
08:54 |
|
cait1 |
until i can find a proper solution |
08:55 |
|
|
liliputech joined #koha |
08:55 |
|
cait1 |
I see it's already fixed in master, closing bug soon |
08:56 |
|
cait1 |
it looks like only import_record_id is now a key |
08:57 |
|
|
davidnind joined #koha |
09:02 |
|
cait1 |
sorry for the noise... |
09:07 |
|
|
m23 joined #koha |
09:31 |
|
|
m23_ joined #koha |
09:50 |
|
|
fridolin left #koha |
09:54 |
|
liliputech |
i'm going to push 4 commits to 21.11.x , will make some noise |
09:57 |
|
cait1 |
that's music not noise :) |
09:57 |
|
liliputech |
:) |
09:57 |
|
liliputech |
hopefully it will sounds like music rather than noise ;) |
10:14 |
|
ashimema |
🙂 |
10:17 |
|
ashimema |
alternative on bug 30462 ready for comments |
10:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30462 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Should the background job list view hide index tasks by default? |
10:18 |
|
oleonard |
Hi |
10:18 |
|
wahanui |
salut, oleonard |
10:19 |
|
alohabot |
🎠🰠Koha '21.11.x' packages pushed to 'koha-staging' repo ðŸ¿ðŸžðŸ¥‘ |
10:21 |
|
|
cait joined #koha |
10:25 |
|
|
khall joined #koha |
10:30 |
|
koha-jenkins |
Project Koha_21.11_D12 build #75: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_21.11_D12/75/ |
10:31 |
|
|
khall_ joined #koha |
10:39 |
|
koha-jenkins |
Project Koha_21.11_D9 build #80: SUCCESS in 44 min: https://jenkins.koha-community[…]Koha_21.11_D9/80/ |
10:42 |
|
koha-jenkins |
Project Koha_21.11_D11 build #114: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]ha_21.11_D11/114/ |
10:56 |
|
koha-jenkins |
Project Koha_21.11_U20 build #88: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.11_U20/88/ |
10:56 |
|
|
Ralecon joined #koha |
10:57 |
|
Ralecon |
hi |
10:59 |
|
Ralecon |
Need a help to update the DNS using the IP address. in our website AWS hosting, there is option to update only IP and there is no option for using PORT number with the IP address |
10:59 |
|
Ralecon |
Is there any option or procedure to do it? |
11:02 |
|
|
Ralecon left #koha |
11:05 |
|
koha-jenkins |
Project Koha_21.11_U22 build #22: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_21.11_U22/22/ |
11:16 |
|
koha-jenkins |
Project Koha_21.11_U18 build #92: SUCCESS in 1 hr 16 min: https://jenkins.koha-community[…]oha_21.11_U18/92/ |
11:20 |
|
koha-jenkins |
Project Koha_21.11_D10 build #102: SUCCESS in 40 min: https://jenkins.koha-community[…]ha_21.11_D10/102/ |
11:23 |
|
|
m23 joined #koha |
11:45 |
|
tcohen |
morning |
11:46 |
|
oleonard |
Hi tcohen |
11:47 |
|
|
marcelr joined #koha |
11:47 |
|
marcelr |
o/ |
11:52 |
|
tcohen |
\o |
11:54 |
|
|
FlorianB joined #koha |
12:04 |
|
marcelr |
kidclamp here |
12:06 |
|
* kidclamp |
waves |
12:07 |
|
marcelr |
hi kidclamp that was my final comment :) |
12:08 |
|
marcelr |
i should be quiet now |
12:08 |
|
|
Dyrcona joined #koha |
12:08 |
|
kidclamp |
title updated, thanks! |
12:20 |
|
tcohen |
hi marcel, how are article requests doing? |
12:22 |
|
Joubu |
somebody around with mysql8? |
12:22 |
|
Joubu |
bug 30912 |
12:22 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30912 critical, P5 - low, ---, koha-bugs, NEW , Database update fails for 21.12.00.016 Bug 30060 |
12:23 |
|
marcelr |
tcohen fine sofar; volume lower than corona |
12:25 |
|
Joubu |
marcelr: did you have a look at bug 30899? |
12:25 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30899 critical, P5 - low, ---, koha-bugs, NEW , Upgrade sometimes fails at "Upgrade to 21.11.05.004" |
12:31 |
|
liliputech |
tests for 21.11 greeens, yay \o/ |
12:31 |
|
|
m23_ joined #koha |
12:36 |
|
|
m23 joined #koha |
12:38 |
|
huginn |
News from kohagit: Bug 13614: Compiled CSS <https://git.koha-community.org[…]96e0dd2de9613e2ab> |
12:38 |
|
huginn |
News from kohagit: Bug 30877: use List::MoreUtils::uniq from recalls_to_pull.pl <https://git.koha-community.org[…]aec7950f955fa7ebe> |
12:38 |
|
huginn |
News from kohagit: Bug 30539: (bug 24161 follow-up) Fix typo in DBrev <https://git.koha-community.org[…]c60a119324e7f4c10> |
12:38 |
|
huginn |
News from kohagit: Bug 13614: Replace usage of YUI on basket groups page <https://git.koha-community.org[…]8c434145a902c5df5> |
12:40 |
|
oleonard |
\o/ |
12:41 |
|
oleonard |
Finally we are rid of YUI's mouldering corpse |
12:44 |
|
marcelr |
Joubu: next thing on my list |
12:52 |
|
oleonard |
If I wanted to test T:T's PRE_CHOMP and POST_CHOMP settings globally, would I do that in C4:Templates.pm ? |
12:54 |
|
oleonard |
I'm guessing I'm wrong, because it doesn't seem to have any effect. |
12:55 |
|
oleonard |
^^ Smart people? |
12:58 |
|
|
m23 joined #koha |
12:59 |
|
cait1 |
not me then :) |
13:01 |
|
FlorianB |
Joubu : Hi, I'm having issues testing your patch for the 20511, mind if I DM you? |
13:02 |
|
Joubu |
of course not! |
13:02 |
|
oleonard |
FlorianB: If you ask here others might be able to help too |
13:03 |
|
Joubu |
oleonard: bug 20657 - looks like you tried already :) |
13:03 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=20657 enhancement, P5 - low, ---, koha-bugs, NEW , Globally enable PRE_CHOMP and POST_CHOMP in Template Toolkit configuration |
13:04 |
|
Joubu |
oleonard: it does not work for me either, hum weird |
13:04 |
|
oleonard |
Indeed, but I never submitted a patch. And now it's not working as I remember it. |
13:13 |
|
oleonard |
And if you think looking at Bug 20511 again after 4 years is a long wait, let me show you the first time: http://irc.koha-community.org/[…]2-09-19#i_1082164 |
13:13 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=20511 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Seasonal prediction just in the staff language |
13:13 |
|
oleonard |
(sorry wrong bug number) |
13:15 |
|
cait1 |
bug 20511 |
13:16 |
|
koha-jenkins |
Project Koha_Master_U20 build #428: SUCCESS in 37 min: https://jenkins.koha-community[…]a_Master_U20/428/ |
13:18 |
|
Joubu |
oleonard: well, it's actually working for me |
13:18 |
|
alohabot |
🎠🦄 Koha 'master' packages pushed to 'koha-staging' repo ðŸ‘ðŸŒðŸ¥ |
13:19 |
|
Joubu |
oleonard: I have: |
13:19 |
|
Joubu |
1 |
13:19 |
|
Joubu |
[% foo %]2 |
13:19 |
|
Joubu |
3 |
13:19 |
|
Joubu |
and I am seeing: |
13:19 |
|
Joubu |
12 |
13:19 |
|
Joubu |
3 |
13:20 |
|
Joubu |
with PRE_CHOMP and POST_CHOMP set to 1 in Template->new |
13:23 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #862: SUCCESS in 45 min: https://jenkins.koha-community[…]ster_D11_My8/862/ |
13:28 |
|
cait1 |
,00, |
13:28 |
|
cait1 |
0,+ |
13:28 |
|
cait1 |
sorry! |
13:28 |
|
|
m23 joined #koha |
13:44 |
|
oleonard |
Joubu: Template->new on line 66 of Templates.pm? |
13:52 |
|
Joubu |
yes, that's the one |
13:52 |
|
oleonard |
I'll try again |
13:53 |
|
|
m23 joined #koha |
13:55 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #947: SUCCESS in 38 min: https://jenkins.koha-community[…]1_MDB_Latest/947/ |
13:55 |
|
|
lukeg joined #koha |
13:57 |
|
|
m23 joined #koha |
14:04 |
|
koha-jenkins |
Project Koha_Master_D9 build #1995: SUCCESS in 1 hr 25 min: https://jenkins.koha-community[…]a_Master_D9/1995/ |
14:05 |
|
liliputech |
hi lukeg, did u have a lot of conflict on bz30742 ? I tried to apply on 21.11 but failed... I'm not very confident on that one. |
14:07 |
|
oleonard |
Bug 30742 |
14:07 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30742 major, P5 - low, ---, nick, Pushed to stable , Confusion when placing hold on record with no items available because of not for loan |
14:09 |
|
Joubu |
checkouts list broken? |
14:09 |
|
Joubu |
Uncaught SyntaxError: unexpected token: identifier |
14:09 |
|
Joubu |
Uncaught ReferenceError: table_settings_issues_table is not defined |
14:09 |
|
oleonard |
Joubu: Do you still have PRE_CHOMP set? :D |
14:10 |
|
koha-jenkins |
Project Koha_Master_U22 build #83: SUCCESS in 47 min: https://jenkins.koha-community[…]ha_Master_U22/83/ |
14:11 |
|
Joubu |
oleonard: that's indeed coming from there, but it's sticky |
14:11 |
|
Joubu |
might be coming from the template cache |
14:11 |
|
Joubu |
and maybe why I first thought it didn't work |
14:12 |
|
oleonard |
Do I have to deal with the template cache separately from restart_all ? |
14:12 |
|
Joubu |
I never had problem with TT's caching system |
14:13 |
|
Joubu |
oleonard: but... yes, if you are playing with TT constructor, I would wipe the cache directory out |
14:14 |
|
Joubu |
<template_cache_dir>/var/cache/koha/kohadev/templates</template_cache_dir> |
14:16 |
|
oleonard |
Ah, thank you Joubu that was my problem |
14:23 |
|
oleonard |
Wow, addbiblio is 1MB smaller with chomping set to 3 |
14:24 |
|
liliputech |
https://static.wikia.nocookie.[…]40&path-prefix=fr :) |
14:27 |
|
oleonard |
I am in ur templates, chomping ur whitespace |
14:28 |
|
FlorianB |
Would anyone feel like taking a look at the bug 3544? https://bugs.koha-community.or[…]w_bug.cgi?id=3544 |
14:28 |
|
FlorianB |
It's been there for a while and despite looking into it, it really puzzles me |
14:28 |
|
huginn |
Bug https://bugs.koha-community.or[…]w_bug.cgi?id=3544 normal, P5 - low, ---, gmcharlt, NEW , Value builder plug-ins don't work with repeatable subfields |
14:28 |
|
huginn |
Bug 3544: normal, P5 - low, ---, gmcharlt, NEW , Value builder plug-ins don't work with repeatable subfields |
14:32 |
|
Joubu |
Is there a price to win for bug # < 10000? |
14:32 |
|
FlorianB |
My admiration and respect? |
14:32 |
|
oleonard |
That is indeed an old one |
14:32 |
|
koha-jenkins |
Project Koha_Master_D12 build #157: SUCCESS in 37 min: https://jenkins.koha-community[…]a_Master_D12/157/ |
14:32 |
|
Joubu |
I think I fixed that for items |
14:38 |
|
FlorianB |
How so? |
14:38 |
|
oleonard |
Joubu: It looks like there isn't a global configuration option that would be akin to setting "FILTER collapse" around everything. Does that sound correct? |
14:39 |
|
Joubu |
FlorianB: I rewrote everything... :D |
14:40 |
|
FlorianB |
Joubu: Ah. Wellll, I got some bad news then :D |
14:40 |
|
Joubu |
oleonard: did you try 2? |
14:40 |
|
Joubu |
oleonard: CHOMP_COLLAPSE |
14:41 |
|
oleonard |
I did. I will double-check. |
14:41 |
|
Joubu |
filter collapse will make the source unreadable anyway |
14:43 |
|
Joubu |
FlorianB: what's your conclusion? |
14:44 |
|
Joubu |
the problem is that the input is cloned, but the id is kept |
14:45 |
|
koha-jenkins |
Yippee, build fixed! |
14:45 |
|
koha-jenkins |
Project Koha_Master build #2050: FIXED in 1 hr 10 min: https://jenkins.koha-community[…]Koha_Master/2050/ |
14:45 |
|
wahanui |
Congratulations! |
14:45 |
|
Joubu |
FlorianB: hum nope, forget that |
14:46 |
|
koha-jenkins |
Yippee, build fixed! |
14:46 |
|
wahanui |
Congratulations! |
14:46 |
|
koha-jenkins |
Project Koha_Master_D10 build #673: FIXED in 1 hr 1 min: https://jenkins.koha-community[…]a_Master_D10/673/ |
14:47 |
|
FlorianB |
Joubu: from what we found on this bug (I worked on it with fridolin), plugin_launcher.pl does not get the right id from the start |
14:48 |
|
Joubu |
FlorianB: there is no event on the cloned buttonDot |
14:49 |
|
Joubu |
you need to clone and pass a flag to have the same event on the cloned node |
14:53 |
|
cait1 |
bye #koha! |
14:53 |
|
|
cait1 left #koha |
14:53 |
|
oleonard |
FILTER collapse will collapse all whitespace in the enclosed area of the template. None of the CHOMP options seems to do so. And I can't even tell what TRIM is supposed to do. |
14:55 |
|
Joubu |
FlorianB: I think the problem is that CloneSubfield is using the cloneNode pure JS function when it should use jQuery's clone (that will clone the events) |
14:55 |
|
Joubu |
Either that, or you add the event listener yourself |
14:56 |
|
|
cait joined #koha |
14:59 |
|
FlorianB |
Joubu: So in your opinion it would be worth a shot to completely rewrite CloneSubfield (and Unclone, I assume) with the jQuery version? |
15:01 |
|
Joubu |
FlorianB: yes, and prevent the buttonDots to have the same id |
15:02 |
|
caroline |
git checdt |
15:02 |
|
caroline |
oops, sorry wrong window :/ |
15:04 |
|
|
cait joined #koha |
15:04 |
|
FlorianB |
Alright, thanks a lot. |
15:05 |
|
|
cait joined #koha |
15:05 |
|
FlorianB |
Well, if anyone wants to work on it in the meantime, feel free :D For now, it's the end of the workday for me, byeeeee |
15:07 |
|
|
cait joined #koha |
15:07 |
|
|
cait joined #koha |
15:08 |
|
Joubu |
oleonard: add that: |
15:08 |
|
Joubu |
+ PRE_CHOMP => 3, |
15:08 |
|
Joubu |
+ POST_CHOMP => 3, |
15:08 |
|
Joubu |
+ TRIM => 1, |
15:08 |
|
Joubu |
and that: |
15:08 |
|
Joubu |
+ $data =~ tr/ //s; |
15:09 |
|
Joubu |
return $data; |
15:09 |
|
Joubu |
at the end of sub output |
15:09 |
|
|
FlorianB left #koha |
15:13 |
|
Joubu |
oleonard: https://paste.debian.net/1243348/ |
15:14 |
|
oleonard |
Thanks Joubu I'll try it |
15:14 |
|
Joubu |
@later tell rangi https cert issue on https://paste.koha-community.org/ |
15:14 |
|
huginn |
Joubu: The operation succeeded. |
15:17 |
|
oleonard |
Joubu: My instinct regarding the repeating field plugins is to create a common event listener and pull parameters from the markup somehow. Then you wouldn't have to worry about attaching new event handlers |
15:27 |
|
|
lukeg joined #koha |
15:29 |
|
Joubu |
oleonard: yes but at this point there is no event on the cloned link. Do you think we should use the jQuery clone function to clone the events, or keep the existing pure JS style and add the onclick event? |
15:29 |
|
oleonard |
I don't know I didn't look at it in enough detail |
15:30 |
|
oleonard |
I'm not philosophically opposed to either option |
15:30 |
|
|
cait joined #koha |
15:31 |
|
|
cait joined #koha |
15:33 |
|
Joubu |
@later tell FlorianB Maybe you only need to add the onclick event, easier that rewrite using jQuery |
15:33 |
|
huginn |
Joubu: The operation succeeded. |
15:33 |
|
Joubu |
bye #koha! |
15:33 |
|
|
Joubu left #koha |
15:33 |
|
|
Joubu joined #koha |
15:48 |
|
|
marie-luce joined #koha |
15:50 |
|
|
lukeg joined #koha |
15:55 |
|
|
cait joined #koha |
16:07 |
|
|
AndrewFH joined #koha |
16:23 |
|
reiveune |
bye |
16:23 |
|
|
reiveune left #koha |
16:43 |
|
|
khall joined #koha |
17:39 |
|
|
davidnind1 joined #koha |
17:56 |
|
|
khall_ joined #koha |
18:27 |
|
|
oleonard joined #koha |
18:37 |
|
|
AndrewFH joined #koha |
18:46 |
|
|
matts_ joined #koha |
18:48 |
|
|
Nemo_bis_ joined #koha |
18:49 |
|
|
eythian_ joined #koha |
18:52 |
|
|
koha-jenkins joined #koha |
18:57 |
|
|
MarkHofstetter joined #koha |
19:28 |
|
|
MarkHofstetter joined #koha |
19:34 |
|
|
fridolin joined #koha |
19:34 |
|
fridolin |
yellow |
19:59 |
|
|
m23 joined #koha |
20:13 |
|
|
m23_ joined #koha |
20:21 |
|
|
m23 joined #koha |
20:46 |
|
|
alexbuckley joined #koha |
21:04 |
|
alexbuckley |
hey cait are you around? |
21:07 |
|
cait |
kind of :) |
21:09 |
|
cait |
alexbuckley: |
21:14 |
|
alexbuckley |
thanks cait ! I would love to hear your thoughts, if you have time, on bug 29963. I have attached a patch which adds a hint for the 952$d subfield to say it will be saved with today's date if left blank. But there is a difference of opinion over whether that is needed. I ask because you failed QA the original patch from 29815 due to inconsistent behaviour it would have introduced, so I wondered if simply adding a hint would do the |
21:14 |
|
alexbuckley |
trick? |
21:14 |
|
wahanui |
trick is to select ISBN from the pull down of search options |
21:14 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29963 major, P5 - low, ---, stalkernoid, Needs Signoff , Date accessioned plugin should not automatically fill today's date on cataloguing screens |
21:14 |
|
alexbuckley |
https://bugs.koha-community.or[…]_bug.cgi?id=29963 |
21:14 |
|
huginn |
Bug 29963: major, P5 - low, ---, stalkernoid, Needs Signoff , Date accessioned plugin should not automatically fill today's date on cataloguing screens |
22:03 |
|
cait |
alexbuckley: oh sorry, got distracted again |
22:03 |
|
cait |
for the hint: I quite like the idea |
22:03 |
|
cait |
it's not intrusive and fixes the 'hidden' behaviour problem |
22:08 |
|
alexbuckley |
not a problem cait ! |
22:08 |
|
alexbuckley |
yeah I agree |
22:10 |
|
cait |
i have commented, hope it makes sense, it's a little late today :) |
22:11 |
|
alexbuckley |
thank you so much cait that is much appreciated! :) |
22:18 |
|
alexbuckley |
also your note makes perfect sense to me - thanks again cait |