| Time |
S |
Nick |
Message |
| 00:00 |
|
tuxayo |
dcook_: hi 😊 |
| 00:31 |
|
|
AndrewFH joined #koha |
| 02:58 |
|
koha-jenkins |
Project Koha_Master_U_Next build #4: SUCCESS in 56 min: https://jenkins.koha-community[…]_Master_U_Next/4/ |
| 03:14 |
|
|
hayleymapley_ joined #koha |
| 03:58 |
|
koha-jenkins |
Yippee, build fixed! |
| 03:58 |
|
wahanui |
Congratulations! |
| 03:58 |
|
koha-jenkins |
Project Koha_Master_D10 build #579: FIXED in 35 min: https://jenkins.koha-community[…]a_Master_D10/579/ |
| 04:26 |
|
koha-jenkins |
Yippee, build fixed! |
| 04:26 |
|
wahanui |
Congratulations! |
| 04:26 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #425: FIXED in 1 hr 3 min: https://jenkins.koha-community[…]ter_U_Stable/425/ |
| 04:32 |
|
koha-jenkins |
Project Koha_Master build #1964: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]Koha_Master/1964/ |
| 05:27 |
|
|
alex2 joined #koha |
| 05:27 |
|
|
alex2 left #koha |
| 06:08 |
|
|
hayleymapley_ joined #koha |
| 06:09 |
|
|
marcelr joined #koha |
| 06:09 |
|
marcelr |
o/ |
| 06:33 |
|
|
alex_ joined #koha |
| 06:34 |
|
alex_ |
Bonjour |
| 06:34 |
|
wahanui |
niihau, alex_ |
| 06:38 |
|
marcelr |
hi alex_ |
| 07:02 |
|
|
cait joined #koha |
| 07:04 |
|
|
reiveune joined #koha |
| 07:04 |
|
reiveune |
hello |
| 07:11 |
|
|
cait1 joined #koha |
| 07:39 |
|
Joubu |
marcelr: Use of uninitialized value in string eq at /kohadevbox/koha/C4/Context.pm line 784. |
| 07:39 |
|
Joubu |
is this new? |
| 07:39 |
|
Joubu |
wondering if it's not coming from the Auth changes |
| 07:43 |
|
marcelr |
784 let me check |
| 07:44 |
|
marcelr |
yes it might be related; see also bug 29954 |
| 07:44 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29954 is not accessible. |
| 07:44 |
|
marcelr |
time for that one ? |
| 07:45 |
|
marcelr |
it could be removed from secu, i guess |
| 07:54 |
|
Joubu |
yep |
| 08:05 |
|
|
sodesvaux joined #koha |
| 08:14 |
|
Joubu |
fridolin: ? |
| 08:14 |
|
Joubu |
around? |
| 08:15 |
|
Joubu |
You are pushing patches that have been marked obsolete |
| 08:16 |
|
Joubu |
bug 29859 comment 17 vs bug 30461 |
| 08:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29859 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Favor iterators over as_list |
| 08:17 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30461 critical, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Batch authority tool is broken |
| 08:17 |
|
Joubu |
this is going to be confusing... |
| 08:17 |
|
Joubu |
I am out, letting you deal with that |
| 08:27 |
|
Joubu |
oleonard: Hi, there is a weird "0" appearing at the top of the cataloguing form when it's submitted, can you have a look please? |
| 08:35 |
|
nlegrand |
Bonjour #koha |
| 08:35 |
|
marcelr |
o/ |
| 08:40 |
|
nlegrand |
o/ |
| 08:53 |
|
oleonard |
Joubu: Can you give more details? |
| 08:54 |
|
|
udkoha joined #koha |
| 08:56 |
|
Joubu |
oleonard: create a new biblio record, click save |
| 08:56 |
|
Joubu |
https://snipboard.io/ENnylx.jpg |
| 08:56 |
|
Joubu |
notice the '0' above "Add MARC record" |
| 08:57 |
|
oleonard |
Oh, when there are errors. Okay. |
| 09:08 |
|
dcook |
Want to stay and help but it's 7pm and time to head home from the office *falls asleep at his desk* |
| 09:10 |
|
|
severine_q joined #koha |
| 09:10 |
|
severine_q |
hi all ! |
| 09:10 |
|
dcook |
salut severine_q |
| 09:10 |
|
dcook |
Long time not see :) |
| 09:11 |
|
dcook |
maybe I should get up earlier before work to do Kohaing.. |
| 09:12 |
|
severine_q |
hello dcook ! |
| 09:12 |
|
severine_q |
indeed... |
| 09:13 |
|
severine_q |
I had planty things to do and forgot a little about Koha-community |
| 09:13 |
|
severine_q |
but luckily Hackfest in Marseille last week make me realize how much I miss you all :D |
| 09:16 |
|
cait1 |
we missed you too, severine_q :) |
| 09:22 |
|
tcohen |
hi all |
| 09:23 |
|
severine_q |
you're so kind cait1 ! |
| 09:23 |
|
severine_q |
hi @tcohen ! |
| 09:24 |
|
tcohen |
hi severine_q ! one more day in your tz :-D |
| 09:26 |
|
dcook |
aww |
| 09:27 |
|
dcook |
One day I'll make it to Marseille.. |
| 09:29 |
|
eythian |
dcook: you should swing by Amsterdam on the way |
| 09:29 |
|
dcook |
eythian: I have a friend whose bf lives in Amsterdam and I keep hearing how it's the best |
| 09:30 |
|
eythian |
there you go, no excuses |
| 09:30 |
|
tcohen |
hi eythian ! |
| 09:32 |
|
eythian |
hello tcohen! |
| 09:33 |
|
cait1 |
severine_q: just the truth, and it's great to have more librarians arond here |
| 09:35 |
|
* oleonard |
waves to dcook's ship passing him in the night |
| 09:35 |
|
* dcook |
waves to oleonard |
| 09:35 |
|
dcook |
Just looking through Bugzilla at all the patches I'd like to work on but don't have the energy for heh |
| 09:35 |
|
dcook |
Figuring out what parts of Koha I need to refactor before I can move on with the new stuff too.. |
| 09:36 |
|
dcook |
Speaking of... oleonard.. I've started using WRAPPER in some of my local customizations |
| 09:36 |
|
dcook |
At some point, I hope to come up with something to add to Bugzilla.. |
| 09:36 |
|
oleonard |
Yeah, I'd love to see a good example of how we can use it in Koha |
| 09:37 |
|
dcook |
Do you know of part of the OPAC which might be less risky to experiment on? Heh |
| 09:37 |
|
dcook |
Right now, I use the wrapper on 3 local pages that don't exist in real Koha.. |
| 09:38 |
|
dcook |
Actually... maybe that Library page.. |
| 09:39 |
|
oleonard |
dcook: Yeah I'd pick the simplest example, that's a good candidate. |
| 09:39 |
|
dcook |
Ok, I'll make a note of that. The wrapper isn't 100% perfect yet, but I think it should be able to take care of that page quite easily.. |
| 09:44 |
|
dcook |
Ohh I could use check_cookie_auth() for some of my devs... good job Jonathan on improving it |
| 09:44 |
|
dcook |
Joubu++ |
| 09:45 |
|
|
alex_ joined #koha |
| 09:46 |
|
dcook |
Okies really going for real |
| 09:46 |
|
dcook |
night all |
| 09:51 |
|
|
khall joined #koha |
| 09:53 |
|
tcohen |
dcook: wait |
| 09:53 |
|
tcohen |
:-D |
| 09:53 |
|
tcohen |
https://bugs.koha-community.or[…]g.cgi?id=30465#c2 |
| 09:53 |
|
huginn |
Bug 30465: enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , BatchUpdateBiblio task does not deal with indexation correctly |
| 09:53 |
|
tcohen |
can you write one sentence explaining your comment |
| 09:54 |
|
tcohen |
so we work for the rest of the day on that :-P |
| 09:59 |
|
|
cait joined #koha |
| 10:15 |
|
|
khall_ joined #koha |
| 10:38 |
|
dcook |
tcohen: Haha. Luckily I just got home and decided to pop back on here |
| 10:38 |
|
tcohen |
hahhaa |
| 10:38 |
|
tcohen |
great |
| 10:39 |
|
dcook |
I thought about it more today and I guess it doesn't matter much |
| 10:39 |
|
tcohen |
Joubu is not online |
| 10:39 |
|
dcook |
I'll add a comment on there (y) |
| 10:39 |
|
tcohen |
but I'm not sure about the real need to make indexing part of the batch task... |
| 10:39 |
|
dcook |
Oh I think it's a good idea esp for ES |
| 10:39 |
|
dcook |
That said, i haven't followed the ES stuff |
| 10:39 |
|
tcohen |
I feel like queueing the index task is.... alright-ish, given that it will be handled by a separate (real-time) worker |
| 10:40 |
|
dcook |
Which reminds me I was going to note down to try ES with Koha.. |
| 10:40 |
|
dcook |
What's the real-time worker for the indexing/ |
| 10:40 |
|
dcook |
?* |
| 10:40 |
|
tcohen |
you need to stop smoking that |
| 10:40 |
|
tcohen |
haha |
| 10:40 |
|
tcohen |
we've been talking about that all week (hackfest) |
| 10:41 |
|
tcohen |
real-time vs. turtle |
| 10:41 |
|
dcook |
Ohhh nvm |
| 10:41 |
|
dcook |
I think I gotcha |
| 10:41 |
|
tcohen |
so |
| 10:41 |
|
tcohen |
the bug is about defering the indexing (i.e. queueing) when someone calls ModBiblio and friends |
| 10:41 |
|
dcook |
yeah that was my understanding |
| 10:42 |
|
dcook |
Which would make sense when using the message queue |
| 10:42 |
|
dcook |
Less so with the zebraqueue I think.. |
| 10:42 |
|
tcohen |
and then Joubu believes the batch task should call indexing at each step |
| 10:42 |
|
tcohen |
to avoid queeing things... |
| 10:42 |
|
dcook |
Hmm I don't follow |
| 10:42 |
|
dcook |
Which step? |
| 10:42 |
|
wahanui |
Which step are you at? |
| 10:43 |
|
tcohen |
on bug 30465 Joubu adds a 'do not queue indexing' flag to modBiblio, so the indexing stuff is handled in the caller (i.e. the background job code) |
| 10:43 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30465 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , BatchUpdateBiblio task does not deal with indexation correctly |
| 10:44 |
|
dcook |
yeah I see the merit of that too |
| 10:44 |
|
dcook |
Update the biblios, and then pass all the IDs through RabbitMQ |
| 10:44 |
|
dcook |
Although only if the worker fetches those biblios in batches from the DB (to reduce DB calls) |
| 10:44 |
|
tcohen |
bug 27783 is the one adding the queues and separate workers |
| 10:44 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=27783 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Introduce background job queues |
| 10:44 |
|
dcook |
Otherwise if it's just going to do 1 DB call per record it's kind of pointless.. |
| 10:44 |
|
* dcook |
buries his head in the sand again and runs away |
| 10:44 |
|
dcook |
hehe |
| 10:45 |
|
tcohen |
well, ->index_records only gets an id, doesn't it? |
| 10:45 |
|
tcohen |
ah |
| 10:45 |
|
dcook |
I haven't looked in deeply enough. i was just thinking conceptually |
| 10:45 |
|
tcohen |
it makes sense, nevermind :-D |
| 10:46 |
|
tcohen |
and we should move the zebra counterpart too |
| 10:46 |
|
tcohen |
and get rid of koha-indexer |
| 10:46 |
|
tcohen |
are you volunteering dcook? |
| 10:46 |
|
dcook |
Not even a little bit haha |
| 10:47 |
|
dcook |
Had a talk with the boss earlier and I think we're going to start trying ES with Koha, since that's where most of the work seems to be these days |
| 10:48 |
|
dcook |
I am feeling inspired tonight though, so thinking of revisiting some of the projects I've shelved for a while |
| 10:48 |
|
tcohen |
enjoy |
| 10:48 |
|
dcook |
Also going to try implementing them locally first so that we can work out the bugs before I try upstreaming them. Going to see how well that works in practice :| |
| 10:48 |
|
dcook |
Well it's 8:48pm and i haven't eaten dinner yet :| |
| 10:48 |
|
dcook |
last morning in marseille, tcohen/ |
| 10:48 |
|
tcohen |
well |
| 10:48 |
|
tcohen |
Madrid :-D |
| 10:48 |
|
dcook |
Wee :D |
| 10:49 |
|
dcook |
Is that where Joubu is these days? |
| 10:49 |
|
tcohen |
I fly tomorrow |
| 10:49 |
|
tcohen |
Naw, he's in france |
| 10:49 |
|
dcook |
It's already tomorrow here :D |
| 10:49 |
|
tcohen |
:-P |
| 10:49 |
|
* tcohen |
is the one that needs sleep it seems |
| 10:49 |
|
dcook |
Or wait.. maybe it's just late today.. |
| 10:49 |
|
dcook |
Mee too |
| 10:50 |
|
dcook |
Going to see if I can quickly put together a patch for oleonard to show off this WRAPPER thing.. |
| 10:50 |
|
* tcohen |
puts the g&t aside |
| 10:50 |
|
dcook |
Mmm g&t.. |
| 10:50 |
|
dcook |
I just have iced tea.. |
| 10:50 |
|
dcook |
A fridge full of beer though.. |
| 10:50 |
|
tcohen |
that's eythian team |
| 10:51 |
|
tcohen |
@later tell fridolin we need to thank batman for saving us on this release |
| 10:51 |
|
huginn |
tcohen: The operation succeeded. |
| 10:52 |
|
tcohen |
mtj: is the exp stuff already in dev? |
| 10:52 |
|
tcohen |
I think we forgot to update ktd |
| 10:53 |
|
dcook |
Must be super late for mtj now :/ |
| 10:53 |
|
dcook |
What's the day got in store for you tcohen/ |
| 10:53 |
|
dcook |
TFW you write git commands into your IRC window.. |
| 10:54 |
|
tcohen |
further complicating holds, then work on a big ILL plugin, then OAuth2 |
| 10:55 |
|
dcook |
No rest for the wicked, eh/ |
| 10:57 |
|
|
AndrewFH joined #koha |
| 10:59 |
|
tcohen |
I'm doing good, heh |
| 10:59 |
|
dcook |
bug 30289 |
| 10:59 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30289 enhancement, P5 - low, ---, oleonard, NEW , Use Template::Toolkit WRAPPER to reduce template boilerplate |
| 11:00 |
|
dcook |
Should have something for this soon... |
| 11:00 |
|
oleonard |
Cool |
| 11:01 |
|
dcook |
In terms of minutes hopefully hehe |
| 11:01 |
|
dcook |
I figured I'd share the wrapper i'm using locally and update opac-library.tt to use it. should be straight-forward enough.. |
| 11:05 |
|
eythian |
tcohen: in fact, I have too much beer in my fridge so if you're offering to help me with this, you're welcome |
| 11:05 |
|
* tcohen |
needs to visit the netherlands.................. |
| 11:06 |
|
dcook |
eythian: I know that feeling... |
| 11:06 |
|
dcook |
I want to buy more but need to drink what's already in there first.. |
| 11:07 |
|
eythian |
yes, even my overflow place for "stuff that can get away without being in the fridge right now" is getting full |
| 11:13 |
|
tcohen |
dcook: you should look at Joubu's bugs introducing Vue3 :-D |
| 11:13 |
|
dcook |
tcohen: I really want to haha |
| 11:13 |
|
dcook |
I don't know how y'all do it.. |
| 11:14 |
|
mtj |
hey peeps, i have having a late nite koha/beer session myself |
| 11:14 |
|
mtj |
tcohen: ill fix the exp package thing now |
| 11:16 |
|
dcook |
mtj: Nice one |
| 11:16 |
|
* dcook |
loves the feeling of pressing enter and getting a template parser error |
| 11:16 |
|
dcook |
It's like.. you know it would be too good to work without at least one |
| 11:18 |
|
dcook |
Hyphen instead of an underscore. Oops.. |
| 11:27 |
|
dcook |
oleonard: All done! |
| 11:27 |
|
dcook |
It's not perfect. I need to improve the <title> and breadcrumbs. You'll probably also have ideas about better Bootstrap classes to use for positioning the columns. |
| 11:28 |
|
dcook |
Hopefully it demonstrates the core idea though |
| 11:29 |
|
dcook |
That's the wrapper I'm using locally for custom pages, so it hasn't really been too battle tested yet |
| 11:29 |
|
oleonard |
Thanks dcook I'll take a look today |
| 11:29 |
|
dcook |
Awesome :) |
| 11:33 |
|
dcook |
Really appreciate it, oleonard :) |
| 11:41 |
|
dcook |
tcohen: That wrapper bug could be useful for plugins as well actually. That was one of the uses I was thinking about back in 2020 for it.. |
| 11:44 |
|
tcohen |
yeah, it looks promising |
| 11:45 |
|
dcook |
All it took was me skipping dinner and working extra late heh. I do want to look at Joubu's Vue3 stuff although tonight I think is food.. |
| 11:45 |
|
dcook |
Well actually.. |
| 11:45 |
|
dcook |
tcohen: You don't have a bug number off the top of your head do you? |
| 11:46 |
|
dcook |
bug 30225 |
| 11:46 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30225 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Rewrite cities admin view in Vue |
| 11:47 |
|
dcook |
bug 30160 |
| 11:47 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30160 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Rewrite cities admin view in React |
| 11:47 |
|
dcook |
Ohh.. |
| 11:51 |
|
Joubu |
dcook: and https://gitlab.com/joubu/Koha/-/commits/erm |
| 11:53 |
|
dcook |
Yeah all right haha |
| 11:53 |
|
dcook |
Usually I'd be dead after muay thai by now but hurt my foot, neck, and shoulder, so here we are.. |
| 11:53 |
|
dcook |
Actually any preference on which one? |
| 11:53 |
|
dcook |
Just about to do 30225 now.. |
| 11:56 |
|
dcook |
Hmm not working. Wonder what I did wrong.. |
| 11:59 |
|
Joubu |
ran `yarn build_js`? |
| 11:59 |
|
dcook |
That would do it |
| 11:59 |
|
dcook |
I just did "yarn install" |
| 12:00 |
|
dcook |
Noticed the JS was missing and figured there must be anothe rstep |
| 12:00 |
|
dcook |
Interesting that Asset.js seems to discard non-existent files.. |
| 12:01 |
|
dcook |
Much better. Cheers. |
| 12:14 |
|
|
khall joined #koha |
| 12:26 |
|
Joubu |
@later tell marcelr bug 30485 |
| 12:26 |
|
huginn |
Joubu: The operation succeeded. |
| 12:43 |
|
|
khall_ joined #koha |
| 12:54 |
|
koha-jenkins |
Project Koha_Master_D12 build #112: SUCCESS in 57 min: https://jenkins.koha-community[…]a_Master_D12/112/ |
| 12:54 |
|
|
Dyrcona joined #koha |
| 13:19 |
|
|
AndrewFH joined #koha |
| 13:30 |
|
tuxayo |
hi #koha :) |
| 13:39 |
|
|
lukeg joined #koha |
| 13:41 |
|
oleonard |
Hi tuxayo |
| 13:41 |
|
tuxayo |
hi :) |
| 13:42 |
|
* oleonard |
just tried to do a recall from the OPAC and got an error... |
| 13:42 |
|
oleonard |
Validation failed for type named Month declared in package DateTime::Types (/usr/lib/x86_64-linux-gnu/perl5/5.28/DateTime/Types.pm) at line 119 in sub named (eval) with value 29 |
| 13:42 |
|
tuxayo |
:o |
| 13:42 |
|
cait1 |
maybe something undiscovered witht he datepicker switch? |
| 13:43 |
|
cait1 |
can you please file and link? |
| 13:45 |
|
oleonard |
Bug 30488 |
| 13:45 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30488 major, P1 - high, ---, koha-bugs, NEW , Recalls for Koha |
| 13:45 |
|
oleonard |
Oh dangit I didn't change the title after cloning. Second time today. |
| 13:50 |
|
oleonard |
Is it not possible to initiate a recall from the staff interface? |
| 13:56 |
|
oleonard |
Does master have known issues with API stuff right now? For example, I can't seem to suspend a hold from the checkout screen |
| 13:57 |
|
|
lukeg joined #koha |
| 13:58 |
|
oleonard |
400 Bad Request |
| 14:19 |
|
cait1 |
oleonard: you have an 'everything falls apart' day |
| 14:19 |
|
oleonard |
So far none of it has been my fault :) |
| 14:21 |
|
cait1 |
I didn't say it was :) |
| 14:22 |
|
oleonard |
I'm just looking on the bright side! |
| 14:33 |
|
cait1 |
you are a good tester |
| 15:00 |
|
|
bag joined #koha |
| 15:01 |
|
|
edveal joined #koha |
| 15:40 |
|
|
philor joined #koha |
| 15:51 |
|
|
khall joined #koha |
| 16:25 |
|
|
khall joined #koha |
| 16:30 |
|
cait1 |
tuxayo: could you have a look at my rebased patches on bug 29271? the cash register report is pretty useless without the transaction types :( |
| 16:30 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29271 normal, P5 - low, ---, nick, Pushed to stable , Cash register report not displaying or exporting correctly |
| 16:31 |
|
tuxayo |
ok :) |
| 16:44 |
|
|
cait joined #koha |
| 16:52 |
|
|
khall_ joined #koha |
| 17:03 |
|
tuxayo |
cait1: great, thanks for the rebase and tests on 20.11 :) |
| 17:19 |
|
|
khall joined #koha |
| 17:23 |
|
|
michal joined #koha |
| 17:25 |
|
michal |
hey yall, i'm having trouble with the koha testing docker installation, i have a windows machine and part of the installation says I have to access my .profile file, but when I do so, and put in the proper variables, running docker compose says that it can't find the variables i give. |
| 17:26 |
|
michal |
what can i do about that, I can send my error message in here as well |
| 17:28 |
|
|
khall_ joined #koha |
| 17:29 |
|
oleonard |
michal: Let me pull out my Windows laptop and see if I can remember how I did it... |
| 17:30 |
|
michal |
okay sounds good |
| 17:33 |
|
oleonard |
michal: I have a .bashrc file in the root of my koha-testing-docker directory with some "export" statements |
| 17:35 |
|
pastebot |
"oleonard" at 127.0.0.1 pasted "koha-testing-docker .bashrc" (5 lines) at https://paste.koha-community.org/8559 |
| 17:35 |
|
michal |
so it's supposed to be in the ../../koha-testing-docker directory |
| 17:35 |
|
michal |
the one i cloned with git |
| 17:37 |
|
oleonard |
You're providing environment variables for that docker instance, so it has to go there (is my understanding) |
| 17:37 |
|
michal |
okay gotchu, i'll try that |
| 17:55 |
|
michal |
it's still giving me the same error as before, I made the .bashrc and put the correct directories for my system |
| 17:56 |
|
michal |
i have class so i'll be back in a bit, but i'll keep trying to figure out what to do |
| 18:07 |
|
|
theminh joined #koha |
| 18:10 |
|
|
michal joined #koha |
| 18:28 |
|
michal |
okay so new error, it says that the variables CPAN and COVERAGE are missing, I'm not sure how to find those variables |
| 18:29 |
|
michal |
do I have to add them in like SYNC_REPO |
| 18:31 |
|
tuxayo |
michal: Did you close and open you terminal/console? Because .bashrc is loaded only once |
| 18:31 |
|
michal |
yes i closed and opened the terminal, but i did source .bashrc |
| 18:32 |
|
tuxayo |
hum, it should be good, too times good even! |
| 18:32 |
|
tuxayo |
*two times |
| 18:33 |
|
tuxayo |
oleonard: did you have weird stuff with ktd on Windows? At the hackfest, we tried on 3 machines I think and gave up on recommending that. In favor of a Linux VM. Like one of the was execution permission missing and git status outputs all the file. Thus making it unusable. |
| 18:34 |
|
tuxayo |
We circumvented telling git to not display changes in permissions. It might bite us back. |
| 18:34 |
|
tuxayo |
And also file performance was terrible from inside the container so git checkout was unusable. qa tools also. git bz was terrible but bearable. |
| 18:35 |
|
tuxayo |
michal: what is the exact error? |
| 18:35 |
|
tuxayo |
I have |
| 18:35 |
|
tuxayo |
WARN[0000] The "COVERAGE" variable is not set. Defaulting to a blank string. |
| 18:35 |
|
tuxayo |
WARN[0000] The "CPAN" variable is not set. Defaulting to a blank string. |
| 18:36 |
|
michal |
time="2022-04-07T14:25:23-04:00" level=warning msg="The \"CPAN\" variable is not set. Defaulting to a blank string." |
| 18:36 |
|
michal |
time="2022-04-07T14:25:23-04:00" level=warning msg="The \"COVERAGE\" variable is not set. Defaulting to a blank string." |
| 18:36 |
|
michal |
also this |
| 18:36 |
|
tuxayo |
It's normal, when running on a personal machine context. |
| 18:36 |
|
michal |
error during connect: This error may indicate that the docker daemon is not running.: Get "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/containers/json?all=1&filters=%7B%22label%22%3A%7B%22com.docker.compose.project%3Dkoha%22%3Atrue%7D%7D&limit=0": open //./pipe/docker_engine: The system cannot find |
| 18:36 |
|
michal |
the file specified. |
| 18:39 |
|
michal |
oh okay so running ku works |
| 18:39 |
|
tuxayo |
michal: oh. We might have had something similar at hackfest. In the docker UI, we could confirm that docker daemon is not running. And we couldn't get it running. We gave up, it seemed to be that the windows version didn't actually have the necessary stuff to run docker. Maybe. Could be that the person didn't have enough admin privilege to enable/install everything. |
| 18:40 |
|
tuxayo |
> oh okay so running ku works |
| 18:40 |
|
tuxayo |
oh :o |
| 18:40 |
|
tuxayo |
What did you try to run before? |
| 18:40 |
|
michal |
ku but i think it didn't work because I didn't have SYNC_REPO, etc. in the .bashrc |
| 18:40 |
|
michal |
but now it's working despite the other warnings |
| 18:42 |
|
tuxayo |
> ku but i think it didn't work because I didn't have SYNC_REPO, etc. in the .bashrc |
| 18:42 |
|
tuxayo |
Indeed! |
| 18:43 |
|
tuxayo |
> but now it's working despite the other warnings |
| 18:43 |
|
tuxayo |
Don't worry about COVERAGE and CPAN. It's for our server (continuous integration) that automatically runs koha-testing-docker and runs automated tests. |
| 18:44 |
|
|
AndrewFH joined #koha |
| 18:50 |
|
michal |
when I run ku now, it exits koha-es-1, and going to localhost:8080 gives me a 404 |
| 18:51 |
|
tuxayo |
michal: when closing ktd, you must run "kd" for some cleanup |
| 18:59 |
|
tuxayo |
@later tell cait1 I found something suspicious on 29271 |
| 18:59 |
|
huginn |
tuxayo: The operation succeeded. |
| 19:00 |
|
tuxayo |
michal: Wasn't koha-es-1 already exiting before? Due to this: https://gitlab.com/koha-commun[…]elasticsearch-run |
| 19:09 |
|
michal |
im not sure, there doesn't say anything for windows with elasticsearch and since the first time I ran ku, it's been exiting koha-es-1 |
| 19:11 |
|
tuxayo |
michal: «there doesn't say anything for windows with elasticsearch» documentation doesn't cover that. |
| 19:12 |
|
tuxayo |
michal: «since the first time I ran ku, it's been exiting koha-es-1» ok, that makes sence |
| 19:13 |
|
michal |
in the tutorial video, they ran ku and they were then able to go to localhost:8080 |
| 19:13 |
|
tuxayo |
which one? |
| 19:13 |
|
wahanui |
i guess which one is that |
| 19:13 |
|
michal |
https://bywatersolutions.com/e[…]ha-testing-docker |
| 19:14 |
|
tuxayo |
If you find a way to have vm.max_map_count right, then you can have ElasticSearch working. Otherwise if you want ES, you will have to use a virtual machine to avoid all the unexpected mess/ |
| 19:14 |
|
tuxayo |
*mess. |
| 19:15 |
|
tuxayo |
michal: ok, it's not Windows. |
| 19:16 |
|
tuxayo |
They might have missed vm.max_map_count because that something you only do once and if you don't undo it or reinstall your computer then it will be okay. |
| 19:17 |
|
michal |
hm, so do i need ElasticSearch in order for me to access the localhost:8080 |
| 19:18 |
|
tuxayo |
No |
| 19:19 |
|
tuxayo |
michal: anyway unless you have experience with making koha-testing-docker work on Linux or macOS I recommend you to not try *directly* on Windows. Because it's uncharted territory and last week we tried and found issues that we can't solve |
| 19:20 |
|
michal |
I have wsl2, should i switch to that |
| 19:20 |
|
tuxayo |
michal: docker actually uses that. |
| 19:21 |
|
tuxayo |
But for more complex stuff we hit many weird issues. It's not yet 100% a Linux |
| 19:21 |
|
tuxayo |
So my recommendation is to install VirtualBox, download an iso file of your favorite Linux. (Linux Mint XFCE or Xubuntu if you don't have a favorite) And then the instruction at https://gitlab.com/koha-commun[…]ha-testing-docker should apply well. As well as you video tutorial. (I don't know if macOS changes much stuff) |
| 19:23 |
|
michal |
is there a reason why those two specific linux distros? |
| 19:24 |
|
tuxayo |
michal: user friendly and an interface that doesn't use much RAM compared to other ones. |
| 19:27 |
|
michal |
gotchu, i'll try doing that |
| 19:28 |
|
|
reiveune left #koha |
| 19:30 |
|
michal |
imma go with mint cuz i like the green |
| 19:30 |
|
tuxayo |
he he |
| 19:32 |
|
tuxayo |
And I recommend Linux Mint before Xubuntu (Xubuntu is based on Ubuntu) because Ubuntu pushes for some technical thing to distribute software called "snap packages" in which part of tooling is not libre software. |
| 19:33 |
|
tuxayo |
Every Linux user has different preferences and reasons to recommend Linux distributions. Don't worry about it until you have software politics (like preferring Koha against other non-libre ILS) and technical preferences. |
| 19:33 |
|
tuxayo |
It's still user friendly Linux distributions that people recommend to new users. |
| 19:33 |
|
tuxayo |
It's like people with car recommendations. Like about repairability and technical preferences. It's still a car. |
| 19:35 |
|
tuxayo |
> gotchu, i'll try doing that |
| 19:35 |
|
tuxayo |
great, because is basically a miracle that now Windows can make ktd partially work. Maybe in the future but in the meantime it makes it harder for you and make it harder to get help. |
| 19:37 |
|
tuxayo |
michal: About the virtual machine: give 70GiB at least of storage to the virtual machine (VM) when asked. (it doesn't take them from the host system until it's actually used, so zero waster). Try to give at leave 4GiB of ram to the VM. |
| 19:37 |
|
tuxayo |
How much do you have on your system? |
| 20:15 |
|
|
dpk__ joined #koha |
| 21:24 |
|
|
michal joined #koha |
| 22:05 |
|
michal |
i set up my virtual machine now, im working on installing docker and then koha |
| 22:07 |
|
michal |
i see what you mean about car preferences, i don't think i'll ever use enough different linux distros to get a feel for what is good |
| 22:08 |
|
michal |
maybe one day when i get adept enough i'll be a master linux hax0r |
| 22:22 |
|
tuxayo |
michal: « i don't think i'll ever use enough different linux distros to get a feel for what is good» |
| 22:22 |
|
tuxayo |
Don't worry ^^ |
| 22:23 |
|
tuxayo |
> a master linux hax0r |
| 22:23 |
|
tuxayo |
A lot of it is messing with stuff like koha-testing-docker :P |
| 23:06 |
|
dcook |
FYI I use ktd on Windows ;) |
| 23:06 |
|
dcook |
Well... |
| 23:06 |
|
dcook |
It uses Docker Desktop on Windows |
| 23:07 |
|
dcook |
michal: I do use a custom docker-compose.yml file to make it work and instead of using a git based on my Windows system I use a named volume within the Docker so that the git lives in Linux from the start |
| 23:18 |
|
|
michal joined #koha |
| 23:21 |
|
tuxayo |
dcook: good to know! :) |
| 23:23 |
|
tuxayo |
dcook: Anything else we should change beside the docker-compose.yml to make a better experience for people that are on Windows? |
| 23:23 |
|
tuxayo |
Is IO perf ok? For git checkout for example |
| 23:23 |
|
dcook |
Using the named volume is a big one |
| 23:24 |
|
dcook |
Not just because of I/O but also for things like ownership, file mode permissions, etc |
| 23:24 |
|
dcook |
line endings |
| 23:24 |
|
tuxayo |
Do you have ES running? |
| 23:24 |
|
dcook |
I think the container is running but I've never used it |
| 23:24 |
|
dcook |
Reminds me to make a note to try it out... |
| 23:24 |
|
tuxayo |
> Using the named volume is a big one |
| 23:24 |
|
tuxayo |
> Not just because of I/O but also for things like ownership, file mode permissions, etc |
| 23:24 |
|
tuxayo |
Oh, that's great! |
| 23:24 |
|
dcook |
Of course using a named volume can be dicey |
| 23:25 |
|
dcook |
You can accidentally nuke your git by doing a "docker volume prune". Guess how I know that... ;) |
| 23:25 |
|
tuxayo |
> I think the container is running but I've never used it |
| 23:25 |
|
tuxayo |
If it didn't crash then it's ok (about vm.max_map_count). What did you have to do about it? |
| 23:26 |
|
dcook |
Actually, you know what, more recently I've removed the ES container from my docker-compose.yml because I wasn't using it and figured it was a waste of m y resources lol |
| 23:26 |
|
tuxayo |
> You can accidentally nuke your git by doing a "docker volume prune". Guess how I know that... ;) |
| 23:26 |
|
tuxayo |
Oh, right. |
| 23:26 |
|
dcook |
As for vm.max_map_count, I haven't had to do anything |
| 23:26 |
|
dcook |
But regarding docker volumes, I scripted my own backup to regularly backup my Docker volumes. Not something your average user might do though.. |
| 23:27 |
|
dcook |
What else.. |
| 23:27 |
|
tuxayo |
That is weird. For michal is crashed because of that and at the hackfest. At least two people had that issue and I suppose nobody else on Windows had that working. |
| 23:27 |
|
dcook |
I remove the "restart: always" from docker-compose.yml because that really doesn't make sense for a developer.. |
| 23:27 |
|
dcook |
tuxayo: Let me check my Docker Desktop settings |
| 23:28 |
|
tuxayo |
> restart: always |
| 23:28 |
|
tuxayo |
What does it do? |
| 23:28 |
|
tuxayo |
> Let me check my Docker Desktop settings |
| 23:28 |
|
tuxayo |
Ah maybe there |
| 23:28 |
|
dcook |
tuxayo: That makes your Docker containers start at startup time |
| 23:28 |
|
dcook |
Hmm I use 5GB of RAM for Docker Desktop |
| 23:28 |
|
dcook |
2 CPU, 2GB swap (probably the default) |
| 23:29 |
|
dcook |
But yeah nah I haven't had ES crash |
| 23:29 |
|
dcook |
At least not recently |
| 23:29 |
|
dcook |
I get rid of the "SYNC_REPO" line and use my named volume instead... |
| 23:29 |
|
dcook |
I get rid of the kohanet aliases as I think those have caused crashes for me.. |
| 23:31 |
|
tuxayo |
For vm.max_map_count, maybe it's someone configured like this: |
| 23:31 |
|
tuxayo |
https://stackoverflow.com/ques[…]62078093#62078093 |
| 23:35 |
|
dcook |
Hmm I doubt it |
| 23:35 |
|
dcook |
But I suppose you never know.. |
| 23:35 |
|
dcook |
It could be that I did it years ago and forgot about it |
| 23:35 |
|
dcook |
I could check one more place.. |
| 23:36 |
|
dcook |
You know.. |
| 23:36 |
|
tuxayo |
Could be. |
| 23:36 |
|
tuxayo |
This can tell the value to confirm that it's not too low. It would be very weird to have ES start with the low value but we never know. |
| 23:36 |
|
tuxayo |
sysctl vm.max_map_count |
| 23:36 |
|
dcook |
I don't use the WSL2 Docker Desktop |
| 23:36 |
|
dcook |
I use OG Docker Desktop |
| 23:36 |
|
dcook |
Which uses Hyper-V for it's Linux VM |
| 23:36 |
|
dcook |
Let me take a wee look.. |
| 23:37 |
|
tuxayo |
> I use OG Docker Desktop |
| 23:37 |
|
tuxayo |
maybe it's that! |
| 23:37 |
|
dcook |
vm.max_map_count = 262144 |
| 23:37 |
|
tuxayo |
OG? https://en.wiktionary.org/wiki/O.G.#English |
| 23:38 |
|
dcook |
tuxayo: Yep heh |
| 23:38 |
|
tuxayo |
^^ |
| 23:38 |
|
dcook |
I'm behind the times with English slang but I find that one convenient haha |
| 23:39 |
|
tuxayo |
I learned it recently so we are in sync ^^ |
| 23:40 |
|
dcook |
Based on that setting, I must've gone into the Docker host and run that command then |
| 23:40 |
|
dcook |
Neato |
| 23:42 |
|
dcook |
Looking at Koha/REST/V1/Auth.pm and wishing someone had refactored C4/Auth.pm instead.. heh |
| 23:45 |
|
dcook |
Although if I did refactor C4/Auth.pm maybe the REST API would be a good place to test it.. |
| 23:45 |
|
dcook |
Not today though. Not today... |
| 23:46 |
|
dcook |
tuxayo: If you want to see something (that I at least think is) cool, check out bug 30289 |
| 23:46 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30289 enhancement, P5 - low, ---, dcook, NEW , Use Template::Toolkit WRAPPER to reduce template boilerplate |
| 23:51 |
|
dcook |
Still needs some work but so useful.. |
| 23:51 |
|
tuxayo |
dcook: look cool indeed. So we have a lot of duplication as of now? |
| 23:51 |
|
dcook |
Soooo much |
| 23:52 |
|
dcook |
Using a wrapper should make it easier to add content and maintain existing content |
| 23:53 |
|
dcook |
I have a different Perl project that has used one for years and it's so handy |
