| Time |
S |
Nick |
Message |
| 00:28 |
|
|
dpk__ joined #koha |
| 03:34 |
|
|
jzairo left #koha |
| 07:01 |
|
|
reiveune joined #koha |
| 07:01 |
|
reiveune |
hello |
| 07:46 |
|
|
marion joined #koha |
| 07:51 |
|
|
lds joined #koha |
| 07:56 |
|
|
cait joined #koha |
| 07:59 |
|
|
cait1 joined #koha |
| 07:59 |
|
cait1 |
good morning #koha |
| 08:45 |
|
tuxayo |
hi #koha :) |
| 08:54 |
|
matts |
hi ! |
| 09:27 |
|
magnuse |
\o/ |
| 09:31 |
|
* Nemo_bis |
waves |
| 10:23 |
|
|
thibaud_glt joined #koha |
| 10:54 |
|
tcohen |
Buen dÃa #koha |
| 10:54 |
|
cait1 |
good morning tcohen |
| 11:08 |
|
|
cait joined #koha |
| 11:18 |
|
|
oleonard joined #koha |
| 11:18 |
|
paxed |
oooh... i love how the code first searches for the patron and then calls $patron->track_login() ... OO is so very efficient X) |
| 11:22 |
|
tcohen |
oo has made our codebase better, indeed, paxed |
| 11:24 |
|
paxed |
tcohen: sure, although this particular case could be more efficient. we've been seeing "Waiting for table lock" for borrowers table |
| 11:24 |
|
paxed |
oh, i see newer koha now updates lastseen once per day |
| 11:28 |
|
tcohen |
paxed: we usually care more about DB access in loops and such, but yeah, generally, we are trying to be more efficient too. If you spot something, file a bug. And try to think how we can improve it as well! |
| 11:32 |
|
paxed |
tcohen: we've been seeing some problems with efficiency. biggest one is bug 29938 |
| 11:32 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29938 enhancement, P5 - low, ---, koha-bugs, NEW , Allow a secondary database |
| 11:34 |
|
tcohen |
ah, yes, interesting. We use the secondary for backups |
| 11:35 |
|
paxed |
technically, the secondary is for that, but it could do some actual work instead of being mostly idle |
| 11:38 |
|
|
koha-jenkins joined #koha |
| 11:38 |
|
oleonard |
o/ |
| 11:38 |
|
paxed |
librarians love to run those reports ;) |
| 11:40 |
|
tcohen |
I like the idea, trying to think how it would look in the code |
| 11:41 |
|
paxed |
optional parameter to C4::Context->dbh? |
| 11:41 |
|
tcohen |
Koha::Database |
| 11:41 |
|
tcohen |
? |
| 11:42 |
|
paxed |
*shrug* i dunno |
| 11:45 |
|
|
koha-jenkins joined #koha |
| 12:01 |
|
|
khall joined #koha |
| 12:12 |
|
|
marion joined #koha |
| 12:28 |
|
tcohen |
paxed: have you thought of making Koha leverage on background jobs as a way to avoid locking Koha for a long running report? |
| 12:55 |
|
|
marion joined #koha |
| 13:17 |
|
|
Dyrcona joined #koha |
| 13:18 |
|
koha-jenkins |
Project Koha_21.11_D11 build #45: STILL UNSTABLE in 1 hr 8 min: https://jenkins.koha-community[…]oha_21.11_D11/45/ |
| 13:33 |
|
paxed |
tcohen: yes, but "we need to report today" |
| 13:33 |
|
paxed |
the* |
| 13:46 |
|
cait1 |
a lot of reports might be for workflow tasks... not statistics... so they might not want a huge delay. statistics ait hink you could probably automate/schedule for nightly? |
| 14:37 |
|
tcohen |
background jobs should be immediate |
| 14:37 |
|
tcohen |
it is just that any report taking a bit longer can eat a worker for too long for apache to timeout |
| 15:05 |
|
|
lukeg joined #koha |
| 15:58 |
|
|
MarkHofstetter1 joined #koha |
| 16:01 |
|
|
MarkHofstetter1 joined #koha |
| 16:03 |
|
reiveune |
bye |
| 16:04 |
|
|
reiveune left #koha |
| 16:15 |
|
|
lukeg joined #koha |
| 16:31 |
|
|
oleonard joined #koha |
| 16:39 |
|
|
lukeg joined #koha |
| 16:50 |
|
|
khall_ joined #koha |
| 17:15 |
|
|
dpk__ joined #koha |
| 17:36 |
|
oleonard |
Can't call method "messages" on an undefined value at /kohadevbox/koha/circ/circulation.pl line 525 |
| 17:44 |
|
|
lukeg joined #koha |
| 18:09 |
|
|
bag joined #koha |
| 18:10 |
|
|
cait joined #koha |
| 18:11 |
|
oleonard |
khall_ around? |
| 18:17 |
|
kidclamp |
he is out today oleonard |
| 18:17 |
|
kidclamp |
oleonard: can I mark 29924 signed off? |
| 18:18 |
|
oleonard |
My little follow-up never got a signoff, that was the only reason I didn't mark it as such. |
| 18:18 |
|
kidclamp |
ah, I will do so, apologies :-) |
| 18:19 |
|
oleonard |
FYI the reason I was asking about khall_ is because fridolin isn't around and I think Bug 29230 has introduced a bug in master and 21.11.x |
| 18:19 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29230 minor, P5 - low, ---, jonathan.druart+koha, Pushed to stable , Patron's messages not accessible from template notices |
| 18:19 |
|
oleonard |
If I hit circulation.pl without a patron selected I get an error. |
| 18:20 |
|
oleonard |
I was hoping someone could double-check |
| 18:25 |
|
kidclamp |
confirmed oleonard |
| 18:25 |
|
|
cait1 joined #koha |
| 18:28 |
|
cait1 |
tcohen: interesting |
| 19:33 |
|
oleonard |
Bug 30101 |
| 19:33 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30101 major, P5 - low, ---, tomascohen, NEW , OPAC advanced search page broken by Bug 29844 |
| 19:34 |
|
oleonard |
Bug 30099 |
| 19:34 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30099 major, P5 - low, ---, koha-bugs, NEW , Error when accessing circulation.pl without patron parameter |
| 19:34 |
|
oleonard |
Broken pages, boo. |
| 19:43 |
|
|
fridolin joined #koha |
| 19:46 |
|
oleonard |
Hi fridolin |
| 19:49 |
|
oleonard |
fridolin: Please take a look at bugs 30099 and 30101 |
| 19:51 |
|
fridolin |
oki |
| 19:51 |
|
fridolin |
will do |
| 20:15 |
|
|
AndrewFH joined #koha |
| 20:19 |
|
cait |
i had some weird tihngs happen yesterday too |
| 20:19 |
|
cait |
empty simple search in OPAC led to an error |
| 20:19 |
|
cait |
an dcan't place holds |
| 20:19 |
|
cait |
could someone have a go maybe and confirm? holds was in opac only |
| 20:26 |
|
cait |
bug 30089 |
| 20:26 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30089 blocker, P5 - low, ---, oleonard, NEW , Placing holds on OPAC broken |
| 20:26 |
|
cait |
bug 30091 |
| 20:26 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30091 blocker, P5 - low, ---, oleonard, NEW , Sending an empty simple search results in error |
| 20:28 |
|
fridolin |
patch on Bug 30101 |
| 20:28 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30101 major, P5 - low, ---, fridolin.somers, Needs Signoff , OPAC advanced search page broken by Bug 29844 |
| 20:29 |
|
cait |
is someone around for SO? i could take over QA |
| 20:33 |
|
tcohen |
yes m'am |
| 20:33 |
|
cait |
iin that case we can also switch roles - I'll send QA mail later, but wnatto get through mails first |
| 20:34 |
|
cait |
bug 30097 also looks bad |
| 20:34 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30097 major, P5 - low, ---, koha-bugs, NEW , Cataloguing - advanced editor not loading |
| 20:36 |
|
cait |
tcohen: which one are yo working on? |
| 20:36 |
|
tcohen |
none |
| 20:36 |
|
cait |
oh :) |
| 20:36 |
|
tcohen |
I'm idle waiting for your order |
| 20:36 |
|
cait |
we need towork on our communication |
| 20:36 |
|
cait |
:) |
| 20:36 |
|
cait |
I'll start on bug 30101 |
| 20:36 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30101 major, P5 - low, ---, fridolin.somers, Needs Signoff , OPAC advanced search page broken by Bug 29844 |
| 20:37 |
|
cait |
will you take 30099? |
| 20:38 |
|
tcohen |
once fridolin submits you mean |
| 20:39 |
|
cait |
ok, I already got confused :) take whatever is blocker or major! :P |
| 20:39 |
|
fridolin |
i'm on patch for 30099 |
| 20:39 |
|
fridolin |
hello all btw \o/ |
| 20:40 |
|
fridolin |
Bug 30099 is hot ^^ |
| 20:40 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30099 major, P5 - low, ---, fridolin.somers, Needs Signoff , Error when accessing circulation.pl without patron parameter |
| 20:41 |
|
fridolin |
30097 seems harder i've never worked on advanced editor :-[] |
| 20:42 |
|
cait |
tcohen: as you are around: is there a way to get around the warning each time I do a git so? WARNING: git-filter-branch has a glut of gotchas generating mangled history |
| 20:42 |
|
cait |
rewrites. Hit Ctrl-C before proceeding to abort, then use an |
| 20:42 |
|
cait |
alternative filtering tool such as 'git filter-repo' |
| 20:42 |
|
cait |
(https://github.com/newren/git-filter-repo/) instead. See the |
| 20:42 |
|
cait |
filter-branch manual page for more details; to squelch this warning, |
| 20:42 |
|
cait |
set FILTER_BRANCH_SQUELCH_WARNI |
| 20:43 |
|
cait |
bug 30101 is ready for QA now |
| 20:43 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30101 major, P5 - low, ---, fridolin.somers, Signed Off , OPAC advanced search page broken by Bug 29844 |
| 20:45 |
|
fridolin |
whooo bug hunting, unleach the dogs ^^ |
| 20:45 |
|
cait |
testing 30099 now |
| 20:46 |
|
tcohen |
never saw that warning, cait |
| 20:46 |
|
tcohen |
never used go so, actually LOL |
| 20:47 |
|
cait |
how do you signoff multiple? |
| 20:47 |
|
tcohen |
I usually git bz apply -s # |
| 20:47 |
|
cait |
hm |
| 20:47 |
|
cait |
i might try that sometime |
| 20:47 |
|
tcohen |
if I'm not signing the bug, I just delete the branch and start over when time comes |
| 20:47 |
|
tcohen |
I think using git so might be the right thing |
| 20:48 |
|
fridolin |
I use "git so" a lot, no warning |
| 20:48 |
|
cait |
ktd fridolin? |
| 20:48 |
|
tcohen |
within KTD? outside? |
| 20:48 |
|
tcohen |
lxd? |
| 20:48 |
|
fridolin |
ah no I run git commands from host |
| 20:48 |
|
cait |
in ktd |
| 20:48 |
|
fridolin |
repo is "mounted" into KTD (twice) |
| 20:49 |
|
fridolin |
i prefer my git_prompt settings |
| 20:49 |
|
tcohen |
I run git commands on the host as well :-D |
| 20:49 |
|
tcohen |
for the same reason haha |
| 20:49 |
|
fridolin |
they show handmade info |
| 20:49 |
|
cait |
i like it sets up git bz for me |
| 20:49 |
|
cait |
so i don't hav eto do that on host |
| 20:49 |
|
fridolin |
sure |
| 20:49 |
|
tcohen |
yeah |
| 20:49 |
|
fridolin |
KTD is great |
| 20:49 |
|
tcohen |
I got used to doing it outside because of the mac |
| 20:50 |
|
tcohen |
git operations in KTD, on a mac => painfully slow |
| 20:50 |
|
cait |
it seems as soon as I start using it, all tihngs break lol |
| 20:50 |
|
fridolin |
but we crazy dev love to open the machine and make tunning |
| 20:50 |
|
cait |
perf is great here |
| 20:50 |
|
tcohen |
on linux, it is great |
| 20:50 |
|
tcohen |
that's why I bought a desktop computer |
| 20:50 |
|
fridolin |
i use Solus OS a rolling release recent build |
| 20:50 |
|
fridolin |
with Budgie WM |
| 20:51 |
|
tcohen |
I regret installing a non-LTS Ubuntu |
| 20:51 |
|
fridolin |
i have NVMe disk its a rocket |
| 20:51 |
|
fridolin |
indeed, and 22.04 LTS is comming |
| 20:51 |
|
fridolin |
Jammy Jellyfish XD |
| 20:52 |
|
tcohen |
hopefully they fix all the 21.20 issues :-D |
| 20:52 |
|
tcohen |
21.10 I mean |
| 20:52 |
|
fridolin |
https://www.omgubuntu.co.uk/20[…]-release-features |
| 20:52 |
|
fridolin |
of course ^^ |
| 20:53 |
|
fridolin |
i use to install as soon as there is beta 1 |
| 20:53 |
|
cait |
I am on most recent ubuntu on my personal desktop usually... |
| 20:53 |
|
cait |
too curious for my own good sometimes |
| 20:53 |
|
cait |
but it works well usually |
| 20:54 |
|
cait |
30099 also ready for QA |
| 20:55 |
|
cait |
ok, what bug is next? |
| 21:06 |
|
cait |
thx lukeg for confirming |
| 21:08 |
|
fridolin |
Bug 30090 is minor with makes sens |
| 21:08 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30090 minor, P5 - low, ---, fridolin.somers, Needs Signoff , Don't export action buttons from patron results |
| 21:09 |
|
cait |
yep, was just a 'side catch' |
| 21:09 |
|
cait |
if those works make any sense |
| 21:10 |
|
cait |
o, on to bug 30090 now |
| 21:10 |
|
cait |
fridolin: could oy ulook at 30089? |
| 21:10 |
|
cait |
i think that's another from wantarray |
| 21:11 |
|
fridolin |
on it |
| 21:11 |
|
fridolin |
it is |
| 21:28 |
|
cait |
I am on stand by |
| 21:28 |
|
cait |
working on osme other bad bugs |
| 21:47 |
|
fridolin |
Bug 30089 burning hot |
| 21:47 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30089 blocker, P5 - low, ---, fridolin.somers, Needs Signoff , Placing holds on OPAC broken |
| 21:53 |
|
cait |
testing it |
| 21:53 |
|
cait |
but iwll probably be my last one for tonight |
| 22:02 |
|
cait |
fridolin: i am not sur about this: |
| 22:02 |
|
cait |
$itemLoopIter->{notforloanvalue} = $notforloan_av->{opac_description} // ''; |
| 22:02 |
|
cait |
if opac-description si not set, we always fall back to the normal one in opac |
| 22:06 |
|
cait |
commented on the bug - ran out of time for today |
| 22:06 |
|
fridolin |
ah this is staff interface behaviot |
| 22:06 |
|
fridolin |
behavior |
| 22:06 |
|
fridolin |
this fallback sould be done by get_description_by_koha_field no ? |
| 22:08 |
|
fridolin |
mmm TT plugin does it himself |
| 22:08 |
|
fridolin |
oki cahnge |
| 22:10 |
|
fridolin |
cait: isn't it a way to hide from OPAC ? it is the actual behavior right ? |
| 22:11 |
|
fridolin |
i copy that to bz |
| 22:11 |
|
fridolin |
bugzilla |
| 22:13 |
|
cait |
no, not for hiding |
| 22:14 |
|
cait |
the fallback to the normal description is everywhere, locations, colelctions etc. |
| 22:14 |
|
cait |
the opac description is just an 'extra' if you want different descriptions |
| 22:14 |
|
cait |
you said it yourself, the TT plugin has the fallback inside |
| 22:26 |
|
fridolin |
cait: mmm we should get more opinions on bug report |
| 22:27 |
|
cait |
I am very sure about the behaviour |
| 22:27 |
|
cait |
you can test it on the detail pages etc. |
| 22:27 |
|
fridolin |
it is not in TT plugin GetByCode |
| 22:27 |
|
fridolin |
but this may be an issue ^^ |
| 22:28 |
|
fridolin |
I agree behavior must be consistent, one can always set a basic text "contact library" |
| 22:28 |
|
cait |
you can also set a space |
| 22:28 |
|
cait |
but it#s not supposed to be hidden |
| 22:29 |
|
cait |
we alays only configure description |
| 22:29 |
|
cait |
well, it's a mix, but we only configure the opac ones if libraries ask for a different one |
| 22:30 |
|
cait |
fridolin: i think it's in GetByCode |
| 22:30 |
|
fridolin |
so open a bug report for GetByCode ? |
| 22:30 |
|
fridolin |
should it be lower in Koha::AuthorisedValues ? |
| 22:30 |
|
cait |
no it's there |
| 22:30 |
|
cait |
have another loo |
| 22:30 |
|
cait |
trying to share the code |
| 22:31 |
|
cait |
https://git.koha-community.org[…]isedValues.pm#L27 |
| 22:31 |
|
cait |
lines 31-33 |
| 22:31 |
|
cait |
lib is the normal description, which is used if opac_descrpition is empty |
| 22:31 |
|
cait |
and if both are empty, it returns code |
| 22:32 |
|
cait |
it's all there |
| 22:34 |
|
fridolin |
indeeed there is even a Unit Test |
| 22:34 |
|
fridolin |
but wat about GetDescriptionsByKohaField ? |
| 22:34 |
|
fridolin |
GetDescriptionByKohaField does a job but this the method above |
| 22:35 |
|
fridolin |
i think we should add this to Koha::AuthorisedValues->get_description(s)_by_koha_field |
| 22:35 |
|
cait |
isn't it here? |
| 22:35 |
|
cait |
return $params->{opac} ? $av->{opac_description} || $description : $description; |
| 22:35 |
|
cait |
line 87 |
| 22:36 |
|
cait |
the problem is, that in your patch you overwrite it again |
| 22:36 |
|
cait |
with "" |
| 22:36 |
|
fridolin |
ahhhhhhh |
| 22:37 |
|
fridolin |
https://git.koha-community.org[…]isedValue.pm#L432 |
| 22:37 |
|
fridolin |
https://git.koha-community.org[…]risedValue.pm#L43 |
| 22:37 |
|
fridolin |
oupsy |
| 22:37 |
|
fridolin |
opac_description is a method |
| 22:37 |
|
fridolin |
not a db field |
| 22:37 |
|
fridolin |
it contains the fallback |
| 22:39 |
|
fridolin |
get_description_by_koha_field uses AV->opac_description so fallback is already there rigth ? |
| 22:40 |
|
fridolin |
db field is "lib_opac" |
| 22:40 |
|
cait |
yes i think you just need to remove yur line |
| 22:40 |
|
cait |
it's taken care of already |
| 22:41 |
|
cait |
can you updat ethe bug? ihave to leave |
| 22:42 |
|
fridolin |
im on it |
| 22:43 |
|
fridolin |
$notforloan_av my be undef that must be tested |
| 22:44 |
|
fridolin |
ah not undef but empty hash |
| 22:46 |
|
cait |
good night! |
| 22:48 |
|
cait |
... and happy Valentine's day Koha |
| 22:50 |
|
fridolin |
same for you :D |
