IRC log for #koha, 2021-12-21

All times shown according to UTC.

Time S Nick Message
00:43 AndrewFH joined #koha
06:05 lmstrand joined #koha
06:12 fridolin joined #koha
06:21 chriss joined #koha
06:30 fridolin yay
07:31 akilsdonk_ joined #koha
07:31 bshum joined #koha
07:32 phasefx_ joined #koha
07:58 cait joined #koha
08:03 cait1 joined #koha
08:03 cait1 good morning #koha
08:05 marion joined #koha
09:08 thibaud joined #koha
09:23 lds joined #koha
09:54 lds joined #koha
10:24 fridolin left #koha
10:25 lds joined #koha
10:29 thibaud_glt joined #koha
10:59 MikeLake joined #koha
11:02 tcohen hola #koha
11:02 tcohen overload++
11:13 pastebot "tcohen" at pasted "ashimema, Joubu, khall, kidclamp: thoughts? the class name needs ideas" (23 lines) at
11:13 tcohen the idea is that in bool context, the Koha::Validation object will eval to the carried bool value
11:14 cait joined #koha
11:16 tcohen does it sound like a good idea? can you help me naming the class?
11:16 ashimema I love it
11:17 tcohen ok, gimme a better name and I submit
11:17 tcohen heh
11:19 oleonard joined #koha
11:52 oleonard hi #koha
11:54 cait HI oleonard :)
11:55 oleonard Do you get a long break for Christmas cait?
11:58 cait not this year
11:58 cait but I like the quiet days between years to get some work on projects done :)
11:59 oleonard I know what you mean
11:59 cait the holidays are mostly weekend days this year
11:59 cait I get 24th off and 25th and 26th are holidays but saturday and sunday this year
12:01 oleonard At my library if a holiday falls on a weekend day when we don't work we can take a different day off in that week.
12:01 oleonard I don't know how common that is.
12:01 tcohen \o it is common here
12:02 tcohen here they establish it at the beggining of the year, so people can schedule their time off
12:04 cait not common here sadly :)
12:04 AndrewFH joined #koha
12:29 marcelr joined #koha
12:29 marcelr hi #koha
12:31 cait1 I am not #koha, but hi marcelr ;)
12:32 thibaud__glt joined #koha
12:33 marcelr hi cait1
12:33 marcelr you belong to #koha
12:34 cait1 aaww :)
12:34 marcelr i read your mail but have no simple solutions too
12:36 tcohen marcelr: can we go back to the AllowList dev?
12:36 tcohen I'm really sorry I didn't invest more time on that
12:36 marcelr you can do whatever you like, tcohen :)
12:36 marcelr i am just cleaning up now and then
12:38 AndrewFH joined #koha
12:46 cait1 marcelr: I believe there is no simple solution... but I'll try to prioritze my own work more (new years resolutions, leading by example... etc.)
12:50 tcohen bug 29746
12:50 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=29746 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Add a handy Koha::Boolean class
12:51 tcohen early feedback is much appreciated
12:51 tcohen several bugs could be simplified/pretty-fied using that
12:54 marion joined #koha
12:59 cait1 It does sound a litlte strange to me to have a class for Booleans :)
12:59 cait1 but htat is probably because it was a negative example reimplementing something in the programming language I had in one of my courses (and I am usre there is a good reason here)
13:07 tcohen we could call it something different
13:07 cait1 ... I didn't mean that badly - curious to see what it does
13:08 tcohen my first option was Koha::Validation
13:08 tcohen opinions accepted
13:08 ashimema cait1, did you see it's use case?
13:08 ashimema it's kinda a perlism I suppose
13:09 tcohen @seen Joubu
13:09 huginn` tcohen: Joubu was last seen in #koha 22 hours, 51 minutes, and 27 seconds ago: <Joubu> tcohen: bug 29736
13:09 ashimema truthy vs boolean
13:09 ashimema should a 'safe_to_delete' method always return a 'truthy' value.. that's the question I raise cait1 😉
13:10 cait1 i think if it's save to delete, truth is good
13:10 cait1 but if it's not, you'd want to know why?
13:11 cait1 and i wonder if we are not replicating a method we already have somewhere... that part of the code is due a clean-up
13:11 ashimema right now.. 'safe_to_delete' always returns a truthy value
13:12 ashimema with tcohens proposed solution.. we return a truthy value for 'safe' and a false for 'not safe'..
13:12 ashimema with an additional accessor allowing one to reach in and ask why it's 'falsy'
13:15 cait1 I understand
13:15 cait1 but don't we have other examples that return as a parameter a boolean and optionally a status code / message?
13:15 claw joined #koha
13:25 marcelr joined #koha
13:25 marcelr back
13:26 marcelr 27946 for you again tcohen
13:27 ashimema wow
13:27 ashimema we allow for '0th of the month'
13:27 ashimema wtf
13:28 marcelr sounds like a nice bug, ashimema
13:28 marcelr and who will be the 0th of the year?
13:29 marcelr tcohen: too bad you dont listen to good advice lol
13:33 cait1 ?
13:39 ashimema ?
13:40 marcelr he understands
13:41 ashimema that was one of the options I proposed cait1
13:42 ashimema and this isn't that far removed from that.
13:42 ashimema the key difference is how it reacts to context
13:43 ashimema dt_from_string is scary
13:43 ashimema to me.. it does too much magic
13:43 ashimema and our 'iso' support isn't at all iso
13:43 ashimema like..
13:44 ashimema you can pass in a 0 day of the month.. and it'll just magically convert it to the 1st for you.
13:44 ashimema which seems a bit black magic to me
13:55 marcelr ashimema this is really confusing:                         manager_id        => $user_id,
13:55 marcelr add_debit
13:55 marcelr the parameter should be manager_id
13:56 ashimema ?
13:56 ashimema in the POD you mean?
13:56 marcelr no in the sub
13:57 * ashimema doesn't like 'manager'.. it should be 'staff'
13:57 marcelr the table contains manager_id
13:57 marcelr and the param is called user_id
13:57 marcelr and especially user_id is very confusing
13:57 marcelr as you know ;)
13:58 ashimema indeed
13:58 ashimema feel free to submit a patch changing all occurrences to 'staff_id' or whatever
13:58 marcelr lol
13:58 ashimema I think I just kept what was already there
13:58 ashimema but I agree.. it's confusing
13:59 marcelr right i was already caught again
13:59 marcelr someone said: when there is enough frustration and anger, they will submit a patch
14:00 tcohen hahaha
14:08 ashimema lol
14:12 Dyrcona joined #koha
14:16 AndrewFH joined #koha
14:22 koha-jenkins Project Koha_21.05_D11 build #142: SUCCESS in 40 min: https://jenkins.koha-community[…]ha_21.05_D11/142/
14:23 koha-jenkins Project Koha_21.05_U18 build #116: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_U18/116/
14:32 koha-jenkins Project Koha_21.05_D12 build #69: UNSTABLE in 50 min: https://jenkins.koha-community[…]oha_21.05_D12/69/
14:39 koha-jenkins Project Koha_21.05_D9 build #119: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_D9/119/
14:40 AndrewFH joined #koha
14:42 koha-jenkins Project Koha_21.05_U20 build #123: SUCCESS in 58 min: https://jenkins.koha-community[…]ha_21.05_U20/123/
14:50 koha-jenkins Project Koha_21.05_D10 build #185: SUCCESS in 1 hr 6 min: https://jenkins.koha-community[…]ha_21.05_D10/185/
14:59 koha-jenkins Project Koha_21.05_U16 build #125: SUCCESS in 35 min: https://jenkins.koha-community[…]ha_21.05_U16/125/
15:03 koha-jenkins Project Koha_21.05_U_Stable build #118: SUCCESS in 41 min: https://jenkins.koha-community[…].05_U_Stable/118/
15:38 koha-jenkins Project Koha_21.05_U21 build #56: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_U21/56/
16:20 koha-jenkins Project Koha_21.05_U21 build #57: SUCCESS in 42 min: https://jenkins.koha-community[…]oha_21.05_U21/57/
16:39 cait1 left #koha
17:05 cait joined #koha
17:11 cait joined #koha
17:16 cait joined #koha
17:18 cait joined #koha
17:23 cait joined #koha
17:24 cait joined #koha
17:25 cait joined #koha
18:36 AndrewFH joined #koha
20:46 janPasi_ joined #koha
21:03 AndrewFH joined #koha
21:22 AndrewFH joined #koha
21:28 AndrewFH joined #koha
21:33 AndrewFH joined #koha
21:50 AndrewFH joined #koha
23:04 cait joined #koha
23:05 cait joined #koha
23:56 fridolin joined #koha
23:56 fridolin left #koha

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary