| Time |
S |
Nick |
Message |
| 01:02 |
|
|
cait joined #koha |
| 03:55 |
|
|
marie-luce joined #koha |
| 04:18 |
|
|
khall joined #koha |
| 04:31 |
|
|
lmstrand joined #koha |
| 05:16 |
|
|
chriss joined #koha |
| 06:21 |
|
|
alex_a joined #koha |
| 06:22 |
|
alex_a |
Bonjour |
| 06:25 |
|
magnuse |
\o/ |
| 06:49 |
|
|
reiveune joined #koha |
| 06:49 |
|
reiveune |
hello |
| 06:53 |
|
|
khall joined #koha |
| 07:13 |
|
|
Jeremy_b joined #koha |
| 07:18 |
|
|
khall joined #koha |
| 07:25 |
|
|
sophie_m joined #koha |
| 07:46 |
|
|
matts joined #koha |
| 08:29 |
|
Joubu |
oleonard, nugged: I've created an omnibus for the flatpickr move to group the different reports together. |
| 08:29 |
|
Joubu |
bug 29239 |
| 08:29 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29239 enhancement, P5 - low, ---, koha-bugs, NEW , [OMNIBUS] Replace jQueryUI's timepicker with flatpickr |
| 08:30 |
|
Joubu |
Then opened 3 bugs (blocker for 21.11): bug 29240, bug 29241 and bug 29242 |
| 08:30 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29240 major, P5 - low, ---, koha-bugs, NEW , Flatpickr - error in the console when a date is selected |
| 08:30 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29241 major, P5 - low, ---, koha-bugs, NEW , Flatpickr not displaying date in the past for futuredate |
| 08:30 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29242 normal, P5 - low, ---, koha-bugs, NEW , Flatpickr - Should autocomplete be turned off? |
| 08:30 |
|
nugged |
Thanks Joubu |
| 08:47 |
|
|
cait joined #koha |
| 08:51 |
|
|
alex_a joined #koha |
| 09:56 |
|
oleonard |
Joubu: Is 29242 different than it was with jQueryUI? |
| 10:03 |
|
Joubu |
yes |
| 10:03 |
|
Joubu |
(just tested on 21.05) |
| 10:07 |
|
oleonard |
The way you describe it, it sounds the same as it was before in Firefox. I'll have to look at Chrome. |
| 10:07 |
|
oleonard |
I don't like disabling autocomplete because I find it useful... |
| 10:11 |
|
Joubu |
yes it looks the same on FF, but on Chrome the options are displayed when the input gets the focus |
| 10:25 |
|
oleonard |
Turns out I had form history turned off in Chrome, no wonder I hadn't seen it |
| 10:55 |
|
oleonard |
Joubu: Bug 29241 doesn't apply |
| 10:55 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29241 major, P5 - low, ---, koha-bugs, NEW , Flatpickr not displaying date in the past for futuredate |
| 10:55 |
|
oleonard |
I guess it's not actually "needs signoff" is it? I must be jumping the gun. |
| 11:01 |
|
|
khall_ joined #koha |
| 11:04 |
|
Joubu |
Reattaching it. But it's not ready as I think we should implement the suggestion I made on bug 28942 comment 5 before anything else |
| 11:04 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28942 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Use Flatpickr on acquisitions pages |
| 11:08 |
|
|
cait joined #koha |
| 11:15 |
|
|
cait joined #koha |
| 11:18 |
|
domm |
Is there anything I can / should do to get the very minor fix for the very minor bug 29010 into the 21.11 release? |
| 11:18 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29010 enhancement, P5 - low, ---, koha-bugs, NEW , weight input pattern wrong |
| 11:25 |
|
oleonard |
domm: It's still marked as "NEW," so nobody knows there is a patch waiting for testing! |
| 11:26 |
|
oleonard |
Joubu: Do you not plan to submit a patch implementing your suggestion from bug 28942? |
| 11:26 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28942 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Use Flatpickr on acquisitions pages |
| 11:27 |
|
ashimema |
oleonard |
| 11:27 |
|
wahanui |
oleonard is probably seeing some buggy stuff though |
| 11:27 |
|
* oleonard |
jumps |
| 11:27 |
|
ashimema |
is it deliberate that message dialogues and alert/error dialogues have a different width? |
| 11:28 |
|
ashimema |
.dialog sets width: 65%.. but then it's overridden for the 'message' case with 55% |
| 11:28 |
|
oleonard |
I don't recall a specific reason for it, and wouldn't object to it being revised. |
| 11:29 |
|
* ashimema |
is bugged by it every time I see it in returns |
| 11:40 |
|
domm |
oleonard: ok, but what's the process of changing the status? Shall I just change it? I assuemed somebody would go through the bugs and set a fitting status / asign them to somebody etc |
| 11:46 |
|
ashimema |
quick scratch of itch on bug 29244 |
| 11:46 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29244 enhancement, P5 - low, ---, koha-bugs, NEW , alert/error and message dialogues should have the same width |
| 11:52 |
|
magnuse |
domm: you set the bug to "needs signoff" yourself. then you hope for someone to come along and test it, and they hopefully change it to "signed off" |
| 11:54 |
|
magnuse |
then someone from the qa team tests it and hopefully set it to "passed qa". then the release manager must choose to include it in koha, and the bug is "pushed to master" |
| 12:01 |
|
|
alex_a_ joined #koha |
| 12:03 |
|
domm |
magnuse: ok, thanks, will do |
| 12:28 |
|
cait |
domm: usually people will only assign themselves to bugs they will work on |
| 12:36 |
|
|
NateC joined #koha |
| 12:38 |
|
|
cait joined #koha |
| 12:45 |
|
|
NateC_ joined #koha |
| 12:48 |
|
|
marcelr joined #koha |
| 12:51 |
|
|
cait joined #koha |
| 12:52 |
|
|
cait joined #koha |
| 12:53 |
|
|
Dyrcona joined #koha |
| 13:07 |
|
|
khall joined #koha |
| 13:09 |
|
ashimema |
oleonard, Joubu.. are either of you already working on comment 5 from bug 28942 |
| 13:09 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28942 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Use Flatpickr on acquisitions pages |
| 13:09 |
|
ashimema |
I was thinking similar thoughts to Joubu when I reviewed them all for QA.. but wasn't so worried |
| 13:09 |
|
ashimema |
but I like the idea of more centralisation |
| 13:21 |
|
|
cait joined #koha |
| 13:42 |
|
|
cait joined #koha |
| 13:51 |
|
|
cait joined #koha |
| 13:51 |
|
|
cait joined #koha |
| 13:58 |
|
ashimema |
hmm |
| 13:58 |
|
ashimema |
we're a bit inconsistent in a few other area's in date pickers too |
| 13:58 |
|
ashimema |
like.. both categories.js and circulation.js set their own minDate |
| 13:58 |
|
ashimema |
oleonard.. any reason not to use 'futuredate' for those |
| 13:58 |
|
ashimema |
for consistency |
| 14:08 |
|
oleonard |
ashimema: categories.js was updated before I built in the futuredate check |
| 14:09 |
|
ashimema |
indeed |
| 14:09 |
|
ashimema |
I added a patch to 29240 |
| 14:09 |
|
oleonard |
I don't recall a specific reason in circulation.js, perhaps just an oversight |
| 14:09 |
|
ashimema |
be great if you could take a look |
| 14:09 |
|
ashimema |
the real work is inside calendar.inc of course |
| 14:10 |
|
oleonard |
Nice, thanks |
| 14:10 |
|
ashimema |
but as it removes flatpickrfrom and flatpickrto to use data-start_for instead.. I had to go through the whole codebase updating the calls |
| 14:11 |
|
ashimema |
I got all the basic ones, but there were a few left that did it themselves.. where we had more than one from/to on one page.. as you're probably aware that's why this wasn't consistent in the first place of course. |
| 14:15 |
|
oleonard |
ashimema: Is that patch supposed to apply by itself or with the other one on 29240? Either way it doesn't apply |
| 14:16 |
|
ashimema |
ah |
| 14:16 |
|
ashimema |
by itself |
| 14:16 |
|
ashimema |
I forgot Joubu had a patch there already |
| 14:18 |
|
ashimema |
hmm |
| 14:18 |
|
ashimema |
should apply on it's own |
| 14:19 |
|
ashimema |
I've obsoleted Joubu's patch now |
| 14:19 |
|
ashimema |
mine include the fix inline |
| 14:19 |
|
|
NateC joined #koha |
| 14:22 |
|
ashimema |
lol |
| 14:22 |
|
ashimema |
`$(".suspend_until_datepicker")` |
| 14:22 |
|
ashimema |
that class doesn't actually exist anywhere in the codebase as far as I can see |
| 14:22 |
|
ashimema |
I perhaps should have got a bit anal on QAing all this |
| 14:23 |
|
ashimema |
but the stuff worked |
| 14:23 |
|
ashimema |
and I like to see progress |
| 14:31 |
|
|
khall_ joined #koha |
| 14:34 |
|
oleonard |
Error on pendingreserves.pl: DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 145 |
| 14:34 |
|
oleonard |
Could this be a problem with my data? |
| 14:36 |
|
ashimema |
hmm, could well be |
| 14:37 |
|
ashimema |
hmm |
| 14:45 |
|
oleonard |
Well... I emptied the reserves table and placed new holds... same problem. |
| 14:46 |
|
ashimema |
rereading your error |
| 14:46 |
|
ashimema |
looks like a query problem |
| 14:49 |
|
ashimema |
hmm |
| 14:49 |
|
ashimema |
27131 looks like it might be the culprit |
| 14:50 |
|
ashimema |
maybe not |
| 14:50 |
|
ashimema |
it's a code problem though |
| 14:50 |
|
ashimema |
it means there's a join |
| 14:50 |
|
ashimema |
and biblionumber exists in both tables |
| 14:51 |
|
ashimema |
and we've not said which table we're looking at |
| 15:16 |
|
oleonard |
ashimema++ |
| 15:16 |
|
oleonard |
Thanks for Bug 29240 |
| 15:16 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29240 major, P5 - low, ---, koha-bugs, Signed Off , Flatpickr - error in the console when a date is selected |
| 15:16 |
|
ashimema |
pleasure |
| 15:16 |
|
ashimema |
I could see it was looking like it might get stuck |
| 15:17 |
|
ashimema |
and I love the flatpickr work you've done so thought I'd jump :) |
| 15:22 |
|
ashimema |
hmm |
| 15:22 |
|
ashimema |
is git really slow today or is that just my server |
| 15:22 |
|
ashimema |
git pull's are taking minutes |
| 15:31 |
|
ashimema |
I've never really thought about it.. we don't do modals in the opac at all do we? |
| 15:32 |
|
oleonard |
Yeah, for a few confirmation messages. |
| 15:32 |
|
ashimema |
just considering how I should add my bookings workflow to the opac |
| 15:32 |
|
ashimema |
the staff client version if very modal driven |
| 15:34 |
|
oleonard |
I don't object to it if it seems like the best solution |
| 15:35 |
|
ashimema |
I think it could work ok as a page like place hold |
| 15:36 |
|
reiveune |
bye |
| 15:36 |
|
|
reiveune left #koha |
| 15:37 |
|
* ashimema |
should look at some other opacs some time.. it's been a while |
| 15:37 |
|
ashimema |
maybe koha's opac does feel 'old fashioned'.. people keep telling me it does but no-one has really be able to tell me what they mean |
| 15:38 |
|
oleonard |
I think by "old-fashioned" they mean "the back button isn't broken" ;) |
| 15:38 |
|
ashimema |
lol |
| 15:42 |
|
oleonard |
We may not have modals everywhere but I think we're doing better than Sirsi https://snipboard.io/8chH4n.jpg |
| 15:43 |
|
ashimema |
lol |
| 15:43 |
|
ashimema |
I'm not sure modals are especially modern either ;) |
| 15:43 |
|
ashimema |
I like them in the staff client |
| 15:43 |
|
ashimema |
but not so sure about opac |
| 16:12 |
|
|
cait joined #koha |
| 16:23 |
|
|
NateC joined #koha |
| 16:29 |
|
|
cait joined #koha |
| 16:34 |
|
|
cait joined #koha |
| 17:02 |
|
|
claw joined #koha |
| 17:54 |
|
ashimema |
oleonard++ |
| 18:07 |
|
|
caroline_catlady joined #koha |
| 19:13 |
|
|
dpk joined #koha |
| 19:47 |
|
|
khall joined #koha |
| 22:08 |
|
|
alexbuckley joined #koha |
| 22:38 |
|
|
gooble_gobble joined #koha |
