Time |
S |
Nick |
Message |
00:38 |
|
|
inlibro joined #koha |
01:38 |
|
|
inlibro joined #koha |
02:38 |
|
|
inlibro joined #koha |
03:28 |
|
|
kathryn joined #koha |
03:39 |
|
|
inlibro joined #koha |
04:39 |
|
|
inlibro joined #koha |
05:27 |
|
|
shaffendi joined #koha |
05:39 |
|
|
inlibro joined #koha |
05:44 |
|
ashimema[m] |
dcook was busy last night :) |
05:44 |
|
ashimema[m] |
Good morning #koha |
05:44 |
|
dcook |
Morning :) |
05:45 |
|
dcook |
I mean I only have 16 minutes of work left today.. heh |
05:45 |
|
dcook |
And yeah just me disturbing everything heh |
05:45 |
|
ashimema[m] |
Haha.. good evening dcook |
05:45 |
|
dcook |
Aww, thanks for that listserv reply |
05:45 |
|
dcook |
One of these days, I really need to work out my listserv email formatting.. |
05:47 |
|
ashimema[m] |
I though the formatting was good. Clear and concise |
05:48 |
|
dcook |
:D |
05:48 |
|
ashimema[m] |
Been working my way through the emails this morning.. afraid I can't really answer the others..any I think are just historical mistakes regarding shebangs |
05:48 |
|
dcook |
Turns out C4/SIP/acstest.py is the one non-GreyBox python script we have... heh https://github.com/Koha-Commun[…]a/search?l=python |
05:48 |
|
dcook |
I'm thinking the shebangs are historical mistakes as well |
05:48 |
|
dcook |
And the SIP... hoping a SIP guru comes out of the woodworks |
05:49 |
|
dcook |
Wow, C4/SIP/acstest.py dates back to 2007.. |
05:49 |
|
ashimema[m] |
I had no idea that py script was there.. haha |
05:49 |
|
dcook |
You must be able to tell I like to be a clean and tidy person by how much I dislike unused code >_> heh |
05:49 |
|
dcook |
Yeah, it hit me out of the blue! |
05:49 |
|
dcook |
Just goes to show how large our codebase is |
05:50 |
|
ashimema[m] |
Oh yeah, I'm behind you on that. Though I've struggled to have old code removed a few times in the past |
05:50 |
|
dcook |
Oh? |
05:50 |
|
wahanui |
Oh are there instructions? |
05:50 |
|
ashimema[m] |
Koha is mahooooosive |
05:50 |
|
dcook |
Hmm looks like Colin Campbell worked on C4/SIP/example_institution_dump.sh about 6 years ago. He might be a good one to look at some of the SIP stuff.. |
05:51 |
|
dcook |
Although maybe that was an automated update via sed or something.. |
05:51 |
|
ashimema[m] |
None of the things you've mentioned.. but there have been a few times I've asked about removing a script here or there and been told by someone it's being used.. which is fine but has surprised me |
05:51 |
|
dcook |
Ahh yeah |
05:51 |
|
ashimema[m] |
I'll ask Colin to take a look :) |
05:51 |
|
dcook |
Looks like it was probably just a sed by Colin but still wouldn't hurt |
05:51 |
|
|
irma joined #koha |
05:51 |
|
dcook |
I think he looks more at SIP than many others |
05:52 |
|
dcook |
misc/migration_tools/remove_unused_authorities.pl is one that I hadn't noticed before |
05:52 |
|
ashimema[m] |
I really do like the idea of splitting up koha-common into smaller constituent self contained parts |
05:52 |
|
dcook |
:3 |
05:52 |
|
dcook |
Glad to hear it |
05:53 |
|
dcook |
I mean we have the CI pipelines so the added management of the code shouldn't be a big drama |
05:53 |
|
ashimema[m] |
Also keen on getting us to a point where we can run more easily in virtual envs.. I see that as a stepping stone to requiring a newer perl and then being able to adopt some more modern best practices |
05:53 |
|
ashimema[m] |
Indeed |
05:54 |
|
dcook |
Mmm true |
05:54 |
|
dcook |
Although I don't know if we could/would shift as a whole community |
05:54 |
|
dcook |
I was helping someone with a Python app recently and doing the deploy with the virtual environment was a bit tricky.. |
05:54 |
|
dcook |
It was a small app, so I could just package it as a Python wheel |
05:54 |
|
ashimema[m] |
I touched most 'scrips' when I introduced the base class for them.. before then I had no idea what half of them were |
05:54 |
|
dcook |
Then a couple manual steps for an easy deployment.. |
05:54 |
|
dcook |
Hehe. Fair enough. |
05:55 |
|
dcook |
With the Python app, I was thinking about just packaging the whole thing up as a Debian package |
05:55 |
|
dcook |
I was reading something on Python's website which was kind of itneresting.. |
05:55 |
|
dcook |
Wonder if I can find that |
05:57 |
|
dcook |
This might be it: https://packaging.python.org/overview/ |
05:57 |
|
ashimema[m] |
I wonder how the whole Perl 7 thing is going to pan out medium to long term |
05:57 |
|
dcook |
Oh yeah.. |
05:57 |
|
dcook |
Trying to remember what timelines they had for that |
05:58 |
|
dcook |
"within the next year" from June 2020.. |
05:58 |
|
ashimema[m] |
It all appears to have gone quiet on that front again, but I bet there's stuff going on behind the scenes. |
05:58 |
|
dcook |
Yeah I imagine so |
05:59 |
|
dcook |
"GitHub is now the primary repository for the Perl code, and has been since October 2019. " |
05:59 |
|
dcook |
Interesting |
05:59 |
|
dcook |
(https://www.effectiveperlprogr[…]stance-operator/) |
06:01 |
|
shaffendi |
hi everyone |
06:01 |
|
shaffendi |
i tried to integrate ldap with koha |
06:02 |
|
shaffendi |
but i got this kind of error |
06:02 |
|
shaffendi |
../etc/koha/sites/uthmlib/koha-conf.xml:316.31: Opening and ending tag mismatch: c ardnumber line 316 and userid <cardnumber is="uid"></userid> |
06:02 |
|
shaffendi |
can anyone advise? |
06:02 |
|
shaffendi |
my ldap server using anonymous. |
06:03 |
|
shaffendi |
so i didnt put in my user n pass in conf |
06:03 |
|
shaffendi |
is it happened because of my empty/blank borrowers table> |
06:04 |
|
shaffendi |
this is fresh install on debian 9 using koha 20.05 |
06:05 |
|
ashimema[m] |
That looks like you've introduced a syntax error into your XML in koha-conf |
06:05 |
|
shaffendi |
oh |
06:06 |
|
shaffendi |
u mean the my auth conf is wrong? |
06:09 |
|
ashimema[m] |
I mean it looks like you have a missing < rage somewhere |
06:09 |
|
ashimema[m] |
tag not rage.. |
06:09 |
|
ashimema[m] |
Silly autocorrect |
06:10 |
|
|
lmstrand joined #koha |
06:11 |
|
ashimema[m] |
In the clip above you open with <cardnumber> but close with </userid> |
06:11 |
|
ashimema[m] |
That looks wrong |
06:11 |
|
|
did joined #koha |
06:11 |
|
ashimema[m] |
XML is unforgiving |
06:15 |
|
|
enkidu joined #koha |
06:19 |
|
|
fridolin joined #koha |
06:23 |
|
dcook |
Oops got caught up and forgot to come back here |
06:24 |
|
ashimema[m] |
No worries, I'm in morning rush mode now. Dog walk then kids ready for school challenges |
06:24 |
|
ashimema[m] |
Have a good night dcook |
06:24 |
|
|
kathryn joined #koha |
06:26 |
|
dcook |
And here I thought I had a lot to do tonight.. |
06:26 |
|
dcook |
good luck, ashimema[m] |
06:35 |
|
|
severine_q joined #koha |
06:39 |
|
|
inlibro joined #koha |
06:40 |
|
|
alex_a joined #koha |
06:40 |
|
alex_a |
Bonjour |
06:47 |
|
|
reiveune joined #koha |
06:47 |
|
magnuse |
davidnind++ for 319 signoffs in 2020! |
06:47 |
|
magnuse |
that is SO impressive! |
06:48 |
|
reiveune |
hello |
06:53 |
|
Joubu |
ashimema[m]: about the graph on the dashboard, would that it be possible to assign a color per person? |
06:55 |
|
Joubu |
thanks dcook! |
07:01 |
|
|
sophie_m joined #koha |
07:03 |
|
|
lds joined #koha |
07:03 |
|
lds |
hi |
07:08 |
|
Joubu |
mtj: libjs-jquery has been removed from debian/control.in but it's still in debian/control. We had 17084 to deal with that, is the automated process broken? |
07:10 |
|
Joubu |
@later tell mtj libjs-jquery has been removed from debian/control.in but it's still in debian/control. We had 17084 to deal with that, is the automated process broken? |
07:10 |
|
huginn |
Joubu: The operation succeeded. |
07:11 |
|
|
kathryn joined #koha |
07:12 |
|
mtj |
hi Joubu, short answer, somewhat.. :) |
07:12 |
|
mtj |
the control file included in the packages are correct |
07:14 |
|
mtj |
..but the automated process that sends patches to bug 17084 has been broken for a few cycles |
07:14 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17084 blocker, P1 - high, ---, mtj, Pushed to oldoldstable , Automatic debian/control updates (master) |
07:15 |
|
Joubu |
mtj: what would be the best to deal with that? |
07:15 |
|
mtj |
its something i was working on today, coincidentally |
07:15 |
|
Joubu |
1. RM catches changes to .in and generated the other one? |
07:16 |
|
Joubu |
2. pre push hook to catch changes and attach patch to the bug report |
07:16 |
|
Joubu |
3. Previous process should be restored |
07:19 |
|
mtj |
hmm, i think probably 4 separate bugs - one for each release (unstable/20.05/19.11/19.05) |
07:21 |
|
mtj |
..and some automated script to send patches for the control file for each branch |
07:22 |
|
ashimema[m] |
That was my understanding of how it used to work I think |
07:22 |
|
ashimema[m] |
4 bugs |
07:23 |
|
mtj |
i think the control file might need to be generated specifically on a deb.9 system? |
07:24 |
|
ashimema[m] |
that reminds me.. I hope mirko is OK.. it's been ages since we've had any contact with him at all |
07:24 |
|
ashimema[m] |
mtj, you've been doing a fantastic job stepping into the breach |
07:24 |
|
ashimema[m] |
@seen drojf |
07:24 |
|
huginn |
ashimema[m]: drojf was last seen in #koha 1 year, 45 weeks, 6 days, 12 hours, 9 minutes, and 40 seconds ago: <drojf> -s |
07:25 |
|
mtj |
cheers ashimema[m] - its been a while hey... |
07:25 |
|
ashimema[m] |
indeed |
07:25 |
|
ashimema[m] |
wow |
07:26 |
|
mtj |
i have an unproven theory that the process that generates the control file, is sensitive to the OS version |
07:28 |
|
ashimema[m] |
interesting |
07:29 |
|
mtj |
...as each debian/ubuntu version has access to a set of different packages |
07:30 |
|
ashimema[m] |
makes sense |
07:31 |
|
Joubu |
hum, so we should have several debian/control files? |
07:32 |
|
mtj |
we may *theoretically* get different control files on diff. OS versions |
07:32 |
|
mtj |
Joubu: no no... the workaround has always been to built the control file on the oldest supported OS version |
07:33 |
|
mtj |
..and the package just-works on any newer OS |
07:35 |
|
* ashimema[m] |
likes the dashboard enhancements.. looks nice today |
07:36 |
|
Joubu |
ok mtj. If you are on it today, I let you work then :) |
07:36 |
|
mtj |
my point is that there might be a bit more effort to building a 'correct' control file - than just running a script on any dev box |
07:37 |
|
mtj |
i should test my theory! |
07:38 |
|
mtj |
i have been building the control file in a fresh deb9 pbuilder vm |
07:39 |
|
|
inlibro joined #koha |
07:43 |
|
mtj |
i think the best option is probably to fix the automated patches to BZ, the RMs can grab the latest patch and manually apply it to their branch |
07:45 |
|
mtj |
the patch can include some useful info about which commit the control file was build from, on which OS version, etc |
07:48 |
|
magnuse |
mtj++ |
07:54 |
|
|
alex_a_ joined #koha |
07:56 |
|
|
alex_a__ joined #koha |
08:29 |
|
|
kohaputti joined #koha |
08:36 |
|
Joubu |
ashimema[m]: regarding the discussion we had yesterday, should not bug 24381 be "assigned"? |
08:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24381 major, P5 - low, ---, martin.renvoize, Needs Signoff , ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees |
08:37 |
|
ashimema[m] |
hmm, maybe |
08:37 |
|
ashimema[m] |
what I really need/want is some feedback on the actual notice from cait |
08:38 |
|
ashimema[m] |
but yeah.. that whole area does appear to need more work to get it to use more 'normal' routines.. |
08:38 |
|
ashimema[m] |
honestly.. I'm nearing the stage of just giving up on that bug :( |
08:38 |
|
ashimema[m] |
it was meant to be a quick improvement |
08:39 |
|
|
inlibro joined #koha |
08:41 |
|
Joubu |
ashimema[m]: could you at least let a comment with the situation we faced? |
08:42 |
|
ashimema[m] |
will do |
08:43 |
|
kohaputti |
ashimema[m], thanks |
08:45 |
|
Joubu |
eythian: Hi Robin, do you remember that you once told me (long time ago) that using a "#!/usr/bin/env perl" shebang was not a good idea in Koha? Maybe was it package related? Or maybe it was not you!? |
08:45 |
|
* Joubu |
is fighting with his memories.. |
08:45 |
|
eythian |
Joubu: hm |
08:45 |
|
eythian |
I can't remember having specific opinions on that, but it's possible :) |
08:46 |
|
eythian |
It might be package related, but I'm not sure |
08:46 |
|
Joubu |
I'm pretty sure I submitted new scripts with that env shebang we someone told me it "was not good" |
08:46 |
|
Joubu |
but really cannot remember who, why, when... |
08:46 |
|
Joubu |
ok thanks eythian anyway :) |
08:47 |
|
eythian |
let me know if you figure it out :) |
08:48 |
|
ashimema[m] |
huh.. what did I do kohaputti ? |
08:48 |
|
kohaputti |
for working on the credit/debit slip |
08:48 |
|
Joubu |
eythian: There is a discussion on the list to unify the shebangs and use the env one for better compat (eg. with Carton) and flexibility |
08:48 |
|
ashimema[m] |
the 'nearing the stage of just giving up' wasn't aimed at anyone negatively btw.. I'm just a tad tired of that one and need a break before getting back to it I tihnk |
08:48 |
|
ashimema[m] |
brain is reaching capacity ;P |
08:49 |
|
eythian |
Joubu: off the top of my head I can't see anything particularly wrong with it |
08:49 |
|
Joubu |
which sounds a good idea, but trying to remember if the hidden part I have in mind is still valid |
08:49 |
|
Joubu |
me neither :) |
08:49 |
|
ashimema[m] |
:) |
08:49 |
|
Joubu |
just a vague old memory haunting me! |
08:50 |
|
eythian |
Joubu: found it! |
08:50 |
|
eythian |
https://bugs.koha-community.or[…]ug.cgi?id=5617#c7 |
08:50 |
|
huginn |
Bug 5617: normal, P5 - low, ---, gmcharlt, CLOSED WONTFIX, fix-perl-path.pl misses some files |
08:50 |
|
ashimema[m] |
nice one |
08:50 |
|
Joubu |
Awesome! I didn't dream! |
08:51 |
|
eythian |
a bit of careful googling brought it to the top :) |
08:52 |
|
Joubu |
weird, I search for the env shebang in the bz attachment but did not find i |
08:52 |
|
Joubu |
it |
08:52 |
|
ashimema[m] |
it looks like we could perhaps use the same approach as the transfer slip printing does Joubu |
08:53 |
|
ashimema[m] |
that does a print slip, but calls GetPreparedLetter properly |
08:53 |
|
Joubu |
there was the .css and include file problem IIRC |
08:54 |
|
ashimema[m] |
indeed |
08:54 |
|
ashimema[m] |
it looks like the controller handles inserting the stylesheet |
08:56 |
|
ashimema[m] |
I'm at the verge of throwing away what I've done and giving it a clearer treatment.. it feels like we need more options for the slips here.. we're re-using the same slip for loads of really pretty distinct types of 'receipt' |
09:32 |
|
|
cait joined #koha |
09:40 |
|
|
inlibro joined #koha |
09:50 |
|
|
enkidu joined #koha |
10:40 |
|
|
inlibro joined #koha |
10:57 |
|
mtj |
hey Joubu, new control file for master on bzz 17084 |
11:06 |
|
Joubu |
thx mtj |
11:07 |
|
ashimema[m] |
right.. bug 24381 is back to being ready to test.. |
11:07 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24381 major, P5 - low, ---, martin.renvoize, Needs Signoff , ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees |
11:08 |
|
ashimema[m] |
I think the DB update still needs some work.. it feels like the underlying default template has changed to the update doesn't follow through yet the way it should :( |
11:08 |
|
ashimema[m] |
Joubu.. no urgency, but when you get a moment I'd love some feedback on that final patch |
11:08 |
|
ashimema[m] |
it does what we discussed |
11:09 |
|
Joubu |
ok, will try and have a look later this week |
11:09 |
|
ashimema[m] |
ta :) |
11:13 |
|
|
khall joined #koha |
11:21 |
|
|
khall_ joined #koha |
11:30 |
|
oleonard |
Hi all |
11:30 |
|
ashimema[m] |
Hi Owen |
11:40 |
|
|
inlibro joined #koha |
11:48 |
|
|
fridolin joined #koha |
11:52 |
|
ashimema[m] |
oleonard.. do you have an opinion on page titles? |
11:53 |
|
ashimema[m] |
I feel like ours are often too long (they seem to often match the content of the breadcrumb navigation).. and as such the pertinent bit of information is often lost form the tab display |
11:53 |
|
ashimema[m] |
bug 24834 drew it to my attention |
11:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24834 enhancement, P5 - low, ---, katrin.fischer, Signed Off , Display report number after running |
11:54 |
|
oleonard |
It think it's a worthwhile issue to revisit, especially if we can find good info on current best practices |
11:54 |
|
ashimema[m] |
:) |
11:54 |
|
* ashimema[m] |
has no idea what current best practice is |
12:02 |
|
* oleonard |
is trying and failing to use curl to access the API... |
12:04 |
|
cait |
hm |
12:04 |
|
cait |
i am seeing something wierd when i put an item into manual transfer |
12:04 |
|
cait |
could someone check? |
12:05 |
|
cait |
the tabs from the detail view are showing up in the table |
12:06 |
|
oleonard |
Confirmed |
12:06 |
|
cait |
that should not be there... right? |
12:08 |
|
cait |
bug 26678 |
12:08 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26678 normal, P5 - low, ---, oleonard, NEW , When putting an item into manual transfer, tabs from detail view show in table |
12:09 |
|
oleonard |
http://git.koha-community.org/[…]83b7b3c55597710ef |
12:14 |
|
cait |
hm bug 24370 doesn't sound good |
12:14 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24370 major, P5 - low, ---, koha-bugs, NEW , Editing purchase suggestion changes the acquisition library to logged-in user's |
12:16 |
|
tcohen |
morning |
12:22 |
|
cait |
hi tcohen |
12:26 |
|
kohaputti |
oleonard, do you have basic auth enabled with REST API? Not sure if koha api issue or client library issue, but too long basic auth password will not work. |
12:26 |
|
oleonard |
How long is too long? |
12:27 |
|
kohaputti |
some length between 33 and 64 characters |
12:27 |
|
* oleonard |
thinks the problem may be that requests are getting redirected for some reason |
12:32 |
|
kohaputti |
you should see what's going on with -v option I think |
12:40 |
|
|
inlibro joined #koha |
12:58 |
|
huginn |
News from kohagit: Bug 12556: DBRev 20.06.00.051 <http://git.koha-community.org/[…]f5fe6e11fcedfbad4> |
12:58 |
|
huginn |
News from kohagit: Bug 19382: DBRev 20.06.00.050 <http://git.koha-community.org/[…]ed19e9a50d0a1ffd2> |
12:58 |
|
huginn |
News from kohagit: Bug 12556: Add missig POD for ->set_processing <http://git.koha-community.org/[…]ba151ef58bead91b3> |
12:58 |
|
huginn |
News from kohagit: Bug 19382: Adjust comment in test <http://git.koha-community.org/[…]2b2fbd5c41ed37e7c> |
12:58 |
|
huginn |
News from kohagit: Bug 19382: (QA follow-up) Fix typos <http://git.koha-community.org/[…]3815d029781ee1ebe> |
12:58 |
|
huginn |
News from kohagit: Bug 12556: (follow-up) Fix failing test <http://git.koha-community.org/[…]2e6c105b14505b556> |
12:58 |
|
huginn |
News from kohagit: Bug 12556: (QA follow-up) Fix QA Script failures <http://git.koha-community.org/[…]3d86e80e12eb003ce> |
12:58 |
|
huginn |
News from kohagit: Bug 26647: Add translation context to cancel hold button in OPAC <http://git.koha-community.org/[…]53b13e059bb9152e5> |
12:58 |
|
huginn |
News from kohagit: Bug 19353: Fix tests on UNIMARC <http://git.koha-community.org/[…]915cded46a7042326> |
12:58 |
|
huginn |
News from kohagit: Bug 19353: Use xslt from distribution, not packaged installed one <http://git.koha-community.org/[…]9e558196e2daf5de5> |
12:58 |
|
huginn |
News from kohagit: Bug 13625: Change messaging preferences descriptions according to RenewalSendNotice <http://git.koha-community.org/[…]90b85fc8168a9f769> |
12:58 |
|
huginn |
News from kohagit: Bug 19382: (follow-up) Alternate tests <http://git.koha-community.org/[…]ee95ac8ebaf2652f8> |
12:59 |
|
huginn |
News from kohagit: Bug 12556: Add new "in processing" state to holds <http://git.koha-community.org/[…]6e6c633fce22eb120> |
12:59 |
|
huginn |
News from kohagit: Bug 12556: Simplify and correct logic in holds-table.inc template <http://git.koha-community.org/[…]1b436f458589598f8> |
12:59 |
|
huginn |
News from kohagit: Bug 12556: reserves/request.pl: Reuse code from Koha::Hold <http://git.koha-community.org/[…]99435e3600f1eb768> |
12:59 |
|
huginn |
News from kohagit: Bug 12556: Reuse code from Koha::Hold instead of duplicating it <http://git.koha-community.org/[…]eaa7a8704aeddd691> |
12:59 |
|
huginn |
News from kohagit: Bug 12556: Remove unused HTML <http://git.koha-community.org/[…]0fe51d09c81368480> |
12:59 |
|
huginn |
News from kohagit: Bug 12556: Refactor hold transfer status setting to its own method <http://git.koha-community.org/[…]36015178a73d30ff0> |
12:59 |
|
huginn |
News from kohagit: Bug 19353: Add test <http://git.koha-community.org/[…]7a39b100bd0d9c52d> |
12:59 |
|
huginn |
News from kohagit: Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in... <http://git.koha-community.org/[…]a23d94af5f1532ffb> |
13:01 |
|
Joubu |
everybody: docker-compose pull! |
13:01 |
|
Joubu |
sysprefs.sql moved from installer/data/mysql/ to installer/data/mysql/mandatory |
13:02 |
|
kohaputti |
Joubu++ |
13:03 |
|
* kohaputti |
was nervous about the SIP2 hold notification delaying patches |
13:03 |
|
ashimema[m] |
:) |
13:05 |
|
ashimema[m] |
it checked out in my testing :) |
13:07 |
|
|
Dyrcona joined #koha |
13:10 |
|
lukeG1 |
Hi |
13:10 |
|
wahanui |
que tal, lukeG1 |
13:11 |
|
Joubu |
kohaputti: nervous because not confident? |
13:11 |
|
Joubu |
:D |
13:13 |
|
* cait |
feels discriminated against as a kohadevbox user ;) |
13:15 |
|
oleonard |
Cross over to the KTD side, cait! We're waiting! |
13:15 |
|
Joubu |
cait: update misc4dev ;) |
13:16 |
|
cait |
Joubu: every time i do that i have to manually fix my sip problem again... *cough* |
13:16 |
|
kohaputti |
Joubu, because I saw you changing the bug status one little thing at a time all throughout the day :D but yeah, also because the change ended up being quite big there might be something we have not caught in the review process. We have had 2 or 3 libraries using this now in production for a while so not too worried. |
13:16 |
|
cait |
whch means... i am commenting stuff for sip out because it breaks my reset_all |
13:16 |
|
cait |
it's really getting darker here... |
13:16 |
|
|
vfernandes joined #koha |
13:17 |
|
Joubu |
cait: commit your changes :) |
13:17 |
|
Joubu |
then rebase them on top of origin/master |
13:17 |
|
cait |
yes i do that |
13:17 |
|
cait |
but owul dlove for osmeone to do a proper fix |
13:17 |
|
cait |
my fix is killing stuff so it doesn't explode... and probably locks me out of nice sip testing |
13:18 |
|
* ashimema[m] |
is stuck.. this template plugin thing is weird |
13:19 |
|
* cait |
suggests asking oleonard |
13:19 |
|
* ashimema[m] |
has asked Joubu |
13:19 |
|
ashimema[m] |
the annoyance is.. the code works.. just the qa script fails |
13:19 |
|
ashimema[m] |
but I don't understand why |
13:20 |
|
* oleonard |
defers all qa script questions to Joubu :) |
13:20 |
|
Joubu |
yep sorry ashimema[m], the last push takes me more time than I expected |
13:21 |
|
ashimema[m] |
no worries |
13:24 |
|
magnuse |
@quote add cait> it's really getting darker here... |
13:24 |
|
huginn |
magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
13:24 |
|
magnuse |
@quote add cait> it's really getting darker here... |
13:24 |
|
huginn |
magnuse: The operation succeeded. Quote #343 added. |
13:24 |
|
magnuse |
@quote get 342 |
13:24 |
|
huginn |
magnuse: Quote #342: "oleonard: splitter is a mixed blessing. It tells you how much trouble you might be getting in but it doesn't tell you the odds." (added by tuxayo at 04:03 PM, July 09, 2020) |
13:24 |
|
|
Ambro joined #koha |
13:25 |
|
Ambro |
hi |
13:25 |
|
wahanui |
what's up, Ambro |
13:25 |
|
magnuse |
@quote get random |
13:25 |
|
huginn |
magnuse: Error: 'random' is not a valid id. |
13:25 |
|
magnuse |
@quote random |
13:25 |
|
huginn |
magnuse: Quote #75: "<jwagner> They do get over it though. Starting along about my 20s, the older I got the smarter my parents got :-)" (added by gmcharlt at 01:13 PM, May 18, 2010) |
13:26 |
|
Ambro |
I have a question regarding koha-testing-docker, may I ask ? |
13:28 |
|
caroline |
Ambro: ask and if someone knows the answer, they'll answer you |
13:29 |
|
Ambro |
thanks |
13:29 |
|
caroline |
btw hi everyone! :D |
13:29 |
|
tcohen |
hi caroline Ambro |
13:29 |
|
Ambro |
when launching the image with ku I get: koha_1 | Cannnot open file No such file or directory at /kohadevbox/misc4dev/cp_debian_files.pl line 35. |
13:30 |
|
Ambro |
everything else looks fine |
13:30 |
|
Ambro |
Docker on macos, latest. |
13:30 |
|
tcohen |
did you pull the latest image? |
13:31 |
|
magnuse |
huh, if i set PatronSelfRegistrationDefaultCategory to a categorycode, should patrons still get a dropdown with *all* possible categories when they self register? |
13:31 |
|
Ambro |
yes : 247401f73341 |
13:32 |
|
Ambro |
up to date with master @tcohen |
13:32 |
|
caroline |
magnuse: I think you have to remove the field with unwantedfields |
13:32 |
|
tcohen |
Ambro I'm downloading the latest image |
13:32 |
|
caroline |
the default category is just the default |
13:33 |
|
tcohen |
with docker-compose pull |
13:33 |
|
Joubu |
Ambro: check your KOHA_SYNC env var |
13:33 |
|
tcohen |
what does echo $KOHA_IMAGE |
13:33 |
|
tcohen |
return |
13:33 |
|
tcohen |
Joubu means SYNC_REPO |
13:33 |
|
Joubu |
tcohen: yes |
13:33 |
|
Joubu |
SYNC_REPO |
13:33 |
|
Joubu |
tcohen: https://gitlab.com/koha-commun[…]cker/-/issues/220 |
13:33 |
|
Joubu |
you should merge that ;) |
13:34 |
|
tcohen |
oh |
13:34 |
|
Ambro |
echo $SYNC_REPO /Users/a/Informatique/Koha/koha-testing-docker |
13:35 |
|
tcohen |
Ambro it should point to your Koha repo clone |
13:35 |
|
tcohen |
not koha-testing-docker |
13:35 |
|
Ambro |
@tcohen $KOHA_IMAGE is not set |
13:35 |
|
huginn |
Ambro: I've exhausted my database of quotes |
13:35 |
|
magnuse |
caroline: ok, thanks! |
13:35 |
|
tcohen |
Ambro its ok, it means you are using the master-stretch image |
13:36 |
|
tcohen |
I have it set to master-buster |
13:37 |
|
cait |
hm thinking about kohadevbox vs koha-testing-docker while doing the dishes... is it time to deprecate kohadevbox then? |
13:38 |
|
caroline |
magnuse: I don't know if that's how it *should* work, but that's how it works :) How it should work can be discussed infinitely |
13:38 |
|
Ambro |
So the error comes from SYNC_REPO not defined ? But this is defined in my case (though I use zsh) |
13:39 |
|
Ambro |
@tcohen, sorry just understood you answer |
13:39 |
|
huginn |
Ambro: I've exhausted my database of quotes |
13:39 |
|
cait |
i get people want to invest time in koha-testing-docker... we could add a note to the repo maybe and the pages. I think for exmple the descriptions on gitlab are not clear: This project aims to provide a dockered solution for running the Koha ILS tests inside Docker containers. vs. Uses Vagrant to set up a VirtualBox ready to do development and signoffs on the Koha project |
13:39 |
|
tcohen |
Ambro glad to hear |
13:40 |
|
|
inlibro joined #koha |
13:42 |
|
|
Dyrcona joined #koha |
13:43 |
|
tcohen |
cait the description is outdated |
13:43 |
|
koha-jenkins |
Project Koha_Master_D9 build #1451: UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_D9/1451/ |
13:43 |
|
tcohen |
I wrote it so we could run the test suite in different environments more easily |
13:43 |
|
cait |
i know |
13:43 |
|
tcohen |
and then it become... more interesting |
13:43 |
|
tcohen |
he |
13:43 |
|
cait |
it has evolved |
13:43 |
|
cait |
and we don't reflect htat |
13:44 |
|
Joubu |
tcohen: willing to merge that one as well? <3 https://gitlab.com/koha-commun[…]erge_requests/165 |
13:44 |
|
cait |
maybe the name oculd be better too now :) |
13:44 |
|
tcohen |
Joubu of course, it doens't apply cleanly, but also, can we keep the ${INSTANCE} |
13:44 |
|
cait |
if we want new people to start out on koha-testing-docker (and not get grumpy like me with stuff breaking) we should update these |
13:45 |
|
Joubu |
ha oops |
13:46 |
|
ashimema[m] |
I'll update the description cait |
13:46 |
|
tcohen |
cait I will support any effort on that route |
13:46 |
|
|
Dyrcona joined #koha |
13:46 |
|
Joubu |
tcohen volunteered to write a wiki page about koha-testing-docker |
13:46 |
|
cait |
at the moment i am stuck with dbic and reset_all broken |
13:46 |
|
Joubu |
(I have the logs!) |
13:46 |
|
cait |
which are 2 basic commands for people starting out testing |
13:46 |
|
tcohen |
Joubu++ |
13:46 |
|
cait |
so i evenutally will have to give in if noone helps me fix these... at least we can have new people not run inot that |
13:47 |
|
tcohen |
thye work for me |
13:47 |
|
cait |
they haven't worked for me in months |
13:47 |
|
tcohen |
dbic needs to be run outside kshell |
13:47 |
|
cait |
i now |
13:47 |
|
cait |
i know |
13:47 |
|
cait |
DBIx::Class::Schema::Loader::catch {...} (): Could not load loader_class "Koha::Schema::Loader::mysql": "{UNKNOWN}: Can't locate Koha/Schema/Loader/mysql.pm in @INC (you may need to install the Koha::Schema::Loader::mysql module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /us |
13:47 |
|
cait |
r/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /usr/share/perl5/Class/C3/Componentised.pm line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155 |
13:47 |
|
cait |
" at /usr/share/perl5/Try/Tiny.pm line 124 |
13:47 |
|
kohaputti |
cait, did you do the docker-compose pull that Joubu just mentioned hour or so ago. |
13:47 |
|
koha-jenkins |
Project Koha_Master_U20 build #115: STILL UNSTABLE in 48 min: https://jenkins.koha-community[…]a_Master_U20/115/ |
13:47 |
|
tcohen |
lets sort one at a time |
13:47 |
|
cait |
kohaputti: that's not a thing for kohadevbox :) |
13:48 |
|
koha-jenkins |
Project Koha_Master_U18 build #915: UNSTABLE in 47 min: https://jenkins.koha-community[…]a_Master_U18/915/ |
13:48 |
|
kohaputti |
ok, I thought you were in koha-testing-docker |
13:48 |
|
cait |
nope, that's why iI said we need to update documentation |
13:48 |
|
tcohen |
AH |
13:48 |
|
tcohen |
starting my old pal kohadevbox |
13:49 |
|
|
alex_a joined #koha |
13:50 |
|
* ashimema[m] |
watches his hopes of getting bug 24786 though QA today get dashed by a kohadevbox explosion |
13:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24786 enhancement, P5 - low, ---, martin.renvoize, Failed QA , Allow setting a cash register for a login session |
13:51 |
|
cait |
and the other issue is +#$cmd = "PERL5LIB=$PERL5LIB perl $misc_dir/setup_sip.pl --instance=$instance"; |
13:51 |
|
cait |
not working on reset_all |
13:51 |
|
cait |
ashimema[m]: i might be less grumpy overall... and that will be good for QA ;) |
13:52 |
|
cait |
also have to head to the supermarket for a bit - bbiab |
13:54 |
|
Joubu |
tcohen: make sure you are using the latest master (to fix all the things) |
13:54 |
|
koha-jenkins |
Project Koha_Master_D10 build #370: UNSTABLE in 54 min: https://jenkins.koha-community[…]a_Master_D10/370/ |
13:56 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #434: FAILURE in 2 min 23 sec: https://jenkins.koha-community[…]aster_D9_My8/434/ |
13:56 |
|
huginn |
News from kohagit: Bug 23895: Fix check_sysprefs.t <http://git.koha-community.org/[…]75bb90c0a96faae75> |
13:56 |
|
huginn |
News from kohagit: Bug 26595: Remove password from the smtp_server API object <http://git.koha-community.org/[…]fc20e8f8a6c8abd36> |
13:56 |
|
huginn |
News from kohagit: Bug 26595: Embed the whole smtp_server object <http://git.koha-community.org/[…]7ed6009a9a40bdbe3> |
13:56 |
|
huginn |
News from kohagit: Bug 17084: Automatic debian/control updates (master) <http://git.koha-community.org/[…]aa23730da1d87b303> |
13:56 |
|
huginn |
News from kohagit: Bug 26595: Add the option to hide the SMTP server column <http://git.koha-community.org/[…]f65b2ac8095f7b741> |
13:56 |
|
huginn |
News from kohagit: Bug 26595: Add SMTP server column to libraries table <http://git.koha-community.org/[…]0b8f6a80d39fc343b> |
13:56 |
|
huginn |
News from kohagit: Bug 26595: Add smtp_server_info embed option to /libraries <http://git.koha-community.org/[…]25af1fb7f25268ea7> |
13:57 |
|
huginn |
News from kohagit: Bug 26595: Add Koha::Library->smtp_server_info <http://git.koha-community.org/[…]27df6d3147c744301> |
13:57 |
|
cait |
tcohen: this is the reset_all issue: http://paste.koha-community.org/25742 |
13:57 |
|
* ashimema[m] |
is super happy to see so much cleaning up going on at the moment |
13:57 |
|
cait |
now really off |
13:58 |
|
ashimema[m] |
installer files being re-located to suitable places, Koha namespace migrations marching on, shebang lines being discussed, translation workflows being clarified |
13:58 |
|
ashimema[m] |
it's awesome |
13:58 |
|
ashimema[m] |
koha++ |
13:58 |
|
Joubu |
and so much left todo! :D |
13:59 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #409: FAILURE in 2 min 9 sec: https://jenkins.koha-community[…]9_MDB_Latest/409/ |
13:59 |
|
tcohen |
koha++ |
13:59 |
|
tcohen |
cleanup++ |
13:59 |
|
Joubu |
15:58:40 koha_1 | The environment variable SYNC_REPO is not defined. |
13:59 |
|
Joubu |
lol |
13:59 |
|
Joubu |
tcohen: I broke Jenkins |
14:00 |
|
Joubu |
but we have a nice error! |
14:00 |
|
ashimema[m] |
loads still to do.. but I'm soooo happy to see things moving in the right direction at a slightly heightened pace :) |
14:00 |
|
ashimema[m] |
we'll march on with it :) |
14:01 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #435: STILL FAILING in 2 min 11 sec: https://jenkins.koha-community[…]aster_D9_My8/435/ |
14:01 |
|
Ambro |
@tcohen, @all thanks a lot, it works great! need to dive into now |
14:01 |
|
huginn |
Ambro: I've exhausted my database of quotes |
14:03 |
|
ashimema[m] |
:) |
14:03 |
|
tcohen |
ashimema[m] yeah, its a great feeling! I share that |
14:03 |
|
koha-jenkins |
Project Koha_Master_D9 build #1452: FAILURE in 2 min 10 sec: https://jenkins.koha-community[…]a_Master_D9/1452/ |
14:05 |
|
koha-jenkins |
Project Koha_Master_U20 build #116: FAILURE in 2 min 15 sec: https://jenkins.koha-community[…]a_Master_U20/116/ |
14:07 |
|
koha-jenkins |
Project Koha_Master_D10 build #371: FAILURE in 2 min 19 sec: https://jenkins.koha-community[…]a_Master_D10/371/ |
14:09 |
|
koha-jenkins |
Project Koha_Master_U18 build #916: FAILURE in 1 min 26 sec: https://jenkins.koha-community[…]a_Master_U18/916/ |
14:12 |
|
Joubu |
tcohen: there is something very wrong |
14:12 |
|
Joubu |
Are not files/run.sh aware of the env var? |
14:12 |
|
Joubu |
I'm just realizing that all the vars we have in it are coming from the .env file |
14:14 |
|
Joubu |
tcohen: it must be in docker-compose.yml |
14:14 |
|
Joubu |
I am following up |
14:15 |
|
Joubu |
soooo, everything is broken for a bit, sorry! |
14:24 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #94: UNSTABLE in 40 min: https://jenkins.koha-community[…]ster_D10_Deps/94/ |
14:25 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #95: ABORTED in 39 sec: https://jenkins.koha-community[…]ster_D10_Deps/95/ |
14:25 |
|
koha-jenkins |
Project Koha_Master_D11 build #108: ABORTED in 37 min: https://jenkins.koha-community[…]a_Master_D11/108/ |
14:25 |
|
koha-jenkins |
Project Koha_Master_U16 build #84: ABORTED in 37 min: https://jenkins.koha-community[…]ha_Master_U16/84/ |
14:29 |
|
koha-jenkins |
Project Koha_Master_D11 build #109: FAILURE in 3 min 0 sec: https://jenkins.koha-community[…]a_Master_D11/109/ |
14:29 |
|
Joubu |
perl version? |
14:29 |
|
koha-jenkins |
Project Koha_Master_U2010 build #24: FAILURE in 3 min 48 sec: https://jenkins.koha-community[…]_Master_U2010/24/ |
14:30 |
|
koha-jenkins |
Project Koha_Master_U16 build #85: ABORTED in 4 min 32 sec: https://jenkins.koha-community[…]ha_Master_U16/85/ |
14:34 |
|
|
vfernandes joined #koha |
14:36 |
|
Joubu |
tcohen: still not good |
14:37 |
|
Joubu |
SYNC_REPO is not a dir in the container! |
14:39 |
|
Joubu |
tcohen: I reverted them 2 last commits |
14:40 |
|
koha-jenkins |
Project Koha_Master_D11 build #110: ABORTED in 5 min 0 sec: https://jenkins.koha-community[…]a_Master_D11/110/ |
14:41 |
|
|
inlibro joined #koha |
14:54 |
|
|
enkidu1 joined #koha |
15:03 |
|
reiveune |
bye |
15:03 |
|
|
reiveune left #koha |
15:10 |
|
|
fridolin left #koha |
15:11 |
|
|
cait joined #koha |
15:18 |
|
tcohen |
cait fixed your issues in kohadevbox :-D |
15:18 |
|
* tcohen |
loves cookies, you know... |
15:18 |
|
cait |
maybe i should grump-freak-out more often |
15:19 |
|
tcohen |
or try with cookies |
15:19 |
|
tcohen |
cogh cough |
15:20 |
|
cait |
thank you? |
15:23 |
|
|
koha-jenkins joined #koha |
15:26 |
|
|
koha-jenkins joined #koha |
15:29 |
|
cait |
tcohen++ |
15:29 |
|
ashimema[m] |
my brain hurts |
15:29 |
|
ashimema[m] |
reading my own code from a few months ago is painful |
15:29 |
|
|
vfernandes joined #koha |
15:34 |
|
koha-jenkins |
Project Koha_Master_D9 build #1453: STILL FAILING in 4 min 45 sec: https://jenkins.koha-community[…]a_Master_D9/1453/ |
15:36 |
|
tcohen |
been there, ashimema[m] |
15:36 |
|
tcohen |
hugs |
15:37 |
|
ashimema[m] |
hehe |
15:38 |
|
ashimema[m] |
you know that feeling when something just works.. but you no longer have a clue why? |
15:38 |
|
ashimema[m] |
that's the feeling I have right now whilst trying to write tests for it. |
15:41 |
|
|
inlibro joined #koha |
15:47 |
|
|
lukeG joined #koha |
15:58 |
|
cait |
oleonard: would you mind having a look at bug 26445? i thnk most of htat is javascript, but not sure - it could also end up somewhere else |
15:58 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26445 normal, P5 - low, ---, koha-bugs, NEW , Search results browser in staff has broken link back to results |
16:17 |
|
|
lukeG1 joined #koha |
16:18 |
|
koha-jenkins |
Project Koha_Master_D10 build #372: NOW UNSTABLE in 49 min: https://jenkins.koha-community[…]a_Master_D10/372/ |
16:20 |
|
koha-jenkins |
Yippee, build fixed! |
16:20 |
|
wahanui |
Congratulations! |
16:20 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #436: FIXED in 49 min: https://jenkins.koha-community[…]aster_D9_My8/436/ |
16:30 |
|
koha-jenkins |
Yippee, build fixed! |
16:30 |
|
wahanui |
Congratulations! |
16:30 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #410: FIXED in 1 hr 0 min: https://jenkins.koha-community[…]9_MDB_Latest/410/ |
16:35 |
|
|
lukeG joined #koha |
16:40 |
|
|
lukeG1 joined #koha |
16:41 |
|
|
inlibro joined #koha |
16:44 |
|
koha-jenkins |
Yippee, build fixed! |
16:44 |
|
wahanui |
Congratulations! |
16:44 |
|
koha-jenkins |
Project Koha_Master_D9 build #1454: FIXED in 52 min: https://jenkins.koha-community[…]a_Master_D9/1454/ |
17:03 |
|
koha-jenkins |
Yippee, build fixed! |
17:03 |
|
koha-jenkins |
Project Koha_Master_U20 build #117: FIXED in 42 min: https://jenkins.koha-community[…]a_Master_U20/117/ |
17:03 |
|
wahanui |
Congratulations! |
17:06 |
|
|
lukeG joined #koha |
17:07 |
|
koha-jenkins |
Yippee, build fixed! |
17:07 |
|
wahanui |
Congratulations! |
17:07 |
|
koha-jenkins |
Project Koha_Master_U18 build #917: FIXED in 48 min: https://jenkins.koha-community[…]a_Master_U18/917/ |
17:13 |
|
|
lisettelatah joined #koha |
17:31 |
|
oleonard |
Yes cait I'll look at 26445 |
17:39 |
|
|
enkidu joined #koha |
17:39 |
|
|
margaret joined #koha |
17:41 |
|
|
inlibro joined #koha |
17:43 |
|
* oleonard |
didn't get far |
17:54 |
|
koha-jenkins |
Yippee, build fixed! |
17:54 |
|
wahanui |
Congratulations! |
17:54 |
|
koha-jenkins |
Project Koha_Master_U2010 build #25: FIXED in 46 min: https://jenkins.koha-community[…]_Master_U2010/25/ |
18:19 |
|
|
enkidu joined #koha |
18:24 |
|
ashimema[m] |
Bug 26445 |
18:24 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26445 normal, P5 - low, ---, koha-bugs, NEW , Search results browser in staff has broken link back to results |
18:25 |
|
oleonard |
Seems to be a few months old at least. Going back any further broke Koha and I gave up |
18:26 |
|
* oleonard |
is just too tired of broken things today |
18:41 |
|
|
inlibro joined #koha |
18:45 |
|
|
kathryn joined #koha |
18:50 |
|
ashimema[m] |
what happened to bug 23388 oleonard? |
18:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23388 enhancement, P5 - low, ---, nick, Failed QA , Make system preferences links |
18:51 |
|
ashimema[m] |
were you still working on it.. feels like it just got lost somehow |
18:54 |
|
oleonard |
Yeah I never got it working well... I put it aside and haven't looked at it again |
18:54 |
|
ashimema[m] |
okies |
18:55 |
|
ashimema[m] |
the alternative one has just come back to life |
19:36 |
|
|
alexbuckley joined #koha |
19:41 |
|
|
cait joined #koha |
19:41 |
|
|
inlibro joined #koha |
19:42 |
|
cait |
oleonard++ thx for trying |
19:58 |
|
|
hayley joined #koha |
20:06 |
|
|
Dyrcona joined #koha |
20:22 |
|
|
enkidu joined #koha |
20:23 |
|
|
lukeG1 joined #koha |
20:27 |
|
|
lukeG joined #koha |
20:40 |
|
|
alexbuckley joined #koha |
20:42 |
|
|
inlibro joined #koha |
21:30 |
|
|
amoyano joined #koha |
21:42 |
|
|
inlibro joined #koha |
22:42 |
|
|
inlibro joined #koha |
23:10 |
|
dcook |
cait: You're working late :( |
23:13 |
|
cait |
not really working |
23:13 |
|
cait |
training my sleeping rhythm for kohacon ;) |
23:16 |
|
dcook |
heh |
23:16 |
|
dcook |
Fair |
23:23 |
|
dcook |
Ugh Koha::Z3950Responder::RPN... but at least I think I have a solution... |
23:31 |
|
|
tmcmahon joined #koha |
23:31 |
|
|
tmcmahon left #koha |
23:42 |
|
|
inlibro joined #koha |
23:46 |
|
dcook |
"POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666" |
23:46 |
|
dcook |
It's a new file! :@ |
23:48 |
|
dcook |
Oh unless.. |
23:49 |
|
dcook |
Nope no idea.. |
23:53 |
|
dcook |
Ugh, I think it's because the qa tools don't expect the file layout... |
23:56 |
|
cait |
if you have checked, you can ignore that one |
23:56 |
|
cait |
it tends to show false positives |
23:56 |
|
cait |
like when a sub is removed |
23:59 |
|
dcook |
The warning was misleading but I think I understood it in the end |
23:59 |
|
dcook |
I was trying to be clever and put some modules in a new "lib" folder, but I don't think it'll work in many cases |
23:59 |
|
dcook |
Like dev installs and such which expect PERL5LIB to point to the top level git repo |
23:59 |
|
* dcook |
really dislikes how the Koha source tree is laid out but c'est la vie |