Time |
S |
Nick |
Message |
00:14 |
|
|
inlibro joined #koha |
00:58 |
|
|
schnydszch joined #koha |
01:14 |
|
|
inlibro joined #koha |
02:02 |
|
|
wizzycray joined #koha |
02:15 |
|
|
inlibro joined #koha |
02:45 |
|
|
caroline joined #koha |
03:12 |
|
|
bigbrovar joined #koha |
03:15 |
|
|
inlibro joined #koha |
03:58 |
|
|
hayleymapley_ joined #koha |
04:15 |
|
|
inlibro joined #koha |
05:07 |
|
|
chriss joined #koha |
05:15 |
|
|
inlibro joined #koha |
05:27 |
|
|
josef_moravec joined #koha |
05:43 |
|
|
bigbrovar joined #koha |
06:12 |
|
|
did joined #koha |
06:15 |
|
|
inlibro joined #koha |
06:24 |
|
|
cait joined #koha |
06:34 |
|
|
lmstrand joined #koha |
06:39 |
|
|
saa joined #koha |
06:40 |
|
saa |
i wish to know is it possible to install new version of koha on 32bit still |
06:40 |
|
saa |
i am getting error of koha-perldeps : Depends: libmojolicious-plugin-openapi-perl but it is not going to be installed Depends: libnet-oauth2-authorizationserver-perl but it is not going to be installed |
06:40 |
|
saa |
can someone help to get it install |
06:41 |
|
saa |
i have to restore old 3.18 version backup on new version of koha on lubuntu 32 bit installation of OS |
06:43 |
|
|
reiveune joined #koha |
06:44 |
|
reiveune |
hello |
06:44 |
|
wahanui |
que tal, reiveune |
06:52 |
|
|
lds joined #koha |
06:53 |
|
|
lds joined #koha |
06:53 |
|
lds |
hello |
07:06 |
|
magnuse |
\o/ |
07:16 |
|
|
inlibro joined #koha |
07:21 |
|
dcook |
saa: I've been told that problem has been solved, so it's interesting that you're still having it |
07:22 |
|
dcook |
saa: Check https://bugs.koha-community.or[…]_bug.cgi?id=25886 |
07:22 |
|
dcook |
hola magnuse |
07:22 |
|
* dcook |
checks his timezones |
07:22 |
|
dcook |
Happy birthday magnuse :) |
07:23 |
|
* dcook |
heads home |
07:24 |
|
magnuse |
thanks, dcook (it was yesterday ;-) |
07:25 |
|
magnuse |
come on, you can do a patch for koha-sip --port before you leave! |
07:39 |
|
ashimema |
mornin' #koha |
07:52 |
|
magnuse |
hiya ashimema |
08:10 |
|
|
davidnind joined #koha |
08:16 |
|
|
inlibro joined #koha |
08:16 |
|
schnydszch |
hi all! |
08:16 |
|
schnydszch |
i |
08:16 |
|
schnydszch |
have some question re git bz. |
08:19 |
|
davidnind |
ask away, not sure I will know the answer though - someone might later |
08:22 |
|
schnydszch |
hmmm. getting this error: Traceback (most recent call last): |
08:22 |
|
schnydszch |
File "/usr/bin/git-bz", line 2699, in <module> |
08:22 |
|
schnydszch |
do_attach(*args) |
08:22 |
|
schnydszch |
after issuing ¨git bz attach -e 20200 HEAD¨ |
08:23 |
|
schnydszch |
already git committed my files |
08:23 |
|
schnydszch |
git add -> git commit |
08:27 |
|
davidnind |
I've only occasionally added a new one - just looking through my notes now... |
08:28 |
|
davidnind |
is there only one patch (commit) or are there more than one? |
08:29 |
|
davidnind |
From here it looks like you don't need the -e (could be wrong though!) => https://wiki.koha-community.or[…]gs_with_one_patch |
08:30 |
|
davidnind |
the logic I think is that you aren't editing anything yet on the bug, as there is nothing there yet |
08:33 |
|
schnydszch |
I have two files |
08:34 |
|
schnydszch |
without the -e parameter, getting error Traceback (most recent call last): |
08:34 |
|
schnydszch |
File "/usr/bin/git-bz", line 2699, in <module> |
08:34 |
|
schnydszch |
do_attach(*args) |
08:34 |
|
schnydszch |
File "/usr/bin/git-bz", line 2037, in do_attach |
08:34 |
|
schnydszch |
bug = Bug.load(handle) |
08:34 |
|
schnydszch |
File "/usr/bin/git-bz", line 1472, in load |
08:34 |
|
schnydszch |
bug._load(bug_reference.id, attachmentdata) |
08:34 |
|
schnydszch |
File "/usr/bin/git-bz", line 1228, in _load |
08:34 |
|
schnydszch |
response = self.server.send_request("GET", url) |
08:34 |
|
schnydszch |
File "/usr/bin/git-bz", line 998, in send_request |
08:34 |
|
schnydszch |
cookies = self.get_cookie_string() |
08:34 |
|
schnydszch |
File "/usr/bin/git-bz", line 991, in get_cookie_string |
08:34 |
|
schnydszch |
self.cookies = get_bugzilla_cookies(host) |
08:34 |
|
schnydszch |
NameError: global name 'host' is not defined |
08:36 |
|
davidnind |
if you have a look at you're git history, how many commits are there for the bug? |
08:37 |
|
davidnind |
are you using koha-testing-docker, or something else? |
08:38 |
|
schnydszch |
yes Iḿ using koha-testing docker |
08:38 |
|
magnuse |
global name 'host' is not defined <== this looks like a problem |
08:38 |
|
magnuse |
maybe check the config file? |
08:39 |
|
davidnind |
I'm assuming you bugzilla user name, email, password are setup correctly in your .env file |
08:39 |
|
schnydszch |
is that the .env of the koha-testing-docker magnuse? |
08:39 |
|
schnydszch |
yes davidnind, I have put the correct settings for email and password used in bugzilla |
08:40 |
|
schnydszch |
thereś no mail server set up with the server, Iḿ thinking if that is the problem? |
08:41 |
|
davidnind |
shouldn't be as it uses the internet, so you need to be able to access the internet from within koha-testing-docker (ping google.com) |
08:42 |
|
magnuse |
hm, there is no setting for bugzilla host here: https://gitlab.com/koha-commun[…]/env/defaults.env so i assume that is hard coded. dunno why it would be missing, then |
08:42 |
|
schnydszch |
i can ping google.com |
08:42 |
|
schnydszch |
64 bytes from 74.125.24.138 (74.125.24.138): icmp_seq=1 ttl=108 time=1.97 ms |
08:42 |
|
schnydszch |
64 bytes from 74.125.24.138 (74.125.24.138): icmp_seq=2 ttl=108 time=1.61 ms |
08:42 |
|
schnydszch |
64 bytes from 74.125.24.138 (74.125.24.138): icmp_seq=3 ttl=108 time=1.63 ms |
08:42 |
|
schnydszch |
64 bytes from 74.125.24.138 (74.125.24.138): icmp_seq=4 ttl=108 time=1.63 ms |
08:42 |
|
schnydszch |
64 bytes from 74.125.24.138 (74.125.24.138): icmp_seq=5 ttl=108 time=1.57 ms |
08:44 |
|
davidnind |
if you have GIT_BZ_PASSWORD and GIT_BZ_USER set in your .env file for KTD then you should be good |
08:46 |
|
schnydszch |
yes davidnind, i have those |
08:46 |
|
davidnind |
sorry schnydszch I've run out of ideas, maybe ashimema, Joubu or tcohen may be able to help when they are around |
08:46 |
|
|
fridolin joined #koha |
08:47 |
|
davidnind |
I'm assuming you have been able to sign off bugs in the past using git bz |
08:49 |
|
schnydszch |
only my first time davidnind |
08:51 |
|
davidnind |
jumping in the deep end!:) |
08:53 |
|
davidnind |
when did you setup koha-testing-docker? |
08:55 |
|
Joubu |
schnydszch: in ~/.gitconfig you should have a bz-tracker section, do you see it? |
08:59 |
|
schnydszch |
yes there is an existing one |
09:00 |
|
schnydszch |
user.name and user.email |
09:01 |
|
Joubu |
do you see your credential in bz-user and bz-password? |
09:09 |
|
Joubu |
schnydszch: also, which user do you use? kohadev-koha or root? |
09:09 |
|
schnydszch |
~/.gitconfig states my fullname and my email. bz-user and bz-password isn´t there |
09:12 |
|
schnydszch |
oopps ~/.gitconfig has nothing when issued while in devbox |
09:14 |
|
Joubu |
schnydszch: if your host is a linux distro you should configure git-bz on the host (it's more convenient to use your usual shell than the one from the docker container) |
09:14 |
|
Joubu |
if you want to use git-bz within the container you should use the root use (and having configured correctly your credential in the koha-testing-docker config file) |
09:15 |
|
Joubu |
root user* |
09:16 |
|
|
inlibro joined #koha |
09:17 |
|
davidnind |
schnydszch: how do you have things setup? I have a koha git clone locally, koha-testing-docker (KTD) setup and working (ku to start, Ctrl-C and then kd to close down), and doing things in KTD (use kshell to get into the container - these commands require the aliases to be setup and config so that it knows where your koha clone is) |
09:18 |
|
schnydszch |
and doing things in KTD (use kshell to get into the container - these commands require the aliases to be setup and config so that it knows where your koha clone is) -> maybe this thing I am missing |
09:18 |
|
schnydszch |
but I was able to get to shell, issuing this: docker exec -it koha_koha_1_a9b052fbb058 bash |
09:19 |
|
davidnind |
when I go git bz in the container I get this: Usage: git bz [add-url|apply|attach|components|edit|file|push] [options] |
09:20 |
|
schnydszch |
I have them when in container: Usage: git bz [add-url|apply|attach|components|edit|file|push] [options] |
09:20 |
|
davidnind |
if the aliases are setup you don't need to remember the really long commands! See https://gitlab.com/koha-commun[…]ting-docker#setup |
09:22 |
|
davidnind |
but I don't think that is what is causing your problem as you are in the container |
09:22 |
|
Joubu |
kidclamp: please catch me when you are around (about 5428) |
09:23 |
|
schnydszch |
yes Iḿ already in the container. I was able to add the aliases too, I just can issue kshell but was able to go to koha container through docker exec -it... |
09:26 |
|
Joubu |
schnydszch: try `git bz apply 12345` |
09:26 |
|
davidnind |
what do you get when you go git config --list - you should have several bz-tracker entries and bz.default entries as well |
09:26 |
|
|
cait joined #koha |
09:27 |
|
davidnind |
( I get 'No patches on bug 12345') |
09:29 |
|
|
magnuse joined #koha |
09:35 |
|
schnydszch |
I have this: rootkohadevbox:kohadevbox(master)$ git config --list |
09:35 |
|
schnydszch |
alias.s=!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter "cat && echo \" |
09:35 |
|
schnydszch |
Signed-off-by: schnydszch <eugenegfyahoo.com>\"" HEAD~$c^..; }; f |
09:35 |
|
schnydszch |
alias.so=!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter "cat && echo \" |
09:35 |
|
schnydszch |
Signed-off-by: schnydszch <eugenegfyahoo.com>\"" HEAD~$c^..; }; f |
09:35 |
|
schnydszch |
alias.sob=!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter "cat && echo \" |
09:35 |
|
schnydszch |
Signed-off-by: $2\"" HEAD~$c^..; }; f |
09:35 |
|
schnydszch |
alias.qa=!sh -c 'git fetch origin && git checkout origin/master && ( git checkout -b bug$1-qa origin/master || ( git branch -D bug$1-qa && git checkout -b bug$1-qa origin/master ) ) && git bz apply $1' - |
09:35 |
|
schnydszch |
alias.qa2=!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter "cat && echo \" |
09:35 |
|
schnydszch |
Signed-off-by: schnydszch <eugenegfyahoo.com>\"" HEAD~$c^..; }; f |
09:35 |
|
schnydszch |
alias.gr=log --graph --full-history --all --color --pretty=tformat:%x1b[31m%h%x09%x1b[32m%x1b[0m%x20%d%s%x20%x1b[33m(%an)%x1b[0m |
09:35 |
|
schnydszch |
alias.bza=!sh -c 'git bz attach -e $2 HEAD~$(($1 - 1)) && git bz attach $2 HEAD~$(($1 - 1))...HEAD' - |
09:35 |
|
schnydszch |
alias.bza2=!sh -c 'git bz attach $2 HEAD~$(($1 - 1))^..HEAD' - |
09:35 |
|
schnydszch |
alias.dqa=!sh -c 'git branch | cut -c3- | egrep ^bug.*-qa | xargs git branch -D' - |
09:35 |
|
schnydszch |
user.name=schnydszch |
09:35 |
|
schnydszch |
user.email=eugenegfyahoo.com |
09:35 |
|
schnydszch |
bz-tracker.bugs.koha-community.org.path=/bugzilla3 |
09:36 |
|
schnydszch |
bz-tracker.bugs.koha-community.org.https=true |
09:36 |
|
schnydszch |
bz-tracker.bugs.koha-community.org.bz-user=schnydszch |
09:36 |
|
schnydszch |
bz-tracker.bugs.koha-community.org.bz-password=password |
09:36 |
|
schnydszch |
core.whitespace=trailing-space,space-before-tab |
09:36 |
|
schnydszch |
apply.whitespace=fix |
09:36 |
|
schnydszch |
core.repositoryformatversion=0 |
09:36 |
|
schnydszch |
core.filemode=true |
09:36 |
|
schnydszch |
core.bare=false |
09:36 |
|
schnydszch |
core.logallrefupdates=true |
09:39 |
|
pastebot |
"davidnind" at 127.0.0.1 pasted "Here is my git config --list" (31 lines) at http://paste.koha-community.org/25153 |
09:41 |
|
davidnind |
I assuming your password for bugzilla isn't password... |
09:41 |
|
schnydszch |
yes. I just changed it |
09:41 |
|
davidnind |
cool |
09:42 |
|
schnydszch |
for sharing purpose, changed it to password hehe |
09:42 |
|
davidnind |
it looks like you are missing the bz.default-... entries |
09:49 |
|
pastebot |
"davidnind" at 127.0.0.1 pasted "my .env file for koha-testing-docker, it should match env/default.env plus your details for GIT... entries" (35 lines) at http://paste.koha-community.org/25154 |
09:49 |
|
davidnind |
I'm not sure how they get in there - it just works for me |
09:49 |
|
Joubu |
@later tell tcohen there is no patch on 25344 |
09:50 |
|
Joubu |
gmcharlt: huginn left us :-/ |
09:50 |
|
davidnind |
so to recap: koha-testing-docker is working fine, you get error messages when you try to add your patches to bugzilla for a single patch/commit (git bz attach XXXX HEAD) |
09:51 |
|
schnydszch |
yeah |
09:53 |
|
davidnind |
the error messages are here http://irc.koha-community.org/[…]0-08-12#i_2277077 |
09:56 |
|
davidnind |
so I'm still thinking what magnuse said (http://irc.koha-community.org/[…]0-08-12#i_2277101) that it is related to the host for bugzilla, and you have no entry similar to me for bz.default-... |
09:57 |
|
davidnind |
basically, git bz doesn't know where to put the patches |
09:58 |
|
davidnind |
I haven't done anything special or configured anything for bz, so don't know how the bz.default-... entries get in there |
10:01 |
|
davidnind |
so I'm all out of ideas, sorry schnydszch! |
10:02 |
|
schnydszch |
I added config settings |
10:02 |
|
schnydszch |
now Iḿ getting this: Attach? [yn] Y |
10:02 |
|
schnydszch |
fatal: ambiguous argument 'b942e62067a1a5b67a85f51fc52ef98fc83ec38a^..b942e62067a1a5b67a85f51fc52ef98fc83ec38a': unknown revision or path not in the working tree. |
10:04 |
|
Joubu |
It means that your range is not correct |
10:05 |
|
Joubu |
if you want to attach the last X patches, try git bz attach -e BUG_NUMBER HEAD~X.. |
10:11 |
|
|
bigbrovar joined #koha |
10:16 |
|
|
inlibro joined #koha |
10:23 |
|
schnydszch |
getting this Joubu: http://paste.koha-community.org/25156 |
10:27 |
|
Joubu |
replace X |
10:28 |
|
Joubu |
git bz attach -e 20200 HEAD~2.. # if you want to attach the last 2 patches |
10:29 |
|
davidnind |
patch = number of commits for your changes, if you only have one commit for your changes then HEAD~1.. (or just HEAD I think will work) |
10:35 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "rootkohadevbox:kohadevbox(mas" (36 lines) at http://paste.koha-community.org/25157 |
10:35 |
|
schnydszch |
got the following: http://paste.koha-community.org/25157 |
10:37 |
|
davidnind |
without the -e ? |
10:38 |
|
davidnind |
what is your git log --oneline ? |
10:39 |
|
schnydszch |
rootkohadevbox:kohadevbox(master)$ git log --oneline |
10:39 |
|
schnydszch |
b942e62 Bug 20200: Show MARC 770 Supplement/Special Issue Entry on detail pages Currently 770 is not shown in Koha on the detail pages. We should add the display of this field. |
10:40 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "git bz attach without the e" (36 lines) at http://paste.koha-community.org/25158 |
10:42 |
|
davidnind |
you only have one patch, so this should work: git bz attach 20200 HEAD |
10:42 |
|
schnydszch |
rootkohadevbox:kohadevbox(master)$ git bz attach 20200 HEAD |
10:42 |
|
schnydszch |
Bug 20200 - Show MARC 770 Supplement/Special Issue Entry on detail pages |
10:42 |
|
schnydszch |
b942e62 Bug 20200: Show MARC 770 Supplement/Special Issue Entry on detail pages Currently 770 is not shown in Koha on the detail pages. We should add the display of this field. |
10:42 |
|
schnydszch |
Attach? [yn] |
10:43 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "git bz attach error after y" (18 lines) at http://paste.koha-community.org/25159 |
10:43 |
|
schnydszch |
that is the error I got from git bz attach 20200 HEAD |
10:44 |
|
davidnind |
what does your git status show? |
10:45 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "git status show" (157 lines) at http://paste.koha-community.org/25160 |
10:46 |
|
schnydszch |
it seems the ones I git add and commit are not there? |
10:47 |
|
Joubu |
you have a weird line: Your branch is based on 'origin/master', but the upstream is gone. |
10:47 |
|
Joubu |
what returns git remote -v |
10:47 |
|
Joubu |
? |
10:47 |
|
Joubu |
do you see "origin"? |
10:47 |
|
schnydszch |
rootkohadevbox:kohadevbox(master)$ git remote -v |
10:47 |
|
schnydszch |
origin git://git.koha-community.org/koha.git (fetch) |
10:47 |
|
schnydszch |
origin git://git.koha-community.org/koha.git (push) |
10:47 |
|
schnydszch |
] |
10:47 |
|
Joubu |
ho but |
10:47 |
|
Joubu |
you are not in /kohadevbox/koha |
10:47 |
|
Joubu |
you are in /kohadevbox |
10:48 |
|
schnydszch |
oh |
10:49 |
|
davidnind |
Joubu++ |
10:50 |
|
|
aaru_swartz[m] joined #koha |
10:52 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "rootkohadevbox:koha(master)$" (296 lines) at http://paste.koha-community.org/25161 |
10:53 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "rootkohadevbox:koha(master)$" (303 lines) at http://paste.koha-community.org/25162 |
10:53 |
|
schnydszch |
getting different errors now |
10:54 |
|
davidnind |
progress :-D |
10:54 |
|
Joubu |
you are trying to attach 2 patches when, apparently, you have only 1 patch to attach |
10:55 |
|
Joubu |
70ff3ba Bug 26162: Wait for the table to be refreshed # this is part of master |
10:55 |
|
Joubu |
that's not the cause of the error |
10:55 |
|
Joubu |
"Bugzilla needs a legitimate login and password to continue." |
10:55 |
|
Joubu |
I think that's the problem (not sure however). Double check your credential |
10:57 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "rootkohadevbox:koha(master)$" (264 lines) at http://paste.koha-community.org/25163 |
10:57 |
|
schnydszch |
davidnind yes progress! :) |
11:00 |
|
davidnind |
test that you can login to bugzilla using the user id (email address) and password you had in your credentials (you should also assign the bug to your self (Assignee)) |
11:03 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "On branch master Your branch i" (4 lines) at http://paste.koha-community.org/25164 |
11:03 |
|
schnydszch |
looks like I missed up with my commits :( |
11:08 |
|
davidnind |
sorry, I don't know what you should do now (before making commits, I would normally create a branch for the bug you are working on and then make commits on that: git checkout -b bz20200) |
11:08 |
|
|
marcelr joined #koha |
11:08 |
|
marcelr |
hi #koha |
11:10 |
|
|
davidnind left #koha |
11:11 |
|
|
magnuse joined #koha |
11:14 |
|
|
AndrewFH joined #koha |
11:16 |
|
|
inlibro joined #koha |
11:18 |
|
|
khall joined #koha |
11:25 |
|
|
khall joined #koha |
11:26 |
|
|
bigbrovar joined #koha |
11:34 |
|
pastebot |
"schnydszch" at 127.0.0.1 pasted "rootkohadevbox:koha(master)$" (296 lines) at http://paste.koha-community.org/25165 |
11:34 |
|
schnydszch |
hmm.. Failed to attach patch to bug 20200, status=200 |
11:35 |
|
lmstrand |
well then it went ok :D |
11:38 |
|
schnydszch |
apparently not :( |
11:39 |
|
|
urra[m] joined #koha |
11:39 |
|
|
mtj[m] joined #koha |
11:39 |
|
|
tuxayo joined #koha |
11:39 |
|
|
black23[m] joined #koha |
11:39 |
|
|
ashimema[m] joined #koha |
11:39 |
|
|
SlackIntegration[m] joined #koha |
11:39 |
|
|
dpk joined #koha |
11:40 |
|
|
AndrewFH joined #koha |
11:41 |
|
kidclamp |
Updated 5428 joubu - we were looking at different ways to edit items in a batch |
11:57 |
|
|
henryb joined #koha |
11:57 |
|
Joubu |
kidclamp: so your patch is for deletion, not edition, right? |
11:59 |
|
Joubu |
kidclamp: it works for the "Return to the record" link but the button does not have the searchid |
12:00 |
|
tcohen |
morning |
12:00 |
|
|
khall joined #koha |
12:01 |
|
|
AndrewFH joined #koha |
12:02 |
|
Joubu |
kidclamp: nevermind, I will deal with that |
12:03 |
|
kidclamp |
it works for editing too, bot only from tjhe 'Edit' button, not selecting item |
12:04 |
|
henryb |
Hi everyone! I have a beginner's question. Do kohadevbox and koha-testing-docker do similar things? If you didn't know how to use either, which one would you start using? I'd like to start learning how to test and sign off patches without relying on the sandboxes but I'm not sure where to start. |
12:08 |
|
Joubu |
henryb: try koha-testing-docker, kohadevbox is not much used nowadays by developers |
12:13 |
|
henryb |
Thanks! |
12:16 |
|
|
inlibro joined #koha |
12:20 |
|
magnuse |
henryb++ |
12:25 |
|
schnydszch |
henryb, I am on koha-testing-docker |
12:46 |
|
|
cait joined #koha |
12:50 |
|
schnydszch |
follow up question, what should be the correct parameter for GIT BZ USERBAME in .env? my email address or my assigned username (schnydszch)? |
12:52 |
|
|
Marie-Luce joined #koha |
12:52 |
|
Joubu |
email address |
12:56 |
|
|
khall joined #koha |
13:00 |
|
schnydszch |
Thanks Joubu, magnuse, davidnind, dcook, kidclamp (through bywaters video)! Finally was able to make it work and attached my first patch :) |
13:00 |
|
ashimema[m] |
oleonard around? |
13:01 |
|
ashimema[m] |
@later tell oleonard any hints or tips on getting datatables headers aligned properly for bug 26160 would be greatly received.. I'm stuck :( |
13:04 |
|
schnydszch |
henryb, take a look at nicely done videos by Bywater here: https://bywatersolutions.com/e[…]ha-testing-docker and this one: https://www.youtube.com/watch?v=4c62it_qnSw as well as the various resources like for Koha Testing Docker here: https://gitlab.com/koha-commun[…]/master/README.md version control using git (https://wiki.koha-community.or[…]ontrol_Using_Git), the git book (https://git-scm.com/book/en/v2) |
13:04 |
|
schnydszch |
and koha git bz (https://wiki.koha-community.or[…]bz_configuration). |
13:07 |
|
magnuse |
schnydszch++ |
13:09 |
|
ashimema[m] |
hmm. |
13:09 |
|
ashimema[m] |
no @laters :( |
13:17 |
|
|
inlibro joined #koha |
13:24 |
|
caroline |
ashimema[m]: maybe if you change your handle to ashimema (without [m]) |
13:25 |
|
ashimema[m] |
damn it.. why oh why have I got the [m] back |
13:26 |
|
ashimema |
still there? |
13:26 |
|
wahanui |
rumour has it there is a monster under the bed |
13:26 |
|
ashimema |
@later tell oleonard any hints or tips on getting datatables headers aligned properly for bug 26160 would be greatly received.. I'm stuck :( |
13:26 |
|
ashimema |
whoami |
13:27 |
|
Joubu |
yup |
13:32 |
|
|
huginn joined #koha |
13:32 |
|
gmcharlt |
@quote random |
13:32 |
|
huginn |
gmcharlt: Quote #169: "<wizzyrea> sometimes the answer is just the answer... even if you don't like it ;)" (added by chris_n at 07:22 PM, December 06, 2011) |
13:33 |
|
henryb |
schnydszch: Thank you, I'll take a look! |
13:34 |
|
schnydszch |
welcome henryb! :) |
13:35 |
|
Joubu |
thanks gmcharlt! |
13:36 |
|
Joubu |
@later tell tcohen there is no patch on 25344 |
13:36 |
|
huginn |
Joubu: The operation succeeded. |
13:36 |
|
wahanui |
i already had it that way, Joubu. |
13:36 |
|
tcohen |
Joubu thanks |
13:36 |
|
tcohen |
fixing it |
13:40 |
|
|
cait joined #koha |
13:46 |
|
|
cait joined #koha |
13:57 |
|
Joubu |
dev meeting in less than 5min |
13:59 |
|
|
khall joined #koha |
13:59 |
|
|
AndrewFH joined #koha |
13:59 |
|
ashimema |
ooh.. dev meeting |
14:00 |
|
Joubu |
#startmeeting Development IRC meeting 12 August 2020 |
14:00 |
|
huginn |
Meeting started Wed Aug 12 14:00:05 2020 UTC. The chair is Joubu. Information about MeetBot at http://wiki.debian.org/MeetBot. |
14:00 |
|
huginn |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
14:00 |
|
|
Topic for #koha is now (Meeting topic: Development IRC meeting 12 August 2020) |
14:00 |
|
huginn |
The meeting name has been set to 'development_irc_meeting_12_august_2020' |
14:00 |
|
Joubu |
#topic Introductions |
14:00 |
|
|
Topic for #koha is now Introductions (Meeting topic: Development IRC meeting 12 August 2020) |
14:00 |
|
Joubu |
#link https://wiki.koha-community.or[…]ng_12_August_2020 |
14:00 |
|
Joubu |
#info Jonathan Druart |
14:00 |
|
marcelr |
#info Marcel de Rooy |
14:00 |
|
ashimema |
#info Martin Renvoize, PTFS Europe, UK |
14:01 |
|
Joubu |
hi marcelr, good to see you around :) |
14:01 |
|
marcelr |
:) |
14:01 |
|
Joubu |
rmaints? |
14:01 |
|
wahanui |
lukeG, aleisha, and tuxayo, I SUMMON THEE!! |
14:01 |
|
Joubu |
qa_team? |
14:01 |
|
wahanui |
qa_team is cait Joubu marcelr kohaputti josef_moravec tcohen kidclamp khall ashimema alex_a jajm matts |
14:01 |
|
kidclamp |
#info Nick Clemens |
14:01 |
|
wahanui |
i guess #info Nick Clemens is working on testing the circulations rules rewrite |
14:02 |
|
tcohen |
#info Tomas Cohen Arazi, Theke Solutions |
14:02 |
|
Joubu |
#topic Announcements |
14:02 |
|
|
Topic for #koha is now Announcements (Meeting topic: Development IRC meeting 12 August 2020) |
14:02 |
|
Joubu |
Anyone have something? |
14:02 |
|
ashimema |
It's too hot ;) |
14:02 |
|
tcohen |
SMTP is ready for testing |
14:03 |
|
ashimema |
bug number and link tcohen ;) |
14:03 |
|
tcohen |
bug 22343 |
14:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22343 new feature, P5 - low, ---, tomascohen, Needs Signoff , Add SMTP configuration options to Administration |
14:03 |
|
marcelr |
smtp is around for a while now :) |
14:03 |
|
Joubu |
# info bug 22343 is ready for testing (SMTP config) |
14:03 |
|
Joubu |
anything else? |
14:03 |
|
wahanui |
i guess anything else is necessarily going to be incremental. |
14:04 |
|
|
oleonard joined #koha |
14:04 |
|
Joubu |
hey oleonard! |
14:04 |
|
wahanui |
oleonard is, like, happy for ashimema to write the release script |
14:04 |
|
oleonard |
#info Owen Leonard, Athens County Public Library, Ohio, USA |
14:04 |
|
Joubu |
oleonard: do you have something to announce? |
14:04 |
|
marcelr |
any feedback on bug 24544 |
14:04 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24544 enhancement, P5 - low, ---, m.de.rooy, In Discussion , Add a script for inserting persistent identifiers to MARC records |
14:05 |
|
oleonard |
I would like to announce that I'm still looking for testers of Bug 20168 :) |
14:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20168 enhancement, P5 - low, ---, oleonard, Needs Signoff , Update of the OPAC bootstrap template to bootstrap v4 |
14:05 |
|
|
vfernandes joined #koha |
14:05 |
|
Joubu |
yes oleonard, that's a good one. I will get back to it |
14:06 |
|
Joubu |
#info Marcel sent an email about 24544 on the dev ML - more feedback welcome! |
14:06 |
|
ashimema |
generally it looked good oleonard.. I just didn't like the increase in default whitespace myself.. but that's likely a personal thing |
14:06 |
|
|
fridolin joined #koha |
14:06 |
|
Joubu |
#info Update from the Release manager (20.11) |
14:07 |
|
Joubu |
Everything goes well, but I'd like to see more big things tested |
14:07 |
|
Joubu |
we really need to focus *now* on those, to have them into master in the last couple of weeks |
14:07 |
|
Joubu |
max 1 month! |
14:07 |
|
Joubu |
you will make the RM happy if you track the RM priority list: https://frama.link/koha_bz_RM_priority |
14:07 |
|
marcelr |
and discourage things too big |
14:08 |
|
Joubu |
The main 3 things in the queue right now, that I really want for 20.11 are: |
14:08 |
|
Joubu |
bug 20168 |
14:08 |
|
Joubu |
bug 22417 |
14:08 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22417 new feature, P5 - low, ---, jonathan.druart, Signed Off , Add a task queue |
14:08 |
|
Joubu |
and, ofc bug 20271 |
14:08 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20271 enhancement, P1 - high, ---, jonathan.druart, Signed Off , Merge deleted biblio, biblioitems, biblio_metadata, and items tables |
14:09 |
|
Joubu |
#info Focus must be on bug 20168, bug 22417 and bug 20271 for the next couple of weeks |
14:09 |
|
Joubu |
#info Bookmark https://frama.link/koha_bz_RM_priority |
14:09 |
|
ashimema |
+1 |
14:09 |
|
Joubu |
any questions about those 3? |
14:10 |
|
Joubu |
any remarks, doubts? |
14:10 |
|
tcohen |
they need to be pushed ASAP :-D |
14:10 |
|
Joubu |
fears? |
14:10 |
|
marcelr |
20271 will have bugs.. |
14:10 |
|
marcelr |
so push fast |
14:10 |
|
Joubu |
yes |
14:10 |
|
oleonard |
tcohen: Some of them need patches ASAP then... |
14:11 |
|
tcohen |
I didn't find bugs in it |
14:11 |
|
marcelr |
when pushed we will :) |
14:11 |
|
Joubu |
yes did not, but there will be |
14:11 |
|
tcohen |
but yeah, statistically |
14:11 |
|
ashimema |
Tomas and I have given 20271 a fairly solid set of testing.. I think really we now need to push it to 'force' wider testing by devs in daily use |
14:11 |
|
Joubu |
so, actions maybe? |
14:11 |
|
Joubu |
volunteers? |
14:12 |
|
ashimema |
I have a few area's I'd like to play with in it.. like how quickly could we end up filling the table when using staged imports + rollbacks |
14:12 |
|
marcelr |
if two qaers had a look, just push now ? |
14:12 |
|
Joubu |
one more is always good |
14:12 |
|
ashimema |
I think we should stick to the current table names.. drop the views and work on a basic report migration + alert displayed in the reports area to get people updating their reports |
14:12 |
|
Joubu |
and I'd like to avoid bypass the QA step for such big changes |
14:13 |
|
ashimema |
I was hopeing cait would look at the import/rollback/matching stuff as they use it allot for their union cat |
14:14 |
|
Joubu |
"stick to the current tables", it's what we did, right? |
14:14 |
|
Joubu |
about the report warnings there is bug 25921 |
14:14 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25921 enhancement, P5 - low, ---, koha-bugs, NEW , Merge biblio* and items table - Update reports |
14:14 |
|
Joubu |
happy to collect ideas there |
14:15 |
|
ashimema |
great Joubu :) |
14:15 |
|
Joubu |
ok moving on if we don't get volunteering |
14:15 |
|
tcohen |
what about bug 25260? |
14:15 |
|
Joubu |
#info Updates from the Release Maintainers |
14:15 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25260 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Add a new 'holds' table |
14:15 |
|
tcohen |
its similar-ish |
14:16 |
|
ashimema |
I didn't find anything broken when working through the OPAC for bug 20168.. perhaps I should just set my SO on it at this point.. encourage the next step people |
14:16 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20168 enhancement, P5 - low, ---, oleonard, Needs Signoff , Update of the OPAC bootstrap template to bootstrap v4 |
14:16 |
|
Joubu |
yes ashimema! |
14:16 |
|
wahanui |
it has been said that ashimema is literally just writing up the release anouncement ;) |
14:16 |
|
marcelr |
tcohen holds versus reserves ? |
14:16 |
|
Joubu |
#action ashimema is going to add his stamp on 20168 |
14:17 |
|
|
inlibro joined #koha |
14:17 |
|
tcohen |
with amoyano we decided to try introducing a new table, for the same merge process |
14:17 |
|
marcelr |
ok it is a merge (title does not say that) |
14:18 |
|
Joubu |
yes it's the same idea as 20271 but for the *reserves tables |
14:19 |
|
Joubu |
no rmaints around, moving on |
14:19 |
|
Joubu |
#topic Updates from the QA team |
14:19 |
|
|
Topic for #koha is now Updates from the QA team (Meeting topic: Development IRC meeting 12 August 2020) |
14:19 |
|
marcelr |
come back cait |
14:20 |
|
Joubu |
NQA queue is quite ok with 78 bug reports (27 bugs) |
14:20 |
|
ashimema |
The queue is fairly high.. 78 NQA |
14:20 |
|
Joubu |
lol |
14:20 |
|
marcelr |
<100 |
14:20 |
|
Joubu |
different point of views :) |
14:20 |
|
ashimema |
less then 100 is good |
14:20 |
|
ashimema |
but I'd love to see us at 50 ;) |
14:20 |
|
Joubu |
less than 50 is better ;) |
14:21 |
|
ashimema |
a fair number fof 'Majors' in the pipe |
14:21 |
|
Joubu |
yes, good point |
14:21 |
|
ashimema |
5 majors waiting qa, 13 majors waiting for SO.. and loads without patches :( |
14:22 |
|
Joubu |
#info There is a bunch a major waiting for SO or QA, would be good to prioritize them |
14:22 |
|
ashimema |
If I can find a moment I will try to work through some of the ones missing patches |
14:22 |
|
Joubu |
I did a bit the last 2 weeks, but some are very hard |
14:22 |
|
Joubu |
or not that hard, but cannot be done easily |
14:22 |
|
ashimema |
yeah.. |
14:22 |
|
ashimema |
agreed.. some are evil |
14:23 |
|
Joubu |
#topic Actions from last meeting |
14:23 |
|
|
Topic for #koha is now Actions from last meeting (Meeting topic: Development IRC meeting 12 August 2020) |
14:23 |
|
Joubu |
#topic ashimema will get back to qa bug 15522 |
14:23 |
|
|
Topic for #koha is now ashimema will get back to qa bug 15522 (Meeting topic: Development IRC meeting 12 August 2020) |
14:23 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15522 enhancement, P5 - low, ---, jonathan.druart, Signed Off , New interface for revamped circulation rules |
14:23 |
|
Joubu |
do you want to update that ashimema? |
14:24 |
|
ashimema |
#info I've left a note on the bug.. I'm generally happy with the way it all works from an end user perspective.. We had the PTFS-E educators have a chat with the ByWater educators to work through it.. they're all happy. |
14:25 |
|
ashimema |
#info My next move is to start digging into the code.. I'd love to see a vue alternative submitted somewhere so we could do a comparison for code clarity between the two frameworks... |
14:25 |
|
ashimema |
#info This bug shouldn't be blocked by a lack of decision on framework.. but also feels like if it gets pushed as is, it makes the implicit decision for us. |
14:25 |
|
Joubu |
ashimema: I don't find your note |
14:25 |
|
Joubu |
which comment? |
14:26 |
|
ashimema |
144 |
14:26 |
|
ashimema |
I confirm the branch works |
14:26 |
|
Joubu |
ok |
14:26 |
|
Joubu |
"Written feedback here to follow." |
14:26 |
|
Joubu |
:) |
14:26 |
|
ashimema |
and confirm that we've been testing it rigorously.. |
14:26 |
|
ashimema |
the guys here are writing up their notes.. but the general consensus was it's a big improvement. |
14:27 |
|
ashimema |
tl:dr; still pushing hard on this one |
14:27 |
|
Joubu |
do you think you will have time to review the code soon? |
14:27 |
|
ashimema |
I hope I'll have some early next week |
14:28 |
|
Joubu |
#action ashimema is collecting notes about bug 15522 and is going to review and dig a bit more into the code |
14:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15522 enhancement, P5 - low, ---, jonathan.druart, Signed Off , New interface for revamped circulation rules |
14:28 |
|
ashimema |
though I have little experience with react.. I'm not sure we have anyone well placed to review that side :( |
14:28 |
|
Joubu |
#topic ashimema to propose a guideline ragarding using direction object notation rather than indirect object notation (postponed) |
14:28 |
|
|
Topic for #koha is now ashimema to propose a guideline ragarding using direction object notation rather than indirect object notation (postponed) (Meeting topic: Development IRC meeting 12 August 2020) |
14:28 |
|
Joubu |
did you write that guideline? |
14:29 |
|
ashimema |
Totally forgot about that one :( |
14:29 |
|
Joubu |
#action ashimema to propose a guideline ragarding using direction object notation rather than indirect object notation (postponed) |
14:29 |
|
marcelr |
"postponed" |
14:29 |
|
Joubu |
#topic tuxayo integrate the RMaint-handover-draft into the "release maintenance" wiki page |
14:29 |
|
|
Topic for #koha is now tuxayo integrate the RMaint-handover-draft into the "release maintenance" wiki page (Meeting topic: Development IRC meeting 12 August 2020) |
14:29 |
|
marcelr |
thats what it is |
14:30 |
|
Joubu |
not done |
14:30 |
|
Joubu |
#action tuxayo integrate the RMaint-handover-draft into the "release maintenance" wiki page (postponed) |
14:30 |
|
Joubu |
#topic davidnind Find and update relevant places to record Perl version required, including release notes, manual and wiki (one source of the truth): update - still working on this |
14:30 |
|
|
Topic for #koha is now davidnind Find and update relevant places to record Perl version required, including release notes, manual and wiki (one source of the truth): update - still working on this (Meeting topic: Development IRC meeting 12 August 2020) |
14:30 |
|
Joubu |
certainly too late for Dvic |
14:30 |
|
Joubu |
oops David |
14:31 |
|
Joubu |
#action davidnind Find and update relevant places to record Perl version required, including release notes, manual and wiki (one source of the truth): update - still working on this (postponed) |
14:31 |
|
Joubu |
#topic General development discussion (trends, ideas, ...) |
14:31 |
|
|
Topic for #koha is now General development discussion (trends, ideas, ...) (Meeting topic: Development IRC meeting 12 August 2020) |
14:31 |
|
Joubu |
Something not on the agenda you would like to discuss? |
14:32 |
|
Joubu |
3, 2, 1? |
14:32 |
|
Joubu |
#topic Set time of next meeting |
14:32 |
|
|
Topic for #koha is now Set time of next meeting (Meeting topic: Development IRC meeting 12 August 2020) |
14:33 |
|
Joubu |
#info Next meeting: 26 August 2020, 14 UTC |
14:33 |
|
Joubu |
we did not get much attender in the last 19 UTC |
14:34 |
|
Joubu |
so no sure if we should stick to 19 or 20 or 21? |
14:35 |
|
Joubu |
#info If you prefer another hour of the meeting, like 19, 20, 21, please contact Joubu on IRC and we will modify it |
14:35 |
|
Joubu |
#endmeeting |
14:35 |
|
|
Topic for #koha is now Welcome to #koha this channel is for discussion of the Koha project and software https://koha-community.org |
14:35 |
|
huginn |
Meeting ended Wed Aug 12 14:35:16 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
14:35 |
|
huginn |
Minutes: https://meetings.koha-communit[…]-08-12-14.00.html |
14:35 |
|
huginn |
Minutes (text): https://meetings.koha-communit[…]0-08-12-14.00.txt |
14:35 |
|
huginn |
Log: https://meetings.koha-communit[…]12-14.00.log.html |
14:35 |
|
ashimema |
happy to try 20/21.. though I tend to be challenged with kids/tiredness at that time |
14:35 |
|
ashimema |
Joubu++ |
14:35 |
|
oleonard |
Joubu++ |
14:35 |
|
tcohen |
Joubu++ |
14:36 |
|
Joubu |
same here ashimema, 20,21 is too late for me |
14:37 |
|
Joubu |
oleonard: could you have a look at the few comments I let you? |
14:38 |
|
oleonard |
In Bugzilla? I'm working my way through emails slowly. Working the circulation desk too so I'm distracted today. |
14:40 |
|
|
wizzycray joined #koha |
14:40 |
|
Joubu |
https://bugs.koha-community.or[…]g.cgi?id=21345#c8 |
14:40 |
|
huginn |
Bug 21345: enhancement, P5 - low, ---, oleonard, Passed QA , Patron records with attached files not obvious from patron details view |
14:41 |
|
Joubu |
https://bugs.koha-community.or[…]g.cgi?id=26091#c5 |
14:41 |
|
huginn |
Bug 26091: enhancement, P5 - low, ---, oleonard, Passed QA , Add column configuration and export options to catalog statistics report |
14:41 |
|
Joubu |
https://bugs.koha-community.or[…]g.cgi?id=26008#c4 |
14:41 |
|
huginn |
Bug 26008: enhancement, P5 - low, ---, oleonard, Passed QA , Remove the use of jquery.checkboxes plugin from OPAC cart |
14:56 |
|
caroline |
oleonard: did you manage to make that notice from yesterday? |
14:59 |
|
oleonard |
caroline: I tried once and then moved on :) |
15:00 |
|
oleonard |
caroline: I hoped that [% FOREACH branch IN branches %] would work but it didn't |
15:00 |
|
caroline |
yeah I tried it too (I was curious) |
15:00 |
|
caroline |
did you simply hardcode the phone numbers in the notice? |
15:03 |
|
Joubu |
[% USE Branches %] [% SET libraries = Branches.all %] should do the job |
15:08 |
|
caroline |
and then you do [% FOREACH branch IN libraries %]? |
15:09 |
|
|
lisettelatah joined #koha |
15:09 |
|
ashimema |
correct |
15:11 |
|
|
schnydszch joined #koha |
15:12 |
|
oleonard |
Oh cool, thanks Joubu |
15:12 |
|
oleonard |
caroline: It came up because we had the phone numbers hardcoded and then of course a number changed and I forgot to update the notice |
15:14 |
|
ashimema |
bug 26194 SO'd.. thanks for that one oleonard.. nice little enhancement |
15:14 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26194 enhancement, P5 - low, ---, oleonard, Signed Off , Messages about missing cash registers should link to cash register management |
15:16 |
|
oleonard |
You're welcome ashimema :) |
15:16 |
|
* oleonard |
bbiab |
15:17 |
|
|
inlibro joined #koha |
15:18 |
|
ashimema |
minor styling comment added though.. I think the alert should continue to be an 'alert' (i.e. yellow) and the button looks devoid of our usual styling. |
15:27 |
|
|
fridolin left #koha |
15:27 |
|
|
cait joined #koha |
16:02 |
|
reiveune |
bye |
16:02 |
|
|
reiveune left #koha |
16:17 |
|
|
inlibro joined #koha |
16:36 |
|
|
cait joined #koha |
16:36 |
|
|
cait joined #koha |
17:13 |
|
|
dpk joined #koha |
17:17 |
|
|
inlibro joined #koha |
17:42 |
|
|
did joined #koha |
17:47 |
|
|
oleonard joined #koha |
17:48 |
|
oleonard |
Hello again #koha |
17:57 |
|
|
did joined #koha |
18:17 |
|
|
inlibro joined #koha |
18:43 |
|
kidclamp |
hi oleonard |
18:43 |
|
wahanui |
hi oleopard |
18:43 |
|
oleonard |
How's it going kidclamp? |
18:44 |
|
kidclamp |
it goes well, if a bit warm |
18:44 |
|
kidclamp |
how are you? |
18:44 |
|
oleonard |
All of us at home are stressing out about school starting :( |
18:45 |
|
* kidclamp |
nods |
18:45 |
|
oleonard |
Online for the first 9 weeks. |
18:45 |
|
kidclamp |
we have half days |
18:47 |
|
|
cait joined #koha |
18:47 |
|
oleonard |
Both options are bad :( |
18:48 |
|
kidclamp |
all options are the worst |
18:50 |
|
|
cait joined #koha |
19:04 |
|
|
cait joined #koha |
19:04 |
|
|
lukeG joined #koha |
19:10 |
|
|
cait joined #koha |
19:18 |
|
|
inlibro joined #koha |
19:18 |
|
|
josef_moravec joined #koha |
19:18 |
|
|
cait joined #koha |
19:22 |
|
|
ashimema joined #koha |
19:25 |
|
|
cait joined #koha |
19:30 |
|
ashimema |
. |
19:31 |
|
|
khall joined #koha |
19:34 |
|
ashimema |
Evening |
19:37 |
|
|
cait joined #koha |
19:40 |
|
|
khall_ joined #koha |
19:55 |
|
oleonard |
ashimema: The point of sale interface is a real puzzle |
19:55 |
|
ashimema |
? |
19:55 |
|
ashimema |
In what way? |
19:57 |
|
ashimema |
Oh, do you mean the data table header issue in having |
19:58 |
|
ashimema |
It's the embedding withing a fieldset with a row class |
19:58 |
|
oleonard |
Yeah... It also feels weird to me the way the three sections are laid out. But I don't know how to make it work better. |
19:58 |
|
ashimema |
If I do the row bit it sure a bit better |
19:58 |
|
ashimema |
But then the rest isn't consistent with elsewhere |
19:59 |
|
ashimema |
The the section layout was basically taken from a bunch of examples of point of sale systems I found googling.. |
19:59 |
|
ashimema |
More than happy if anyone can come up with a nicer approach |
20:02 |
|
|
cait joined #koha |
20:05 |
|
oleonard |
I considered removing the <fieldset>s... also simplifying the DataTable configuration... but still clunky |
20:05 |
|
oleonard |
https://zivotdesign.com/p/#1/15972626787761 |
20:06 |
|
oleonard |
I also wonder if we could put the "collect payment" form into a modal so that it could be 2 columns until it was time to pay |
20:07 |
|
oleonard |
...but people hate extra clicks |
20:07 |
|
|
lisettelatah joined #koha |
20:10 |
|
|
cait joined #koha |
20:18 |
|
|
inlibro joined #koha |
20:18 |
|
ashimema |
Interesting ideas |
20:19 |
|
ashimema |
I wondered about moving money collection to a modal in general.. one that could replace paycollect |
20:19 |
|
ashimema |
And here too |
20:48 |
|
|
aleisha_ joined #koha |
20:49 |
|
|
hayley joined #koha |
21:05 |
|
|
alexbuckley joined #koha |
21:06 |
|
|
alexbuckley joined #koha |
21:09 |
|
|
kathryn_ joined #koha |
21:18 |
|
|
inlibro joined #koha |
21:18 |
|
|
khall joined #koha |
21:48 |
|
|
cait joined #koha |
21:59 |
|
|
aleisha joined #koha |
22:18 |
|
|
inlibro joined #koha |
22:26 |
|
|
kathryn joined #koha |
22:39 |
|
|
dcook_ joined #koha |
22:44 |
|
|
did joined #koha |
22:52 |
|
|
tosca joined #koha |
23:12 |
|
|
dcook_ joined #koha |
23:18 |
|
|
inlibro joined #koha |