| Time |
S |
Nick |
Message |
| 00:14 |
|
|
alexbuckley joined #koha |
| 00:35 |
|
koha-jenkins |
Project Koha_19.11_D8 build #188: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_19.11_D8/188/ |
| 00:36 |
|
koha-jenkins |
Project Koha_19.11_U18 build #184: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_19.11_U18/184/ |
| 00:41 |
|
|
inlibro joined #koha |
| 00:43 |
|
koha-jenkins |
Project Koha_19.11_D9 build #187: SUCCESS in 46 min: https://jenkins.koha-community[…]oha_19.11_D9/187/ |
| 01:06 |
|
|
hayley joined #koha |
| 01:17 |
|
koha-jenkins |
Project Koha_19.11_D8 build #189: UNSTABLE in 41 min: https://jenkins.koha-community[…]oha_19.11_D8/189/ |
| 01:18 |
|
koha-jenkins |
Project Koha_19.11_U18 build #185: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_19.11_U18/185/ |
| 01:30 |
|
koha-jenkins |
Project Koha_19.11_D9 build #188: SUCCESS in 47 min: https://jenkins.koha-community[…]oha_19.11_D9/188/ |
| 01:41 |
|
|
inlibro joined #koha |
| 02:09 |
|
koha-jenkins |
Project Koha_19.11_D10 build #22: UNSTABLE in 51 min: https://jenkins.koha-community[…]oha_19.11_D10/22/ |
| 02:28 |
|
|
irma joined #koha |
| 02:29 |
|
|
BobB joined #koha |
| 02:41 |
|
|
inlibro joined #koha |
| 03:11 |
|
koha-jenkins |
Yippee, build fixed! |
| 03:11 |
|
wahanui |
Congratulations! |
| 03:11 |
|
koha-jenkins |
Project Koha_19.11_D10 build #23: FIXED in 42 min: https://jenkins.koha-community[…]oha_19.11_D10/23/ |
| 03:11 |
|
koha-jenkins |
Project Koha_19.11_D8 build #190: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]oha_19.11_D8/190/ |
| 03:15 |
|
koha-jenkins |
Project Koha_19.11_U18 build #186: SUCCESS in 45 min: https://jenkins.koha-community[…]ha_19.11_U18/186/ |
| 03:41 |
|
|
inlibro joined #koha |
| 03:50 |
|
koha-jenkins |
Yippee, build fixed! |
| 03:50 |
|
wahanui |
Congratulations! |
| 03:50 |
|
koha-jenkins |
Project Koha_19.11_D8 build #191: FIXED in 35 min: https://jenkins.koha-community[…]oha_19.11_D8/191/ |
| 03:56 |
|
koha-jenkins |
Project Koha_19.11_D9 build #189: SUCCESS in 45 min: https://jenkins.koha-community[…]oha_19.11_D9/189/ |
| 04:02 |
|
dcook |
Bug 16357 |
| 04:02 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16357 normal, P3, ---, mtj, Needs Signoff , Plack error logs are not time stamped |
| 04:02 |
|
koha-jenkins |
Project Koha_19.11_D10 build #24: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_19.11_D10/24/ |
| 04:12 |
|
|
did joined #koha |
| 04:34 |
|
koha-jenkins |
Project Koha_19.11_D8 build #192: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_19.11_D8/192/ |
| 04:38 |
|
koha-jenkins |
Project Koha_19.11_U18 build #187: SUCCESS in 47 min: https://jenkins.koha-community[…]ha_19.11_U18/187/ |
| 04:42 |
|
|
inlibro joined #koha |
| 04:57 |
|
koha-jenkins |
Project Koha_19.11_D9 build #190: SUCCESS in 54 min: https://jenkins.koha-community[…]oha_19.11_D9/190/ |
| 05:08 |
|
|
chriss joined #koha |
| 05:12 |
|
koha-jenkins |
Project Koha_19.11_D8 build #193: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_19.11_D8/193/ |
| 05:16 |
|
koha-jenkins |
Project Koha_19.11_D10 build #25: SUCCESS in 42 min: https://jenkins.koha-community[…]oha_19.11_D10/25/ |
| 05:34 |
|
|
andreashm joined #koha |
| 05:42 |
|
|
inlibro joined #koha |
| 05:50 |
|
koha-jenkins |
Project Koha_19.11_U18 build #188: SUCCESS in 53 min: https://jenkins.koha-community[…]ha_19.11_U18/188/ |
| 05:59 |
|
koha-jenkins |
Project Koha_19.11_D9 build #191: SUCCESS in 46 min: https://jenkins.koha-community[…]oha_19.11_D9/191/ |
| 06:25 |
|
|
alexbuckley joined #koha |
| 06:38 |
|
|
reiveune joined #koha |
| 06:38 |
|
reiveune |
hello |
| 06:39 |
|
|
sophie_m joined #koha |
| 06:39 |
|
|
fridolin joined #koha |
| 06:40 |
|
fridolin |
hi there |
| 06:41 |
|
|
alex_a joined #koha |
| 06:42 |
|
alex_a |
Bonjour |
| 06:42 |
|
|
inlibro joined #koha |
| 06:50 |
|
|
andreashm joined #koha |
| 06:52 |
|
|
cait joined #koha |
| 06:55 |
|
|
alexbuckley joined #koha |
| 06:57 |
|
|
andreashm joined #koha |
| 06:58 |
|
|
andreashm joined #koha |
| 07:14 |
|
|
cait joined #koha |
| 07:19 |
|
|
cait1 joined #koha |
| 07:27 |
|
magnuse |
\o/ |
| 07:39 |
|
cait1 |
lukeG: please don't ignore string freeze :( You pushed a bunch of new strings after 22nd that now cannot be translated for the 20.05.01 release. |
| 07:41 |
|
cait1 |
argh, after 15th |
| 07:41 |
|
cait1 |
it's 22nd now |
| 07:42 |
|
|
inlibro joined #koha |
| 08:00 |
|
|
fridolin left #koha |
| 08:17 |
|
|
fridolin joined #koha |
| 08:39 |
|
|
TimothyAlexis joined #koha |
| 08:42 |
|
|
inlibro joined #koha |
| 08:53 |
|
TimothyAlexis |
Is there a job to clear obsolete fines? |
| 08:58 |
|
TimothyAlexis |
Also, I see there is a "lastseen" field of type date in the Borrowers table, however each entry has the value NULL. Is this field supposed to log "last login" ? |
| 09:03 |
|
|
sophie_m joined #koha |
| 09:38 |
|
|
alex_a joined #koha |
| 09:42 |
|
|
inlibro joined #koha |
| 09:59 |
|
fridolin |
small typo in master : Bug 25839 |
| 09:59 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25839 major, P5 - low, ---, fridolin.somers, Needs Signoff , Typo patron.streetype in member-main-address-style.inc |
| 10:00 |
|
fridolin |
breaks patrons creation |
| 10:04 |
|
|
alexbuckley joined #koha |
| 10:30 |
|
|
cait joined #koha |
| 10:40 |
|
|
khall joined #koha |
| 10:43 |
|
|
inlibro joined #koha |
| 10:53 |
|
|
TimothyAlexis joined #koha |
| 10:53 |
|
|
TimothyAlexis_ joined #koha |
| 10:54 |
|
TimothyAlexis_ |
I've found the details for the "lastseen" field. |
| 10:54 |
|
TimothyAlexis_ |
The other question remains. :) |
| 10:58 |
|
|
davidnind left #koha |
| 11:04 |
|
|
khall joined #koha |
| 11:15 |
|
|
khall_ joined #koha |
| 11:15 |
|
|
cait joined #koha |
| 11:19 |
|
|
TimothyAlexis joined #koha |
| 11:21 |
|
|
fridolin joined #koha |
| 11:43 |
|
|
inlibro joined #koha |
| 11:51 |
|
|
khall joined #koha |
| 11:58 |
|
tuxayo |
hi #koha o/ |
| 11:58 |
|
tuxayo |
wizzycray: or gmcharlt around? |
| 12:04 |
|
oleonard |
hi #koha o/ |
| 12:05 |
|
TimothyAlexis |
hello |
| 12:11 |
|
tuxayo |
First step of the release: the translations "export" tells me « |
| 12:11 |
|
tuxayo |
Translation project for v19.05 does not exist!» |
| 12:12 |
|
tuxayo |
:< |
| 12:13 |
|
tuxayo |
Good, it was just a mistake, I should have wrote 19.05.12 instead of v19.05.12 |
| 12:14 |
|
tuxayo |
pfiou |
| 12:17 |
|
tcohen |
motninh |
| 12:19 |
|
TimothyAlexis |
Is there a Koha job to clean up the fines log? |
| 12:31 |
|
oleonard |
fridolin around? |
| 12:32 |
|
magnuse |
TimothyAlexis: have you looked at the cleanup_database.pl cronjob? |
| 12:32 |
|
fridolin |
oleonard: yes |
| 12:33 |
|
oleonard |
Hi, I was looking at Bug 25839 |
| 12:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25839 major, P5 - low, ---, fridolin.somers, Needs Signoff , Typo patron.streetype in member-main-address-style.inc |
| 12:33 |
|
magnuse |
TimothyAlexis: the scope of that script has been expanded quite a lot in the latest version (or the one before?) |
| 12:33 |
|
oleonard |
I noticed there are other instances of the incorrect string "streetype" being used. I wonder if those should be corrected too |
| 12:34 |
|
oleonard |
fridolin, I know those instances are part of the same problem, but perhaps for consistency? |
| 12:35 |
|
TimothyAlexis |
magnuse Thank you for the suggestion, now I know where to look. |
| 12:43 |
|
|
inlibro joined #koha |
| 12:48 |
|
tcohen |
ok, 4G, internet is unreliable ATM |
| 12:50 |
|
fridolin |
oleonard: indeed, there is a var |
| 12:51 |
|
fridolin |
oleonard: create a new bug i'd say |
| 12:53 |
|
oleonard |
Okay |
| 12:54 |
|
fridolin |
oleonard: tell me its number when created ;) |
| 12:58 |
|
oleonard |
fridolin: Bug 25842 |
| 12:58 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25842 major, P5 - low, ---, fridolin.somers, NEW , Typo "streetype" in member-main-address-style.inc |
| 12:58 |
|
ashimema |
oleonard shouldn't adaptive css for veiwport also come into play for high zoom levels on desktop? |
| 12:59 |
|
* ashimema |
is looking at bug 25242 |
| 12:59 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25242 enhancement, P5 - low, ---, oleonard, NEW , Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom |
| 13:06 |
|
ashimema |
ever thought about doing something like https://css-tricks.com/responsive-data-tables/ for tables in the OPAC for better mobile support ? |
| 13:08 |
|
oleonard |
In fact I have done so :) But it doesn't seem to kick in until a narrower view than what the bug describes |
| 13:09 |
|
oleonard |
There is also this we might consider https://datatables.net/extensions/responsive/ |
| 13:10 |
|
|
khall joined #koha |
| 13:11 |
|
tcohen |
is bug 25288 pushed already? |
| 13:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25288 enhancement, P5 - low, ---, tomascohen, Passed QA , Make the libraries list use the API |
| 13:11 |
|
fridolin |
https://gitlab.com/koha-commun[…]release-tools.git |
| 13:13 |
|
ashimema |
Thanks oleonard |
| 13:16 |
|
|
JesseM joined #koha |
| 13:22 |
|
|
wizzyrea joined #koha |
| 13:26 |
|
|
kivilahtio joined #koha |
| 13:27 |
|
|
lari joined #koha |
| 13:42 |
|
|
khall_ joined #koha |
| 13:43 |
|
|
inlibro joined #koha |
| 13:46 |
|
gmcharlt |
tuxayo: still need help with something? |
| 13:50 |
|
* oleonard |
waves to gmcharlt |
| 13:50 |
|
* gmcharlt |
waves back |
| 13:50 |
|
tcohen |
\o |
| 13:52 |
|
|
khall joined #koha |
| 13:53 |
|
|
andreashm joined #koha |
| 13:54 |
|
|
andreashm joined #koha |
| 13:55 |
|
|
andreashm joined #koha |
| 13:55 |
|
ashimema |
cait... you've well and truly knocked me off top spot over the weeken |
| 13:55 |
|
|
andreashm joined #koha |
| 13:56 |
|
tuxayo |
gmcharlt: yes ^^" |
| 13:56 |
|
tuxayo |
Do you confirm being Wordpress admin on the koha-community.org website? |
| 13:56 |
|
tuxayo |
We messaged with Liz a few weeks ago about creating an account for me to announce releases but that might have been lost among other tasks. |
| 13:56 |
|
|
andreashm joined #koha |
| 13:56 |
|
tuxayo |
I noticed that a bit late friday (saturday in NZ) and sent and email hoping for it to make it through for monday (12h ago for NZ) |
| 13:56 |
|
tuxayo |
But since I had email-ending-up-in-spam issues, that might have been he case :( |
| 13:57 |
|
|
andreashm joined #koha |
| 13:57 |
|
gmcharlt |
tuxayo: I am. please DM your preferred email address and I'll set you up |
| 13:58 |
|
|
andreashm joined #koha |
| 13:58 |
|
|
andreashm joined #koha |
| 13:59 |
|
|
andreashm joined #koha |
| 14:00 |
|
tuxayo |
gmcharlt: thanks :D |
| 14:00 |
|
tuxayo |
I might be an imposter on IRC though :P |
| 14:00 |
|
|
andreashm joined #koha |
| 14:00 |
|
tuxayo |
You can use the email address that is signing off the commits pushed on 19.05.x |
| 14:00 |
|
tuxayo |
https://gitlab.com/koha-commun[…]-/commits/19.05.x |
| 14:01 |
|
|
andreashm joined #koha |
| 14:01 |
|
gmcharlt |
tuxayo: OK, you should shortnly have an email asking to confirm your WP account |
| 14:07 |
|
tuxayo |
gmcharlt++ # Saved the day again! :) |
| 14:07 |
|
tcohen |
hi gmcharlt |
| 14:07 |
|
gmcharlt |
hi tcohen |
| 14:08 |
|
gmcharlt |
tuxayo: well, that's the thing: we take are imposters and put them to working testing patches ;) |
| 14:08 |
|
gmcharlt |
*our |
| 14:12 |
|
* oleonard |
starts assigning patch-testing punishments for the most trivial infractions |
| 14:13 |
|
tuxayo |
gmcharlt: oh no they got me! |
| 14:13 |
|
gmcharlt |
:) |
| 14:14 |
|
tuxayo |
oleonard: We could partner with a few libraries to have that in the overdue triggers. Best would be librarian school libraries. |
| 14:15 |
|
|
andreashm joined #koha |
| 14:16 |
|
oleonard |
Is child labor ethical if it's for open source? I could be convinced |
| 14:25 |
|
tcohen |
has anyone manage to make cats do QA? |
| 14:28 |
|
|
margaret joined #koha |
| 14:28 |
|
gmcharlt |
fuzz testing, sure |
| 14:29 |
|
oleonard |
:P |
| 14:35 |
|
tcohen |
we improved our test suite when we made test execution random |
| 14:43 |
|
|
inlibro joined #koha |
| 14:46 |
|
tuxayo |
> fuzz testing, sure |
| 14:46 |
|
tuxayo |
Ubuntu users do. |
| 14:46 |
|
tuxayo |
https://bugs.launchpad.net/ubu[…]nity/+bug/1463112 |
| 14:46 |
|
tuxayo |
https://bugs.launchpad.net/ubu[…]eter/+bug/1538615 |
| 14:46 |
|
tuxayo |
https://bugs.launchpad.net/ubu[…]nity/+bug/1303698 |
| 14:46 |
|
tuxayo |
https://launchpadlibrarian.net[…]140307_200415.jpg |
| 14:46 |
|
tuxayo |
https://launchpadlibrarian.net[…]d-sitting-cat.jpg |
| 14:47 |
|
tuxayo |
caroline: might have some experience in cat-driven QA |
| 14:58 |
|
tcohen |
tuxayo LOL |
| 15:00 |
|
reiveune |
bye |
| 15:00 |
|
|
reiveune left #koha |
| 15:12 |
|
caroline |
tuxayo: omg, I was just giving a training via video conference and of course my cats had to chase each other right behind me and make a mess hehe |
| 15:13 |
|
tuxayo |
purrfect |
| 15:21 |
|
caroline |
my weekend project https://www.instagram.com/p/CBtBUkYniT4/ |
| 15:26 |
|
|
khall joined #koha |
| 15:27 |
|
tuxayo |
That a good moment to try Bibliogram, I never tried it before. |
| 15:27 |
|
tuxayo |
https://bibliogram.art/p/CBtBUkYniT4/ |
| 15:28 |
|
tuxayo |
he he, very nice caroline ! |
| 15:28 |
|
tuxayo |
tcohen: do you remember if that already happened for the release to put the wrong team in the generated release notes? |
| 15:29 |
|
tuxayo |
The repo is up to date though. |
| 15:31 |
|
tuxayo |
Also the wrong recommendations for deployments (env) |
| 15:33 |
|
|
fridolin left #koha |
| 15:38 |
|
|
cait1 left #koha |
| 15:43 |
|
|
andreashm joined #koha |
| 15:44 |
|
|
inlibro joined #koha |
| 15:55 |
|
|
khall joined #koha |
| 15:59 |
|
TimothyAlexis |
Thank you again magnuse, I found it. |
| 15:59 |
|
TimothyAlexis |
I wish you all superb health, clarity of mind and a blessed rest of today. |
| 16:15 |
|
|
andreashm joined #koha |
| 16:15 |
|
oleonard |
tuxayo: Bibliogram looks cool! |
| 16:35 |
|
koha-jenkins |
Project Koha_19.05_U18 build #244: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_19.05_U18/244/ |
| 16:35 |
|
koha-jenkins |
Project Koha_19.05_D8 build #248: UNSTABLE in 36 min: https://jenkins.koha-community[…]oha_19.05_D8/248/ |
| 16:39 |
|
koha-jenkins |
Project Koha_19.05_D9 build #242: SUCCESS in 39 min: https://jenkins.koha-community[…]oha_19.05_D9/242/ |
| 16:44 |
|
|
inlibro joined #koha |
| 16:55 |
|
|
cait joined #koha |
| 16:57 |
|
tuxayo |
tcohen: ashimema : Does running `prove -r t/ xt/` in koha-testing-docker with |
| 16:57 |
|
tuxayo |
the right image and DBMS is good enough to reproduce the CI locally? |
| 16:58 |
|
tuxayo |
It's for a one shot run for envs not in the CI for 19.05 |
| 16:59 |
|
tuxayo |
(after the release, I'll see what need to be added to the CI and what need to be removed) |
| 17:06 |
|
ashimema |
That's what I used to do yes |
| 17:06 |
|
ashimema |
Sorry, dinner duties calling |
| 17:07 |
|
tuxayo |
ashimema: Thanks, no worries. I think I'm good now. After that, NZ will wake up if I have any issues. |
| 17:19 |
|
|
khall_ joined #koha |
| 17:27 |
|
|
khall joined #koha |
| 17:30 |
|
|
khall_ joined #koha |
| 17:44 |
|
|
inlibro joined #koha |
| 18:01 |
|
tuxayo |
Does anyone know how to check which are the Perl version requirements for a Koha version? |
| 18:01 |
|
tuxayo |
It seems the release notes says "Perl 5.10 is required" since many years until now ^^" |
| 18:03 |
|
tuxayo |
the debian/control file mentions "perl-modules | perl-modules-5.22 | perl-modules-5.24," for 19.05 which I guess means «supported perl version 5.20, 5.22, 5.24» |
| 18:05 |
|
tuxayo |
Actually I should just pick the perl version where the automated tests pass. Otherwise is not reliable to tell for any other version. |
| 18:09 |
|
tcohen |
I think it depends on the version, but as we deprecated jessie... |
| 18:10 |
|
|
khall joined #koha |
| 18:44 |
|
|
inlibro joined #koha |
| 18:47 |
|
tuxayo |
tcohen: Yes, I'll not count Jessie (the dev meeting logs where not clear if Jessie is dropped now or in one Month...) |
| 18:47 |
|
tuxayo |
But it seems to lean towards is now. |
| 18:48 |
|
tuxayo |
*towards now |
| 18:48 |
|
tuxayo |
(anyway, the tests still pass on Debian 8 so nobody should complain :P ) |
| 19:13 |
|
|
andreashm joined #koha |
| 19:44 |
|
|
inlibro joined #koha |
| 20:03 |
|
|
kathryn joined #koha |
| 20:15 |
|
tuxayo |
tcohen: still around? |
| 20:15 |
|
tcohen |
only for a couple more minutes |
| 20:15 |
|
tcohen |
shoot |
| 20:18 |
|
tuxayo |
tcohen: The previous release of 19.05 advertised experimental MySQL 8 support seemingly without testing it. |
| 20:18 |
|
tuxayo |
I ran the tests locally to fact check that and I got 2 failure DB related. |
| 20:18 |
|
tuxayo |
Should I remove in the release notes "experimental MySQL 8 support". |
| 20:18 |
|
tuxayo |
*? |
| 20:18 |
|
tuxayo |
And maybe add it back next month (maybe a simple backport can fix it) |
| 20:18 |
|
tuxayo |
done. |
| 20:19 |
|
tuxayo |
*MariaDB 10.3 |
| 20:19 |
|
tuxayo |
(not MySQL 8) |
| 20:19 |
|
tuxayo |
doesn't change the question actually |
| 20:19 |
|
tcohen |
what are those failures? |
| 20:20 |
|
|
alexbuckley joined #koha |
| 20:20 |
|
tuxayo |
tcohen: https://bugs.koha-community.or[…].cgi?id=23825#c34 |
| 20:20 |
|
huginn |
Bug 23825: normal, P5 - low, ---, m.de.rooy, RESOLVED FIXED, Object.t is failing - Exception not caught |
| 20:21 |
|
tcohen |
I would say we can keep the experimental flag |
| 20:21 |
|
tcohen |
in both cases an exception is thrown |
| 20:22 |
|
tuxayo |
Ok, I didn't get the impact of the bug |
| 20:22 |
|
tuxayo |
Thanks tcohen :) |
| 20:22 |
|
tuxayo |
tcohen++ |
| 20:22 |
|
tcohen |
is this 19.11? |
| 20:22 |
|
tcohen |
no, 19.05 |
| 20:23 |
|
* andreashm |
waves |
| 20:24 |
|
tcohen |
let me check something tuxayo |
| 20:25 |
|
tuxayo |
Ok, I'll be back latter unfortunatelly |
| 20:25 |
|
tcohen |
No, wait 30 seconds :-D |
| 20:26 |
|
tcohen |
https://gitlab.com/koha-commun[…]ha/Object.pm#L178 |
| 20:27 |
|
tcohen |
compare that to the warn in your comment |
| 20:27 |
|
tcohen |
your comment shows backticks |
| 20:27 |
|
tcohen |
that's why it is failing, it should even be simple to correct |
| 20:27 |
|
tcohen |
fix |
| 20:27 |
|
tuxayo |
ok |
| 20:28 |
|
tcohen |
23825 is the proper fix for it |
| 20:29 |
|
tuxayo |
I'm already late for releasing. And the rest of the process will also be my first time. |
| 20:30 |
|
tuxayo |
tcohen: 23825 I applied it indeed and that fixed these tests. But that would require me rerun all the other tests locally (for reasons) |
| 20:30 |
|
tcohen |
No |
| 20:31 |
|
tcohen |
there's a discrepancy on the string this mariadb version returns to detail the error it got |
| 20:31 |
|
tcohen |
on other DB versions, it is consistent, this patch just makes the regexp catch *also* this case |
| 20:32 |
|
tcohen |
I find it pretty safe |
| 20:32 |
|
tcohen |
and you can push it to your branch, and eventually push a revert once Jenkins has gon through all combinations and you find it causes trouble (which you shouldn't) |
| 20:44 |
|
|
inlibro joined #koha |
| 20:47 |
|
aleisha |
hello |
| 20:47 |
|
wahanui |
niihau, aleisha |
| 20:47 |
|
oleonard-away |
Hi aleisha |
| 20:51 |
|
* cait |
waves |
| 20:55 |
|
* mtj |
waves back 🙋ðŸ»â€ |
| 20:55 |
|
mtj |
hi #koha |
| 20:55 |
|
cait |
hi mtj :) |
| 20:59 |
|
|
hayley joined #koha |
| 21:21 |
|
tuxayo |
hi aleisha o/ |
| 21:21 |
|
aleisha |
heyo |
| 21:26 |
|
tuxayo |
aleisha: I got several issues while beginning release which were very confusing. Here are some warnings about the release not generation: |
| 21:26 |
|
tuxayo |
1. RMaint team wrong, I'll fix it manually in my release notes. You might want to check also the rest of the team |
| 21:26 |
|
tuxayo |
(I didn't check yet the rest of the notes) |
| 21:26 |
|
tuxayo |
2. Recommended perl version wrong https://gitlab.com/koha-commun[…]tools/-/issues/12 |
| 21:26 |
|
tuxayo |
3. Recommended Debian & DBMS versions wrong. It didn't match my CI. |
| 21:26 |
|
tuxayo |
I had to run locally many times to fact check what was advertised in the earlier releases of my branch. |
| 21:28 |
|
tuxayo |
I hope I didn't make mistakes and that the rest of the release will be okay. |
| 21:29 |
|
aleisha |
thanks yes tuxayo i did notice that the rmaint team was wrong |
| 21:29 |
|
aleisha |
im sure you sorted everything out :) |
| 21:32 |
|
tuxayo |
aleisha: I'm sure not! I didn't finished proofreading them :P |
| 21:32 |
|
tuxayo |
I just finished the fifth test suite run and there are failures on MySQL 8 :( (well it did said "experimental") |
| 21:33 |
|
tuxayo |
If you find something new in your branch, I would be much interested. |
| 21:34 |
|
aleisha |
i got held up with fixing errors in the translation files - ill let you know about the rest once i get to it |
| 21:34 |
|
tuxayo |
I hope at least the CI of stable and oldstable match what the release note generator and the previous release say. |
| 21:38 |
|
tuxayo |
aleisha: I might have overlooked the translation issues. Is that issues like that? |
| 21:38 |
|
tuxayo |
«a format specification for argument 'count' doesn't exist» |
| 21:38 |
|
aleisha |
yes those kinds of errors |
| 21:38 |
|
rangi |
if thats in the messages.po files then yeah |
| 21:38 |
|
rangi |
it should give you a line number |
| 21:38 |
|
tuxayo |
«number of format specifications in 'msgid' and 'msgstr' does not match» |
| 21:39 |
|
tuxayo |
Yes there are |
| 21:39 |
|
rangi |
yeah thats another one |
| 21:39 |
|
rangi |
for those ones, yuo can either fix it if you can (if you can read the language its in) |
| 21:39 |
|
rangi |
or |
| 21:39 |
|
rangi |
mark it fuzzy |
| 21:40 |
|
rangi |
to do that you can on the line above that has the #,c-format |
| 21:40 |
|
rangi |
put |
| 21:40 |
|
rangi |
,fuzzy |
| 21:40 |
|
rangi |
ie #,c-format,fuzzy |
| 21:40 |
|
rangi |
that tells the system we aren't sure about that translation |
| 21:40 |
|
* rangi |
hopes he is making sense |
| 21:41 |
|
cait |
sounded good to me :) |
| 21:41 |
|
tuxayo |
Thanks you both for raising that issue and the explanation. |
| 21:41 |
|
tuxayo |
Should I also go in the translation platform to mark it fuzzy there? |
| 21:41 |
|
tuxayo |
So the same issue doesn't pop next month. |
| 21:41 |
|
cait |
also always think about string freeze - no string changes after 15th |
| 21:42 |
|
rangi |
ideally yes, bonus points for emailing the translate list and saying you did it so someone can fix the translation |
| 21:42 |
|
tuxayo |
cait: I tried to pay attention to the changed file types |
| 21:42 |
|
cait |
good :) |
| 21:43 |
|
tuxayo |
.tt and .inc right? |
| 21:43 |
|
cait |
also js these days |
| 21:43 |
|
cait |
best to check/read the changes |
| 21:43 |
|
tuxayo |
indeed! |
| 21:44 |
|
tuxayo |
rangi: Ok, I'll try that. |
| 21:44 |
|
rangi |
(it has the side effect of reminding people to translate :)) |
| 21:45 |
|
|
inlibro joined #koha |
| 21:47 |
|
|
bdonnahue1 joined #koha |
| 21:54 |
|
tuxayo |
aleisha: rangi is force push allowed for fixing mistakes just before release? ^^" (no tag was pushed yet) |
| 21:54 |
|
rangi |
hmm did you do a rebase? |
| 21:55 |
|
rangi |
(ie why are you needing to force push?) |
| 21:55 |
|
aleisha |
hey tuxayo just as a heads up for the release notes using the old rmaint team - i needed to update the etc/config.yaml and change the master version at the top of the file to 20.11 |
| 21:56 |
|
tuxayo |
Thanks aleisha . That didn't prevent me from getting the wrong team though :( |
| 21:56 |
|
rangi |
short answer is no, we prefer a revert etc |
| 21:56 |
|
rangi |
because it will mess up anyone who has a clone of it |
| 21:56 |
|
rangi |
but if you need ot, then go for it, just drop a note to koha-devel so that people know |
| 21:57 |
|
rangi |
hope that helps |
| 22:00 |
|
tuxayo |
rangi: I have already pushed: |
| 22:00 |
|
tuxayo |
- Translation updates for Koha 19.05.12 |
| 22:00 |
|
tuxayo |
- Increment version for 19.05.12 release |
| 22:00 |
|
tuxayo |
So I need to fix the translations and also Tomas thinks that I should backport a small fix for MariaDB 10.3 |
| 22:00 |
|
tuxayo |
(which has experimental support in 19.05.x) |
| 22:00 |
|
tuxayo |
How it will mess up with the other having clones if there don't work on 19.05.X? |
| 22:00 |
|
tuxayo |
When I do git remote update I often see "(force pushed)" on the branches in the remote that are mirrors (like the GitLab mirror). |
| 22:00 |
|
tuxayo |
And git doesn't know it's a mirror. |
| 22:00 |
|
rangi |
if anyone else has a 19.05.x checkout |
| 22:01 |
|
rangi |
has some local comits |
| 22:01 |
|
rangi |
does a pull |
| 22:01 |
|
rangi |
it will get messy |
| 22:02 |
|
rangi |
its ok as long as people are aware of it |
| 22:03 |
|
rangi |
(rebasing changes commitids) |
| 22:03 |
|
tuxayo |
Indeed, a local 19.05.x where there add commit. |
| 22:04 |
|
tuxayo |
If that okay to have a messy history with stuff after the version increment then I can do that. |
| 22:04 |
|
rangi |
i think thats fine |
| 22:04 |
|
rangi |
its only really if you have pushed the tag |
| 22:04 |
|
|
tosca joined #koha |
| 22:04 |
|
rangi |
that you would have to force push |
| 22:04 |
|
rangi |
(to change the tag) |
| 22:05 |
|
tuxayo |
Good, let it be simple then. ^^ |
| 22:20 |
|
tuxayo |
rangi: When looking at a case I don't get how to fix it. |
| 22:20 |
|
tuxayo |
https://copycat.drycat.fr/?4a4[…]ZZdUwXyqaMv5oz1wr |
| 22:20 |
|
tuxayo |
I could just copy what you did for 19.11 to 19.05 but understanding has advantages ^^" |
| 22:20 |
|
tuxayo |
https://translate.koha-communi[…].po#unit=10625354 |
| 22:21 |
|
tuxayo |
https://translate.koha-communi[…]s.po#unit=8853240 |
| 22:22 |
|
koha-jenkins |
Project Koha_19.11_D8 build #194: SUCCESS in 42 min: https://jenkins.koha-community[…]oha_19.11_D8/194/ |
| 22:23 |
|
rangi |
ahh its saying it needs a {count} in the msgstr[3] line |
| 22:23 |
|
koha-jenkins |
Project Koha_19.11_U18 build #189: SUCCESS in 43 min: https://jenkins.koha-community[…]ha_19.11_U18/189/ |
| 22:23 |
|
rangi |
i don't know arabic, so i would just copy "{count} مواد" |
| 22:24 |
|
rangi |
and hope there is only one plural version of items |
| 22:24 |
|
rangi |
some languages the word changes if tere is 1, 2, 3, 4 or more of something |
| 22:26 |
|
tuxayo |
rangi: Ok, I'll mark as fuzzy because there are no common arabic parts between 19.05 and 19.11! |
| 22:26 |
|
tuxayo |
That might be a sign of multiple plural forms :o |
| 22:26 |
|
rangi |
yeah |
| 22:27 |
|
koha-jenkins |
Project Koha_19.11_D9 build #192: SUCCESS in 45 min: https://jenkins.koha-community[…]oha_19.11_D9/192/ |
| 22:27 |
|
rangi |
translation manager is a super fun & interesting job |
| 22:27 |
|
rangi |
i did it once a long time ago |
| 22:27 |
|
rangi |
bernardo has been great, but we should probably get some others learning just in case he ever wants to take a break |
| 22:28 |
|
tuxayo |
+1 |
| 22:37 |
|
tuxayo |
Does anyone confirm that in the translation platform we can't mark a string a fuzzy without having so user privilege related to the language? |
| 22:37 |
|
tuxayo |
Even though we can directly submit the translations... |
| 22:38 |
|
rangi |
im not sure |
| 22:38 |
|
tuxayo |
Like I can fix something but if I don't know the language, I can't even mark a fuzzy. I had to let it here. |
| 22:38 |
|
rangi |
ahh might need to ask bernardo |
| 22:39 |
|
tuxayo |
I only see the checkbox when being on the esperanto translation XD |
| 22:39 |
|
tuxayo |
(which I ended up being admin of lol) |
| 22:39 |
|
tuxayo |
Ok, I'll ask Bernardo |
| 22:40 |
|
cait |
there is a "needs more work" checkbox |
| 22:40 |
|
cait |
that is the fuzzy one |
| 22:40 |
|
cait |
do you see that? |
| 22:41 |
|
cait |
I am admin... so i see it everywhere :( |
| 22:41 |
|
tuxayo |
> do you see that? |
| 22:41 |
|
tuxayo |
Nope, expect in one language ^^" |
| 22:41 |
|
tuxayo |
> I am admin... so i see it everywhere :( |
| 22:41 |
|
tuxayo |
That's why :P |
| 22:45 |
|
|
inlibro joined #koha |
| 23:00 |
|
|
hayleymapley_ joined #koha |
| 23:01 |
|
|
tosca_ joined #koha |
| 23:01 |
|
|
kathryn_ joined #koha |
| 23:01 |
|
koha-jenkins |
Project Koha_19.11_D8 build #195: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_19.11_D8/195/ |
| 23:06 |
|
|
kathryn_ joined #koha |
| 23:09 |
|
tuxayo |
Should I remove from the release note the advertised "experimental support for MySQL 8" ?, it has 16 test failures... |
| 23:12 |
|
koha-jenkins |
Project Koha_19.11_U18 build #190: UNSTABLE in 45 min: https://jenkins.koha-community[…]ha_19.11_U18/190/ |
| 23:14 |
|
koha-jenkins |
Project Koha_19.11_D10 build #26: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_19.11_D10/26/ |
| 23:26 |
|
tuxayo |
Any opinion rangi , aleisha ? (my previous message) |
| 23:45 |
|
|
inlibro joined #koha |
| 23:46 |
|
koha-jenkins |
Project Koha_19.11_D9 build #193: UNSTABLE in 44 min: https://jenkins.koha-community[…]oha_19.11_D9/193/ |
| 23:54 |
|
koha-jenkins |
Yippee, build fixed! |
| 23:54 |
|
wahanui |
Congratulations! |
| 23:54 |
|
koha-jenkins |
Project Koha_19.05_D8 build #249: FIXED in 35 min: https://jenkins.koha-community[…]oha_19.05_D8/249/ |
| 23:55 |
|
hayleymapley_ |
up to you tuxayo |
| 23:55 |
|
hayleymapley_ |
it is experimental |
| 23:57 |
|
koha-jenkins |
Project Koha_19.05_U18 build #245: SUCCESS in 40 min: https://jenkins.koha-community[…]ha_19.05_U18/245/ |
