| Time |
S |
Nick |
Message |
| 00:02 |
|
|
hayley joined #koha |
| 00:02 |
|
|
inlibro joined #koha |
| 00:19 |
|
|
Marie-Luce joined #koha |
| 01:02 |
|
|
inlibro joined #koha |
| 02:02 |
|
|
inlibro joined #koha |
| 02:15 |
|
|
hayley joined #koha |
| 02:17 |
|
tuxayo |
Does anyone know how to build the debian packages for Koha? |
| 02:17 |
|
tuxayo |
I want to sign off bug 25485 but don't even have an entry point about how building the packages work |
| 02:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25485 critical, P5 - low, ---, kyle, Needs Signoff , TinyMCE broken in Debian package installs |
| 02:21 |
|
rangi |
https://wiki.koha-community.or[…]es_-_The_Easy_Way |
| 02:21 |
|
rangi |
should be enough for your testing |
| 02:22 |
|
rangi |
you'll want to do stretch instead of jessie when creating your pbuilder (most likely) |
| 02:30 |
|
tuxayo |
rangi++ |
| 02:30 |
|
tuxayo |
thanks :D |
| 03:02 |
|
|
inlibro joined #koha |
| 04:02 |
|
|
inlibro joined #koha |
| 05:03 |
|
|
inlibro joined #koha |
| 05:42 |
|
|
ere joined #koha |
| 05:57 |
|
|
cait joined #koha |
| 06:02 |
|
|
did joined #koha |
| 06:03 |
|
|
inlibro joined #koha |
| 06:12 |
|
* magnuse |
waves |
| 06:14 |
|
* cait |
waves |
| 06:18 |
|
|
davidnind joined #koha |
| 06:25 |
|
did |
hi, |
| 06:25 |
|
magnuse |
kia ora cait and davidnind |
| 06:25 |
|
magnuse |
hi did |
| 06:28 |
|
did |
A workflow question, bug 25291 : doesnt apply cleanly to 19.05.x, if needed please rebase. So far so good, I know how to rebase but how do I put it in bugzilla? A new patch attached to the bug number, replace the old patch? |
| 06:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25291 trivial, P5 - low, ---, didier.gautheron, Pushed to stable , Barcode should be escaped everywhere in html code |
| 06:28 |
|
cait |
did: yes in this case |
| 06:29 |
|
cait |
and you can add [19.05.x] in the commit message subject line |
| 06:29 |
|
cait |
so it's immediately visible that this is one for an older version |
| 06:30 |
|
davidnind |
hi magnuse! |
| 06:30 |
|
did |
cait: thanks, have you an example? patch number? |
| 06:32 |
|
cait |
not righ tnow |
| 06:32 |
|
did |
cait: ok, thanks |
| 06:32 |
|
cait |
but just do a git --commit amend after your rebase |
| 06:32 |
|
cait |
an add [19.11] in front of everythng |
| 06:32 |
|
cait |
hm maybe after the bug number... (been a while) |
| 06:33 |
|
cait |
ah, here is one: https://bugs.koha-community.or[…]_bug.cgi?id=24964 |
| 06:33 |
|
huginn |
Bug 24964: major, P5 - low, ---, jonathan.druart, Pushed to oldstable , Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions) |
| 06:33 |
|
cait |
they did not obsolete hte older patches in this case |
| 06:34 |
|
cait |
you can't get it very wrong actually, because we can always bring the older patches back and still see them |
| 06:34 |
|
cait |
this is another example: https://bugs.koha-community.or[…]_bug.cgi?id=25311 |
| 06:34 |
|
huginn |
Bug 25311: normal, P5 - low, ---, jonathan.druart, Pushed to master , Better error handling when creating/updating a patron |
| 06:37 |
|
cait |
brb |
| 06:38 |
|
|
cait joined #koha |
| 06:40 |
|
|
cait joined #koha |
| 06:41 |
|
|
cait joined #koha |
| 06:42 |
|
|
reiveune joined #koha |
| 06:42 |
|
reiveune |
hello |
| 06:44 |
|
|
cait joined #koha |
| 06:50 |
|
|
cait joined #koha |
| 06:51 |
|
|
alex_a joined #koha |
| 06:52 |
|
alex_a |
Bonjour |
| 06:52 |
|
wahanui |
hi, alex_a |
| 06:52 |
|
|
cait1 joined #koha |
| 06:59 |
|
|
kohaputti joined #koha |
| 07:03 |
|
|
andreashm joined #koha |
| 07:03 |
|
|
inlibro joined #koha |
| 07:15 |
|
|
hayley joined #koha |
| 07:41 |
|
|
alex_a_ joined #koha |
| 07:52 |
|
Joubu |
@later tell talljoy you should pick 25400 for the next release |
| 07:52 |
|
huginn |
Joubu: The operation succeeded. |
| 07:54 |
|
cait1 |
probably better to email - not sure how often she says something here |
| 08:03 |
|
|
inlibro joined #koha |
| 08:03 |
|
Joubu |
@later tell talljoy It seems that 19.11 installs are broken, please wait for 25510 before releasing |
| 08:03 |
|
huginn |
Joubu: The operation succeeded. |
| 08:04 |
|
Joubu |
cait1: usually she answers me here |
| 08:05 |
|
* ashimema |
can pass those messages on via slack |
| 08:05 |
|
cait1 |
ok, if that's your workflow :) |
| 08:05 |
|
cait1 |
morning ashimema :) |
| 08:06 |
|
ashimema |
mornin' |
| 08:14 |
|
ere |
uh.. since the default MARC 21 framework is now YAML, is there a tool for making changes during database migration? I'm working on bug 20447 which introduces the holdings framework and wondering about the correct way to handle this. Or should importing the framework be left to the admin? |
| 08:14 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20447 new feature, P5 - low, ---, ere.maijala, Patch doesn't apply , Add support for MARC holdings records |
| 08:15 |
|
|
alex_a joined #koha |
| 08:15 |
|
ere |
It doesn't feel right to duplicate the work in SQL especially as I plan to copy a lot of fields from the default bibliographic framework. |
| 08:15 |
|
ere |
aaand good morning :) |
| 08:16 |
|
Joubu |
ashimema: no need to ping her via slack |
| 08:16 |
|
Joubu |
better without proxy usually ;) |
| 08:17 |
|
Joubu |
ere: yes you have to duplicate the work |
| 08:18 |
|
ere |
eek |
| 08:18 |
|
ere |
previously it was cut-n-paste, but no it's "convert YAML to SQL" |
| 08:18 |
|
Joubu |
maybe bug 24912 can help you |
| 08:18 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24912 enhancement, P5 - low, ---, jonathan.druart, ASSIGNED , Generate sql from yaml installer files |
| 08:19 |
|
ere |
Joubu: cool, I'll take a look |
| 08:19 |
|
Joubu |
ere: have a look at comment 5, you may need to tweak the result a bit (int vs string) |
| 08:20 |
|
ere |
Joubu: ok, thanks! |
| 08:33 |
|
cait1 |
ere: we are in transition there - the translated installers still use sql -hopefully not for too long |
| 08:34 |
|
cait1 |
only es-ES has fully moved over |
| 08:34 |
|
cait1 |
the yaml based installer is rather new still |
| 08:37 |
|
ashimema |
Thanks for digging in that area ere.. it's all rather new and in the 'learn and refine' stage still really :) |
| 08:38 |
|
ere |
I see and feel being caught in the middle :) |
| 08:38 |
|
ashimema |
apologies :( |
| 08:40 |
|
ere |
ashimema: no worries.. what I would have wanted would be for the tools to be there already and work wonderfully. Now I'm in for a lot of manual work, but hey, that's not unusual :D |
| 08:40 |
|
ere |
well, I would have done a lot of the manual conversion anyway, and caught a couple of mistakes while doing it, so there's also the upside |
| 08:41 |
|
ashimema |
We're getting there on the tools.. so close.. yet so far |
| 08:41 |
|
ashimema |
Joubu and Bernardo have been working diligently on them.. just a shame there's never quit enough time to finish things :( |
| 08:42 |
|
ashimema |
I think they're really at the point where it's really helpful to get this sort of feedback though :) |
| 08:48 |
|
Joubu |
what's missing ashimema? |
| 08:48 |
|
ashimema |
the core stuff is all there |
| 08:49 |
|
ashimema |
getting 24912 over the finish line would be good and is nearly there |
| 08:49 |
|
Joubu |
I think we are stuck with this one |
| 08:49 |
|
ashimema |
also, finishing off the installer files migrations.. i.e. the same as we've already done for es-ES for the other files |
| 08:49 |
|
Joubu |
the problem from comment 5 is hard to fix |
| 08:50 |
|
Joubu |
I don't like Bernardo's idea to add the "numeric" info in the yml, it's something we have already in the DB |
| 08:50 |
|
ashimema |
which I think hinges on some work Bernardo is currently doing to split localisation out as a distinct step so we're not using some of those files for both translation and localisation |
| 08:50 |
|
Joubu |
DB struct |
| 08:51 |
|
Joubu |
yes, he will get back to us asap. The first implementation is too complex imo |
| 08:51 |
|
Joubu |
we need something simpler for localisation |
| 08:51 |
|
ashimema |
yeah |
| 08:51 |
|
ashimema |
I commented on the bug with an idea.. can't for the life of my find the bug number now |
| 08:52 |
|
cait1 |
i wouldn't mihd keeping the option to add sql files locally |
| 08:52 |
|
cait1 |
for localisation (just keep the sysprefs.sql file and run it at the end) |
| 08:52 |
|
cait1 |
it would also allow to extend the installer as we can do currently |
| 08:52 |
|
Joubu |
ashimema: bug 24973 |
| 08:52 |
|
cait1 |
we load some extras to be honest :) |
| 08:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24973 enhancement, P5 - low, ---, bgkriegel, ASSIGNED , Allow to localize and translate system preferences with new yaml based installer |
| 08:53 |
|
ashimema |
bug 24973 I think |
| 08:53 |
|
cait1 |
at the moment all you need to do is add some files, that's very convenient |
| 08:53 |
|
ashimema |
that's the comment I made |
| 08:54 |
|
ashimema |
> If that's the case.. I wonder if we could instead split localisation into a |
| 08:54 |
|
ashimema |
> distinct step in the installer.. so prefs are translated 'as is'.. but if |
| 08:54 |
|
ashimema |
...(truncated) |
| 08:54 |
|
ashimema |
so.. keep translation as translation.. add a step in the installer process that allows for localisation, probably via arbitrary .sql files as you say cait |
| 08:54 |
|
cait1 |
yeah |
| 08:54 |
|
ashimema |
bernardo is currently working on that.. he liked the idea |
| 08:56 |
|
ashimema |
anyways.. to me that's the last nail to hammer here :) |
| 08:56 |
|
ashimema |
well.. until the next one 😂 |
| 08:58 |
|
|
Null404 joined #koha |
| 08:58 |
|
Null404 |
hi there |
| 08:58 |
|
Null404 |
I updated KOHA 17.11 to 18.11 and one report don't work |
| 08:58 |
|
Null404 |
"how many people visit libraries" |
| 08:59 |
|
huginn |
News from kohagit: Bug 25480: Don't hide apache error and display incorrect error <http://git.koha-community.org/[…]09292d71405f2260a> |
| 08:59 |
|
huginn |
News from kohagit: Bug 25468: Preserve line breaks in hold notes <http://git.koha-community.org/[…]f648491dbafb1a1a7> |
| 08:59 |
|
huginn |
News from kohagit: Bug 25416: (follow-up) Remove useless use statement <http://git.koha-community.org/[…]d782613ee72265763> |
| 08:59 |
|
huginn |
News from kohagit: Bug 24458: Use the ViewPolicy filter on search results <http://git.koha-community.org/[…]08e279d8590a6180f> |
| 08:59 |
|
huginn |
News from kohagit: Bug 24458: Regression tests <http://git.koha-community.org/[…]a4d4ea3a27ef0d2fa> |
| 08:59 |
|
huginn |
News from kohagit: Bug 25416: Unit tests <http://git.koha-community.org/[…]4455d563b0f53e7a7> |
| 08:59 |
|
huginn |
News from kohagit: Bug 25416: Let OPAC XSLTs know if the context is an anonymous session <http://git.koha-community.org/[…]897f78f9672bd81e0> |
| 08:59 |
|
huginn |
News from kohagit: Bug 23403: Catch other cases of ->{patron} <http://git.koha-community.org/[…]0e03142ac701e8e06> |
| 08:59 |
|
huginn |
News from kohagit: Bug 23403: List borrowernumber in the ILS::Patron fields <http://git.koha-community.org/[…]729f6a8a81edcda68> |
| 08:59 |
|
huginn |
News from kohagit: Bug 23403: Fix whitespace <http://git.koha-community.org/[…]166e5c89c4c591ddf> |
| 08:59 |
|
huginn |
News from kohagit: Bug 23403: Remove cardnumber from SIP <http://git.koha-community.org/[…]bd340520ea2e945f1> |
| 09:03 |
|
|
inlibro joined #koha |
| 09:04 |
|
Joubu |
if it does not work, you need to fix it |
| 09:04 |
|
Joubu |
:D |
| 09:05 |
|
Null404 |
I know |
| 09:05 |
|
Null404 |
I'm searching solution |
| 09:06 |
|
Null404 |
on test server the same report working fine |
| 09:08 |
|
davidnind |
Null404: http://schema.koha-community.org/ and the reports library at https://wiki.koha-community.or[…]L_Reports_Library may help workout what database fields and tables have changed |
| 09:09 |
|
Null404 |
davidnind but in test koha 19.11 this report is working |
| 09:09 |
|
huginn |
News from kohagit: Bug 24994: Correct DB Updates <http://git.koha-community.org/[…]3663b1d80fd2c4c5b> |
| 09:09 |
|
Null404 |
on main 18.11 is incomplette |
| 09:10 |
|
Null404 |
don't show number of how much people visit library |
| 09:11 |
|
cait1 |
Null404: if you share your report i can maybe suggest what has changes |
| 09:12 |
|
cait1 |
what has changed |
| 09:12 |
|
Null404 |
okay |
| 09:14 |
|
Null404 |
http://paste.koha-community.org/20394 |
| 09:14 |
|
Joubu |
yes please share the report and the error you get. Otherwise we cannot help you |
| 09:15 |
|
Null404 |
a seccond date don't show and I don't get a number in table |
| 09:15 |
|
|
marcelr joined #koha |
| 09:15 |
|
marcelr |
hi |
| 09:16 |
|
Null404 |
hello |
| 09:16 |
|
marcelr |
ashimema: what is your exact release planning ? when is the last push on or before May 22? |
| 09:16 |
|
cait1 |
hm Null404 hat looks ok, but the error would be interesting |
| 09:17 |
|
Joubu |
Null404: you have twice the same "field name" |
| 09:17 |
|
cait1 |
and it#s probably write it a little different |
| 09:17 |
|
Joubu |
"Data od" |
| 09:17 |
|
Null404 |
I know that SQL code should be ok |
| 09:17 |
|
Joubu |
Null404: try "Date from" and "Date to" |
| 09:19 |
|
cait1 |
oh yes |
| 09:19 |
|
cait1 |
new feature |
| 09:19 |
|
cait1 |
if you have the same name, the same date will be added |
| 09:19 |
|
cait1 |
that allows reuse of variables in an easy way |
| 09:19 |
|
Null404 |
hm.. |
| 09:22 |
|
Null404 |
is almost ok |
| 09:24 |
|
Null404 |
got two dates, get syntax error |
| 09:25 |
|
Joubu |
share it |
| 09:29 |
|
Null404 |
http://paste.koha-community.org/20395 |
| 09:29 |
|
Null404 |
I got error at line: " (type LIKE 'renew' OR type LIKE 'issue' OR type LIKE 'return') AND" |
| 09:30 |
|
Joubu |
what is the error |
| 09:30 |
|
wahanui |
the error is a silent one which is not visible unless i enable verbose logging for zebra |
| 09:30 |
|
Joubu |
*always* provide us the error please |
| 09:30 |
|
Joubu |
Null404: and read again the query, it's syntaxically wrong |
| 09:31 |
|
Null404 |
I forgot "and" |
| 09:31 |
|
Joubu |
yes |
| 09:31 |
|
Null404 |
and now I don't have errors but don't show numbers after accept date |
| 09:31 |
|
Null404 |
I got empty table |
| 09:31 |
|
Joubu |
then you don't have data that matches |
| 09:32 |
|
Null404 |
hm.. yes |
| 09:32 |
|
Null404 |
so something was broken in system after update ? |
| 09:32 |
|
Joubu |
enter the query in MySQL/MariaDB cli directly |
| 09:33 |
|
ashimema |
marcelr as I ended up pushing a little longer than expected on strings I was going to extend the deadline by a few days. My aim is last push on or around 22nd depending on if anything raises it's head between now and then. |
| 09:33 |
|
ashimema |
bugs only at this point |
| 09:34 |
|
marcelr |
ok so full next working week |
| 09:34 |
|
Null404 |
"#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '<<Enter date from (yyyy-mm-dd)>> AND <<Enter date to (yyyy-mm-dd)>> AND ' at line 6 " |
| 09:34 |
|
Joubu |
we have 4 critical and 4 blocker, cannot release without them anyway... |
| 09:35 |
|
marcelr |
yeah anyone can say that it is a blocker ;) |
| 09:35 |
|
ashimema |
I intend to then release some time over the weekend.. slightly loose on dates as that's half term |
| 09:35 |
|
Joubu |
Install and use under D10 is broken... |
| 09:35 |
|
koha-jenkins |
Project Koha_Master_D9 build #1332: UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_D9/1332/ |
| 09:35 |
|
ashimema |
well.. i agree with the current criticals and blockers in the queue.. they're right at the top of my priority list |
| 09:35 |
|
* ashimema |
goes and double checks that |
| 09:37 |
|
Joubu |
There is also a random and weird failure on stable for U18 - bug 24229 |
| 09:37 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24229 normal, P5 - low, ---, tomascohen, NEW , /items API tests fail on Ubuntu 18.04 |
| 09:37 |
|
Joubu |
that would be good to have additional pair of eyes on it. A shame to release without everything green |
| 09:38 |
|
ashimema |
I can try to replicate bug 25338 later today Joubu.. sounds like your struggling there |
| 09:38 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25338 critical, P5 - low, ---, koha-bugs, NEW , Koha checks items in when lost fee waived/paid |
| 09:38 |
|
ashimema |
it's 19.05 anyway in theory |
| 09:39 |
|
cait1 |
Null404: change that: (type LIKE 'renew' OR type LIKE 'issue' OR type LIKE 'return') AND" |
| 09:39 |
|
wahanui |
cait1: that doesn't look right |
| 09:39 |
|
|
wahanui joined #koha |
| 09:39 |
|
cait1 |
to type in ('renew', 'issue', 'return') |
| 09:39 |
|
Joubu |
ashimema: I did not recreate on master |
| 09:39 |
|
Joubu |
you mean it's only in 19.05? |
| 09:40 |
|
Null404 |
nope cait1 |
| 09:40 |
|
ashimema |
well the bug is reported against 19.05 |
| 09:40 |
|
Null404 |
still empty |
| 09:40 |
|
ashimema |
and he confirms he's only tested it on 19.05 |
| 09:41 |
|
Joubu |
yes, that's why I asked the exact version |
| 09:41 |
|
ashimema |
I'm inclined to ask ByWater to take a look as I think it's one of their partners |
| 09:42 |
|
ere |
Updating dbix class files is getting more complicated since update_dbix_class_files.pl won't retain the manually added stuff. I wonder if it could be made smarter? I'm constantly worrying that I forget to bring something over.. |
| 09:42 |
|
ere |
(should have said that we have much more manually added stuff than before) |
| 09:43 |
|
ashimema |
confused ere? |
| 09:43 |
|
ashimema |
it's has always kept it for me.. |
| 09:43 |
|
ashimema |
and still does |
| 09:43 |
|
ere |
ashimema: really? I'm doing something wrong :| |
| 09:43 |
|
Joubu |
Null404: you must replace the placeholders |
| 09:43 |
|
ashimema |
nothing has really changed in that regard for years... when did you notice it dropping customisations |
| 09:45 |
|
Null404 |
maybe Joubu |
| 09:45 |
|
ere |
ashimema: Wait, actually, yeah, that's not the problem. The problem is trying to rebase one's changes. I'd like to have a way of forcing update even if the checksum doesn't match. |
| 09:45 |
|
ere |
I mean, when I have database changes and manually added changes, it gets complicated |
| 09:46 |
|
ashimema |
aha.. I see |
| 09:46 |
|
ashimema |
I've contemplated adding that for literally ages |
| 09:46 |
|
ashimema |
want me to knock up a patch.. it's super trivial |
| 09:46 |
|
ere |
ashimema: If you already know the stuff, it would be a great addition. |
| 09:49 |
|
ashimema |
I manually add the flag occassionally already |
| 09:49 |
|
cait1 |
Null404: show me waht you have now and what is the output |
| 09:49 |
|
ashimema |
making it an option on calling the script would make it simpler |
| 09:50 |
|
Joubu |
yes, I don't think we want it by default |
| 09:50 |
|
Null404 |
cait1: I want to get table that have 2 informations: "how much" and "categorycode" |
| 09:50 |
|
ashimema |
totally agree Joubu |
| 09:51 |
|
Null404 |
for exaple: 5 adult, 12 childer etc |
| 09:51 |
|
Null404 |
*children |
| 09:51 |
|
ashimema |
but exposing it with a --force flag seems OK |
| 09:52 |
|
cait1 |
i meant share the sql gain please :) and the error you see |
| 09:53 |
|
Joubu |
any ideas how I could make my system slow without burning my CPU? |
| 09:54 |
|
koha-jenkins |
Project Koha_Master_U18 build #784: SUCCESS in 54 min: https://jenkins.koha-community[…]a_Master_U18/784/ |
| 09:55 |
|
ere |
yes, --force would be great |
| 09:57 |
|
ashimema |
bug 25511 ready for testing ere |
| 09:57 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25511 enhancement, P5 - low, ---, koha-bugs, NEW , Add --force option to update_dbix_class_files.pl |
| 09:57 |
|
ere |
ashimema: I'm on it! |
| 09:57 |
|
ashimema |
:) |
| 09:59 |
|
ashimema |
probably `:s` isn't needed actually.. |
| 09:59 |
|
ashimema |
but it should still work I think.. the code is trivial to follow |
| 10:02 |
|
ere |
ashimema: :s actually makes it fail |
| 10:02 |
|
ashimema |
oops |
| 10:02 |
|
ashimema |
I wrote it a tad quick |
| 10:02 |
|
ere |
:D |
| 10:03 |
|
ashimema |
I assume it works without? |
| 10:03 |
|
ere |
Yes. Can I just sign off with :s removed? :) |
| 10:03 |
|
|
inlibro joined #koha |
| 10:04 |
|
ashimema |
sure thing :) |
| 10:04 |
|
ashimema |
hopefully it makes your life a little easier :) |
| 10:05 |
|
cait1 |
community++ ere++ ashimema++ :) |
| 10:06 |
|
ere |
ashimema: Done! Good stuff, thanks, that's so much better :) |
| 10:08 |
|
ashimema |
Pleasure |
| 10:12 |
|
Null404 |
I don't have any ideas how to fix this report |
| 10:13 |
|
cait1 |
Null404: please share what you got in SQL right now if you want help |
| 10:13 |
|
Null404 |
I got this error: " #1064 - You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '<<Enter date from (yyyy-mm-dd)>> AND <<Enter date to (yyyy-mm-dd)>> AND ' at line 6" to this code: http://paste.koha-community.org/20395 |
| 10:14 |
|
Null404 |
something wrong with date |
| 10:14 |
|
cait1 |
you are arunning this from the reports module in Koha? |
| 10:14 |
|
cait1 |
and how did you enter the dates? |
| 10:15 |
|
Null404 |
I write date like this: "14/05/2020" |
| 10:16 |
|
cait1 |
yes, that won't work |
| 10:16 |
|
cait1 |
you removed date |
| 10:16 |
|
cait1 |
so you need to write db date format |
| 10:16 |
|
cait1 |
give me a moment to see if i can rewrite this in a nice way |
| 10:17 |
|
Null404 |
I changed to dd-mm-yyyy and still nothing |
| 10:17 |
|
cait1 |
it would be yyyy-mm-dd :) |
| 10:17 |
|
cait1 |
but give e a moment |
| 10:17 |
|
Null404 |
on test system I can select day from callendar |
| 10:18 |
|
Null404 |
and everything works |
| 10:18 |
|
Null404 |
with old, original report |
| 10:19 |
|
Null404 |
I have concerns that some functions got damaged during the update |
| 10:19 |
|
davidnind |
what's different between test system and the system you are trying on? |
| 10:19 |
|
cait1 |
it will be alright |
| 10:20 |
|
cait1 |
it was a simple fix actually, you just removed a bit too much |
| 10:20 |
|
cait1 |
and i am trying to make it a little nicer |
| 10:20 |
|
cait1 |
have a moment of patience please :) |
| 10:20 |
|
cait1 |
davidnind: << >> with same label was the problem |
| 10:20 |
|
cait1 |
Null404: do you want to see the category description? :) |
| 10:21 |
|
Null404 |
test system is the same version of main koha, but it's not updated from 2018 (new books, borrows, users etc) |
| 10:21 |
|
Null404 |
okay cait1 |
| 10:22 |
|
Joubu |
hum, `yes > /dev/null&` is a bit too efficient :D |
| 10:22 |
|
Joubu |
(don't run this command) |
| 10:23 |
|
cait1 |
try this: http://paste.koha-community.org/20398 |
| 10:23 |
|
Null404 |
I have a one more question, how to manually translate some text in system? (for expamle Available, not for load etc)? |
| 10:23 |
|
cait1 |
the values in the administrastion > authorised values - yes |
| 10:23 |
|
cait1 |
they are stored in the db |
| 10:24 |
|
cait1 |
but the upside is you can add to them and use whatever you like |
| 10:24 |
|
Null404 |
WOW! It's works! |
| 10:24 |
|
Null404 |
thanks you cait1 ! :D |
| 10:24 |
|
davidnind |
cait1++ |
| 10:24 |
|
Null404 |
finally, other librarians will be happy |
| 10:25 |
|
cait1 |
you can change Enter date from (yyyy-mm-dd) to whatever you want of course |
| 10:25 |
|
cait1 |
the part between << and |date is the label text |
| 10:25 |
|
cait1 |
they onle need to be different! so don't name them both the same again :) |
| 10:25 |
|
cait1 |
that waas the issue |
| 10:25 |
|
Null404 |
oh okay |
| 10:26 |
|
cait1 |
i usually do something like <<Date from|date>> and <<To|date>> - it will automatically add a : for the form |
| 10:26 |
|
cait1 |
date(datetime) BETWEEN <<From)|date>> AND <<To|date>> |
| 10:26 |
|
cait1 |
for example |
| 10:49 |
|
|
khall_ joined #koha |
| 10:50 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #317: SUCCESS in 55 min: https://jenkins.koha-community[…]aster_D9_My8/317/ |
| 10:53 |
|
koha-jenkins |
Project Koha_Master_D10 build #234: STILL UNSTABLE in 1 hr 17 min: https://jenkins.koha-community[…]a_Master_D10/234/ |
| 11:04 |
|
|
inlibro joined #koha |
| 11:08 |
|
Null404 |
again thanks for help cait1 |
| 11:10 |
|
cait1 |
you are welcome |
| 11:10 |
|
cait1 |
i wrote a lot of SQL |
| 11:14 |
|
Null404 |
good to know |
| 11:15 |
|
Null404 |
I wrote some programs in C and Pascal |
| 11:15 |
|
Null404 |
but it was a years age |
| 11:15 |
|
Null404 |
*ago |
| 11:15 |
|
* ashimema |
reminds himself how to boot k-t-d with d10 |
| 11:16 |
|
Joubu |
export KOHA_IMAGE=master-buster |
| 11:17 |
|
ashimema |
yup |
| 11:17 |
|
ashimema |
I got there |
| 11:18 |
|
Null404 |
fun fact - in polish version KOHA 18.11 is a same typo as in 17.11 - there is "Data wpłuwu" instead " Data wpływu" in 8d MARC when adding magazine |
| 11:18 |
|
ashimema |
I should really set an alias or something.. I have to look it up every time |
| 11:18 |
|
ashimema |
sounds like something you could fix Null404 |
| 11:19 |
|
Null404 |
how ? |
| 11:20 |
|
Null404 |
I want to translate some names used by librarians (age, avaiable, not for load etc) |
| 11:20 |
|
cait1 |
is that in the marc frameworks or a button or something? |
| 11:21 |
|
cait1 |
but in general: https://translate.koha-community.org/ here |
| 11:21 |
|
Null404 |
in Serials subscriptions when you click on Serial receive there is a table with that typo |
| 11:22 |
|
koha-jenkins |
Project Koha_Master_D8 build #868: SUCCESS in 29 min: https://jenkins.koha-community[…]ha_Master_D8/868/ |
| 11:22 |
|
Null404 |
its not a big problem anyway |
| 11:23 |
|
cait1 |
ah yes, then probably you can just fix it on the website i linked to |
| 11:23 |
|
cait1 |
do you want me to have a look? it will be released with the next versions to come out if you fix it |
| 11:24 |
|
* oleonard |
waves |
| 11:24 |
|
cait1 |
hi oleonard :) |
| 11:24 |
|
kohaputti |
yay, the upgrade to 19.11 worked without any errors (i of course modified the schema before running the upgrade script) |
| 11:24 |
|
cait1 |
hm not finding the string there |
| 11:24 |
|
cait1 |
kohaputti: sonds good :) |
| 11:25 |
|
Null404 |
yes |
| 11:25 |
|
|
Dyrcona joined #koha |
| 11:25 |
|
|
davidnind left #koha |
| 11:25 |
|
tcohen |
bonjour |
| 11:25 |
|
kohaputti |
cait1, still some stuff to do with developing missing features like bug 20447 but this is looking promising :) |
| 11:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20447 new feature, P5 - low, ---, ere.maijala, Patch doesn't apply , Add support for MARC holdings records |
| 11:29 |
|
|
andreashm joined #koha |
| 11:30 |
|
|
alex_a joined #koha |
| 11:36 |
|
|
cait joined #koha |
| 11:43 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #291: UNSTABLE in 53 min: https://jenkins.koha-community[…]9_MDB_Latest/291/ |
| 11:48 |
|
huginn |
News from kohagit: Bug 25482: Explicitly set macros as not shard during tests <http://git.koha-community.org/[…]c0e132971a82406fb> |
| 11:48 |
|
huginn |
News from kohagit: Bug 25482: Fix tests <http://git.koha-community.org/[…]9a61a60867f661d09> |
| 11:48 |
|
huginn |
News from kohagit: Bug 25482: Wrong permissions specification for adv editor macros <http://git.koha-community.org/[…]f1d1211513889fa09> |
| 11:58 |
|
koha-jenkins |
Yippee, build fixed! |
| 11:58 |
|
wahanui |
Congratulations! |
| 11:58 |
|
koha-jenkins |
Project Koha_Master_D9 build #1333: FIXED in 36 min: https://jenkins.koha-community[…]a_Master_D9/1333/ |
| 12:00 |
|
Null404 |
I got another problem :/ |
| 12:01 |
|
Null404 |
I got "Internal Server Error" when I reserve exatly one books, other ones can reserve |
| 12:02 |
|
|
khall joined #koha |
| 12:04 |
|
Joubu |
Null404: locate your plack-error.log log file, and the relevant error |
| 12:04 |
|
|
inlibro joined #koha |
| 12:04 |
|
Null404 |
I borrowed and return, and after that reserved and now working |
| 12:07 |
|
Null404 |
"DBD::mysql::db selectrow_array failed: Unknown column 'notloan' in 'field list' [for Statement "SELECT notloan from items where itemnumber = ?"] at /usr/share/koha/lib/C4/Items.pm line 1433. |
| 12:08 |
|
Null404 |
sit was a book that was in quarantine yesterday and I forgot to unlock this one |
| 12:08 |
|
Null404 |
but I set that librarian can borrow book that are not for load |
| 12:10 |
|
Joubu |
the column is "notforloan", not "notloan" |
| 12:11 |
|
Null404 |
so change that in Items.pm ? |
| 12:11 |
|
Null404 |
or its a bug ? |
| 12:21 |
|
|
sonOfRa joined #koha |
| 12:28 |
|
koha-jenkins |
Project Koha_Master_D8 build #869: UNSTABLE in 29 min: https://jenkins.koha-community[…]ha_Master_D8/869/ |
| 12:37 |
|
Joubu |
Null404: which version of Koha are you using? |
| 12:37 |
|
Null404 |
18.11 |
| 12:37 |
|
Null404 |
yesterday I used 17.11 |
| 12:37 |
|
Joubu |
18.11.? |
| 12:37 |
|
wahanui |
18.11 is very new still |
| 12:37 |
|
Null404 |
18.11.16.000 |
| 12:38 |
|
koha-jenkins |
Project Koha_Master_U18 build #785: UNSTABLE in 54 min: https://jenkins.koha-community[…]a_Master_U18/785/ |
| 12:38 |
|
Null404 |
newest one |
| 12:38 |
|
Joubu |
there is no occurrence of "notloan" in 18.11.16 |
| 12:38 |
|
|
jzairo joined #koha |
| 12:39 |
|
Null404 |
Joubu: so I need to manually edit Items.pm ? |
| 12:42 |
|
Null404 |
yes, I got Internal Server Error every time when I want to reserve book that is NotForLoan |
| 12:43 |
|
Joubu |
with the same error in the log file? |
| 12:44 |
|
Null404 |
yes |
| 12:45 |
|
Joubu |
line 1433 in C4/Items.pm? |
| 12:46 |
|
Null404 |
yes, every time |
| 12:46 |
|
Null404 |
I got about 10 lines of same error |
| 12:47 |
|
|
Marie-Luce joined #koha |
| 12:48 |
|
Joubu |
Null404: try `sudo service memcached restart; sudo service apache2 restart; sudo service koha-common restart;` |
| 12:51 |
|
Null404 |
nope, same problems |
| 12:52 |
|
|
caroline joined #koha |
| 12:55 |
|
Joubu |
it cannot be line 1433 on 18.11.16, it's an empty line |
| 12:55 |
|
Null404 |
hm.. |
| 12:57 |
|
Null404 |
mine file have 2179 lines |
| 12:58 |
|
Null404 |
and yes 1433 is empty line |
| 12:59 |
|
Null404 |
1432 line is: "=head2 _set_derived_columns_for_mod" and line 1434 is : "_set_derived_column_for_mod($item); " |
| 13:00 |
|
|
khall joined #koha |
| 13:02 |
|
Joubu |
So you have something wrong in your setup. Where did you find the Koha version, on the about page? |
| 13:03 |
|
|
andreashm joined #koha |
| 13:04 |
|
|
inlibro joined #koha |
| 13:05 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:05 |
|
wahanui |
Congratulations! |
| 13:05 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #292: FIXED in 36 min: https://jenkins.koha-community[…]9_MDB_Latest/292/ |
| 13:29 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #13: SUCCESS in 51 min: https://jenkins.koha-community[…]ster_D10_Deps/13/ |
| 13:30 |
|
caroline |
oh! I just came back from a 2 day training this morning to see that we have 9 ppl on the docs team!!! Largest I've ever seen in my 2 1/2 yrs in the community (I admit, not very long considering Koha turned 20) |
| 13:31 |
|
* caroline |
is feeling optimistic for the future of the manual |
| 13:33 |
|
magnuse |
yay! |
| 13:39 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:39 |
|
wahanui |
Congratulations! |
| 13:39 |
|
koha-jenkins |
Project Koha_Master_D10 build #235: FIXED in 34 min: https://jenkins.koha-community[…]a_Master_D10/235/ |
| 13:49 |
|
|
vfernandes joined #koha |
| 13:49 |
|
vfernandes |
hi #koha |
| 13:49 |
|
vfernandes |
someone have encoding problem with authorities like "Michał" |
| 13:49 |
|
vfernandes |
? |
| 13:50 |
|
Joubu |
no, check the encoding in DB |
| 13:50 |
|
vfernandes |
"Can't escape \x{0142}, try uri_escape_utf8() instead" |
| 13:51 |
|
vfernandes |
error in plack logs |
| 13:51 |
|
Joubu |
when doing what? |
| 13:51 |
|
vfernandes |
lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm |
| 13:53 |
|
Joubu |
when doing what? |
| 13:54 |
|
vfernandes |
i'm working on Koha 16.11 |
| 13:54 |
|
vfernandes |
it's on build_query_compat |
| 13:55 |
|
Joubu |
Bug 12478: Fix encoding issue on facets |
| 13:55 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=12478 enhancement, P5 - low, ---, robin, CLOSED FIXED, Elasticsearch support for Koha |
| 13:55 |
|
Joubu |
it's in 16.05 |
| 13:58 |
|
|
cait1 joined #koha |
| 13:58 |
|
|
lukeG joined #koha |
| 14:04 |
|
|
inlibro joined #koha |
| 14:12 |
|
Null404 |
I'm back by the way |
| 14:13 |
|
Null404 |
Joubu: yes, in "About Koha" I found name of version |
| 14:16 |
|
koha-jenkins |
Project Koha_Master_D9 build #1334: SUCCESS in 37 min: https://jenkins.koha-community[…]a_Master_D9/1334/ |
| 14:23 |
|
cait1 |
hm I could use some help solving 25485 :( |
| 14:23 |
|
cait1 |
bug 25485 |
| 14:23 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25485 critical, P5 - low, ---, kyle, Needs Signoff , TinyMCE broken in Debian package installs |
| 14:23 |
|
cait1 |
we moved from bad to worse (partially broken editor to not working at all) |
| 14:25 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #318: SUCCESS in 55 min: https://jenkins.koha-community[…]aster_D9_My8/318/ |
| 14:27 |
|
Null404 |
I created account on https://translate.koha-community.org/ and I didn't get activation email from 3 hours |
| 14:34 |
|
|
cait joined #koha |
| 14:34 |
|
cait1 |
hm not good |
| 14:35 |
|
cait1 |
i can activate you manually |
| 14:35 |
|
cait1 |
but you might want to drop an email to the mailing list anyway |
| 14:35 |
|
cait1 |
did: did translate registration work for you? |
| 14:35 |
|
cait1 |
is ee you registrered not too long ago |
| 14:37 |
|
cait1 |
Null404: did you try twice? |
| 14:37 |
|
Null404 |
I tried |
| 14:37 |
|
cait1 |
please pm me the user name |
| 14:37 |
|
Null404 |
but "this e-mail" is in use |
| 14:37 |
|
Null404 |
Null404 |
| 14:38 |
|
cait1 |
i just opened a private chat with you, can you see that? |
| 14:38 |
|
cait1 |
fo rm eit's an extra tab, but it might appear different in your irc client |
| 14:38 |
|
Null404 |
no cait1 |
| 14:38 |
|
Null404 |
yes now |
| 14:54 |
|
koha-jenkins |
Project Koha_Master_U18 build #786: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_U18/786/ |
| 15:04 |
|
|
inlibro joined #koha |
| 15:13 |
|
cait1 |
tcohen: answered on the bug - yes, built a package and updated an existing installation with it |
| 15:39 |
|
|
lisettelatah joined #koha |
| 15:42 |
|
reiveune |
bye |
| 15:42 |
|
|
reiveune left #koha |
| 15:47 |
|
Null404 |
cait1: I'm looking in pl-PL-staff-help.po and the most important functions should be translated |
| 15:48 |
|
cait1 |
that's the help files |
| 15:48 |
|
cait1 |
not the main gui |
| 15:48 |
|
cait1 |
try without -help |
| 15:48 |
|
Null404 |
not libriarian interface / opac ? |
| 15:49 |
|
Null404 |
I'm looking inside files |
| 15:49 |
|
cait1 |
only the help file parts when you click ? in the top corner |
| 15:49 |
|
cait1 |
ther eis another file |
| 15:49 |
|
cait1 |
with staff |
| 15:50 |
|
caroline |
mine is called staff-prog |
| 15:50 |
|
Null404 |
whoops, I pasted wrong filename |
| 15:50 |
|
cait1 |
ah, then you are probably good |
| 15:50 |
|
Null404 |
pl-PL-staff-prog.po - this is correct one |
| 15:51 |
|
Null404 |
and basic words like "not for loan" , "available" should be translated |
| 15:52 |
|
Null404 |
there are only 4 - 7 untranslated of these words |
| 15:52 |
|
cait1 |
so it's mostly current, that's good |
| 15:53 |
|
Null404 |
oh well, I will tried on monday, because I have 5 minutes to end of work ;) |
| 15:53 |
|
Null404 |
so happy weekend everyone |
| 15:53 |
|
* oleonard-away |
only just now realized it is Friday |
| 15:53 |
|
Null404 |
hehe |
| 15:56 |
|
|
davidnind joined #koha |
| 15:56 |
|
lisettelatah |
hello documentation webinar! |
| 15:56 |
|
* oleonard-away |
waves |
| 15:58 |
|
* cait1 |
is so tired of finding bugs today :( |
| 15:58 |
|
cait1 |
[% tnx('{count} item', '{count} items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | html %][% IF ( SEARCH_RESULT.availablecount ) %], [% SEARCH_RESULT.availablecount | html %] available:[% ELSE %], None available[% END %] |
| 15:58 |
|
cait1 |
doesn't work in 18.11 |
| 15:58 |
|
caroline |
ah forgot about the webinar! |
| 15:58 |
|
cait1 |
the tinymce is broken |
| 15:58 |
|
cait1 |
and gah. |
| 15:58 |
|
cait1 |
oh |
| 15:58 |
|
cait1 |
that was bad tming for a pre-weekend rant |
| 15:58 |
|
* cait1 |
waves and smiles |
| 15:59 |
|
davidnind |
cait1++ |
| 16:00 |
|
lisettelatah |
cait1 Jessie just showed her screen for a minute to encourage people to go to the IRC if they had questions. |
| 16:00 |
|
cait1 |
i hope i didn't scare them all off |
| 16:01 |
|
lisettelatah |
no no, they saw my hello but by the time oleonard waved she had switched away |
| 16:01 |
|
cait1 |
puh thx :) |
| 16:01 |
|
cait1 |
i've just been running from one bug to the next today, it added up a bit |
| 16:02 |
|
lisettelatah |
I haven't been doing as much bug tracking this week, but I've had about 3 days with lots of little things adding up this week. |
| 16:03 |
|
cait1 |
might be just this week is wierd |
| 16:03 |
|
cait1 |
we are about to run updates and suddenly eveything breaks under me |
| 16:03 |
|
caroline |
davidnind: did you see our team? https://wiki.koha-community.or[…]i/Roles_for_20.11 This is so cool! |
| 16:04 |
|
|
inlibro joined #koha |
| 16:05 |
|
koha-jenkins |
Project Koha_19.05_D9 build #209: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_D9/209/ |
| 16:06 |
|
davidnind |
caroline: yep, so many people! |
| 16:08 |
|
koha-jenkins |
Project Koha_19.05_D8 build #215: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_19.05_D8/215/ |
| 16:20 |
|
jzairo |
davidnind++ |
| 16:20 |
|
davidnind |
jzairo++ |
| 16:20 |
|
jzairo |
caroline++ |
| 16:20 |
|
davidnind |
caroline++ |
| 16:20 |
|
jzairo |
thank you! |
| 16:20 |
|
caroline |
jzairo++ thank so much for this! |
| 16:20 |
|
lisettelatah |
davidnind++ jzario++ caroline++ |
| 16:21 |
|
davidnind |
Thanks jzairo, that was great@ |
| 16:21 |
|
caroline |
and davidnind++ for picking up the slack in merging |
| 16:21 |
|
jzairo |
:) |
| 16:21 |
|
davidnind |
great to see so many interested |
| 16:22 |
|
caroline |
yes, I think these webinars will help librarians feel empowered |
| 16:23 |
|
davidnind |
caroline: no problems (I tend to review things a bit too much though...) |
| 16:23 |
|
caroline |
no reviewing is good! |
| 16:24 |
|
caroline |
helps find typos and things |
| 16:24 |
|
caroline |
I like to review too, but I become overwhelmed when there are many merge requests and I don't have time to do them all |
| 16:24 |
|
caroline |
will have to streamline my workflow to accomodate the larger team |
| 16:25 |
|
davidnind |
for me, I tend to be a perfectionist, so have to hold myself back to good enough (and review later) |
| 16:26 |
|
davidnind |
happy to do more, you can delegate, and work on other stuff :) |
| 16:27 |
|
* caroline |
has to learn to delegate more |
| 16:27 |
|
caroline |
https://en.wikipedia.org/wiki/[…]the_enemy_of_good |
| 16:27 |
|
davidnind |
ditto - I like to do everything myself... |
| 16:28 |
|
davidnind |
nice - I can use that! |
| 16:29 |
|
tuxayo |
Hi #koha :D |
| 16:29 |
|
tuxayo |
> propounded a "cult of the imperfect", which he stated as "Give them the third best to go on with; the second best comes too late, the best never comes." |
| 16:29 |
|
tuxayo |
This is great! |
| 16:31 |
|
caroline |
I have this in my home https://snipboard.io/IcmfOa.jpg |
| 16:32 |
|
caroline |
and ironically, it's in a frame that is grey instead of black like the others https://snipboard.io/vbm9Gc.jpg |
| 16:32 |
|
caroline |
totally by accident, but I decided to roll with it |
| 16:32 |
|
davidnind |
lol! |
| 16:32 |
|
tuxayo |
cait1: davidnind about bug 25485, IIUC the basic case (new install) still needs to be tested right? |
| 16:32 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25485 critical, P5 - low, ---, kyle, Needs Signoff , TinyMCE broken in Debian package installs |
| 16:32 |
|
tuxayo |
If I manage to built the packages[1]. Is there a way to use them in koha-testing-docker or a devbox? |
| 16:33 |
|
tuxayo |
[1] https://wiki.koha-community.or[…]es_-_The_Easy_Way |
| 16:33 |
|
tuxayo |
caroline: nice :D |
| 16:33 |
|
cait1 |
tuxayo - sorry, I didn't do the packaging part, my coworker did |
| 16:33 |
|
cait1 |
i am not sure... and not sure if our test makes sense |
| 16:34 |
|
cait1 |
khall: aorund? |
| 16:34 |
|
davidnind |
caroline: I need to get one of those! |
| 16:34 |
|
cait1 |
can we order them from you? ;) |
| 16:35 |
|
caroline |
I got it from this artist (NSFW warning - lots of cuss words) https://www.marieclaudemarquis.com/ |
| 16:36 |
|
koha-jenkins |
Project Koha_19.05_U18 build #213: SUCCESS in 31 min: https://jenkins.koha-community[…]ha_19.05_U18/213/ |
| 16:37 |
|
davidnind |
tuxayo: I have no idea about that, sorry... |
| 16:37 |
|
caroline |
She has magnets and buttons too https://www.etsy.com/ca/listin[…]e_active_20&crt=1 |
| 16:42 |
|
davidnind |
lots of great stuff, excellent! |
| 16:43 |
|
davidnind |
also likes the phrase "cuss words" |
| 16:45 |
|
tuxayo |
cait1: «not sure if our test makes sense» |
| 16:45 |
|
tuxayo |
Same boat, not sure mine would if I manage to do it :P |
| 16:46 |
|
cait1 |
we need help |
| 16:47 |
|
tuxayo |
Because sometimes hammering the bug and patch together on top of Koha doesn't result in a good signoff. |
| 16:52 |
|
koha-jenkins |
Project Koha_19.05_D9 build #210: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_19.05_D9/210/ |
| 16:56 |
|
davidnind |
tuxayo: I'd have no idea how to do step 5, so would pass on testing that one; if I had time I'd ask the author how o do that... |
| 16:58 |
|
cait1 |
tuxayoi am going to do a git bisect on my dev installaiton - it hnk kyle's patch is not for 18.11. testing for master should continue separately |
| 17:02 |
|
koha-jenkins |
Project Koha_19.05_D8 build #216: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_19.05_D8/216/ |
| 17:02 |
|
tuxayo |
davidnind: thanks the info. This is how we should build is seems. |
| 17:02 |
|
tuxayo |
https://wiki.koha-community.or[…]es_-_The_Easy_Way |
| 17:02 |
|
tuxayo |
*it |
| 17:03 |
|
tuxayo |
davidnind: in what kind of env did you try the installation? |
| 17:03 |
|
cait1 |
... or I would git bisect my problem if i could find a good commit - mibht be related to something elese after all |
| 17:03 |
|
tuxayo |
cait1: what do you aim to find by bisecting? |
| 17:03 |
|
cait1 |
i was hoping to see hwne hte editor broke |
| 17:04 |
|
cait1 |
but i am a few hundred commits back now... and it's still not working right |
| 17:04 |
|
tuxayo |
cait1: I think it's the Debian system that should be bisected right? That's what changes over time. Not Koha i guess (at least the tinyMCE part). |
| 17:05 |
|
|
inlibro joined #koha |
| 17:05 |
|
cait1 |
i was wondering if our problem was different |
| 17:05 |
|
cait1 |
to the one repoted... but I am starting to doubt and these paths are really confusing |
| 17:05 |
|
tuxayo |
> Debian system that should be bisected |
| 17:05 |
|
tuxayo |
Which probably happened from D9 to D10 |
| 17:06 |
|
tuxayo |
> i was wondering if our problem was different to the one repoted |
| 17:06 |
|
tuxayo |
I see |
| 17:06 |
|
|
did joined #koha |
| 17:06 |
|
cait1 |
our old 17.11 ones are ok |
| 17:06 |
|
cait1 |
and they also got a debian update |
| 17:06 |
|
kidclamp |
i thinkthe tiny mce problem we saw the other day |
| 17:06 |
|
tuxayo |
Could be, it's vert confusing indeed. |
| 17:06 |
|
cait1 |
it's only the 18.11 that show the breakage |
| 17:06 |
|
kidclamp |
Oleonard updated the version in our repo recently ish |
| 17:06 |
|
cait1 |
kidclamp: my problem is in 18.11 :( |
| 17:06 |
|
tuxayo |
cait1: same Debian between your 17.11 and 18.11 ? |
| 17:06 |
|
cait1 |
tuxayo yep |
| 17:06 |
|
kidclamp |
but when you install koha, we go and get the debian package and write it over the shipped package |
| 17:07 |
|
kidclamp |
so you aere missing the min.js file |
| 17:07 |
|
cait1 |
kidclamp: i am missing something else |
| 17:07 |
|
cait1 |
that's the odd big |
| 17:07 |
|
cait1 |
bit |
| 17:07 |
|
cait1 |
dialog.css |
| 17:07 |
|
cait1 |
so it breaks all the pop ups in the editor |
| 17:07 |
|
cait1 |
when you want to add a file, and especially adding a link |
| 17:07 |
|
kidclamp |
may astill be same issue |
| 17:07 |
|
cait1 |
i was wondering, but after kyles patch the ditor is gone |
| 17:07 |
|
cait1 |
totally |
| 17:08 |
|
cait1 |
so we went from partial breakage to total breakage |
| 17:08 |
|
kidclamp |
sounds hard |
| 17:08 |
|
* kidclamp |
run away |
| 17:08 |
|
cait1 |
oh please don't... i need help? |
| 17:08 |
|
tuxayo |
^^" |
| 17:08 |
|
kidclamp |
:-) |
| 17:08 |
|
cait1 |
i don't have a clue still how all these shoudl fit togehter |
| 17:08 |
|
cait1 |
ah another thing: it's broken in my devbox |
| 17:08 |
|
cait1 |
that's not a pacakge install... or a gitified one...? |
| 17:09 |
|
cait1 |
so i see the issue we have both in our test installations with packages and my local env |
| 17:10 |
|
cait1 |
oleonard: any chance i could bribe yo in checking out an 18.11 and have a look? |
| 17:10 |
|
tuxayo |
cait1: makes sense that it would no only affect package installs. Dev env also use scripts from package install right? |
| 17:10 |
|
cait1 |
but the file structure is quite different |
| 17:10 |
|
cait1 |
and kyle's bug specifies package installs |
| 17:11 |
|
tuxayo |
Indeed. |
| 17:11 |
|
oleonard |
Are we still talking about tinyMCE? Yesterday I tried checking out 18.11.x, reset_all, and testing. I could verify the problem. |
| 17:11 |
|
oleonard |
Are we testing a fix? |
| 17:11 |
|
* oleonard |
hasn't been paying attention |
| 17:11 |
|
cait1 |
oleonard: yes, we ttested kyle's patch and it broke everything |
| 17:11 |
|
cait1 |
so it might not be the right fix or just not hte fix for 18.11 |
| 17:11 |
|
oleonard |
:( |
| 17:11 |
|
cait1 |
and I am lost |
| 17:12 |
|
cait1 |
but that you can see it too is a tiny bit of relief :) |
| 17:12 |
|
tuxayo |
oleonard: «Yesterday I tried checking out 18.11.x, reset_all, and testing. I could verify the problem.» |
| 17:12 |
|
tuxayo |
Even on a dev env you could verify the problem? |
| 17:12 |
|
cait1 |
thank you for that |
| 17:13 |
|
oleonard |
tuxayo: Yes, in koha-testing-docker |
| 17:13 |
|
cait1 |
same for me here - with kohadevbox |
| 17:13 |
|
cait1 |
at leas it's not a bug that hides |
| 17:13 |
|
oleonard |
We have tinymce in version-control. Why are we messing with Debian packages? |
| 17:13 |
|
tuxayo |
«historical reasons» |
| 17:14 |
|
cait1 |
no idea whatsoever |
| 17:14 |
|
tuxayo |
oleonard: «Yes, in koha-testing-docker» nice that makes early testing easier. |
| 17:14 |
|
cait1 |
i am sill trying to find a good commit - i am in april 2018 now |
| 17:14 |
|
tuxayo |
cait1: «same for me here - with kohadevbox» On 18.11 or master? |
| 17:14 |
|
cait1 |
all on 18.11 |
| 17:15 |
|
cait1 |
i believe someonee checked that master has god pop-ups? |
| 17:15 |
|
cait1 |
alos has the newer tinymce i believe |
| 17:15 |
|
oleonard |
Yes |
| 17:15 |
|
tuxayo |
cait1: oleonard When spinning and env on 18.11 bisecting on many month/years. You have to ensure the perldeps come from the right repo right? |
| 17:15 |
|
cait1 |
i was thinking it might be a chance in koha fiel |
| 17:15 |
|
cait1 |
s |
| 17:16 |
|
cait1 |
so i jump back in time and restart all... so far the template still works, but tinymce is always broken |
| 17:16 |
|
cait1 |
you could do a reset_all too... but the table structure there hasn't changed really |
| 17:17 |
|
cait1 |
oooh |
| 17:17 |
|
cait1 |
found a good one |
| 17:17 |
|
cait1 |
october 2017 |
| 17:17 |
|
cait1 |
lol |
| 17:18 |
|
cait1 |
now i need to figure out the git bisect command again |
| 17:20 |
|
oleonard |
I seriously want to yell about this: WHY do we use Debian packages for TinyMCE?? |
| 17:20 |
|
tcohen |
lets start from scratch whatever the reasons were by that time |
| 17:20 |
|
tcohen |
khall is 100% right about removing that |
| 17:20 |
|
tcohen |
and also the jquery deps |
| 17:20 |
|
cait1 |
i am ok with all that |
| 17:20 |
|
tcohen |
khall++ # for spotting this |
| 17:20 |
|
cait1 |
but it did not work for our ancient one .( |
| 17:20 |
|
cait1 |
so we might be missing something |
| 17:21 |
|
tcohen |
did: you need to change your nickname or we will bother you too much |
| 17:21 |
|
oleonard |
(I know, right??) |
| 17:21 |
|
tcohen |
cait1 if your packages are working, leave them alone and fix this is master |
| 17:22 |
|
tuxayo |
oleonard: «WHY do we use Debian packages for TinyMCE??» |
| 17:22 |
|
tuxayo |
We will never know. It seems even jquery came from the packages at some point! |
| 17:22 |
|
cait1 |
tcohen: ? they are not working |
| 17:22 |
|
oleonard |
I'm taking it very personally :) Like someone was sneaking around behind my back! |
| 17:23 |
|
tcohen |
oleonard lets fix this |
| 17:23 |
|
tcohen |
and use something to bundle the deps in a kosher way |
| 17:24 |
|
tuxayo |
+1 |
| 17:24 |
|
oleonard |
So khall's patch simply removes the dependency and the link... that's good. But it doesn't fully solve the problem |
| 17:25 |
|
tcohen |
I haven't looked at the patch in depth |
| 17:25 |
|
cait1 |
dcook left a lot of (confusing to me) comments |
| 17:25 |
|
tcohen |
what I would expect is nothing removed on packaging and no external links |
| 17:25 |
|
cait1 |
maybe someoen with deeper understanding of these things can figure itout |
| 17:25 |
|
tcohen |
dcook always confuses us |
| 17:25 |
|
tcohen |
If we knew someone |
| 17:26 |
|
tuxayo |
I confused dcook with davidnind ^^" That why I asked you questions about this bug. |
| 17:27 |
|
tuxayo |
You also tested it so you held well to the role davidnind :P |
| 17:28 |
|
oleonard |
I'm onboard to try to help, but I don't know how |
| 17:29 |
|
tuxayo |
cait1: oleonard : how do you cleanly handle the perldeps when spinning a dev env on an older koha version? Like you did for this bug. |
| 17:29 |
|
tcohen |
ktd and kohadevbox are useless to test that bug |
| 17:29 |
|
tcohen |
as everything is gitified |
| 17:30 |
|
tcohen |
you need a 'clean' VPS or container, in which you manually install the package you've just built |
| 17:30 |
|
tcohen |
luckily, there's koha-dpkg-docker |
| 17:30 |
|
tcohen |
and that's your weekend homework |
| 17:30 |
|
tcohen |
LOL |
| 17:32 |
|
tuxayo |
Thanks for the pointers. Though the bugs happen also in dev env despite the gitification. That doesn't mean the fix will work there ^^" |
| 17:32 |
|
* oleonard |
disappears back into his burrow |
| 17:34 |
|
tuxayo |
«burrow: A tunnel or hole, often as dug by a small creature.» |
| 17:34 |
|
* tuxayo |
feels bug25485 is a nice rabbit hole, no need to move |
| 17:35 |
|
tuxayo |
> luckily, there's koha-dpkg-docker |
| 17:35 |
|
tuxayo |
tcohen this one is the most up to date right? https://gitlab.com/tomascohen/koha-dpkg-docker |
| 17:36 |
|
tcohen |
tuxayo refer to the docker hub page instead |
| 17:36 |
|
tcohen |
but yes |
| 17:36 |
|
tcohen |
I mean, don't build it yourself |
| 17:36 |
|
tcohen |
use the one in dockerhub |
| 17:36 |
|
tcohen |
https://hub.docker.com/r/koha/koha-dpkg/ |
| 17:37 |
|
tcohen |
I created that for using it on a pipeline |
| 17:37 |
|
tcohen |
for testing packages building and installing |
| 17:37 |
|
tcohen |
and we can then add tests like 'instance gets created' 'permissions on the logs are right' etc |
| 17:38 |
|
tuxayo |
thanks! |
| 17:38 |
|
tuxayo |
So koha-dpkg-docker would be more relevant to use than the following? |
| 17:38 |
|
tuxayo |
https://wiki.koha-community.or[…]es_-_The_Easy_Way |
| 17:38 |
|
tuxayo |
> for testing packages building and installing |
| 17:38 |
|
tuxayo |
This would be great. |
| 17:38 |
|
tuxayo |
tcohen++ |
| 17:42 |
|
cait1 |
Interesting |
| 17:42 |
|
cait1 |
Bug 12904: Force browser to load new javascript files after upgrade |
| 17:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=12904 enhancement, P5 - low, ---, kyle, CLOSED FIXED, Force browser to load new JavaScript and CSS files after upgrade |
| 17:45 |
|
tuxayo |
So IIUC the cleanest way to test this while being simple enough be less like likely to be messed up is: |
| 17:45 |
|
tuxayo |
- make a packages with https://hub.docker.com/r/koha/koha-dpkg |
| 17:45 |
|
tuxayo |
- spin a standard Debian (9?) however ones want |
| 17:46 |
|
tuxayo |
- install the packages following https://wiki.koha-community.or[…]ki/Koha_on_Debian |
| 17:47 |
|
tuxayo |
Anything missing? |
| 17:48 |
|
cait1 |
https://bugs.koha-community.or[…]ment.cgi?id=71550 |
| 17:50 |
|
tuxayo |
cait1: good find! |
| 17:50 |
|
cait1 |
not quite... still not sure how these apply |
| 17:51 |
|
cait1 |
right ow i am ot sure if the paths are wrong... apache rewrite rules are wrong... or whatever |
| 17:54 |
|
cait1 |
it appears it looks for the css in the wrong spot: http://localhost:8081/cgi-bin/[…]efault/dialog.css |
| 17:55 |
|
cait1 |
it shoudl start out like this: http://localhost:8081/intranet[…]/themes/advanced/ |
| 17:56 |
|
cait1 |
http://localhost:8081/intranet[…]efault/dialog.css < this wuld be correct |
| 17:56 |
|
cait1 |
i am slightly confused why it would look in koha/tools? |
| 17:57 |
|
cait1 |
hm because i am on news... and that's where the pl is |
| 17:58 |
|
cait1 |
oleonard: does anything of that spark something for you? |
| 17:59 |
|
cait1 |
to me it looks like setting the baseurl like kyle did might not transfer to the popups |
| 18:00 |
|
cait1 |
https://stackoverflow.com/ques[…]rows-404/15277380 - i am not the first |
| 18:04 |
|
koha-jenkins |
Project Koha_19.05_U18 build #214: SUCCESS in 31 min: https://jenkins.koha-community[…]ha_19.05_U18/214/ |
| 18:05 |
|
|
inlibro joined #koha |
| 18:06 |
|
koha-jenkins |
Project Koha_19.05_D8 build #217: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_19.05_D8/217/ |
| 18:16 |
|
cait1 |
oleonard: i found a fix - do you htink that#s safe? http://paste.koha-community.org/20416 |
| 18:28 |
|
cait1 |
sorry, i guess i used you all as rubberducks a bit... been a too long day |
| 18:29 |
|
|
msr joined #koha |
| 18:34 |
|
oleonard |
cait1 looks safe to me |
| 18:34 |
|
koha-jenkins |
Project Koha_19.05_D9 build #211: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_D9/211/ |
| 18:34 |
|
cait1 |
thank you |
| 18:34 |
|
cait1 |
oleonard++ and community++ thx for not throwing me off irc |
| 18:42 |
|
* tuxayo |
is back here |
| 18:43 |
|
tuxayo |
> sorry, i guess i used you all as rubberducks a bit... been a too long day |
| 18:43 |
|
tuxayo |
No worries. It's useful. |
| 18:43 |
|
cait1 |
it looks like i have a owrking patch for the laatest 18.11.16 |
| 18:43 |
|
tuxayo |
cait1++ # for the fix |
| 18:44 |
|
tuxayo |
This is great! |
| 18:44 |
|
tuxayo |
congratulations for managing to get out of the hole ^^ |
| 18:44 |
|
cait1 |
trying to clean up my chaos a bit now |
| 18:44 |
|
cait1 |
i think we still need to fix the other tnymce issue tho :) |
| 18:52 |
|
koha-jenkins |
Project Koha_19.05_U18 build #215: SUCCESS in 45 min: https://jenkins.koha-community[…]ha_19.05_U18/215/ |
| 18:57 |
|
|
cait1 left #koha |
| 18:59 |
|
caroline |
does anyone ever work with build_authorities and link_bibs_to_authorities? I'm having a hard time understanding how they work |
| 18:59 |
|
koha-jenkins |
Project Koha_19.05_D8 build #218: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_19.05_D8/218/ |
| 19:00 |
|
caroline |
I start with 0 authorities. I run build_authorities, I get my authorities, but they are not linked, so I run link_bibs_to_authorities and only some authorities end up being linked... why? I just created them from the biblios |
| 19:05 |
|
|
inlibro joined #koha |
| 19:13 |
|
|
cait joined #koha |
| 19:14 |
|
* cait |
waves |
| 19:15 |
|
cait |
caroline: i seem to remember bywater had some blog posts about the linker |
| 19:16 |
|
cait |
it might be you need different settings for the linker prefs? |
| 19:17 |
|
caroline |
ok I'll look into that |
| 19:31 |
|
koha-jenkins |
Project Koha_19.05_U18 build #216: SUCCESS in 31 min: https://jenkins.koha-community[…]ha_19.05_U18/216/ |
| 19:36 |
|
koha-jenkins |
Project Koha_19.05_D9 build #212: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_19.05_D9/212/ |
| 19:46 |
|
|
khall joined #koha |
| 20:00 |
|
|
khall joined #koha |
| 20:05 |
|
|
inlibro joined #koha |
| 20:07 |
|
|
jzairo left #koha |
| 20:17 |
|
|
talljoy joined #koha |
| 20:26 |
|
|
andreashm joined #koha |
| 20:32 |
|
koha-jenkins |
Project Koha_19.05_U18 build #217: SUCCESS in 30 min: https://jenkins.koha-community[…]ha_19.05_U18/217/ |
| 20:43 |
|
koha-jenkins |
Project Koha_19.05_D9 build #213: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_19.05_D9/213/ |
| 20:55 |
|
|
hayley joined #koha |
| 20:57 |
|
koha-jenkins |
Project Koha_19.05_D8 build #219: UNSTABLE in 24 min: https://jenkins.koha-community[…]oha_19.05_D8/219/ |
| 21:05 |
|
|
inlibro joined #koha |
| 21:18 |
|
tuxayo |
caroline: If still blocked your next step might be to ask on the koha-fr list. I heard about that at BibLibre about link_bibs_to_authorities |
| 21:18 |
|
tuxayo |
so you might get answers from someone at BibLibre or one of the big libraries that was using them. (I don't remember who) |
| 21:19 |
|
caroline |
thanks tuxayo! |
| 21:28 |
|
koha-jenkins |
Project Koha_19.05_D9 build #214: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_D9/214/ |
| 21:28 |
|
koha-jenkins |
Project Koha_19.05_U18 build #218: SUCCESS in 44 min: https://jenkins.koha-community[…]ha_19.05_U18/218/ |
| 21:33 |
|
|
tcohen joined #koha |
| 21:52 |
|
koha-jenkins |
Yippee, build fixed! |
| 21:52 |
|
wahanui |
Congratulations! |
| 21:52 |
|
koha-jenkins |
Project Koha_19.05_D8 build #220: FIXED in 24 min: https://jenkins.koha-community[…]oha_19.05_D8/220/ |
| 21:57 |
|
|
hayley joined #koha |
| 22:06 |
|
|
inlibro joined #koha |
| 22:11 |
|
koha-jenkins |
Project Koha_19.05_D9 build #215: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_19.05_D9/215/ |
| 22:18 |
|
caroline |
Have a nice weekend all! Monday is a holiday here, so I'll see you on Tuesday! :) |
| 22:18 |
|
davidnind |
have a great long weekend! |
| 22:24 |
|
koha-jenkins |
Project Koha_19.05_U18 build #219: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_19.05_U18/219/ |
| 22:44 |
|
koha-jenkins |
Project Koha_19.05_D8 build #221: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_19.05_D8/221/ |
| 22:54 |
|
koha-jenkins |
Project Koha_19.05_D9 build #216: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_19.05_D9/216/ |
| 23:06 |
|
|
inlibro joined #koha |
| 23:19 |
|
koha-jenkins |
Project Koha_19.05_D8 build #222: SUCCESS in 24 min: https://jenkins.koha-community[…]oha_19.05_D8/222/ |
| 23:29 |
|
koha-jenkins |
Project Koha_19.05_U18 build #220: UNSTABLE in 45 min: https://jenkins.koha-community[…]ha_19.05_U18/220/ |
| 23:49 |
|
koha-jenkins |
Project Koha_19.05_D9 build #217: SUCCESS in 29 min: https://jenkins.koha-community[…]oha_19.05_D9/217/ |
