| Time |
S |
Nick |
Message |
| 00:16 |
|
|
dj_ joined #koha |
| 00:19 |
|
|
BobB joined #koha |
| 00:19 |
|
|
irma joined #koha |
| 00:19 |
|
|
kathryn joined #koha |
| 00:19 |
|
|
hayley joined #koha |
| 00:19 |
|
|
tosca joined #koha |
| 00:19 |
|
|
aleisha joined #koha |
| 00:19 |
|
|
alexbuckley joined #koha |
| 00:19 |
|
|
rangi_ joined #koha |
| 00:20 |
|
|
mtj joined #koha |
| 00:20 |
|
|
alohalog` joined #koha |
| 00:21 |
|
|
eythian joined #koha |
| 00:29 |
|
|
ribasushi joined #koha |
| 00:38 |
|
|
inlibro joined #koha |
| 01:04 |
|
|
alexbuckley joined #koha |
| 01:38 |
|
|
inlibro joined #koha |
| 02:20 |
|
|
bdonnahue joined #koha |
| 02:38 |
|
|
inlibro joined #koha |
| 03:39 |
|
|
inlibro joined #koha |
| 03:51 |
|
|
alexbuckley joined #koha |
| 04:10 |
|
|
deb-CSPL joined #koha |
| 04:10 |
|
|
Scott-CSPL joined #koha |
| 04:39 |
|
|
inlibro joined #koha |
| 05:23 |
|
|
inlibro_ joined #koha |
| 05:39 |
|
|
inlibro joined #koha |
| 06:08 |
|
|
chriss joined #koha |
| 06:39 |
|
|
inlibro joined #koha |
| 06:39 |
|
|
fridolin joined #koha |
| 06:52 |
|
|
cait joined #koha |
| 07:39 |
|
|
inlibro joined #koha |
| 07:40 |
|
|
reiveune joined #koha |
| 07:40 |
|
reiveune |
hello |
| 07:48 |
|
magnuse |
bonjour reiveune et #koha! |
| 07:53 |
|
ere |
good morning! |
| 07:54 |
|
ashimema |
morning ere.. |
| 07:54 |
|
ashimema |
it's good to have you back :) |
| 07:54 |
|
* ashimema |
ere for qa team next cycle |
| 07:56 |
|
kohaputti |
ashimema, heheh, I was thinking asking that too, but I'm worried ere has too much to do |
| 07:57 |
|
|
alex_a joined #koha |
| 07:57 |
|
alex_a |
Bonjour |
| 07:57 |
|
wahanui |
que tal, alex_a |
| 07:57 |
|
ashimema |
well.. I'm of the opinion that 'every little helps'.. he has expertise in area's many of us don't.. if he can get 6 bugs in those area's moving along per cycle. (that's only one per month), that'll actually be an awesome contribution :) |
| 07:57 |
|
ere |
ashimema: Thanks, it's good to do some Koha work too, but sadly kohaputti is right.. Plus I'll be on parental leave from mid March to mid May, which further complicates things. |
| 07:57 |
|
ashimema |
no worries.. always worth asking :) |
| 07:58 |
|
|
did1 joined #koha |
| 07:58 |
|
ere |
How's the cycle defined anyway? |
| 08:00 |
|
ashimema |
hmm.. I thought we had some good pages describing our 'cycle' |
| 08:00 |
|
ashimema |
https://wiki.koha-community.or[…]i/Koha_Versioning |
| 08:00 |
|
ashimema |
https://koha-community.org/abo[…]release-schedule/ |
| 08:00 |
|
ashimema |
those are all I can find |
| 08:01 |
|
ere |
I know the release cycle, but is QA cycle the same? |
| 08:01 |
|
ashimema |
yeah.. we re-elect the team as a whole every cycle |
| 08:02 |
|
ashimema |
so you're only 'committed' to being in the QA team for 6 months.. (you can of course bow out early if life gets in the way) and can of course re-run for the next cycle.. |
| 08:02 |
|
ashimema |
hense why you often see 'continuing' on the roles election page.. |
| 08:02 |
|
ere |
ok, good to know |
| 08:02 |
|
ashimema |
:) |
| 08:03 |
|
ashimema |
we have been known to add people to the QA team mid cycle occassionaly too if we deem fit |
| 08:04 |
|
ashimema |
I also tend to accept QA signoffs from topic experts in their respective area's.. sometimes people find it easier to commit to being a topic expert than a fully fledged qa team member.. but in reality whatever one can do to help keep developments moving through the queue is good in my book :) |
| 08:04 |
|
ashimema |
kohaputti has been an excellent addition to the team :) |
| 08:05 |
|
ashimema |
we should probably highlight peoples cnotributions better.. I tend to try to do that a bit more with each cycle :) |
| 08:06 |
|
ashimema |
the about pages inside koha itself have gotten allot better in recent releases, as have the release notes I feel |
| 08:13 |
|
|
fridolin joined #koha |
| 08:16 |
|
|
andreashm joined #koha |
| 08:20 |
|
|
paul_p joined #koha |
| 08:34 |
|
|
andreashm joined #koha |
| 08:38 |
|
magnuse |
huh? shouldn't koha just pick up and run files in atomicupdates when you test a bug with an atomic update? |
| 08:39 |
|
magnuse |
even if i do "$ sudo koha-shell -c "perl installer/data/mysql/atomicupdate/bug21190.perl" kohadev" i get: Undefined subroutine &main::CheckVersion called at installer/data/mysql/atomicupdate/bug21190.perl line 2 |
| 08:39 |
|
* magnuse |
does not do this often enough |
| 08:39 |
|
|
inlibro joined #koha |
| 08:39 |
|
|
davidnind joined #koha |
| 08:41 |
|
ashimema |
I always run them via updatedatabase |
| 08:41 |
|
ashimema |
that will pick any/all atomicupdates |
| 08:41 |
|
* ashimema |
always runs them twice too as part of checking their idempotent |
| 08:43 |
|
magnuse |
ah yes, "sudo koha-upgrade-schema kohadev" did the trick |
| 08:43 |
|
magnuse |
ashimema++ |
| 08:44 |
|
ashimema |
:) |
| 08:51 |
|
|
cait joined #koha |
| 08:53 |
|
cait |
good morning #koha |
| 08:55 |
|
magnuse |
kia ora cait |
| 09:04 |
|
|
andreashm joined #koha |
| 09:17 |
|
|
andreashm joined #koha |
| 09:17 |
|
ere |
ashimema++ |
| 09:32 |
|
|
andreashm joined #koha |
| 09:40 |
|
|
inlibro joined #koha |
| 09:41 |
|
huginn |
News from kohagit: Bug 23493: (RM follow-up) Let datatables calculate colspan for us <http://git.koha-community.org/[…]220ae226617ad2a3f> |
| 09:41 |
|
huginn |
News from kohagit: Bug 23493: Fix selenium/regressions.t <http://git.koha-community.org/[…]e9cc23bb8cde39b60> |
| 09:41 |
|
huginn |
News from kohagit: Bug 22868: DBRev 19.12.00.016 <http://git.koha-community.org/[…]cc278fdac362c01c4> |
| 09:41 |
|
huginn |
News from kohagit: Bug 22868: Move suggestions_manage subperm out of acquisition perm <http://git.koha-community.org/[…]85454c24112e6f984> |
| 09:54 |
|
Joubu |
bug 24542 |
| 09:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24542 blocker, P5 - low, ---, jonathan.druart, Needs Signoff , Checkout page - Can't locate object method "search" via package "Koha::Account::DebitTypes" |
| 09:56 |
|
|
fridolin joined #koha |
| 09:58 |
|
|
andreashm joined #koha |
| 09:59 |
|
ashimema |
yikes |
| 10:00 |
|
ashimema |
thanks Jonathan.. not sure how we missed that! |
| 10:01 |
|
|
andreashm joined #koha |
| 10:03 |
|
huginn |
News from kohagit: Bug 24542: (bug 23049 follow-up) Add missing use statement in Koha::Account <http://git.koha-community.org/[…]afe0e630033e9c126> |
| 10:05 |
|
|
vfernandes joined #koha |
| 10:12 |
|
|
paul_p joined #koha |
| 10:18 |
|
koha-jenkins |
Project Koha_Master_D8 build #651: STILL UNSTABLE in 35 min: https://jenkins.koha-community[…]ha_Master_D8/651/ |
| 10:20 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #101: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]9_MDB_Latest/101/ |
| 10:25 |
|
koha-jenkins |
Project Koha_Master_D8 build #652: FAILURE in 7 min 11 sec: https://jenkins.koha-community[…]ha_Master_D8/652/ |
| 10:30 |
|
|
davidnind left #koha |
| 10:37 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #122: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]aster_D9_My8/122/ |
| 10:40 |
|
|
inlibro joined #koha |
| 10:54 |
|
|
xoan joined #koha |
| 10:59 |
|
|
alex_a joined #koha |
| 10:59 |
|
koha-jenkins |
Project Koha_Master_U18 build #584: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_U18/584/ |
| 11:08 |
|
cait |
oloenard++ ashimema++ |
| 11:08 |
|
ashimema |
? |
| 11:08 |
|
cait |
just... pushing things and noticing cookies? :) |
| 11:08 |
|
ashimema |
:) |
| 11:08 |
|
ashimema |
nom, nom |
| 11:09 |
|
cait |
we got asked about the cookie documentation jsut a little while back - was glad about being able to just pass some links on |
| 11:10 |
|
ashimema |
we should probably record it within koha.. on the about page somewhere |
| 11:10 |
|
ashimema |
rather than it being entirely external |
| 11:10 |
|
ashimema |
but.. it's good we have it somewhere |
| 11:10 |
|
cait |
yep |
| 11:10 |
|
cait |
i had to do it - so it made sense to put on the wiki |
| 11:10 |
|
cait |
we also have a german translation of it on our pages |
| 11:11 |
|
* ashimema |
is contemplating what to do next.. |
| 11:11 |
|
ashimema |
go on an SO/QA spree.. |
| 11:12 |
|
ashimema |
continue to grow the accounts tree.. but it's already hard to keep on top of whilst waiting for SO/QA.. |
| 11:12 |
|
ashimema |
continue to grow the transfers tree.. but same challenge as above. |
| 11:12 |
|
ashimema |
hmm. |
| 11:13 |
|
koha-jenkins |
Project Koha_Master_D9 build #1113: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_D9/1113/ |
| 11:18 |
|
|
xoan joined #koha |
| 11:22 |
|
|
andreashm joined #koha |
| 11:26 |
|
koha-jenkins |
Project Koha_Master_D8 build #653: NOW UNSTABLE in 35 min: https://jenkins.koha-community[…]ha_Master_D8/653/ |
| 11:26 |
|
|
marcelr joined #koha |
| 11:26 |
|
marcelr |
hi #koha |
| 11:28 |
|
marcelr |
ashimema sure you pushed 23896? dont see him |
| 11:29 |
|
ashimema |
have now.. |
| 11:29 |
|
huginn |
News from kohagit: Bug 23594: Fix bad resolution conflict with bug 16784 <http://git.koha-community.org/[…]a878234c7b70dce2a> |
| 11:29 |
|
huginn |
News from kohagit: Bug 23594: Add missing html filters <http://git.koha-community.org/[…]c58627da0f80aec04> |
| 11:29 |
|
huginn |
News from kohagit: Bug 23031: Make 'add to basket' accessible in one click (fix regression) <http://git.koha-community.org/[…]460e3bfb32a9f5fbd> |
| 11:29 |
|
huginn |
News from kohagit: Bug 17697: Improve NotesBlacklist system preference description <http://git.koha-community.org/[…]4abbd1293ac747569> |
| 11:29 |
|
huginn |
News from kohagit: Bug 24347: (follow-up) Remove custom catalog search from acquisitions <http://git.koha-community.org/[…]72931967cf54943e9> |
| 11:29 |
|
huginn |
News from kohagit: Bug 24347: Add a 'search to order' option similar to 'search to hold' <http://git.koha-community.org/[…]1ff581d59955406f3> |
| 11:29 |
|
ashimema |
forgot to do the actual 'push' but.. |
| 11:29 |
|
huginn |
News from kohagit: Bug 23915: Replace OPAC list sort menu with Bootstrap menu button <http://git.koha-community.org/[…]a915fb757672a2179> |
| 11:29 |
|
huginn |
News from kohagit: Bug 23896: logaction should pass the correct interface to Koha::Logger <http://git.koha-community.org/[…]8fa029eca3570de15> |
| 11:29 |
|
huginn |
News from kohagit: Bug 23594: Restore previous view after delete or update itemtype <http://git.koha-community.org/[…]2cfd8456fe1fd7d9c> |
| 11:29 |
|
huginn |
News from kohagit: Bug 23594: Fix [un]checkall links <http://git.koha-community.org/[…]8f72e0a5212324296> |
| 11:29 |
|
huginn |
News from kohagit: Bug 23594: Batch modification for itemtypes on suggestions page <http://git.koha-community.org/[…]61c680ecf0b091f62> |
| 11:29 |
|
marcelr |
even more |
| 11:30 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #102: STILL UNSTABLE in 52 min: https://jenkins.koha-community[…]9_MDB_Latest/102/ |
| 11:30 |
|
ashimema |
indeed |
| 11:30 |
|
ashimema |
my workflow is to work through a set of bugs locally.. run the koha-push script which does a final check and then updates all the bz status's.. and then finally do the actual push to community repo.. |
| 11:31 |
|
ashimema |
seems my cat distracted me at the last step and I'd not hit 'enter' yet |
| 11:31 |
|
ashimema |
hehe |
| 11:31 |
|
marcelr |
poor cat |
| 11:31 |
|
marcelr |
glad you didnt hit him |
| 11:31 |
|
ashimema |
he's happy.. just had 10 minutes of cuddle :P |
| 11:33 |
|
marcelr |
ashimema: are you having trouble sending message to the general koha ml seeing the signature on your dev list mails ? |
| 11:33 |
|
|
khall joined #koha |
| 11:33 |
|
marcelr |
my mail two days ago was rejected without notice |
| 11:34 |
|
marcelr |
our server adds signature stuff too |
| 11:34 |
|
ashimema |
hmm.. |
| 11:34 |
|
ashimema |
I've not spotted any rejections |
| 11:35 |
|
cait |
it might be a mailing list config issue |
| 11:35 |
|
cait |
we have had to make some changes on ours for signed emails |
| 11:36 |
|
marcelr |
ashimema: your gbsd mail came thru indeed |
| 11:36 |
|
ashimema |
:) |
| 11:36 |
|
marcelr |
cait: i dont have control over the rijksmuseum mail server unfortunately |
| 11:36 |
|
cait |
ashimema: as for what to do next - could you check the accounts related email on the mailing list from last night? |
| 11:36 |
|
cait |
marcelr: i meant the mailing list server actually |
| 11:36 |
|
cait |
so it accepts them |
| 11:37 |
|
marcelr |
ok |
| 11:37 |
|
ashimema |
do you mean the one Joubu already fixed and I already pushed cait? |
| 11:38 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #123: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]aster_D9_My8/123/ |
| 11:40 |
|
|
inlibro joined #koha |
| 11:42 |
|
ashimema |
marcelr.. ask and you shall receive.. love that there's three signoffs on a bug without hours of you asking on dev lists |
| 11:43 |
|
ashimema |
I don't think it's that people don't care.. I just think there's so many bugs in the queue that it's hard to pick any out above any others |
| 11:43 |
|
marcelr |
after 3mo i start nagging |
| 11:44 |
|
ashimema |
hehe |
| 11:44 |
|
ashimema |
I understand :) |
| 11:44 |
|
marcelr |
nice to see the response now |
| 11:44 |
|
ashimema |
annoys me sometimes when the people originally requesting something drop it though.. that's soooo annoying |
| 11:44 |
|
ashimema |
:) |
| 11:47 |
|
cait |
nope |
| 11:47 |
|
cait |
another |
| 11:48 |
|
ashimema |
more of a clue? |
| 11:48 |
|
cait |
yes, but was on the phone :) |
| 11:48 |
|
cait |
give me a moment |
| 11:49 |
|
cait |
hm maybe it is the same |
| 11:50 |
|
ashimema |
hehe |
| 11:51 |
|
cait |
the secod part of it about debit types |
| 11:51 |
|
cait |
it looked a bit like separate issues on first glance |
| 11:52 |
|
cait |
https://lists.katipo.co.nz/pip[…]nuary/054228.html |
| 11:52 |
|
cait |
"unexepcted type found during upgrade" |
| 11:52 |
|
ashimema |
ok.. I'll try to explain |
| 11:52 |
|
ashimema |
it basically means they had crap in their database |
| 11:52 |
|
cait |
possibly not - bug 24532? |
| 11:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24532 major, P5 - low, ---, martin.renvoize, NEW , Some account types are converted to debits when they shouldn't be |
| 11:53 |
|
cait |
it looks like their issue is about pay and w as well |
| 11:53 |
|
ashimema |
yup.. I've asked for feedback on that one from nick |
| 11:53 |
|
cait |
ok |
| 11:53 |
|
cait |
all progressing then :) |
| 11:54 |
|
ashimema |
what it means is that they set something to 'Pay' in their manual invoices and then gave it's a negative 'amount' |
| 11:54 |
|
ashimema |
so.. |
| 11:54 |
|
ashimema |
although they've called it a 'pay' it's always been treated as a debt ;) |
| 11:54 |
|
ashimema |
I'll have a ponder.. so if there's any way I could handle these more nicely |
| 11:54 |
|
cait |
I don't think they set it |
| 11:54 |
|
cait |
it was koha messing up |
| 11:55 |
|
ashimema |
seems lots more libraries were entering naff data than I thought. |
| 11:55 |
|
cait |
you can#t st that, pay is a koha internal thing |
| 11:55 |
|
cait |
or was |
| 11:55 |
|
cait |
W too |
| 11:55 |
|
cait |
standard stuff |
| 11:55 |
|
ashimema |
you can write whatever you like in the type box prior to the recent patches |
| 11:55 |
|
cait |
you could, but i don't thin it#s waht thy did |
| 11:56 |
|
cait |
the problem is... that accounts was not working right before |
| 11:56 |
|
cait |
but if that turns out something we can fix, it might help a lot of libraries |
| 11:56 |
|
ashimema |
what's worse.. reporting bad data and requesting they fix it.. or silently fixing the data but risking getting it very wrong |
| 11:56 |
|
cait |
i just meant it#s worth taking a closer look at things |
| 11:57 |
|
ashimema |
I actually know now that a bunch of libraries were infact very much deliberately doing this.. |
| 11:57 |
|
cait |
and see if there is an explanation that we can see and fix it then |
| 11:57 |
|
cait |
my... ours would never |
| 11:57 |
|
|
khall joined #koha |
| 11:57 |
|
ashimema |
it was a way to get around the lack of a proper refund and payout workflow.. |
| 11:57 |
|
cait |
well, never say never, but that's creative |
| 11:57 |
|
ashimema |
it's actually what lead to me writing those two patches ;) |
| 11:58 |
|
ashimema |
mm |
| 11:58 |
|
ashimema |
I intend to.. |
| 11:58 |
|
ashimema |
no time like the present i suppose |
| 11:59 |
|
ere |
ashimema: re bug 20271: was my suggestion of putting just an uuid or something to the unique fields upon deletion just a really bad idea? You could use a trigger to update the fields when the record is marked deleted. |
| 11:59 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20271 major, P1 - high, ---, jonathan.druart, In Discussion , Merge deleted biblio, biblioitems, biblio_metadata, and items tables |
| 12:00 |
|
ashimema |
I wasn't hugely against it personally.. I think cait didn't like it.. |
| 12:00 |
|
* cait |
hides |
| 12:00 |
|
cait |
does it work? |
| 12:00 |
|
cait |
we query the tables a lot... i was worried libraries will get very confused by it |
| 12:01 |
|
cait |
reporting and such |
| 12:01 |
|
ashimema |
I'm envisaging that reports would need more thought with that approach |
| 12:01 |
|
ashimema |
it would work |
| 12:01 |
|
ere |
a static prefix wouldn't work, but just replacing or appending something unique would. |
| 12:01 |
|
ashimema |
I think the cleanest approach is joubu's nullable field and a unique constraint over the two |
| 12:01 |
|
|
did joined #koha |
| 12:01 |
|
cait |
we should probably switch the datatype on the column to soemthing really wide... or they will manage to have a cardnumber and uuid clash |
| 12:02 |
|
cait |
hm ok talking barcodes now, but just saw a request of making that one wider |
| 12:02 |
|
cait |
if we everw ant to merge borrowers things will get more ugly |
| 12:02 |
|
cait |
cardnumber and userid ... |
| 12:02 |
|
ere |
uuid should never clash |
| 12:02 |
|
ashimema |
is there a reason you prefer appending/prefixing a uuid to the existing field vs adding a nullable 'is_current' field? |
| 12:02 |
|
ere |
if it does, it's not unique |
| 12:02 |
|
cait |
i meant they will manage to make somethign that doesn't fit into the column :) |
| 12:03 |
|
ere |
cait: right, in that case |
| 12:03 |
|
ere |
ashimema: is_current is fine if a trigger makes sure it's properly set |
| 12:03 |
|
cait |
sorry, have to go and knit - will be back in a little bit :) |
| 12:03 |
|
ashimema |
indeed |
| 12:04 |
|
ere |
I'd just do everything possible to avoid the need to keep two columns in sync manually |
| 12:04 |
|
ashimema |
I'm never a real fan of null being meaningful, but in this case it's not so much meaningful and deliberately meaningless |
| 12:05 |
|
ashimema |
I'd deffo like it to be done with triggers if at all possible.. on both fronts |
| 12:06 |
|
ere |
ashimema: just one question: if there's a unique key on (is_current, cardnumber), can you have two records with (NULL, '1')? |
| 12:06 |
|
ere |
(I didn't quite follow the examples) |
| 12:06 |
|
ashimema |
yes |
| 12:07 |
|
ashimema |
that's the reason for using 1 = true and null = untrue.. rather than 0 = untree |
| 12:07 |
|
ashimema |
* that's the reason for using 1 = true and null = untrue.. rather than 0 = untreu |
| 12:07 |
|
ashimema |
so we can repeat the field for deleted but maintain integrity for undeleted |
| 12:07 |
|
ashimema |
I'm pretty sure that's the same in mysql, maraidb and postgres |
| 12:08 |
|
ashimema |
`PostgreSQL treats NULL as distinct value, therefore, you can have multiple NULL values in a column with a UNIQUE index.` |
| 12:08 |
|
ashimema |
yup.. |
| 12:08 |
|
ashimema |
so that works nicely with all three db's |
| 12:09 |
|
ere |
nice, in that case I agree is_current is good as long as it's updated with a trigger |
| 12:09 |
|
koha-jenkins |
Project Koha_Master_D8 build #654: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]ha_Master_D8/654/ |
| 12:10 |
|
ashimema |
next question for me is.. is the syntax for defining a trigger going to match between mariadb and mysql versions we currently support.. I like the idea of having it constrained at the db level |
| 12:12 |
|
ere |
what's the minimum MysQL version that needs to be supported? |
| 12:12 |
|
ashimema |
right now.. 5.5 |
| 12:12 |
|
ashimema |
as of 20.05 release I'm not entirely sure yet.. |
| 12:13 |
|
ashimema |
personally.. i'd like us to advocate a move to maraidb the same way debian is.. |
| 12:13 |
|
ashimema |
it's actually now not entirely trivial to install mysql on debian at all... apt install mysql will actually install maraidb |
| 12:13 |
|
ere |
me too, but I believe they should be compatible when it comes to normal triggers |
| 12:14 |
|
ashimema |
I thought that when I tried to get CHECK constraints working.. I ended up having to strip them out entirely because maraidb and mysql treat them rather differently :( |
| 12:15 |
|
ere |
check constraints are, as far as I know, a completely different beast |
| 12:15 |
|
ashimema |
they are indeed |
| 12:15 |
|
ashimema |
but.. they are in theory meant to be a pretty standard part of SQL |
| 12:15 |
|
ashimema |
hense I wouldn't be surprised is another fairly standard part of sql.. triggers.. also differed between the two beasts |
| 12:16 |
|
ashimema |
won't know until we try ;) |
| 12:16 |
|
koha-jenkins |
Project Koha_Master_D9 build #1114: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]a_Master_D9/1114/ |
| 12:16 |
|
ere |
looking at the docs they look the same. MariaDB adds more, e.g. triggering a trigger after another trigger, but that shouldn't be necessary |
| 12:17 |
|
ashimema |
I do wish that dependancy would start working in our jenkins run.. the packages must still not be working right :( |
| 12:17 |
|
Joubu |
we won't add a trigger for that |
| 12:17 |
|
ashimema |
that's promising |
| 12:17 |
|
Joubu |
or we really use trigger, or we don't |
| 12:17 |
|
Joubu |
or we really use triggers, or we don't* |
| 12:17 |
|
ashimema |
? |
| 12:19 |
|
Joubu |
it will introduce a new complexity, which seems unecessary for only that. If we decide to use the trigger at DBMS level, it should be voted then use when we can. |
| 12:20 |
|
Joubu |
I think I tried to open that door few years ago but people disagreed. Cannot remember the context however |
| 12:22 |
|
|
andreashm joined #koha |
| 12:22 |
|
ere |
Without it on the DBMS level there's bound to be trouble with the values getting out of sync. Would you rather have a maintenance task to correct out-of-sync columns in the database? |
| 12:24 |
|
|
xoan joined #koha |
| 12:24 |
|
Joubu |
we already have such columns to maintain. A "boolean" flag seems trivial to keep up-to-date, really. Providing an additional check to the search_for_inconsistencies.pl script will be trivial if we need it |
| 12:25 |
|
Joubu |
I am not against trigger, do not get me wrong. But it seems that we will already face enough issues/problematic cases with that bug :) No need to add more |
| 12:25 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #103: STILL UNSTABLE in 52 min: https://jenkins.koha-community[…]9_MDB_Latest/103/ |
| 12:25 |
|
koha-jenkins |
Project Koha_Master_U18 build #585: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_U18/585/ |
| 12:25 |
|
ere |
Let's just say that I dont' quite agree, but I find it way more important to get the tables combined that I'm willing to up with anything :) |
| 12:29 |
|
ashimema |
Lol |
| 12:29 |
|
ashimema |
I'm game for whatever.. perhaps triggers is a future thing as Joubu says. |
| 12:29 |
|
ashimema |
Let's not pollute this already complex further for now. |
| 12:30 |
|
ere |
Agreed. |
| 12:31 |
|
|
alex_a joined #koha |
| 12:35 |
|
|
oleonard joined #koha |
| 12:36 |
|
oleonard |
Hi all |
| 12:40 |
|
|
inlibro joined #koha |
| 12:56 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #124: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]aster_D9_My8/124/ |
| 13:23 |
|
|
Dyrcona joined #koha |
| 13:32 |
|
|
andreashm joined #koha |
| 13:40 |
|
|
inlibro joined #koha |
| 13:45 |
|
|
khall joined #koha |
| 13:55 |
|
tcohen |
we should just move to old_barcode |
| 13:56 |
|
tcohen |
and reports will need more work, but... |
| 13:56 |
|
tcohen |
we won't overcomplicate the code |
| 13:57 |
|
|
chris_n joined #koha |
| 13:57 |
|
Joubu |
we won't |
| 13:57 |
|
Joubu |
it's easy |
| 13:57 |
|
tcohen |
what is the solution? |
| 13:59 |
|
Joubu |
UNIQUE KEY itembarcodeidx(barcode, is_current) |
| 13:59 |
|
tcohen |
does that work if they reuse the barcode more than once? |
| 14:00 |
|
Joubu |
comment 198 |
| 14:00 |
|
cait |
i was wondering that |
| 14:01 |
|
tcohen |
ok, NULL |
| 14:01 |
|
cait |
or... delete it more than once |
| 14:01 |
|
tcohen |
on ILL I imagine if we are the requesting site, then we will create a temporary record+item, which will be deleted after circ finished |
| 14:01 |
|
tcohen |
so it can be many more than one |
| 14:02 |
|
tcohen |
is that 'NULL is ok on UNIQUE' behaviour dependent on any specific flag in MySQL? So we set a whatchdog for that |
| 14:04 |
|
Joubu |
any specific flag? |
| 14:06 |
|
|
magnuse joined #koha |
| 14:09 |
|
ashimema |
NULL is treated the same on mysql, mariadb and postgres.. I checked.. |
| 14:09 |
|
ashimema |
no mention of flags though where I looked |
| 14:13 |
|
Joubu |
ho, you were talking about SQL modes. No, it's not depending on anything |
| 14:13 |
|
cait |
is someone good friends with update-control? I am getting strange results and could use some pointers |
| 14:17 |
|
|
khall_ joined #koha |
| 14:22 |
|
|
paul_p joined #koha |
| 14:24 |
|
cait |
everyone hiding? |
| 14:24 |
|
* ashimema |
doesn't know enough to help |
| 14:25 |
|
cait |
https://wiki.koha-community.or[…]elease_management says it has to be run in a Debian 7 env |
| 14:25 |
|
ashimema |
mtj or mirko or perhaps eythian are the best to ask |
| 14:25 |
|
cait |
but that seems onlikely? |
| 14:25 |
|
cait |
The update-control script needs to be run on Debian 7. The best way to do it, is inside a VM, and probably on kohadevbox. To do it: |
| 14:25 |
|
ashimema |
nope.. it's entirely true right now cait.. |
| 14:25 |
|
ashimema |
I think I said this to you the other day |
| 14:26 |
|
cait |
i might have overread it |
| 14:26 |
|
ashimema |
untill we deprecate D7 |
| 14:26 |
|
cait |
ook |
| 14:26 |
|
cait |
will my devbox come up as suggested there? |
| 14:26 |
|
cait |
before I destroy... I'd like to know |
| 14:26 |
|
ashimema |
you run against the oldest deb we support |
| 14:26 |
|
ashimema |
pass |
| 14:26 |
|
Joubu |
D8 you mean? |
| 14:26 |
|
Joubu |
D8 is jessie |
| 14:27 |
|
ashimema |
sorry. Joubu is right.. |
| 14:27 |
|
ashimema |
D8 |
| 14:27 |
|
ashimema |
that's the one we're about to call end of life on.. D7 is already dead |
| 14:28 |
|
cait |
shoud we update the wiki? |
| 14:29 |
|
ashimema |
to be honest.. I don't feel confident updating it as I'm not entirely sure how the procedure all fits togetrher |
| 14:29 |
|
|
wizzyrea joined #koha |
| 14:29 |
|
cait |
i seem to have d9 and the output is not right... |
| 14:29 |
|
cait |
so not sure where to go next |
| 14:40 |
|
|
inlibro joined #koha |
| 14:52 |
|
|
ere_away_ joined #koha |
| 14:57 |
|
|
alex_a joined #koha |
| 14:58 |
|
|
paul_p_ joined #koha |
| 15:31 |
|
|
deb-CSPL joined #koha |
| 15:41 |
|
|
inlibro joined #koha |
| 15:49 |
|
|
khall joined #koha |
| 15:53 |
|
huginn |
News from kohagit: Bug 21674: DBRev 19.12.00.017 <http://git.koha-community.org/[…]c7b13a2d6f263d4e6> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24543: Fix wrong test in api/v1/checkouts.t <http://git.koha-community.org/[…]c67058220e541fdc4> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24487: Add 2 more tests <http://git.koha-community.org/[…]471883a2d7555f6fd> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24487: Don't apply matching criteria to path parameters <http://git.koha-community.org/[…]010fcce9836e34c75> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24487: Regresion test <http://git.koha-community.org/[…]dba56ec065ad5b769> |
| 15:53 |
|
huginn |
News from kohagit: Bug 21674: Remove duplicates from library_groups before adding the uniq constraint <http://git.koha-community.org/[…]bda16ee552798a82d> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24377: Record passed branch if renewing via cron <http://git.koha-community.org/[…]1e237e5858feea6c1> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24377: Unit test <http://git.koha-community.org/[…]0f3d1225f80c73162> |
| 15:53 |
|
huginn |
News from kohagit: Bug 24330: When importing patrons from CSV, automatically strip BOM from file if... <http://git.koha-community.org/[…]f99284e23603a7bbc> |
| 15:53 |
|
huginn |
News from kohagit: Bug 21674: Prevent to insert twice the same library in a group <http://git.koha-community.org/[…]5bbfd2718022eee2d> |
| 15:53 |
|
huginn |
News from kohagit: Bug 21674: DB changes <http://git.koha-community.org/[…]d1b596c2c11e5059a> |
| 15:55 |
|
ashimema |
1 more QA's of mojors today and we'll be under 100 again! |
| 15:56 |
|
* ashimema |
cant do either of them as I SO'd them |
| 15:59 |
|
ashimema |
2 more.. even. |
| 16:12 |
|
reiveune |
bye |
| 16:12 |
|
|
reiveune left #koha |
| 16:31 |
|
koha-jenkins |
Project Koha_Master_D9 build #1115: FAILURE in 37 min: https://jenkins.koha-community[…]a_Master_D9/1115/ |
| 16:31 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #104: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]9_MDB_Latest/104/ |
| 16:33 |
|
koha-jenkins |
Project Koha_Master_D8 build #655: STILL UNSTABLE in 40 min: https://jenkins.koha-community[…]ha_Master_D8/655/ |
| 16:41 |
|
|
inlibro joined #koha |
| 16:41 |
|
|
khall joined #koha |
| 17:07 |
|
|
khall joined #koha |
| 17:11 |
|
koha-jenkins |
Project Koha_Master_U18 build #586: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_U18/586/ |
| 17:15 |
|
|
bdonnahue joined #koha |
| 17:29 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #125: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]aster_D9_My8/125/ |
| 17:34 |
|
|
cait left #koha |
| 17:41 |
|
|
inlibro joined #koha |
| 18:01 |
|
|
fridolin joined #koha |
| 18:03 |
|
|
fridolin left #koha |
| 18:08 |
|
|
cait joined #koha |
| 18:41 |
|
|
inlibro joined #koha |
| 19:01 |
|
|
kathryn joined #koha |
| 19:02 |
|
|
oleonard-away joined #koha |
| 19:07 |
|
|
Marie-Luce joined #koha |
| 19:16 |
|
|
cait joined #koha |
| 19:29 |
|
|
khall joined #koha |
| 19:29 |
|
|
andreashm joined #koha |
| 19:31 |
|
|
hayley joined #koha |
| 19:41 |
|
|
inlibro joined #koha |
| 19:44 |
|
|
cait joined #koha |
| 19:58 |
|
|
alexbuckley joined #koha |
| 19:59 |
|
|
alexbuckley joined #koha |
| 20:01 |
|
|
alexbuckley joined #koha |
| 20:04 |
|
|
bdonnahue1 joined #koha |
| 20:05 |
|
|
alexbuckley joined #koha |
| 20:26 |
|
|
lisettelatah joined #koha |
| 20:35 |
|
|
tosca joined #koha |
| 20:42 |
|
|
inlibro joined #koha |
| 20:47 |
|
|
xoan joined #koha |
| 20:54 |
|
|
ere_away joined #koha |
| 21:10 |
|
|
xoan joined #koha |
| 21:30 |
|
|
wizzyrea joined #koha |
| 21:42 |
|
|
inlibro joined #koha |
| 21:47 |
|
|
tosca joined #koha |
| 21:52 |
|
|
khall joined #koha |
| 22:02 |
|
|
tosca joined #koha |
| 22:14 |
|
|
xoan joined #koha |
| 22:24 |
|
koha-jenkins |
Project Koha_Master_D9 build #1116: NOW UNSTABLE in 38 min: https://jenkins.koha-community[…]a_Master_D9/1116/ |
| 22:28 |
|
koha-jenkins |
Project Koha_Master_D8 build #656: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]ha_Master_D8/656/ |
| 22:42 |
|
|
inlibro joined #koha |
| 23:01 |
|
|
khall joined #koha |
| 23:05 |
|
|
khall joined #koha |
| 23:08 |
|
|
bdonnahue joined #koha |
| 23:20 |
|
|
khall joined #koha |
| 23:42 |
|
|
inlibro joined #koha |
| 23:44 |
|
|
talljoy joined #koha |
| 23:57 |
|
koha-jenkins |
Project Koha_19.11_D9 build #38: SUCCESS in 36 min: https://jenkins.koha-community[…]Koha_19.11_D9/38/ |
