| Time |
S |
Nick |
Message |
| 00:00 |
|
|
inlibro joined #koha |
| 00:09 |
|
koha-jenkins |
Project Koha_18.11_U18 build #225: UNSTABLE in 43 min: https://jenkins.koha-community[…]ha_18.11_U18/225/ |
| 01:00 |
|
|
inlibro joined #koha |
| 02:01 |
|
|
inlibro joined #koha |
| 02:02 |
|
koha-jenkins |
Project Koha_18.11_D9 build #238: SUCCESS in 28 min: https://jenkins.koha-community[…]oha_18.11_D9/238/ |
| 02:09 |
|
koha-jenkins |
Project Koha_18.11_D8 build #235: UNSTABLE in 34 min: https://jenkins.koha-community[…]oha_18.11_D8/235/ |
| 02:12 |
|
koha-jenkins |
Yippee, build fixed! |
| 02:12 |
|
wahanui |
Congratulations! |
| 02:12 |
|
koha-jenkins |
Project Koha_18.11_U18 build #226: FIXED in 36 min: https://jenkins.koha-community[…]ha_18.11_U18/226/ |
| 02:14 |
|
|
ask joined #koha |
| 03:01 |
|
|
inlibro joined #koha |
| 03:27 |
|
|
hayley joined #koha |
| 03:30 |
|
|
bshum joined #koha |
| 04:01 |
|
|
inlibro joined #koha |
| 05:01 |
|
|
inlibro joined #koha |
| 05:41 |
|
|
andreashm joined #koha |
| 05:53 |
|
|
cait joined #koha |
| 05:55 |
|
|
did joined #koha |
| 05:59 |
|
|
chriss joined #koha |
| 06:01 |
|
|
inlibro joined #koha |
| 06:47 |
|
|
cait joined #koha |
| 06:56 |
|
|
fridolin joined #koha |
| 07:01 |
|
|
inlibro joined #koha |
| 07:18 |
|
|
reiveune joined #koha |
| 07:18 |
|
reiveune |
hello |
| 07:18 |
|
wahanui |
bidet, reiveune |
| 07:28 |
|
|
andreashm joined #koha |
| 07:33 |
|
|
did joined #koha |
| 07:37 |
|
|
did1 joined #koha |
| 07:39 |
|
|
did1 joined #koha |
| 07:40 |
|
|
kohaputti joined #koha |
| 07:58 |
|
|
cait joined #koha |
| 07:59 |
|
|
cait1 joined #koha |
| 08:00 |
|
|
alex_a joined #koha |
| 08:00 |
|
alex_a |
Bonjour |
| 08:00 |
|
wahanui |
niihau, alex_a |
| 08:02 |
|
|
inlibro joined #koha |
| 08:09 |
|
magnuse |
huh, i changed the settings for plack_max_requests and plack_workers in koha-conf.xml, restarted plack but htop still shows starman running with the old/default settings? what do i have to do to make the new settings take effect? |
| 08:10 |
|
cait1 |
restart all the things? |
| 08:10 |
|
cait1 |
apache? memcached? |
| 08:10 |
|
magnuse |
ah yes, memcached, perhaps |
| 08:12 |
|
magnuse |
hm, restarting memcached and then plack did not help |
| 08:13 |
|
cait1 |
reboot? ;) |
| 08:15 |
|
magnuse |
there should be a better way... |
| 08:22 |
|
magnuse |
reading koha-plack, it looks like a restart should do it |
| 08:26 |
|
|
sophie_m joined #koha |
| 08:28 |
|
magnuse |
*facepalm* i managed to put the plack settings up amongst the zebra config, not in the <config> section... |
| 08:52 |
|
cait1 |
I feel with you |
| 09:01 |
|
magnuse |
thanks |
| 09:01 |
|
|
davidnind joined #koha |
| 09:02 |
|
|
inlibro joined #koha |
| 09:18 |
|
kohaputti |
Joubu, I really think the author should squash the follow-ups – maybe we will discuss this more at some dev meeting |
| 09:19 |
|
Joubu |
not until the feature is ready for push, it's hard for me to keep track of those follow-ups, would be harder if squashed |
| 09:20 |
|
cait1 |
kohaputti: why insist on the squashing? |
| 09:21 |
|
ashimema |
I very ocassionally squash on push.. but it's rare |
| 09:21 |
|
kohaputti |
cait1, to ease reviewing. I can get all the information from change log, v2, v3, etc. |
| 09:21 |
|
ashimema |
I find the historical context of followups very helpful |
| 09:21 |
|
cait1 |
we usually have a rule to keep history, especially if different people have touched it |
| 09:21 |
|
kohaputti |
cait1, if other people touch it then yes |
| 09:21 |
|
ashimema |
it makes it very clear when an author has acted on feedback |
| 09:21 |
|
cait1 |
i usually do a git diff HEAD~4... |
| 09:21 |
|
kohaputti |
but if you make your one little change in 10+ commits please squash it |
| 09:21 |
|
cait1 |
to view all changes of the different commits together |
| 09:22 |
|
Joubu |
follow-ups can mean different things |
| 09:22 |
|
cait1 |
i get grumpy if people squash follow-ups for qa |
| 09:22 |
|
kohaputti |
I don't want to read a story with many hoops from git |
| 09:22 |
|
cait1 |
i want to see the code they touched since my review |
| 09:22 |
|
ashimema |
indeed.. I use caits trick above.. or fairly often I'll push a branch to github of gitlab to get a nicer visual diff which I can comment on inline and then point authors to that.. |
| 09:23 |
|
ashimema |
I find that easier that the bz review tools sometimes as it gives full context |
| 09:23 |
|
cait1 |
it also allows you to 'not see whitespace change' i like that |
| 09:24 |
|
cait1 |
spliter can't, but splitter is still useful for quick review of small stuff |
| 09:26 |
|
cait1 |
but back to the complex patch sets... |
| 09:27 |
|
cait1 |
can you share the bug number we are talking about? |
| 09:27 |
|
kohaputti |
Bug 18936 |
| 09:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18936 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Convert issuingrules fields to circulation_rules |
| 09:28 |
|
kohaputti |
the commit contains the intent of the change, and if the change is only fully made throughout multiple commits then I cannot use the one commit message to verify all the changes made are as intended |
| 09:29 |
|
kohaputti |
and then instead I have reverse-engineer what the code does and I don't like it |
| 09:29 |
|
kohaputti |
more work for me |
| 09:29 |
|
kohaputti |
the author has already done the work so why not re-use that |
| 09:29 |
|
cait1 |
? |
| 09:30 |
|
cait1 |
the issue i have... once suqashed you can't see the history, but if not squashed I can still 'visually squash' them |
| 09:31 |
|
cait1 |
ashimema: can you do a git diff HEAd~x... view on gitlab? |
| 09:31 |
|
ashimema |
if the commit message doesn't describe the change made than that's different |
| 09:31 |
|
kohaputti |
ok, I get it, but that might only help the first reviewer |
| 09:31 |
|
ashimema |
I tend to be comparing full branches on gitlab/github cait |
| 09:31 |
|
cait1 |
this started 2 years ago... 2 different uathors |
| 09:32 |
|
kohaputti |
ashimema, if you compare full branches then you need to reverse-engineer the intended change there |
| 09:32 |
|
cait1 |
probably one of our worst |
| 09:32 |
|
|
greenjimll joined #koha |
| 09:32 |
|
kohaputti |
ashimema, for full branch you don't have a commit message |
| 09:32 |
|
cait1 |
but if you squash them all... do you not have to do the same? |
| 09:33 |
|
ashimema |
the basics of it is.. if it's a big change.. QA is going to be hard and there's a judgement call that needs to take place at some point.. |
| 09:33 |
|
kohaputti |
cait1, one commit, one logical change, so squash only the commits next to each other that are part of the same logical change |
| 09:33 |
|
cait1 |
ok, but not sure if we could do that here |
| 09:34 |
|
ashimema |
generally.. so long as the code doesn't "smell" and the intended functionality change as a whole is as described.. and the tests all pass (and qa script passes).. |
| 09:34 |
|
cait1 |
Jesses work is fairly old but seems to make sense |
| 09:34 |
|
ashimema |
then I tend to pqa and pass along.. the rm can always push back if they're not comfortable. |
| 09:34 |
|
cait1 |
and most of Joubus follow-ups make sense to me too |
| 09:34 |
|
cait1 |
maybe apart form fix several issues an dmore fixed ;) |
| 09:35 |
|
ashimema |
Joubu needs to learn to split these sorts of changes into smaller bugs with more clearly described functional changes.. |
| 09:35 |
|
cait1 |
this is a hard one - inheriting another's work |
| 09:35 |
|
Joubu |
I am not the original author, the feature has been split already in several bug reports (at least 5) |
| 09:35 |
|
kohaputti |
cait1, here I had only problem with those commit messages like "Fixes" |
| 09:35 |
|
cait1 |
and not sure how we could split something like this up more effectivley |
| 09:35 |
|
ashimema |
but we are where we are right now and I don't think it's worth breaking it down further at this point.. I just encourage any new works take a more broken down tree approach as far as possible.. sometimes that's plain hard |
| 09:36 |
|
cait1 |
yeah |
| 09:36 |
|
cait1 |
small steps |
| 09:36 |
|
ashimema |
indeed.. this one can't easily be split any smaller |
| 09:36 |
|
cait1 |
from being at the project for a long time... |
| 09:36 |
|
kohaputti |
so I can live with the follow-ups but only if they describe the changes |
| 09:36 |
|
cait1 |
it seems devs circle back and forth |
| 09:36 |
|
ashimema |
ok.. 'Fixes' is indeed a bad commit message.. that should really summarise what it's fixing.. |
| 09:37 |
|
ashimema |
things highlights during QA runs.. rebase corrections.. etc |
| 09:37 |
|
cait1 |
between big stuff and small steps ... both are hard in different ways |
| 09:37 |
|
cait1 |
i stil lbelieve firmly in smaller steps |
| 09:38 |
|
ashimema |
want me to take it on kohaputti.. I was aiming to give it a good last QA run before pushing anyway |
| 09:39 |
|
kohaputti |
ashimema, well we need sign-off and qa sign-off there so I can do one of the other |
| 09:40 |
|
kohaputti |
I already started looking into the code |
| 09:40 |
|
ashimema |
hope none of that came accross too negative.. I want to continue to encourage questioning and general dev talk.. we can always improve as a team :) |
| 09:41 |
|
Joubu |
Really, given the size of the changes, I do not understand it deserves a discussion about a 2 lines patch that is named "more fixes". Ok it's bad, you can blame me, but please focus on the whole picture |
| 09:41 |
|
* cait1 |
sends cookies to Joubu |
| 09:42 |
|
cait1 |
this is a hard one, let's work on it together |
| 09:42 |
|
ashimema |
always remember we're an international group of varying abilities and cultural lines tend to also be blurred.. I always try to take a general 'be friendly' policy :) |
| 09:46 |
|
kohaputti |
Joubu, 2 lines patches with non-descriptive message make hard to revert features if there are many, though reverting is not so common with Koha. But as you said let's focus now on the whole picture here and let's get this in so it's not blocking other bugs. |
| 09:58 |
|
cait1 |
... and write super nice commit messages in the future :P |
| 09:58 |
|
cait1 |
my inner librarian talking... |
| 10:02 |
|
|
vfernandes joined #koha |
| 10:02 |
|
|
inlibro joined #koha |
| 10:11 |
|
|
andreashm joined #koha |
| 10:39 |
|
cait1 |
hm no talljoy no kidclamp :( |
| 10:39 |
|
ashimema |
? |
| 10:39 |
|
ashimema |
it's early for them |
| 10:42 |
|
cait1 |
still worried because talljoy pushed the datepicker-not-sexy |
| 10:43 |
|
cait1 |
bug 24181 |
| 10:43 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24181 enhancement, P5 - low, ---, jonathan.druart, Pushed to stable , Make our datepicker inputs sexy |
| 10:43 |
|
cait1 |
and we got tons of display issues with htat one atm |
| 10:51 |
|
|
davidnind left #koha |
| 10:57 |
|
|
fridolin joined #koha |
| 10:59 |
|
tcohen |
morning |
| 11:01 |
|
cait1 |
.... and it's almost release day |
| 11:01 |
|
cait1 |
morning tcohen |
| 11:02 |
|
|
inlibro joined #koha |
| 11:03 |
|
|
khall joined #koha |
| 11:08 |
|
tcohen |
US people had Martin Luther King's memorial day yesterday, so it was a holiday |
| 11:13 |
|
|
paul_p joined #koha |
| 11:13 |
|
ashimema |
mtj around? |
| 11:15 |
|
|
khall joined #koha |
| 11:16 |
|
ashimema |
@later tell mtj we still have some issues with pinned versions in D10 I'm afraid.. we seem to get the 'min' version of Plugin::OpenAPI as listed in the PerlDependancies.. but we get a much newer than 'min' version of JSON::Validator.. those two should really be kept in sync.. I can try to work out which version of JSON::Validator is the last one compatible with our version of the OpenAPI plugin if that helps |
| 11:16 |
|
huginn |
ashimema: The operation succeeded. |
| 11:19 |
|
ashimema |
tcohen.. do you have a prefered version of the OpenAPI plugin.. we should pick one and then lockstep our Mojolicious and JSON::Validator versions with it. |
| 11:25 |
|
tcohen |
I don' thave a preferred version. Stretch's is fine |
| 11:28 |
|
tcohen |
ashimema do you see an option to upgrade it? |
| 11:38 |
|
huginn |
News from kohagit: Bug 24435: Add Koha::Biblio->items_count <http://git.koha-community.org/[…]f69e9071cc48ca199> |
| 11:38 |
|
huginn |
News from kohagit: Bug 24435: Unit tests <http://git.koha-community.org/[…]992e75487e61300bc> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: fix the export labels popup header <http://git.koha-community.org/[…]d37dc5f9d6a370d8a> |
| 11:38 |
|
huginn |
News from kohagit: Bug 19793: Change label to match patron record: Primary email <http://git.koha-community.org/[…]5b92cb93b58ca8d29> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: Use Modern::Perl <http://git.koha-community.org/[…]f7256250906669643> |
| 11:38 |
|
huginn |
News from kohagit: Bug 3426: Keep note about sequence of subfields <http://git.koha-community.org/[…]87a126e9a33707320> |
| 11:38 |
|
huginn |
News from kohagit: Bug 24430: Remove CountBiblioInOrders and its traces <http://git.koha-community.org/[…]31f41ed29b1dac5d1> |
| 11:38 |
|
huginn |
News from kohagit: Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio <http://git.koha-community.org/[…]afccb89d44403e5f6> |
| 11:38 |
|
huginn |
News from kohagit: Bug 24430: Unit tests <http://git.koha-community.org/[…]75b3770a88fccdece> |
| 11:38 |
|
huginn |
News from kohagit: Bug 19793: Add a field for email in batch patron modification <http://git.koha-community.org/[…]fcaaaf43c19a812d3> |
| 11:38 |
|
huginn |
News from kohagit: Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC <http://git.koha-community.org/[…]83a25416c9f89c1a1> |
| 11:38 |
|
huginn |
News from kohagit: Bug 3426: Allow for multiple fields in itemcallnumber syspref <http://git.koha-community.org/[…]94df9ccb03945454e> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: (follow-up) Add missing filters <http://git.koha-community.org/[…]51a190781febd0edd> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: (follow-up) fix label-edit-range template <http://git.koha-community.org/[…]7eee903969057a7c0> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: (follow-up) Make sure only integers are accepted as from/to values <http://git.koha-community.org/[…]3b03794354bb26753> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: Showing the error message according to the community interface patterns... <http://git.koha-community.org/[…]f960506ca2f6ecb8b> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: Add warning when range has non-existent barcodes <http://git.koha-community.org/[…]5dcebb66ada2e2cfb> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: Fix 'false' message on Firefox <http://git.koha-community.org/[…]841c4296e2fd24e8b> |
| 11:38 |
|
huginn |
News from kohagit: Bug 7468: Print barcodes by range <http://git.koha-community.org/[…]83ae1e67c945f1aa0> |
| 11:44 |
|
|
did joined #koha |
| 11:44 |
|
|
khall joined #koha |
| 11:56 |
|
|
andreashm joined #koha |
| 12:02 |
|
|
inlibro joined #koha |
| 12:03 |
|
|
andreashm joined #koha |
| 12:04 |
|
|
andreashm joined #koha |
| 12:04 |
|
|
andreashm joined #koha |
| 12:05 |
|
|
andreashm joined #koha |
| 12:11 |
|
|
andreashm joined #koha |
| 12:12 |
|
|
andreashm joined #koha |
| 12:13 |
|
|
andreashm joined #koha |
| 12:14 |
|
|
andreashm joined #koha |
| 12:14 |
|
|
andreashm joined #koha |
| 12:15 |
|
koha-jenkins |
Project Koha_Master_D9 build #1089: SUCCESS in 36 min: https://jenkins.koha-community[…]a_Master_D9/1089/ |
| 12:15 |
|
|
andreashm joined #koha |
| 12:16 |
|
|
andreashm joined #koha |
| 12:17 |
|
|
andreashm joined #koha |
| 12:17 |
|
|
andreashm joined #koha |
| 12:18 |
|
|
andreashm joined #koha |
| 12:19 |
|
|
cait joined #koha |
| 12:19 |
|
|
andreashm joined #koha |
| 12:19 |
|
|
cait1 joined #koha |
| 12:27 |
|
|
kidclamp joined #koha |
| 12:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 12:28 |
|
wahanui |
Congratulations! |
| 12:28 |
|
koha-jenkins |
Project Koha_Master_U18 build #560: FIXED in 48 min: https://jenkins.koha-community[…]a_Master_U18/560/ |
| 12:30 |
|
|
oleonard joined #koha |
| 12:31 |
|
oleonard |
Hi #koha |
| 12:32 |
|
|
alex_a joined #koha |
| 12:33 |
|
magnuse |
kia ora oleonard |
| 12:36 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #97: STILL UNSTABLE in 54 min: https://jenkins.koha-community[…]Master_D9_My8/97/ |
| 12:42 |
|
cait1 |
Joubu: 24435 is the same qusetion as for subscriptions, right? |
| 12:42 |
|
cait1 |
bug 24435 |
| 12:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24435 enhancement, P5 - low, ---, tomascohen, Pushed to master , Add Koha::Biblio->items_count |
| 12:44 |
|
|
andreashm joined #koha |
| 12:50 |
|
Joubu |
it is |
| 12:51 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #76: SUCCESS in 35 min: https://jenkins.koha-community[…]D9_MDB_Latest/76/ |
| 12:56 |
|
oleonard |
Joubu: I think it's unrealistic to expect every form field in a form to be the same width unless we're going to set them all to a width of 100% |
| 12:58 |
|
|
andreashm joined #koha |
| 12:58 |
|
|
andreashm joined #koha |
| 12:59 |
|
|
andreashm joined #koha |
| 13:00 |
|
|
andreashm joined #koha |
| 13:00 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:00 |
|
wahanui |
Congratulations! |
| 13:00 |
|
koha-jenkins |
Project Koha_Master_D8 build #626: FIXED in 32 min: https://jenkins.koha-community[…]ha_Master_D8/626/ |
| 13:00 |
|
|
andreashm joined #koha |
| 13:01 |
|
|
andreashm joined #koha |
| 13:02 |
|
|
andreashm joined #koha |
| 13:02 |
|
|
inlibro joined #koha |
| 13:03 |
|
|
andreashm joined #koha |
| 13:03 |
|
|
andreashm joined #koha |
| 13:04 |
|
|
andreashm joined #koha |
| 13:05 |
|
|
andreashm joined #koha |
| 13:06 |
|
|
andreashm joined #koha |
| 13:10 |
|
Joubu |
oleonard: do you remember why we need the padding-right rule? |
| 13:11 |
|
oleonard |
So that the contents of the form field don't overlap the background image of the calendar |
| 13:23 |
|
|
andreashm joined #koha |
| 13:24 |
|
|
andreashm joined #koha |
| 13:25 |
|
|
andreash_ joined #koha |
| 13:25 |
|
|
andreashm joined #koha |
| 13:26 |
|
Joubu |
oleonard: do you know on which screen it happens? |
| 13:27 |
|
|
andreashm joined #koha |
| 13:27 |
|
oleonard |
the padding-right is a preventative measure. I don't know that it happens anywhere but the padding makes sure it doesn't |
| 13:27 |
|
|
andreashm joined #koha |
| 13:28 |
|
|
andreashm joined #koha |
| 13:29 |
|
|
andreashm joined #koha |
| 13:30 |
|
|
andreashm joined #koha |
| 13:30 |
|
|
andreashm joined #koha |
| 13:31 |
|
* magnuse |
hands andreashm the velcro |
| 13:31 |
|
oleonard |
andreashm is like my cat, can't decide whether to be inside our outside |
| 13:31 |
|
|
andreashm joined #koha |
| 13:32 |
|
|
andreashm joined #koha |
| 13:33 |
|
|
Dyrcona joined #koha |
| 13:33 |
|
|
andreashm joined #koha |
| 13:33 |
|
|
did joined #koha |
| 13:34 |
|
|
andreashm joined #koha |
| 13:55 |
|
|
andreashm joined #koha |
| 13:56 |
|
|
corilynn joined #koha |
| 13:58 |
|
oleonard |
Hi corilynn |
| 13:58 |
|
corilynn |
oleonard, what's up? |
| 13:58 |
|
oleonard |
Same old |
| 13:58 |
|
corilynn |
here too! |
| 13:59 |
|
corilynn |
I imagine you saw that patch I threw back yesterday.. wondering if something maybe changed since you wrote it? |
| 14:01 |
|
oleonard |
Bug 23753? |
| 14:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23753 normal, P5 - low, ---, oleonard, Failed QA , Background job JavaScript should not try to call humanMsg library |
| 14:01 |
|
corilynn |
that one, yeah |
| 14:02 |
|
oleonard |
Never heard of it! |
| 14:02 |
|
oleonard |
;) |
| 14:02 |
|
corilynn |
mmm k |
| 14:03 |
|
|
inlibro joined #koha |
| 14:03 |
|
|
Null404 joined #koha |
| 14:03 |
|
Null404 |
hello everyone |
| 14:06 |
|
oleonard |
Hi Null404 |
| 14:08 |
|
caroline_catlady |
good morning! |
| 14:08 |
|
|
Marie-Luce joined #koha |
| 14:11 |
|
corilynn |
oh, 23753 depends on another bug, i see... |
| 14:12 |
|
kidclamp |
that's just the bug that added humanmsg there |
| 14:14 |
|
kidclamp |
oleonard: I like the look of the human msg bette for the errors that came back - I think they looked odd in the alerts. Not a big deal, you are the master of the GUI :-) |
| 14:15 |
|
* oleonard |
rules with an iron fist and also that was like three months ago who knows |
| 14:18 |
|
corilynn |
well, ya'll wrestle it out and let me know |
| 14:19 |
|
|
paul_p joined #koha |
| 14:36 |
|
|
caroline_crazycatlady joined #koha |
| 14:37 |
|
|
wizzyrea joined #koha |
| 14:51 |
|
|
did joined #koha |
| 14:57 |
|
ashimema |
dang my inbox is overflowing with bugmail :( |
| 15:03 |
|
|
talljoy joined #koha |
| 15:03 |
|
|
inlibro joined #koha |
| 15:06 |
|
|
cait joined #koha |
| 15:09 |
|
|
cait1 joined #koha |
| 15:15 |
|
|
khall_ joined #koha |
| 15:18 |
|
oleonard |
tcohen++ |
| 15:33 |
|
kidclamp |
Joubu: I can agree testing everywhere is annoying, however, I think we also agree we dont want to display 'Internal server error' anywhere - we should not die to the user |
| 15:34 |
|
kidclamp |
would it be better to catch an exception and bubble an error to the uer? much bigger patch, but betetr method |
| 15:34 |
|
kidclamp |
bug 24331 for context |
| 15:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24331 normal, P5 - low, ---, nick, Signed Off , Internal server error when placing hold on item if itemtype undefined |
| 15:37 |
|
|
did joined #koha |
| 15:39 |
|
Joubu |
kidclamp: either we test everywhere, or nowhere :) |
| 15:39 |
|
tcohen |
exceptions everywhere |
| 15:39 |
|
Joubu |
And I thought we agreed that the search_for_inconsistencies.pl maintenance script must be executed to make sure the app won't crash |
| 15:41 |
|
cait1 |
i thought that too |
| 15:41 |
|
cait1 |
or we should make the site explode |
| 15:42 |
|
cait1 |
right now things work... trangely ... when there is no itemtype, like the checkouts list not loading |
| 15:42 |
|
cait1 |
it's not ideal |
| 15:42 |
|
kidclamp |
I disagree with that |
| 15:42 |
|
Joubu |
then it must be tested everywhere |
| 15:42 |
|
cait1 |
i think a warning that tells you what is wrong would be nice |
| 15:42 |
|
kidclamp |
we should never die to the user, maybe we don't succeed the job, but not internal server error |
| 15:42 |
|
kidclamp |
if not test, then more try/catch |
| 15:43 |
|
kidclamp |
or posibly display datat inconsistencies directly on homepage with links to fix |
| 15:44 |
|
Joubu |
I am sure I can find hundreds of ways to make Koha explode if I mess with the data :) |
| 15:46 |
|
kidclamp |
heh, that's the easy part, making it be nice is the hard part |
| 15:46 |
|
Joubu |
We do not want to search for inconsistencies everytime a user hit the homepage |
| 15:51 |
|
kidclamp |
https://metacpan.org/pod/Plack[…]::PrettyException |
| 16:03 |
|
|
inlibro joined #koha |
| 16:06 |
|
reiveune |
bye |
| 16:06 |
|
|
reiveune left #koha |
| 16:19 |
|
|
lisettelatah joined #koha |
| 16:35 |
|
|
did joined #koha |
| 16:47 |
|
|
cait joined #koha |
| 16:56 |
|
|
khall joined #koha |
| 17:03 |
|
|
inlibro joined #koha |
| 17:17 |
|
talljoy |
oooo I want to play |
| 17:17 |
|
talljoy |
i can mess up data really well |
| 17:17 |
|
|
did joined #koha |
| 17:27 |
|
tcohen |
the discussion should be how we handle specific exceptions, and what's the fallback for unhandled exceptions |
| 17:46 |
|
|
khall joined #koha |
| 17:53 |
|
cait |
talljoy: hello |
| 17:53 |
|
cait |
still around? |
| 17:53 |
|
talljoy |
hi cait! |
| 17:53 |
|
cait |
:) |
| 17:53 |
|
cait |
was trying to catch you for a few days |
| 17:53 |
|
cait |
bug 24181 |
| 17:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24181 enhancement, P5 - low, ---, jonathan.druart, Pushed to stable , Make our datepicker inputs sexy |
| 17:54 |
|
cait |
there is a new bug below that points out display issues with this patch |
| 17:54 |
|
talljoy |
i got your message about bz 24181. Is anything broken from it? |
| 17:54 |
|
cait |
yep it breaks displays |
| 17:54 |
|
cait |
see bug 24363 |
| 17:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24363 enhancement, P5 - low, ---, lucas, Needs Signoff , Datepicker calendar is not always sexy |
| 17:55 |
|
cait |
on that bug is a screenshot with an example |
| 17:56 |
|
cait |
from the add item form - the date acquired |
| 17:56 |
|
talljoy |
i'll take a look. My inclination is to not revert. But I promise to give it a good review today and decide before i release .02. |
| 17:56 |
|
talljoy |
thanks! |
| 17:56 |
|
cait |
it's a display patch that breaks display... :) |
| 17:56 |
|
cait |
but yep, thx |
| 17:57 |
|
cait |
caroline listed pages with issues on the bug that she found |
| 17:59 |
|
cait |
we'vebeen debating to revert from master - but they wanted to have a go to fix it |
| 18:03 |
|
|
inlibro joined #koha |
| 18:04 |
|
oleonard |
Everyone test my proposed fix on Bug 24363! :) |
| 18:04 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24363 enhancement, P5 - low, ---, lucas, Needs Signoff , Datepicker calendar is not always sexy |
| 18:07 |
|
cait |
:) |
| 18:10 |
|
|
lukeG joined #koha |
| 18:45 |
|
caroline_crazycatlady |
thx oleonard! |
| 18:54 |
|
|
khall joined #koha |
| 18:54 |
|
|
khall_ joined #koha |
| 18:55 |
|
bag |
!bang |
| 18:55 |
|
AnnaBoten |
There is no hunt right now! You can start a hunt with the 'start' command |
| 19:04 |
|
|
inlibro joined #koha |
| 19:06 |
|
rangi |
morning |
| 19:07 |
|
cait |
morning rangi |
| 19:07 |
|
rangi |
ashimema: same bug, Bad arg length for Socket::sockaddr_family, length is 0, should be at least 2 at /usr/share/perl5/HTTP/Server/Simple.pm line 422. |
| 19:07 |
|
rangi |
running again now |
| 19:08 |
|
cait |
splitter? |
| 19:08 |
|
wahanui |
well, splitter is working again?? |
| 19:12 |
|
rangi |
yep |
| 19:13 |
|
cait |
ah... so another issue unfound yet? |
| 19:14 |
|
rangi |
same bug as always |
| 19:14 |
|
cait |
:( |
| 19:35 |
|
|
andreashm joined #koha |
| 19:40 |
|
tcohen |
!start |
| 19:40 |
|
AnnaBoten |
The hunt starts now! |
| 19:41 |
|
oleonard |
BANG |
| 19:41 |
|
tcohen |
ha |
| 19:41 |
|
oleonard |
cait: I updated the commit message and test plan on Bug 24249, I hope it's a little more clear |
| 19:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24249 minor, P5 - low, ---, oleonard, Needs Signoff , OPAC lists page should require login for login-dependent operations |
| 19:43 |
|
AnnaBoten |
\_o< quack! |
| 19:43 |
|
wahanui |
*click* |
| 19:43 |
|
oleonard |
!bang |
| 19:43 |
|
AnnaBoten |
oleonard, you missed the duck! |
| 19:43 |
|
oleonard |
liar |
| 19:43 |
|
cait |
oleonard: thx! |
| 19:44 |
|
corilynn |
!bang |
| 19:44 |
|
AnnaBoten |
\_x< corilynn: 1 (94.37 seconds) |
| 19:45 |
|
|
lukeG joined #koha |
| 19:46 |
|
AnnaBoten |
\_o< quack! |
| 19:46 |
|
wahanui |
*click* |
| 19:46 |
|
oleonard |
!bang |
| 19:46 |
|
AnnaBoten |
\_x< oleonard: 1 (23.49 seconds) |
| 19:49 |
|
|
khall joined #koha |
| 19:50 |
|
AnnaBoten |
\_o< quack! |
| 19:50 |
|
wahanui |
*click* |
| 19:51 |
|
oleonard |
!bang |
| 19:51 |
|
AnnaBoten |
\_x< oleonard: 2 (23.64 seconds) |
| 19:51 |
|
AnnaBoten |
[('oleonard', 2), ('corilynn', 1)] |
| 19:51 |
|
AnnaBoten |
Best time: oleonard with 23.49 seconds |
| 19:51 |
|
oleonard |
kidclamp still around? |
| 19:58 |
|
oleonard |
See y'all later |
| 19:58 |
|
|
hayley joined #koha |
| 19:59 |
|
AnnaBoten |
\_o< quack! |
| 19:59 |
|
wahanui |
oops, slipped over |
| 20:00 |
|
hayley |
!bang |
| 20:00 |
|
AnnaBoten |
\_x< hayley: 1 (72.74 seconds) |
| 20:02 |
|
AnnaBoten |
\_o< quack! |
| 20:02 |
|
wahanui |
*click* |
| 20:04 |
|
|
inlibro joined #koha |
| 20:09 |
|
hayley |
!bang |
| 20:09 |
|
AnnaBoten |
\_x< hayley: 2 (388.08 seconds) |
| 20:10 |
|
|
lukeG joined #koha |
| 20:14 |
|
AnnaBoten |
\_o< quack! |
| 20:14 |
|
wahanui |
*click* |
| 20:15 |
|
cait |
ashimema: bug 24474 |
| 20:15 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24474 critical, P5 - low, ---, aleisha, NEW , Lost items that are checked out are always returned, even when attempting to renew them |
| 20:15 |
|
hayley |
!bang |
| 20:15 |
|
AnnaBoten |
\_x< hayley: 3 (40.73 seconds) |
| 20:15 |
|
AnnaBoten |
\o/ hayley: 3 ducks out of 3: perfect!!! +5 \o/ |
| 20:15 |
|
AnnaBoten |
Best time: hayley with 40.73 seconds |
| 20:15 |
|
AnnaBoten |
Longest time: hayley with 388.08 seconds (this is your new longest time in this channel! Your previous longest time was 361.96) |
| 20:15 |
|
hayley |
!stop |
| 20:15 |
|
AnnaBoten |
Not a single duck was shot during this hunt! |
| 20:15 |
|
AnnaBoten |
Nothing to stop: there's no hunt right now. |
| 20:16 |
|
cait |
:) |
| 20:18 |
|
hayley |
:D |
| 20:20 |
|
cait |
this makes so much sense :) |
| 20:24 |
|
hayley |
lukeG if you're around, I think b 24054 needs updating status updated to Pushed to oldstable :) |
| 20:24 |
|
hayley |
*needs status updated |
| 20:25 |
|
* andreashm |
waves |
| 20:25 |
|
* hayley |
waves too |
| 20:26 |
|
* cait |
waves |
| 20:26 |
|
cait |
br |
| 20:26 |
|
cait |
b |
| 20:26 |
|
lukeG |
Hayley thanks, it's updated |
| 20:27 |
|
koha-jenkins |
Project Koha_19.11_D8 build #37: SUCCESS in 37 min: https://jenkins.koha-community[…]Koha_19.11_D8/37/ |
| 20:30 |
|
koha-jenkins |
Project Koha_19.11_U18 build #34: UNSTABLE in 40 min: https://jenkins.koha-community[…]oha_19.11_U18/34/ |
| 20:33 |
|
wizzyrea |
hi |
| 20:33 |
|
andreashm |
hey wizzyrea |
| 20:33 |
|
wahanui |
i heard wizzyrea was very glad the git repo is reliably working todya |
| 20:35 |
|
koha-jenkins |
Project Koha_19.11_D9 build #36: SUCCESS in 44 min: https://jenkins.koha-community[…]Koha_19.11_D9/36/ |
| 20:41 |
|
|
kathryn joined #koha |
| 20:56 |
|
caroline_crazycatlady |
hi all! I have a question re overdue_notices argument --date |
| 20:56 |
|
caroline_crazycatlady |
there are two different descriptions in the script |
| 20:57 |
|
caroline_crazycatlady |
one says "emulate overdues run for this date" and the other says "use it in order to send overdues on a specific date and not Now" |
| 20:58 |
|
caroline_crazycatlady |
do they mean that we could run it as if we're in the past? |
| 20:58 |
|
caroline_crazycatlady |
we need to run the script for older overdues and I'm wondering if that is the argument to use |
| 20:58 |
|
cait |
i thinkso |
| 20:58 |
|
cait |
but we haven't used that one in forever |
| 20:59 |
|
cait |
maybe turn of the process_message_queue and do a test run? |
| 20:59 |
|
cait |
turn off |
| 20:59 |
|
caroline_crazycatlady |
we have SenddAllMessagesTo now :) |
| 20:59 |
|
cait |
that's cool too :) |
| 20:59 |
|
caroline_crazycatlady |
but yeah definitely don't want a gazillion emails coming in |
| 21:04 |
|
|
inlibro joined #koha |
| 21:26 |
|
koha-jenkins |
Project Koha_18.11_U18 build #227: SUCCESS in 29 min: https://jenkins.koha-community[…]ha_18.11_U18/227/ |
| 21:26 |
|
ashimema |
Is the code on gitlab the latest running for splitter rangi.. might have a bit of a look tomorrow.. see if a new set of eyes helps at all |
| 21:26 |
|
rangi |
yep, that'd be good |
| 21:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 21:28 |
|
wahanui |
Congratulations! |
| 21:28 |
|
koha-jenkins |
Project Koha_18.11_D8 build #236: FIXED in 33 min: https://jenkins.koha-community[…]oha_18.11_D8/236/ |
| 21:31 |
|
koha-jenkins |
Project Koha_18.11_D9 build #239: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_18.11_D9/239/ |
| 21:44 |
|
ashimema |
And how are we deploying it at the moment.. rangi ? |
| 21:45 |
|
ashimema |
Soo many ways to run a dancer app.. always fun trying to replicate issues |
| 21:47 |
|
rangi |
real simple just ./bin/app.pl |
| 21:47 |
|
rangi |
then behind nginx |
| 21:48 |
|
ashimema |
Cool, so no clever daemons or plackups to contend with |
| 21:48 |
|
ashimema |
Ta |
| 21:48 |
|
ashimema |
I'll have more of a play in the morning... Just gathering notes right now. 😀 |
| 21:53 |
|
rangi |
sweet |
| 22:04 |
|
|
inlibro joined #koha |
| 22:26 |
|
|
paul_p joined #koha |
| 23:04 |
|
|
inlibro joined #koha |
| 23:07 |
|
|
khall joined #koha |
| 23:41 |
|
|
khall joined #koha |
