Time |
S |
Nick |
Message |
00:44 |
|
|
cait1 joined #koha |
00:55 |
|
|
inlibro joined #koha |
00:56 |
|
|
lavamind joined #koha |
01:29 |
|
|
khall joined #koha |
01:45 |
|
|
jzairo joined #koha |
01:55 |
|
|
inlibro joined #koha |
02:55 |
|
|
inlibro joined #koha |
03:08 |
|
|
Mandersoon joined #koha |
03:55 |
|
|
inlibro joined #koha |
04:55 |
|
|
inlibro joined #koha |
05:10 |
|
|
chris joined #koha |
05:18 |
|
|
cait joined #koha |
05:33 |
|
ashimema |
@later tell kathryn ask interleaf about 'scooter', that was a shared Koha for schools program they had a while back.. think they still support it.. needs a few bits merging upstream and would be nice for them to have interest showed. |
05:33 |
|
huginn` |
ashimema: The operation succeeded. |
05:56 |
|
|
inlibro joined #koha |
06:19 |
|
|
alexbuckley joined #koha |
06:24 |
|
* magnuse |
waves |
06:27 |
|
* cait |
waves back |
06:30 |
|
ashimema |
mornin |
06:31 |
|
cait |
morning, oh mighty RM ;) |
06:31 |
|
cait |
bbl |
06:31 |
|
ashimema |
lol |
06:31 |
|
* ashimema |
is pleased to see Joubu poped in over night :) |
06:32 |
|
ashimema |
though he has left me with one little fun challenge.. how to revert test data in a test without using transactions |
06:35 |
|
|
Mandersoon joined #koha |
06:45 |
|
|
marcelr joined #koha |
06:45 |
|
marcelr |
hi #koha |
06:50 |
|
magnuse |
hiya cait and ashimema and marcelr |
06:51 |
|
ashimema |
horrible would it be to do a DB dump within a test and then restore it at the end of the test? |
06:51 |
|
ashimema |
as an alternative to transactions (we can't use a transaction here as we're testing an interface which sits on a different connection) |
06:51 |
|
marcelr |
hi magnuse ashimema |
06:51 |
|
ashimema |
hmm.. I missed 'how' there |
06:52 |
|
ashimema |
morning marcelr and magnuse and cait |
06:56 |
|
|
inlibro joined #koha |
06:59 |
|
|
Mandersoon joined #koha |
07:04 |
|
|
Mandersoon_ joined #koha |
07:09 |
|
|
irma_ joined #koha |
07:11 |
|
|
cait joined #koha |
07:17 |
|
|
dpk__ joined #koha |
07:18 |
|
|
Mandersoon_ joined #koha |
07:43 |
|
cait |
can you search in the code with gitlab? |
07:43 |
|
cait |
i don't want a file... i want occurrences of search_patrons_with_acq_perm_only for example |
07:47 |
|
magnuse |
clone the repo and use grep localy? |
07:49 |
|
cait |
not waht i intended to do |
07:49 |
|
cait |
sometimes i just want to look something up quickly |
07:49 |
|
* cait |
grumps about gitweb being better |
07:56 |
|
|
inlibro joined #koha |
07:59 |
|
magnuse |
cait: you mean this one? https://gitlab.com/koha-community/Koha |
07:59 |
|
magnuse |
there is a "Search or jump to" field at the top |
07:59 |
|
cait |
no ours |
07:59 |
|
cait |
yes, but it doesn't appear to search in the code? |
07:59 |
|
cait |
hm it does |
07:59 |
|
cait |
have to check why our gitlab installation is different then |
08:00 |
|
cait |
huh, now it worked doh. |
08:00 |
|
cait |
:) |
08:00 |
|
magnuse |
hehe |
08:00 |
|
ashimema |
lol |
08:00 |
|
cait |
sorry, still too tired i guess |
08:01 |
|
cait |
it still doesn#t make sense to me |
08:01 |
|
ashimema |
you on the security list in bz magnuse? |
08:01 |
|
cait |
the 'inform on receive' feature is for users in acq... isn't it? |
08:01 |
|
cait |
on basket.pl |
08:01 |
|
* ashimema |
would be interested in the cringe factor of my final followup on bug 23329 |
08:01 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23329 is not accessible. |
08:01 |
|
cait |
and when i search, i see all users there, but when a staff user in one of our librareis does, it limits to staff |
08:02 |
|
cait |
but i don't see why it behaves differently for me and i think the code looks wrong |
08:02 |
|
cait |
https://gitlab.com/koha-commun[…]dd_user_search.pl |
08:11 |
|
|
andreashm joined #koha |
08:22 |
|
huginn` |
News from kohagit: Bug 23309: DBRev 19.06.00.021 <http://git.koha-community.org/[…]e5d057373dfd3ed84> |
08:22 |
|
huginn` |
News from kohagit: Bug 20292: Add sponsor details <http://git.koha-community.org/[…]2871b63ca634124ee> |
08:22 |
|
huginn` |
News from kohagit: Bug 23309: Use Koha::MarcSubfieldStructures to create to subfields <http://git.koha-community.org/[…]c701222784ec0893f> |
08:22 |
|
huginn` |
News from kohagit: Bug 23309: Update DB <http://git.koha-community.org/[…]4691e36f5dc04e68e> |
08:22 |
|
huginn` |
News from kohagit: Bug 23253: Fix OpacNavRight for self reg by email <http://git.koha-community.org/[…]64050a536b9c2815d> |
08:22 |
|
huginn` |
News from kohagit: Bug 23253: (bug 22318 follow-up) Fix OpacNavRight even if opacuserlogin is off <http://git.koha-community.org/[…]8f62bf12854e5a838> |
08:22 |
|
huginn` |
News from kohagit: Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email <http://git.koha-community.org/[…]95820b602225c75f5> |
08:29 |
|
magnuse |
ashimema: nope, not on the list |
08:29 |
|
ashimema |
no worries |
08:30 |
|
* ashimema |
is now looking at bug 23454 |
08:30 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23454 major, P5 - low, ---, koha-bugs, NEW , Fine for the previous overdue may get overwritten by the next one |
08:30 |
|
ashimema |
not sure I understand Hemantha's test plan |
08:34 |
|
ashimema |
reading the code I really really can't see how it's doing what they're suggesting |
08:35 |
|
cait |
did you see the broken links bug? |
08:35 |
|
ashimema |
erm.. |
08:35 |
|
ashimema |
bug number? |
08:35 |
|
cait |
ashimema: same for me - i see 2 cases: fine from a different user for the same item |
08:35 |
|
cait |
or fine for the same user - but then I don't undertand the difference to what i usggested |
08:36 |
|
ashimema |
right.. one thing at a time |
08:36 |
|
ashimema |
is broken links related to this or something else entirely |
08:36 |
|
cait |
bug 23423 - we broke the file urls we generate ourselves with a recent xslt change |
08:36 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23423 major, P5 - low, ---, oleonard, NEW , Online resource links which are OPAC retrieve file references are not correctly formatted in the OPAC detail view |
08:36 |
|
cait |
i'd say revert from stable for now and revisit |
08:37 |
|
cait |
because bug 21887 got added all the way down |
08:37 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21887 minor, P5 - low, ---, kohadevinim, Pushed to stable , 856$u link problem in XSLT result lists and detail page |
08:37 |
|
ashimema |
:( |
08:37 |
|
ashimema |
I spent ages QAing that one from memory |
08:37 |
|
ashimema |
grr |
08:37 |
|
cait |
it shoudl only set http if the indicator says so i think |
08:38 |
|
cait |
if first indicator is http |
08:38 |
|
cait |
and http or https ar emissing |
08:38 |
|
ashimema |
sounds right |
08:38 |
|
cait |
yeah... but the implementation doesn't do that |
08:38 |
|
cait |
+ <xsl:otherwise> + <xsl:text>http://</xsl:text> + </xsl:otherwise> |
08:39 |
|
cait |
it's lazy |
08:39 |
|
ashimema |
hmm. ok |
08:39 |
|
cait |
because catalogers are... but we can't make up for bad data breaking stuff |
08:39 |
|
ashimema |
mmm |
08:40 |
|
cait |
if you both don't catlog the indicator and not set http... then you are out of luck in my opinion |
08:40 |
|
ashimema |
can I work through the fines issue first.. my brain was already part way through that.. |
08:40 |
|
ashimema |
I agree cait |
08:40 |
|
cait |
ok |
08:41 |
|
cait |
just wanted to make you aware because of the tracklinks thing |
08:41 |
|
cait |
something ot keep in mind |
08:41 |
|
ashimema |
ah, I see |
08:41 |
|
ashimema |
yeah.. Joubu's followup did confuse me somewhat there.. he added back http:// |
08:41 |
|
ashimema |
in a test |
08:41 |
|
ashimema |
which felt a bit wierd to me.. |
08:41 |
|
ashimema |
I think perhaps I need to test cases with indicator and without |
08:42 |
|
cait |
btw... all the examples on loc include the http |
08:42 |
|
ashimema |
GetMARCUri isn't all that well tested I think.. that's probably where that should get tested properly |
08:42 |
|
cait |
so i guess it's save to assume that it being added to the record is the normal use case |
08:42 |
|
cait |
especialyl since you can't encode https |
08:42 |
|
cait |
my issue is xslt side, but probably |
08:43 |
|
ashimema |
interesting |
08:43 |
|
cait |
http://www.loc.gov/marc/bibliographic/bd856.html |
08:45 |
|
ashimema |
I suppose you could do https via subfield $2 |
08:45 |
|
ashimema |
but it would end up pretty custom |
08:46 |
|
ashimema |
or.. just always try https when the first indicator is set to 4 (http) |
08:46 |
|
ashimema |
but.. yeah.. the examples all put the protocol iwthing the $u anyway! |
08:46 |
|
ashimema |
* but.. yeah.. the examples all put the protocol iwthing the $u anyways! |
08:52 |
|
koha-jenkins |
Project Koha_Master_D9 build #842: UNSTABLE in 28 min: https://jenkins.koha-community[…]ha_Master_D9/842/ |
08:56 |
|
|
inlibro joined #koha |
09:01 |
|
ashimema |
ok.. doesn't matter how many times I re-read Hemantha's comment.. I don't understand it |
09:01 |
|
cait |
have you tried mine? |
09:02 |
|
ashimema |
not yet |
09:02 |
|
ashimema |
have you tried it? |
09:04 |
|
koha-jenkins |
Project Koha_Master_D8 build #351: ABORTED in 41 min: https://jenkins.koha-community[…]ha_Master_D8/351/ |
09:04 |
|
koha-jenkins |
Project Koha_Master_U18 build #328: FAILURE in 39 min: https://jenkins.koha-community[…]a_Master_U18/328/ |
09:05 |
|
ashimema |
It feels like Jenkins has run out of space or something again |
09:10 |
|
ashimema |
ooh.. 21887 wasn't one I QA'd |
09:21 |
|
ashimema |
`When recording a URL in subfield $u, the value corresponds to the access method (URL scheme), which is also the first element in the string.` |
09:21 |
|
ashimema |
doesn't that pretty much state $u should always include protocol? |
09:23 |
|
cait |
ashimema: not yet... it was reported against 18.11 so could be a backporting issue too |
09:23 |
|
cait |
fines changed in between i think withmore going in |
09:23 |
|
ashimema |
me either |
09:33 |
|
|
andreashm joined #koha |
09:34 |
|
* andreashm |
waves |
09:34 |
|
magnuse |
\o/ |
09:34 |
|
* magnuse |
wanders off to find food |
09:35 |
|
ashimema |
grr.. |
09:35 |
|
andreashm |
Does anyone know what the syspref AccountAutoReconcile actually does? I can't find any information in the manual etc. |
09:35 |
|
ashimema |
GetMarcUrls does something different again with the 856 cait |
09:36 |
|
ashimema |
andreashm |
09:36 |
|
wahanui |
andreashm is probably this the ppt from last kohacon? |
09:36 |
|
ashimema |
AccountAutoReconcile sets whether or not any existing credits will automatically be applied to a debit when it's added to the system (and vica versa) |
09:37 |
|
andreashm |
Ah, thanks. |
09:37 |
|
ashimema |
i.e.. if you give a user £25 credit at the beggining of the year.. whenever they get fined some of the £25 will be used up automatically if AccountAutoReconcile is set to `Do` |
09:37 |
|
andreashm |
So it's new debits that get checked towards credits already there it that syspref is set to "Do"? |
09:37 |
|
ashimema |
if it's not.. then a staff member has to actually apply it via the client somewhere |
09:38 |
|
ashimema |
correct |
09:38 |
|
andreashm |
Cool thanks. |
09:38 |
|
cait |
ashimema: i know |
09:38 |
|
andreashm |
We would actually like to avoud using credits at all (but still want lost books returned to be refunded etc). I need to see what is possible to do. |
09:39 |
|
cait |
more for the use case... not all links are http/https - we got realtive urls too |
09:39 |
|
ashimema |
it also works the other way around I believe.. if a user has some fines outstanding and then they have a manual credit added by a staff user.. then if it's set to 'Do' then it will immediately apply that credit to those fines |
09:39 |
|
ashimema |
:) |
09:39 |
|
andreashm |
We never set manual credits, so don't think that will happen. =) |
09:39 |
|
ashimema |
we need consistency here cait.. I wish I'd caught this.. |
09:39 |
|
andreashm |
(Just because I said that, someone is bound to give a manual credit.... sometime soon!) |
09:39 |
|
ashimema |
hehe |
09:40 |
|
ashimema |
GetMarcUrls does seem to be closer to what the xslt does now than what it did before though.. |
09:40 |
|
ashimema |
it all feels wrong.. I'm not sure how to resolve this 'properly' |
09:40 |
|
ashimema |
it feels like $u should always include a protocol to me. |
09:41 |
|
cait |
i agree |
09:41 |
|
ashimema |
though.. that'll be nasty for relatie uri's |
09:41 |
|
cait |
hm |
09:41 |
|
cait |
we could set 78 |
09:41 |
|
cait |
sorry |
09:41 |
|
cait |
indocator 7 |
09:42 |
|
cait |
and a $2 |
09:42 |
|
cait |
when the file upload plugin is sued |
09:42 |
|
ashimema |
in which case.. perhaps if we start with `/` we should assume it's a relative URL? |
09:42 |
|
ashimema |
and skip adding protocols |
09:42 |
|
cait |
yeah that woudl work too |
09:42 |
|
cait |
and easier |
09:43 |
|
cait |
marc correctly... i guess first indiactor = 7 and a $2 with file |
09:43 |
|
cait |
but... who does super correct marc? |
09:43 |
|
cait |
http://www.loc.gov/standards/v[…]ectronaccess.html |
09:44 |
|
cait |
maybe for the xslt: |
09:45 |
|
cait |
if first indicator is empty and string doesn't start with / use http:// automatically? |
09:45 |
|
cait |
or first indicator = 4 (http) |
09:45 |
|
cait |
hm ok gets complicated |
09:45 |
|
ashimema |
I doubt `file` would work as currently that would result in `file:///cgi-bin/koha/opac-retrieve-file.pl?id=fjin` |
09:45 |
|
cait |
string doesn't contain http, doesn't start with /, has first indicator 4 or empty |
09:45 |
|
cait |
hm true |
09:46 |
|
koha-jenkins |
Yippee, build fixed! |
09:46 |
|
wahanui |
Congratulations! |
09:46 |
|
koha-jenkins |
Project Koha_Master_D8 build #352: FIXED in 41 min: https://jenkins.koha-community[…]ha_Master_D8/352/ |
09:46 |
|
cait |
nice |
09:47 |
|
ashimema |
Jenkins really isn't very well at the moment |
09:47 |
|
ashimema |
so many random failures.. but mostly seem to be run time or space related |
09:48 |
|
ashimema |
hmmm |
09:48 |
|
ashimema |
marc is designed to be shared right? |
09:49 |
|
ashimema |
so.. really.. relative URL's shouldn't be a think.. as if you end up copy catalogueing you're relative base will be different |
09:49 |
|
ashimema |
so.. I'm back to saying all $u should include the protocol |
09:49 |
|
ashimema |
and that should also mean including the base url |
09:50 |
|
ashimema |
thoughts cait...? |
09:50 |
|
ashimema |
it would result in a need to update all existing marc records that contain a relative URI in them |
09:51 |
|
ashimema |
and obviously updating the upload and attach feature itself |
09:51 |
|
ashimema |
all a bit painful |
09:51 |
|
cait |
ashimema: we add them through the upload featrue |
09:51 |
|
ashimema |
yup |
09:51 |
|
cait |
so... yeah we caused an issue |
09:51 |
|
ashimema |
it would be easy enough to fix that to include base URL |
09:52 |
|
cait |
hm |
09:52 |
|
cait |
in the data or just on the fly? |
09:52 |
|
eythian |
ashimema: definitely should always be a fully-specified URL |
09:52 |
|
ashimema |
but it's the backwards stuff that's more interesting |
09:52 |
|
cait |
oh |
09:52 |
|
cait |
base url opac or staff? |
09:52 |
|
cait |
opac i guess |
09:52 |
|
cait |
not totalyl user how the linking works right now |
09:52 |
|
ashimema |
mm, indeed cait |
09:53 |
|
cait |
tbh i haven' tused the upload feature yet |
09:53 |
|
cait |
os i am not sure what the caes are there |
09:53 |
|
eythian |
I'd suggest that if you need a reference to a record within the system, you use a custom field for it that you can put an appropriate record descriptor into. |
09:53 |
|
ashimema |
if we're being rigorous we should also set $7 depending on whether you need an opac login or not to access the file |
09:54 |
|
cait |
which codes? |
09:55 |
|
cait |
ah ok |
09:55 |
|
cait |
i see |
09:55 |
|
cait |
is this a feature yet? |
09:55 |
|
ashimema |
what.. the upload files ? |
09:55 |
|
* ashimema |
is now confused |
09:56 |
|
|
inlibro joined #koha |
10:00 |
|
cait |
no the internal external |
10:00 |
|
ashimema |
lol.. well opac-retrieve-file has been around sine 2012! |
10:01 |
|
ashimema |
sorry.. what do you mean by internal/external? |
10:01 |
|
cait |
do we have links generated that can only be accessed from staff side |
10:01 |
|
cait |
i really don't know much about the upload feature |
10:01 |
|
ashimema |
I don't believe so |
10:02 |
|
cait |
we got 2 issues righ tnow about urls... sec and regression... maybe just ned to focus on those first |
10:11 |
|
|
khall joined #koha |
10:16 |
|
koha-jenkins |
Yippee, build fixed! |
10:16 |
|
wahanui |
Congratulations! |
10:16 |
|
koha-jenkins |
Project Koha_Master_D9 build #843: FIXED in 28 min: https://jenkins.koha-community[…]ha_Master_D9/843/ |
10:21 |
|
|
irma_ joined #koha |
10:25 |
|
ashimema |
right.. I'm even more baffled now... |
10:26 |
|
ashimema |
I can't see how they got relative URI's in the 856 in the first place.. short of deleting the base URL |
10:26 |
|
ashimema |
when I add one via the cataloguing UI it adds in the base url |
10:26 |
|
* ashimema |
has wasted enough time on this today and is going to move on. |
10:28 |
|
cait |
ok, maybe they did? |
10:28 |
|
cait |
we should ask... will do as I dragged yo udown into this |
10:30 |
|
ashimema |
I've aksed |
10:31 |
|
cait |
oh |
10:31 |
|
ashimema |
lol |
10:31 |
|
ashimema |
no worries.. we both asked |
10:31 |
|
ashimema |
still.. at least he knows people are looking at it now |
10:31 |
|
cait |
yep |
10:31 |
|
cait |
and i was mistaken about the link to the upload feature potentially... which actually makes me feel better |
10:31 |
|
cait |
this would have been bad |
10:32 |
|
ashimema |
I still don't really like 21887 much though.. |
10:32 |
|
cait |
yeah |
10:32 |
|
cait |
i think i will do a follow up |
10:32 |
|
ashimema |
I wonder if it's a case of OPACBaseUrl not being set |
10:32 |
|
cait |
it goes from the same assumption as this one.... |
10:32 |
|
cait |
i think 23423 is copy and paste from catalogers |
10:32 |
|
cait |
leaving off the thttp |
10:32 |
|
cait |
because browsers will resolve it |
10:33 |
|
ashimema |
yeah.. a followup bug to correct some logic for 21887 would be awesome.. I'm still not 100% sure what it should do.. |
10:33 |
|
cait |
often on printed media and the li nk the http is not there |
10:33 |
|
cait |
i can try... but probably not getting to it any time soon |
10:33 |
|
cait |
just too tried this week |
10:33 |
|
ashimema |
sorta feels like we shouldn't be encouraging leaving out the protocol at all |
10:34 |
|
ashimema |
hmm |
10:35 |
|
cait |
yeah |
10:35 |
|
cait |
but the otherwise section is still a bit fishy in the xslt |
10:35 |
|
eythian |
if you have a link without a protocol in a <a href="">, it won't do the right thing |
10:36 |
|
eythian |
it will treat it as relative |
10:36 |
|
cait |
especially since it doesn't take into accoutn the standard right - like all the other protocols possible |
10:36 |
|
cait |
first indicator and $2 |
10:36 |
|
ashimema |
indeed eythian.. |
10:36 |
|
cait |
eythian: i think this is waht the library used for their 'advantage' |
10:36 |
|
ashimema |
what we're doing though it randomly trying to guess a protocol if it's missing.. which seems a bit off too |
10:36 |
|
cait |
and we broke it now with pushin ghttp:// in front |
10:37 |
|
cait |
we are guessing too much for sure |
10:37 |
|
eythian |
yeah, you can't really guess |
10:37 |
|
cait |
we can make it at least stricter |
10:37 |
|
eythian |
it's just not a URL if it doesn't have a protocol, so it should really fail validation. |
10:37 |
|
cait |
so guess... when they indicate it's http and if it's really nothing else specific |
10:37 |
|
cait |
eythian: vaidation in cataloguing? :) |
10:37 |
|
eythian |
a brave new world :) |
10:37 |
|
ashimema |
hehe |
10:38 |
|
* ashimema |
randomly fancies hunting down eythian and sitting down for a pint together again some time.. it's been toooooo long |
10:39 |
|
eythian |
ashimema: I'll be in Ireland for a bit in September, and London in October (details TBD however.) |
10:39 |
|
ashimema |
ooh.. London is close :) |
10:39 |
|
* cait |
is slightly jealous already |
10:40 |
|
eythian |
cait: I might be in Munich in October :) |
10:40 |
|
ashimema |
though October is a rather busy month too |
10:40 |
|
eythian |
ashimema: I'm hoping to have nearly a week there, so I'm sure something can work out. |
10:42 |
|
ashimema |
:) |
10:42 |
|
cait |
ah my brother is close to Munich... what are you doing there? |
10:42 |
|
eythian |
(my parents are visiting the UK+Ireland, so I'm meeting them for a bit at the start and at the end of their trip.) |
10:42 |
|
eythian |
cait: there's a band playing I want to see, and I have someone's spare room I can use. |
10:43 |
|
cait |
ah, sounds busy |
10:43 |
|
eythian |
Yeah. Will also be in Naples in October. |
10:43 |
|
cait |
wow |
10:43 |
|
cait |
i got 3 weeks of vacation in november... |
10:44 |
|
eythian |
Tonight I need to go make sure my calendar is up to date as a friend wants to meet up to explore a castle around here some weekend, and I'm not sure exactly when I'm free. |
10:44 |
|
eythian |
I haven't had a lot of holiday lately, so it's mostly going to September/October. |
10:45 |
|
eythian |
Hopefully with some left over for next year going to NZ for a few weeks. |
10:55 |
|
cait |
how many days do you have annual leave? |
10:56 |
|
|
inlibro joined #koha |
11:01 |
|
|
dj joined #koha |
11:01 |
|
|
khall joined #koha |
11:02 |
|
|
irma joined #koha |
11:02 |
|
magnuse |
i don't ask for much, i just need a 6 month vacation twice a year |
11:03 |
|
|
BobB_ joined #koha |
11:20 |
|
magnuse |
this is weird. i have one instance where some of the letters for browsing patrons does not render anything on the page. the data arrives ok in the browser, but it is stuck at "processing". nothing in the firebug console. |
11:20 |
|
magnuse |
always the same result for the same letter, so not random in that sense |
11:26 |
|
eythian |
cait: 5 weeks |
11:31 |
|
|
oleonard joined #koha |
11:32 |
|
oleonard |
Hi all |
11:36 |
|
magnuse |
hah, looks like a tab at the end of the email was the culprit |
11:46 |
|
|
andreashm joined #koha |
11:49 |
|
|
khall joined #koha |
11:57 |
|
|
inlibro joined #koha |
11:59 |
|
koha-jenkins |
Yippee, build fixed! |
11:59 |
|
wahanui |
Congratulations! |
11:59 |
|
koha-jenkins |
Project Koha_Master_U18 build #329: FIXED in 39 min: https://jenkins.koha-community[…]a_Master_U18/329/ |
12:01 |
|
|
jzairo joined #koha |
12:14 |
|
|
jzairo left #koha |
12:14 |
|
|
jzairo joined #koha |
12:16 |
|
andreashm |
Am I correct in the assumption that Koha does differentiate between a ckecked in book with hold, that has pick-up location at the same library, and a hold with a pick-up location on another branch? The same hold-found2 modal seems to be triggered in both cases. |
12:18 |
|
andreashm |
Are we the only ones who wouldlike the option to print a transfer slip on library A, and then have the item checked in and a hold slip printed at library B? |
12:18 |
|
cait |
hm shoudl it not say Tansport to in the lower part? |
12:18 |
|
cait |
i thought it did last time i checked |
12:18 |
|
cait |
not on the heading, but in the last 2 bold lines or so |
12:18 |
|
cait |
andreashm: actually i thought it worked like that... but we are not dealing with holds between branches currently |
12:18 |
|
oleonard |
Having been spending a fair amount of time in returns.tt lately I think you're correct andreashm |
12:19 |
|
andreashm |
oleonard: yeah, I was afraid of that. |
12:20 |
|
andreashm |
cait: probably does. But there is no option to print a transfer slip |
12:20 |
|
oleonard |
ashimema: So you want to have consistent use of transfer slips when moving items between libraries |
12:20 |
|
oleonard |
I mean andreashm: |
12:21 |
|
andreashm |
We have had a workaround of confirming the hold and transfer and then returning the item again which triggers the transfer-alert-box (whatever it is called) |
12:22 |
|
* ashimema |
listens in |
12:22 |
|
* oleonard |
wonders if you could hack the notice to get what you want |
12:22 |
|
andreashm |
We would like to have the option of "Print transfer slip" on the hold modal. (But probably only if there actually is a transfer) |
12:22 |
|
ashimema |
I find the transfers system a tad confusing and wierd at the moment ;) |
12:22 |
|
ashimema |
we use it for stockrotation.. but it feels odd in it's mechanics |
12:22 |
|
andreashm |
I guess it's possible to use JQuery or something to add a print transfer button if it is a hold that should be transferred. |
12:23 |
|
andreashm |
But seems a round-about way of doing it |
12:23 |
|
andreashm |
(oleonard:) |
12:24 |
|
andreashm |
I've seen other adding a line in the beginning of the hold letter: "Hold for: <branch>" |
12:24 |
|
andreashm |
But that seems like an even more clumsy way of handling it. |
12:26 |
|
oleonard |
I wonder a generalized solution would be to add a separate slip for holds requiring transfers? |
12:28 |
|
andreashm |
Hold-transfer slip? Yeah, that would perhaps make most sense. |
12:29 |
|
oleonard |
That would eliminate the necessity of adding another button to the hold notification modal, which I would like to avoid |
12:30 |
|
oleonard |
Libraries who didn't care about this issue could put the same content in hold-slip and hold-transfer-slip |
12:30 |
|
andreashm |
Yeah, might be even more confusing. |
12:30 |
|
andreashm |
exactly |
12:33 |
|
* oleonard |
puts on his list to check whether we really need hold-found1 and hold-found2... could probably be combined in returns.tt |
12:33 |
|
andreashm |
hold-found1 is for when a hold is waiting right? |
12:34 |
|
oleonard |
Yes, already waiting |
12:34 |
|
* oleonard |
realizes he just sent a random character to Windows' "restart now?" dialog and doesn't know which one |
12:35 |
|
ashimema |
lol |
12:37 |
|
oleonard |
I'm still here, so... |
12:37 |
|
eythian |
so you pressed the "restart in ~ minutes without warning" option? |
12:37 |
|
oleonard |
Where ~ is randomized :D |
12:43 |
|
* oleonard |
crosses his fingers and bites the bullet |
12:55 |
|
|
oleonard joined #koha |
12:56 |
|
* oleonard |
gives up and installs Windows 2000 |
12:57 |
|
|
inlibro joined #koha |
12:58 |
|
cait |
if we had a separate notice it could fall back to the normal holds one if not defined maybe... |
12:58 |
|
cait |
or pref it ;) |
12:58 |
|
cait |
so people don't have to double up |
13:04 |
|
andreashm |
a fallback if no notice for transfer-holds is defined sounds like a nice solution. |
13:05 |
|
cait |
the pref would give a bit better documentation |
13:06 |
|
cait |
and allow us to add default notices and stuff... |
13:07 |
|
andreashm |
https://bugs.koha-community.or[…]_bug.cgi?id=23292 |
13:07 |
|
huginn` |
Bug 23292: enhancement, P5 - low, ---, johanna.raisa, Needs Signoff , Use TransferSlip when transfering item which is on hold |
13:07 |
|
andreashm |
That would work too |
13:07 |
|
cait |
looks like you are not alone at all |
13:08 |
|
andreashm |
=) |
13:20 |
|
magnuse |
nah, we are all alone |
13:20 |
|
andreashm |
I should get my devbox running again and test that bug |
13:21 |
|
magnuse |
andreashm++ |
13:22 |
|
andreashm |
project for tomorrow maybe. |
13:31 |
|
caroline_catlady |
good morning! |
13:35 |
|
cait |
good morning caroline_catlady! |
13:40 |
|
|
magnuse joined #koha |
13:47 |
|
|
khall joined #koha |
13:57 |
|
|
inlibro joined #koha |
13:59 |
|
oleonard |
cait: Bug 23445 |
13:59 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23445 normal, P5 - low, ---, katrin.fischer, Needs Signoff , Loan period unit in circulation rules is untranslatable causing problems one editing rules |
13:59 |
|
oleonard |
No |
13:59 |
|
oleonard |
Bug 23455 |
13:59 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23455 major, P5 - low, ---, oleonard, Needs Signoff , Patron card printing from Patron lists is broken |
14:00 |
|
cait |
but a sign-off would be nice too :) |
14:01 |
|
oleonard |
I almost attached my patch to that bug because my fingers can't stop typing it wrong |
14:01 |
|
cait |
oh |
14:01 |
|
cait |
filter problems? |
14:01 |
|
|
magnuse joined #koha |
14:02 |
|
oleonard |
cait: JavaScript on one page referred to an HTML id on another page which went away with Bug 20650 |
14:02 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20650 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Switch single-column templates to Bootstrap grid: Various, part 3 |
14:05 |
|
cait |
oh the lovely side effects |
14:05 |
|
cait |
i had a short go at debugging... as you saw in the comment... but got quite stuck |
14:08 |
|
cait |
ok, sun is out - i better leave before the next rain cloud |
14:08 |
|
cait |
bye all! |
14:08 |
|
|
cait left #koha |
14:16 |
|
andreashm |
bye #koha |
14:56 |
|
|
oleonard joined #koha |
14:57 |
|
|
inlibro joined #koha |
15:05 |
|
|
lisettelatah joined #koha |
15:06 |
|
|
khall joined #koha |
15:18 |
|
|
khall joined #koha |
15:57 |
|
|
inlibro joined #koha |
16:29 |
|
bag |
morning all |
16:47 |
|
|
cait joined #koha |
16:58 |
|
|
inlibro joined #koha |
17:06 |
|
|
oleonard joined #koha |
17:28 |
|
caroline_catlady |
anyone know if we can search by acqdate in the OPAC using < or > or => or =<) |
17:28 |
|
caroline_catlady |
I tried with = and it works but I can't figure out how to use the greater than, less than, etc |
17:50 |
|
lisettelatah |
I haven't tried it but you might need to use the urlencode character for it < %3C > %3E |
17:58 |
|
|
inlibro joined #koha |
18:00 |
|
caroline_catlady |
lisettelatah: not working either, but I noticed that even if I change the URL to put %3D, once I hit enter, it changes back to >, unlike the other symbols which stay as %3X |
18:46 |
|
cait |
caroline_catlady: in theory i think you need to use st-numeric |
18:47 |
|
cait |
acqdate,st-numeric ... etc |
18:47 |
|
cait |
but i never got it to work right |
18:47 |
|
caroline_catlady |
I'm pretty sure I tried that, but let me try again (I did so many tries, I can't be 100% sure I did) |
18:47 |
|
cait |
bug 17815 |
18:47 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17815 normal, P5 - low, ---, gmcharlt, NEW , Problems with search for dateaccessioned |
18:48 |
|
cait |
hm not the one i was looking for actulally |
18:49 |
|
cait |
maybe this? bug 10816 |
18:49 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10816 normal, P5 - low, ---, chris, NEW , Relational operators in Search |
18:49 |
|
cait |
it says use ge= |
18:49 |
|
cait |
yr,st-numeric,ge=2000 (greater equal) |
18:51 |
|
caroline_catlady |
ok that's a new info, I will try that |
18:54 |
|
pastebot |
"caroline_catlady" at 127.0.0.1 pasted "still not working... can you spot the error?" (1 line) at http://paste.koha-community.org/7115 |
18:56 |
|
cait |
not really |
18:56 |
|
cait |
does it work just using the acdate without the others? |
18:56 |
|
caroline_catlady |
hm, didn't try that |
18:56 |
|
cait |
just to limit it doen a bit |
18:57 |
|
caroline_catlady |
yeah, still not working |
18:57 |
|
cait |
hmpf |
18:57 |
|
caroline_catlady |
also tried acqdate,st-date,ge=2019-01-01 |
18:57 |
|
cait |
i thiki have 2 old tickets about this too |
18:57 |
|
cait |
there should be another bug report i can't spot right now |
18:58 |
|
|
inlibro joined #koha |
19:19 |
|
cait |
caroline_catlady: for this search... maybe = 2019 and ...,rtrn=202 could work? |
19:22 |
|
caroline_catlady |
acqdate,rtrn=2019 returns the whole database, but it's a test database, so I wonder if they all have acquisitions dates in 2019 |
19:23 |
|
caroline_catlady |
yup, so it works! It doesn't give the results I want, but it works! |
19:23 |
|
caroline_catlady |
cait++ |
19:24 |
|
cait |
heh :) |
19:24 |
|
cait |
caroline_catlady++ :) |
19:25 |
|
|
lisettelatah joined #koha |
19:26 |
|
caroline_catlady |
Is there any plan/demand for developping dynamic lists? e.g. lists based on sql requests for example |
19:33 |
|
|
andreashm joined #koha |
19:35 |
|
cait |
caroline_catlady: have you seen issues with the fr-CA installer? |
19:35 |
|
cait |
bug 23353 |
19:35 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23353 blocker, P5 - low, ---, koha-bugs, REOPENED , Fresh installation duplicate keys ACQ-020 |
19:37 |
|
caroline_catlady |
oh it's been a while since I used the installer... But I seem to remember something about the acq framework |
19:38 |
|
cait |
hm i think i see the problem |
19:38 |
|
cait |
sec |
19:39 |
|
cait |
the first 2 inserts and the second 2 both add the framework |
19:39 |
|
cait |
http://paste.koha-community.org/7123 |
19:39 |
|
cait |
the first is a full copy of the default |
19:39 |
|
cait |
and the second is a partial copy |
19:39 |
|
cait |
for only some fields |
19:40 |
|
cait |
the second would not copy the 952 |
19:41 |
|
cait |
but when it tries to do the inserts of the same fields/subfields a second time it epxlodes |
19:41 |
|
caroline_catlady |
not sure I understand |
19:41 |
|
cait |
it adds a copy of default as ACQ framewor with all fields |
19:42 |
|
cait |
then it tries to add the fields again, but only those mapped to certain biblio fields... |
19:42 |
|
cait |
and that explodes |
19:42 |
|
cait |
because the fields are already there |
19:42 |
|
caroline_catlady |
the one where it explodes is the fourth "insert into"? |
19:42 |
|
cait |
the third probably |
19:42 |
|
cait |
already |
19:43 |
|
cait |
oh no |
19:43 |
|
cait |
forgot the frameowrk one |
19:43 |
|
cait |
the 4th |
19:44 |
|
caroline_catlady |
did you compare with the original en? |
19:44 |
|
cait |
i just looked at de-de |
19:44 |
|
cait |
there is no acq sample |
19:44 |
|
cait |
checking en now |
19:44 |
|
cait |
seems there isn't one in en either |
19:45 |
|
caroline_catlady |
strange |
19:45 |
|
cait |
you can add your own stuff |
19:45 |
|
cait |
the web installer checks for the files existing and text files for the descriptions |
19:45 |
|
cait |
other languages have done this too |
19:45 |
|
caroline_catlady |
but which framework is used in acquisitions if there isn't one at the beginning? |
19:46 |
|
cait |
we always add one |
19:46 |
|
cait |
as part of the basic config |
19:46 |
|
cait |
and it falls back to default |
19:47 |
|
caroline_catlady |
ok, I always thought it was part of Koha and we had just transated it |
19:47 |
|
cait |
i didn't spot it in the 2 installers i checked |
19:47 |
|
cait |
i will change the bug report to point out the mistake in the file |
19:48 |
|
cait |
i am not sure how you want the framework, so not sure how to fix |
19:51 |
|
caroline_catlady |
I don't understand what the 4th insert into is trying to do |
19:52 |
|
cait |
i think the idea might have been to have a very small acq framework... |
19:52 |
|
cait |
but it seems to have gone in untested |
19:53 |
|
caroline_catlady |
the only difference I noticed in the ACQ framework is that there are less item fields (like lost, and withdrawn are not there, because usually you're not acquiring a lost something) |
19:53 |
|
cait |
it looks like it was Joubu |
19:53 |
|
cait |
yeah but that is only from the visibility thing |
19:53 |
|
cait |
s |
19:54 |
|
cait |
hm it sets tab to -1 actually: UPDATE marc_subfield_structure SET tab = -1 |
19:54 |
|
cait |
that is 'ignore' |
19:54 |
|
cait |
look here: |
19:54 |
|
cait |
http://git.koha-community.org/[…]64050a536b9c2815d |
19:54 |
|
cait |
the lines 40-56 change the item fields |
19:54 |
|
caroline_catlady |
yeah that is what I was thinking abou |
19:55 |
|
caroline_catlady |
it's just the queries where there are kohafield = "" that I'm not sure what they do |
19:55 |
|
cait |
i think they are there by mistake |
19:56 |
|
cait |
you can now use the biblio part of the framework too |
19:56 |
|
cait |
UseACQFrameworkForBiblioRecords |
19:56 |
|
caroline_catlady |
or the 2nd and 3rd are there by mistake? If like you said the point was to have a smaller framwork, I would only put the 4th and the 5th ones |
19:56 |
|
cait |
that removes the hardcoded form and displays the fields from the framework in the acquisition module instead |
19:56 |
|
cait |
i think the lines were added by accident in context of this enh |
19:56 |
|
caroline_catlady |
Yeah, I've used it before |
19:57 |
|
cait |
more the 4th and 5th are by mistake |
19:57 |
|
cait |
I have no idea what Joubu was trying to do there |
19:57 |
|
caroline_catlady |
when you git blame, can you see the dates? |
19:57 |
|
caroline_catlady |
can we see which one was there first? |
19:57 |
|
cait |
you can click on history in the gitweb too :) |
19:57 |
|
cait |
but yeah git blame does the trick as well |
19:58 |
|
cait |
it as this change here: |
19:58 |
|
cait |
http://git.koha-community.org/[…]bdd5ea56a6ff65e1a |
19:58 |
|
|
inlibro joined #koha |
19:58 |
|
caroline_catlady |
http://git.koha-community.org/[…]bdd5ea56a6ff65e1a |
19:58 |
|
cait |
it made the same change to 3 fr-CA files |
19:59 |
|
caroline_catlady |
looks like those two were added in a bunch of languages, not just fr-CA |
19:59 |
|
cait |
probably a mistake in a script... maybe because your structure is different |
19:59 |
|
cait |
the other languages didn't have a full ACQ frameowrk |
20:00 |
|
cait |
but fr-CA has |
20:00 |
|
caroline_catlady |
oh yes, I see it now |
20:01 |
|
caroline_catlady |
it was added originally by francharb |
20:01 |
|
cait |
I thnk the question si if you want to keep it like that |
20:01 |
|
cait |
as a separate file |
20:01 |
|
cait |
or move it with the others like the other languages do |
20:01 |
|
caroline_catlady |
I'm trying to figure out why it was done this way |
20:02 |
|
caroline_catlady |
I'll ask eric see if he remembers |
20:02 |
|
cait |
ok |
20:02 |
|
cait |
i ocmmented on the bug - should have enough to fix it |
20:02 |
|
cait |
not hard to fix, just have to decide what to do |
20:03 |
|
|
kathryn joined #koha |
20:05 |
|
cait |
good morning kathryn |
20:05 |
|
caroline_catlady |
I'm sure there was a good reason at the time, especially if you have to create it during config, makes sense that it is already there |
20:06 |
|
caroline_catlady |
do you know if there were some in other languages that have been removed since? |
20:06 |
|
kathryn |
evening cait :) |
20:07 |
|
kathryn |
hi caroline_catlady |
20:07 |
|
caroline_catlady |
good morning kathryn |
20:07 |
|
cait |
caroline_catlady: i think it might have been there first |
20:07 |
|
cait |
before the othe rlanguage got acq frameworks added |
20:08 |
|
cait |
but the other languages used the existing file and the existing extra fr-CA file was missed |
20:08 |
|
caroline_catlady |
not sure I understand, sorry |
20:10 |
|
caroline_catlady |
http://git.koha-community.org/[…]0c4be292bbbe4b25b |
20:10 |
|
caroline_catlady |
? |
20:10 |
|
cait |
the fr-CA is the only installer with a separte file adding an ACQ framework |
20:11 |
|
caroline_catlady |
ah ok, whereas the other languages have it in the simple_bib_framework file? |
20:11 |
|
cait |
yep |
20:11 |
|
caroline_catlady |
aaaah! |
20:11 |
|
cait |
an dprobably that was added later |
20:11 |
|
cait |
so we now have a double up |
20:11 |
|
caroline_catlady |
ok NOW I understand :) |
20:11 |
|
cait |
hm it loks like fr-FR might also have the problem? |
20:12 |
|
cait |
hm have to verify that, the fr-* get me confused |
20:12 |
|
caroline_catlady |
don't know, I can't see a separate file for them |
20:12 |
|
caroline_catlady |
and anyway, I don't think they use MARC21 |
20:12 |
|
cait |
yeah |
20:12 |
|
cait |
we will leave the bug as is for now, i t hink the fr-FR is ok |
20:13 |
|
caroline_catlady |
ok, so we (I) have to decide if we keep it as a separate file or not and submit a patch for the bug., is that it? |
20:13 |
|
cait |
if yo ucomment, i can help too ... but a patch would be great :) |
20:15 |
|
caroline_catlady |
in your last comment, you say that 2 fr-CA files were amended, but there is only one and two fr-FR no? |
20:15 |
|
cait |
ok, now i am not following anymore :) |
20:15 |
|
cait |
thinking about this ocmmit here: http://git.koha-community.org/[…]bdd5ea56a6ff65e1a |
20:16 |
|
caroline_catlady |
yeah ^ that commit has only 1 fr-CA file |
20:16 |
|
caroline_catlady |
unless I'm not looking at the right place |
20:16 |
|
cait |
yeah the ohter are fr-FR |
20:16 |
|
cait |
it hink both the one you had and this one together made too many changes |
20:16 |
|
caroline_catlady |
ok |
20:17 |
|
caroline_catlady |
I will clean it up |
20:17 |
|
caroline_catlady |
hopefully this is truly the problem, because tcohen seems to have another one in the comment jhust before yours |
20:17 |
|
cait |
ah, fr-FR - one is marc21 and one is unimarc.. so that looks ok |
20:18 |
|
cait |
hm pretty sure |
20:19 |
|
cait |
he says it's fr-CA |
20:19 |
|
tcohen |
hola caroline_catlady |
20:19 |
|
cait |
hi tcohen |
20:19 |
|
tcohen |
hola cait |
20:19 |
|
caroline_catlady |
hi tcohen |
20:19 |
|
cait |
we are trying to discuss bug 23353 |
20:19 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23353 major, P5 - low, ---, koha-bugs, NEW , ACQ framework makes fr-CA web installer explode |
20:19 |
|
cait |
and confuse each other |
20:19 |
|
caroline_catlady |
we were just discussing bug 23353 |
20:19 |
|
tcohen |
yes |
20:19 |
|
cait |
commented on the bug |
20:19 |
|
tcohen |
I read it |
20:20 |
|
cait |
dismiss the last comment |
20:20 |
|
tcohen |
what I found was that the translations were notgenerated correctly |
20:20 |
|
cait |
i got confused between fr-FR and fr-CA |
20:20 |
|
cait |
the acq file is not generated |
20:20 |
|
cait |
your bug is diferent to the one reported i tihnk |
20:21 |
|
cait |
I htink there might be 2 issues? |
20:21 |
|
cait |
[Mon Jul 22 03:04:19 2019] install.pl: DBD::mysql::st execute failed: Duplicate entry 'ACQ-020' for key 'PRIMARY' at /usr/share/perl5/DBIx/RunSQL.pm line 273. < this is from the wrong sql file |
20:21 |
|
cait |
And this: Template process failed: file error - /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/fr-CA/modules/onboarding/onboardingstep1.tt: not found at /usr/share/koha/lib/C4/Templates.pm line 122. " might be tranlsatoin related? |
20:28 |
|
tcohen |
I think there are several issues |
20:28 |
|
cait |
agreed |
20:29 |
|
|
lukeG joined #koha |
20:41 |
|
|
lukeG1 joined #koha |
20:47 |
|
|
alexbuckley joined #koha |
20:49 |
|
wizzyrea |
hi alexbuckley |
20:53 |
|
alexbuckley |
hey wizzyrea :) |
20:58 |
|
|
inlibro joined #koha |
21:11 |
|
|
andreashm joined #koha |
21:28 |
|
|
lisettelatah joined #koha |
21:29 |
|
|
andreash_ joined #koha |
21:37 |
|
caroline_catlady |
good night! |
21:51 |
|
|
irma_ joined #koha |
21:58 |
|
|
inlibro joined #koha |
22:08 |
|
|
JesseM joined #koha |
22:54 |
|
|
kathryn joined #koha |
22:59 |
|
|
inlibro joined #koha |
23:03 |
|
|
khall joined #koha |
23:23 |
|
|
papa joined #koha |
23:59 |
|
|
inlibro joined #koha |