| Time |
S |
Nick |
Message |
| 00:08 |
|
|
wizzyrea joined #koha |
| 00:53 |
|
|
dpk_ joined #koha |
| 01:14 |
|
|
lavamind joined #koha |
| 02:53 |
|
|
edveal joined #koha |
| 05:10 |
|
|
chris joined #koha |
| 05:13 |
|
|
cait joined #koha |
| 05:36 |
|
|
calire joined #koha |
| 06:09 |
|
|
josef_moravec joined #koha |
| 06:12 |
|
|
calire joined #koha |
| 06:20 |
|
|
ere joined #koha |
| 06:45 |
|
|
reiveune joined #koha |
| 06:46 |
|
reiveune |
hello |
| 06:54 |
|
|
ashimema_ joined #koha |
| 06:54 |
|
ashimema_ |
morning |
| 06:59 |
|
|
andreashm joined #koha |
| 07:04 |
|
|
alex_a joined #koha |
| 07:05 |
|
alex_a |
bonjour |
| 07:05 |
|
|
fridolin joined #koha |
| 07:06 |
|
|
cait joined #koha |
| 07:11 |
|
cait |
can we get the full error to display on a package installation like in the kohadevbox? |
| 07:11 |
|
cait |
I haven't foudn docs yet on how to configure that, something to do with a flag for dev installations maybe? |
| 07:11 |
|
cait |
I'd like to have that on our test installation so I don't always have to ask for the logs |
| 07:24 |
|
* josef_moravec |
waves |
| 07:24 |
|
cait |
hi josef_moravec :) |
| 07:26 |
|
josef_moravec |
cait: I added follow-up to bug 16284 |
| 07:26 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=16284 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Borrower Previously Checked Out: Serials |
| 07:26 |
|
cait |
yep, just saw |
| 07:27 |
|
cait |
thank you |
| 07:27 |
|
|
alex_a_ joined #koha |
| 07:32 |
|
|
davidnind joined #koha |
| 07:41 |
|
|
severine_q joined #koha |
| 07:42 |
|
severine_q |
good mornig ! |
| 07:44 |
|
cait |
good mornign severine_q :) |
| 07:45 |
|
severine_q |
hi cait ! |
| 07:47 |
|
josef_moravec |
hi severine_q |
| 07:49 |
|
severine_q |
hi josef_moravec :) |
| 07:57 |
|
josef_moravec |
cait: thanks for testing bug 21757, if there is a change in behaviour, it is bug, the refactored code should behave the same I believe |
| 07:57 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21757 enhancement, P5 - low, ---, josef.moravec, Failed QA , Patron detail script (moremember.pl) cleanup |
| 08:06 |
|
cait |
josef_moravec: is my description ok?: |
| 08:06 |
|
cait |
just add a patron with the same surname firstname as an existing one |
| 08:06 |
|
josef_moravec |
cait: yep, I understand and see the issue ;) |
| 08:06 |
|
cait |
ok :) |
| 08:06 |
|
josef_moravec |
working on it now |
| 08:06 |
|
josef_moravec |
I was too aggresive on removing code ;) |
| 08:06 |
|
cait |
ashimema_: is the FFOR bug a candidate for the duplicate problem? |
| 08:07 |
|
josef_moravec |
:wq |
| 08:07 |
|
cait |
heh |
| 08:07 |
|
josef_moravec |
ops, it is not vim ;) |
| 08:17 |
|
severine_q |
Silly question, but can't decide myself... I identify a mandatory field with the label not red, should I declare the bug in "Templates" or in the module I found it in ? |
| 08:21 |
|
cait |
hm grey zone |
| 08:21 |
|
cait |
maybe try templates... then oleonard wil see it ;) |
| 08:22 |
|
ashimema_ |
FFOR duplicate program? |
| 08:22 |
|
ashimema_ |
huh cait ? |
| 08:22 |
|
wahanui |
i guess cait is qa manager |
| 08:23 |
|
cait |
problem |
| 08:23 |
|
cait |
my fingers have life of their own typing |
| 08:23 |
|
ashimema_ |
do you mean bug 22200 ? |
| 08:23 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22200 minor, P5 - low, ---, martin.renvoize, Failed QA , Forgiving a fine (FFOR) does not update the accountline date |
| 08:23 |
|
ashimema_ |
I'm currently stealing it and creating a rather different approach.. (also FFOR no longer exists in master ) |
| 08:24 |
|
cait |
yes |
| 08:24 |
|
ashimema_ |
so what did you mean by the 'duplicate program' |
| 08:24 |
|
cait |
the double fines problem |
| 08:25 |
|
ashimema_ |
ah.. no |
| 08:25 |
|
ashimema_ |
I don't think it's that |
| 08:25 |
|
severine_q |
thanks cait ! |
| 08:25 |
|
ashimema_ |
kidclamp suggested `check out overdue, charge fines, set finesforgiven when lost, mark lost, the patron has only the lost fee, fines are forgiven. Check in, the lost fine goes away, the overdue is recreated` |
| 08:27 |
|
ashimema_ |
I'm working my way back around to trying that later today |
| 09:17 |
|
cait |
bug 22753 is in 18.11 too |
| 09:17 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22753 could not be retrieved: InvalidBugId |
| 09:20 |
|
ashimema_ |
sorry.. what bug? |
| 09:37 |
|
josef_moravec |
can somebody try to test bug 22751?: |
| 09:37 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22751 could not be retrieved: InvalidBugId |
| 09:37 |
|
josef_moravec |
bug 22721 |
| 09:37 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22721 enhancement, P5 - low, ---, josef.moravec, Needs Signoff , Normalize GetMarcFromKohaField calls |
| 09:51 |
|
huginn` |
News from kohagit: Bug 21336: Add borrowers.flgAnonymized in an explicit position <http://git.koha-community.org/[…]b48dc0bb8df824f75> |
| 09:51 |
|
huginn` |
News from kohagit: Bug 21336: Fix the API <http://git.koha-community.org/[…]9324951ab1f7ed838> |
| 09:51 |
|
|
kidclamp joined #koha |
| 09:53 |
|
* kidclamp |
waves |
| 09:54 |
|
cait |
josef_moravec: can't retest right now, but maybe the problematic template was a patron without birthdate |
| 09:54 |
|
* cait |
waves at kidclamp |
| 09:54 |
|
cait |
ashimema_: sorry, bug 22735 |
| 09:54 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22735 major, P5 - low, ---, oleonard, NEW , Broken MARC and ISBD views |
| 10:05 |
|
|
indradg joined #koha |
| 10:07 |
|
josef_moravec |
cait: it makes sense, I'll try it |
| 10:14 |
|
josef_moravec |
cait: When there is no dateofbirth, the age is not shown at all... |
| 10:20 |
|
koha-jenkins |
Project Koha_Master_D9 build #709: STILL UNSTABLE in 26 min: https://jenkins.koha-community[…]ha_Master_D9/709/ |
| 10:24 |
|
cait |
josef_moravec: wonder what i had happen thre... test data |
| 10:24 |
|
cait |
invalid date? i will recheck |
| 10:24 |
|
cait |
but lost my db actually... tired and restart_all /reset_all mistake |
| 10:26 |
|
ashimema_ |
cait still here? |
| 10:27 |
|
ashimema_ |
do you have any recollection of how 'Rep' accountypes were originally used? |
| 10:27 |
|
cait |
just got back |
| 10:27 |
|
cait |
no idea |
| 10:27 |
|
cait |
i thought you knew :) |
| 10:27 |
|
ashimema_ |
haha |
| 10:27 |
|
ashimema_ |
I thought I did too.. but the more I read the more confused I'm not getting |
| 10:28 |
|
ashimema_ |
I 'thought' 'Rep' was a form of writeoff that signified that the patron had chose to go and buy a new book for the library as apposed to pay the libraries fee for replacing it |
| 10:29 |
|
ashimema_ |
I still think that's valid.. but I get the feeling from the code that that logic got broken over 14 years ago |
| 10:30 |
|
ashimema_ |
I only added the db update and UI for display in bug 22564 at marcelr's request.. I can see if the code is fixed in the future it could become useful again.. but at this point I don't want it to hold up the rest of this tree |
| 10:30 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22564 enhancement, P5 - low, ---, martin.renvoize, Failed QA , accounttype 'Rep' is still referred to but is never set |
| 10:30 |
|
koha-jenkins |
Project Koha_Master_D8 build #215: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]ha_Master_D8/215/ |
| 10:31 |
|
koha-jenkins |
Project Koha_Master_U18 build #203: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_U18/203/ |
| 10:32 |
|
cait |
ashimema_: i am fine with hat |
| 10:32 |
|
cait |
can you comment on the bug and switch it back? |
| 10:33 |
|
cait |
maybe we could throw a comment about it being unused right now in somewhere? |
| 10:33 |
|
ashimema_ |
sure |
| 10:36 |
|
indradg |
Hi |
| 10:36 |
|
indradg |
On a 18.05.11 db i just noticed something that I... |
| 10:37 |
|
indradg |
that i´m not being able to understand... NULLs in borrowernumber column for four returns in statistics table |
| 10:38 |
|
kidclamp |
if you check in a book that is not checked out you get that |
| 10:39 |
|
kidclamp |
if you enable ' RecordLocalUseOnReturn ' then they record as localuse |
| 10:40 |
|
indradg |
kidclamp: thats the strange part of the business... in the patronÅ› reading history i see the check out and the return today. same from the bib recordÅ› circulation history |
| 10:40 |
|
indradg |
it was checked out on 03-APR-2019 and returned on 18-APR-2019 |
| 10:41 |
|
kidclamp |
but maybe there were scanned twice at return |
| 10:43 |
|
indradg |
hmm |
| 11:07 |
|
|
irma joined #koha |
| 11:19 |
|
ashimema_ |
do we have any policies on when we can add debug logging via Koha::Logger.. |
| 11:22 |
|
|
khall joined #koha |
| 11:24 |
|
|
chris joined #koha |
| 11:34 |
|
kidclamp |
is there reason not to use it some places ashimema_ ? |
| 11:35 |
|
ashimema_ |
I think I mis-worded that |
| 11:35 |
|
ashimema_ |
more of a.. 'can we introduce logging "along the way"' in bugs |
| 11:36 |
|
|
oleonard joined #koha |
| 11:36 |
|
oleonard |
Hi all |
| 11:36 |
|
ashimema_ |
i.e. I keep finding places that are ripe for logging (at the right level) but I don't add the lines because it's just 'noise' for QA in the actual but |
| 11:36 |
|
ashimema_ |
s/but/bug/ |
| 11:36 |
|
kidclamp |
ah, like should it be sparate bugs or part of a bug |
| 11:36 |
|
ashimema_ |
but I never come back around and add them in their own bug |
| 11:36 |
|
ashimema_ |
exactly |
| 11:36 |
|
ashimema_ |
prime examples in this accounts tree |
| 11:37 |
|
ashimema_ |
there are some weird cases that could creep out if we logged stuff.. but I've not added logging as I can't easily justify it |
| 11:37 |
|
ashimema_ |
like.. we assume we'll onyl get one accountline back for lots of queries.. but it would be nice to log if that assumption ever failed |
| 11:38 |
|
ashimema_ |
would really help with debugging later in bugs that raise issues against them |
| 11:38 |
|
ashimema_ |
we could even go so far as to say QAers should encourage suitable logging |
| 11:48 |
|
kidclamp |
sounds like the incoming RM has plans ;-) |
| 11:48 |
|
|
alex_a joined #koha |
| 11:49 |
|
oleonard |
Assuming he survives the gladiatorial combat with other RM candidates |
| 11:50 |
|
ashimema_ |
lol |
| 11:50 |
|
ashimema_ |
thinking of standing oleonard? |
| 11:50 |
|
oleonard |
No I have weak puny muscles |
| 12:05 |
|
huginn` |
News from kohagit: Bug 15253: (follow-up) Fix qa complaints <http://git.koha-community.org/[…]647a0bc8530465bd7> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22532: DBRev 18.12.00.059 <http://git.koha-community.org/[…]9bda813cd9dee84ab> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22521: (RM follow-up) Adjust tests to use new accounttype <http://git.koha-community.org/[…]99bbbebeb1eb5ec9a> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22318: DBRev 18.12.00.058 <http://git.koha-community.org/[…]7e82b50b82a7d8db6> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22175: (follow-up) Identify columns to exclude from export <http://git.koha-community.org/[…]ceec32f2e24486a5a> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 6730: Rename 'basket' filter to 'basket name' on receive page <http://git.koha-community.org/[…]17fce6718bfa9727f> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22318: (QA follow-up) Correct name of atomicupdate <http://git.koha-community.org/[…]80027dae0c369d847> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22645: Add 'ISSN' sarch option to OPAC simple search pull down <http://git.koha-community.org/[…]99329128700e2d42b> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 13795: Remove occurences of unused columns in code <http://git.koha-community.org/[…]7b337dce944626511> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 13795: Make database update idempotent <http://git.koha-community.org/[…]83f24009811104240> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22318: (follow-up) Add new options to new table filter form <http://git.koha-community.org/[…]0f2e4ce747bdced2b> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22532: Database update <http://git.koha-community.org/[…]cfa4d95b14e7b9b68> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22532: Remove Z39.50 random <http://git.koha-community.org/[…]4cebff9bbec2fa117> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22318: Example implementation: OpacNavRight system preference <http://git.koha-community.org/[…]e6f2f3551b3a82cb0> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22318: Extend Koha news feature to include other content areas <http://git.koha-community.org/[…]6b44fbf0ca65f7b35> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 22175: Make stock rotation table sortable <http://git.koha-community.org/[…]fae249d87ca5c8b9c> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha <http://git.koha-community.org/[…]b1d27a17a775f07d1> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German <http://git.koha-community.org/[…]dc6cb07727ac5a63a> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 21545: Translate 'Stock rotation slip' <http://git.koha-community.org/[…]9b45ebcddf9a7e4c7> |
| 12:05 |
|
huginn` |
News from kohagit: Bug 15253: Add Koha::Logger based logging for SIP2 <http://git.koha-community.org/[…]e3b04f97cb36d8dc4> |
| 12:22 |
|
oleonard |
kidclamp: I put Bug 20689 back to PQA but of course you can tell me that's wrong. |
| 12:22 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20689 enhancement, P5 - low, ---, katrin.fischer, Passed QA , Make it possible to add capital letter subfields to item search fields |
| 12:26 |
|
kidclamp |
Could you recreate my issue with 520$A? |
| 12:26 |
|
oleonard |
Yes, and I submitted a follow-up |
| 12:27 |
|
kidclamp |
Ah, cool, I saw the form fix but missed that |
| 12:27 |
|
oleonard |
No sorry I think I wasn't thorough |
| 12:27 |
|
oleonard |
Let me check again. |
| 12:30 |
|
koha-jenkins |
Project Koha_Master_D9 build #710: STILL UNSTABLE in 26 min: https://jenkins.koha-community[…]ha_Master_D9/710/ |
| 12:32 |
|
oleonard |
No kidclamp I'm not able to recreate the issue with 520$A. I modified a framework to include it, added a value to a record, did an item search for that value, and the correct result was returned. |
| 12:32 |
|
kidclamp |
I will try again |
| 12:39 |
|
koha-jenkins |
Project Koha_Master_U18 build #204: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]a_Master_U18/204/ |
| 12:46 |
|
|
Henry joined #koha |
| 12:46 |
|
koha-jenkins |
Project Koha_Master_D8 build #216: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_Master_D8/216/ |
| 13:33 |
|
|
calire left #koha |
| 14:02 |
|
|
edveal joined #koha |
| 14:03 |
|
oleonard |
Hi edveal |
| 14:04 |
|
|
wizzyrea joined #koha |
| 14:04 |
|
wizzyrea |
hi |
| 14:04 |
|
oleonard |
Hi wizzyrea |
| 14:05 |
|
wizzyrea |
how we doin today |
| 14:05 |
|
|
caroline_catlady joined #koha |
| 14:06 |
|
oleonard |
Expanding the scope of my bug fixes as usual |
| 14:06 |
|
caroline_catlady |
hi! |
| 14:06 |
|
wizzyrea |
hehe |
| 14:18 |
|
cait |
is tomorrow a public holiday everywhere? |
| 14:18 |
|
cait |
and monday? |
| 14:18 |
|
wizzyrea |
not in the US |
| 14:18 |
|
cait |
:( |
| 14:20 |
|
caroline_catlady |
here only one is mandatory (friday OR monday), but most governmental orgs have both |
| 14:21 |
|
caroline_catlady |
we only get monday... |
| 14:22 |
|
oleonard |
I don't get the day off Friday but my kids do, so I have to take a vacation day |
| 14:24 |
|
wizzyrea |
best country |
| 14:29 |
|
* wizzyrea |
just typed "kohadevo" instead of "kohadev" and suddenly had the urge to hear https://www.youtube.com/watch?v=j_QLzthSkfM |
| 14:30 |
|
wizzyrea |
bonus kohadevo: https://www.youtube.com/watch?v=4MT16GpuZks |
| 14:30 |
|
oleonard |
Also, that "up next" queue is top shelf |
| 14:30 |
|
wizzyrea |
hehe |
| 14:31 |
|
wizzyrea |
fun fact, Mark Mothersbaugh did the soundtrack for the likes of "the lego movie" and "thor: ragnarok" |
| 14:33 |
|
oleonard |
Also several Wes Anderson soundtracks, which are always excellent |
| 14:33 |
|
wizzyrea |
oh yes |
| 14:45 |
|
oleonard |
I guess it's time to start making follow-ups to Bug 22318! |
| 14:45 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22318 enhancement, P5 - low, ---, oleonard, Pushed to Master , Extend Koha news feature to include other content areas |
| 14:52 |
|
wizzyrea |
yaaaaaay |
| 14:58 |
|
ashimema_ |
++ |
| 15:03 |
|
oleonard |
I'd love to hear suggestions about how to answer this question: https://bugs.koha-community.or[…]g.cgi?id=22318#c5 |
| 15:03 |
|
huginn` |
Bug 22318: enhancement, P5 - low, ---, oleonard, Pushed to Master , Extend Koha news feature to include other content areas |
| 15:07 |
|
cait |
can you give an example? |
| 15:08 |
|
oleonard |
Yes. For instance: OpacHeader: The template checks for the existence of the preference and includes some markup around the preference which otherwise wouldn't appear. |
| 15:08 |
|
cait |
aah |
| 15:08 |
|
cait |
would something like size() work? |
| 15:10 |
|
oleonard |
I'm not sure how that would work with the template plugin |
| 15:12 |
|
* cait |
misses Joubu |
| 15:12 |
|
cait |
kidclamp++ # rejoining QA team |
| 15:16 |
|
|
fridolin left #koha |
| 15:16 |
|
|
tuxayo joined #koha |
| 15:21 |
|
ashimema_ |
wow |
| 15:21 |
|
cait |
hm? |
| 15:21 |
|
ashimema_ |
I'm suddenly getting loads of `Log file /var/log/koha/kohadev/intranet-error.log is not writable! at /kohadevbox/koha/Koha/Logger.pm line 163.` errors when running tests in koha-testing-docker |
| 15:21 |
|
ashimema_ |
is that a new thing.. or is it just me |
| 15:21 |
|
wizzyrea |
how's your disk space |
| 15:22 |
|
|
valterbarreira[m] joined #koha |
| 15:23 |
|
ashimema_ |
erm.. should have plenty |
| 15:23 |
|
ashimema_ |
perhaps not.. I'll dig a little further |
| 15:27 |
|
wizzyrea |
usually, in my experience, when things suddenly go non-writable it's because there's no space so that's always what I think of first |
| 15:27 |
|
ashimema_ |
very true |
| 15:27 |
|
ashimema_ |
doesn't appear to be the case here |
| 15:27 |
|
ashimema_ |
odd |
| 15:27 |
|
wizzyrea |
bum |
| 15:27 |
|
ashimema_ |
oh well |
| 15:36 |
|
wizzyrea |
heyy ashimema_ |
| 15:36 |
|
ashimema_ |
hi |
| 15:36 |
|
wizzyrea |
if you are about |
| 15:36 |
|
wizzyrea |
what is the best way to get rid of |
| 15:36 |
|
wizzyrea |
git manipulation |
| 15:36 |
|
wizzyrea |
The file has been added and deleted in the same patchset |
| 15:37 |
|
wizzyrea |
if you know |
| 15:37 |
|
wizzyrea |
have had two of these in the last couple of days |
| 15:38 |
|
wizzyrea |
mostly it seems legit, person does a dev, then they are asked to do it differently so they do, in a series of commits |
| 15:39 |
|
ashimema_ |
well.. I tend to ignore them during QA and leave it upto the RM to clean up |
| 15:40 |
|
ashimema_ |
personally I sometimes find it helpful to see the logic |
| 15:40 |
|
ashimema_ |
but if we did want to clean them up then really the only way is to rebase and squash the addition and removal commits together |
| 15:40 |
|
wizzyrea |
right that's what I was afraid of |
| 15:40 |
|
ashimema_ |
and then attach the new set of patches to bz |
| 15:40 |
|
wizzyrea |
well |
| 15:40 |
|
wizzyrea |
I'm not *really* afraid |
| 15:40 |
|
wizzyrea |
but rebasing is rather annoying. :P |
| 15:41 |
|
wizzyrea |
esp when it's not your work |
| 15:41 |
|
ashimema_ |
I'm not entirely sure why we're especially worried about those to be honest |
| 15:41 |
|
ashimema_ |
yes.. it's minor noise in the commit log |
| 15:41 |
|
ashimema_ |
but is that really that bad I ask? |
| 15:41 |
|
ashimema_ |
yeah.. totally |
| 15:41 |
|
wizzyrea |
me personally, I like patch sets when work is in progress |
| 15:41 |
|
wizzyrea |
but I'd like a squash at the end |
| 15:42 |
|
ashimema_ |
I never rebase someone elses work for that warning and unless it's a really horrible case I pretty much never ask them to clean it up as part of the QA process.. |
| 15:42 |
|
ashimema_ |
kidclamp: do you have an opinion no that? |
| 15:42 |
|
wizzyrea |
as long as authorship can be maintained |
| 15:42 |
|
ashimema_ |
I do the same.. I like to squash at the end |
| 15:42 |
|
wizzyrea |
right I won't worry too much about it |
| 15:42 |
|
wizzyrea |
i don't like to rebase others work either |
| 15:42 |
|
ashimema_ |
though of course.. that doesn't help one's personal git statistics ;) |
| 15:43 |
|
wizzyrea |
I do like to make a zillion tiny commits myself, and squash them at the end |
| 15:43 |
|
wizzyrea |
easy rollbacks! |
| 15:43 |
|
wizzyrea |
:D |
| 15:43 |
|
ashimema_ |
precisely |
| 15:43 |
|
ashimema_ |
http://git.koha-community.org/[…]ster/authors.html |
| 15:43 |
|
oleonard |
wizzyrea: If you're squashing at the end can't you just ignore the warning? |
| 15:43 |
|
ashimema_ |
in fact.. even when squasing at the end I like them to be in nice clear distinct parts rather than squashing to one bigger less comprehensible commit |
| 15:43 |
|
wizzyrea |
if it were my work, I would |
| 15:44 |
|
wizzyrea |
but in this case it's not |
| 15:44 |
|
wizzyrea |
that makes sense, comprehensible bits are nice |
| 15:44 |
|
ashimema_ |
yeah.. I'd firmly stick it in the camp of it's become a qa script noise item rather than a really helpful warning |
| 15:44 |
|
wizzyrea |
especially if one part is whitespace cleanup |
| 15:45 |
|
ashimema_ |
sometimes it's nice to see it just as a 'Hey, you might want to double check this' moment.. but I certainly wouldn't worry enough to fail it. |
| 15:45 |
|
wizzyrea |
i imagine I could make it come out ok in this case but mm |
| 15:45 |
|
ashimema_ |
these were often introduced recently when people were asked to do followups to change the .sql file to .perl for atomicupdates |
| 15:45 |
|
wizzyrea |
yes that is exactly what is happening here |
| 15:45 |
|
ashimema_ |
yeah.. skim over it in that case :) |
| 15:46 |
|
ashimema_ |
if a QAer fancies arguing the difference over it send 'em my way.. haha |
| 15:46 |
|
wizzyrea |
kek |
| 15:46 |
|
wizzyrea |
naw I'm not gonna worry too much about it I didn't see the point really and I do like to tidy things off for people when I can |
| 15:46 |
|
wizzyrea |
it sucks to be a dev and have someone just say "nah, stupid tiny detail you missed make a whole new set" |
| 15:46 |
|
wizzyrea |
that's annoying |
| 15:46 |
|
wizzyrea |
easing that is nice. |
| 15:47 |
|
wizzyrea |
(when you can do it without messing up their stuff or making decisions they'd be upset about) |
| 15:47 |
|
ashimema_ |
totally.. I really respect you for that.. I'm of a very similar nature.. I will always try to do the trivial bits myself and perhaps comment for next time |
| 15:47 |
|
wizzyrea |
I like enabling people to be awesome ;) |
| 15:49 |
|
|
alex_a_ joined #koha |
| 15:58 |
|
kidclamp |
Yeah, I like a squash if there is that warning, but I don't like to do the squash, I like the patch author to clean things up |
| 16:01 |
|
ashimema_ |
okies.. maybe I'm a bit lenient there then |
| 16:02 |
|
wizzyrea |
what is the actual harm, besides git log untidyiness |
| 16:02 |
|
|
edveal joined #koha |
| 16:02 |
|
wizzyrea |
mostly just curious |
| 16:03 |
|
ashimema_ |
just untidyiness I think.. it can complicate reverts if you need to do any.. but generally it's just untidyiness I think |
| 16:03 |
|
wizzyrea |
hehe my untidiness was a typo |
| 16:03 |
|
wizzyrea |
what a funny word |
| 16:04 |
|
ashimema_ |
lol |
| 16:04 |
|
wizzyrea |
i now have semantic satiation on untidiness. |
| 16:05 |
|
* ashimema_ |
is currently trying to come up with a sane test plan for bug 22563 and falling flat |
| 16:05 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22563 enhancement, P4, ---, martin.renvoize, Needs Signoff , Convert lost handling to use 'status' instead of multiple accounttypes |
| 16:07 |
|
wizzyrea |
hm |
| 16:07 |
|
wizzyrea |
gonna have to get a library to test that I reckon |
| 16:07 |
|
wizzyrea |
with their data |
| 16:07 |
|
wizzyrea |
in the real-ish world |
| 16:11 |
|
ashimema_ |
that's about the most waffly test plan I've written |
| 16:11 |
|
ashimema_ |
I'm pretty darn confident in that code now (I wasn't at all confident in it before this excersize) |
| 16:11 |
|
ashimema_ |
but yeah.. there's allot of prefs at play |
| 16:13 |
|
ashimema_ |
the end result should be a significantly clearer use of the accountypes with status's to clarify their purposes.. we we're re-using accounttypes all over the place |
| 16:16 |
|
ashimema_ |
anyone know if Joubu will be back during the next cycle |
| 16:17 |
|
* ashimema_ |
doesn't want him to miss out on being in the QA team ;) |
| 16:24 |
|
* oleonard |
doesn't want us to miss out on him being in the QA team |
| 16:26 |
|
cait |
don't give me nightmares |
| 16:27 |
|
* ashimema_ |
is pleased to see we have kidclamp the PITA tester signed up ;) |
| 16:27 |
|
ashimema_ |
in his own words |
| 16:29 |
|
kidclamp |
I do love pita, with hummus, yum |
| 16:29 |
|
kidclamp |
:-D |
| 16:29 |
|
ashimema_ |
hehe |
| 16:29 |
|
* ashimema_ |
thinks it must be nearly beer o'clock |
| 16:34 |
|
reiveune |
bye |
| 16:34 |
|
|
reiveune left #koha |
| 16:39 |
|
|
ashimema joined #koha |
| 16:39 |
|
ashimema |
wahoo |
| 16:39 |
|
ashimema |
ashimema is back.. not more ashimema_ ! |
| 16:40 |
|
|
ashimema_ left #koha |
| 16:47 |
|
* ashimema |
quietly weeps as he looks at his RMaint queue.. how did it creep back up to over 100 commits :'( |
| 16:48 |
|
ashimema |
string freeze on monday too |
| 16:48 |
|
* ashimema |
roles up his sleeves.. |
| 16:51 |
|
cait |
kidclamp: am gald to have you on board too :) |
| 16:52 |
|
cait |
kidclamp: you are stepping in for ashimema, right? |
| 16:52 |
|
tcohen |
hi |
| 16:52 |
|
kidclamp |
not filling his shoes. but sure |
| 16:52 |
|
kidclamp |
ashimema has big shoes |
| 16:54 |
|
ashimema |
lol |
| 16:55 |
|
* ashimema |
did go a bit QA mad this last cycle |
| 16:57 |
|
cait |
kidclamp: you can strive to fill them... |
| 16:57 |
|
cait |
:) |
| 16:58 |
|
cait |
khall: what kind of cookies do you like? I am missing your signature... :) |
| 16:59 |
|
* khall |
likes all the cookies :) |
| 16:59 |
|
cait |
heh |
| 16:59 |
|
cait |
i missed you here, just realized you had come back :) |
| 16:59 |
|
cait |
khall++ |
| 17:00 |
|
cait |
and bywater++ just reading the report from VT |
| 17:07 |
|
|
cait left #koha |
| 17:08 |
|
|
lukeG joined #koha |
| 17:53 |
|
* oleonard-away |
just found himself getting excited about DataTables buttons... might be in a little too deep |
| 17:58 |
|
huginn` |
News from kohagit: Revert "Bug 15253: Add Koha::Logger based logging for SIP2" <http://git.koha-community.org/[…]220df2306e166963f> |
| 17:58 |
|
huginn` |
News from kohagit: Revert "Bug 15253: (follow-up) Fix qa complaints" <http://git.koha-community.org/[…]a6dfbbd3ba79a3589> |
| 17:59 |
|
kidclamp |
that should fix the log errors ashimema |
| 18:00 |
|
ashimema |
Oh, cool |
| 18:00 |
|
ashimema |
I thought it was me |
| 18:02 |
|
ashimema |
Interesting, so does that mean logging has never worked in tests |
| 18:03 |
|
ashimema |
Sorta looks like the warning was introduced the catch this sort of case |
| 18:03 |
|
ashimema |
Perhaps the longer term fix is to configure logs on koha-testing-docker? |
| 18:03 |
|
* ashimema |
hopes he didn't just misread that bug |
| 18:20 |
|
kidclamp |
I had that warning because the log in my docker was owned by root |
| 18:20 |
|
kidclamp |
But didn't have it before those patches |
| 18:25 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:25 |
|
koha-jenkins |
Project Koha_Master_D9 build #711: FIXED in 25 min: https://jenkins.koha-community[…]ha_Master_D9/711/ |
| 18:34 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:34 |
|
koha-jenkins |
Project Koha_Master_U18 build #205: FIXED in 34 min: https://jenkins.koha-community[…]a_Master_U18/205/ |
| 18:35 |
|
ashimema |
it's just this line isn't it: http://git.koha-community.org/[…]a6dfbbd3ba79a3589 |
| 18:35 |
|
* ashimema |
clocks off.. |
| 18:35 |
|
ashimema |
too late for brain |
| 18:36 |
|
ashimema |
have a good weekend all |
| 18:40 |
|
oleonard |
Bye ashimema |
| 18:41 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:41 |
|
koha-jenkins |
Project Koha_Master_D8 build #217: FIXED in 37 min: https://jenkins.koha-community[…]ha_Master_D8/217/ |
| 18:51 |
|
|
sameee joined #koha |
| 18:53 |
|
wizzyrea |
hmm |
| 18:53 |
|
wizzyrea |
that's very sad about the sip logs |
| 18:54 |
|
wizzyrea |
I think we need to fix it instead of reverting. :( |
| 18:57 |
|
oleonard |
Have a good weekend, #koha |
| 18:59 |
|
ashimema |
We'll fix it |
| 18:59 |
|
wizzyrea |
those logs are SO ANNOYING as they are. |
| 19:00 |
|
wizzyrea |
it's just the SIP tests that are failing or others |
| 19:10 |
|
ashimema |
Everything |
| 19:10 |
|
wahanui |
i guess Everything is fine and direct access to our 30000 books MySQL database is super fast. |
| 19:11 |
|
ashimema |
It introduced a slightly different way of warning if the log file is writable |
| 19:11 |
|
ashimema |
Turns out they're not in the testing environment |
| 19:11 |
|
ashimema |
So all the tests go noisy if they touch anything that uses Koha::Logger |
| 19:12 |
|
ashimema |
I think just that patch may be reworkable |
| 19:12 |
|
ashimema |
We'll work on it next week.. |
| 19:12 |
|
wizzyrea |
i hope so I'd really hate to see the SIP logs go another release without that fix >.< |
| 19:15 |
|
|
killer_bee[m] joined #koha |
| 19:15 |
|
|
davidnind[m] joined #koha |
| 19:15 |
|
|
SlackIntegration[m] joined #koha |
| 19:35 |
|
davidnind |
is confused, doesn't know who davidnind[m] is |
| 19:36 |
|
caroline_catlady |
your evil twin? |
| 19:37 |
|
davidnind |
one of me is probably tolerable, but anymore than that would be weird :) |
| 19:37 |
|
caroline_catlady |
maybe [m] is for mobile? |
| 19:38 |
|
davidnind |
caroline_catlady: possibly my evil twin or maybe the good twin |
| 19:43 |
|
davidnind |
that's what I thought, but my phone is right beside me and I didn't touch it - I do have an IRC client on my phone, but haven't used it or ste it up |
| 19:46 |
|
caroline_catlady |
... just noticed a bunch of [m] appeared at the same time... |
| 19:46 |
|
ashimema |
So I have an M |
| 19:47 |
|
ashimema |
Could be matrix |
| 19:48 |
|
davidnind |
I do have a slack user thingy somewhere, but don't really use it (and not logged in) |
| 19:56 |
|
davidnind |
oh well, one of those mysteries I guess (goes away to make a cup of tea, and contemplate the matrix) |
| 20:06 |
|
|
indradg_ joined #koha |
| 20:30 |
|
|
andreashm joined #koha |
| 20:43 |
|
|
cait joined #koha |
| 21:27 |
|
|
georgew joined #koha |
| 21:39 |
|
caroline_catlady |
good night! |
| 22:47 |
|
|
dpk_ joined #koha |
