| Time |
S |
Nick |
Message |
| 00:00 |
|
caroline1 |
good night all! |
| 00:34 |
|
aleisha_ |
hello! does anyone know if bug 15110 is still valid? there is no decreaseHighHolds syspref but there are a few that look similar and we're wondering if the issue still exists. |
| 00:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15110 enhancement, P5 - low, ---, jke0429, NEW , decreaseHighHolds unclear |
| 00:36 |
|
oleonard |
Looks like it's decreaseLoanHighHolds aleisha_ |
| 00:37 |
|
aleisha_ |
thanks oleonard, we know what to do now ;) |
| 00:37 |
|
aleisha_ |
:) |
| 00:39 |
|
|
helene joined #koha |
| 00:39 |
|
oleonard |
Hi helene |
| 00:40 |
|
oleonard |
helene, I hope my comment on Bug 19818 makes sense |
| 00:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19818 enhancement, P5 - low, ---, hickeyhe, Patch doesn't apply , Add id into tag html from moremember.tt |
| 01:52 |
|
|
indradg joined #koha |
| 01:53 |
|
indradg |
hi is the mothership (k-c.org) down? Been getting HTTP 500 all day |
| 02:04 |
|
rangi |
hmm seems ok at the moment? |
| 02:07 |
|
rangi |
hmm no its doing some weird stuff, might need to contact wizzyrea (liz) as she looks after the site |
| 02:07 |
|
indradg |
rangi: thanks :-) the sub pages are doing it (e.g. https://koha-community.org/en/[…]-05-07-released/) |
| 02:08 |
|
rangi |
yep |
| 02:12 |
|
rangi |
can you try now? |
| 02:17 |
|
rangi |
i think the server has crashed |
| 02:26 |
|
huginn |
News from kohagit: Bug 7143: Update about page for new devs (Academy)wq <http://git.koha-community.org/[…]b95c4b85bc3422b22> |
| 02:26 |
|
huginn |
News from kohagit: Bug 22095: Replaced dead links with working links <http://git.koha-community.org/[…]c7d5ef7c953db283c> |
| 02:26 |
|
huginn |
News from kohagit: Bug 20865: Removed space before : on order receive filters <http://git.koha-community.org/[…]226f746fd597362b0> |
| 02:26 |
|
huginn |
News from kohagit: Bug 21866: Changed "report" to "plugins" for the warning "This report was written... <http://git.koha-community.org/[…]e331388e56658db84> |
| 02:26 |
|
huginn |
News from kohagit: Bug 22054: Updated the error message for attempting to renew an onsite checkout <http://git.koha-community.org/[…]78584073354cb43e5> |
| 02:26 |
|
huginn |
News from kohagit: Bug 22036: Indented code where '^I' was written rather than an indent. <http://git.koha-community.org/[…]e29e37f5db29d0c7b> |
| 02:26 |
|
huginn |
News from kohagit: Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search... <http://git.koha-community.org/[…]5dc724e45964707e1> |
| 02:26 |
|
huginn |
News from kohagit: Bug 21637: Fixed upercase letter in EasyAnalyticalRecords syspref <http://git.koha-community.org/[…]f3aa09bfb10cd9f23> |
| 02:26 |
|
huginn |
News from kohagit: Bug 22011: Fixed Typo on batchMod-edit.tt <http://git.koha-community.org/[…]2745c6168979359ca> |
| 02:28 |
|
|
jasmine joined #koha |
| 02:30 |
|
kidclamp |
Academy++ |
| 02:31 |
|
kidclamp |
have a good night all |
| 02:39 |
|
aleisha_ |
hi gmcharlt_ are you around? we have a question about bug 11996 |
| 02:39 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11996 minor, P5 - low, ---, koha-bugs, NEW , default active currencies for ru-RU and uk-UA are probably wrong |
| 02:40 |
|
aleisha_ |
we're just not sure what to do for the Ukraine currency because the currency isn't already in there like for the Russia currencies, and we aren't sure of the data ourselve |
| 02:40 |
|
aleisha_ |
s |
| 02:43 |
|
koha-jenkins |
Project Koha_Master_U18 build #127: FAILURE in 13 min: https://jenkins.koha-community[…]a_Master_U18/127/ |
| 03:00 |
|
koha-jenkins |
Project Koha_Master_D9 build #640: SUCCESS in 31 min: https://jenkins.koha-community[…]ha_Master_D9/640/ |
| 03:02 |
|
koha-jenkins |
Project Koha_Master_D8 build #150: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_Master_D8/150/ |
| 03:03 |
|
rangi |
aleisha_: did you see http://git.koha-community.org/[…]b95c4b85bc3422b22 |
| 03:14 |
|
aleisha_ |
yay! |
| 03:14 |
|
aleisha_ |
oh no helene's name is spelled wrong! |
| 03:15 |
|
rangi |
ahh easy patch for someone there then :) |
| 03:16 |
|
aleisha_ |
true :-) |
| 03:47 |
|
kidclamp |
Ah, sorry |
| 05:42 |
|
|
cait joined #koha |
| 06:05 |
|
|
davidnind joined #koha |
| 06:16 |
|
|
chris joined #koha |
| 06:45 |
|
|
alexbuckley joined #koha |
| 07:02 |
|
magnuse |
@later tell rangi finally got to see "hunt for the wilderpeople" last week - really enjoyed it! |
| 07:02 |
|
huginn |
magnuse: The operation succeeded. |
| 07:02 |
|
magnuse |
\o/ |
| 07:11 |
|
magnuse |
sooo, patches from academy students: should we rush to sign them off, or should we leave them for other academy students to tackle? |
| 07:12 |
|
davidnind |
there is a lot! |
| 07:26 |
|
|
cait joined #koha |
| 07:30 |
|
|
paul_p joined #koha |
| 07:34 |
|
|
laurence joined #koha |
| 07:44 |
|
|
reiveune joined #koha |
| 07:44 |
|
reiveune |
hello |
| 07:44 |
|
wahanui |
what's up, reiveune |
| 08:01 |
|
|
fridolin joined #koha |
| 08:02 |
|
|
chris joined #koha |
| 08:02 |
|
fridolin |
hi there |
| 08:03 |
|
|
alex_a joined #koha |
| 08:03 |
|
|
calire joined #koha |
| 08:10 |
|
|
laurence joined #koha |
| 08:41 |
|
ashimema |
mornin' |
| 08:42 |
|
ashimema |
I bet lots of the academy bugs are string changes aren't they |
| 08:42 |
|
* ashimema |
was hoping to perhaps push a few today |
| 09:50 |
|
|
josef_moravec joined #koha |
| 10:22 |
|
|
kohaputti joined #koha |
| 10:24 |
|
cait |
some are, but not all |
| 10:27 |
|
|
chris joined #koha |
| 10:35 |
|
tcohen |
hi |
| 10:44 |
|
|
kohaputti joined #koha |
| 11:02 |
|
eythian |
hi |
| 11:02 |
|
wahanui |
niihau, eythian |
| 12:21 |
|
* kidclamp |
waves |
| 12:26 |
|
|
davidnind left #koha |
| 12:34 |
|
|
oleonard_ joined #koha |
| 12:35 |
|
oleonard_ |
Hi all |
| 12:35 |
|
oleonard_ |
Oh no there's another one. |
| 12:36 |
|
calire |
imposter! |
| 12:36 |
|
oleonard_ |
It's me from the past. It's a ghost. |
| 12:37 |
|
* calire |
hides |
| 12:54 |
|
|
alex_a joined #koha |
| 12:55 |
|
|
josef_moravec joined #koha |
| 13:54 |
|
|
lukeg1 joined #koha |
| 14:03 |
|
|
caroline joined #koha |
| 14:03 |
|
caroline |
bonjour! |
| 14:04 |
|
* oleonard_ |
waves |
| 14:08 |
|
|
koha-jenkins joined #koha |
| 14:17 |
|
|
koha-jenkins joined #koha |
| 14:39 |
|
|
calire left #koha |
| 14:40 |
|
caroline |
I'm looking for the index "l-format" in the zebra index files (biblio-zebra.indexdefs.xsl, biblio-koha-indexdefs.xml) but I can't find it anywhere. Where should I look? |
| 14:42 |
|
cait |
hm |
| 14:42 |
|
cait |
wher did you get the name? |
| 14:43 |
|
tcohen |
ccl.properties |
| 14:43 |
|
cait |
i'd look for mappings at ccl.properties |
| 14:43 |
|
cait |
yep |
| 14:43 |
|
cait |
it might have been shortcut |
| 14:43 |
|
caroline |
I search for Subtypes Braille |
| 14:43 |
|
cait |
hm |
| 14:43 |
|
caroline |
It says l-format:fk |
| 14:43 |
|
cait |
actually it hasn't l-format ff7-01-02 |
| 14:43 |
|
cait |
or |
| 14:43 |
|
cait |
yep |
| 14:44 |
|
cait |
ff1-01-02 |
| 14:44 |
|
cait |
that's it |
| 14:44 |
|
tcohen |
but if it isn't in biblio-koha-indexdefs.xml, then Zebra will not be creating it |
| 14:44 |
|
caroline |
I found the other ones look in 007/00-01, but braille is not fk, so I'm wondering why it's looking for fk |
| 14:45 |
|
cait |
hm it looks at 007 |
| 14:45 |
|
cait |
position 2? |
| 14:46 |
|
cait |
39 <index_control_field tag="007" offset="0" length="2"> |
| 14:46 |
|
cait |
40 <target_index>ff7-01-02:w</target_index> |
| 14:46 |
|
cait |
41 </index_control_field> |
| 14:46 |
|
caroline |
007/00-001 = fb is "Tactile material/Braille", which makes sense (but not fk |
| 14:47 |
|
caroline |
and 007/00-01 = tc is "Text/Braille" |
| 14:47 |
|
cait |
it says 0, 2 |
| 14:47 |
|
cait |
i am never sure if that's 2 or 1 |
| 14:47 |
|
cait |
let's say it's one, becuse 0 1 |
| 14:48 |
|
caroline |
ok, so it looks in 007/00 and 007/02? |
| 14:48 |
|
caroline |
argh... |
| 14:48 |
|
cait |
shoudl be 007 pos 1 = b.... i guess? |
| 14:49 |
|
cait |
hm or 007, pos 0 = f |
| 14:49 |
|
caroline |
I'm looking at the codes here http://www.marc21.ca/M21/COD/Z[…]/BIB/BCZ-007.html |
| 14:49 |
|
cait |
http://www.loc.gov/marc/bibliographic/bd007f.html |
| 14:49 |
|
cait |
i am here |
| 14:49 |
|
caroline |
there are no "k" that mean anything close to Braille" |
| 14:49 |
|
cait |
let me check our opac |
| 14:50 |
|
cait |
atually we always hide those because they don't work |
| 14:50 |
|
cait |
with the union catalog data |
| 14:50 |
|
caroline |
Could it be possible that it was changed from k to b since ? |
| 14:50 |
|
cait |
or it was just neve right |
| 14:51 |
|
cait |
hm |
| 14:51 |
|
cait |
it should be fb |
| 14:51 |
|
cait |
it indexes the first 2 |
| 14:51 |
|
cait |
that's it |
| 14:51 |
|
cait |
007pos 0+1 |
| 14:53 |
|
caroline |
ok, that makes more sense :) |
| 14:53 |
|
caroline |
I'll file a bug |
| 14:53 |
|
caroline |
thx cait! |
| 14:53 |
|
caroline |
does it say fk in your catalog too? |
| 14:53 |
|
cait |
indexes. *grump* |
| 14:53 |
|
cait |
yep - 18.11 |
| 14:54 |
|
cait |
i see nor format change notes on the loc page |
| 14:54 |
|
caroline |
ok, at least it's not just mine |
| 14:54 |
|
cait |
and no fk in the standard |
| 15:03 |
|
koha-jenkins |
Project Koha_Master_U18 build #128: SUCCESS in 32 min: https://jenkins.koha-community[…]a_Master_U18/128/ |
| 15:44 |
|
|
caroline joined #koha |
| 16:04 |
|
cait |
oleonard_: which photo did you like better? hands up or down? |
| 16:05 |
|
oleonard_ |
I vote up. An up vote, if you will. |
| 16:05 |
|
cait |
same |
| 16:05 |
|
cait |
trying to add it now |
| 16:06 |
|
cait |
right now still trying to find the start page |
| 16:10 |
|
cait |
ashimema: around? |
| 16:10 |
|
|
oleonard joined #koha |
| 16:11 |
|
oleonard_ |
Oh no I didn't notice my ghost had left and now he's back |
| 16:11 |
|
cait |
oh no |
| 16:12 |
|
* oleonard_ |
wonders if that means the cat woke up my computer at home |
| 16:27 |
|
|
talljoy joined #koha |
| 16:27 |
|
talljoy |
morning |
| 16:27 |
|
oleonard_ |
Hi talljoy |
| 16:28 |
|
talljoy |
i know how to clear a room. heh |
| 16:29 |
|
oleonard_ |
It's my ghost, he's gone! |
| 16:29 |
|
talljoy |
or just owen's twins |
| 16:29 |
|
cait |
as long as it#s not an evil twin that would be awesome |
| 16:30 |
|
oleonard |
talljoy: That'll teach me to get on IRC after hours. Ghosts. |
| 16:31 |
|
cait |
caroline: do you have a master db at hand maybe for a quick check? or oleonard? |
| 16:31 |
|
cait |
i just need to know the default sort for subscriptions |
| 16:31 |
|
cait |
because it look slike it's issn |
| 16:31 |
|
cait |
and i think it shoudl be title |
| 16:31 |
|
cait |
hm |
| 16:33 |
|
oleonard |
What do you mean by default sort cait? |
| 16:33 |
|
cait |
default sor tfor the subscription result list |
| 16:34 |
|
oleonard |
In my system it's very helpfully sorting by checkboxes |
| 16:34 |
|
cait |
oh nice heh |
| 16:34 |
|
cait |
so maybe it was issn before, because that's the first column on 17.11 |
| 16:34 |
|
cait |
i'll file a bug :) |
| 16:35 |
|
cait |
i think title would be nice |
| 16:36 |
|
cait |
bug 22156 |
| 16:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22156 minor, P5 - low, ---, koha-bugs, NEW , Subscription result list sorty by "checkbox" |
| 16:37 |
|
cait |
bug 22156 |
| 16:39 |
|
|
fridolin left #koha |
| 16:39 |
|
cait |
i fixed the title |
| 16:51 |
|
|
caroline joined #koha |
| 17:06 |
|
reiveune |
bye |
| 17:07 |
|
|
reiveune left #koha |
| 17:19 |
|
|
wizzyrea joined #koha |
| 17:19 |
|
* oleonard |
waves to wizzyrea |
| 17:26 |
|
wizzyrea |
hi :) |
| 17:26 |
|
wizzyrea |
fyi apropos the meeting |
| 17:26 |
|
wizzyrea |
the website is updated |
| 17:26 |
|
wizzyrea |
@later tell cait website should be happier now |
| 17:26 |
|
huginn |
wizzyrea: The operation succeeded. |
| 17:27 |
|
wizzyrea |
fixed a bunch of things akshully |
| 17:27 |
|
oleonard |
wizzyrea++ |
| 17:28 |
|
wizzyrea |
now I've forgotten why I got out my computer |
| 17:28 |
|
wizzyrea |
maybe it was to do that stuff lol |
| 17:28 |
|
cait |
hi, amhere :) |
| 17:28 |
|
cait |
hi wizzyrea |
| 17:28 |
|
wizzyrea |
hi |
| 17:29 |
|
wizzyrea |
oleonard, do we have a newer theme for the opac than what we've got in the screens on the home page? |
| 17:29 |
|
cait |
might be cache, but can you take a look at try it now? |
| 17:29 |
|
cait |
ah... itw orks, never mind |
| 17:29 |
|
cait |
yesterday it didn't work with demo only with demo/... seems good now |
| 17:30 |
|
oleonard |
wizzyrea: Yes we do |
| 17:30 |
|
wizzyrea |
like I said, I fixed several things |
| 17:30 |
|
wizzyrea |
;) |
| 17:30 |
|
cait |
:) |
| 17:30 |
|
cait |
wizzyrea++ |
| 17:30 |
|
wizzyrea |
could I impose upon you oleonard to make me a new little graphic like that? |
| 17:30 |
|
wizzyrea |
with the new opac? |
| 17:30 |
|
wizzyrea |
i'm rubbish at gimp and you probably have heaps better tools than I do |
| 17:30 |
|
cait |
oleonard: wizzyrea: we also wanted to add the version to the demo page - where shoudl the new column go? beginning or end? |
| 17:31 |
|
oleonard |
Sure. I was just looking at it and wondering who made it originally |
| 17:31 |
|
wizzyrea |
me :P |
| 17:31 |
|
wizzyrea |
it took me ages |
| 17:31 |
|
cait |
wizzyrea: he optimized the picture for the front page too ;) |
| 17:31 |
|
cait |
oleonard++ |
| 17:31 |
|
wizzyrea |
yaaay |
| 17:31 |
|
wizzyrea |
oleonard++ |
| 17:31 |
|
cait |
the new editor is a bit strange |
| 17:31 |
|
wizzyrea |
and I've just updated it again |
| 17:31 |
|
wizzyrea |
heh |
| 17:32 |
|
wizzyrea |
hm |
| 17:33 |
|
|
laurence left #koha |
| 17:33 |
|
wizzyrea |
sorry cait i'm thinking about your query |
| 17:33 |
|
wizzyrea |
i think we had it on there for a while |
| 17:34 |
|
wizzyrea |
and it proved to be a maintenance nightmare |
| 17:34 |
|
cait |
i am volunteering to try it out |
| 17:34 |
|
cait |
i was thinking maybe we could have a website mail thing - so we can help out |
| 17:34 |
|
cait |
the issue is we are advertising 18.11... but only very few offer that |
| 17:34 |
|
wizzyrea |
I feel like, and this will be an unpopular opinion i reckon |
| 17:34 |
|
wizzyrea |
that if you're not going to commit to running latest |
| 17:35 |
|
wizzyrea |
you don't get your demo on that page. |
| 17:35 |
|
cait |
yeah... i think maybe this is just a step to wake some up |
| 17:35 |
|
cait |
dunno |
| 17:35 |
|
cait |
it seemed bad for people wanting to see the newest |
| 17:36 |
|
wizzyrea |
that or we run up one we control as a community |
| 17:36 |
|
wizzyrea |
which might be better |
| 17:36 |
|
wizzyrea |
and take the vendors out of it. |
| 17:36 |
|
cait |
yeah that would be ideal i reckon |
| 17:36 |
|
wizzyrea |
maybe point to a sandbox instead |
| 17:36 |
|
cait |
also can ensure lots of langs installed |
| 17:36 |
|
wizzyrea |
yeah |
| 17:36 |
|
cait |
currently i think sandbox would not be ideal becuase of translations - the new system can't do them yet i thnk |
| 17:36 |
|
cait |
but it might be nice |
| 17:37 |
|
wizzyrea |
if we have to have the version on there, then I guess the 2nd column |
| 17:37 |
|
wizzyrea |
company, version, opac, intranet |
| 17:37 |
|
wizzyrea |
etc |
| 17:38 |
|
wizzyrea |
but as mentioned it was a bit of a nightmare. |
| 17:38 |
|
wizzyrea |
to maintain |
| 17:39 |
|
cait |
i put it after marcflavor heh |
| 17:39 |
|
cait |
i am almost done - we can chec it and move then |
| 17:39 |
|
wizzyrea |
you log in as kfischer yeah/ |
| 17:39 |
|
wizzyrea |
? |
| 17:39 |
|
cait |
yep |
| 17:39 |
|
wizzyrea |
k |
| 17:40 |
|
cait |
software coop seems down |
| 17:40 |
|
cait |
http://library.software.coop/c[…]ha/maintenance.pl |
| 17:40 |
|
wizzyrea |
i've given you some new permissions |
| 17:40 |
|
cait |
oooh shiny |
| 17:40 |
|
cait |
should i comment them out? |
| 17:40 |
|
wizzyrea |
gonna guess they've got some automation something that's broken, it happens occasionally |
| 17:40 |
|
cait |
can't get the version |
| 17:40 |
|
wizzyrea |
^ maintenance nightmare lol |
| 17:41 |
|
cait |
heh |
| 17:41 |
|
wizzyrea |
could remove it |
| 17:41 |
|
cait |
i will try it out - check on first every month or so |
| 17:42 |
|
cait |
how would i go about changing front page? |
| 17:42 |
|
wizzyrea |
see your dm's |
| 17:43 |
|
cait |
https://koha-community.org/demo/ |
| 17:43 |
|
wizzyrea |
cait++ |
| 17:44 |
|
caroline |
good job cait! cait++ |
| 17:44 |
|
cait |
I'll add a reminder to my calendar |
| 18:00 |
|
|
davidnind joined #koha |
| 18:06 |
|
|
cait left #koha |
| 18:07 |
|
wizzyrea |
right, running away for a little while email if anything looks stupid on the website (I don't anticipate it will but you never know after updates) |
| 18:12 |
|
davidnind |
wizzyrea++ |
| 18:22 |
|
|
oleonard joined #koha |
| 18:51 |
|
|
cait joined #koha |
| 18:55 |
|
rangi |
morning |
| 18:55 |
|
cait |
morning! |
| 18:55 |
|
caroline |
good morning! |
| 18:55 |
|
oleonard |
Hi rangi |
| 19:02 |
|
|
lukeg joined #koha |
| 19:25 |
|
|
jasmine joined #koha |
| 19:26 |
|
|
aleisha_ joined #koha |
| 19:33 |
|
|
paul_p joined #koha |
| 19:39 |
|
cait |
oleonard: did you figure out why the other check didn't work from the template? bug 22134) |
| 19:39 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22134 enhancement, P5 - low, ---, oleonard, Needs Signoff , Add account expiration information to patron details |
| 19:39 |
|
oleonard |
I didn't really get a chance to look into it today |
| 19:40 |
|
cait |
the patch doesn't look quite right |
| 19:40 |
|
cait |
it looks like you keep is_expired but remove is_going_to_expire |
| 19:40 |
|
cait |
https://bugs.koha-community.or[…]ment.cgi?id=84147 |
| 19:40 |
|
cait |
is it me? |
| 19:41 |
|
oleonard |
is_going_to_expire isn't actually used in the template |
| 19:41 |
|
oleonard |
unless I messed up |
| 19:44 |
|
oleonard |
Has anyone converted ISSUEQSLIP to template tookit? |
| 19:44 |
|
cait |
haven't dabbled with TT yet, sorry |
| 19:45 |
|
cait |
why not remove both template variables then? |
| 19:45 |
|
cait |
first patch added them |
| 19:45 |
|
cait |
i might have to take another look |
| 19:46 |
|
cait |
i think it appears as warndeparture |
| 19:46 |
|
oleonard |
The "flagged" variable is set so that display of the messages block can controlled |
| 19:59 |
|
oleonard |
cait: I might be completely wrong about is_going_to_expire. It's working differently than it did last night when I tested. |
| 19:59 |
|
* oleonard |
will come back to it |
| 20:00 |
|
|
caroline joined #koha |
| 20:01 |
|
|
helene joined #koha |
| 20:03 |
|
caroline |
cait re: bug 18723 |
| 20:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18723 critical, P5 - low, ---, josef.moravec, In Discussion , Dot not recognized as decimal separator on receive |
| 20:04 |
|
caroline |
in your comment, I don't understand if the patch is too complicated or if you reject the patch completely? |
| 20:04 |
|
cait |
no |
| 20:04 |
|
cait |
i was grumpy because it's 'in discussion' again |
| 20:05 |
|
caroline |
ah ok... yeah that made me grumpy too |
| 20:05 |
|
cait |
and it might be the wrong fix |
| 20:05 |
|
caroline |
but tuxayo signed in off, I don't understand |
| 20:05 |
|
cait |
making only this one form behave like the currencyformat selected would be wrong |
| 20:05 |
|
cait |
reading the full test plan now |
| 20:06 |
|
|
olivia joined #koha |
| 20:06 |
|
caroline |
I agree, but we needed to correct this for our clients, that is the only place I noticed that the price is multiplied |
| 20:06 |
|
cait |
yeah i tihnk it's ont what we want right now |
| 20:06 |
|
cait |
just bring back the dot |
| 20:06 |
|
cait |
figure out a general solution |
| 20:06 |
|
cait |
next |
| 20:06 |
|
caroline |
it's a band-aid patch, but at least it works and nobody will have a heart attack while we develop the bigger patch |
| 20:07 |
|
caroline |
(we = me not included :) ) |
| 20:08 |
|
|
jack joined #koha |
| 20:11 |
|
cait |
i am just grumpy because libraries complain to me about it |
| 20:11 |
|
cait |
and for a long time |
| 20:11 |
|
cait |
reported in 2017! |
| 20:12 |
|
caroline |
"it" being the general problem of . vs , or this form in particular? |
| 20:13 |
|
cait |
this form |
| 20:13 |
|
cait |
this form is the only one out of line that i know of |
| 20:13 |
|
cait |
it#s a little crazy |
| 20:13 |
|
cait |
we currently have turned currencyformat back to US |
| 20:13 |
|
cait |
because that 'fixes' it |
| 20:14 |
|
caroline |
do you usually use 0 000,00 or the one with th apostrophe? |
| 20:14 |
|
cait |
, and space |
| 20:14 |
|
cait |
german actually would be a thousands dot |
| 20:14 |
|
cait |
but both are understaood |
| 20:15 |
|
cait |
the apostrophe is swiss :) |
| 20:16 |
|
caroline |
So do you think we could use this patch for this form while we wait for the bigger, all-emcompassing patch? |
| 20:17 |
|
cait |
it reads like it keeps the wrong behavior but puts a textual wraning on it? |
| 20:17 |
|
cait |
or an alert |
| 20:17 |
|
|
alexbuckley joined #koha |
| 20:17 |
|
cait |
it's like those street signs that say 'beare the road is broken' |
| 20:17 |
|
caroline |
hehe! |
| 20:17 |
|
rangi |
bears always break roads |
| 20:18 |
|
cait |
bears? :) |
| 20:18 |
|
caroline |
I think it's the right behavior because it uses the decimal punctuation from CurrencyFormat |
| 20:18 |
|
caroline |
beers? |
| 20:18 |
|
cait |
i think it#s what we should do in the future everywhere |
| 20:18 |
|
cait |
but at once |
| 20:18 |
|
cait |
this only fixes one form |
| 20:18 |
|
cait |
so for master... not sure about the code, but the behaviour seems ok |
| 20:19 |
|
caroline |
It will be too big to correct all the forms in one patch, no? |
| 20:19 |
|
cait |
yep, that's why i htink do it lie we did with the new date format |
| 20:19 |
|
cait |
do one form after the other during a 6 month period - for a major release |
| 20:19 |
|
caroline |
ok |
| 20:19 |
|
cait |
i am a big fan of having the display format expect the expected input |
| 20:20 |
|
cait |
but some people wanted the forms to accept all and everything and I don't believe that's a good idea |
| 20:20 |
|
caroline |
so should I create a bug that is for only this form? |
| 20:20 |
|
cait |
the bug is for this form :) |
| 20:21 |
|
caroline |
ah ok! I though it was for another in acquisitions and I had just hijacked it :) |
| 20:21 |
|
cait |
on receive = but people keep derailing it |
| 20:21 |
|
cait |
oh lol |
| 20:21 |
|
cait |
trying to knit a thumb here... and I totally messed it up |
| 20:22 |
|
cait |
i knitted it closed... |
| 20:22 |
|
caroline |
oops! lol! |
| 20:22 |
|
cait |
closed it... whatever |
| 20:22 |
|
cait |
probably should concentrate on that for a little bit |
| 20:22 |
|
cait |
:) |
| 20:23 |
|
tuxayo |
cait caroline bug 18723 if you feel it can move forward then swich it to sign off 🙂 |
| 20:23 |
|
tuxayo |
I wasn't sure "in discussion" was appropriate. It was because of the feedback I had on the payments/fines bugzilla |
| 20:23 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18723 critical, P5 - low, ---, josef.moravec, In Discussion , Dot not recognized as decimal separator on receive |
| 20:24 |
|
caroline |
hi tuxayo! :) |
| 20:24 |
|
caroline |
I'm not sure of all the comments... @_@ |
| 20:26 |
|
caroline |
What I understand is : 1) fix one form at a time, but quickly, 2) decimal based on CurrencyFormat, 3) make display mirror the decimal that is expected in input |
| 20:26 |
|
tuxayo |
(I did't read much of the chat here and the new comments in bugzilla, I'm on mobile) |
| 20:26 |
|
caroline |
is that what you had too tuxayo? |
| 20:26 |
|
caroline |
in your new specs? |
| 20:26 |
|
cait |
that's what i would prefer |
| 20:27 |
|
cait |
with a 0) make this one form behave as it did before - always expecting a dot |
| 20:27 |
|
cait |
then start fixing it globally |
| 20:27 |
|
cait |
we always derail the fix with discussion about how to move forward make it all nice... but koha is not all nice now |
| 20:27 |
|
cait |
it works with dots. |
| 20:30 |
|
caroline |
couldn't this form be the first of the new generation? |
| 20:30 |
|
cait |
yep - but not for backporting |
| 20:30 |
|
caroline |
right |
| 20:30 |
|
cait |
that's my point |
| 20:30 |
|
cait |
libraries in 17.11 still have one form to remember to enter different than all others |
| 20:30 |
|
cait |
because we haven't fixed that in 1.5 year |
| 20:30 |
|
cait |
s |
| 20:31 |
|
|
oleonard joined #koha |
| 20:32 |
|
caroline |
So there would be one patch extra to backport the fix in the older version |
| 20:32 |
|
cait |
i'd really love that as a first step |
| 20:35 |
|
cait |
ah but beware... not sure about the warning |
| 20:35 |
|
cait |
but you can't just check for dot or comma |
| 20:35 |
|
cait |
because we use dot as thousand separators and US use , |
| 20:35 |
|
cait |
so both might appear. |
| 20:35 |
|
caroline |
It has to be the same as CurrencyFormat |
| 20:36 |
|
cait |
thousand opeartors should not be mandatory |
| 20:36 |
|
caroline |
do you have a CurrencyFormet for the german writing? |
| 20:36 |
|
caroline |
I don't have it in my koha, but I don't have German installed |
| 20:36 |
|
cait |
and it should accept full values |
| 20:36 |
|
cait |
12 |
| 20:36 |
|
cait |
instead of 12,00 |
| 20:36 |
|
cait |
you don't need |
| 20:36 |
|
cait |
i mean the translation is indepentent |
| 20:36 |
|
cait |
independent |
| 20:36 |
|
cait |
just switching the pref around is all you need |
| 20:37 |
|
caroline |
Yes, that I gathered. But I only have three options in my Koha, US, FR and CH. I was wondering if you had a German one |
| 20:37 |
|
cait |
ah no |
| 20:37 |
|
cait |
we use fr |
| 20:38 |
|
cait |
i guess we couls add it :) |
| 20:39 |
|
cait |
totally lost track of my rounds on the thumb, but it's still open |
| 21:00 |
|
cait |
caroline: maybe you were irght- make a separate bug |
| 21:00 |
|
cait |
for changing the behaviour (enh) and we keep this for bugfix? |
| 21:06 |
|
tuxayo |
<_oftc_caroli "is that what you had too tuxayo?"> caroline "what you had" The content of my last comment on bug 18723? |
| 21:06 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18723 critical, P5 - low, ---, josef.moravec, In Discussion , Dot not recognized as decimal separator on receive |
| 21:06 |
|
|
davidnind left #koha |
| 21:07 |
|
caroline |
tuxayo: I meant in your revised specs for the system-wide decimal fix |
| 21:07 |
|
caroline |
they're in another bug I think |
| 21:09 |
|
caroline |
bug 21507 |
| 21:09 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21507 major, P5 - low, ---, victor.grousset, ASSIGNED , Decimal separators issues in patrons payments/fines, simplified |
| 21:09 |
|
caroline |
I see that this is only for patron payment/fines |
| 21:09 |
|
caroline |
not acq |
| 21:10 |
|
* cait |
goes away to wash her owl mittens |
| 21:10 |
|
cait |
maybe that will make me less grumpy :) |
| 21:10 |
|
tuxayo |
<_oftc_caroli "What I understand is : 1) fix on"> Oh I missed that, sorry for the confusion |
| 21:10 |
|
caroline |
cait this bug ^ says not to handle thousand separator |
| 21:10 |
|
cait |
i am ok with thta |
| 21:10 |
|
caroline |
ok |
| 21:10 |
|
cait |
i think people usually don't type them |
| 21:11 |
|
tuxayo |
3: no, the direction is to not parse thousand separators |
| 21:11 |
|
caroline |
So it's basically the same as we said except for "display should mirror expected entry" |
| 21:11 |
|
tuxayo |
😃 |
| 21:12 |
|
caroline |
I asked José-Mario to review his patch for bug 18723 to allow only the dot |
| 21:12 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18723 critical, P5 - low, ---, josef.moravec, In Discussion , Dot not recognized as decimal separator on receive |
| 21:13 |
|
caroline |
(I told him to keep his current patch on the side) |
| 21:13 |
|
caroline |
I will talk to blou about José-Mario working on the forms one by one, but I'm not sure he will accept |
| 21:15 |
|
caroline |
He is grumpy because bug 17015 is not moving... |
| 21:15 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17015 enhancement, P5 - low, ---, charles.farmer, Needs Signoff , New Koha Calendar |
| 21:27 |
|
cait |
it's big |
| 21:28 |
|
caroline |
i know... -_- |
| 21:28 |
|
caroline |
I asked, and apparently, it's the smallest they were able to make it |
| 21:28 |
|
cait |
and it's a very central part |
| 21:29 |
|
cait |
both make it hard :( |
| 21:29 |
|
caroline |
What do you think they would need to change to make it easier to pass? |
| 21:30 |
|
caroline |
I thought about separating it, but like I said, I asked and they said no |
| 21:35 |
|
cait |
I haven't looked at it closely, so can't really tell |
| 21:36 |
|
caroline |
I would really like to find a way to make this pass... I've been racking by brain to find a solution that would make it easier |
| 21:44 |
|
cait |
is there an rfc? |
| 21:45 |
|
caroline |
I don't know, would that make it easier? |
| 21:45 |
|
caroline |
I don't think so |
| 21:45 |
|
caroline |
(I don't think so that there is an rfc) |
| 21:47 |
|
cait |
having an up to date description of how it works might help |
| 21:47 |
|
cait |
no guarantee tho |
| 21:47 |
|
caroline |
hehe! |
| 21:47 |
|
cait |
but with lots of bug comments an dsuch it's hard to get through |
| 21:47 |
|
caroline |
but it's an idea! |
| 21:47 |
|
caroline |
I will let them know |
| 21:47 |
|
cait |
having a reference document might give it a push |
| 21:47 |
|
cait |
might also start discussion, but it's movement |
| 21:48 |
|
caroline |
I could maybe even write about a couple of the functionalities, since it's the one we use in production with our clients |
| 21:55 |
|
cait |
good night all :) |
| 21:55 |
|
caroline |
good night! |
| 22:21 |
|
|
tallerjoy joined #koha |
| 22:35 |
|
|
papa joined #koha |
| 22:39 |
|
caroline |
My turn to take off, good night! |
| 22:41 |
|
|
oleonard joined #koha |
| 23:25 |
|
|
davidnind joined #koha |
| 23:29 |
|
|
oleonard joined #koha |
| 23:51 |
|
|
indradg joined #koha |
