Time |
S |
Nick |
Message |
00:30 |
|
mtompset |
@later tell Joubu almost made it through bug 21526. I'll have some comments, but most of it is good. Just minor consistency things, and a couple missing or wrong filters. |
00:30 |
|
huginn |
mtompset: The operation succeeded. |
00:39 |
|
alexbuckley |
hi mtompset :) |
00:40 |
|
mtompset |
Greetings, alexbuckley |
00:53 |
|
mtompset |
@later Joubu 108Kb eyeball'ing is a pain. I'm torn on many tiny patches or one massive mess like that. |
00:53 |
|
huginn |
mtompset: I'll give you the answer just as soon as RDA is ready |
00:53 |
|
wahanui |
i already had it that way, huginn. |
00:53 |
|
mtompset |
@later tell Joubu 108Kb eyeball'ing is a pain. I'm torn on many tiny patches or one massive mess like that. |
00:53 |
|
huginn |
mtompset: The operation succeeded. |
01:24 |
|
|
dcook joined #koha |
01:38 |
|
dcook |
Whoa, did Koha really have a recent style overhaul? |
01:38 |
|
* dcook |
seems to recall something about this |
02:05 |
|
dcook |
ere++ #bug 14716 |
02:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=14716 normal, P5 - low, ---, ere.maijala, Passed QA , Correctly URI-encode URLs in XSLT result lists and detail pages |
02:19 |
|
|
cait joined #koha |
03:01 |
|
mtompset |
dcook, see bug 21526 as an attempt to start cleaning it up. |
03:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21526 normal, P5 - low, ---, jonathan.druart, Pushed to Master , TT variables used to build a link should be uri filtered |
03:01 |
|
mtompset |
I commented on the last patch which came AFTER the push to master. |
03:01 |
|
mtompset |
At Joubu's request. |
03:02 |
|
mtompset |
-- hopefully that is on topic with your inquiry. :) |
03:11 |
|
dcook |
mtompset: It is on topic but I already saw that heh |
03:11 |
|
dcook |
But your comment on Bugzilla was helpful as it drew out the exact line I wanted to double-check |
03:11 |
|
dcook |
Actually... that was a different issue |
03:11 |
|
dcook |
But related |
03:12 |
|
dcook |
Giving ere karma for doing some XSLT fixes that I was willing to do but glad he did it ahead of me heh |
03:16 |
|
dcook |
Hope the earthquake in NZ wasn't too bad... |
03:35 |
|
alexbuckley |
thanks dcook, we were having a team meeting at the time of the earthquake and went under the table - we're always expecting a big quake - all good though |
03:35 |
|
dcook |
Whew glad all good |
03:35 |
|
dcook |
Must still be a bit scary :/ |
03:35 |
|
dcook |
I've been through a few earthquakes in Vancouver, but they were always so small that I never even felt them |
03:37 |
|
alexbuckley |
yeah it is a bit :) |
04:50 |
|
dcook |
TFW you use plenv to install a version of perl... but it's not the version you actually should've installed *facepalm* |
05:02 |
|
mtompset |
I suppose I should close windows and sleep. |
05:03 |
|
mtompset |
Have a good day (24 hour period), dcook alexbuckley |
05:46 |
|
|
cait joined #koha |
06:06 |
|
|
alexbuckley joined #koha |
06:33 |
|
|
josef_moravec joined #koha |
06:59 |
|
|
laurence joined #koha |
07:01 |
|
|
calire joined #koha |
07:35 |
|
|
reiveune joined #koha |
07:35 |
|
reiveune |
hello |
07:39 |
|
matts |
hi |
07:43 |
|
|
alex_a joined #koha |
07:43 |
|
alex_a |
bonjour |
07:44 |
|
josef_moravec |
morning #koha |
07:44 |
|
josef_moravec |
hi reiveune, matts, alex_a |
07:45 |
|
reiveune |
\o_ |
07:45 |
|
|
AndrewIsh joined #koha |
07:47 |
|
|
andreashm joined #koha |
07:48 |
|
* andreashm |
waves |
08:10 |
|
|
Archie^ joined #koha |
08:32 |
|
|
sophie_m joined #koha |
08:38 |
|
|
geffy_pen joined #koha |
08:59 |
|
ashimema |
morning #koha |
09:01 |
|
andreashm |
hi ashimema |
09:04 |
|
|
cait joined #koha |
09:59 |
|
|
alexbuckley joined #koha |
10:00 |
|
|
cait joined #koha |
10:03 |
|
|
m23_ joined #koha |
10:05 |
|
|
cait1 joined #koha |
10:32 |
|
|
Francesca joined #koha |
10:47 |
|
|
josef_moravec joined #koha |
10:48 |
|
josef_moravec |
ashimema: thanks for patch on bug 21002, but i can't apply it on master, it looks there is missing something... |
10:48 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21002 enhancement, P5 - low, ---, tomascohen, NEW , Add Koha::Account::add_debit |
10:54 |
|
|
cait joined #koha |
10:57 |
|
ashimema |
hmm |
10:57 |
|
ashimema |
ok.. will take a look in a minute |
10:58 |
|
josef_moravec |
thanks! |
10:58 |
|
josef_moravec |
I am really itnerested ;) |
11:05 |
|
* kidclamp |
waves |
11:05 |
|
ere |
hi kidclamp! |
11:05 |
|
kidclamp |
hi ere |
11:05 |
|
calire |
hi kidclamp |
11:06 |
|
kidclamp |
hi calire |
11:11 |
|
ashimema |
hi kidclamp |
11:12 |
|
kidclamp |
hi ashimema |
11:36 |
|
|
bella joined #koha |
11:37 |
|
bella |
hi |
11:40 |
|
|
oleonard joined #koha |
11:40 |
|
oleonard |
Hi #koha |
11:41 |
|
calire |
hi oleonard |
11:41 |
|
wahanui |
hi oleopard |
11:45 |
|
bella |
i have a problem, i neet to export same data from ABCD library software to koha, in this case iso to mrc, i try using markedit but does not work |
11:48 |
|
|
andreashm joined #koha |
11:50 |
|
oleonard |
bella: Why do you say it doesn't work? What about it doesn't work? |
11:57 |
|
|
jzairo joined #koha |
12:07 |
|
huginn |
News from kohagit: Bug 21596: (follow-up) Handle updated_on part 2 <http://git.koha-community.org/[…]472a3a5ef87329fc6> |
12:12 |
|
|
Dyrcona joined #koha |
12:16 |
|
|
corilynn joined #koha |
12:16 |
|
|
bella_o joined #koha |
12:16 |
|
|
papa1 joined #koha |
12:35 |
|
|
laurence joined #koha |
12:40 |
|
kidclamp |
@later tell Joubu bug 21725 |
12:40 |
|
huginn |
kidclamp: The operation succeeded. |
12:45 |
|
oleonard |
Hi kidclamp |
12:46 |
|
|
cait joined #koha |
12:46 |
|
kidclamp |
hi oleonard |
12:46 |
|
wahanui |
hi oleopard |
12:52 |
|
|
calire joined #koha |
12:53 |
|
|
marcelr joined #koha |
12:53 |
|
|
mtompset joined #koha |
12:53 |
|
marcelr |
hi #koha |
12:53 |
|
mtompset |
Greetings, #koha marcelr |
12:53 |
|
marcelr |
o/ |
12:53 |
|
kidclamp |
hi marcelr |
12:56 |
|
|
kmlussier joined #koha |
13:01 |
|
ashimema |
josef_moravec I've uploaded a fresh patch to bug 21002 |
13:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21002 enhancement, P5 - low, ---, tomascohen, NEW , Add Koha::Account::add_debit |
13:02 |
|
ashimema |
As I say in the comments.. it's a bit of a work in progress whilst I work through the related bugs and add in any additional requirements that may come about |
13:02 |
|
ashimema |
but hopefully it's enough to get going on.. |
13:02 |
|
ashimema |
I think it's a bit late for such a change before feature freeze.. but perhaps early next cycle we could get this stuff in and thoroughly tested |
13:04 |
|
josef_moravec |
ashimema: thanks, it applies cleanly now, I will try to use it for bug 21678 |
13:04 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21678 major, P5 - low, ---, josef.moravec, ASSIGNED , Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset |
13:04 |
|
josef_moravec |
And maybe we'll be able to get rid of whole C4::Account - it is nearly done! |
13:05 |
|
ashimema |
:) |
13:05 |
|
|
caroline joined #koha |
13:05 |
|
caroline |
hi #koha! |
13:07 |
|
cait |
josef_moravec++ thx for late night qa |
13:12 |
|
cait |
Joubu: around? |
13:12 |
|
|
m23_ joined #koha |
13:13 |
|
mtompset |
Greetings, kidclamp ashimema josef_moravec caroline cait |
13:13 |
|
|
bella_o joined #koha |
13:27 |
|
ashimema |
calire about? |
13:27 |
|
calire |
ashimema I am now |
13:36 |
|
|
cait joined #koha |
14:00 |
|
|
alex_a_ joined #koha |
14:03 |
|
|
alex_a__ joined #koha |
14:06 |
|
|
CrispyBran joined #koha |
14:25 |
|
|
bella joined #koha |
14:54 |
|
corilynn |
all, I don't want to tell dev to do unconventional things for bug 14957 |
14:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=14957 enhancement, P5 - low, ---, eivin, Failed QA , Write protecting MARC fields based on source of import |
15:03 |
|
|
m23 joined #koha |
15:05 |
|
corilynn |
any thoughts on what I should tell him about squishing / rewriting the tests? |
15:05 |
|
|
corilynn_ joined #koha |
15:09 |
|
kidclamp |
I am not sure what the question/issue is corilynn |
15:11 |
|
corilynn_ |
kidclamp, david wants to know if he should "squish" all the patches and overwrite the test text |
15:12 |
|
corilynn_ |
I would say "yes" to the latter and "no" to the former, but I'm unsure of the tribal thoughts on this |
15:12 |
|
corilynn_ |
and I don't want to tell him wrong |
15:12 |
|
corilynn_ |
so, my question is, what would ya'll tell him? |
15:12 |
|
kidclamp |
I would say yes. If the bug isn't signed off then squashing will make the set easier to read and rewriting the test plans/renaming the bug will make it more clear what he is doing |
15:14 |
|
corilynn |
kidclamp, updating with "Thoughts in IRC are that squishing would be fine and to please re-write the tests to make them clearer and easier to follow with correct information." |
15:17 |
|
kidclamp |
'test plan' rather than 'tests' - test plan is the instructions for testers- tests are usually the unit tests that programatically cover the changes - semantics - as long as he and you understand:-) |
15:19 |
|
corilynn |
I'll remember for next time |
15:25 |
|
oleonard |
I'm curious about the decision to submit separate follow-up patches to a bug which isn't signed off. If there's no signoff to preserve, just submit a corrected original patch |
15:27 |
|
ashimema |
to me it depends whose doing the followups |
15:27 |
|
ashimema |
we want to preseve authors for the release notes ;) |
15:27 |
|
* ashimema |
is always keen to attribute work to the right people |
15:27 |
|
ashimema |
so.. if it's the original author doing followups then I'm fine with squashing |
15:27 |
|
ashimema |
if it's a new author I like it in a separate patch |
15:28 |
|
ashimema |
personally.. to actually qa a bug I nearly always create a branch with the whole set applied and then diff the branch against master to get the big picture vuew |
15:28 |
|
ashimema |
then if something's a bit odd.. I'll refer back through the commits to see if there's a reason it's odd |
15:28 |
|
ashimema |
before commenting |
15:28 |
|
oleonard |
Yes, of course a different author's patch shouldn't be squashed |
15:29 |
|
kidclamp |
ah, indeed, agreed |
15:30 |
|
kidclamp |
well, in the case of the bug transferring from one author to another and major rewrite htough, I could go along |
15:30 |
|
kidclamp |
if you buy an axe, then replace the handle, then replace the head, is it the same axe? |
15:31 |
|
kidclamp |
No easy answers ever! |
15:32 |
|
oleonard |
The answer is easy: You simply moved the handle to a new axe. The handle itself carries no essence of "axe." Only the head of the axe is 100% axe. |
15:33 |
|
oleonard |
Tell your friends. |
15:36 |
|
ashimema |
lol |
15:37 |
|
kidclamp |
lunchies |
15:37 |
|
CrispyBran |
why am i here? ;) |
15:41 |
|
corilynn |
I don't ask easy questions, ya'll |
15:42 |
|
mtompset |
kidclamp, it's like having the infinite spousal inheritance... one spouse dies, other remarries younger. The other spouse dies, the younger one remarries younger. And let's say by some miracle the kid of the first couple is still alive. Is the last couple the kid's parents? ;) |
15:46 |
|
CrispyBran |
only if the new parent adopted at the time of the marriage. |
15:46 |
|
oleonard |
^^ See, simple answers all. |
15:48 |
|
corilynn |
I don't see the huge deal. You can always go back and see the obsoleted attachements |
15:48 |
|
|
m23_ joined #koha |
15:48 |
|
oleonard |
corilynn: Those kids can't go back and see their obsoleted parents!! |
15:49 |
|
corilynn |
sure they can, there's pictures, oleonard |
15:52 |
|
oleonard |
True, the original spouse must have had money, hence a beautifully-painted portrait. The new spouse married them for their money, which is why the child is now their servant can can't go to the dance. |
15:52 |
|
corilynn |
starting your nanowrimo early, oleonard? |
15:57 |
|
Dyrcona |
heh. |
15:58 |
|
ashimema |
what sort of time does alex buckley usual roll around? |
15:58 |
|
oleonard |
I'd guess in about three hours ashimema |
15:59 |
|
ashimema |
ta |
16:01 |
|
reiveune |
bye |
16:01 |
|
|
reiveune left #koha |
16:07 |
|
Joubu |
@later tell mtompset thanks for the review. I will not have time to get back to it in the next hours, maybe tomorrow. The links to refine the search (sort, facets, etc.) have to be fixed |
16:07 |
|
huginn |
Joubu: The operation succeeded. |
16:08 |
|
|
caroline joined #koha |
16:17 |
|
mtompset |
Joubu, *ping* |
16:22 |
|
mtompset |
@later tell Joubu re the feedback about bug 21526: patch the same bug? It was pushed already. |
16:22 |
|
huginn |
mtompset: The operation succeeded. |
16:42 |
|
|
caroline joined #koha |
16:47 |
|
|
calire joined #koha |
16:47 |
|
|
laurence left #koha |
16:48 |
|
|
bella joined #koha |
16:56 |
|
lavamind |
hello! I'm hitting an issue with Koha 18.05 that I don't understand: I can't view/edit any item-related statuses (screenshot: https://share.riseup.net/#sLzWcP3EJPgTUjljJvzaYw ) |
16:57 |
|
lavamind |
all the statuses like withdrawn, damaged, use restrictions have an empty drop-down box |
16:57 |
|
lavamind |
well the box says "aucune correspondance trouvée" which I think translates to no matching record |
16:57 |
|
lavamind |
this is an instance I've upgraded all the way from 3.08 |
16:58 |
|
calire |
lavamind: do you have authorised values set for those fields? |
16:59 |
|
lavamind |
calire: maybe, but I wouldn't know how to check |
16:59 |
|
calire |
I cannot comment on such a big version jump - a lot will have changed between the versions |
16:59 |
|
calire |
lavamind, if you go to administration and then authorised values |
17:00 |
|
oleonard |
lavamind: If I delete all my "withdrawn" authorised values I see "No matches found" in the drop-down, so it sounds like that's what you're seeing too |
17:00 |
|
oleonard |
...although mine isn't squeezed too small like it is in your screenshot |
17:01 |
|
lavamind |
it seems there are no authorised values for any fields |
17:01 |
|
lavamind |
(yikes) |
17:01 |
|
lavamind |
oh there is for YES_NO |
17:02 |
|
oleonard |
lavamind: It seems like something you should be able to recover from a backup of the database |
17:02 |
|
lavamind |
ah well all of the item-related ones are empty |
17:02 |
|
lavamind |
in my case I'd rather want to restore the defaults |
17:02 |
|
lavamind |
which database tables should I look at? |
17:03 |
|
oleonard |
authorised_values |
17:08 |
|
lavamind |
oleonard: I'm looking at the default SQL files, and I don't seem to be able to find default values for these categories |
17:08 |
|
lavamind |
does Koha ship with empty values for these ? |
17:09 |
|
lavamind |
it only seems to have values for HSBND_FREQ and YES_NO |
17:09 |
|
oleonard |
installer/data/mysql/en/optional/auth_val.sql |
17:11 |
|
|
barton joined #koha |
17:11 |
|
|
PeanutButterWoman joined #koha |
17:22 |
|
|
cait joined #koha |
17:32 |
|
cait |
hi #koha! |
18:29 |
|
|
alexbuckley joined #koha |
18:58 |
|
oleonard |
Bye #koha |
19:18 |
|
cait |
@wunder Konstanz |
19:18 |
|
huginn |
cait: Konstanz, Germany :: Clear :: 40F/4C | Wind Chill: 37F/3C | Tuesday: Clear. Lows overnight in the mid 30s. Tuesday Night: Clear skies. Scattered frost possible. Low around 35F. Winds light and variable. |
19:24 |
|
|
caroline1 joined #koha |
19:36 |
|
|
alexbuckley joined #koha |
20:07 |
|
ashimema |
cait |
20:07 |
|
ashimema |
Did I miss her |
20:09 |
|
cait |
nope |
20:09 |
|
cait |
just peeling pomegranates |
20:09 |
|
cait |
(next to the laptop, maybe not the bets idea) |
20:15 |
|
cait |
ashimema: |
20:25 |
|
|
kathryn joined #koha |
20:25 |
|
kathryn |
hi everyone |
20:25 |
|
alexbuckley |
hi kathryn |
20:28 |
|
|
caroline joined #koha |
20:29 |
|
* cait |
waves |
20:30 |
|
|
sameee joined #koha |
20:32 |
|
* kathryn |
waves back, hi cait, hi alexbuckley :) |
20:58 |
|
|
caroline joined #koha |
21:19 |
|
ashimema |
Oops |
21:29 |
|
lavamind |
hello |
21:29 |
|
wahanui |
kia ora, lavamind |
21:33 |
|
lavamind |
I'm currently testing this patch (mojolocious) and hit a snag https://bugs.koha-community.or[…]_bug.cgi?id=20582 |
21:33 |
|
huginn |
Bug 20582: enhancement, P5 - low, ---, julian.maurice, Needs Signoff , Turn Koha into a Mojolicious application |
21:33 |
|
lavamind |
I can't upload any file, there are no compiler errors, upload-file.pl jkust returns a failed error code |
21:34 |
|
lavamind |
HTTP response: {"errors":null,"status":"failed","fileid":null} |
21:35 |
|
lavamind |
I ran the app inside morbo with strace but it doesn't seem to be attempting to write anything to the upload/temp dirs (which exist and have the correct permissions) |
22:02 |
|
lavamind |
hrmm, the issue seems to be in Koha::Uploader, the cgi handler is created but for some reason its hook is never called |
22:09 |
|
alexbuckley |
hi #koha |
22:12 |
|
lavamind |
hello alexbuckley |
22:14 |
|
caroline |
bye #koha! |
22:23 |
|
|
cdickinson joined #koha |
23:00 |
|
|
sonOfRa joined #koha |
23:01 |
|
dcook |
@wunder syd |
23:01 |
|
huginn |
dcook: Sydney, Australia :: Clear :: 68F/20C | Wednesday: A good deal of sunshine. High 77F. Winds SE at 10 to 20 mph. Wednesday Night: Mostly cloudy skies. Low 64F. Winds SSE at 10 to 15 mph. |
23:37 |
|
|
Francesca joined #koha |