IRC log for #koha, 2018-04-03

All times shown according to UTC.

Time S Nick Message
00:02 BobB joined #koha
00:14 Kafilini joined #koha
00:15 BobB_ joined #koha
00:36 JoshB joined #koha
00:50 Kafilini joined #koha
01:04 talljoy hi #koha  question on BZ 19687  Mason doesn't say what the prefix is that he added to fix this problem.  anyone familiar with this that can provide that little detail so i can load some bibs?
01:15 talljoy think i got it C4::Biblio
01:27 alexbuckley joined #koha
01:27 rangi talljoy: yep, that looks right to me
01:28 talljoy it's working for me.  so yippee
04:45 mtompset Have a great day, #koha
05:03 JesseDhammu joined #koha
05:07 cait joined #koha
05:14 josef_moravec joined #koha
05:46 magnuse joined #koha
05:53 fridolin joined #koha
05:54 fridolin hie there
06:00 josef_moravec hi fridolin
06:01 magnuse \o/
06:04 fridolin bonjour josef_moravec magnuse
06:26 BobB joined #koha
06:29 reiveune joined #koha
06:29 reiveune hello
06:36 alex_a joined #koha
06:36 alex_a bonjour
06:36 wahanui privet, alex_a
06:41 paul_p joined #koha
06:56 tuxayo hi #koha o/
06:57 laurence joined #koha
07:02 JesseDhammu joined #koha
07:02 JesseDhammu hay, can anyone provide me detailed documentation on Serials control of KOHA, i need to start managing my library journals, (Current and back volume) with koha
07:11 josef_moravec JesseDhammu: have you looked to manual?
07:11 josef_moravec https://koha-community.org/man[…]l/08_serials.html
07:14 sophie_m joined #koha
07:17 benjamin joined #koha
07:24 emucla joined #koha
07:34 gaetan_B joined #koha
07:34 gaetan_B hello
07:47 magnuse_ joined #koha
07:57 ashimema joined #koha
08:09 _emucla_ joined #koha
08:26 ashimema_laptop joined #koha
08:26 alexbuckley joined #koha
08:27 ashimema joined #koha
08:29 cait joined #koha
08:39 andreashm joined #koha
08:39 andreashm hi #koha
08:43 nlegrand Bonjoul !
08:43 nlegrand hum
08:43 nlegrand Bonjour !
08:44 andreashm bonjour nlegrand
08:45 nlegrand o/
08:45 ashimema_laptop joined #koha
08:48 ashimema_laptop joined #koha
08:53 ashimema_laptop joined #koha
09:03 ashimema_laptop joined #koha
09:06 magnuse_ hiya cait andreashm nlegrand ashimema_laptop
09:06 andreashm hey magnuse_
09:11 nlegrand o/ magnuse
09:19 * cait waves
09:21 nlegrand o/ cait
09:25 tuxayo o/ nlegrand  cait  magnuse_
09:32 magnuse hiya tuxayo
09:35 chris_n joined #koha
09:42 nlegrand o/ tuxayo
09:49 kidclamp joined #koha
09:59 AndrewIsh joined #koha
10:00 petter joined #koha
10:01 tuxayo cait: Do you think that bug 12310 is ready for sign off? https://bugs.koha-community.or[…].cgi?id=12310#c56
10:01 tuxayo I should have adressed everything that must be adressed before sign off. (JS includes to move and functions to eventually rename)
10:01 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=12310 critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
10:01 huginn Bug 12310: critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
10:01 magnuse hei petter
10:02 petter hei magnus!
10:05 AndrewIsh Hey all! I'm trying to resurrect a Koha install that has been unused for the past 12 months or so. I've pulled latest and upgraded the DB. All seems fine except all my CSS and JS assets are all 404'ing, they've all got paths such as /opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap.min_17.1200025.css All the assets are present, they've just not got the version appended to their filenames. I'm assuming I need to update a redirect somewhere, I'm not seeing
10:05 AndrewIsh anything in Apache. Does anyone know what's going on?
10:14 paxed AndrewIsh: yes, current master has apache redirects for the version numbered assets
10:16 AndrewIsh paxed: Aha, excellent. I can cook up a redirect myself, but I'm thinking, in case there are any gotchas, is the required redirect documented anywhere?
10:17 paxed AndrewIsh: see etc/koha-httpd.conf
10:17 tuxayo paxed: Do we have a ressource to point to these changes?
10:17 tuxayo AndrewIsh: The lastest rewrite rules are in bug 20187
10:17 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=20187 normal, P5 - low, ---, kyle, Pushed to Master , New rewrite rules can break custom css
10:18 paxed tuxayo: no idea.
10:18 paxed AndrewIsh: eg. RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][​0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
10:18 AndrewIsh Perfect, thanks all :)
10:25 JoshB joined #koha
10:28 andreashm joined #koha
10:30 * andreashm waves
10:37 fridolin AndrewIsh: I have proposed a shorter rule : RewriteRule ^(.*)_[0-9]{2}\.[0-9]{7}\.(js|css)$ $1.$2 [L]
10:37 fridolin see Bug 20259
10:37 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=20259 normal, P5 - low, ---, fridolin.somers, Needs Signoff , Shorter JS and CSS rewrite rule
10:38 fridolin regexp si sooo beautiful
10:45 AndrewIsh Thanks fridolin :D
10:46 fridolin your welcome
10:47 fridolin we have an nginx version if needed
10:48 andreashm fridolin: do you run nginx with elastic?
10:48 fridolin andreashm: we run nginx with Koha including with ES
10:49 andreashm fridolin: we have a Swedish library who wants to do that, but they are having encoding issues. have you encountered any? and if so, do you have a fix?
10:49 fridolin in our sandboxes where is a rproxy rule in Nginx to access ES server
10:49 fridolin andreashm: encoding with search results only  ?
10:49 fridolin or with all the pages ?
10:50 andreashm at least search. not sure if it is all pages
10:50 andreashm I guess you have plack (starman) working with nginx+es too?
10:50 fridolin andreashm: so its not a problem from nginx i bet, a pb of ES. It is still under developpement by now
10:51 fridolin yes plack of course
10:51 andreashm maybe. but it works with apache
10:51 fridolin ah euuu
10:51 fridolin with apache + plack ?
10:52 andreashm looking at create database the default character set seems to be latin1
10:52 andreashm fridolin: yep. plack, apache and es
10:52 fridolin strange
10:52 andreashm As far as I understand (we are not running either nginx or es as of yet)
10:52 fridolin you can see our Nginx config here http://git.biblibre.com/biblib[…]nginx/tree/master
10:54 fridolin oh indeed, db must be created with UTF8
10:55 andreashm fridolin: thanks, I'll pass that along!
10:55 fridolin look at source code debian/scripts/koha-create
11:01 fridolin dont hesitate to contact me by email if you need help ;)
11:03 andreashm thanks fridolin!
11:26 ncbaratta joined #koha
11:29 Dyrcona joined #koha
11:31 meliss joined #koha
11:50 JesseDhammu HI Guys, I went though the Koha manual and created some serial subscriptions as well. but i am confused about the old and bound volumes of journals which are already recieved and stacked in our library, Coz multiple issues are bound in one, how do i mark those issues in koha as bound volumes and assign them one barcode ????
11:50 JesseDhammu please help, if there is any detailed documentation from librarians perspective, it would be really helpfull.
11:54 magnuse JesseDhammu: I *think* you just have to delete (or hide) the items for the individual issues, and create a new item for the bound volume
11:54 andreashm JesseDhammu: bound volumes are always a problem. Unfortunately, I can't help you with serial subscriptions since we don't use Koha to handle those at our library.
11:55 JesseDhammu That'd be hell of a job, coz i have huge collection of bound volumes, and i am thinking to enter them all in koha, so that my current and future subscriptions can be managed through koha
11:55 andreashm I think magnuse answer was more helpful. =)
11:56 JesseDhammu is there any other system which has a solid serials module ..??
11:58 cait JesseDhammu: can you check them out?
11:59 cait first question: do you need real items for those :)
11:59 cait you can check the 'manual history' and use the notes fields on subscrption history to indicate your holdings
11:59 cait we have libraries who started later with the serials module that use the history fields to summarize
12:00 cait as issues often can't be checked out they only make items for bound volumes
12:02 JesseDhammu cait: yes, i have my old bound volumes with accession numbers on them, and they are properly arranged with a call number in the stack, although can not be circulated. but still, i want my uses and my staff to search which issue is bouned under which barcode number (Item).
12:02 JesseDhammu so
12:02 cait ok yep, then for the bound volumes creating items makes sense
12:02 cait how do you handle the issues before they are bound?
12:03 JesseDhammu they are kept on display rack individually, but still not circulated.
12:03 cait no barcodes?
12:03 cait or chips?
12:03 wahanui chips are what we call fries
12:03 cait well tags
12:04 JesseDhammu not with individual issues, only after they are bound as one item to be shelved on the rack
12:04 cait ok
12:04 cait so i would make subscriptions not creating items
12:04 cait that will make it easier to handle
12:04 cait and make sure you check the manual history in the subscription
12:05 cait then in one of the tabs on subscription detail page, you have a link to edit the history
12:05 cait there are note fields and some auto filled fields by Koha
12:06 cait so you can be super correct and change the entries there to delete issues that have been bound, or you can just add some notes
12:06 JesseDhammu ok, and then later on by editing the history i can assign one barcode to a bundle ??
12:06 cait like: Please note that issues from the last year are ususally bound together and available from the stacks (or something like that)
12:06 oleonard joined #koha
12:06 cait no, you'd craete a normal item then
12:06 cait there is no automatism
12:06 cait and use  952$h
12:07 cait sec, looking for an example
12:07 JesseDhammu ok, but then would'nt it create duplicate records for the same thing, coz i will be having the record in subscription history and also i will create new item record for the bound volume ..?!?!
12:08 cait if you don't create items with the serials there is no duplicates
12:08 cait you just record issues
12:08 cait that's how I woudl do it, but you can do things differently of course
12:08 cait Koha can track the issues without creating items for them
12:09 cait the configuration here is that the subscription tab opens first if there is a subscription
12:09 oleonard Hi #koha
12:10 cait that shows the latest issues
12:10 cait how many are shown is configurable per subscription or globally
12:10 JesseDhammu let me go through. :)
12:10 cait hen when you go to the items tab you see the items for the bound volumes
12:11 cait they also use acq and order not 'from subscription' but as a normal order  - that's the item on top. It is later changed to be the item for the bound volume
12:11 cait could be hidden from OPAC too, if you wnted
12:12 cait hi oleonard :)
12:12 tuxayo o/ oleonard
12:13 JesseDhammu cait: Thanks mate, ill try
12:13 cait hope I kind of explained... only one way to do it of course
12:16 cait different topic... someone who wants to sign-off on bug  9634?
12:16 huginn Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9634 enhancement, P5 - low, ---, nick, Needs Signoff , Allow for parameters re-use on SQL reports
12:16 cait bug 18791 is also a lot of fun
12:16 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=18791 enhancement, P5 - low, ---, kyle, Needs Signoff , Add the ability for librarians to easily copy, download or print DataTables based tables in Koha
12:19 tcohen morning
12:21 cait morning tcohen!
12:22 andreashm hey tcohen cait oleonard tuxayo
12:23 magnuse cait++
12:24 cait hm?
12:29 DonnaB joined #koha
12:31 cait josef_moravec++
12:34 magnuse for advice on the bound volumes thing
12:34 Joubu hi #koha
12:35 cait hi Joubu
12:35 josef_moravec hi Joubu
12:36 magnuse hi Joubu
12:37 cait josef_moravec: thx for taking those bugs :)
12:38 andreashm hi joubu josef_moravec
12:41 andreashm I guess most have seen this already? http://kohacon2018.bywatersolu[…]ns.com/index.html
12:43 oleonard Be there or be square
12:45 * andreashm hopes to not be square
12:45 andreashm =)
12:48 * magnuse will probably be square, as long as the powers that be be the powers that be
12:51 magnuse kia ora kidclamp
12:52 kidclamp hiya magnuse
12:58 tuxayo hi Joubu , hi kidclamp :)
12:58 kidclamp hi tuxayo
13:00 andrew joined #koha
13:01 kmlussier joined #koha
13:02 tuxayo Joubu: Will you have some time tell if bug 12310 is ready for sign off? https://bugs.koha-community.or[…].cgi?id=12310#c56
13:02 tuxayo I should have adressed all the feedback that had to be adressed before sign off. (remaining: JS includes to move and functions to eventually rename)
13:02 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=12310 critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
13:02 huginn Bug 12310: critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
13:06 tcohen kidclamp: reset_all_unimarc and reset_all_marc21 ?
13:06 kidclamp with reset_all default to setting from kohadevbox?
13:07 josef_moravec Joubu++
13:07 kidclamp or should reset_all with no params default to the current?
13:07 kidclamp tcohen^
13:07 * oleonard votes for no params == current
13:08 tcohen exactly
13:08 Joubu tuxayo: default value is ',.', how will be converted "1,000,000.10"?
13:08 Joubu it's not in the test plan
13:08 tcohen Joubu++ # generally
13:14 kellym joined #koha
13:15 fridolin joined #koha
13:21 tuxayo Joubu: It will be converted to something invalid. The default value can't handle that case. But it handle commas or dots as separators on the same instance.
13:22 JoshB joined #koha
13:24 Margaret_ joined #koha
13:25 Joubu tuxayo: maybe we should guess it for existing installs depending on currencyformat?
13:29 oleonard Is anyone already planning to send an IRC meeting reminder for tomorrow? If not I can do it
13:29 kidclamp oleonard++
13:33 cait do it :)
13:35 * oleonard did it
13:38 cait thx oleonard :)
13:39 cait oleonard: coudl you take a look at bug 13044 - i think it drifts into a gui disussion
13:39 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=13044 enhancement, P5 - low, ---, kyle, NEW , Deprecate old book drop mode
13:40 oleonard Yes, but probably not today unless it's urgent
13:40 cait not urgent :)
13:48 edveal joined #koha
13:49 magnuse hehe "so this script is not intended to have a long lifetime" http://git.koha-community.org/[…]ngoverdue.pl#l181
13:54 talljoy joined #koha
13:55 Joubu tuxayo: something else, I think the unformat_input function must be called on elements with a given class
13:56 dersmon joined #koha
13:56 dersmon hi everyone!
13:59 dersmon quick question: can i search explicitely for a system number?
13:59 dersmon (marc 001)
14:00 cait Control-number=
14:00 edveal joined #koha
14:00 cait in a keyword search input field
14:00 cait you can use ccl syntax, index name=terms
14:04 eythian magnuse: you might say it's long overdue for a replacement.
14:04 magnuse haha!
14:06 dersmon thx cait :)
14:09 maksim joined #koha
14:13 maksim Hey everyone, is there a value somewhere in the database in koha that tells me if a renewal was made online?
14:15 tcohen I don't think so
14:17 maksim Is there one to see if a patron did it?
14:20 tcohen probably in action_logs
14:21 maksim Thanks Cohen, I'll have a look!
14:22 cait maksim: i think it depends on a pref
14:22 cait let me check
14:23 cait maksim: take a look at OpacRenewalBranch
14:23 prova joined #koha
14:23 cait I think only if you set it to OPACRenew it will be visible where the renewal was made
14:23 maksim oh alright let me check!
14:24 tuxayo Joubu: guessing: That might be confusing. And from the feedback I got during the hackfest. Supporting both separators on the same instance seems more prefered than supporting separators.
14:24 tuxayo «the unformat_input function must be called on elements with a given class» I don't get that.
14:26 Joubu tuxayo: instead of ('#amount').on('change', function(){decimal.handler_unformat_input(this)});
14:26 Joubu you could: $("all_my_elemment_with_a_​given_class").on('change', ...);
14:27 Joubu to put in a global (or acq only) JS file
14:29 cait maybe new include js?
14:29 cait later used in fines and acq
14:31 rocio joined #koha
14:33 tuxayo Joubu cait Isn't that equivalent of not following https://wiki.koha-community.or[…]_attributes_like_.22onclick.22_to_attach_events
14:36 Joubu tuxayo: what I suggest is the same syntax as yours
14:36 Joubu the guideline you are referring to forbid the use of the "onclick" attribute
14:37 Joubu ha, the ID part you meant?
14:38 Joubu it is an example I guess, it could be a class as well (oleonard is not around to confirm)
14:38 oleonard I'm around
14:38 oleonard ...but haven't been paying attention
14:40 Joubu oleonard: my IRC client did not autocomplete your nick!
14:40 * oleonard stealthy
14:40 Joubu $(".just_a_class").on('click', function(){}); # oleonard, this is correct right? no need an id
14:40 oleonard Yes
14:41 Joubu ok thanks, I am going to update the wiki page to remove the confusion
14:46 huginn News from kohagit: Bug 7143: Update about page for new dev - Roch D'Amour <http://git.koha-community.org/[…]b36dedc447dc076c9>
14:46 huginn News from kohagit: Bug 7143: Update about page for new dev - Philippe Audet-Fortin <http://git.koha-community.org/[…]57e9c4185b67c0cf3>
14:46 huginn News from kohagit: Bug 7143: Update about page for new releases <http://git.koha-community.org/[…]66c62902c90b14cf3>
14:46 huginn News from kohagit: Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl <http://git.koha-community.org/[…]035d4d8348ad108dc>
14:46 huginn News from kohagit: Bug 19935: Use ->checkouts when ->pending_checkouts->count was used <http://git.koha-community.org/[…]adaec701531913764>
14:46 huginn News from kohagit: Bug 17553: (follow-up) Adjust number of tests <http://git.koha-community.org/[…]6a7f32af2f8623782>
14:46 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - IssueSlip <http://git.koha-community.org/[…]f58ab8e2d29134c32>
14:46 huginn News from kohagit: Bug 19935: Add Koha::Patron->pending_checkouts <http://git.koha-community.org/[…]181f64f078087fa45>
14:46 huginn News from kohagit: Bug 19926: Add tests for Koha::Object->unblessed_all_relateds <http://git.koha-community.org/[…]f1c0657c6b9ad5dd0>
14:46 huginn News from kohagit: Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues <http://git.koha-community.org/[…]a7416a734410c12f6>
14:46 huginn News from kohagit: Bug 19926: Add the Koha::Object->unblessed_all_relateds method <http://git.koha-community.org/[…]0ccee346f48db40bd>
14:46 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - Remove the residue <http://git.koha-community.org/[…]2cebba218dfeec38e>
14:46 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - SIP <http://git.koha-community.org/[…]c0cf707afd9e5bd78>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - sco-main <http://git.koha-community.org/[…]ef9d615bf35806cbe>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - opac-user.pl <http://git.koha-community.org/[…]56fa41c467c4c8c88>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - opac-ics.pl <http://git.koha-community.org/[…]47e51d0cdcf961939>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - summary-print <http://git.koha-community.org/[…]1c29c6ab10faa6bdb>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - deletemem.pl <http://git.koha-community.org/[…]fdb6c4d349f9b1e10>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - Discharges <http://git.koha-community.org/[…]38c405843fe9be654>
14:47 huginn News from kohagit: Bug 19935: Replace GetPendingIssues - ILSDI <http://git.koha-community.org/[…]b09537b3cc0368274>
14:47 huginn News from kohagit: Bug 17553: Move existing tests <http://git.koha-community.org/[…]8c085370681bc1af8>
15:00 tuxayo Joubu: the aim of guideline from what I understood is to separate the presentation from the logic.
15:00 tuxayo So having using a class "class-used-to-bind-an-onc​hange-event-automatically" is equivalent right?
15:00 tuxayo cc oleonard cait
15:01 oleonard I don't think I understand your question tuxayo
15:01 cait me neither
15:05 edveal joined #koha
15:06 * tuxayo sent a long message: tuxayo_2018-04-03_15:06:52.txt <https://matrix.org/_matrix/med[…]cTHSrZbUwxZXwMAIL>
15:08 tuxayo Because the class will have a unique name used only to bind our handler (foo in the above example)
15:11 jbeno joined #koha
15:13 edveal joined #koha
15:15 oleonard tuxayo: Yes
15:24 fridolin left #koha
15:26 jenkins Project Koha_Master_D8 build #418: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_Master_D8/418/
15:26 jenkins * Jonathan Druart: Bug 7143: Update about page for new releases
15:26 jenkins * Jonathan Druart: Bug 7143: Update about page for new dev - Philippe Audet-Fortin
15:26 jenkins * Jonathan Druart: Bug 7143: Update about page for new dev - Roch D'Amour
15:26 huginn Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, koha-bugs, Pushed to Master , Bug for tracking changes to the about page
15:26 jenkins * Jonathan Druart: Bug 19926: Add the Koha::Object->unblessed_all_relateds method
15:26 jenkins * Jonathan Druart: Bug 19926: Add tests for Koha::Object->unblessed_all_relateds
15:26 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=19926 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Add the Koha::Object->unblessed_all_relateds method
15:26 jenkins * Jonathan Druart: Bug 17553: Move existing tests
15:26 jenkins * Jonathan Druart: Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues
15:26 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=17553 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Move GetOverduesForPatron to Koha::Patron
15:26 jenkins * josef.moravec: Bug 17553: (follow-up) Adjust number of tests
15:26 jenkins * Jonathan Druart: Bug 19935: Add Koha::Patron->pending_checkouts
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - IssueSlip
15:26 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=19935 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Move C4::Members::GetPendingIssues to the Koha namespace
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - ILSDI
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - Discharges
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - deletemem.pl
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - summary-print
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - opac-ics.pl
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - opac-user.pl
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - sco-main
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - SIP
15:26 jenkins * Jonathan Druart: Bug 19935: Replace GetPendingIssues - Remove the residue
15:26 jenkins * Jonathan Druart: Bug 19935: Use ->checkouts when ->pending_checkouts->count was used
15:26 jenkins * Jonathan Druart: Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl
15:26 tuxayo oleonard: So which way will result in the cleaner code? (we could argue that it's not a violation of JS9 :P)
15:27 oleonard tuxayo: I don't know what code you're referring to so it's hard to say
15:31 maksim cait do you know where renewals would be kept in the database?
15:32 tuxayo oleonard: https://gitlab.com/tuxayo/Koha[…]e9079903d626e4bb8
15:32 tuxayo search for handler_unformat_input
15:32 wahanui joined #koha
15:34 oleonard tuxayo: Now that I have the code in front of me you explain your question again? Sorry to make you repeat yourself.
15:37 reiveune bye
15:37 reiveune left #koha
15:42 tuxayo oleonard: it was to address the suggestion of using a class to bind the event instead of binding with the JavaScript.
15:45 oleonard And the code you showed me is the revised version, correct? It looks good to me, but I'm wondering what you mean about cleaner code
15:47 liw joined #koha
15:51 tuxayo oleonard: It was Joubu and cait who suggested to use a class to not have multiple binds in JS
15:51 tuxayo But maybe they can explain it better :P
15:51 oleonard Yes I agree
15:51 roch joined #koha
15:53 cait i don't think it was me :)
15:55 tuxayo cait: you approved it, it's the same :P
15:56 Joubu my point was to avoid hundreds of JS lines and replace them with only one :)
15:57 cait Joubu and oleonard know best - so i can approve that, just not claim the idea was mine :)
15:58 tuxayo Indeed ^^
15:59 laurence left #koha
15:59 tuxayo oleonard: So: I'll put a very specific class to be able to bind the handler in the decimal-input-js.inc
16:00 tuxayo And finally move on the bug! :D
16:06 oleonard tuxayo++
16:08 ebegin joined #koha
16:08 oleonard Hi ebegin
16:08 ebegin Hey there ! :)
16:53 * cait waves
17:01 * kidclamp pew pew pew
17:02 cait left #koha
17:05 andrew joined #koha
17:06 ebegin joined #koha
17:19 Scratch joined #koha
17:32 smita joined #koha
17:33 smita hello
17:33 wahanui niihau, smita
17:33 smita thanks wahanui
17:34 smita my first time here
17:34 kidclamp welcome smita
17:35 smita I'm trying to use Koha, migrating from SOUL software
17:35 smita in my library we allow faculty members unlimited renewals
17:35 smita hi kidclamp
17:36 smita i see the field renewal allowed (count) in the circ rules setup
17:36 smita the manual says number of renewals allowed should be entered
17:36 smita so how should I enter it here?
17:38 rocio joined #koha
17:45 roch joined #koha
17:47 tcohen @later tell Joubu running do_all_you_can_do.pl --marcflavour unimarc gives lots of 'error retrieving record' errors, probably due to sample data?
17:47 huginn tcohen: The operation succeeded.
17:48 tcohen @later tell Joubu test it with the reset_all_unimarc alias, after re-provisioning
17:48 huginn tcohen: The operation succeeded.
17:51 liw left #koha
17:57 kidclamp smita, I would say just make it veyr large
17:57 smita ok
17:57 kidclamp I don't think we have 'unlimited' as an option
18:27 cait joined #koha
18:46 barton joined #koha
20:15 jmsasse joined #koha
20:40 alexbuckley joined #koha
21:18 Infra_3600 joined #koha
21:51 Margaret joined #koha
21:58 kathryn joined #koha
22:09 _emucla_ joined #koha
22:44 kathryn joined #koha
22:53 kathryn joined #koha
22:56 wizzyrea joined #koha
22:56 JoshB left #koha
23:20 kathryn joined #koha
23:30 _emucla_ joined #koha
23:46 emucla joined #koha

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary