| Time |
S |
Nick |
Message |
| 00:16 |
|
|
papa joined #koha |
| 00:41 |
|
|
JoshB joined #koha |
| 00:53 |
|
|
jseplae joined #koha |
| 01:33 |
|
|
Francesca joined #koha |
| 01:38 |
|
|
pianohacker joined #koha |
| 01:39 |
|
pianohacker |
@later tell cait patched QA issues for rancor |
| 01:39 |
|
huginn |
pianohacker: The operation succeeded. |
| 01:41 |
|
|
BobB joined #koha |
| 03:00 |
|
|
Francesca joined #koha |
| 03:11 |
|
|
Francesca joined #koha |
| 03:13 |
|
|
Francesca joined #koha |
| 03:16 |
|
|
jseplae joined #koha |
| 03:50 |
|
eythian |
@seen dcook |
| 03:50 |
|
huginn |
eythian: dcook was last seen in #koha 5 days, 20 hours, 54 minutes, and 2 seconds ago: <dcook> Europe is coming online, while we Oceanic folk go home |
| 03:59 |
|
|
Francesca joined #koha |
| 04:53 |
|
|
Francesca joined #koha |
| 05:49 |
|
|
Viktor joined #koha |
| 06:05 |
|
|
saiful joined #koha |
| 06:11 |
|
|
cait joined #koha |
| 07:08 |
|
|
sophie_m joined #koha |
| 07:15 |
|
|
magnuse joined #koha |
| 07:17 |
|
* magnuse |
waves |
| 07:21 |
|
* cait |
waves |
| 07:21 |
|
* cait |
asks people to sign off on the remaining C4::Dates patches |
| 07:22 |
|
|
Francesca joined #koha |
| 07:23 |
|
|
fridolin joined #koha |
| 07:34 |
|
|
marcelr joined #koha |
| 07:34 |
|
marcelr |
hi #koha |
| 07:38 |
|
Francesca |
hi marcelr |
| 07:38 |
|
|
reiveune joined #koha |
| 07:40 |
|
marcelr |
:) |
| 07:42 |
|
reiveune |
hello |
| 07:48 |
|
|
Francesca joined #koha |
| 07:54 |
|
|
alex_a joined #koha |
| 07:55 |
|
|
laurence joined #koha |
| 07:55 |
|
alex_a |
bonjour |
| 07:55 |
|
wahanui |
hello, alex_a |
| 07:56 |
|
|
saiful joined #koha |
| 07:57 |
|
Joubu |
hi |
| 07:57 |
|
wahanui |
what's up, Joubu |
| 08:02 |
|
magnuse |
@later tell rangi i can haz bug 15042 in 3.20.x plueeses? kthxbai |
| 08:02 |
|
huginn |
magnuse: The operation succeeded. |
| 08:05 |
|
|
gaetan_B joined #koha |
| 08:05 |
|
gaetan_B |
hello |
| 08:06 |
|
magnuse |
@wunder boo |
| 08:06 |
|
huginn |
magnuse: The current temperature in Bodo, Norway is 5.0°C (8:50 AM CET on October 26, 2015). Conditions: Mostly Cloudy. Humidity: 81%. Dew Point: 2.0°C. Windchill: 1.0°C. Pressure: 29.89 in 1012 hPa (Steady). |
| 08:06 |
|
magnuse |
@wunder marseille |
| 08:06 |
|
huginn |
magnuse: The current temperature in Marseille, France is 17.0°C (9:00 AM CET on October 26, 2015). Conditions: Clear. Humidity: 77%. Dew Point: 13.0°C. Pressure: 30.09 in 1019 hPa (Steady). |
| 08:06 |
|
magnuse |
oops |
| 08:11 |
|
sophie_m |
magnus, the gap is deeper than friday :) |
| 08:15 |
|
Francesca |
@wunder wlg |
| 08:15 |
|
huginn |
Francesca: The current temperature in Wellington, New Zealand is 14.0°C (9:00 PM NZDT on October 26, 2015). Conditions: Overcast. Humidity: 77%. Dew Point: 10.0°C. Pressure: 29.86 in 1011 hPa (Steady). |
| 08:15 |
|
Francesca |
hmmm not much difference |
| 08:16 |
|
Francesca |
I think I'd still take frances weather though |
| 08:17 |
|
|
cait joined #koha |
| 08:19 |
|
cait |
morning #koha |
| 08:28 |
|
|
Viktor joined #koha |
| 08:43 |
|
|
Francesca joined #koha |
| 08:57 |
|
|
saiful joined #koha |
| 09:06 |
|
|
andreashm joined #koha |
| 09:06 |
|
* andreashm |
waves |
| 09:09 |
|
|
saiful2 joined #koha |
| 09:10 |
|
* cait |
waves back |
| 09:13 |
|
|
Francesca joined #koha |
| 09:28 |
|
|
paul_p joined #koha |
| 09:31 |
|
* magnuse |
waves too |
| 09:32 |
|
* liw |
undulates |
| 09:32 |
|
|
paul_p_ joined #koha |
| 09:36 |
|
|
Viktor joined #koha |
| 09:37 |
|
magnuse |
tjänare Viktor |
| 09:37 |
|
Viktor |
Hei Magnuse |
| 09:55 |
|
* cait |
waves again |
| 10:04 |
|
|
Viktor joined #koha |
| 10:06 |
|
* andreashm |
waves back (again) |
| 10:08 |
|
andreashm |
good to see activity on bug 13799 again, not so good that it's problems with the patches. oooh. |
| 10:08 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13799 new feature, P5 - low, ---, julian.maurice, Failed QA , Add base for building RESTful API |
| 10:13 |
|
* ashimema |
was just trying to replicate that |
| 10:15 |
|
|
saiful joined #koha |
| 10:27 |
|
magnuse |
ashimema++ |
| 10:30 |
|
* ashimema |
was about to submit his followups when he saw the comment.. hense why they're not there yet.. |
| 10:34 |
|
andreashm |
ashimema++ |
| 10:35 |
|
sophie_m |
Hello : in release notes for Koha 3.18.10 it is said that Bug 14690 is in (and it really is), but the report is always in NSO ? |
| 10:35 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=14690 minor, P5 - low, ---, liz, Needs Signoff , Patron import tool page missing extra search patron options |
| 10:40 |
|
cait |
i think maybe liz forgot to swith it |
| 10:41 |
|
|
khall left #koha |
| 10:41 |
|
|
khall joined #koha |
| 10:52 |
|
|
Oak joined #koha |
| 10:52 |
|
* Oak |
waves |
| 10:53 |
|
Oak |
Guten tag cait. |
| 10:53 |
|
Oak |
magnuse |
| 10:55 |
|
cait |
hi Oak:) |
| 10:58 |
|
Joubu |
@later tell on d7 master, I have executer alter table biblioitems auto_increment=115; alter table biblio auto_increment=115; to make GetTopIssues.t pass. There is something wrong somewhere... I hope it's just the tests |
| 10:58 |
|
huginn |
Joubu: The operation succeeded. |
| 10:59 |
|
ashimema |
who you telling there Joubu? |
| 11:00 |
|
ashimema |
'on' ;) |
| 11:00 |
|
Joubu |
ashimema: hum? |
| 11:00 |
|
ashimema |
you're later.. looked odd |
| 11:00 |
|
khall |
Joubu: looks like you didn't specify a username for your later |
| 11:00 |
|
Joubu |
erk |
| 11:00 |
|
ashimema |
no reference to a user ;) |
| 11:00 |
|
Joubu |
@later tell tcohen on d7 master, I have executer alter table biblioitems auto_increment=115; alter table biblio auto_increment=115; to make GetTopIssues.t pass. There is something wrong somewhere... I hope it's just the tests |
| 11:00 |
|
huginn |
Joubu: The operation succeeded. |
| 11:01 |
|
Joubu |
thanks ashimema |
| 11:01 |
|
ashimema |
hehe :) |
| 11:01 |
|
ashimema |
sorta thing I do all the time ;) |
| 11:03 |
|
ashimema |
jajm about? |
| 11:03 |
|
|
saiful joined #koha |
| 11:03 |
|
ashimema |
I see your working on bug 13799 |
| 11:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13799 new feature, P5 - low, ---, julian.maurice, Signed Off , Add base for building RESTful API |
| 11:04 |
|
ashimema |
and have fixed my overly hasty spec file refactoring (regarding the $ref missing) |
| 11:04 |
|
ashimema |
I don't like that you've removed the type's however |
| 11:04 |
|
ashimema |
if we remove those.. we may as well not use swagger |
| 11:07 |
|
* ashimema |
goes off to do somthing else then.. no point in working on 13799 whilst jajm is also working on it.. will just lead to loads of conflicts :( |
| 11:11 |
|
sophie_m |
Joubu : hello |
| 11:12 |
|
sophie_m |
Joubu, http://bugs.koha-community.org[…]g.cgi?id=14584#c6 you said not to backport in 3.18, but it is in 3.18.11 |
| 11:12 |
|
huginn |
Bug 14584: major, P5 - low, ---, jonathan.druart, Pushed to Stable , Encoding broken with system preferences |
| 11:13 |
|
Joubu |
sophie_m: ha :) |
| 11:14 |
|
Joubu |
weird, Liz didn't mark it "push to 3.18" |
| 11:14 |
|
sophie_m |
It is in release notes and i checked it is really in 3.18.11. Should we revert it in production ? |
| 11:16 |
|
Joubu |
sophie_m: I think so, but before you should test, see the commit message for a test plan |
| 11:16 |
|
* ashimema |
dislikes swagger with a passion sometimes.. |
| 11:18 |
|
Joubu |
@later tell tcohen Search.t fail on D7 suddenly but I suspect you just enable it. I have checked out 4132ac28bf088960d25766fccc60ba1535a0e8ef which introduce the test and it fails too. |
| 11:18 |
|
huginn |
Joubu: The operation succeeded. |
| 11:41 |
|
|
andreashm joined #koha |
| 11:42 |
|
andreashm |
ashimema: no luck with swagger today? |
| 11:43 |
|
ashimema |
well.. jajm is currently posting patches.. |
| 11:43 |
|
ashimema |
so there's little point on my doing followups until he's finished |
| 11:43 |
|
ashimema |
else I'll just spend time doing the same as him.. or rebased after him |
| 11:44 |
|
ashimema |
however.. he's highlighted a failing in swagger in his latest patch.. (which I knew about, but was ignoring in my own app) |
| 11:44 |
|
ashimema |
my stance is that if we don't use swagger to validatte the api then there's very ittle point in using swagger at all |
| 11:45 |
|
ashimema |
but.. there are some strange decisions in the swagger community meaning that swagger is not json-schema compatible.. and thus a bunch of perfectly reasonable schema requirements are not obtainable using swagger schema.. |
| 11:45 |
|
ashimema |
'string or null' being one such case.. |
| 11:46 |
|
ashimema |
jajm's latest followup just removes all validation from the schema files.. no point in having them then is my opinion on that |
| 11:48 |
|
|
meliss joined #koha |
| 11:48 |
|
jajm |
ashimema, hi |
| 11:49 |
|
jajm |
ashimema, do you disagree with my patches ? |
| 11:50 |
|
ashimema |
the very last followup I do... but i must admit i'm not sure yet what to suggest instead |
| 11:50 |
|
ashimema |
without type's I see not point in having those definitions at all :( |
| 11:51 |
|
ashimema |
but I do see your point on oneOf not being swagger valid.. (Swagger is stupid in my opinion with this regard) |
| 11:51 |
|
jajm |
they could be used to build documentation |
| 11:51 |
|
ashimema |
in my own ap I flag not to be fully swagger compliant |
| 11:52 |
|
ashimema |
if that's all we're suign them for.. we may as well jsut write human radable documentation ;) |
| 11:52 |
|
ashimema |
s/radabale/readable |
| 11:52 |
|
ashimema |
in plain text |
| 11:52 |
|
ashimema |
the entire point of swagger is to be machine readable allowing for automatic client generation |
| 11:53 |
|
ashimema |
So.. we either need to stick to swagger proper and thus write our api's to be compliant (and thus have types defined and stick to their limited types).. |
| 11:53 |
|
ashimema |
needs opening up to a wider audience |
| 11:54 |
|
cait |
ashimema: would there be an alternative that would work better? |
| 11:54 |
|
cait |
or is it mostly that it isn't worth the hassle if we can't use them for generation (which i might agree with... one more thing to keep in sync then) |
| 11:56 |
|
ashimema |
It's just a hard one to work with.. |
| 11:56 |
|
ashimema |
in koha.. null/undef is meaningful at the moment.. |
| 11:56 |
|
ashimema |
that's the issue |
| 11:57 |
|
ashimema |
In swagger.. you can do 'not exists' and 'exists and is of type'.. you can't do 'exists and is of type OR exists and is null/undef' |
| 11:58 |
|
ashimema |
In a fully restful world I suppose a 'not exists' should be treated the same as 'is null'.. which is where the swagger people are coming from |
| 11:59 |
|
ashimema |
jajm.. in your opinion what does a null mean in the api? |
| 11:59 |
|
cait |
i wonder - can you give an example where empty and null mean differnt things in Koha? |
| 11:59 |
|
ashimema |
OK.. users.. |
| 12:00 |
|
ashimema |
PUT { streetaddress: null } |
| 12:00 |
|
ashimema |
PUT { streetaddress: "some string" } |
| 12:00 |
|
ashimema |
PUT { } |
| 12:00 |
|
cait |
i think koah is bad ther eitself |
| 12:00 |
|
cait |
if you look at a patron record... sometimes we have nulland sometimes it's empty |
| 12:00 |
|
ashimema |
first one to me means 'Delete streetaddress', second one means 'Set streetaddress to 'some string'' |
| 12:01 |
|
cait |
maybe also depending on if the record was changed later - a field emptied out vs. never filled |
| 12:01 |
|
jajm |
null mean nothing special, simply "no value" |
| 12:01 |
|
ashimema |
and third one is opaque.. did you miss out streetaddress because it should be deleted.. or because you forgot to set it |
| 12:01 |
|
cait |
hm so put is also for delete? |
| 12:01 |
|
ashimema |
So.. rather than remove types.. set all fields to 'required' and be explicit about an empty string |
| 12:02 |
|
ashimema |
'PUT' is for UPDATE.. and always expects an entire object |
| 12:02 |
|
ashimema |
so.. my objects above are in fact invalid to start with.. because I did not include every field for brevity |
| 12:03 |
|
cait |
hm you always have to include all fields? |
| 12:03 |
|
cait |
sound slike that woudl get really hard to maintain |
| 12:03 |
|
ashimema |
PUT's are bad for big objects anyways (we should use PATCH).. but that's an entirely different story |
| 12:03 |
|
cait |
everytime the table changes, api partners woudl need to adapt |
| 12:03 |
|
ashimema |
exactly cait.. |
| 12:03 |
|
ashimema |
PATCH is nicer on that front |
| 12:04 |
|
ashimema |
though it still stands for CREATE and UPDATE routes.. they shold both expect a full object every time.. |
| 12:05 |
|
cait |
hm guess you could create like a 'minimal borrower' route? |
| 12:05 |
|
cait |
that requires less things? |
| 12:05 |
|
ashimema |
you could.. |
| 12:05 |
|
ashimema |
there are various ways to do it.. |
| 12:06 |
|
ashimema |
/borrowers/id = expect full object |
| 12:06 |
|
ashimema |
/borrowers/id/fieldname = expect just that field object |
| 12:08 |
|
ashimema |
I should probably continue with the guidelines |
| 12:08 |
|
ashimema |
more than the patch itself.. this is what we're really arguing over.. |
| 12:09 |
|
ashimema |
If our 'nulls' are not meaningful then there really is no point in having them at all ;) |
| 12:09 |
|
ashimema |
thus the types can go back in.. |
| 12:11 |
|
ashimema |
with 'allowEmptyValue' set |
| 12:12 |
|
ashimema |
except.. it's only valid for query string or formData.. |
| 12:12 |
|
ashimema |
ffs |
| 12:23 |
|
cait |
sorry was afk |
| 12:23 |
|
cait |
reading back |
| 12:23 |
|
* cait |
sends cookies |
| 12:28 |
|
ashimema |
hmm jajm.. |
| 12:28 |
|
ashimema |
looks like this may be a null point.. |
| 12:28 |
|
ashimema |
type: [ integer, null ] |
| 12:28 |
|
ashimema |
seems to work |
| 12:31 |
|
|
tcohen joined #koha |
| 12:31 |
|
jajm |
ashimema, is that thing in the swagger spec ? |
| 12:32 |
|
tcohen |
morning |
| 12:33 |
|
jajm |
it seems it's part of json schema spec http://json-schema.org/latest/[…]ion.html#anchor79 |
| 12:35 |
|
tcohen |
Joubu: the failing SEarch.t tests are due to recent changes |
| 12:35 |
|
tcohen |
I've only fixed the failure on D8 |
| 12:37 |
|
tcohen |
hi cait |
| 12:40 |
|
|
francharb joined #koha |
| 12:41 |
|
cait |
hi tcohen :) |
| 12:50 |
|
jajm |
ashimema, should I submit a patch with "string" replaced by ["string", "null"] ? |
| 12:52 |
|
|
Dyrcona joined #koha |
| 12:53 |
|
ashimema |
jajm.. i just tried it in the swagger editor and it didn't complain.. |
| 12:53 |
|
ashimema |
though i can't find anywhere in the swagger docs for it :( |
| 12:53 |
|
jajm |
ashimema, i tried it in koha and it works |
| 12:54 |
|
ashimema |
:) |
| 12:54 |
|
jajm |
it's part of json schema spec http://json-schema.org/latest/[…]ion.html#anchor79 |
| 12:56 |
|
cait |
cooperation++ |
| 12:59 |
|
ashimema |
indeed it is.. |
| 12:59 |
|
ashimema |
but it appears that it's part that is supported by swagger.. unless it's a bug in the swagger editor demo they host |
| 13:00 |
|
ashimema |
swagger != json-schema unfortunately as you are aware.. swagger both removes json-schema features and add's it's own features. |
| 13:00 |
|
ashimema |
I still think the broader question is whether our nulls are meaningful.. if they are not then we shuld likely not allow them in the requests and responses.. ;) |
| 13:02 |
|
ashimema |
and rather write our api to be consistent and valid against restful principles ;) |
| 13:05 |
|
jajm |
you mean we should remove null fields from the response ? |
| 13:08 |
|
|
mario joined #koha |
| 13:11 |
|
ashimema |
let me continue writing the guidelines page for a while.. |
| 13:11 |
|
ashimema |
then getting your comments on it would be the best place to start ;) |
| 13:12 |
|
ashimema |
the bug itself I personally believe is pretty pushable. |
| 13:19 |
|
|
talljoy joined #koha |
| 13:28 |
|
tcohen |
ashimema: so it is passed-qa? |
| 13:30 |
|
|
cma joined #koha |
| 13:31 |
|
|
meliss joined #koha |
| 13:34 |
|
ashimema |
I signed off.. so think khall was going to p-qa |
| 13:34 |
|
ashimema |
;0 |
| 13:34 |
|
ashimema |
but yeah.. in my opinion I'd pass it.. |
| 13:34 |
|
ashimema |
the documentation is in the works as I type. |
| 13:34 |
|
khall |
ashimema: which bug are you referring to? |
| 13:34 |
|
ashimema |
and will deffo need lots of inputs. |
| 13:35 |
|
ashimema |
restful base.. bug 13799 |
| 13:35 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13799 new feature, P5 - low, ---, julian.maurice, Signed Off , Add base for building RESTful API |
| 13:35 |
|
ashimema |
some of the followups are done now.. enough that I think it's a viable goer |
| 13:35 |
|
khall |
yes, I've been looking at that this morning. I'm ready to pass it! |
| 13:35 |
|
ashimema |
I'll be adding further followup to enhance the spec files and the patrons route once i've articulated my thoughts in the guidlines I'm curretly writing. |
| 13:37 |
|
ashimema |
also.. I really want us at some point to switch all occurrences of Borrowers or Patrons to Users codebase wide.. (I don't like the api being 'patrons' but understand people wanting it consistent with the internal api) ;) |
| 13:37 |
|
khall |
agreed |
| 13:37 |
|
ashimema |
users is a much more generic term and better fits the software.. to me Patron and Borrower both mean 'OPAC Users'.. yet our tables bundle staff and public users into one.. they're users.. |
| 13:38 |
|
khall |
I'd like to see consistency at the least. too many terms right now |
| 13:38 |
|
ashimema |
I have no idea why at some point we went from borrowers to patrons.. but both are wrong ;) |
| 13:38 |
|
khall |
ashimema: tcohen: I just put my qa stamp of approval on 13799 |
| 13:39 |
|
ashimema |
cheers khall |
| 13:39 |
|
khall |
np! |
| 13:39 |
|
ashimema |
push and prosper tcohen :) |
| 13:39 |
|
ashimema |
hugs all round |
| 13:40 |
|
khall |
I'd love to see this in 3.22 if that's possible |
| 13:41 |
|
ashimema |
me too |
| 13:41 |
|
ashimema |
I think that's tcohen's aim :) |
| 13:41 |
|
magnuse |
@confetti! |
| 13:41 |
|
huginn |
magnuse: I'll give you the answer as soon as RDA is ready |
| 13:41 |
|
magnuse |
confetti! |
| 13:41 |
|
wahanui |
somebody said confetti was https://31.media.tumblr.com/f5[…]1tt9lrzo6_250.gif |
| 13:42 |
|
tcohen |
jajm++ ashimema++ khall++ Joubu++ |
| 13:45 |
|
magnuse |
yeah! jajm++ ashimema++ khall++ Joubu++ |
| 13:46 |
|
tcohen |
koha++ |
| 13:47 |
|
cait |
ashimema: don't forget members |
| 13:48 |
|
cait |
ashimema: we have borrowers members fromt he original codebase (NZ?) and then patrons because AE i think... and... I do't want to think too much about it |
| 13:49 |
|
ashimema |
hehe.. |
| 13:49 |
|
ashimema |
true.. had forgotten members |
| 13:50 |
|
ashimema |
users is the most sensible collective term I believe.. it's certainly what the majority of web apps out there use ;) |
| 13:50 |
|
tcohen |
we should stick with inetOrgPerson :-P |
| 13:51 |
|
ashimema |
lol |
| 13:51 |
|
* ashimema |
slaps tcohen with a wet fish |
| 13:51 |
|
tcohen |
:-P |
| 13:55 |
|
magnuse |
HumanEntity? |
| 13:56 |
|
tcohen |
magnuse: really? would you exclude martians? you racist |
| 13:56 |
|
tcohen |
:-P |
| 13:56 |
|
ashimema |
what about bots magnuse ;) |
| 13:56 |
|
misilot |
or service accounts |
| 13:57 |
|
tcohen |
yeah, and cats? what about cats???? |
| 13:57 |
|
* tcohen |
stops making sily jokes and goes congratulate Joubu for another bug fixed |
| 14:01 |
|
Joubu |
from bug 14778: http://bugs.koha-community.org[…]44003&action=diff |
| 14:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=14778 major, P5 - low, ---, jonathan.druart, Pushed to Master , DBIC should create/own the DB handler |
| 14:01 |
|
Joubu |
this is quite unexpected... |
| 14:02 |
|
magnuse |
oops |
| 14:03 |
|
|
mario joined #koha |
| 14:07 |
|
cait |
khall: did you see my notes on the glyphicon/font awesome patch - do you think it woudl be hard to update us to 4.4? |
| 14:08 |
|
khall |
I'll check on that in a bit, putting out a fire atm! |
| 14:08 |
|
cait |
ouch |
| 14:08 |
|
cait |
ok... someone else thinking about the IT crowd episode with the fire now? |
| 14:09 |
|
magnuse |
nope :-) |
| 14:17 |
|
|
andreashm joined #koha |
| 14:18 |
|
|
JoshB joined #koha |
| 14:19 |
|
* andreashm |
is back - does the usual waving |
| 14:20 |
|
ashimema |
Joubu I don't follow.. |
| 14:20 |
|
ashimema |
what's that about bug 14778 |
| 14:20 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=14778 major, P5 - low, ---, jonathan.druart, Pushed to Master , DBIC should create/own the DB handler |
| 14:20 |
|
ashimema |
oooh.. |
| 14:20 |
|
ashimema |
how on earth did I miss that then? |
| 14:21 |
|
ashimema |
I see now.. it's a followup after all the passed qa checks |
| 14:21 |
|
magnuse |
cait: now i do https://www.youtube.com/watch?v=1EBfxjSFAxQ |
| 14:21 |
|
ashimema |
did it actually cause a bug? |
| 14:21 |
|
tcohen |
ashimema: the followup makes the tests pass |
| 14:22 |
|
* ashimema |
prefers the result anyways.. means not having to hit the database at all too :) |
| 14:22 |
|
tcohen |
yeah .-D |
| 14:23 |
|
tcohen |
we should have a bug for doing that move in the codebase |
| 14:23 |
|
tcohen |
umbrella bug |
| 14:23 |
|
ashimema |
indeed |
| 14:23 |
|
ashimema |
though I wonder how often it actually appears |
| 14:23 |
|
ashimema |
I wouldn't have expected it |
| 14:24 |
|
pastebot |
"tcohen" at 172.16.248.212 pasted "ashimema: not too much, though" (12 lines) at http://paste.koha-community.org/137 |
| 14:24 |
|
cait |
magnuse: and you will never forget again :) |
| 14:24 |
|
cait |
magnuse: fire exlamation mark |
| 14:24 |
|
|
JoshB joined #koha |
| 14:26 |
|
magnuse |
cait: tanks :-) |
| 14:26 |
|
tcohen |
c'mon jenkins |
| 14:29 |
|
huginn |
New commit(s) kohagit: Bug 14982: Remove C4::Dates from guided report wizard and dictionary <http://git.koha-community.org/[…]d851d7b042ad368ac> / Bug 14961: Remove C4::Dates from files reports/*_stats.pl <http://git.koha-community.org/[…]aaa6efaeb49eeec98> / Bug 14824: Fix sorting of Norwegian vowels <http://git.koha-community.org/gitweb/? |
| 14:29 |
|
cait |
khall: did you file a but about problems with label sample data or did i imagine that? |
| 14:29 |
|
khall |
yes |
| 14:29 |
|
cait |
can you find it? |
| 14:29 |
|
cait |
i think 15064 might be duplicate |
| 14:29 |
|
khall |
http://bugs.koha-community.org[…]_bug.cgi?id=15053 |
| 14:29 |
|
huginn |
Bug 15053: major, P5 - low, ---, kyle.m.hall, Needs Signoff , sample_creator_data.sql now fails during a fresh install |
| 14:30 |
|
cait |
you could have put the word label in there :P |
| 14:30 |
|
cait |
...and i could have searched with creator :) |
| 14:30 |
|
khall |
sorry! go ahead an update the title ; ) |
| 14:33 |
|
* magnuse |
cheers everyone on, then scampers off to make dinner |
| 14:33 |
|
|
mveron-away joined #koha |
| 14:33 |
|
mveron-away |
Hi #koha |
| 14:33 |
|
tcohen |
hi mveron |
| 14:34 |
|
mveron |
hi tcohen :-) |
| 14:34 |
|
tcohen |
nice job with C4::Dates |
| 14:34 |
|
tcohen |
;-) |
| 14:34 |
|
mveron |
Thanks. Hope we get it through... |
| 14:34 |
|
mveron |
Everybody ++ |
| 14:35 |
|
tcohen |
mveron: there's no reason for that not to happen |
| 14:35 |
|
mveron |
Great! |
| 14:36 |
|
* mveron |
counts: 11 sign-offs left, 4 QAed |
| 14:51 |
|
|
saiful joined #koha |
| 14:55 |
|
tcohen |
is UNIMARC people aware that Koha's tests are mostly MARC21 only? |
| 15:00 |
|
|
francharb joined #koha |
| 15:06 |
|
|
TGoat joined #koha |
| 15:17 |
|
|
pianohacker joined #koha |
| 15:17 |
|
pianohacker |
morning |
| 15:23 |
|
pianohacker |
cait: working on rancor |
| 15:28 |
|
pianohacker |
cait: which browser were you using to test? |
| 15:29 |
|
cait |
firefox |
| 15:29 |
|
cait |
in ubuntu |
| 15:30 |
|
pianohacker |
cait: weird... the syntax was wrong, and I've corrected the wiki, but I can't repro the issue with the macro editor |
| 15:30 |
|
pianohacker |
could I ask you to check your developer console? |
| 15:30 |
|
cait |
not right now |
| 15:30 |
|
cait |
later |
| 15:30 |
|
cait |
- the laptop is at home :) |
| 15:31 |
|
pianohacker |
I'll see if I can find a way to reproduce it, we're racing the clock |
| 15:38 |
|
|
fedegin joined #koha |
| 15:59 |
|
* cait |
keeps fingers crossed |
| 16:10 |
|
|
fridolin left #koha |
| 16:23 |
|
|
vfernandes joined #koha |
| 16:23 |
|
vfernandes |
hi :) |
| 16:23 |
|
vfernandes |
i'm having a little problem when pritting patron cards using Windows Acrobat Reader |
| 16:24 |
|
vfernandes |
the card has the patron card image... when printing it's says insufficient data for image |
| 16:29 |
|
Joubu |
@later tell tcohen it took me ages but I think I have fixed the upload file issue on bug 15032. Please apply it on the test server |
| 16:29 |
|
huginn |
Joubu: The operation succeeded. |
| 16:30 |
|
pianohacker |
bug 15032 |
| 16:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15032 major, P5 - low, ---, jonathan.druart, Needs Signoff , Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import |
| 16:30 |
|
pianohacker |
oh yeah, that |
| 16:30 |
|
wahanui |
yeah, that is cool - a way to enhance the OPAC without bloating Koha... |
| 16:31 |
|
pianohacker |
Joubu++ |
| 16:36 |
|
Joubu |
@later tell tcohen erk, it's not :-( |
| 16:36 |
|
huginn |
Joubu: The operation succeeded. |
| 16:42 |
|
pianohacker |
plack in general seems to have weird issues with things that fork... |
| 16:45 |
|
mveron |
vfernandes: What Koha version? Just for some images or for all images? |
| 16:46 |
|
reiveune |
bye |
| 16:46 |
|
|
reiveune left #koha |
| 16:46 |
|
mveron |
vfernandes: ...and what image formats? |
| 16:50 |
|
gaetan_B |
bye |
| 16:55 |
|
|
saiful joined #koha |
| 16:56 |
|
vfernandes |
mveron... koha 3.16 |
| 16:56 |
|
vfernandes |
i think the images are in JPEG |
| 17:02 |
|
|
laurence left #koha |
| 17:05 |
|
Joubu |
pianohacker: do you know how we could fix that? |
| 17:06 |
|
mveron |
vfernandes: We had some image problems fixed with Bug 13954 (Pushed to master this summer). |
| 17:06 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13954 normal, P4, ---, cnighswonger, Pushed to Master , Patroncards: images show inadequate rough pixelation |
| 17:06 |
|
mveron |
vfernandes: Do you have the problem wit all cards / images or just with some? |
| 17:06 |
|
mveron |
with |
| 17:07 |
|
vfernandes |
i've only tested a few patrons |
| 17:07 |
|
vfernandes |
all with the same problem |
| 17:09 |
|
pianohacker |
Joubu: no idea... I think we're out a bit in the woods, doesn't seem like many people know how |
| 17:22 |
|
cait |
khall: thx for the follow-ups |
| 17:22 |
|
cait |
khall: do you agree with my choices? |
| 17:22 |
|
cait |
bit worried people won't like :) |
| 17:22 |
|
khall |
cait: absolutely! Thanks for your followups! |
| 17:22 |
|
khall |
I think they all look very good |
| 17:23 |
|
cait |
mostly worried about the holds one |
| 17:23 |
|
cait |
but we will see - and opac remains for now |
| 17:24 |
|
khall |
cait: I think the sticky-note-o looks like a good replacement! Now that I've updated the patch to FA 4.4 you should be able to use that icon |
| 17:24 |
|
pianohacker |
we have fontawesome now? |
| 17:24 |
|
khall |
pianohacker: it's passed qa |
| 17:24 |
|
pianohacker |
sweet |
| 17:27 |
|
|
Dyrcona joined #koha |
| 17:29 |
|
Joubu |
see you tomorrow #koha! |
| 17:32 |
|
cait |
bye Joubu! |
| 17:33 |
|
cait |
iwill try to take a look |
| 17:33 |
|
cait |
at the 4.4 :) |
| 17:52 |
|
cait |
bye all |
| 17:52 |
|
|
cait left #koha |
| 17:55 |
|
|
paul_p joined #koha |
| 18:29 |
|
|
francharb joined #koha |
| 18:48 |
|
|
Stompro joined #koha |
| 18:58 |
|
|
magnuse joined #koha |
| 19:14 |
|
magnuse |
enjoy your lunch TGoat_Lunch |
| 19:15 |
|
TGoat_Lunch |
thanks magnuse :) |
| 19:22 |
|
|
cait joined #koha |
| 19:25 |
|
magnuse |
kia ora cait |
| 19:26 |
|
* cait |
waves |
| 19:37 |
|
|
kathryn joined #koha |
| 19:38 |
|
kathryn |
hi everyone |
| 19:40 |
|
magnuse |
hiya kathryn |
| 19:40 |
|
kathryn |
hi magnuse :) |
| 19:50 |
|
|
meliss joined #koha |
| 19:54 |
|
|
tcohen joined #koha |
| 19:55 |
|
|
northcottc joined #koha |
| 19:56 |
|
cait |
hiya kathryn :) |
| 20:01 |
|
cait |
pianohacker: around? |
| 20:02 |
|
kathryn |
hey cait :) |
| 20:07 |
|
pianohacker |
cait: back |
| 20:08 |
|
cait |
ok |
| 20:08 |
|
cait |
time for me to log back into koha |
| 20:08 |
|
pianohacker |
por favor kooooha |
| 20:40 |
|
bag |
@later tell tcohen - alright I’m back from vacation - I saw I missed I a message from you - So here’s a response - HI THERE |
| 20:40 |
|
huginn |
bag: The operation succeeded. |
| 20:41 |
|
cait |
hi bag |
| 20:41 |
|
bag |
hi cait |
| 20:42 |
|
magnuse |
bag: HI |
| 20:42 |
|
bag |
hi magnuse |
| 20:50 |
|
magnuse |
<sup>5</sup> |
| 20:52 |
|
cait |
bag: torturing pianohacker |
| 20:52 |
|
bag |
excellent :) |
| 20:53 |
|
cait |
hebrew+cyrillic records |
| 20:53 |
|
cait |
*muhaaha* heh |
| 21:09 |
|
TGoat |
hey #koha anyone have knowledge or experience with bibliocommons as a discovery layer for Koha? |
| 21:15 |
|
|
JoshB joined #koha |
| 21:19 |
|
|
Francesca joined #koha |
| 21:33 |
|
cait |
bug 11559 - passed qa |
| 21:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=11559 enhancement, P5 - low, ---, jweaver, Passed QA , Professional cataloger's interface |
| 21:34 |
|
pianohacker |
cait++ |
| 21:34 |
|
pianohacker |
wnickc++ |
| 21:34 |
|
cait |
yep wnickc++ |
| 21:34 |
|
cait |
brave_testing_librarians++ |
| 21:34 |
|
pianohacker |
amen to that |
| 21:38 |
|
cait |
still need sign offs on the C4::Dates patches! |
| 21:38 |
|
cait |
http://bugs.koha-community.org[…]_bug.cgi?id=14870 |
| 21:38 |
|
huginn |
Bug 14870: enhancement, P5 - low, ---, veron, ASSIGNED , Delete C4/Dates.pm from System |
| 21:39 |
|
* Francesca |
waves |
| 21:40 |
|
pianohacker |
cait: these are feature-freeze eligible, right? I'll happily sign off today, but I think it may be after you go to bed |
| 21:41 |
|
pianohacker |
(as opposed to feature-slush) |
| 21:41 |
|
cait |
i think so |
| 21:41 |
|
cait |
th depending feature is marked candidate |
| 21:41 |
|
pianohacker |
kk, will do then |
| 21:41 |
|
cait |
some will help already |
| 21:41 |
|
cait |
and it's nice to get that cleaned up |
| 21:41 |
|
cait |
big project |
| 21:42 |
|
pianohacker |
yeah |
| 21:43 |
|
* mveron |
waves to cait |
| 21:43 |
|
* cait |
waves back at mveron |
| 21:43 |
|
mveron |
everybody helping with C4::Dates ++ :-) |
| 21:44 |
|
cait |
.. have to admit, thereis something in it for me too... german date formatting :) |
| 21:45 |
|
mveron |
...and the swiss one... ...and in south america as well I was told... |
| 21:45 |
|
cait |
:) |
| 21:47 |
|
pianohacker |
is yyyy.mm.dd german date formatting? |
| 21:47 |
|
cait |
almost |
| 21:47 |
|
pianohacker |
dd.mm.yyyy sorry |
| 21:47 |
|
cait |
dd.mm.yyyy |
| 21:47 |
|
pianohacker |
interesting... |
| 21:47 |
|
wahanui |
interesting is, like, sometimes good and sometimes bad |
| 21:47 |
|
pianohacker |
yeah, that applies to date formats, wahanui |
| 21:47 |
|
wahanui |
pianohacker: huh? |
| 22:03 |
|
|
liz joined #koha |
| 22:39 |
|
|
cdickinson joined #koha |
| 22:39 |
|
|
chrisvella joined #koha |
| 22:39 |
|
|
BobB joined #koha |
| 22:50 |
|
mveron |
Good night / daytime #koha |
| 22:51 |
|
|
chrisvella joined #koha |
| 23:16 |
|
|
cait left #koha |
| 23:48 |
|
|
papa joined #koha |
| 23:50 |
|
irma |
Hi papa. How are you doing? Might you be coming to Sydney soon? |
| 23:55 |
|
papa |
Hi there! |
| 23:56 |
|
papa |
not too bad, thanks. not sure, maybe end of Nov. Anything exciting happening? |
