IRC log for #koha, 2015-08-28

All times shown according to UTC.

Time S Nick Message
00:40 TGoat left #koha
01:21 francesca joined #koha
01:26 JoshB joined #koha
02:06 trea joined #koha
02:17 trea joined #koha
02:24 mario joined #koha
02:43 eythian for those that care about it:
02:43 eythian > libswagger2-perl_0.31-1_amd64.changes ACCEPTED into unstable, unstable
03:09 francesca my computer is ready to be picked up
03:09 francesca yay!
03:09 mtj nice one eythian++
03:10 mtj francesca, is it a new computer?
03:10 francesca no my macbook pro display broke last week
03:10 francesca its been in for repairs
03:13 mtj curious... did you drop/bang it? or did it just stop working?
03:15 francesca it just stopped working
03:17 mtj make sure you get the 'dead' part back from the shop, too
03:18 * mtj adjusts tinfoil hat
03:20 francesca oh ok
03:20 francesca what is the use in getting back the dead part?
03:20 francesca does looking at it tell you something about what went wrong?
03:25 mtj yeah.. the part may still be working
03:27 wizzyrea you must have experience with this?
03:29 mtj yep, and had friends that worked in laptop service companies
03:37 wizzyrea ew
03:37 wizzyrea you mean like fraudulent part replacements
03:37 wizzyrea i.e. "this is not working, we'll replace your working one that came unplugged with a new one $500 please" sort of thing?
03:38 mtj yeah, thats the one wiz
03:38 wizzyrea bleh
03:38 mtj my sister has had similar experiences with car/auto shops too
03:39 wizzyrea generalising wildly, women have a bad time at car repair shops.
03:39 wizzyrea unless you go in having done your research
03:40 mtj ..having perfectly good brake hoses replaced, without consent
03:40 wizzyrea so when they tell you your flubberwutzle is congulmerated
03:40 wizzyrea you can be like, no, I really just need a cam belt thanks.
03:40 mtj my dad installed them, only a few months earlier
03:40 wizzyrea ugh.
03:41 wizzyrea flubberwutzle.
03:41 wizzyrea I make myself laugh.
03:41 mtj dad made the manager inspect them, from the rubbish bin
03:41 eythian you probably were out of headlight fluid though
03:42 mtj lol eythian
03:44 mtj i tragically had a laptop declared dead by a service shop
03:45 mtj my brother 'fixed' it about 5 years later... by plugging in a random power supply into it?!
03:46 mtj ..turns out it just had a bad power supply :/
03:47 mtj i doubt whether the shop even looked at it
03:47 wizzyrea yeah, I had a shop do the same with an alternator once
03:47 wizzyrea they told me it was bad, that I'd need a new one
03:48 wizzyrea my dad said "well I can replace an alternator" so we went to the parts store and bought one
03:48 wizzyrea he installed it in the parking lot, took the old one in to get a free alternator test
03:48 wizzyrea ...the alternator was fine.
03:48 wizzyrea he went back to the shop, and made them pay him for the new alternator.
03:49 mtj yeap :/
03:49 wizzyrea something like "this is what you get for trying to cheat young women"
03:49 wizzyrea good guy my dad :)
03:50 wizzyrea on reflection, he probably should have made me go in there to demand the money, but I think he knew that they would hassle me and not him.
03:52 mtj another friend told me that his co-worker would tell customers their items were broken... in the hope they wouldnt bother picking up the item from the store
03:52 mtj .. he'd then take the item home, for himself :/
03:53 francesca woaaaaah
03:53 francesca just came back to an avalanche of messages
03:53 * francesca needs to pay more attention to IRC
03:58 eythian you'll soon learn it's not a requirement to read everything, or all you'll ever be doing is reading everything :)
03:59 wizzyrea this is a key to pretty much all online things.
04:09 francesca lol
05:32 rocio left #koha
06:00 francesca joined #koha
06:00 francesca bye #koha
06:28 marcelr joined #koha
06:29 marcelr hi #koha
06:38 reiveune joined #koha
06:38 reiveune hello
06:38 wahanui privet, reiveune
06:38 Viktor joined #koha
06:44 marcelr hi reiveune
06:44 reiveune salut marcelr
06:49 * magnuse waves
06:50 magnuse @wunder boo
06:50 huginn magnuse: The current temperature in Bodo, Norway is 18.0°C (8:20 AM CEST on August 28, 2015). Conditions: Mostly Cloudy. Humidity: 68%. Dew Point: 12.0°C. Pressure: 29.30 in 992 hPa (Falling).
06:50 magnuse lots of wind though
06:51 p_vdk joined #koha
06:54 p_vdk left #koha
06:56 alex_a joined #koha
06:56 alex_a bonjour
06:56 wahanui niihau, alex_a
06:57 sophie_m joined #koha
06:58 marcelr hi magnuse and alex_a
07:01 magnuse hiya alex_a marcelr
07:02 alex_a hi marcelr
07:11 codavid joined #koha
07:11 codavid left #koha
07:15 alex_a_ joined #koha
07:16 Jul joined #koha
07:17 Joubu hi
07:17 Joubu rangi: around?
07:17 marcelr bonjour Joubu
07:17 Joubu Hello marcelr
07:18 putti joined #koha
07:18 putti Hello ! :)
07:18 marcelr hi putti
07:18 Joubu @later tell rangi agout the 4.x version in HEA, you could ask a BibLibre guys to have a look in the DB directly and know some library details (last update, date of creation, etc.)
07:18 huginn Joubu: The operation succeeded.
07:21 cait joined #koha
07:21 putti Heh, yesterday got my first patch to master :P But then after that got ~5 messages about build failing xD
07:23 cait morning #koha
07:24 putti cait, good morning :)
07:24 marcelr hi cait
07:27 putti Joubu, bug 13618 ready for signing-off?
07:27 huginn Bug[…]_bug.cgi?id=13618 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Prevent XSS in the Staff Client and the OPAC
07:27 magnuse kia ora cait
07:28 magnuse wow 251 libraries in hea!
07:29 cait hi putti, magnuse  and marcelr  :)
07:29 cait second day of the workshop here - now learning more about kuali ole
07:29 Joubu putti: if the status is "Needs Signoff", yes it is :)
07:30 putti Ok, looks like lots of reviewing is gonna happen soon :D
07:30 putti There's like ~13 patches
07:30 Joubu putti: that whas not your fault  :)
07:31 Joubu yes 13 patches and there *are* bugs and so, more patches
07:35 * cait cheers putti on
07:35 putti Joubu, I cannot apply 14416 because 3-way merge
07:35 putti should I do some merging myself :D
07:36 putti Wait.. It says it has applied it already
07:36 putti interesting
07:36 wahanui interesting is sometimes good and sometimes bad
07:36 putti hahah :D
07:37 Joubu usually the merge is quite easy: keep master and remove the html filters
07:39 putti Joubu, now I now why it says the patch is already applied: 14416 is already in master
07:39 putti Can we remove the dependency now?
07:39 putti or no, because it might go to some other branches?
07:40 putti know*
07:41 putti bug 14418 is also in master
07:41 Joubu keep the deps, and don't apply it
07:41 huginn Bug[…]_bug.cgi?id=14418 major, P5 - low, ---, oleonard, Pushed to Stable , XSS Flaws in OPAC Interface
07:41 putti ok
07:41 Joubu just apply 13618
07:41 Joubu on to topmaster
07:41 Joubu on top of master
07:42 putti Why that?
07:42 Joubu putti: ? why what?
07:42 wahanui ? why are you asking ?
07:42 putti oh.. XD
07:42 Joubu putti: you want to test 13618, all the deps is in master, so just apply it
07:43 Joubu are!
07:43 putti I was like it's not in the dependencies list, but then I realized that it is "the" bug
07:43 putti :-)
07:54 p_vdk joined #koha
07:55 p_vdk left #koha
07:56 putti with git bz can I attach many patches to one comment?
07:58 cait you can do it in one command
07:58 cait but it will generate multiple comments again for each one
07:59 putti Can I edit all those comments seperately?
07:59 putti cait, which command is it ?
08:00 drojf joined #koha
08:00 drojf morning #koha
08:00 drojf @wunder berlin, germany
08:01 huginn drojf: The current temperature in Berlin Tegel, Germany is 15.0°C (9:50 AM CEST on August 28, 2015). Conditions: Mostly Cloudy. Humidity: 88%. Dew Point: 13.0°C. Pressure: 30.01 in 1016 hPa (Rising).
08:01 drojf next week >30 again. this summer is crazy
08:03 cait :(
08:03 cait now i want to stay here
08:03 drojf instead of going where?
08:03 drojf or, where are you? :)
08:04 cait in copenhagen
08:04 magnuse @wunder cph
08:04 huginn magnuse: The current temperature in Copenhagen, Denmark is 17.0°C (9:50 AM CEST on August 28, 2015). Conditions: Scattered Clouds. Humidity: 68%. Dew Point: 11.0°C. Pressure: 29.89 in 1012 hPa (Steady).
08:04 magnuse @wunder boo
08:04 huginn magnuse: The current temperature in Bodo, Norway is 17.0°C (9:50 AM CEST on August 28, 2015). Conditions: Mostly Cloudy. Humidity: 77%. Dew Point: 13.0°C. Pressure: 29.30 in 992 hPa (Steady).
08:32 andreashm joined #koha
08:33 * andreashm waves
08:35 drojf hi andreashm
08:35 magnuse tjänare andreashm
08:35 drojf hei magnuse
08:35 magnuse moin drojf
08:35 magnuse ncip! ncip! ncip!
08:36 andreashm hi drojf, magnuse!
08:36 drojf i bet that is norwegian to attract animals
08:36 cait andreashm: can you paste the link to the viola video for me? :)
08:37 andreashm ok course =)
08:37 andreashm
08:37 drojf thanks :)
08:37 drojf andreashm: can you open source it for me? :)
08:37 andreashm it's coming
08:37 andreashm hopefully october
08:38 drojf nice :)
08:38 cait heh, i am adding pressure by telling lots of people about it :)
08:38 cait we got a break now - brb
08:38 andreashm haha
08:39 magnuse drojf: yeah, if you go out into the woods and shout that, the moose will come flocking
08:40 drojf lol that's what i was thinking. that or puffins
08:40 magnuse nah, we use dogs to catch the puffins
08:40 * magnuse actually has a puffindog
08:40 * magnuse used to have three
08:40 drojf i know, i would have never heard of puffins otherwise ;)
08:41 magnuse ah
08:43 drojf meeting is on 9 september, right? i should prepare the voting thing somewhen
08:50 mveron joined #koha
08:51 mveron Hi #koha
08:51 drojf hi mveron :)
08:51 mveron hi drojf :-)
08:51 drojf long time no see
08:52 mveron drojf:yes, indeed...
08:53 drojf how are things in allschwil?
08:53 mveron @wunder allschwil
08:53 huginn mveron: The current temperature in Bern-Belp, Switzerland is 23.0°C (10:50 AM CEST on August 28, 2015). Conditions: Clear. Humidity: 65%. Dew Point: 16.0°C. Pressure: 30.12 in 1020 hPa (Steady).
08:53 drojf or did you never return from vacation? :)
08:53 cait joined #koha
08:53 andreashm_ joined #koha
08:54 mveron drojf: I did, but I had a lot of work waiting for me...
08:54 drojf yes, returning is the worst part of vacation
08:54 * cait waves at mveron
08:54 mveron Hi cait :-)
08:55 cait :)
09:01 cait hi Viktor :)
09:17 marcelr mveron++
09:19 mveron marcelr ++
09:19 mveron :-)
09:19 marcelr mveron: you could just add a follow-up for some small corrections
09:19 marcelr easier to check
09:21 mveron I amended because I did not want to increase the nuber of patches ... But I will do follow-ups now.
09:21 mveron number
09:21 marcelr just one followup please
09:21 * mveron has a meeting
09:21 marcelr this report should not have had so many patches
09:25 mveron marcelr: Ok, will wait and then do one follow-up
09:26 * mveron will be back in teh afternoon
09:40 lari Are there any other pages where staff members can view messages from message_queue other than members/ ?
09:41 magnuse lari: don't think so, but you can create custom reports
09:44 lari I see, I did not yet know about this :) Thanks magnuse
09:50 cait lari: we also use a custom report for that - with the option to look only at the notices for a specific day
09:51 cait seems to work well
09:58 andreashm joined #koha
10:13 drojf1 joined #koha
10:50 putti Joubu, what's the idea with this: Bug 13618: Remove html filters at the OPAC
10:50 huginn Bug[…]_bug.cgi?id=13618 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Prevent XSS in the Staff Client and the OPAC
10:51 putti Joubu, oh I see you had already some discussion in the bug comments. Let mee see them first.
10:52 Joubu yes please :)
11:18 andreashm joined #koha
11:19 cait joined #koha
11:19 Viktor joined #koha
11:21 cdickinson joined #koha
11:50 Francesca joined #koha
11:52 meliss joined #koha
12:01 magnuse having trouble setting up koha and ldap - is there some way to get logging anywhere?
12:07 cait magnuse: i could ask my coworker - but not before monday :(
12:08 nengard joined #koha
12:12 magnuse cait: better than nothing :-)
12:12 magnuse kia ora nengard
12:12 magnuse aka crazy cat lady ;-)
12:14 cait magnuse: i can ask how he finds out if something goes wrong
12:14 cait but no guarantees :)
12:14 tcohen joined #koha
12:14 tcohen morning
12:15 tcohen @seen marcelr
12:15 huginn tcohen: marcelr was last seen in #koha 2 hours, 53 minutes, and 10 seconds ago: <marcelr> this report should not have had so many patches
12:16 cait hi tcohen  :)
12:16 tcohen hi cait
12:16 Dyrcona joined #koha
12:19 nengard morning magnuse and all
12:20 tcohen hi nengard
12:26 magnuse cait: that would be super awesome!
12:27 drojf joined #koha
12:28 mveron joined #koha
12:33 putti Joubu, how did you do this patch: Bug 13618: Specific for other prefs ?
12:33 huginn Bug[…]_bug.cgi?id=13618 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Prevent XSS in the Staff Client and the OPAC
12:33 putti Did you generated it or one by one basis?
12:37 Joubu putti: I don't it, it does not apply ?
12:37 Joubu putti: you should use the remote branch from my github account
12:37 tcohen putti: what was your real life name?
12:37 putti Joubu, you don't it?
12:37 Joubu get*
12:37 putti tcohen, Joonas
12:37 tcohen oh, hi Joonas
12:37 tcohen :-D
12:38 tcohen tests failing has nothing to do with your commit
12:38 putti Well, hello! :)
12:38 putti tcohen, Good to hear that!
12:38 putti Joubu, it applied, and worked
12:39 Joubu putti: the only change is in
12:39 Joubu [% SET OPACMySummaryNote = Koha.Preference('OPACMySummaryNote').raw %] didn't work
12:39 Joubu [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote').raw %][% END %] works great
12:40 putti Joubu, Are we talking about the patch "Specific for other prefs" ?
12:40 Joubu yes
12:41 putti Joubu, ok.. but i was just asking how did you do this patch.
12:41 Joubu how?
12:41 Joubu with my keyboard?
12:41 putti :D
12:41 putti Did you use some script to add the .raws?
12:41 Joubu no
12:41 Joubu git grep SysPrefName
12:41 cait guess we should keep the .raw in mind for documenation later :)
12:42 putti ok
12:43 cait should we check the csv exports and similar as well?
12:43 Joubu putti: actually it was a bit better: vim `grep -Ril SysPrefName **/*.tt **/*.inc | grep "\/en\/"`
12:43 cait the ones based on TT templates?
12:43 putti Joubu, oh, how about the other languages
12:43 Joubu should we expect html tag in csv?
12:44 Joubu the other languages are not in the git repo
12:44 putti oh, and the syspref names are the same...
12:44 putti so never mind :D
12:44 cait Joubu: not really, was more thinking about weird charactrs in general.. like < in a title
12:44 Joubu didn't think about that...
12:45 cait i have to...
12:45 Joubu Could be added to the csv files also indeed (if you confirm the bug)
12:45 cait we have alot of <> in corporate names still here
12:45 cait and in other places
12:46 cait can't test right now - still stuck with the windows laptop at the workshop
12:46 cait but iwill try to keep it in mind
12:49 cait hm what other places do we have that are non html
12:49 cait reports?
12:49 wahanui somebody said reports was[…]L_Reports_Library
12:49 cait report exports i mean?
12:49 cait i am not sure how they are done, probably no TT involved
12:50 Joubu I don't think so
12:50 cait hm cart emails maybe? it's kind of weird magic going on there with TT and text
12:50 cait when we fixed their translatability
12:53 tcohen cait: whould you say "add a fee" or is it "charge a fee"?
12:53 cait hm
12:53 cait i think charge sounds better... but you are aware that i am german? :)
12:53 cait charge seems more specific
12:53 cait in which context?
12:53 tcohen "add a fee when a patron changes to a category"
12:54 tcohen gmcharlt: opinion?
12:54 cait charge a fee automatically when a patron changes to a another category?
12:54 cait something like this?
12:54 * gmcharlt reads up
12:54 * cait waves at gmcharlt
12:54 tcohen the syspref description for bug 13697
12:54 gmcharlt tcohen: "charge a fee"
12:54 huginn Bug[…]_bug.cgi?id=13697 enhancement, P5 - low, ---, christophe.croullebois, Passed QA , Syspref to not add a fee when a patron  changes to a category with enrolment fee
12:54 gmcharlt hi cait
12:54 tcohen thanks galen
12:55 tcohen gmcharlt: how was your vacation?
12:55 gmcharlt the vacation itself was great and super-geeky :)
12:55 cait he seemed quite busy on twitter :)
12:55 gmcharlt the germs I came back home with... not so much :/
12:55 tcohen indeed :-D
12:55 tcohen ouch
12:56 cait feel better!
12:57 gmcharlt thanks!
12:57 tcohen yeah, try to have some rest during the weekend, that always helps!
12:59 magnuse gmcharlt: did you go to GERMany?
13:00 gmcharlt magnuse: you know... I'm not sure I can give karma for that pun...
13:00 gmcharlt ;)
13:01 cait germs?
13:01 wahanui Germs originated in Germany, before rapidly spreading throughout the rest of the world.
13:02 * cait blames eythian for corrupting magnuse
13:02 magnuse ah, so they have spread to the rest of the world...
13:03 cait :P
13:03 magnuse gmcharlt: you should probably give me negative karma
13:03 Joubu putti: I will add your signed-off-by lines to the patches of my branch
13:04 putti Where's your branch on github
13:04 putti Can you link it
13:05 putti Joubu, btw I had to do some merging in order to apply the first signed-off patch.. I hope that's fine..
13:05 Joubu putti: on the bug report
13:05 Joubu comment 49
13:06 putti Found it. So much stuff there so it hid itself there
13:06 Joubu putti: added
13:07 Joubu I will test the baskets and shelves export
13:07 Joubu cait: and something else?
13:07 JoshB joined #koha
13:07 NateC joined #koha
13:12 jseplae joined #koha
13:12 tcohen can anyone help me figure how to make 00-testcritic.t pass on debian/templates/plack.psgi
13:15 putti Joubu, I guess I cannot change attachments name after it's in bugzilla (other than submitting it again)?
13:15 putti Because now my comment went to the title of the attachment
13:15 Joubu putti: edit > edit details
13:15 Joubu no, details > edit details
13:16 putti Cool! :)
13:17 cait Joubu: exports and emails is the one that come to my mind
13:18 cait i will try to think more about other odd things we might do
13:23 putti tcohen, what's the error?
13:24 tcohen it was missing use strict or use Modern::Perl
13:24 tcohen but i'm puzzled why koha.psgi is not making it fail
13:24 putti so now it passes?
13:24 tcohen it should
13:25 lari My library (using 3.16) is experiencing this problem described by pianohacker at[…]4-03-12#i_1404311 where invalid login at OPAC + page refresh produces broken page. I wonder how it was fixed?
13:27 * magnuse wanders off to make pizza
13:27 tcohen enjoy magnuse
13:27 * magnuse will
13:32 Joubu cait: how should be displayed "my title <test>" when sending a cart by email?
13:32 Joubu on master: "my title", with the patches: "my title <test>"
13:33 Joubu if the comment contains "<a href="a test">test</a>"
13:33 Joubu on master: "a test", with the patches: "<a href="a test">test</a>"
13:33 huginn New commit(s) kohagit: Bug 13791: (QA followup) fix perlcritic warning <[…]9c6e36cb59463920e> / Bug 11880: Select what has been selected before <[…]55681b1bf4ae92031> / Bug 11880: Select the barcode index by default then searching for label items. <
13:34 tcohen i'm about to push the wysiwyg html editor for the sysprefs patch
13:35 mario joined #koha
13:36 cma joined #koha
13:37 cait sorry discussion- have to pay attention here
13:39 mario joined #koha
13:43 huginn New commit(s) kohagit: Bug 14337: Add 2 more tests to be complete <[…]91c67fe1358a93609> / Bug 14337: Fix conflict with bug 9809 <[…]6a2d5ef02ca237089> / Bug 14337: AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when... <
13:49 Joubu putti: don't you use git-bz?
13:49 putti yes
13:49 tcohen so once i fixed the failing tests, XISBN service seems to fail on its own to make jenkins unhappy
13:51 Joubu putti: you shouldn't have anything to do on attaching the patches. Why do you change the description of the patches? :)
13:51 alex_a joined #koha
13:52 putti Joubu, because I add a test report ;-)
13:56 rocio joined #koha
13:59 amyjeankearns joined #koha
14:19 putti Joubu, the latest patch in xss thingie: In online catalog: [% OPACBaseURL.raw %] I guess the url could be without the raw?
14:20 putti and things like barcodes... Or should we do another bug report for these?
14:21 putti This bug could be just for doing it with the Template::Stash::AutoEscaping and keeping the functionality the same.
14:28 talljoy joined #koha
14:51 druthb_away joined #koha
14:52 atheia joined #koha
14:53 atheia Hi kohites :-)
14:53 atheia I have a question about
14:54 atheia I've got a situation were it would be useful for a dropbox created from authorized values, to contain an "empty" element.
14:55 atheia And I figure this could be generally useful — so I was playing with the idea of adding a parameter to to allow for the "empty" element to be added.
14:55 atheia Can anyone see a reason why that would be bad?
14:58 Joubu putti: it's what it does
14:58 Joubu If I have put the .raw on them, someone would ask me why :)
14:58 Joubu +not*
14:58 Joubu If I have not put the .raw on them, someone would ask me why :)
14:59 putti yes. I'm going to open a new bug for that
14:59 Joubu putti: I don't understand why it's a bug
14:59 putti because someone can do xss
14:59 Joubu atheia: let me check
15:00 Joubu putti: ha ok. So no :) because of the html2text filter
15:00 Joubu used in these page
15:00 putti I didn't know that there was one
15:00 atheia joubu: cheers!
15:01 putti but is it used in every single template in koha?
15:01 putti I guess not.
15:02 Joubu atheia: it won't be too bad. But for instance, my bsort2 (used on memberentry) has already an empty value
15:03 Joubu And I am sure some people did that, not to be forced to choose a value
15:03 Joubu putti: no, only on sending basket/shelf
15:03 putti Joubu, okay, I'll look forward to do the bug report if it looks like we need it.
15:05 atheia joubu: sorry — I don't quite follow; are you saying there is already a way to add an empty value to a authorized values <select>?
15:06 Joubu atheia: yep, go on admin/authorised_values
15:06 Joubu click on add new AV, don't fill anything, click save. Done :)
15:07 putti How do I enable email in Koha after I have setup postfix succesfully?
15:08 Joubu putti: nothing to do, emails are sent using the sendmail cmd
15:08 putti can I send the email address where the email is coming from?
15:08 putti Joubu, is it the  KohaAdminEmailAddress preference?
15:09 atheia Joubu: ah, right: but then you have a blank authorised value in the db, I was thinking more if you need to display a list of authorised values, but you also want to display a blank option — i.e. you want to keep the db authorised values without a blank, but want to display a blank to the end user.
15:09 atheia maybe my use case is a bit niche…
15:09 atheia :-)
15:09 Joubu putti: maybe
15:10 Joubu atheia: so 2 blank entries in the select? :)
15:10 Joubu How will you differ the 2 options?
15:10 putti Joubu, hey now it works!! :)
15:11 putti Joubu, It just took few minutes.
15:12 pianohacker joined #koha
15:12 atheia Joubu: Wait… I currently don't get any blank values in my authorised values select?
15:14 reiveune bye
15:14 reiveune left #koha
15:14 Joubu atheia: You won't if you don't have a blank AV defined
15:17 atheia Joubu: :-) Right, exactly: so I don't want to define a blank AV, but I want, in some cases to display a blank AV to the end user.
15:18 Joubu atheia: IMO it's a good idea. The only issue will be with install where a blanck AV is already defined, they will get 2 blanks.
15:19 tcohen Joubu: i forgot to re-do the entry for bug 14598
15:19 huginn Bug[…]_bug.cgi?id=14598 major, P5 - low, ---, tomascohen, Failed QA , itemtype is not set on statistics by C4::Circulation::AddReturn
15:19 Joubu atheia: OTOH it will be less adaptable
15:20 Joubu tcohen: that's why I have changed the status
15:20 atheia Joubu: Cool, so the default should be: don't add a blank, and if the param is passed to the .inc, then add a blank, selected value.
15:20 atheia Joubu: so any code not passing the parameter will work as it does now.
15:21 Joubu hum, not sure there is a difference
15:21 Joubu unless you want to create a new AV
15:22 Joubu If there is a blank entry, you will display it, in any case, with or without the param. So if the flag is set, you will have 2 blank entries
15:24 atheia Right, so devs should only invoke [% PROCESS 'av-build-dropbox' ... 'blank' %] (or whatever the param will be) if they have no blank AV, but want to display a blank value to the end user.
15:25 Joubu but the devs don't know if the users have a blank :p
15:25 atheia s/'av-build-dropbox'/''/
15:25 atheia ah. Now I'm with you :-)
15:26 atheia Yeah, I can see that this would fall down there.  Probably not worth implementing.
15:26 Joubu of you could... check if there is a blank.
15:26 Joubu s/of/or
15:26 atheia oh, now that's an option.
15:27 Joubu and you will have to create a pref, because some people would like to force their users to choose a value :)
15:27 Joubu that's why they didn't create a blank AV
15:27 atheia Right… going off this idea fast :-)
15:27 Joubu :)
15:28 atheia Joubu: thanks for rubber-ducking though :-)
15:29 Joubu de rien :) Sorry to have been so long to be understood
15:32 putti Joubu, can we rebase in 13618 some of the commits which add the .raws ?
15:33 putti I mean to be a one commit.
15:34 Joubu putti: no :) use the github branch
15:35 putti Can someone explain the whitespace here: bug 13961
15:35 huginn Bug[…]_bug.cgi?id=13961 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Option to include patron's total amount of fines in notices
15:35 putti Was it from some other commit?
15:36 mveron putti: The qa tools complained about the white space. I did a follow up to remove them. There where about 4 spaces in an line that otherwise is empty.
15:37 putti mveron, but how is it possible even if the commit didn't edit that line :D
15:37 putti mveron, or is git diff cheating us
15:38 mveron putti: I do not know...
15:38 mveron brb
15:51 Joubu putti: I confirm, your patch adds 4 spaces line 648
15:52 putti Joubu, but does your git diff show it?
15:53 Joubu my git diff does not show anything, everything is commited
15:54 Joubu that does not matter, it can happen to anyone you know :p
15:54 putti No but this is weird because with git diff it doesn't show
15:54 putti format-patch might have a bug...
15:54 Joubu I don't understand your "git diff"
15:55 putti git diff = tig diff
15:55 putti :-)
15:56 Joubu `git show HEAD` shows me a 4 red spaces
15:56 Joubu tig shows me "+   "
15:58 putti Why my git doesn't do that :(
15:58 Joubu git reset --hard origin/master; git bz apply 13961; git show HEAD;
15:59 Joubu it will show you
15:59 putti git config --global core.whitespace trailing-space,space-before-tab
15:59 putti git config --global apply.whitespace fix
15:59 putti can those do something?
16:00 putti git reset --hard origin/master; git bz apply 13961; git show HEAD; didn't show O.o
16:02 putti Weird problem.. but need to go now! Bye :)
16:02 Joubu I don't have any occurrence of whitespace in my git config, try and remove them
16:02 putti I will
16:02 Joubu Have to go too, have a good w-e #koha
16:02 tcohen jajm: if eythian builds master packages soon, we will be able to test the REST api using kohadevbox easily
16:03 putti Joubu, removed those whitespace things and now it shows the red spaces
16:04 putti We should remove the recommendation to put that line to gitconfig also in wiki
16:06 Joubu @later tell putti "You should remove the recommendation to put that line to gitconfig also in wiki"
16:06 huginn Joubu: The operation succeeded.
16:06 Joubu ;)
16:36 atheia left #koha
16:40 pianohacker_DND Joubu: apply.whitespace, maybe, but definitely not core.whitespace - then git diff --check stops working!
17:37 Callender joined #koha
17:47 jo joined #koha
18:19 tcohen magnuse: i'm basing it on debian/jessie64 vagrant box
18:45 tcohen @later tell eythian could you please provide updated packages for master? it is time to try the new plack-related scripts
18:45 huginn tcohen: The operation succeeded.
18:58 tcohen bye everyone
18:58 tcohen have a nice weekend #koha
19:12 ashimema joined #koha
21:10 nengard left #koha
21:19 tcohen joined #koha
21:21 tcohen hi
21:38 magnuse joined #koha
21:53 cdickinson joined #koha
22:07 JoshB joined #koha
22:17 bag hi tcohen
22:28 Francesca joined #koha
22:44 Francesca joined #koha
23:48 TGoat joined #koha

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary