IRC log for #koha, 2015-07-10

All times shown according to UTC.

Time S Nick Message
00:00 eythian no, I noticed that too
00:00 wizzyrea bad journalist. no cookie.
00:00 cdickinson when you think about it, it's amazing that didn't actually fall in
00:00 wizzyrea seriously.
00:00 wizzyrea manawatu standard is comedy gold today with headlines
00:01 wizzyrea Fork used on pork and ex-partner
00:01 wizzyrea ...what
00:01 wizzyrea New trampoline a nationwide first  < this has to be the onion.
00:02 cdickinson hehe
00:02 eythian welcome to rural news
00:02 wizzyrea I've lived in rural places.
00:02 indradg eythian: viavitae has just 2 techs... and none that is a CentOS expert.
00:03 wizzyrea I don't think I ever saw any headlines, much less 3 in one day, that were that special.
00:03 cdickinson http://www.stuff.co.nz/motorin[…]ple-speed-cameras - "Welcome to the 40kmh highway" on the Dominion Post homepage
00:03 cdickinson if that isn't clickbait, I don't know what is
00:03 eythian it's clickbait. The comments are all pretty mouthbreathery too
00:03 wizzyrea oh geez.
00:04 cdickinson "Is this a toll road in disguise?" 14 upvotes WTF
00:04 wizzyrea it is reasonably daft that the state highway has stoplights on it, and winds through a part of wellington with really pretty narrow streets.
00:04 wizzyrea BUT.
00:04 wizzyrea it's part of our charm. ;)
00:05 wizzyrea Also I don't drive, so anything is fine with me. :P
00:05 cdickinson haha
00:05 wizzyrea (note that I *can* drive, I just choose not to)
00:05 eythian I don't even really know why it's considered part of the highway. It goes ... to the airport! And stops.
00:05 wizzyrea ^ all of this.
00:05 eythian really, it should go to the ferry terminals, because you can put a car on them.
00:05 wizzyrea so reasonable.
00:05 eythian and then connect up with the other half of the highway
00:05 papa joined #koha
00:06 * wizzyrea nominates eythian for the road planning committee.
00:06 cdickinson yeah, people are divided on that point for sure
00:06 * eythian also doesn't have a car, so wouldn't be ideal :)
00:06 wizzyrea maybe it would be MORE ideal.
00:06 wizzyrea because you wouldn't have a car-first bias :)
00:07 cdickinson heh
00:07 eythian true :)
00:07 cdickinson I drive and I like cars, but I'm a pretty staunch supporter of public transport
00:07 wizzyrea Woman sentenced over stabbing ex-partner with fork after pork meal in car < this extended headline isn't much better than the shortened one.
00:08 eythian heh
00:08 wizzyrea why does it matter what the meal was.
00:08 wizzyrea you could just stop at "woman sentenced over stabbing ex-partner with fork"
00:08 cdickinson it doesn't even do a good job as clickbait
00:08 wizzyrea couldn't resist the rhyme I guess.
00:08 cdickinson I don't even care about clicking on it
00:08 wizzyrea ikr!
00:09 wizzyrea well I might click to find out about a fork-stabbing.
00:09 wizzyrea that might say something about me.
00:09 cdickinson heh
00:10 wizzyrea Cameras, light: explosion < seriously, that's getting into william carlos williams level of non-verbosity.
00:11 wizzyrea http://www.poets.org/poetsorg/[…]m/red-wheelbarrow
00:11 wizzyrea (for example)
00:13 drojf good night #koha
00:22 tcohen joined #koha
00:25 tcohen @wunder cordoba, argentina
00:25 huginn` tcohen: The current temperature in Bo Altos de San Martin - NW, Cordoba city, Cordoba City, Argentina is 12.6°C (9:24 PM ART on July 09, 2015). Conditions: Clear. Humidity: 50%. Dew Point: 2.0°C. Pressure: 29.95 in 1014 hPa (Steady).
00:29 Francesca joined #koha
00:30 Francesca I'm back
00:30 Francesca look rangi I've got a cold so I am just going to work from home today instead
00:31 cdickinson he's AFK
00:31 wizzyrea we'll let him know :)
00:31 cdickinson his kids are here anyway, so I'm not sure if you'd be able to sit anywhere haha
00:32 tcohen hi rangi
00:32 Francesca ok thanks guys
00:33 Francesca I'll just hang around on here for a bit, do some work and just chill
01:09 irma joined #koha
01:24 trea joined #koha
01:25 rangi bugzilla 5.0 is out
01:26 rangi https://www.bugzilla.org/relea[…]e-notes.html#feat
01:26 rangi i think ill do an upgrade
01:28 rangi that rest like interface will make my plan to do a pebble app for bugs.koha-community.org a lot more likely to actually happen
01:28 eythian ah cool
01:28 Francesca any websites I can work on?
01:28 eythian though, not sure I want even more notice about bugs :)
01:29 rangi heh i was thinking just the koha-security product
01:29 rangi actually the caching might be good too
01:33 eythian http://cube-drone.com/comics/c[…]tless-persistence <-- javascript problems/solutions
01:33 Francesca sooo no websites that need work done?
01:33 rangi not that i can think of
01:33 rangi you could maybe read a bit about bugzilla
01:33 rangi see how easy it is to theme?
01:34 JoshB joined #koha
01:36 Francesca buzilla isn't working atm
01:36 Francesca i went to the page and got this software errorThe ./data/params.json file does not exist. You probably need to run checksetup.pl. at Bugzilla/Config.pm line 350.
01:36 Francesca Compilation failed in require at /var/www/bugzilla3/index.cgi line 15.
01:36 Francesca BEGIN failed--compilation aborted at /var/www/bugzilla3/index.cgi line 15.
01:36 rangi https://www.bugzilla.org/docs/
01:36 rangi i meant hin here to see if it tells you how to theme it etc
01:37 Francesca ok cool
01:37 rangi ohh look at that now
01:37 rangi http://bugs.koha-community.org/bugzilla3/
01:37 rangi the common queries thing is cool
01:37 Francesca nice work
01:38 Francesca I just have this urge to try and make the colours match the other koha sites I've worked on
01:38 eythian wahanui: \you maniacs is <reply>\You blew it up! Ah, damn \you! God damn \you all to hell!
01:38 wahanui OK, eythian.
01:39 eythian wahanui: literal you maniacs
01:39 wahanui eythian: what?
01:39 eythian wahanui: literal maniacs
01:39 wahanui eythian: what?
01:39 eythian hmph
01:39 Francesca hahahahaha
01:39 wizzyrea oh! common queries!
01:39 wizzyrea neat!
01:40 Francesca I want to turn the page green
01:40 Francesca since green seems to be like kohas colour
01:40 wizzyrea if you made it kind of match the website that would be cool
01:40 wizzyrea (which is more white than green
01:40 wizzyrea )
01:41 Francesca I can do that
01:41 wizzyrea white/grey/green
01:41 Francesca yeah I've borrowed the website colour scheme before
01:41 wizzyrea :)
01:42 Francesca this is the website we're talking about right? http://koha-community.org/
01:45 wizzyrea yep
01:45 * Francesca wonders how to change the css
01:48 Francesca rangi is this the sort of thing you were thinking about?
01:48 Francesca Bugzilla supports skins - ways of changing the look of the UI without altering its underlying structure. It ships with two - "Classic" and "Dusk". You can find some more listed on the wiki, and there are a couple more which are part of bugzilla.mozilla.org. However, in each case you may need to check that the skin supports the version of Bugzilla you have.
01:48 Francesca this is from the documentation
01:52 rangi yep so you might have to see if you can figure out how to make skins
01:53 Francesca okey doke
01:53 Francesca new challange
01:53 Francesca fun
01:54 Francesca this is what basil says to do To create a new custom skin, make a directory that contains all the same CSS file names as skins/standard/, and put your directory in skins/contrib/. Then, add your CSS to the appropriate files.
01:54 Francesca omg autocorrect
01:54 Francesca stop it
01:55 Francesca so is there anyway I can look at these files? Do I install bugzilla on my laptop or something
01:57 rangi https://git.mozilla.org/?p=bug[…]lla.git;a=summary
01:57 rangi you should be able to clone that
01:58 Francesca ok. Never used this site before
01:58 * Francesca goes off to try and figure out where the clone option is
02:01 Francesca tried doing my usual clone thing
02:01 Francesca got this error
02:02 Francesca fatal: repository 'https://git.mozilla.org/?p=bug[…]la/bugzilla.git/'
02:02 wizzyrea no slash on the end maybe?
02:03 Francesca nope
02:03 Francesca same error
02:04 Francesca I couldn't actually find anything that said clone I just grabbed the url and went git clone insert_url_here
02:05 eythian that's not a git repo url
02:05 eythian that's a gitweb url
02:05 wizzyrea https://git.mozilla.org/bugzilla/bugzilla.git this one maybe?
02:05 wizzyrea (the one listed by URL)
02:05 Francesca 404 not found
02:05 wahanui well, 404 not found is http://www.masswerk.at/404
02:06 Francesca shh wahanui
02:06 wahanui I'M EXCERCISING MY ROBOT RIGHT TO FREE DATA TRANSMISSION
02:06 wizzyrea best.
02:06 Francesca hahahahaha
02:06 eythian https://bugzilla.readthedocs.o[…]alling/linux.html <-- 3.2.3
02:06 Francesca oh
02:06 Francesca thats linux
02:06 Francesca dammit
02:07 eythian https://bugzilla.readthedocs.o[…]ling/windows.html
02:07 eythian but windows is the Hard Way
02:07 Francesca I'm mac
02:07 Francesca not windows
02:08 eythian oh
02:08 eythian mac is probably also the hard way
02:08 Francesca everything is the hard wat
02:08 Francesca ah well
02:09 Francesca I'll work it out
02:09 eythian https://bugzilla.readthedocs.o[…]ing/mac-os-x.html
02:09 eythian (there's a theme with these links :)
02:09 eythian they all tell you where to check it out from git, anyway
02:10 Francesca yeah
02:10 Francesca new error
02:10 Francesca fatal: Remote branch release-X.X-stable not found in upstream origin
02:10 wizzyrea X is probably a variable
02:10 Francesca perhaps I better install git on here
02:10 eythian that's not what the error means
02:11 eythian read both the error and the instructions
02:11 eythian because you didn't do the latter :)
02:12 Francesca I'll just work my way through that stuff then
02:21 wizzyrea whoa! test bug just blew up!
02:22 rangi i was just testing it :)
02:22 wizzyrea I am always so glad I made that bug
02:22 wizzyrea much better than having heaps of test bugs.
02:23 Francesca you didn't literally blow anything up did you?
02:23 wizzyrea ooh comment preview
02:23 wizzyrea hehe no
02:23 rangi yup
02:23 tcohen joined #koha
02:23 rangi hey tcohen
02:27 Francesca grrr git doesn't appear to be installing on here
02:30 eythian Francesca: you got an error from git before, therefore you apparently have git.
02:32 wizzyrea Also I am pretty sure we installed it one time when you were here
02:33 wizzyrea :)
02:36 Francesca that was onwindows
02:36 rangi hmm you were doing stuff with git for the dashboard
02:37 rangi last week
02:37 wahanui hmmm... last week is just one big blur :)
02:37 rangi i think you need to change the X.X to actual values
02:39 Francesca yeah working on it
02:39 Francesca this cold is turning my head all fuzzy
02:40 Francesca yap there we go
02:40 Francesca grrr auto correct
02:40 Francesca its working now
02:40 rangi cool
02:41 wizzyrea \o/
02:41 * Francesca really needs to turn off auto correct for irc
02:42 Francesca hey wizzyrea my cats have decided to make friends again while the weather is so cold
02:42 Francesca they happily share half an armchair each
02:42 wizzyrea :D
02:43 tcohen joined #koha
02:43 Francesca yas done
02:46 tcohen joined #koha
02:50 Francesca wizzyrea its a shame my cats can't come out with me
02:50 Francesca you would adore them
02:50 wizzyrea :) that's probably true
02:55 Francesca here is an article for you http://www.stuff.co.nz/life-st[…]y-cats-delight-us
02:55 Francesca since you like cats
02:56 wizzyrea the simple answer to that question is "because they are adorable"
02:57 wizzyrea the little orange one sprawled on a lap reminds me of a cat I used to have.
02:57 eythian https://youtu.be/Hgx-Qa8DXDE
02:57 wizzyrea haha
02:59 eythian "cat dishes include chili cat, "El Gato" stew, feline and fries, calico claws, cat tails, whisker omelet, breast of cat, cats Benedict, filet of cat, stir-fried cat, feline mignon, and cat fudge sundae."
02:59 eythian hehe cat fudge sundae
03:00 wizzyrea ew. is that like http://allrecipes.com/recipe/kitty-litter-cake/
03:00 eythian heh
03:00 wizzyrea I just realised that tootsie rolls aren't really a thinghere.
03:01 eythian no, they're not.
03:01 wizzyrea or at least I haven't seen them.
03:01 Francesca lol
03:01 wizzyrea This weather is pants.
03:02 Francesca mmm
03:09 Francesca OH.MY.GOD. this is soooooooo good!!! http://www.nzherald.co.nz/ente[…]objectid=11478805
03:09 Francesca I'm dying
03:11 wizzyrea :D yeah it's been a good news kind of week for whovians.
03:12 eythian https://youtu.be/iu6jO_cxiqQ <-- a preview
03:12 wizzyrea hahahahaha
03:13 wizzyrea not to be pedantic, but that was a 10th doctor episode. :P
03:13 eythian https://youtu.be/5Blf073f2Lc <-- I prefer this one really
03:14 Francesca I'm saving up for the fan event in auckland later this year
03:14 wizzyrea yeah that 2nd one is quite a bit better.
03:15 eythian heh true
03:15 wizzyrea also, peter capaldi is in Paddington, and that's pretty hilarious.
03:16 wizzyrea you kind of expect his flat to turn into the tardis.
03:16 eythian if you haven't watched The Thick of It, you should do so
03:16 wizzyrea "I am waiting for something awesome to happen here... Oh it's just paddington."
03:16 * wizzyrea has watched it
03:17 wizzyrea I am not sure how I would characterise it. Funny,sure. Appalling, yes. closer to reality than we might like... probably.
03:17 Francesca I watched paddington
03:17 Francesca my step mother was appalled at how excited I got over peter capaldi being in it
03:17 Francesca she doesn't approve of doctor who
03:17 Francesca which is a shame cas dads a nerd as well
03:18 wizzyrea hrmph.
03:18 wizzyrea my parents didn't approve of the simpsons.
03:18 eythian Francesca: then you definitely should watch The Thick of It, he's a main character :)
03:18 wizzyrea my mom was convinced it was "filthy" which, ok, fair enough.
03:19 Francesca hahaha is that the one where he does all the swearing
03:19 wizzyrea same for "Fresh Prince of Bel Air" she did not approve.
03:19 wizzyrea fresh prince = decidedly not filthy.
03:19 wizzyrea hehe yes.
03:19 wizzyrea it's the sweary one.
03:20 Francesca lol
03:22 Francesca man that trailer was so good I died
03:23 wizzyrea this is ghost francesca?
03:24 Francesca yup
03:24 * ghost_francesca waves
03:25 ghost_francesca I wonder if anyone has ever died of pure woven excitement before
03:25 ghost_francesca whovian
03:37 eythian @wunder nzwn
03:37 huginn` eythian: The current temperature in Wellington, New Zealand is 8.0°C (3:00 PM NZST on July 10, 2015). Conditions: Light Rain Showers. Humidity: 81%. Dew Point: 5.0°C. Windchill: 3.0°C. Pressure: 30.24 in 1024 hPa (Steady).
03:43 eythian I'm going to have to optimise this ES indexing process at some stage, I think it's a lot slower than it needs to be.
03:44 wizzyrea "squalls" is not a word I would have ever used to describe weather in other places I've lived.
03:44 ghost_francesca joined #koha
03:44 wizzyrea but it is absolutely the best word for this weather.
03:45 ghost_francesca Right I'm over this cold already
03:45 ghost_francesca ears blocked head hurts
03:47 rocio left #koha
03:49 ngourlay joined #koha
04:00 ghost_francesca joined #koha
04:40 francesca joined #koha
04:42 drojf joined #koha
04:42 drojf morning. why am i awake already?
04:46 mario joined #koha
05:17 francesca dunno
05:17 francesca why are you awake drojf
05:22 francesca joined #koha
05:43 hyvaria joined #koha
05:56 francesca joined #koha
06:15 laurence joined #koha
06:16 indradg joined #koha
06:26 * magnuse waves
06:33 juan_s joined #koha
06:41 francesca joined #koha
06:43 reiveune joined #koha
06:43 reiveune hello
06:44 magnuse bonjour reiveune
06:44 reiveune salut magnuse
06:53 indradg joined #koha
06:55 Joubu joined #koha
06:56 Joubu Hello #koha
06:58 seige joined #koha
06:58 seige hi
07:00 alex_a joined #koha
07:00 alex_a bonjour
07:00 wahanui kia ora, alex_a
07:01 marcelr joined #koha
07:01 marcelr hi #koha
07:03 magnuse hiya Joubu leander alex_a marcelr
07:04 alex_a hello magnuse and magnuse
07:04 leander hi magnuse
07:08 * leander is looking for cait
07:10 lari joined #koha
07:10 Jul joined #koha
07:12 magnuse leander: i think maybe cait said she would be traveling today?
07:12 leander ah, ok
07:13 francesca joined #koha
07:13 sophie_m joined #koha
07:15 Joubu eythian:
07:16 Joubu rangi++ # bz update
07:24 magnuse ooh, version 5
07:33 sophie_m joined #koha
07:35 indradg hi Joubu, alex_a, magnuse, marcelr, leander
07:35 marcelr hi indradg
07:37 magnuse namoshkaar indradg
07:37 gaetan_B joined #koha
07:48 marcelr Joubu: tests for CalcDateDue added too on bug 14494
07:48 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=14494 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Terribly slow checkout caused by DateTime->new in far future
07:54 Joubu marcelr: I am not sure to understand the change in CalcDateDue actually
07:55 gaetan_B joined #koha
07:55 Joubu I am not sure comparing a floating with a parcular tz is a good thing to do
07:55 magnuse joined #koha
07:58 marcelr sorry?
07:59 marcelr please read the code more carefully; both are floating
07:59 jat124 joined #koha
08:00 marcelr if you would test this bug without the second patch so only 1 3 and 4, the test will fail; we need patch 2
08:00 marcelr the time spent would be 80 secs with me
08:02 Joubu both are floating, indeed...
08:04 Joubu marcelr: actually it's just... we add complexity to take into account different "infinite" date.
08:04 Joubu To me it does not make sense
08:04 marcelr it makes more sense to me
08:04 marcelr we should not test on 9999
08:04 Joubu why not?
08:04 marcelr it is a hardcoded date
08:04 Joubu yes
08:05 marcelr i added a test with 9876
08:05 marcelr and it works fine too
08:05 marcelr it is more robust
08:05 Joubu and more error prone
08:05 marcelr we follow the recommendation of DateTime to make calculations in floating
08:06 Joubu no we don't, we just do it on 1 place
08:06 marcelr I would opt for removing 9999 in some other code too
08:06 marcelr we did not yet remove DateTime compares in all code etc.
08:06 francesca joined #koha
08:07 marcelr should I open a new report to remove 9999 from DateUtils ?
08:08 marcelr Joubu: what is more error prone about the 9876 test ?
08:09 Joubu more changes, more complexity :)
08:10 marcelr i disagree; it is just another test date separate from 9999
08:10 marcelr just data
08:11 marcelr I am not proposing to put such dates anywhere in the database at all
08:12 Joubu We have occured several issues last year related to dates. It's quite frustrating to see a bug reproductible 1 day and not another one, because of the tz, etc.
08:12 Joubu The simpler the code is, the less error we could find
08:13 marcelr this is just the reason for me why the floating tz compare is better
08:13 Joubu git grep "DateTime->compare" | wc => 18
08:15 marcelr we covered all dateexpiry cases on this report
08:15 marcelr we could check other compares or move them to DateUtils but it is another scope
08:17 boutros joined #koha
08:17 petter hi #koha
08:21 Joubu Hi petter
08:23 Joubu @later tell rangi I got an error on bz attach -e. The status is changed but the patches are not sent (Failed to update bug 14494, status=200). With the -e option, the patches are sent
08:23 huginn` Joubu: The operation succeeded.
08:26 marcelr Joubu++
08:27 Joubu marcelr++ ;)
08:29 francesca joined #koha
08:37 cdickinson joined #koha
08:48 francesca joined #koha
09:01 cait joined #koha
09:01 cait @wunder Konstanz
09:01 huginn` cait: The current temperature in Bodensee Konstanz City, Konstanz, Germany is 20.7°C (11:01 AM CEST on July 10, 2015). Conditions: Clear. Humidity: 50%. Dew Point: 10.0°C. Pressure: 30.21 in 1023 hPa (Steady).
09:01 cait @wunder Tübingen
09:01 huginn` cait: Error: No such location could be found.
09:01 cait @wunder entringen
09:01 huginn` cait: Error: No such location could be found.
09:01 cait @wunder Tuebingen
09:01 huginn` cait: Error: No such location could be found.
09:01 cait hm.
09:04 petter Anyone has up-to-date instructions for setting up Koha with Plack?
09:05 petter The wiki page states that it's outdated, so I haven't tried following it yet
09:17 Joubu petter: the patch is still partially ok. Actually now the opac.psgi and intranet.psgi files are included in the koha repo (see file misc/plack/koha.psgi)
09:17 Joubu petter: warning: It's not ready yet for production
09:17 Joubu s/patch/page
09:18 petter Joubu: cool, thanks! Will try it out
09:21 francesca joined #koha
09:22 francesca @wunder Wellington
09:22 huginn` francesca: Error: No such location could be found.
09:28 cdickinson @wunder nzwn
09:28 huginn` cdickinson: The current temperature in Wellington, New Zealand is 8.0°C (9:00 PM NZST on July 10, 2015). Conditions: Light Rain Showers. Humidity: 76%. Dew Point: 4.0°C. Windchill: 4.0°C. Pressure: 30.30 in 1026 hPa (Rising).
09:28 cdickinson Don't ask me how it works
09:41 drojf joined #koha
09:42 drojf morning #koha
09:43 drojf i like the common queries in bugzilla. nice!
09:46 drojf @wunder berlin, germany
09:46 huginn` drojf: The current temperature in Berlin Tegel, Germany is 14.0°C (11:20 AM CEST on July 10, 2015). Conditions: Mostly Cloudy. Humidity: 55%. Dew Point: 5.0°C. Pressure: 30.12 in 1020 hPa (Steady).
09:48 kivilahtio Joubu: can you tell me how do we use TestBuilder.pm to generate a valid borrower? Like something which can be used to test authentication?
09:49 kivilahtio I love the way you can easily clean all the changes you have, but what if you want to only clean a subset of the DB changes you have made?
09:49 Joubu kivilahtio: my $patron = $builder->build({source => 'Borrower'});
09:49 kivilahtio Joubu: and it HASHes the password automatically?
09:50 Joubu kivilahtio: no, it just filled the pwd field with something
09:50 Joubu fills
09:50 kivilahtio I am eyeballing the code, it looks like it uses a BEGIN statement to store the transactions into a temporary never-completing transaction?
09:50 kivilahtio am I correct?
09:51 Joubu you can pass it with my $patron = $builder->build({source => 'Borrower', value => { password =>'your hash'});
09:51 Joubu kivilahtio: yes
09:51 kivilahtio Joubu: so how does this translate to Selenium tests ?
09:51 kivilahtio Do you have any suggestions how I could make this work with Selenium tests?
09:51 Joubu kivilahtio: what do you mean?
09:52 kivilahtio I have quite a nice framework for driving them :)
09:52 kivilahtio Well, selenium tests cannot rely on test context which ios not persisted to the DB
09:53 kivilahtio the noncommitted SQL transaction isonly visible to the SQL thread processing the SQL session
09:53 kivilahtio when I run Selenium tests which are like replayed real world tests, these non-committed changes are not visible
09:54 kivilahtio So based on the current TestBuilder features I think it is aimed for unit testing only
09:54 kivilahtio I am just thinking of could it be generalized to become a universal TestBuilde for integration tests as well? And could it have multiple stash-contexts like Cucumber test have?
09:55 kivilahtio It is super awesome to have three stashes, for step-objects, for scenario-objects and feature-objects
09:55 kivilahtio especially when doing very slow-to-set-up tests
09:56 cait left #koha
09:57 kivilahtio I think we should add business logic shorthands to the TestBuilder. I would like to generate borrowers with it without needing to worry about all the business logic like HASHing the password or defining expiration dates for the card
09:57 kivilahtio i think it should be really easy for the tester to create text context without necessarily knowing how Koha internally works
09:58 kivilahtio and TestBuilder to me is more like a passthrough to database columns. An elegant one :)
09:58 kivilahtio + you need to worry about all the business rules for object creation ,or you easily get hard to trace bugs when you have to remeber and clone all the business logic in the test scripts
09:59 Joubu ok too much things. sorry was somewhere else ;)
09:59 kivilahtio I know the feeling :)
10:00 Joubu kivilahtio: don't worry about the password, if you don't need to know what is the password, TestBuilder does it for you (fill it with "somethinglongandrandompoueoptueoutou")
10:00 Joubu there is no stash context at the moment
10:00 kivilahtio but I cannot test password login if the password is not hashed properly
10:00 Joubu we have some issues with the DB handler and the transactions
10:00 kivilahtio and this is just one example of the issues when you bybass object constructors and directly access the DB
10:01 Joubu there was a discussion some days/weeks ago with a DBIX dev, I should ask Tomas if there was something next
10:01 kivilahtio Joubu: I don't think we are talking about the same issues
10:04 Joubu kivilahtio: I thing so, it's related
10:04 Joubu (But I am doing 3 things at the same time)
10:05 kivilahtio but what do you think about using for ex C4::Members::AddMember via the TestBuilder?
10:05 Joubu why/where?
10:05 kivilahtio so we get te business logic rules
10:05 Joubu TestBuilder is based on the DB structure and just fill fields and create FK
10:05 kivilahtio ok
10:06 kivilahtio that answers my question :)
10:07 Joubu but what you can do, is create a common setup for several tests, then create data1 for test1 and data2 for test2
10:08 kivilahtio Joubu: how about Bug 13906?
10:08 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=13906 enhancement, P5 - low, ---, chris, In Discussion , TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
10:09 kivilahtio the issue is that my TestFactories are tightly linked to Cucumber, And I need something which can be used in Selenium tests and REST API tests
10:09 kivilahtio and Cucumber tests
10:10 kivilahtio And I was thinking if TestBuilder could be the glue, but you answered my question :)
10:11 Joubu I think a "factory" stuff should be based on top of testbuilder
10:12 Joubu and you assume branchcodes CPL, FFL and itype BK, VM exist, which is not a good idea
10:13 kivilahtio Joubu: Guilty as charged, it aint perfect either :)
10:13 kivilahtio But creating all those things for every test would be just too much work
10:13 kivilahtio I think having a common test environment configuration is a good thing
10:14 kivilahtio like branches, borrowercategories  (erm. koha.categories), itemtypes, marcframeworks
10:15 kivilahtio it is very hard to configure and understand tests if there is nothing common between them
10:15 kivilahtio and I can always realte to CPL and FFL
10:15 kivilahtio :)
10:16 Joubu "creating all those things for every test would be just too much work" => That's why TestBuilder exist :)
10:17 kivilahtio Joubu: and we can also have the common default configurations
10:17 kivilahtio Joubu: so did you create the TestBuilder so we can get rid of using the default configuration branches, itemtypes, etc. ?
10:29 Joubu kivilahtio: the first idea was to simplify the tests
10:29 Joubu and not to care about all the stuffs you need to create an entity
10:30 kivilahtio I understand
10:43 drojf1 joined #koha
11:52 meliss joined #koha
12:01 AmitG joined #koha
12:03 Dyrcona joined #koha
12:04 carmen joined #koha
12:05 drojf what do i do when git says a file needs a merge but there is no <<< >>> stuff in there?
12:05 drojf i know i have not touched it, so it's not just that i forgot git add
12:06 jcamins drojf: view the patch you're trying to apply and manually add the changes.
12:07 drojf jcamins: thanks, will do. luckily it's not a large file
12:07 drojf ah!
12:08 drojf it's part of the opac prog theme. so it just has to go
12:08 drojf (old patch)
12:08 jcamins That'll do it.
12:08 drojf or rather, be ported to bootstrap
12:11 Joubu it also happens if you have already fixed the conflict and git rerere is enabled
12:36 drojf hm ok i have problems submitting a patch too
12:37 drojf works neither with or without -e for me
12:38 tcohen joined #koha
12:39 tcohen morning
12:39 francharb joined #koha
12:50 drojf hi tcohen
12:50 tcohen @wunder cordoba, argentina
12:50 huginn` tcohen: The current temperature in Bo Altos de San Martin - NW, Cordoba city, Cordoba City, Argentina is 10.9°C (9:50 AM ART on July 10, 2015). Conditions: Scattered Clouds. Humidity: 63%. Dew Point: 4.0°C. Pressure: 30.02 in 1016 hPa (Rising).
12:52 drojf mtompsett++
12:59 mario joined #koha
13:10 JoshB joined #koha
13:11 nengard joined #koha
13:14 NateC joined #koha
13:17 misilot Can Koha check for barcodes with too many digits?
13:29 cma joined #koha
13:53 edveal joined #koha
13:55 amyjeankearns joined #koha
14:06 huginn` New commit(s) kohagit: Bug 14303: Fix item search CSV export - obsolete "by" and display of publication... <http://git.koha-community.org/[…]bf897e2d77132296a> / Bug 14428: Remove C4::Input <http://git.koha-community.org/[…]b9a76b1618fb0add0> / Bug 14496: Improving opac-detail.pl performances <http://git.koha-community.org/gitweb/?p=koha.g
14:13 tcohen a RM should have the power to invoke oleonard so he's back
14:16 drojf tcohen: +1
14:36 wicope joined #koha
14:36 nengard joined #koha
14:43 AmitG joined #koha
14:58 AmitG hello indradg
15:12 rocio joined #koha
15:19 reiveune bye
15:19 reiveune left #koha
15:22 Joubu khall: it seems you forgot to update the status of bug 9006
15:22 huginn` Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9006 minor, P5 - low, ---, jonathan.druart, Signed Off , autoload in C4::Context is a bad idea
15:22 khall thanks! I'm having gt-bz issues
15:23 Joubu khall: yep same here
15:23 AmitG hi Joubu, khall
15:23 khall hi!
15:24 bag heya khall and Joubu
15:25 khall mornin!
15:25 * bag only here for a sec (just saying hi)
15:25 AmitG heya bag
15:25 bag hi AmitG
15:26 Joubu hello all :)
15:42 nengard Hi all
15:55 laurence left #koha
15:59 gaetan_B bye
16:16 tcohen Joubu khall: hi
16:16 khall hi tcohen!
16:16 Joubu tcohen: o/
16:17 tcohen i'm looking at Koha::Logger
16:17 tcohen looks awesome
16:17 tcohen :-D
16:18 khall thanks!
16:19 bag sweet :)
16:21 tcohen later #koha, have to run to the to-be house
16:22 pianohacker joined #koha
16:38 Joubu khall: bug 11194 SO or PQA? :)
16:38 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=11194 enhancement, P5 - low, ---, olli-antti.kivilahti, Signed Off , Add a new index for "Edition Statement" of a MARC Record
16:39 khall I didn't mean to pqa that one
16:40 Joubu khall: you switched to PQA then SO, and there is your signed-off-by line on the last patch attached
16:52 laurence joined #koha
17:14 Joubu have a good week-end #koha!
17:17 JesseM joined #koha
18:15 drojf joined #koha
18:32 laurence left #koha
19:21 indradg joined #koha
19:32 chris_K joined #koha
20:02 nengard left #koha
20:07 chris__K joined #koha
20:48 wizzyrea_ joined #koha
21:49 JoshB joined #koha
22:01 liz joined #koha
23:17 cdickinson joined #koha

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary