| Time |
S |
Nick |
Message |
| 00:01 |
|
|
papa joined #koha |
| 00:37 |
|
dcook |
eythian: around for a quick question about packages? |
| 00:37 |
|
dcook |
Actually... |
| 00:38 |
|
eythian |
dcook: si |
| 00:38 |
|
dcook |
Nevermind |
| 00:38 |
|
dcook |
Thanks anyway :) |
| 00:38 |
|
eythian |
happy to have helped. |
| 00:41 |
|
dcook |
You know your keyboard has seen better days when the up arrow jumps out and onto your desk in protest... |
| 00:42 |
|
dcook |
I didn't know huginn could do PM reminders... |
| 00:42 |
|
dcook |
Or did huginn just come up... |
| 00:42 |
|
eythian |
haha |
| 00:42 |
|
eythian |
PM reminders? |
| 00:42 |
|
eythian |
https://twitter.com/BrandsSayingBae <-- "Bæ/bae is a Danish word for poop. Also used by people on the internet who think it means baby, sweetie etc." |
| 00:43 |
|
eythian |
it should really be muninn that does reminders. |
| 00:58 |
|
dcook |
hehe |
| 00:58 |
|
dcook |
Yeah, I used to think that about muninn as well |
| 00:58 |
|
dcook |
I think huginn must've been down until that big upheaval and I just got my reminder really late |
| 00:59 |
|
wizzyrea |
eythian++ for excellent facts about language |
| 01:02 |
|
wizzyrea |
also, fun fact, it means good bye in icelandic. |
| 01:03 |
|
eythian |
also english, roughly |
| 01:03 |
|
wizzyrea |
sorta kinda. |
| 01:03 |
|
wizzyrea |
I don't think I'd ever spell "bye" that way |
| 01:04 |
|
wizzyrea |
now bye looks weird to me. |
| 01:08 |
|
dcook |
By the by... it must be annoying to learn English |
| 01:08 |
|
dcook |
By, bye, bi |
| 01:08 |
|
dcook |
Oh God, this is a... *insert boyband name* song |
| 01:09 |
|
wizzyrea |
Buffalo buffalo buffalo... and so on. |
| 01:09 |
|
dcook |
Buffalo buffalo buffalo... is just plain awesome though :p |
| 01:09 |
|
wizzyrea |
hehe |
| 01:10 |
|
eythian |
https://www.youtube.com/watch?v=hTdhXxxWREo <-- not a boyband |
| 01:10 |
|
dcook |
:D |
| 01:52 |
|
dcook |
http://www.zdnet.com/article/m[…]-windows-10-push/ <-- Great... another browser to support... |
| 01:53 |
|
eythian |
oh dear |
| 02:00 |
|
rangi |
@later tell tcohen working on a fix for the issue with the failing tests introduced by the db change |
| 02:00 |
|
huginn |
rangi: The operation succeeded. |
| 02:02 |
|
eythian |
http://youtu.be/rtR63-ecUNo |
| 02:05 |
|
eythian |
@wunder nzwn |
| 02:05 |
|
huginn |
eythian: The current temperature in Wellington, New Zealand is 22.0°C (2:30 PM NZDT on December 30, 2014). Conditions: Mostly Cloudy. Humidity: 64%. Dew Point: 15.0°C. Pressure: 30.04 in 1017 hPa (Falling). |
| 02:11 |
|
pastebot |
"rangi" at 127.0.0.1 pasted "ten points if you can spot the problem here" (30 lines) at http://paste.koha-community.org/331 |
| 02:18 |
|
dcook |
Is this a trick question, rangi? |
| 02:18 |
|
rangi |
nope |
| 02:23 |
|
dcook |
Hmm |
| 02:23 |
|
dcook |
I'm wondering what inputs they're getting in all the cases where the result is different |
| 02:23 |
|
dcook |
The only thing that really looks different is that "if ($borrowernumber);" |
| 02:23 |
|
rangi |
look at the order of the tenary |
| 02:24 |
|
dcook |
Looks all right, no? |
| 02:24 |
|
rangi |
nope |
| 02:24 |
|
dcook |
Although.. |
| 02:24 |
|
wahanui |
although is mine 2.3.2 or 2.3.3 |
| 02:24 |
|
rangi |
if $count = 1 return 0 |
| 02:24 |
|
dcook |
Yeah |
| 02:25 |
|
rangi |
well if $count return 0 |
| 02:25 |
|
dcook |
( $uid ne '' ) && ( my $row = $sth->fetchrow_hashref ){ return 0 } |
| 02:25 |
|
dcook |
Although I can't remember what happens there if you do/do not have a row.. |
| 02:25 |
|
rangi |
the wrong thing |
| 02:25 |
|
dcook |
Had a feeling that might be it |
| 02:26 |
|
rangi |
basically it is returning 0, when it should return 1 |
| 02:26 |
|
dcook |
That'll do it |
| 02:27 |
|
dcook |
I imagine "my $row = $sth->fetchrow_hashref" returns true no matter what? |
| 02:27 |
|
rangi |
not sure, just the old version worked, the new one, not so much |
| 02:27 |
|
dcook |
:/ |
| 02:28 |
|
dcook |
Haven't looked at Check_Userid in ages, what does that one do again? |
| 02:28 |
|
dcook |
Is it for checking userid for new members or as part of auth? |
| 02:28 |
|
rangi |
tests if a user id is unique |
| 02:28 |
|
rangi |
does it when you add a borrower etc |
| 02:28 |
|
dcook |
Mmm, thought that might be it |
| 02:28 |
|
dcook |
What's the borrowernumber? |
| 02:28 |
|
rangi |
bug 1861 made a unique constraint ont he db |
| 02:28 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=1861 normal, P4, ---, kyle, ASSIGNED , Unique patrons logins not (totally) enforced |
| 02:29 |
|
dcook |
Or rather whose borrowernumber is it? :S |
| 02:29 |
|
rangi |
and changed this code |
| 02:29 |
|
dcook |
Mmm |
| 02:29 |
|
rangi |
now 25 tests are failing |
| 02:29 |
|
dcook |
Yeah I saw the test failing part :( |
| 02:30 |
|
rangi |
$data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) |
| 02:30 |
|
rangi |
if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); |
| 02:30 |
|
rangi |
thats pretty broken |
| 02:31 |
|
rangi |
if your userid is unique |
| 02:31 |
|
rangi |
lets throw it away and make a new one |
| 02:31 |
|
rangi |
bzzt |
| 02:31 |
|
rangi |
wrong |
| 02:31 |
|
rangi |
no wonder the tests are failing they try to add a borrower with a userid they know |
| 02:32 |
|
rangi |
- $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; |
| 02:32 |
|
rangi |
+ $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) |
| 02:32 |
|
rangi |
+ if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); |
| 02:32 |
|
rangi |
*sigh* |
| 02:34 |
|
rangi |
basically that should be ! Check_Userid |
| 02:34 |
|
rangi |
and it then works |
| 02:35 |
|
dcook |
Hmm.. |
| 02:36 |
|
rangi |
Check_Userid returns 1 for unique |
| 02:36 |
|
rangi |
0 if its not |
| 02:36 |
|
dcook |
Yeah |
| 02:36 |
|
dcook |
So "return $count ? 0 : 1;" should be ok, no? |
| 02:36 |
|
rangi |
well either its wrong |
| 02:36 |
|
rangi |
or that or is wrong |
| 02:36 |
|
dcook |
Since "return 0 if ( $uid eq C4::Context->config('user') );" would mean the userid is the same as the db user |
| 02:37 |
|
rangi |
basically they are both expecting contradictory behaviour |
| 02:37 |
|
dcook |
Sounds like it |
| 02:37 |
|
wahanui |
Sounds like it is beer o'clock for you dcook? ;) |
| 02:37 |
|
dcook |
:D |
| 02:37 |
|
rangi |
ill change the AddMember and hope its the only place that is wrong |
| 02:38 |
|
dcook |
Hmm ! Check_Userid doesn't look like it would be right though.. |
| 02:42 |
|
rangi |
why not? |
| 02:43 |
|
dcook |
Ah wait.. |
| 02:43 |
|
dcook |
Right right |
| 02:43 |
|
dcook |
Since if you get a 0, you want a new userid.. |
| 02:43 |
|
rangi |
@later tcohen please take a look at the last patch on bug 1861 |
| 02:43 |
|
huginn |
rangi: I'll give you the answer just as soon as RDA is ready |
| 02:43 |
|
rangi |
@later tell tcohen please take a look at the last patch on bug 1861 |
| 02:43 |
|
huginn |
rangi: The operation succeeded. |
| 02:43 |
|
dcook |
Check_Userid is a hell of a function name.. |
| 02:43 |
|
rangi |
yeah, if its not unique, make a new one |
| 02:43 |
|
rangi |
yeah its dumb |
| 02:43 |
|
rangi |
is_userid_unique |
| 02:44 |
|
rangi |
is better |
| 02:44 |
|
rangi |
or unique_userid |
| 02:44 |
|
rangi |
if ! unique_userid(blah) |
| 02:44 |
|
dcook |
totes |
| 02:44 |
|
rangi |
but since half arsed refactoring is what broke this |
| 02:44 |
|
rangi |
im not about to start doing more :) |
| 02:44 |
|
dcook |
Fair enough :) |
| 02:45 |
|
dcook |
I certainly hear that |
| 03:10 |
|
eythian |
OK, after far too long I've finally figured out how to alias repo names (e.g. "stable" to "squeeze") without warnings showing up. |
| 03:11 |
|
rangi |
:) |
| 03:12 |
|
dcook |
\o/ |
| 03:17 |
|
dcook |
eythian++ |
| 03:18 |
|
eythian |
turned out to be surprisingly easy, once you've waded through a fair bit of documentation |
| 03:20 |
|
dcook |
Reminds me of more than a few things ;) |
| 03:21 |
|
dcook |
Yay for documentation! |
| 03:23 |
|
|
burdsjm_ joined #koha |
| 04:00 |
|
|
JesseDhammu joined #koha |
| 05:02 |
|
|
mtompset joined #koha |
| 05:02 |
|
mtompset |
@seen eythian |
| 05:02 |
|
huginn |
mtompset: eythian was last seen in #koha 1 hour, 44 minutes, and 37 seconds ago: <eythian> turned out to be surprisingly easy, once you've waded through a fair bit of documentation |
| 05:03 |
|
eythian |
I'm still here if you're quick |
| 05:04 |
|
mtompset |
Just curious why you turned the other repo possibilitiesinto blue boxes in the ubuntu wiki. |
| 05:04 |
|
mtompset |
It's confusing for a person who doesn't understand repos. |
| 05:04 |
|
eythian |
I don't understand the question |
| 05:05 |
|
mtompset |
I'll just revert your changes then. |
| 05:05 |
|
eythian |
what changes? |
| 05:05 |
|
wahanui |
changes are written to the database, but Koha doesn't seem to pick it up... |
| 05:05 |
|
mtompset |
http://wiki.koha-community.org[…]ubuntu_-_packages |
| 05:06 |
|
eythian |
oh |
| 05:06 |
|
eythian |
that was an error |
| 05:06 |
|
mtompset |
the add koha community repo section now has three blue boxes for the adding repo, instead of just the one. |
| 05:06 |
|
eythian |
oh wait |
| 05:06 |
|
eythian |
on moment |
| 05:06 |
|
eythian |
+e |
| 05:06 |
|
dcook |
blue boxes? |
| 05:07 |
|
mtompset |
The commands were there before, but purposefully not formatted. |
| 05:07 |
|
mtompset |
code boxes show up as blue on my browser. |
| 05:07 |
|
dcook |
So that people don't accidentally add them? |
| 05:07 |
|
mtompset |
EXACTLY. |
| 05:07 |
|
eythian |
ah |
| 05:07 |
|
dcook |
Seems reasonable... the caps less so :p |
| 05:07 |
|
eythian |
yeah, revert that if you like |
| 05:07 |
|
mtompset |
Sorry. Just a little passionate. |
| 05:08 |
|
eythian |
I was making something cleaner, but that got caught up in it I think. |
| 05:08 |
|
mtompset |
Though, I was thinking, since you added/renamed and added aliases... we should remove reference to squeeze. |
| 05:08 |
|
eythian |
sure |
| 05:08 |
|
* dcook |
is wondering how he can finish his donuts, crackers, and sandwiches in the next 50 minutes... |
| 05:08 |
|
dcook |
While also typing up a storm |
| 05:08 |
|
mtompset |
And that's why I just sent you an email about perhaps squeeze-dev being something other than 'unstable'.. |
| 05:08 |
|
* dcook |
needs an extra set of hands.. |
| 05:09 |
|
mtompset |
(or in addition to being unstable) |
| 05:09 |
|
mtompset |
eythian: You don't like <pre>? :) |
| 05:10 |
|
mtompset |
I like explicitness. :) |
| 05:10 |
|
eythian |
it's icky to read in source, and it requires noisy markup to get a multiline entry. |
| 05:12 |
|
eythian |
it's unstable because that's what it is |
| 05:12 |
|
eythian |
it's expected to change a lot, which is what stable means in the debian context. |
| 05:13 |
|
mtompset |
But Jessie is testing, and sid is experimental, aren't they? |
| 05:14 |
|
eythian |
no, jessie is testing, sid is unstable |
| 05:14 |
|
mtompset |
Oh, just read your email reply. :) |
| 05:14 |
|
mtompset |
So our master is unstable?! |
| 05:15 |
|
mtompset |
Considering the QA process to get something in there, I would think it is more testing than unstable. |
| 05:15 |
|
eythian |
sure it is, it changes most days |
| 05:16 |
|
eythian |
stable |
| 05:16 |
|
eythian |
2: firm and dependable; subject to little fluctuation; "the |
| 05:16 |
|
eythian |
economy is stable" |
| 05:16 |
|
eythian |
it's not that, by design |
| 05:17 |
|
mtompset |
consider a person unfamiliar with geek talk, unstable is going to sound bad. |
| 05:17 |
|
dcook |
If they're unfamiliar with geek talk, they shouldn't be using unstable :) |
| 05:17 |
|
eythian |
yes. |
| 05:17 |
|
eythian |
that |
| 05:19 |
|
mtompset |
Just trying to keep the technical bar low, so that people aren't afraid to join the coding community. :P |
| 05:21 |
|
eythian |
I sorta think that having some consistency is good. Now our naming matches the parts of debian that they are closest to. |
| 05:31 |
|
|
mtompset_ joined #koha |
| 05:31 |
|
mtompset |
Oops... silly internet connection. |
| 05:31 |
|
mtompset |
I suppose |
| 05:31 |
|
mtompset |
I should get sleep. |
| 05:31 |
|
mtompset |
Have a great day, #koha. |
| 05:32 |
|
* eythian |
leaves also. |
| 05:32 |
|
eythian |
bye |
| 06:04 |
|
|
qu-bit joined #koha |
| 06:27 |
|
|
cait joined #koha |
| 06:41 |
|
|
rocio left #koha |
| 06:57 |
|
|
qu-bit joined #koha |
| 07:36 |
|
|
laurence joined #koha |
| 07:39 |
|
|
reiveune joined #koha |
| 07:39 |
|
reiveune |
hello |
| 07:39 |
|
wahanui |
what's up, reiveune |
| 07:57 |
|
|
alex_a joined #koha |
| 07:57 |
|
alex_a |
bonjour |
| 07:57 |
|
wahanui |
salut, alex_a |
| 08:08 |
|
|
ashimema joined #koha |
| 08:08 |
|
|
cait joined #koha |
| 08:10 |
|
cait |
good morning #koha |
| 08:11 |
|
ashimema |
morning cait |
| 08:11 |
|
* ashimema |
is a tad embarrassed that he missed a pretty epic bug in a auth patch he qa'd |
| 08:12 |
|
Joubu |
hello #koha |
| 08:12 |
|
cait |
hi Joubu |
| 08:12 |
|
cait |
nice that it's not totally empty here these days |
| 08:13 |
|
cait |
ashimema: I am embarassed too - but it happens |
| 08:13 |
|
* cait |
sends cookies |
| 08:13 |
|
cait |
i tested it too, remember? :) |
| 08:14 |
|
ashimema |
yup |
| 08:14 |
|
ashimema |
what it teaches me is that I really need to sort out tests on this system.. |
| 08:14 |
|
ashimema |
a huge number fail for me every time I run then.. |
| 08:15 |
|
|
sophie_m joined #koha |
| 08:15 |
|
ashimema |
and thus it kinda becomes pointless |
| 08:15 |
|
cait |
the problem is that i don't have a clean database really... intentionally because the data is good for testing |
| 08:15 |
|
cait |
but it means a lot of the db dependent tests are failing |
| 08:16 |
|
ashimema |
that's my issue exactly too |
| 08:16 |
|
ashimema |
our db_dependant tests really really should be database agnostic |
| 08:16 |
|
ashimema |
i.e. they should all create and destroy ALL data they need to run the test. |
| 08:17 |
|
|
gaetan_B joined #koha |
| 08:17 |
|
gaetan_B |
hello |
| 08:19 |
|
ashimema |
@wunder stevenage, uk |
| 08:19 |
|
huginn |
ashimema: The current temperature in Pin Green, Stevenage, United Kingdom is -1.1°C (8:10 AM GMT on December 30, 2014). Conditions: Clear. Humidity: 94%. Dew Point: -2.0°C. Windchill: -1.0°C. Pressure: 30.69 in 1039 hPa (Steady). |
| 08:22 |
|
Joubu |
ashimema: I always point out this patch, but you can create a DB with the script provided on bug 10337 |
| 08:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=10337 enhancement, P5 - low, ---, jonathan.druart, In Discussion , UT: The unit tests cannot be launched by everyone |
| 08:23 |
|
Joubu |
ashimema: I have 2 DB, the one to test the patch using koha, and the one for the "unit" tests, I switch the db name in koha-conf when needed |
| 08:23 |
|
ashimema |
indeed Joubu.. |
| 08:23 |
|
ashimema |
having two db's is a pretty good work around actually.. |
| 08:24 |
|
|
fridolin joined #koha |
| 08:24 |
|
Joubu |
especially because I test on an UNIMARC DB and the tests need a MARC21 DB... |
| 08:24 |
|
fridolin |
hie all |
| 08:24 |
|
rangi |
i have about 8 :) |
| 08:24 |
|
cait |
could there be a script to do the switch? |
| 08:25 |
|
* cait |
is lazy |
| 08:25 |
|
ashimema |
thanks for spotting that rangi, and coming up with a patch so quick. |
| 08:25 |
|
Joubu |
rangi: yes, I have 5 or 6 too, but I always use the same for tests |
| 08:25 |
|
cait |
also i tend to mess up things too much :) |
| 08:25 |
|
rangi |
its just export KOHA_CONF= different/koha-conf.xml |
| 08:25 |
|
cait |
rangi: ooh |
| 08:25 |
|
rangi |
i toggle between unimarc and marc21 for testing |
| 08:25 |
|
ashimema |
can't believe I missed it.. so obvious now you've pointed it out :( |
| 08:25 |
|
Joubu |
and it's the one created by the script on 10337 |
| 08:25 |
|
cait |
i didn't htink of doubling up the koha-conf |
| 08:25 |
|
rangi |
both with only sample data in |
| 08:26 |
|
cait |
i have a unimarc installation too, but right now it's totally separate - even another git clone |
| 08:26 |
|
rangi |
you can even write a small .sh |
| 08:26 |
|
rangi |
#!/bin/sh |
| 08:26 |
|
rangi |
export KOHA_CONF |
| 08:26 |
|
rangi |
run tests |
| 08:26 |
|
rangi |
export other one |
| 08:26 |
|
rangi |
run tests |
| 08:26 |
|
rangi |
now its been tested in marc21 and unimarc |
| 08:27 |
|
rangi |
or |
| 08:27 |
|
rangi |
you can use magnuse kohadevbox |
| 08:27 |
|
rangi |
and have 2 vagrant instances |
| 08:27 |
|
ashimema |
don't tihnk I'de seen 10337 before |
| 08:27 |
|
rangi |
one for each |
| 08:27 |
|
ashimema |
or maybe I had but forgotten about it. |
| 08:28 |
|
rangi |
thats handy for UAT too |
| 08:28 |
|
cait |
UAT? |
| 08:28 |
|
ashimema |
I was in fact tihnking of using the vagrant box as a new qa machine |
| 08:28 |
|
ashimema |
at the moment I just use my main dev system directly |
| 08:28 |
|
rangi |
user acceptance testing |
| 08:29 |
|
rangi |
yeah i use that for dev |
| 08:29 |
|
rangi |
but use 'clean' ones for testing |
| 08:30 |
|
cait |
for automatic testing or in general? |
| 08:30 |
|
rangi |
both |
| 08:31 |
|
rangi |
if im gonna sign off, i switch to my clean repo and sample db database |
| 08:31 |
|
cait |
for things like acq i find a clean database not so helpful |
| 08:31 |
|
cait |
you have to set up a lot of stuff and it gets more interesting once you have longer lists and more different data |
| 08:31 |
|
* ashimema |
goes away to grab a second db and impliment rangi and joubu's suggestions |
| 08:31 |
|
cait |
well interesting = you see more of the problematic things easier |
| 08:32 |
|
rangi |
you can always test on both |
| 08:32 |
|
rangi |
but stuff should work on a fresh install |
| 08:32 |
|
rangi |
not just a populated one too |
| 08:32 |
|
* ashimema |
has been thinking for a while that we should be using https://metacpan.org/pod/DBIx::Class::Fixtures |
| 08:32 |
|
cait |
that's true - but setting up funds and stuff takes a lot of time |
| 08:32 |
|
rangi |
yep |
| 08:32 |
|
cait |
and i think some of the tests fail once you have raeally basic data |
| 08:32 |
|
rangi |
they should all pass with the sample data |
| 08:32 |
|
rangi |
thats the rul |
| 08:32 |
|
rangi |
e |
| 08:33 |
|
rangi |
if they dont, then they need to be fixed |
| 08:33 |
|
cait |
yeah but we have no acq sample data :) |
| 08:33 |
|
Joubu |
they pass |
| 08:33 |
|
Joubu |
cait: yes, that why we need to create all data before testing |
| 08:33 |
|
rangi |
id like to do some more www::mechanize tests |
| 08:33 |
|
rangi |
that would have caught this bug too |
| 08:33 |
|
rangi |
because it would have seen the userid put in, is not what came back out |
| 08:34 |
|
cait |
makes sense |
| 08:34 |
|
rangi |
those are harder tho, because you need a running webserver |
| 08:34 |
|
* cait |
feels a bit lazy now... but i don't want to double the time for testing each time :( |
| 08:35 |
|
cait |
but i will try to run the db_dependent tests on a sample database in future |
| 08:36 |
|
Joubu |
it's really easy with the patch I proposed |
| 08:50 |
|
ashimema |
cait.. |
| 08:50 |
|
ashimema |
your followup to 5511 doesn't apply? |
| 08:51 |
|
cait |
hm |
| 08:51 |
|
cait |
let me see |
| 08:52 |
|
ashimema |
leaves me in a 'wierd' git state.. |
| 08:52 |
|
cait |
strange |
| 08:52 |
|
ashimema |
mmm.. it's a simple patch.. can't see why it wouldn't apply |
| 08:52 |
|
cait |
me neither |
| 08:53 |
|
ashimema |
i get the usual.. 'fatal: sha1 information is lacking or useless' |
| 08:53 |
|
ashimema |
for updatedatabase.pl.. |
| 08:53 |
|
cait |
huh |
| 08:53 |
|
ashimema |
but then it drops out without giving me a file with merge conflicts to sort out.. |
| 08:53 |
|
cait |
don't have a master at hand right now to test :( |
| 08:54 |
|
ashimema |
rangi... always wondered why that happens on occasions and wondered if you had any advice. |
| 08:55 |
|
cait |
wonder if updatedatabase changed since i tested? |
| 08:55 |
|
cait |
tcohen pushed in between |
| 08:55 |
|
ashimema |
possibly.. |
| 08:55 |
|
ashimema |
but I would have though it be the patch before that fails rather than yours ;) |
| 08:56 |
|
Joubu |
ashimema: it fails here too, but you can try to apply --reject |
| 08:56 |
|
cait |
hm i moved it around quite a bit |
| 08:56 |
|
cait |
it was in a weird spot |
| 08:57 |
|
ashimema |
ooh.. |
| 08:57 |
|
ashimema |
--reject |
| 08:57 |
|
ashimema |
never used that |
| 08:57 |
|
cait |
how does it work? |
| 08:57 |
|
rangi |
i usually just --abort |
| 08:58 |
|
ashimema |
indeed.. and abort gets me back to a working tree.. |
| 08:58 |
|
ashimema |
but I wanted to know if there's any way to save the apply ;) i.e. sort out the merge conflicts.. |
| 08:59 |
|
ashimema |
I'de have tought git would be able to dump me out with a conflicte file as per usual which I could sort out with mergetool.. |
| 08:59 |
|
ashimema |
never worked out why sometimes it fails to do that |
| 09:00 |
|
rangi |
ah yeah reject will make *.rej files for the bits taht fail |
| 09:00 |
|
ashimema |
ooh. |
| 09:00 |
|
rangi |
and applies the bits it can |
| 09:00 |
|
Joubu |
yep, very useful in some cases |
| 09:00 |
|
cait |
ah |
| 09:00 |
|
rangi |
often its best/easiest to just get the person to rebase tho if they can, but if they cant reject is handy |
| 09:00 |
|
cait |
and then you have to only fix the one file and git ament? |
| 09:00 |
|
cait |
amend |
| 09:00 |
|
rangi |
yep |
| 09:00 |
|
Joubu |
especially where there is a sha1 information lacking or useless |
| 09:01 |
|
rangi |
Joubu: http://blog.bigballofwax.co.nz[…]a-by-the-numbers/ |
| 09:01 |
|
ashimema |
how do I reject then.. |
| 09:01 |
|
ashimema |
'git bz apply --reject' isn't an option? |
| 09:01 |
|
cait |
how do you run it? with the git am when it fails the first time? |
| 09:01 |
|
ashimema |
'git am --reject' also failed for me. |
| 09:02 |
|
Joubu |
rangi: wahou nice :) |
| 09:02 |
|
rangi |
it saves a copy of the patch in /tmp |
| 09:02 |
|
Joubu |
ashimema: no git apply --reject |
| 09:02 |
|
Joubu |
not git bz |
| 09:02 |
|
ashimema |
ahh.. |
| 09:02 |
|
ashimema |
thanks |
| 09:02 |
|
rangi |
git apply --reject /tmp/the_patch |
| 09:02 |
|
Joubu |
you have to git bz apply --skip |
| 09:02 |
|
ashimema |
that's better, it's actually doing somtihng now.. |
| 09:02 |
|
cait |
Joubu: congrats on author of the year :) |
| 09:02 |
|
Joubu |
and then git apply --reject /tmp/the_file_created_by_git_bz.patch |
| 09:02 |
|
ashimema |
thanks Joubu.. a new command to add to my git repetior |
| 09:03 |
|
ashimema |
ooh.. rangi your block looks different |
| 09:05 |
|
Joubu |
rangi: It seems that the numbers are not the same as on the dashboard |
| 09:06 |
|
cait |
hm think he added the failed |
| 09:06 |
|
Joubu |
rangi: the total are good, but the not the individuals. For instance, I PQA 263 on the dashboard and 336 on your blog, where does come from this number? |
| 09:06 |
|
Joubu |
ha yes, makes sense! |
| 09:07 |
|
ashimema |
I'm gonna set 1861 back to passed qa (skipping signoff) if that's ok with peeps.. rangi's change is a single character fix |
| 09:07 |
|
ashimema |
then I'll push it onto my module branch |
| 09:07 |
|
Joubu |
87 authors, that a great number :) |
| 09:07 |
|
ashimema |
yeah.. those stats are brill |
| 09:08 |
|
ashimema |
ooh.. joubu beat me. |
| 09:08 |
|
cait |
yeah :) |
| 09:08 |
|
cait |
Joubu++ |
| 09:09 |
|
ashimema |
and he added a unit test.. |
| 09:09 |
|
|
alex_a joined #koha |
| 09:09 |
|
ashimema |
even better.. Joubu++ |
| 09:09 |
|
rangi |
Joubu: you failed some too |
| 09:10 |
|
rangi |
passed + failed = number qaed |
| 09:10 |
|
cait |
hm i am failing about 25% |
| 09:12 |
|
cait |
hope a lot of those still made it in |
| 09:14 |
|
|
dac joined #koha |
| 09:14 |
|
cait |
hm but maybe not only me looking at the stats |
| 09:14 |
|
rangi |
most of them are the same bug, it fails, then it passes |
| 09:15 |
|
rangi |
but you have to test it each time |
| 09:15 |
|
rangi |
so i count that |
| 09:15 |
|
cait |
yeah 'zombie bugs' coming back at you :) |
| 09:17 |
|
Joubu |
rangi: it could be good to add the number of new devs |
| 09:18 |
|
rangi |
hmm yep i can do that |
| 09:20 |
|
rangi |
34 |
| 09:21 |
|
cait |
very cool |
| 09:22 |
|
cait |
ashimema: thx for fixing the follow-up |
| 09:22 |
|
Joubu |
I have just compared with http://blog.bigballofwax.co.nz[…]a-by-the-numbers/ and the numbers are very closed |
| 09:22 |
|
Joubu |
2250 vs 2225 commits |
| 09:22 |
|
cait |
rangi: why is the person with most sign offs missing? ;) |
| 09:22 |
|
Joubu |
84 dev vs 85 |
| 09:23 |
|
rangi |
yeah we are pretty consistent |
| 09:23 |
|
Joubu |
33 new dev bd 34 |
| 09:23 |
|
Joubu |
s/bd/vs |
| 09:23 |
|
cait |
hm could we see a enh/new vs. bugs stat? |
| 09:23 |
|
rangi |
2013 was similar |
| 09:23 |
|
cait |
guess i can look that up in release notes :) |
| 09:23 |
|
rangi |
more commits |
| 09:24 |
|
rangi |
but around the same number of devs |
| 09:24 |
|
|
JesseDhammu joined #koha |
| 09:24 |
|
rangi |
actually 91 in 2013 |
| 09:24 |
|
JesseDhammu |
koha in the blind koha in the blind |
| 09:24 |
|
cait |
btw - coworker testing 3.18 - filing tickets for me while we speak ) |
| 09:24 |
|
JesseDhammu |
Cait are you there ..? |
| 09:24 |
|
cait |
mostly translation things for now |
| 09:24 |
|
cait |
and some old things |
| 09:25 |
|
rangi |
in 2013 we got more new devs at the hackfest than in 2014 that helped jump the number |
| 09:25 |
|
cait |
he just brought up bug 4041 again |
| 09:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4041 enhancement, P5 - low, ---, koha-bugs, NEW , Address Format as a I18N/L10N system preference |
| 09:26 |
|
ashimema |
rangi.. did you look at bug 12954 at all? |
| 09:26 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=12954 major, P3, ---, abl, Signed Off , Questionable logic regarding session handling in C4::Auth::checkauth() |
| 09:27 |
|
ashimema |
I'm just going through the logic of it now, but wondered if you had any thoughts |
| 09:28 |
|
ashimema |
my feeling is that we probably shouldn't completely nuke the session data upon failed login, rather set the session to anon again, and maintian the anon search history through a bad login attempt |
| 09:29 |
|
rangi |
yeah |
| 09:29 |
|
rangi |
that makes sense |
| 09:29 |
|
rangi |
you know what we should do sometime soon |
| 09:29 |
|
rangi |
count login attempts, and block them after a number of failed ones |
| 09:30 |
|
rangi |
(offtopic but i just remembered that) |
| 09:30 |
|
ashimema |
indeed.. we probably should.. |
| 09:30 |
|
ashimema |
I'm also thinking of submitting a non-destructive (i.e don't break lines) tidy of the Auth.pm file.. it's bacome pretty unreadable with indenting all over the shop.. |
| 09:31 |
|
JesseDhammu |
hello i need some help with users issues data |
| 09:32 |
|
JesseDhammu |
i have migrated to another koha server,,, and have exported and imported bibliographic records. |
| 09:32 |
|
rangi |
good plan ashimema |
| 09:32 |
|
rangi |
if it doesnt break lines the git diff -w works well |
| 09:32 |
|
ashimema |
that was my thoughts :) |
| 09:33 |
|
JesseDhammu |
but dont have data of issued books to the users. |
| 09:33 |
|
JesseDhammu |
how do i restore that from my old database ..? |
| 09:37 |
|
rangi |
you cant; the id numbers of the items and borrowers will be different |
| 09:37 |
|
rangi |
its better to copy the whole db, and upgrade it |
| 09:42 |
|
rangi |
ok, sleep time for me |
| 09:43 |
|
cait |
night rangi |
| 09:48 |
|
JesseDhammu |
good night rangi , just a small query |
| 09:53 |
|
JesseDhammu |
cait: do you remember the problem which i explained yesterday |
| 09:53 |
|
JesseDhammu |
about the database upgradation faliure .. |
| 09:54 |
|
JesseDhammu |
i still have that issue |
| 09:54 |
|
cait |
JesseDhammu: rangi is right, it's too complicated to explain that here |
| 09:54 |
|
JesseDhammu |
no i understand why he is saying that .. |
| 09:54 |
|
JesseDhammu |
but my issue is i can not import the whole sql dump |
| 09:54 |
|
cait |
there is too much involved, your best bet would probably doing it manually |
| 09:54 |
|
JesseDhammu |
ok .. |
| 09:55 |
|
cait |
it's possible... but not easily and what we can do here is limitted |
| 09:55 |
|
JesseDhammu |
and by mannually you mean i should export the list of books from old database,, and re issue them using circulation module after identifying the book names and patrons ..?? |
| 09:55 |
|
JesseDhammu |
what about the main problem .. |
| 09:56 |
|
JesseDhammu |
my koha upgrade script failed on the main server.. |
| 09:56 |
|
JesseDhammu |
thats why this all is happening ... |
| 09:56 |
|
JesseDhammu |
http://paste.koha-community.org/328 |
| 09:56 |
|
JesseDhammu |
this is the error i am facing after installing the updates.. |
| 10:03 |
|
JesseDhammu |
and one more thing .. which are the two tables where information about issued books is stored .?? |
| 10:03 |
|
JesseDhammu |
one is issues table that im sure |
| 10:03 |
|
JesseDhammu |
which is the other one ..? |
| 10:06 |
|
cait |
JesseDhammu: issues stores all the information about the issued books |
| 10:07 |
|
JesseDhammu |
only one table ..?? |
| 10:08 |
|
Joubu |
and old_issues |
| 10:08 |
|
JesseDhammu |
i dont want old issued records.. |
| 10:08 |
|
JesseDhammu |
i just need the current data ... |
| 10:08 |
|
cait |
then it's only one table. |
| 10:09 |
|
cait |
it has the itemnumber, borrowernumber, due date |
| 10:14 |
|
JesseDhammu |
ok .. so, when i imported only the bibliographic records on a fresh koha server, it will import the biblio data, but will assign item numbers acording to its own |
| 10:14 |
|
JesseDhammu |
and according to you, the old issues table will have the old scheme of item numbers.. |
| 10:15 |
|
JesseDhammu |
and thats why it wont work if i just export and import only one table .. |
| 10:15 |
|
JesseDhammu |
is that what are yo saying ..?? |
| 10:15 |
|
cait |
correct |
| 10:15 |
|
JesseDhammu |
ok i got it ... |
| 10:15 |
|
cait |
you'd have to get the new numbers for each, borrower and item |
| 10:16 |
|
JesseDhammu |
see i have only 199 books circulated that i could see from the old issues table .. . |
| 10:17 |
|
JesseDhammu |
so if i use Excel Vlookup, or any other probrame.. and replace the old item numbers with the new item numbers, (sort of modifying the issues table data), and then import that modified issues table to the new database would it work ..?? |
| 10:19 |
|
cait |
it kind of would probably |
| 10:21 |
|
JesseDhammu |
let me try |
| 10:21 |
|
JesseDhammu |
i would update you |
| 10:23 |
|
JesseDhammu |
by that time can you please check the upgrade issue which is the mother of all this hell ... |
| 10:24 |
|
JesseDhammu |
http://paste.koha-community.org/328 |
| 10:24 |
|
JesseDhammu |
here is the error log |
| 10:25 |
|
cait |
thre s also an on_loan field in the items tabel |
| 10:25 |
|
cait |
loading it via sql is more dangerous then doing it manually |
| 10:25 |
|
cait |
and if you change data in the items tabel you need to do a full reindex |
| 10:26 |
|
JesseDhammu |
how do i do that ..?? |
| 10:34 |
|
|
dcook__ joined #koha |
| 10:35 |
|
|
cait1 joined #koha |
| 10:38 |
|
|
JesseDhammu_ joined #koha |
| 10:39 |
|
|
bshum_ joined #koha |
| 10:39 |
|
|
mtj| joined #koha |
| 10:40 |
|
|
dcook joined #koha |
| 10:42 |
|
|
thd-away joined #koha |
| 10:44 |
|
|
burdsjm__ joined #koha |
| 10:44 |
|
|
reiveune joined #koha |
| 10:44 |
|
|
laurence joined #koha |
| 10:44 |
|
|
kivilahtio joined #koha |
| 10:44 |
|
|
RowdyChild|Away joined #koha |
| 10:44 |
|
|
kmlussier_ joined #koha |
| 10:44 |
|
|
alohalog` joined #koha |
| 10:44 |
|
|
druthb_away joined #koha |
| 10:44 |
|
|
huginn joined #koha |
| 10:44 |
|
|
pastebot joined #koha |
| 10:44 |
|
|
gaetan_B joined #koha |
| 10:45 |
|
|
khall joined #koha |
| 10:45 |
|
|
fridolin joined #koha |
| 10:45 |
|
|
eth0_ joined #koha |
| 10:45 |
|
|
sophie_m joined #koha |
| 11:14 |
|
JesseDhammu_ |
cait: i got the details of the books which are issued .. |
| 11:15 |
|
JesseDhammu_ |
so now apart from item number.. i have, the details like, borrower number, borrower name, barcode of the book, title of the book, author of the book, date of issue, due date .. |
| 11:16 |
|
JesseDhammu_ |
would it help now ..?? |
| 11:16 |
|
JesseDhammu_ |
cait1: ^ |
| 12:18 |
|
|
collum joined #koha |
| 12:38 |
|
ashimema |
Joubu.. fancy commenting on bug 13499 |
| 12:38 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13499 enhancement, P5 - low, ---, gmcharlt, NEW , Auth.pm needs a tidy |
| 12:38 |
|
ashimema |
I'm hoping to make Auth a bit more readable without affecting blame history ;) |
| 12:40 |
|
Joubu |
ashimema: the problem with this king of patches is it will add conflicts for patches already in the queue (NSO, NQA, PQA) |
| 12:41 |
|
ashimema |
true.. I could be pursuaded to do those initial rebases though... I tihnk this would make my life as mm easier as a whole |
| 12:42 |
|
ashimema |
there are 23 bugs affecting Auth.pm at the minute |
| 12:43 |
|
ashimema |
of which, so far most look trivial to rebase should this get pushed |
| 12:58 |
|
|
fridolin joined #koha |
| 13:11 |
|
|
fridolin joined #koha |
| 13:39 |
|
|
JoshB joined #koha |
| 13:47 |
|
|
edveal joined #koha |
| 13:55 |
|
|
Dyrcona joined #koha |
| 14:19 |
|
|
dac joined #koha |
| 14:24 |
|
|
NateC joined #koha |
| 14:30 |
|
|
cma joined #koha |
| 14:30 |
|
|
rambutan joined #koha |
| 14:59 |
|
|
carmen joined #koha |
| 16:05 |
|
reiveune |
bye |
| 16:05 |
|
|
reiveune left #koha |
| 16:12 |
|
fridolin |
byebye |
| 16:12 |
|
|
fridolin left #koha |
| 16:20 |
|
|
sophie_m1 joined #koha |
| 16:20 |
|
|
edveal joined #koha |
| 16:31 |
|
|
rocio joined #koha |
| 16:32 |
|
|
cait1 left #koha |
| 16:39 |
|
gaetan_B |
bye ! |
| 17:18 |
|
|
sophie_m1 left #koha |
| 17:19 |
|
|
laurence left #koha |
| 17:32 |
|
|
Joubu joined #koha |
| 17:34 |
|
|
cait joined #koha |
| 17:39 |
|
|
carmen joined #koha |
| 17:41 |
|
|
tcohen joined #koha |
| 18:27 |
|
|
ashimema_ joined #koha |
| 18:53 |
|
rangi |
morning |
| 18:53 |
|
ashimema_ |
evening |
| 18:53 |
|
cait |
hi rangi |
| 18:56 |
|
ashimema_ |
silly question... did we ever settle on a standard for logging? |
| 18:57 |
|
rangi |
not really, there are couple of interesting patches in the signoff queue to |
| 18:57 |
|
rangi |
tho |
| 18:57 |
|
rangi |
around logging, using cpan modules, and one that builds on that that stops SIP being so verbose in syslog (unless you want it to be) |
| 18:57 |
|
ashimema_ |
bug 8190 being one of them? |
| 18:57 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8190 enhancement, P5 - low, ---, jonathan.druart, In Discussion , Add a logging module to Koha |
| 18:58 |
|
rangi |
i cant test tho, cos they are from catalyst |
| 18:58 |
|
rangi |
theres that one |
| 18:58 |
|
ashimema_ |
ooh.. point me at them? |
| 18:58 |
|
rangi |
http://bugs.koha-community.org[…]_bug.cgi?id=13413 |
| 18:58 |
|
ashimema_ |
I'd love to see decent loggin but got lost in the discussions somewhere.. |
| 18:58 |
|
huginn |
Bug 13413: enhancement, P5 - low, ---, gmcharlt, Needs Signoff , Koha::Log - an attempt to have sane logging in Koha |
| 18:59 |
|
rangi |
http://bugs.koha-community.org[…]_bug.cgi?id=12952 |
| 18:59 |
|
huginn |
Bug 12952: enhancement, P5 - low, ---, srdjan, Needs Signoff , Log koha actions to syslog too |
| 19:01 |
|
jenkins_koha |
Starting build #22 for job Koha_3.18.x_U14 (previous build: STILL FAILING -- last SUCCESS #19 4 days 23 hr ago) |
| 19:01 |
|
rangi |
http://bugs.koha-community.org[…]&attachment=34189 this is the patch i like |
| 19:03 |
|
rangi |
or at lesat the idea i like :) |
| 19:05 |
|
ashimema_ |
cheers rangi.. |
| 19:05 |
|
ashimema_ |
i'll do some digging : |
| 19:05 |
|
rangi |
cool |
| 19:10 |
|
ashimema_ |
think I prefer that approach too just looking at it in brief.. will have to comment properly later.. need to go do some painting now |
| 19:11 |
|
* ashimema_ |
is getting a nursery ready :) |
| 19:11 |
|
rangi |
:) |
| 19:13 |
|
cait |
:) |
| 19:13 |
|
cait |
ashimema: which color for the walls? |
| 19:16 |
|
jcamins |
cait: teal. |
| 19:17 |
|
cait |
No tengo ningún gato? |
| 19:17 |
|
jcamins |
I don't have a cat? |
| 19:18 |
|
cait |
made as much sense as teal :) |
| 19:18 |
|
rangi |
teal is a colour cait |
| 19:18 |
|
cait |
i had to look it up... so i made him look up something |
| 19:19 |
|
* jcamins |
actually knew what it meant without looking it up, but looked it up anyway. |
| 19:19 |
|
cait |
ok, was just trying to buy time while looking it up? :) |
| 19:19 |
|
jcamins |
lol |
| 19:19 |
|
cait |
and i am doing my daily duolingo bit right now |
| 19:21 |
|
|
wnickc joined #koha |
| 19:23 |
|
cait |
@wunder Konstanz |
| 19:23 |
|
huginn |
cait: The current temperature in Konstanz, Germany is -2.0°C (8:00 PM CET on December 30, 2014). Conditions: Snow. Humidity: 96%. Dew Point: -2.0°C. Pressure: 30.63 in 1037 hPa (Rising). |
| 19:23 |
|
cait |
snow... nothing new |
| 19:42 |
|
|
druthb left #koha |
| 20:35 |
|
rangi |
right 17 tests fixed, down to 7 still failing |
| 20:35 |
|
* rangi |
is on the case |
| 20:41 |
|
rangi |
ah ha missed one other corner case |
| 20:41 |
|
rangi |
if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) ); |
| 20:42 |
|
rangi |
that works |
| 20:42 |
|
rangi |
unless $data{'userid'} is undef |
| 20:44 |
|
|
Joubu joined #koha |
| 20:46 |
|
jenkins_koha |
Starting build #23 for job Koha_3.18.x_U14 (previous build: STILL FAILING -- last SUCCESS #19 5 days 1 hr ago) |
| 20:52 |
|
|
dpk joined #koha |
| 20:54 |
|
|
ashimema_ joined #koha |
| 20:56 |
|
|
carmen joined #koha |
| 20:58 |
|
rangi |
working on a fix for bug 13502 now |
| 20:58 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13502 normal, P5 - low, ---, koha-bugs, NEW , A bug was introduced by 1861 - meaning borrowers sometimes cant be added |
| 20:58 |
|
cait |
rangi++ |
| 21:25 |
|
rangi |
right .. needs signoff now |
| 21:26 |
|
eythian |
hi |
| 22:09 |
|
dcook |
rangi++ |
| 22:10 |
|
* dcook |
was wondering a bit about the case where $data{'userid'} would be undef... that's one case where the old version of Check_Userid would probably work while the latter wouldn't.. |
| 22:10 |
|
rangi |
yeah |
| 22:17 |
|
|
sophie_m joined #koha |
| 22:28 |
|
|
pianohacker joined #koha |
| 22:31 |
|
|
ashimema_ joined #koha |
| 22:40 |
|
|
tcohen joined #koha |
| 22:50 |
|
|
wnickc joined #koha |
| 22:50 |
|
wnickc |
@wunder 05048 |
| 22:50 |
|
huginn |
wnickc: The current temperature in Quechee Lakes Sec 1, Quechee, Vermont is -8.3°C (5:50 PM EST on December 30, 2014). Conditions: Clear. Humidity: 47%. Dew Point: -18.0°C. Windchill: -8.0°C. Pressure: 30.33 in 1027 hPa (Steady). |
| 23:19 |
|
|
papa joined #koha |
| 23:47 |
|
|
jwellner joined #koha |
| 23:58 |
|
|
NateC joined #koha |
