| Time |
S |
Nick |
Message |
| 00:02 |
|
jcamins_away |
It seems to have been fixed. Could you please confirm? |
| 00:02 |
|
wizzyrea |
oh no, you will still need that |
| 00:02 |
|
wizzyrea |
it's still doing that string with single quotes |
| 00:02 |
|
wizzyrea |
let me triple check that |
| 00:03 |
|
wizzyrea |
because my brain is not quite right today :) |
| 00:03 |
|
wizzyrea |
yep, you'll still need to make that change |
| 00:04 |
|
wizzyrea |
in 6574 |
| 00:04 |
|
wizzyrea |
+ var is_confirmed = window.confirm(_('Are you sure you want to renew this patron\'s registration?')); |
| 00:04 |
|
wizzyrea |
needs to be double quoted. |
| 00:04 |
|
jcamins_away |
Why don't I see any Javascript errors? |
| 00:04 |
|
wizzyrea |
I can do a follow up for 6261 if you like |
| 00:04 |
|
wizzyrea |
it's not a javascript error |
| 00:04 |
|
wizzyrea |
it's a translation error |
| 00:04 |
|
jcamins_away |
A new patch on 6574 would be better. |
| 00:05 |
|
wizzyrea |
and you don't see it bc you're not using en-nz or en-gb |
| 00:05 |
|
jcamins_away |
I switched to en-GB. |
| 00:05 |
|
jcamins_away |
But I thought I was looking for a javascript error. |
| 00:05 |
|
wizzyrea |
did you re-run the translations? |
| 00:06 |
|
jcamins_away |
Yes. |
| 00:06 |
|
wizzyrea |
the problem is in the toolbar, it doesn't show in enGB |
| 00:07 |
|
jcamins_away |
Okay, there it is. |
| 00:07 |
|
jcamins_away |
Yeah, a new patch on 6574 is needed. |
| 00:07 |
|
wizzyrea |
okie dokie |
| 00:07 |
|
wizzyrea |
you are going to push 6261 |
| 00:07 |
|
wizzyrea |
? |
| 00:07 |
|
jcamins_away |
I did, yes. |
| 00:07 |
|
jcamins_away |
All pushed. :) |
| 00:07 |
|
wizzyrea |
cool I'll grab it and fix it up |
| 00:08 |
|
wizzyrea |
ftr, I love git aliases. |
| 00:08 |
|
jcamins_away |
Me too! |
| 00:10 |
|
jcamins_away |
I have a lot of great git aliases. |
| 00:10 |
|
huginn |
New commit(s) kohagit: Merge branch 'bug_9284' into 3.12-master <http://git.koha-community.org/[…]4bbaa84542d4c12e5> / Bug 9284 - JavaScript should follow rules recommended by JSHint <http://git.koha-community.org/[…]0705163ba0218549d> / Merge branch 'bug_8299' into 3.12-master <http://git.koha-community.org/[…]git;a=commitdiff; |
| 00:11 |
|
cait |
jcamins_away: I have none - what am I missing out on? |
| 00:11 |
|
jcamins_away |
Wonderfulness! |
| 00:11 |
|
cait |
jcamins_away: do you remember a while back there was a bug that broke deleting authorized values? |
| 00:11 |
|
wizzyrea |
being able to |
| 00:11 |
|
cait |
I thought I had seen you talking abou tthat but I can't find a bug |
| 00:12 |
|
cait |
but it seems mirko ran into it on 3309 |
| 00:12 |
|
wizzyrea |
git qa 6544 and have it check out master, fetch & rebase, then create a branch called qa-6544, then git bz apply 6544 |
| 00:12 |
|
wizzyrea |
for example |
| 00:13 |
|
wizzyrea |
it reduces dumb mistakes like checking out your qa branch from the wrong spot |
| 00:14 |
|
cait |
ah ok |
| 00:16 |
|
jenkins_koha |
Starting build #997 for job Koha_master (previous build: FIXED) |
| 00:17 |
|
jcamins_away |
cait: http://git.cpbibliography.com/[…]refs/heads/master |
| 00:18 |
|
wizzyrea |
oh I need your t |
| 00:19 |
|
jcamins_away |
I'm going to have to revise my increment script. |
| 00:19 |
|
jcamins_away |
t? |
| 00:19 |
|
wizzyrea |
your t gitalias ;) |
| 00:19 |
|
jcamins_away |
Ah. Yes. |
| 00:19 |
|
jcamins_away |
I actually don't use it anymore. |
| 00:20 |
|
jcamins_away |
release-tool.pl takes care of it for me. |
| 00:20 |
|
wizzyrea |
yea but sometimes you just want to run the tests |
| 00:20 |
|
wizzyrea |
for fun and profit. |
| 00:20 |
|
wizzyrea |
or something. |
| 00:20 |
|
wahanui |
something is wrong.... |
| 00:20 |
|
jcamins_away |
True. |
| 00:22 |
|
* cait |
bookmarks |
| 00:22 |
|
cait |
jcamins_away: thx :) but no idea about the bug? |
| 00:23 |
|
jcamins_away |
Yes, I pushed a fix. |
| 00:23 |
|
jcamins_away |
I think. |
| 00:29 |
|
cait |
hm |
| 00:30 |
|
wizzyrea |
cait: easy signoff - bug 6574 |
| 00:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6574 normal, P5 - low, ---, liz, Needs Signoff , js error in en-GB template breaks circulation toolbar |
| 00:31 |
|
cait |
hm |
| 00:31 |
|
cait |
jcamins_away: deltion works, but there is a bad error in the logs |
| 00:31 |
|
cait |
[Fri Dec 28 01:29:26 2012] [error] [client 127.0.0.1] [Fri Dec 28 01:29:26 2012] authorised_values.pl: DBD::mysql::st execute failed: Unknown column 'id' in 'where clause' at /home/katrin/kohaclone/admin/authorised_values.pl line 228., referer: http://localhost:8080/cgi-bin/[…]OC&id=17&offset=0 |
| 00:33 |
|
jcamins_away |
Okay, that means I didn't push the patch. |
| 00:33 |
|
cait |
hm or you did |
| 00:34 |
|
cait |
228 is part of the connexion library patch |
| 00:34 |
|
cait |
acbfe26c |
| 00:34 |
|
jcamins_away |
Yeah, so it wasn't pushed yet. |
| 00:35 |
|
cait |
ah ok |
| 00:35 |
|
cait |
do you have a patch? |
| 00:35 |
|
cait |
wantme to report a bug linked to the connexion one? |
| 00:36 |
|
jcamins_away |
There's a patch somewhere. |
| 00:36 |
|
jcamins_away |
Or at least a bug. |
| 00:36 |
|
jcamins_away |
It probably says "Plack" somewhere. |
| 00:36 |
|
cait |
hm |
| 00:36 |
|
cait |
I am not using plack and getting the error |
| 00:37 |
|
cait |
and it does delete, but shows me the error in the logs |
| 00:37 |
|
jcamins_away |
Yes, I am telling you what the bug says. |
| 00:37 |
|
jcamins_away |
It says "Plack" somewhere. |
| 00:39 |
|
cait |
bug 9272 |
| 00:39 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9272 major, P5 - low, ---, koha-bugs, Signed Off , Plack goes into paroxysms of horror when faced with deleting an authorized value |
| 00:39 |
|
wizzyrea |
lol, you should have searched for "paroxysms" |
| 00:39 |
|
wizzyrea |
because that's the memorable word there. |
| 00:40 |
|
jcamins_away |
lol |
| 00:40 |
|
jcamins_away |
I was close. |
| 00:41 |
|
druthb |
@quote add wizzyrea: lol, you should have searched for "paroxysms" |
| 00:41 |
|
huginn |
druthb: The operation succeeded. Quote #227 added. |
| 00:48 |
|
cait |
hehe |
| 00:53 |
|
jcamins_away |
Hm. |
| 00:54 |
|
jcamins_away |
Apparently using skip in the unit tests is non-trivial. |
| 00:54 |
|
wizzyrea |
hehe that's gonna show in the dashboard now |
| 00:54 |
|
cait |
jcamins_away: oh? |
| 00:55 |
|
jcamins_away |
Yeah, I just tried adding a bunch of skips, and it didn't work. |
| 00:58 |
|
cait |
what did it say? |
| 00:59 |
|
jcamins_away |
Nothing. |
| 00:59 |
|
wahanui |
nothing is a requirement, we have guidelines though |
| 00:59 |
|
jcamins_away |
It only ran 31 tests instead of 35. |
| 00:59 |
|
jcamins_away |
Which is not how skip is supposed to work. |
| 01:00 |
|
jcamins_away |
There were four tests that weren't skipped or run. |
| 01:04 |
|
jcamins_away |
Maybe we should put the test in t/experimental/ as-is. |
| 01:05 |
|
cait |
maybe |
| 01:07 |
|
jcamins_away |
Or, I suppose, just skip everything if the right version of DBD::Mock isn't available. |
| 01:14 |
|
|
melia left #koha |
| 01:16 |
|
|
NateC joined #koha |
| 01:22 |
|
jenkins_koha |
Project Koha_master build #997: SUCCESS in 1 hr 6 min: http://jenkins.koha-community.[…]/Koha_master/997/ |
| 01:22 |
|
jenkins_koha |
* oleonard: Bug 9289 - Adjacent checkbox behavior broken on circulation.pl |
| 01:22 |
|
jenkins_koha |
* oleonard: Bug 6261 [Revised] Consolidate patron toolbar include files |
| 01:22 |
|
jenkins_koha |
* srikanth: Bug 8712 - We should use WAI-ARIA guidelines to help with accessibility |
| 01:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9289 minor, P5 - low, ---, oleonard, Pushed to Master , Adjacent checkbox behavior broken on circulation.pl |
| 01:22 |
|
jenkins_koha |
* mtj: Bug 8299 - overdue_notice.pl shows error messages |
| 01:22 |
|
jenkins_koha |
* oleonard: Bug 9284 - JavaScript should follow rules recommended by JSHint |
| 01:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6261 enhancement, P5 - low, ---, oleonard, Pushed to Master , Consolidate patron toolbar include files |
| 01:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8712 enhancement, P5 - low, ---, oleonard, Needs Signoff , We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug |
| 01:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8299 normal, P5 - low, ---, nikhilvr0, Pushed to Master , overdue_notice.pl shows warning messages |
| 01:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9284 normal, P5 - low, ---, oleonard, Pushed to Master , JavaScript should conform to coding guidelines recommended by JSHint |
| 01:25 |
|
jcamins_away |
Could someone please sign off on the follow-up to bug 9209 and confirm that if you don't have a new version of DBD::Mock it doesn't do anything? |
| 01:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9209 normal, P5 - low, ---, tomascohen, Signed Off , Mocked Koha::Calendar tests |
| 02:19 |
|
jcamins_away |
Hey... what is the heading when you look at a system preferences page? |
| 02:19 |
|
wizzyrea |
1s |
| 02:20 |
|
jcamins_away |
I'm seeing "authorities.pref preferences" which seems... not right. |
| 02:20 |
|
wizzyrea |
koha -> Administration -> System preferences |
| 02:20 |
|
jcamins_away |
Right below that. |
| 02:20 |
|
wizzyrea |
hmmI'll just screencap |
| 02:20 |
|
wizzyrea |
:) |
| 02:20 |
|
wizzyrea |
then you can see |
| 02:21 |
|
jcamins_away |
Thanks. |
| 02:21 |
|
jcamins_away |
The syspref editor feels wrong to me, and I don't know if it is. |
| 02:21 |
|
wizzyrea |
http://imgur.com/gbCMM |
| 02:21 |
|
jcamins_away |
Oh. |
| 02:22 |
|
jcamins_away |
My brain. It has the dumb. |
| 02:22 |
|
jcamins_away |
It helps if you are looking at the English interface. |
| 02:23 |
|
wizzyrea |
oh, but you know what |
| 02:23 |
|
wizzyrea |
I *have* seen what you are talking about |
| 02:23 |
|
wizzyrea |
and it's in translations |
| 02:23 |
|
cait |
i think it's a translation error maybe |
| 02:23 |
|
wizzyrea |
yes, it has to be |
| 02:23 |
|
wizzyrea |
everything works |
| 02:23 |
|
cait |
from the po file |
| 02:23 |
|
wizzyrea |
but the buttons are labeled wrong... just one min |
| 02:23 |
|
cait |
if you don't skip the first part |
| 02:23 |
|
wizzyrea |
gah I can't remember who I was looking at that had that now >.< |
| 02:24 |
|
|
thd-away joined #koha |
| 02:24 |
|
wizzyrea |
cait I'm not sure what you mean? |
| 02:24 |
|
wizzyrea |
and why are you awake! |
| 02:24 |
|
cait |
sorry :) |
| 02:24 |
|
cait |
jared said: (03:18:50) jcamins_away: I'm seeing "authorities.pref preferences" which seems... not right. |
| 02:24 |
|
cait |
and I think hat's because the string should not have the authorities.pref part |
| 02:25 |
|
wizzyrea |
ah yea here it is |
| 02:26 |
|
jcamins_away |
Yep. Exactly what I'm seeing. |
| 02:26 |
|
wizzyrea |
do note that is not in the default language |
| 02:28 |
|
wizzyrea |
cait I'm not sure what you mean "if you don't skip the first part" |
| 02:28 |
|
cait |
don't translate it |
| 02:28 |
|
cait |
it's only for orientation like the comments |
| 02:29 |
|
cait |
i18n_10n.pref preferences translates to preferences only |
| 02:29 |
|
wizzyrea |
oh, I see, I think |
| 02:29 |
|
cait |
the pref file... has some special rules |
| 02:30 |
|
wizzyrea |
gotya |
| 02:30 |
|
|
thd-away` joined #koha |
| 02:32 |
|
cait |
i got it wrong the first time ... that's why I remember |
| 02:37 |
|
|
thd-away joined #koha |
| 02:40 |
|
|
thd-away` joined #koha |
| 02:43 |
|
|
thd-awa`` joined #koha |
| 02:46 |
|
|
thd-away joined #koha |
| 02:49 |
|
* chris_n |
notes that the weasels are at it again |
| 02:50 |
|
wizzyrea |
holy crap not good bug 9325 |
| 02:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9325 critical, P5 - low, ---, julian.maurice, Needs Signoff , overdue notices sent same messages for all users. |
| 02:51 |
|
wizzyrea |
very not super bad not good |
| 02:51 |
|
jcamins_away |
@later tell magnuse http://search.cpan.org/~jcamin[…]Plugin-MARC-0.02/ |
| 02:51 |
|
huginn |
jcamins_away: The operation succeeded. |
| 02:52 |
|
chris_n |
ouch, that is bad |
| 02:53 |
|
rangi |
i wonder how it happened, must have been a recent change |
| 02:54 |
|
rangi |
because that definitely didnt use to happen |
| 02:54 |
|
wizzyrea |
no, definitely not |
| 02:55 |
|
wizzyrea |
and it's not happening in 3.8, that I've heard of |
| 02:55 |
|
rangi |
nope |
| 02:55 |
|
rangi |
id have libraries yelling |
| 02:55 |
|
wizzyrea |
and BOY would people &^^^^^ that |
| 02:55 |
|
jcamins_away |
I just tested overdues a few days ago and it worked. |
| 02:55 |
|
jcamins_away |
It must have been a side effect of something else. |
| 02:56 |
|
rangi |
*nod* |
| 02:56 |
|
jcamins_away |
Well, seemed to work. |
| 02:56 |
|
jcamins_away |
Honestly, overdues make no sense to me. |
| 02:56 |
|
wizzyrea |
if only because it has to do with money and issues and privacy |
| 02:56 |
|
wizzyrea |
scary things. |
| 02:57 |
|
rangi |
well its pretty easy to spot if 2 ppl get the same message, run overdues and check the message queue table |
| 02:57 |
|
wizzyrea |
jcamins_away: I will look at that maybe this weekend - that's a no good very bad bug |
| 02:57 |
|
wizzyrea |
it can't sit |
| 02:57 |
|
rangi |
for something like that, i dont like having a patch |
| 02:57 |
|
rangi |
i like to see a git bisect |
| 02:57 |
|
rangi |
showing where the error crept in |
| 02:58 |
|
jcamins_away |
Yeah, especially with the proposed patch. |
| 02:58 |
|
rangi |
i found the commit |
| 02:58 |
|
rangi |
40f9914e60e002ae4cbf10d09cff8bbf32abd8fe |
| 02:58 |
|
rangi |
my $letter = parse_letter( |
| 02:58 |
|
rangi |
{ letter_code => $overdue_rules->{"letter$i"}, |
| 02:58 |
|
rangi |
+ letter => $letter_template, |
| 02:59 |
|
jcamins_away |
Hmm. |
| 02:59 |
|
jcamins_away |
But I just ran overdues and had different letters. |
| 02:59 |
|
jcamins_away |
And that was pushed three months ago. |
| 03:00 |
|
rangi |
yep, but would only be in 3.10.x |
| 03:00 |
|
rangi |
thats the line that introduces passing the template |
| 03:00 |
|
rangi |
im not sure about the bug tho, or the patch |
| 03:00 |
|
rangi |
because i cant reproduce |
| 03:01 |
|
wizzyrea |
yea it will need to be reproduced |
| 03:01 |
|
wizzyrea |
for sure |
| 03:01 |
|
jcamins_away |
I don't like the patch. |
| 03:01 |
|
rangi |
nope |
| 03:02 |
|
jcamins_away |
I try not to reject patches on the basis that "I don't like it," but I think that's one I would. |
| 03:02 |
|
rangi |
well it has no test plan |
| 03:03 |
|
jcamins_away |
Well, yeah, it was going to fail for that anyway. |
| 03:03 |
|
jcamins_away |
But even with a test plan, I don't like it. |
| 03:03 |
|
jcamins_away |
The way he's fixing the problem is wrong. It's just a band-aid, and not a logical one. |
| 03:03 |
|
chris_n |
<chant>revert</chant> |
| 03:04 |
|
rangi |
well id like to see the problem recreated first |
| 03:04 |
|
jcamins_away |
Me too. |
| 03:04 |
|
jcamins_away |
But if the problem happens there, it could happen somewhere else. |
| 03:05 |
|
jcamins_away |
If that variable has to be copied, it needs to be copied in C4::Letters. |
| 03:06 |
|
jcamins_away |
Or the POD needs to reflect what that routine does. |
| 03:06 |
|
rangi |
sub parse_letter is in that script |
| 03:07 |
|
jcamins_away |
parse_letter is just a wrapper around C4::Letters::GetProcessedLetter. |
| 03:07 |
|
rangi |
yes, but before it was GetPreparedLetter |
| 03:07 |
|
rangi |
and it didnt pass letter => $params->{'letter'} |
| 03:08 |
|
rangi |
copying it in the C4:: sub makes no sense |
| 03:09 |
|
jcamins_away |
If GetProcessedLetter isn't supposed to modify its parameters (and the POD is unclear but suggests to me that it's not), that is where the read-only limitation needs to be enforced. |
| 03:09 |
|
jcamins_away |
Though that particular idiom is dreadful anywhere. |
| 03:10 |
|
rangi |
yes |
| 03:10 |
|
rangi |
$params->{'letter'}->{'title'} = NFC($params->{'letter'}->{'title'}); |
| 03:10 |
|
rangi |
its certainly modifying them |
| 03:11 |
|
jcamins_away |
In which case this POD needs to be fixed. |
| 03:11 |
|
* jcamins_away |
doesn't understand what the code is supposed to do, so won't try and document it. |
| 03:11 |
|
rangi |
basically you give it a letter |
| 03:12 |
|
rangi |
it does a bunch of stuff to it |
| 03:12 |
|
rangi |
and hands it back |
| 03:12 |
|
rangi |
$letter->{title} =~ s/<<$token>>/$val/g; |
| 03:12 |
|
rangi |
etc etc |
| 03:13 |
|
jcamins_away |
Hm. So really the only change needed in the POD is "Return value: letter fields hashref (title & content useful) |
| 03:13 |
|
rangi |
its a hashref tho, so it will modify the values, so yes if you want to keep a copy, make a copy before you pass it, however, it should be making a new letter each borrower |
| 03:13 |
|
jcamins_away |
" => "Returns a reference to the processed letter" |
| 03:13 |
|
rangi |
return $letter; |
| 03:13 |
|
rangi |
yeah |
| 03:14 |
|
jcamins_away |
Because to me that first one tells me that it's creating a hashref of the letter fields, in which case I would expect any copying to be in C4. |
| 03:14 |
|
chris_n |
is it really making a copy or a "pointer"? |
| 03:15 |
|
jcamins_away |
chris_n: pointer, but the documentation doesn't say that. |
| 03:15 |
|
rangi |
the problem here is |
| 03:15 |
|
rangi |
my $letter = parse_letter( |
| 03:15 |
|
rangi |
{ letter_code => $overdue_rules->{"letter$i"}, |
| 03:15 |
|
rangi |
letter => $letter_template, |
| 03:16 |
|
jcamins_away |
As I read it, that should probably be "letter => C4::Letters::GetLetter ( module => 'circulation', letter_code => $overdue_rules->{"letter$i"}, branchcode => $branchcode); |
| 03:17 |
|
jcamins_away |
(though possibly not all on one line) |
| 03:17 |
|
rangi |
its trying to be effecient fetch the template once of each of the 3 codes |
| 03:17 |
|
rangi |
while ( my $overdue_rules = $rqoverduerules->fetchrow_hashref ) { |
| 03:17 |
|
rangi |
my $letter_template = C4::Letters::GetLetter ( |
| 03:18 |
|
jcamins_away |
Efficiency is good, but that weird copy thing makes it hard to understand. |
| 03:18 |
|
jcamins_away |
... as demonstrated by the fact that it took you fifteen minutes to explain what it was supposed to do. |
| 03:19 |
|
rangi |
well its not copying, you pass a hashref to it, it modifies it, hands it back |
| 03:19 |
|
rangi |
the problem is that its passing the same hashref all the time, and it should be different per borrower |
| 03:19 |
|
jcamins_away |
Right. I meant the weird copying thing that Jonathan does in his patch. |
| 03:20 |
|
chris_n |
stupid firefox |
| 03:20 |
|
rangi |
oh yeah, that should be done outside the call, probably up near the |
| 03:20 |
|
rangi |
while ( my ( $borrowernumber, $firstname, $lastname, $address1, $address2, $city, $postcode, $country, $email ) = $sth->fetchrow ) |
| 03:20 |
|
chris_n |
always crashing at the wrong time |
| 03:20 |
|
rangi |
line |
| 03:20 |
|
wizzyrea |
there is a good time? |
| 03:21 |
|
chris_n |
it did it good this time |
| 03:21 |
|
chris_n |
there's no process for it, but it still refuses to start |
| 03:21 |
|
* chris_n |
whips out chrome |
| 03:21 |
|
wizzyrea |
oh i've had that happen |
| 03:22 |
|
chris_n |
ouch |
| 03:22 |
|
* chris_n |
discovers his file system is ro |
| 03:22 |
|
chris_n |
not good |
| 03:22 |
|
jcamins_away |
chris_n: double-plus ungood. |
| 03:23 |
|
rangi |
http://bugs.koha-community.org[…]ug.cgi?id=9325#c2 |
| 03:23 |
|
huginn |
Bug 9325: critical, P5 - low, ---, julian.maurice, In Discussion , overdue notices sent same messages for all users. |
| 03:23 |
|
* chris_n |
heads off for a reboot.... at least |
| 03:24 |
|
jcamins_away |
Miracle of miracles! I can revert it. |
| 03:24 |
|
chris_n |
bbiab |
| 03:25 |
|
rangi |
did that make sense? |
| 03:25 |
|
rangi |
try and fix that bug 8378 a better way |
| 03:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 minor, P5 - low, ---, koha-bugs, Needs Signoff , <fine> syntax not working on overdues anymore |
| 03:25 |
|
jcamins_away |
That makes sense to me. |
| 03:25 |
|
rangi |
cool |
| 03:27 |
|
jcamins_away |
There should be a separate bug for the Unicode stuff. |
| 03:27 |
|
rangi |
yeah i think thats what actually introduced the problem |
| 03:32 |
|
wizzyrea |
oh yea, and there's the original report of the bug too - irritating. |
| 03:32 |
|
wizzyrea |
disk is cheap, make a new bug. |
| 03:34 |
|
rangi |
http://bugs.koha-community.org[…]g.cgi?id=8378#c19 |
| 03:34 |
|
huginn |
Bug 8378: minor, P5 - low, ---, koha-bugs, Needs Signoff , <fine> syntax not working on overdues anymore |
| 03:34 |
|
jcamins_away |
Okay, I am going to revert 8378. |
| 03:35 |
|
rangi |
http://bugs.koha-community.org[…]14069&action=diff same fix |
| 03:35 |
|
rangi |
but yeah reverting it is the best option |
| 03:35 |
|
rangi |
and now hometime |
| 03:39 |
|
jcamins_away |
Bedtime for me, I think. |
| 03:44 |
|
huginn |
New commit(s) kohagit: Revert "Bug 8378 - syntax not working on overdues anymore" <http://git.koha-community.org/[…]d78884c8b53c5b533> |
| 03:46 |
|
jenkins_koha |
Starting build #998 for job Koha_master (previous build: SUCCESS) |
| 04:31 |
|
|
insightful joined #koha |
| 04:33 |
|
insightful |
hi I am investigating LMS options and came across Koha. Can anyone tell me if Koha is accessible to blind users who use the Jaws print reader? |
| 04:43 |
|
|
trea left #koha |
| 04:53 |
|
jenkins_koha |
Project Koha_master build #998: SUCCESS in 1 hr 6 min: http://jenkins.koha-community.[…]/Koha_master/998/ |
| 04:53 |
|
jenkins_koha |
jcamins: Revert "Bug 8378 - <fine> syntax not working on overdues anymore" |
| 04:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 minor, P5 - low, ---, koha-bugs, In Discussion , <fine> syntax not working on overdues anymore |
| 05:09 |
|
|
thd-away` joined #koha |
| 06:16 |
|
jenkins_koha |
Starting build #40 for job Koha_3.10.x (previous build: SUCCESS) |
| 06:18 |
|
|
insightful joined #koha |
| 06:36 |
|
|
laurence joined #koha |
| 06:56 |
|
jenkins_koha |
Project Koha_3.10.x build #40: SUCCESS in 40 min: http://jenkins.koha-community.[…]b/Koha_3.10.x/40/ |
| 06:56 |
|
jenkins_koha |
jcamins: Revert "Bug 8378 - <fine> syntax not working on overdues anymore" |
| 06:56 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 minor, P5 - low, ---, koha-bugs, In Discussion , <fine> syntax not working on overdues anymore |
| 07:21 |
|
alex_a |
bonjour |
| 07:33 |
|
rangi |
hi alex_a |
| 07:37 |
|
alex_a |
hello rangi |
| 07:51 |
|
|
asaurat joined #koha |
| 08:04 |
|
|
Joubu joined #koha |
| 08:04 |
|
Joubu |
hi |
| 08:07 |
|
rangi |
hi asaurat and Joubu |
| 08:10 |
|
asaurat |
hi! |
| 08:15 |
|
|
fredericd joined #koha |
| 08:20 |
|
|
sophie_m joined #koha |
| 08:30 |
|
|
francharb joined #koha |
| 08:31 |
|
|
francharb joined #koha |
| 08:31 |
|
francharb |
good morning #koha |
| 08:32 |
|
rangi |
hi francharb |
| 08:32 |
|
|
cait joined #koha |
| 08:33 |
|
francharb |
hi rangi cait |
| 08:33 |
|
cait |
hi francharb, hi rangi |
| 08:34 |
|
rangi |
hi cait |
| 08:42 |
|
|
hdl joined #koha |
| 08:43 |
|
hdl |
hi |
| 08:43 |
|
wahanui |
hola, hdl |
| 08:43 |
|
hdl |
bye |
| 08:44 |
|
rangi |
heh |
| 09:37 |
|
rangi |
Joubu: did my comment make sense? |
| 09:37 |
|
rangi |
its tricky to spot because most developers have KOHA_CONF set so never notice |
| 09:39 |
|
Joubu |
rangi: yes! I can reproduce, thanks |
| 10:11 |
|
* magnuse |
waves |
| 10:19 |
|
magnuse |
jcamins++ for his first cpan module |
| 10:38 |
|
|
cait joined #koha |
| 10:41 |
|
|
gaetan_B joined #koha |
| 10:42 |
|
|
Oak joined #koha |
| 10:42 |
|
magnuse |
Oak |
| 10:42 |
|
Oak |
magnuse |
| 10:42 |
|
magnuse |
:-) |
| 10:42 |
|
* Oak |
waves |
| 10:42 |
|
Oak |
:) |
| 10:42 |
|
magnuse |
o/ |
| 10:43 |
|
Oak |
\o |
| 10:43 |
|
magnuse |
hiya cait and gaetan_B too |
| 10:43 |
|
* cait |
waves |
| 10:43 |
|
cait |
hi Oak :) |
| 10:43 |
|
Oak |
hello cait :) |
| 10:43 |
|
* gaetan_B |
too |
| 10:43 |
|
Oak |
2012... *sigh* |
| 10:43 |
|
cait |
not happy with 2012? |
| 10:44 |
|
Oak |
nah it's not like that |
| 10:44 |
|
Oak |
just the... passage of time. so fast. |
| 10:44 |
|
Oak |
swift. |
| 10:45 |
|
cait |
yeah, that's true |
| 10:45 |
|
cait |
have to go :) |
| 10:45 |
|
cait |
bbl |
| 10:45 |
|
Oak |
later |
| 10:56 |
|
magnuse |
yeah, 2012 was quick |
| 11:09 |
|
|
thd-away joined #koha |
| 11:12 |
|
|
asaurat left #koha |
| 11:18 |
|
|
pierre_paris joined #koha |
| 12:09 |
|
magnuse |
@wunder boo |
| 12:09 |
|
huginn |
magnuse: The current temperature in Bodo Vi, Norway is -3.0°C (1:00 PM CET on December 28, 2012). Conditions: Rain. Humidity: 91%. Dew Point: -4.0°C. Pressure: 29.64 in 1004 hPa (Rising). |
| 12:10 |
|
magnuse |
s/Rain/Snow/ |
| 12:11 |
|
|
jwagner joined #koha |
| 12:19 |
|
|
asaurat joined #koha |
| 12:27 |
|
jcamins_away |
Whoa! There are OpenSuSE packages! |
| 12:29 |
|
magnuse |
um, hooray? ;-) |
| 12:30 |
|
jcamins_away |
Yeah! |
| 12:36 |
|
* magnuse |
should probably find a more fetching title for bug 9256 |
| 12:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9256 critical, P5 - low, ---, koha-bugs, NEW , debian/templates/koha-conf-site.xml.in is hardcoded to retrieval syntax = usmarc |
| 12:38 |
|
jcamins |
magnuse: I recommend something with the word "paroxysms." |
| 12:38 |
|
magnuse |
hehe |
| 12:41 |
|
magnuse |
jcamins: i didn't manage to fit that in, but i hope bug 9256 sounds more scary now |
| 12:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9256 critical, P5 - low, ---, koha-bugs, NEW , Search is broken for 3.10 package-installs when marcflavour != marc21 |
| 12:42 |
|
jcamins |
Yup. Much scarier. |
| 12:43 |
|
magnuse |
yay |
| 12:48 |
|
magnuse |
i also wonder if bug 3087 made it impossible to have more than one marcflavour on the same server |
| 12:48 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=3087 enhancement, P3, ---, frederic, Pushed to Master , Z39.50 server returns usmarc format records for UNIMARC DB |
| 12:50 |
|
jcamins |
magnuse: I was pondering that. |
| 12:50 |
|
jcamins |
I think it may have. |
| 12:50 |
|
magnuse |
:-( |
| 12:51 |
|
magnuse |
or... |
| 12:51 |
|
magnuse |
we should probably not use /etc/koha/zebradb/etc/usmarc.mar for all marcflavours? |
| 12:51 |
|
magnuse |
have different files for different flavours, and then point to them as appropriate? |
| 12:53 |
|
jcamins |
I'm not sure we can make that change for packages as they are now. |
| 12:54 |
|
magnuse |
but will that problam only affect package installs? |
| 12:54 |
|
jcamins |
Wow it's early for rangi. |
| 12:54 |
|
magnuse |
yeah, weird :-) |
| 12:54 |
|
magnuse |
any thoughts on reverting 3087? |
| 12:55 |
|
magnuse |
it does seem to cause major problems to achieve a somewhat minor fix... |
| 12:55 |
|
jcamins |
I hesitate to do it because reverting it will break all non-MARC21 3.10 installs. |
| 12:56 |
|
rangi |
it wont just affect package installs, but its a lot harder to have 2 koha one server without packages .. so proably will affect less |
| 12:56 |
|
jcamins |
The problem will probably only affect packages because practically speaking no one can figure out how to make other installs work correctly together. |
| 12:57 |
|
jcamins |
If they could it would still be a problem if any configuration files were shared. |
| 12:57 |
|
rangi |
its not that hard, i used to do it before packages existed |
| 12:58 |
|
rangi |
but its unlikely many people are |
| 12:58 |
|
* magnuse |
too |
| 13:00 |
|
magnuse |
but yeah, it's probably not very common |
| 13:02 |
|
rangi |
what a mess |
| 13:05 |
|
rangi |
that whole changing a file called usmarc.mar ... to be other than usmarc ... how could that possibly be a good idea |
| 13:07 |
|
|
francharb joined #koha |
| 13:07 |
|
rangi |
ah well it will still be broken in the morning |
| 13:07 |
|
* rangi |
goes to sleep |
| 13:07 |
|
magnuse |
sleep tight rangi |
| 13:08 |
|
magnuse |
jcamins: guess it was late for rangi, not early ;-) |
| 13:08 |
|
jcamins |
Apparently so. |
| 13:08 |
|
jcamins |
Actually, it looks like we could correct it by having different files for each marcflavour. |
| 13:09 |
|
magnuse |
woot! |
| 13:12 |
|
jcamins |
The only place usmarc.mar is referenced is in record.abs. |
| 13:12 |
|
|
NateC joined #koha |
| 13:14 |
|
magnuse |
and there is one record.abs for each marcflavour, right? |
| 13:14 |
|
magnuse |
kia ora NateC! |
| 13:14 |
|
jcamins |
Two... one for bibs, one for authorities. |
| 13:14 |
|
magnuse |
yeah |
| 13:15 |
|
NateC |
Hiya Magnuse :) |
| 13:15 |
|
|
nengard joined #koha |
| 13:15 |
|
magnuse |
jcamins: i also had to edit /etc/koha/zebradb/retrieval-info-bib-dom.xml, i think |
| 13:17 |
|
|
oleonard joined #koha |
| 13:17 |
|
jcamins |
We have two options for those... move them to be instance-specific, or have one per marcflavour. |
| 13:18 |
|
jcamins |
Actually... I'm not entirely sure those are used. |
| 13:18 |
|
magnuse |
oops, i might have done stupid things... |
| 13:19 |
|
jcamins |
Oh, I see. |
| 13:19 |
|
jcamins |
They are. |
| 13:19 |
|
jcamins |
They're included by koha-conf.xml. |
| 13:22 |
|
|
oleonard left #koha |
| 13:30 |
|
|
oleonard__ joined #koha |
| 13:33 |
|
oleonard__ |
Many thanks to those who helped test Bug 6261. I'm very happy to have that one fixed. |
| 13:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6261 enhancement, P5 - low, ---, oleonard, Pushed to Master , Consolidate patron toolbar include files |
| 13:41 |
|
magnuse |
tidying_up++ |
| 13:41 |
|
|
asaurat left #koha |
| 13:43 |
|
|
asaurat joined #koha |
| 13:47 |
|
|
edveal joined #koha |
| 14:03 |
|
oleonard |
Joubu: Your patch on Bug 8845 is to be tested for signoff along with the others? |
| 14:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8845 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add ability search patrons by date of birth |
| 14:06 |
|
Joubu |
oleonard: my patch replaces the second patch of Kyle. So if you want to test it, you have to test it with the first proposed patch |
| 14:06 |
|
oleonard |
Okay, thanks |
| 14:17 |
|
|
libsysguy joined #koha |
| 14:56 |
|
|
maximep joined #koha |
| 14:56 |
|
|
BigRig joined #koha |
| 14:57 |
|
|
Callender_ joined #koha |
| 14:59 |
|
|
BigRig_ joined #koha |
| 15:03 |
|
|
BigRig__ joined #koha |
| 15:06 |
|
|
BigRig joined #koha |
| 15:08 |
|
|
BigRig_ joined #koha |
| 15:13 |
|
libsysguy |
who is bigrig? |
| 15:13 |
|
|
BigRig__ joined #koha |
| 15:21 |
|
gmcharlt |
libsysguy: BigRig__ is one of my colleagues at Equinox |
| 15:22 |
|
libsysguy |
ahh |
| 15:22 |
|
libsysguy |
I think he needs some smaller tires, he keeps bouncing (not that I am one to talk) |
| 15:34 |
|
|
rambutan joined #koha |
| 15:51 |
|
pierre_paris |
Hello everybody, I am a relatively fresh newbie. Is this the right place to submit two problems I encountered with Koha? |
| 15:51 |
|
oleonard |
Yes, pierre_paris |
| 15:51 |
|
wahanui |
i heard pierre_paris was getting the follwing error message : DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Access denied for user 'kohaadmin'@'localhost' (using password: YES) at /usr/share/koha/lib/C4/Context.pm line 758 Access denied for user 'kohaadmin'@'localhost' (using password: YES) at /usr/sha |
| 15:51 |
|
oleonard |
Heh. wahanui (a bot) remembers you! |
| 15:53 |
|
pierre_paris |
Thanks! This problem is now solved for me. I have two new ones :>) First big one : I have test loaded some 140,000 records and I would like to delete them all. How should I proceed? |
| 15:55 |
|
oleonard |
Drop the database and start over? It depends on how much configuration you want to save. |
| 15:57 |
|
oleonard |
Do I remember correctly that druthb had a good script for "cleaning" a test installation? |
| 15:57 |
|
druthb |
yes. |
| 15:58 |
|
pierre_paris |
Is this sufficient? I mean are the zebra indexes stored elsewhere than in the mysql DB? Is there a script option to do this? (I told you I was a newbie... :>) |
| 15:58 |
|
druthb |
https://www.gitorious.org/koha[…]lean_database.sql |
| 15:58 |
|
oleonard |
nengard: Don't forget to include a description and test plan with your patches! |
| 15:59 |
|
nengard |
it was a string patch ? |
| 15:59 |
|
druthb |
The zebra indexes are separate, yes, but you can kind of ignore that. When you re-import your data, just reindex, and that will overwrite the old ones. |
| 15:59 |
|
|
edveal1 joined #koha |
| 16:00 |
|
|
francharb joined #koha |
| 16:00 |
|
oleonard |
wahanui: forget pierre_paris |
| 16:00 |
|
wahanui |
oleonard: I forgot pierre_paris |
| 16:04 |
|
pierre_paris |
OK, thanks, I will try the script. Second question : All the search aspects are OK (web interface, SRU...) but I always get the folwing error with the yaz client : "Connecting...error = System (lower-layer) error: Connection refused" |
| 16:04 |
|
|
chris_n joined #koha |
| 16:05 |
|
pierre_paris |
I use the command : open tcp:localhost:9999/biblios |
| 16:06 |
|
* chris_n |
slowly climbs out of the pit of the bad magic number |
| 16:09 |
|
|
edveal joined #koha |
| 16:10 |
|
|
kf joined #koha |
| 16:11 |
|
magnuse |
huh, kf? |
| 16:11 |
|
wahanui |
kf is cait or really, really sweet. or <reply>she gives me memory loss or a holds expert. |
| 16:11 |
|
jcamins |
Shouldn't kf be on vacation? |
| 16:11 |
|
druthb |
I thought so too. |
| 16:13 |
|
* magnuse |
suspects foul play |
| 16:13 |
|
kf |
oh right :) |
| 16:13 |
|
kf |
wrong nick - occupying my dad's computer and using mibbit |
| 16:13 |
|
druthb |
:) |
| 16:13 |
|
jcamins |
Bug 8190 |
| 16:13 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8190 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Add a logging module to Koha, that can report log message to staff interface (for developer use) |
| 16:15 |
|
magnuse |
phew |
| 16:21 |
|
|
asaurat left #koha |
| 16:23 |
|
* magnuse |
calls it a year |
| 16:23 |
|
magnuse |
see you next year, folks :-) |
| 16:24 |
|
oleonard |
it was a good one magnuse. Here's to the next! |
| 16:34 |
|
Joubu |
bye all |
| 16:35 |
|
|
Joubu left #koha |
| 16:56 |
|
jcamins |
Time for server upgrades. Bye, all. |
| 16:57 |
|
|
jcamins joined #koha |
| 17:04 |
|
|
melia joined #koha |
| 17:07 |
|
|
thd-away` joined #koha |
| 17:19 |
|
|
uhusiano joined #koha |
| 17:21 |
|
uhusiano |
is it a problem with koha 3.10 installed with packages or what is it cos I cant seem to make changes on CSS nor add images as I did on tarball installed |
| 17:22 |
|
jcamins |
uhusiano: you'll have to give a lot more details about what it is you're trying to do. |
| 17:23 |
|
uhusiano |
I am trying to edit opac.css esp adding a banner with a custom banner |
| 17:23 |
|
jcamins |
Ah. |
| 17:23 |
|
jcamins |
Don't do that. |
| 17:23 |
|
libsysguy |
rule 1) don't edit the code that comes with Koha, use the system prefs |
| 17:23 |
|
jcamins |
Use the OpacUserCSS syspref. |
| 17:24 |
|
libsysguy |
rule 2) don't talk about fight club |
| 17:24 |
|
libsysguy |
shoot I always forgot to not talk about rule 2 |
| 17:25 |
|
jcamins |
lol |
| 17:25 |
|
uhusiano |
I have tried that on syspref I used <img src="../images/banner.png"> to get my banner on on opacheader invain |
| 17:26 |
|
libsysguy |
if you are trying to add img tags you shouldn't be using css |
| 17:28 |
|
uhusiano |
nope that was my 2nd problem |
| 17:28 |
|
uhusiano |
my first was adding custom css (fonts + colors), 2nd problem was images |
| 17:30 |
|
jcamins |
You should probably store the banner.png image somewhere other than in /usr/share/koha |
| 17:31 |
|
libsysguy |
agreed |
| 17:31 |
|
uhusiano |
i have stored it in /opac-tmpl/prog/en/images |
| 17:32 |
|
jcamins |
Yeah, that's not a good place. You should treat the file tree under /usr/share/koha as read-only. |
| 17:33 |
|
libsysguy |
yeah you should really put the images somewhere completely separate from Koha and have apache serve them |
| 17:33 |
|
|
chris_n joined #koha |
| 17:33 |
|
libsysguy |
you could try /var/www/ |
| 17:34 |
|
* libsysguy |
usually cheats and hotlinks the banner from somewhere else |
| 17:35 |
|
uhusiano |
let me try |
| 17:35 |
|
clrh |
good end of year #koha |
| 17:43 |
|
rambutan |
interesting. clrh is a hash of rhcl |
| 17:51 |
|
|
edveal left #koha |
| 17:54 |
|
rangi |
Morning |
| 17:54 |
|
wahanui |
Morning is a state of mind. or whenever the cat wants breakfast. |
| 18:12 |
|
|
laurence left #koha |
| 18:26 |
|
|
libsysguy joined #koha |
| 18:35 |
|
|
trea joined #koha |
| 18:43 |
|
clrh |
rambutan: I don't know rhcl :) |
| 18:43 |
|
clrh |
what does mean* |
| 18:43 |
|
clrh |
chemistry ? |
| 18:44 |
|
jcamins |
clrh: RHCL = Rolling Hills Consolidated Library (rambutan's library) |
| 18:55 |
|
rambutan |
sorry, was off for a bit. Yes, because Rolling Hills Consolidated Library is so long, we frequently just use the initials "RHCL", which is a transposition of the first/last half of your nic, "clrh" |
| 18:56 |
|
rambutan |
and to add to the fun, we are working on a sometimes nascent children's workstation called RaCHeL, which contains the initials RHCL. |
| 19:05 |
|
clrh |
aaah |
| 19:05 |
|
clrh |
:) |
| 19:36 |
|
|
maximep joined #koha |
| 19:37 |
|
|
jcamins_ joined #koha |
| 19:53 |
|
|
trea left #koha |
| 20:03 |
|
|
cait joined #koha |
| 20:07 |
|
|
sophie_m joined #koha |
| 20:08 |
|
rambutan |
https://github.com/AaronOgle/rachel |
| 20:08 |
|
cait |
hi all :) |
| 20:25 |
|
rambutan |
hi cait |
| 20:25 |
|
cait |
hi rambutan |
| 20:28 |
|
|
sophie_m left #koha |
| 20:31 |
|
libsysguy |
where are the package deps? |
| 20:31 |
|
* libsysguy |
hoped wahanui had an answer |
| 20:31 |
|
jcamins |
debian/control |
| 20:31 |
|
jcamins |
Unfortunately, only eythian can update it. |
| 20:32 |
|
rangi |
no anyone can |
| 20:32 |
|
rangi |
you just use the script |
| 20:32 |
|
jcamins |
Except me. |
| 20:32 |
|
rangi |
dont do it by hand |
| 20:32 |
|
rangi |
./debian/update-control |
| 20:32 |
|
libsysguy |
ah okay |
| 20:32 |
|
jcamins |
I used that, and the result was a package that eythian couldn't use. |
| 20:32 |
|
libsysguy |
well poo |
| 20:33 |
|
jcamins |
However, when he updates the control file, I'm able to use the resulting packages. |
| 20:33 |
|
libsysguy |
I don't want to piss off eythan |
| 20:33 |
|
jcamins |
Maybe because his host is Debian and mine is Ubuntu? |
| 20:33 |
|
rangi |
could be, i do it in a squeeze machine |
| 20:34 |
|
libsysguy |
do I pass it what I want to add? |
| 20:34 |
|
rangi |
you dont |
| 20:34 |
|
jcamins |
No, it just loads the list from C4::Installer::PerlDependencies. |
| 20:34 |
|
libsysguy |
i get errors if I just run it |
| 21:05 |
|
|
maximep left #koha |
| 21:28 |
|
|
nengard left #koha |
| 21:40 |
|
cait |
@wunder Konstanz |
| 21:40 |
|
huginn |
cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 4.3°C (10:35 PM CET on December 28, 2012). Conditions: Overcast. Humidity: 85%. Dew Point: 2.0°C. Windchill: 4.0°C. Pressure: 30.36 in 1028 hPa (Steady). |
| 21:41 |
|
rambutan |
@wunder 64507 |
| 21:41 |
|
huginn |
rambutan: The current temperature in Wyatt Park, St Joseph, Missouri is -2.0°C (3:39 PM CST on December 28, 2012). Conditions: Overcast. Humidity: 76%. Dew Point: -6.0°C. Windchill: -2.0°C. Pressure: 30.00 in 1016 hPa (Steady). |
| 21:44 |
|
jcamins |
@wunder 11735 |
| 21:45 |
|
huginn |
jcamins: The current temperature in Nassau/Suffolk County Line, East Farmingdale, New York is 1.8°C (4:41 PM EST on December 28, 2012). Conditions: Clear. Humidity: 69%. Dew Point: -3.0°C. Windchill: 2.0°C. Pressure: 30.03 in 1017 hPa (Rising). Winter Weather Advisory in effect from 8 am Saturday to 6 am EST Sunday... |
| 21:45 |
|
jcamins |
Yay! It's above freezing! |
| 21:47 |
|
druthb |
@wunder 66046 |
| 21:47 |
|
huginn |
druthb: The current temperature in Lawrence Live-Courtesy of the Khoury's, Lawrence, Kansas is -1.6°C (3:45 PM CST on December 28, 2012). Conditions: Haze. Humidity: 77%. Dew Point: -5.0°C. Windchill: -2.0°C. Pressure: 29.98 in 1015 hPa (Falling). |
| 21:47 |
|
* druthb |
shivers. |
| 21:52 |
|
* cait |
is cold too |
| 22:04 |
|
gmcharlt |
@wunder 98155 |
| 22:04 |
|
huginn |
gmcharlt: The current temperature in Shoreline, Seattle, Washington is 6.5°C (2:02 PM PST on December 28, 2012). Conditions: Scattered Clouds. Humidity: 98%. Dew Point: 6.0°C. Windchill: 7.0°C. Pressure: 30.12 in 1020 hPa (Steady). |
| 22:05 |
|
gmcharlt |
the wind chill is higher than the actual temperature? |
| 22:05 |
|
cait |
interesting |
| 22:05 |
|
wahanui |
i think interesting is sometimes good and sometimes bad |
| 22:05 |
|
cait |
hi gmcharlt |
| 22:05 |
|
gmcharlt |
hi cait |
| 22:38 |
|
jcamins |
bug 1993 |
| 22:38 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=1993 enhancement, P3, ---, sophie.meynieux, Signed Off , Task Scheduler Needs Re-write |
| 23:04 |
|
rangi |
[2012/12/29 12:02:17] ERROR - main::test_calledby - test calledby - main::test_calledby('test calledby') called |
| 23:04 |
|
rangi |
at t/Logger.t line 33 |
| 23:05 |
|
cait |
that looks... confusing |
| 23:06 |
|
rangi |
not really |
| 23:06 |
|
rangi |
its the time |
| 23:06 |
|
rangi |
the log level |
| 23:07 |
|
rangi |
the calling function, the log message, then the stacktrace |
| 23:07 |
|
rangi |
[2012/12/29 12:02:17] ERROR - main:: - an error string called at t/Logger.t line 31 |
| 23:07 |
|
rangi |
[2012/12/29 12:02:17] NORMAL - main:: - a normal string |
| 23:07 |
|
jcamins |
What's confusing about it is that the log message happens to match both the calling function and stacktrace. |
| 23:07 |
|
rangi |
etc |
| 23:08 |
|
rangi |
yep |
| 23:08 |
|
rangi |
passing 10 out of the 15 tests |
| 23:09 |
|
pastebot |
"rangi" at 127.0.0.1 pasted "KOHA_LOG="/tmp/test.log" perl" (32 lines) at http://paste.koha-community.org/328 |
| 23:09 |
|
|
thd-away joined #koha |
| 23:10 |
|
jcamins |
A bunch of those errors look to be because the level wasn't changed to a string everywhere. |
| 23:10 |
|
rangi |
yep |
| 23:11 |
|
rangi |
its the the dump one that isnt |
| 23:11 |
|
rangi |
2 secs new patch that should pass everything except dump |
| 23:12 |
|
jcamins |
I have a suggestion: wouldn't it be better to have a $log->dump($LEVEL, $variable) method? |
| 23:12 |
|
rangi |
makes sense to me |
| 23:12 |
|
jcamins |
Otherwise it looks like $log->warn($variable, 1), and I'd expect that to warn "$variable\t1" |
| 23:13 |
|
rangi |
$log is just a Log::Log4Perl object so we would have to make it an isa or the like to do that |
| 23:13 |
|
jcamins |
(because as far as I'm concerned warn should act like print) |
| 23:13 |
|
jcamins |
Oh, right. |
| 23:15 |
|
jcamins |
rangi: http://search.cpan.org/~mschil[…]ore_logging_them? (in case you haven't seen that yet) |
| 23:15 |
|
rangi |
ooh |
| 23:15 |
|
rangi |
sweet thanks |
| 23:16 |
|
rangi |
its a pretty nice module |
| 23:25 |
|
jcamins |
I don't think that it would be unreasonable to do use base and AUTOLOAD. |
| 23:27 |
|
jcamins |
I think it's about time to go home. |
| 23:27 |
|
jcamins |
I haven't decided what I want to make book boxes out, but I don't think I'm going to be able to do that today. |
| 23:27 |
|
rangi |
yeah im pretty much done for now, hopefully it mark spark someone elses imagination |
| 23:28 |
|
jcamins |
Fair enough. I might try the AUTOLOAD thing, just 'cause it's cool. |
| 23:28 |
|
* cait |
gives you both cookies |
| 23:28 |
|
cait |
I wouldparticipate in the discussion... but it's totally over my head :) |
| 23:28 |
|
jcamins |
Nonsense. |
| 23:28 |
|
jcamins |
So long, #koha. |
| 23:28 |
|
cait |
bye jcamins_away |
| 23:29 |
|
rangi |
i think we need appender.Stderr = Log::Log4perl::Appender::Screen |
| 23:29 |
|
rangi |
as well |
| 23:29 |
|
rangi |
for that but thats easy |
| 23:29 |
|
rangi |
and yep im done too |
| 23:30 |
|
cait |
bye rangi |
| 23:49 |
|
|
rambutan left #koha |
