Time |
S |
Nick |
Message |
00:53 |
|
|
libsysguy left #koha |
04:25 |
|
|
drojf joined #koha |
04:44 |
|
|
wajasu joined #koha |
04:49 |
|
wajasu |
just tried to reverse engineer the koha mysql schema. she's a beaute! |
04:53 |
|
|
drojf joined #koha |
05:05 |
|
|
drojf1 joined #koha |
05:14 |
|
|
drojf joined #koha |
06:02 |
|
|
sophie_m joined #koha |
06:37 |
|
|
sophie_m left #koha |
06:49 |
|
|
sophie_m joined #koha |
06:51 |
|
rangi |
wajasu: no need to do that its all documented |
06:51 |
|
rangi |
http://schema.koha-community.org/ |
06:51 |
|
wahanui |
http://schema.koha-community.org/ are you looking here? |
06:54 |
|
|
adnc joined #koha |
07:18 |
|
|
sophie_m left #koha |
07:26 |
|
|
francharb joined #koha |
07:27 |
|
francharb |
good morning #koha |
07:28 |
|
ropuch |
Good morning :) |
07:31 |
|
rangi |
francharb: http://stats.workbuffer.org/scroller.html |
07:31 |
|
rangi |
and good morning :) |
07:32 |
|
rangi |
im totally rewriting the whole thing now |
07:34 |
|
|
mbalmer joined #koha |
07:38 |
|
mbalmer |
morning |
07:38 |
|
ropuch |
Too much text for <h2> ;-) |
07:38 |
|
ropuch |
rangi: consider moving some part of info outside of <h2></h2> |
07:39 |
|
ropuch |
Below maybe? ;> |
07:39 |
|
rangi |
im rewriting the whole thing |
07:39 |
|
ropuch |
I can see changes from yesterday version ;> |
07:39 |
|
rangi |
yeah im ditching it, rewriting in dancer |
07:54 |
|
ibeardslee |
not prancer? |
07:55 |
|
ibeardslee |
or vixen or comet |
07:55 |
|
|
cait joined #koha |
07:56 |
|
cait |
morning #koha |
07:59 |
|
francharb |
0/ cait |
07:59 |
|
cait |
hi francharb :) |
08:08 |
|
|
drojf joined #koha |
08:12 |
|
drojf |
hi #koha |
08:26 |
|
cait |
wow |
08:26 |
|
cait |
I can search again |
08:26 |
|
cait |
after reverting one patch |
08:29 |
|
drojf |
great |
08:29 |
|
drojf |
what patch was it? |
08:30 |
|
cait |
the same htat gave jared trouble |
08:30 |
|
cait |
adding limits to search history |
08:31 |
|
cait |
I am sure it didn't do that when I tested it |
08:32 |
|
drojf |
ah the one that rangi reverted out of 3.8? |
08:34 |
|
rangi |
yep |
08:34 |
|
cait |
exactly that one |
08:34 |
|
cait |
i really wonder what's going wrong there, strange symptoms |
08:35 |
|
drojf |
oh-oh that could have been bad |
08:35 |
|
cait |
drojf: but you weren't able to confirm the problem... it still quite a mystery |
08:35 |
|
cait |
did you activate search history? |
08:36 |
|
drojf |
not that i know of |
08:39 |
|
cait |
not sure if it's activated by default or not |
08:39 |
|
cait |
it would show up as a separate link on top of your opac |
08:40 |
|
cait |
where the link to the borrower account is |
08:41 |
|
|
adnc joined #koha |
08:42 |
|
drojf |
oh yes i had thar |
08:42 |
|
drojf |
that |
08:43 |
|
drojf |
apparently it does not break everything for everybody or it would not have been pushed to 3.8 |
08:44 |
|
cait |
hm yeah, but it certainly broke my master installation |
08:44 |
|
cait |
perhaps some bad combination of preferneces? I am running out of ideas... |
08:44 |
|
cait |
only glad I can continue testing now |
08:45 |
|
cait |
ok brb |
09:11 |
|
|
drojf1 joined #koha |
09:32 |
|
cait |
@wunder Konstanz |
09:32 |
|
huginn |
cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 21.1°C (11:30 AM CEST on July 08, 2012). Conditions: Mostly Cloudy. Humidity: 69%. Dew Point: 15.0°C. Pressure: 29.95 in 1014 hPa (Steady). |
09:32 |
|
cait |
not so hot today it seems :) |
09:36 |
|
cait |
oook, deactivating search history in opac fixes all my problems on master (for the logs ;) ) |
09:36 |
|
drojf1 |
heh |
09:37 |
|
rangi |
http://dashboard.koha-community.org/ |
09:37 |
|
rangi |
checkout the random bug |
09:38 |
|
rangi |
it pulls up one that isnt closed, resolved or pushed |
09:38 |
|
cait |
wow cool! |
09:39 |
|
cait |
rangi++ |
09:39 |
|
cait |
I love it |
09:39 |
|
cait |
one problem with gbsd I think was lack of visuals :) this is very nice! |
09:39 |
|
drojf1 |
hey that's cool |
09:39 |
|
drojf1 |
rangi++ |
09:39 |
|
rangi |
im gonna add oldest 5 bugs needing sign off now |
09:40 |
|
drojf1 |
make it look scary so we get a guilty conscience :) |
09:41 |
|
cait |
hehe |
09:41 |
|
cait |
yeah :) |
09:41 |
|
cait |
hm I could try to come up with some css |
09:41 |
|
cait |
for the last 10 sign offs |
09:41 |
|
drojf1 |
make a double rainbow for jcamins_away |
09:41 |
|
drojf1 |
he has half the sign offs |
09:43 |
|
rangi |
thatwould be good, any css gratefully accepted |
09:43 |
|
cait |
yeah |
09:43 |
|
cait |
thinking |
09:43 |
|
rangi |
im making that 5, and 5 needs signoff |
09:43 |
|
rangi |
and ill also try to get info from jenkins to display |
09:44 |
|
cait |
we don't have long lines here, so I think breaking the information on 2 lines would be better |
09:44 |
|
cait |
like name and time and bug number and description on next |
09:44 |
|
cait |
and then give some more space between entries |
09:45 |
|
cait |
I am making a dummy |
09:50 |
|
|
drojf joined #koha |
09:51 |
|
* drojf |
tries a different modem |
09:51 |
|
cait |
good luck :) |
09:51 |
|
drojf |
thanks |
09:51 |
|
drojf |
but the one i'm trying is supposed to be the one that acts weird |
09:52 |
|
drojf |
i'll guess i'll make them send me a third one :( |
09:52 |
|
cait |
meh |
09:52 |
|
cait |
it refuses to upload the picture |
09:52 |
|
francharb |
hey cait, do you know the difference between "budget_manage" and "budget_add_del"/"budget_modify" permissions in the acquisition module |
09:52 |
|
francharb |
? |
09:52 |
|
drojf |
eeew some plastic waste is hanging down on my balkony from the guy one floor up |
09:52 |
|
cait |
no but there is a long standing bug abou tit |
09:52 |
|
cait |
and noone ever gave me an answer |
09:52 |
|
cait |
look for acquisition permissons |
09:52 |
|
drojf |
balcony even |
09:53 |
|
francharb |
cait, I will ask julian tomorrow |
09:53 |
|
cait |
francharb: it's been confusing from the beginning :( and the descriptions are sometimes even the same |
09:53 |
|
cait |
francharb: please ask him to take a look at the bug too maybe? |
09:53 |
|
cait |
bug 3849 |
09:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=3849 normal, P5 - low, ---, paul.poulain, NEW , Acq Permissions unclear |
09:53 |
|
cait |
it's really an old one |
09:54 |
|
rangi |
updated |
09:55 |
|
francharb |
cait, the thing I already know is that "period" means "budgets" and "budgets" means "funds" |
09:55 |
|
francharb |
:) |
09:55 |
|
cait |
confusing! heh |
09:55 |
|
cait |
we should really make it match the interface at least |
09:55 |
|
cait |
wher eit shows in the interface |
09:55 |
|
rangi |
the needs signoff will get new ones every 100000 milliseconds |
09:55 |
|
francharb |
and I guess : manage budget is when you want librarian to be able to use funds |
09:56 |
|
francharb |
and budget add/del modify is to allow librarian to manage funds on the admin level |
09:56 |
|
francharb |
cait++ |
09:56 |
|
drojf |
rangi: the number of last signoffs is a lie ;) |
09:56 |
|
rangi |
oh yeah ill change that |
09:56 |
|
cait |
rangi give me a minute to show oyu my screenshot... all my tools acting up toda |
09:56 |
|
cait |
y |
09:56 |
|
* francharb |
is adding something new on his todo list |
09:56 |
|
francharb |
\0/ |
09:58 |
|
francharb |
(by the way, I'm using trello.com to help me getting organised. it's kind of cool! i recommend it ;) |
09:58 |
|
francharb |
time for lunch |
09:58 |
|
francharb |
see you later |
09:59 |
|
cait |
rearranged the information a bit and added padding:5px to the li element |
09:59 |
|
rangi |
looking now |
10:00 |
|
rangi |
can you paste the css/html |
10:00 |
|
cait |
it's a bit ugly because I did it in firebug, give me a sec |
10:07 |
|
cait |
hm instead of using padding:5px you could do padding-bottom:10px - then the other things will fit a bit better |
10:08 |
|
cait |
and maybe give the content div a bit of margin to the left border |
10:08 |
|
cait |
margin:left:5px or something |
10:08 |
|
cait |
I am not so good with css - owen would probably not be too happy with me :) |
10:17 |
|
rangi |
hows that? |
10:18 |
|
cait |
yay :) |
10:18 |
|
cait |
I like it :) |
10:18 |
|
cait |
hope you do too? |
10:18 |
|
rangi |
yup |
10:18 |
|
|
ibeardslee joined #koha |
10:18 |
|
cait |
cool :) |
10:18 |
|
rangi |
wanna reply to my mail, with the link to that |
10:18 |
|
rangi |
im gonna turn the other one off |
10:18 |
|
cait |
ah, so what do you want me to rewrite? |
10:18 |
|
cait |
new improved version at ... ? |
10:19 |
|
rangi |
:) |
10:19 |
|
rangi |
yep, in the spirit of collaboration that koha is famous for :-) |
10:19 |
|
cait |
you did all the work on it :) |
10:21 |
|
rangi |
updated the nav |
10:21 |
|
cait |
maybe better use {padding-bottom:10px;} and add some padding to the content element? it looks a bit squashed |
10:22 |
|
rangi |
? |
10:23 |
|
cait |
#content {padding:Â 15px 20px 15px 10px;} |
10:23 |
|
cait |
what would make it the same as the sidebar |
10:23 |
|
cait |
moving the text a bit away from the borders |
10:23 |
|
rangi |
lemme try |
10:24 |
|
cait |
and then: #example_4 ul li {Â Â Â Â padding-bottom:Â 10px;} |
10:24 |
|
cait |
because else the left padding adds up |
10:24 |
|
rangi |
like that? |
10:29 |
|
cait |
rangi: the needs signoff are the oldest now? or random? |
10:29 |
|
rangi |
oldest |
10:33 |
|
francharb |
re |
10:33 |
|
rangi |
wb francharb |
10:34 |
|
francharb |
\0/ rangi |
10:35 |
|
cait |
rangi: about the css - still looks the same? |
10:36 |
|
cait |
nice navigation :) |
10:36 |
|
cait |
rangi: I think the css does not work because there are some weird characters in there |
10:37 |
|
cait |
I will make you a clean paste |
10:37 |
|
rangi |
hmm? |
10:37 |
|
cait |
http://paste.koha-community.org/18 |
10:43 |
|
rangi |
hows that? |
10:44 |
|
cait |
yep |
10:44 |
|
cait |
:) |
10:44 |
|
cait |
now it looks like intended |
10:46 |
|
cait |
so if you now made last 5 sign offs h3 instead of h2... all the headlines would be the same size |
10:46 |
|
cait |
:P |
10:46 |
|
cait |
yes, I am terrible |
10:47 |
|
cait |
hm jenkins status is h2 too, it's only b it of mixed, perhaps intentional |
10:51 |
|
rangi |
all h3 now |
10:58 |
|
cait |
yay |
10:58 |
|
cait |
:) |
10:58 |
|
cait |
what will jenkins show? |
10:59 |
|
rangi |
probably just the status of jobs |
11:01 |
|
cait |
:) |
11:41 |
|
cait |
drojf++ for overdue bug 7143 |
11:41 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, katrin.fischer, Passed QA , Bug for tracking changes to the about page |
12:18 |
|
|
BobB joined #koha |
12:26 |
|
|
adnc joined #koha |
12:36 |
|
jcamins |
Hey, didn't I sign off on bug 5635? |
12:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5635 enhancement, P1 - high, ---, stephane.delaune, Needs Signoff , bulkmarcimport new parameters & features |
12:38 |
|
cait |
jcamins: I can't remember |
12:38 |
|
cait |
but I had to fail 2 of your patches :( |
12:39 |
|
jcamins |
cait: oh no! |
12:39 |
|
cait |
I am sorry :( |
12:39 |
|
jcamins |
That's what QA is for. |
12:39 |
|
cait |
yeah, but I am still sorry |
12:40 |
|
jcamins |
Could you attach a screenshot of bug 8204? |
12:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8204 enhancement, P5 - low, ---, jcamins, Failed QA , Authority viewer in OPAC ugly, unfriendly, and mostly useless |
12:41 |
|
cait |
what's the critical point? |
12:41 |
|
jcamins |
I'm wondering where the links to the MARC view went. |
12:41 |
|
jcamins |
I'm hoping if I see a screenshot, it will give me a hint about why the tabs aren't there. |
12:42 |
|
cait |
ah |
12:42 |
|
cait |
so there should be tabs to different views? |
12:42 |
|
jcamins |
Yup. |
12:42 |
|
jcamins |
Also, the hash thing is an old bug. |
12:42 |
|
jcamins |
Actually, let me see when I attached the patch. |
12:42 |
|
cait |
it's not appearing on current master |
12:43 |
|
jcamins |
Old bug in my code. |
12:43 |
|
jcamins |
Of course it doesn't appear on current master... neither does any indication of what the main entry is. ;) |
12:43 |
|
cait |
oh ! |
12:43 |
|
cait |
I missed the tabs |
12:43 |
|
cait |
I am sorry! |
12:44 |
|
cait |
the tabs are there :) |
12:44 |
|
cait |
so it's only the hash thing |
12:44 |
|
cait |
and maybe not showing the headline when there are no entries following |
12:46 |
|
cait |
hm |
12:46 |
|
cait |
and the fact that my system keeps mailing errors |
12:47 |
|
jcamins |
Okay, found the errors. |
12:58 |
|
cait |
jcamins: have you seen http://dashboard.koha-community.org/ |
12:58 |
|
cait |
? |
12:58 |
|
jcamins |
cait: I have. |
12:58 |
|
jcamins |
It's very, very cool! |
12:59 |
|
cait |
it totally is! rangi++ |
13:03 |
|
jcamins |
8204 is ready for another look. :) |
13:07 |
|
cait |
ok |
13:07 |
|
cait |
going back to that |
13:08 |
|
jcamins |
:) |
13:09 |
|
cait |
hm |
13:54 |
|
|
mveron joined #koha |
13:55 |
|
mveron |
hi #koha |
13:55 |
|
cait |
hi mveron :) |
13:56 |
|
cait |
why are you not at the beach!? |
13:56 |
|
mveron |
It is to hot... |
13:56 |
|
cait |
@wunder Konstanz |
13:56 |
|
huginn |
cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 24.3°C (3:55 PM CEST on July 08, 2012). Conditions: Scattered Clouds. Humidity: 61%. Dew Point: 16.0°C. Pressure: 29.92 in 1013 hPa (Steady). |
13:56 |
|
cait |
mveron: I can undertand that reasoning |
13:56 |
|
mveron |
24° is not bad... |
13:56 |
|
cait |
no, it's nice |
13:57 |
|
mveron |
But the early morning and the evennings are nics |
13:57 |
|
jcamins |
Ah-ha! |
13:57 |
|
mveron |
Much sun, I have not to much contraast on my screen... |
13:58 |
|
mveron |
mbalmer around? |
14:03 |
|
mveron |
@wunder Kamares |
14:03 |
|
huginn |
mveron: Error: No such location could be found. |
14:04 |
|
cait |
haven't seen mbalmer today I think |
14:05 |
|
|
libsysguy joined #koha |
14:05 |
|
mveron |
Thanks, cait :-) |
14:11 |
|
|
libsysguy left #koha |
14:26 |
|
* mveron |
...has to get some cold drink :-) |
14:47 |
|
francharb |
see you later |
14:59 |
|
mbalmer |
cait, actually I am here |
15:04 |
|
cait |
ah |
15:04 |
|
cait |
only meant I didn't see you talking that day |
15:05 |
|
* cait |
just finished her attempt on making baileys fudge like bought in edinburgh |
15:05 |
|
mbalmer |
yeah, I did not say much, was occupied with debian packaging stuff and setting up secure chrooted repositories |
15:06 |
|
cait |
... and I covered half of my kitchen in caramel... |
15:06 |
|
mbalmer |
hehe ;( |
15:07 |
|
cait |
hope the result is worth all the stickiness |
15:09 |
|
cait |
the first saucepan was too small |
15:10 |
|
mbalmer |
it will work out. |
15:11 |
|
jcamins_away |
Why did you chroot the repository? |
15:11 |
|
cait |
thx :) |
15:12 |
|
mbalmer |
jcaming_away, every "customers" gets an account and registers the machines using a ssh key. they can access the repo in a safe manner and only get the packages they need to (we use the apt-get ssh method) |
15:13 |
|
jcamins_away |
mbalmer: ah, I see. |
15:13 |
|
mbalmer |
so they don't get a shell when they log in via ssh, they can only execute the commands apt-get needs, and are confined to a chroot jail. |
15:14 |
|
jcamins_away |
Right, that makes sense. |
15:14 |
|
* jcamins_away |
uses a regular apt repo, so it's just a matter of apt-get upgrade on the customer's server. |
15:14 |
|
|
libsysguy joined #koha |
15:15 |
|
mbalmer |
wrote a small shell, aptsh, which allows only find and dd to be executed, aka what apt-get needs. that plus chroot makes it more or less secure (I I think more more than less) |
15:15 |
|
mbalmer |
yes, and this is a regular repo, clients use synaptic or apt-get update/apt-get upgrade |
15:17 |
|
jcamins_away |
Ah, just one only accessed via SSH. |
15:17 |
|
mbalmer |
client enters our server to the apt sources and hands in his ssh key. we then decide what packages he "sees" |
15:17 |
|
mbalmer |
yes, and of course it contains only the "special" packages, i.e. customer specific ones. |
15:17 |
|
jcamins_away |
Okay, that's pretty cool. :) |
15:18 |
|
mbalmer |
in the case of licensed software, he only sees those packages he licensed. an all seems to be secure. |
15:37 |
|
drojf |
@wunder berlin, germany |
15:37 |
|
huginn |
drojf: The current temperature in Prenzlauer Berg, Berlin, Germany is 25.9°C (5:13 PM CEST on July 08, 2012). Conditions: Overcast. Humidity: 49%. Dew Point: 14.0°C. Pressure: 29.77 in 1008 hPa (Steady). |
15:37 |
|
cait |
hi drojf |
15:37 |
|
drojf |
hey cait |
15:37 |
|
cait |
@wunder Konstanz |
15:37 |
|
drojf |
overcast. haha. thunderstorm again |
15:37 |
|
huginn |
cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 23.7°C (5:35 PM CEST on July 08, 2012). Conditions: Mostly Cloudy. Humidity: 65%. Dew Point: 17.0°C. Pressure: 29.92 in 1013 hPa (Steady). |
15:47 |
|
|
sandeepbhavsar joined #koha |
15:48 |
|
sandeepbhavsar |
hi all |
15:55 |
|
|
libsysguy joined #koha |
16:20 |
|
drojf |
rangi: can you make the "last signoffs" appear in a different colour if it was a bug from the "needs signoff" list? |
16:21 |
|
drojf |
like, premium signoff? |
16:23 |
|
cait |
the older the better? |
16:24 |
|
cait |
I fear my fudge is not setting |
16:24 |
|
drojf |
oooh |
16:24 |
|
cait |
or i am afraid it does not |
16:24 |
|
cait |
*sigh* |
16:25 |
|
drojf |
don't know mudge (haha) about fudgemaking, but maybe some patience will help |
16:25 |
|
cait |
i hope |
16:25 |
|
* drojf |
hopes too |
16:26 |
|
cait |
thx :) |
16:27 |
|
|
adnc joined #koha |
19:07 |
|
|
mbalmer joined #koha |
19:08 |
|
* drojf |
wonders what he has to do to index authorities so that they can be found |
19:09 |
|
mbalmer |
so |
19:10 |
|
drojf |
so? |
19:10 |
|
wahanui |
so is a long road. |
19:11 |
|
jcamins_away |
drojf: shouldn't need to do much of anything. |
19:12 |
|
mbalmer |
so means I am going to take a sauna bath ;) |
19:12 |
|
drojf |
jcamins_away: i added an authority personal name record when i wanted to try a patch of you. turned out it shows up nowhere |
19:12 |
|
drojf |
mbalmer: too much information :P |
19:12 |
|
mbalmer |
it's only hot |
19:14 |
|
drojf |
jcamins_away: i have not really done anything with authorities before so maybe i'm just missing something. zebra said something of 4 authority records, nut i cannot find them either in opac or staff client |
19:14 |
|
drojf |
+but |
19:15 |
|
mbalmer |
the hot pot is a cool place to discuss koha features, trust me! |
19:37 |
|
|
paul_p_android joined #koha |
19:39 |
|
drojf |
jcamins_away: so you are right in the end and now it just shows up. weird, because i put that data in yesterday. |
19:48 |
|
rangi |
Wow not one of those suggestions is either valid or good |
19:49 |
|
jcamins |
rangi: I wondered. |
19:50 |
|
cait |
rangi, jcamins? |
19:51 |
|
jcamins |
cait: on the list. |
19:51 |
|
* jcamins |
won't get involved. |
19:53 |
|
cait |
hm me neither |
19:53 |
|
cait |
not until I have figured it out with my coworker |
19:54 |
|
rangi |
Well it's easy syspref and move on to something actually useful. |
19:54 |
|
rangi |
Pointless discussions are pointless |
19:57 |
|
rangi |
And let 'helpful' people help |
19:59 |
|
drojf |
yes i don't see why "let's have a syspref" is not the one and only answer to this. after that i don't care what anybody does with it |
20:02 |
|
rangi |
Slightly |
20:02 |
|
drojf |
"Solr uses at least 1Gb of memory by default and http://vufind.org/wiki/performance suggests more than 4Gb" |
20:02 |
|
drojf |
who puts such raspberry-pi-unfriendly stuff in koha? |
20:02 |
|
rangi |
Heh |
20:02 |
|
jcamins |
Hehe. |
20:02 |
|
jcamins |
Zebra won't be going anywhere for a while, I don't think. |
20:03 |
|
drojf |
i guess i should get a "real" git too |
20:03 |
|
rangi |
Hence the desire to make it optional |
20:07 |
|
jcamins |
Am I the only one who saw this "loophole" as a feature? |
20:07 |
|
jcamins |
The ability for non-authenticated users to e-mail records is standard in every single other OPAC that I have seen. |
20:07 |
|
cait |
i liked it too :( |
20:08 |
|
jcamins |
Since it's considered harmful, I'll just revert out that patch for my customers in a year. |
20:11 |
|
|
kathryn joined #koha |
20:17 |
|
|
adnc joined #koha |
20:19 |
|
rangi |
Well it gets worse if ppl listen to that email. That would restrict to only send to yourself |
20:19 |
|
jcamins |
Yes, that would be a lot worse, but not being able to send a cart without logging in is a pretty huge nuisance already. |
20:21 |
|
rangi |
yes, yes it is |
20:26 |
|
* cait |
nods |
20:43 |
|
ropuch |
Good evening |
20:43 |
|
cait |
hi ropuch :) |
20:43 |
|
ropuch |
cait: how's your opac-search problem? have you solved it? |
20:43 |
|
cait |
oh yes I have |
20:43 |
|
cait |
it was a bad patch |
20:44 |
|
ropuch |
What was the cause? |
20:44 |
|
ropuch |
Oh |
20:44 |
|
cait |
not sure how the patch caused the proble |
20:44 |
|
cait |
but reverting it or disabling opacsearchhistory fixes it |
20:50 |
|
ropuch |
Hm, it's been a long time since I send some patch, what should I type in "Message-ID to be used as In-Reply-To for the first email?" |
20:51 |
|
ropuch |
(I'm trying to send updated polish translation for some installer files) |
20:51 |
|
rangi |
https://gitorious.org/koha-dashboard now people can clone and fix my css |
20:52 |
|
rangi |
ahh, ropuch i would just attach them to the bug |
20:52 |
|
rangi |
and mark it needs signoff, and not worry about the mailing list |
20:52 |
|
ropuch |
So I should create a bug first? |
20:53 |
|
rangi |
*nod* or check if one already exists and update it |
20:53 |
|
rangi |
there might be one marked resolved already |
20:53 |
|
rangi |
if not yep, a new one (every patch should have a bug number) |
20:54 |
|
ropuch |
Make sense ;) |
20:55 |
|
ropuch |
It's kinda funny I'm back on Koha translating when I'm about to stop working in library ;> |
20:56 |
|
rangi |
heh |
20:56 |
|
rangi |
you can never escape koha :) |
20:57 |
|
cait |
ropuch: oh? |
20:57 |
|
rangi |
or libraries |
20:57 |
|
wahanui |
libraries are the kings of overcomplication |
20:57 |
|
rangi |
https://www.youtube.com/watch?[…]ySY&feature=g-upl |
21:03 |
|
|
libsysguy joined #koha |
21:09 |
|
ropuch |
cait: yup, from the next month I won't be working as librarian or in library (but I'll still consider myself as one ;-) |
21:10 |
|
cait |
hm |
21:10 |
|
cait |
so what are you going to do then? :) |
21:10 |
|
ropuch |
technical support engineer |
21:10 |
|
cait |
sounds important |
21:10 |
|
cait |
:) |
21:10 |
|
ropuch |
hehehe |
21:11 |
|
ropuch |
Yea, 3 words! ;-)) |
21:11 |
|
cait |
working with libraries? |
21:11 |
|
ropuch |
Nope, afair completly unrelated |
21:11 |
|
cait |
ah |
21:11 |
|
cait |
but updating koha before you leave? |
21:11 |
|
ropuch |
We have 3.8.2 already ;> |
21:12 |
|
cait |
oh |
21:13 |
|
ropuch |
Actually I think I will contribute more form now on |
21:13 |
|
rangi |
w00t!! |
21:15 |
|
cait |
:) |
21:15 |
|
cait |
woot indeed |
21:15 |
|
ropuch |
I mean: in my spare time |
21:16 |
|
cait |
you are here now... and I am too... heh |
21:17 |
|
drojf |
oh cait signed off my patch for the german translators. that's cool, i really don't want to enter koha history with a patch that just puts my name in a file. i have not submitted this since 3.4 so i have something real before… |
21:17 |
|
cait |
drojf: we should have added your name there earlier :) |
21:17 |
|
cait |
was I not supposed to sign it off? |
21:18 |
|
drojf |
doesn't matter, but i'd prefer to get my other patch in first |
21:18 |
|
drojf |
so i have actually done someting ;) |
21:18 |
|
cait |
heh |
21:18 |
|
cait |
don't worry about that |
21:18 |
|
cait |
you already did something |
21:20 |
|
drojf |
heh that is just a blatant scheme to get somebody to look at bug 8377 :D |
21:20 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8377 enhancement, P5 - low, ---, 5p4m, Needs Signoff , Show HTML5 video/ audio in OPAC for media files in 856 |
21:20 |
|
drojf |
also i wonder how i would make it not call me 5p4m without changing my email address |
21:21 |
|
cait |
I suspected it :P |
21:21 |
|
cait |
hm, you can't probably |
21:21 |
|
rangi |
drojf: git or bugzilla? |
21:22 |
|
drojf |
rangi: i thought that huginn gets that from bugzilla |
21:23 |
|
rangi |
bugzilla has your real name |
21:23 |
|
drojf |
if that is something in git i should change it myyelf of course |
21:23 |
|
drojf |
yes |
21:23 |
|
drojf |
that is why i am confused |
21:23 |
|
rangi |
hmm not sure lemme try something |
21:24 |
|
drojf |
but i entered the bug in bugzilla first. and the info huginn gives is not from a patch. so i assume it just uses whatever is before the @ in my email address? |
21:24 |
|
cait |
drojf: your author line looks nice in the patch |
21:24 |
|
cait |
drojf: that was my guess |
21:24 |
|
rangi |
bug 6679 |
21:24 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6679 minor, P1 - high, ---, chris, Needs Signoff , Fixing code so it passes basic Perl::Critic tests |
21:25 |
|
rangi |
hmm yeah its just not taking the real name field |
21:25 |
|
rangi |
looks like huginn needs a fix |
21:28 |
|
drojf |
i think i have a "too much information" problem in my bug description. because the crazy things from the rfc are not part of the patch now, it's just basic functionality plus a little extra. but for a person that does not live inside my head it looks like a lot more has to be considered |
21:29 |
|
cait |
drojf: step by step test plan on the bug? :) |
21:29 |
|
drojf |
there is one |
21:29 |
|
drojf |
its just a little above |
21:30 |
|
drojf |
i made that manually and not in the patch, that was no great idea |
21:30 |
|
cait |
don't worry so much |
21:34 |
|
rangi |
ill try to test tonight when the kids are asleep |
21:34 |
|
rangi |
drojf: have you see magnuse's semantikoha ? |
21:35 |
|
rangi |
combine that with html5 and the koha opac would be one of a kind |
21:35 |
|
cait |
true :) |
21:41 |
|
drojf |
rangi: that looks very interesting actually :) |
21:41 |
|
drojf |
also it reminds me that he had some bug where he asked about html5 and said it would be too early?! i think about maps |
21:43 |
|
rangi |
i think if it degraded |
21:43 |
|
rangi |
then would be fine |
22:04 |
|
ropuch |
Good night |
22:04 |
|
cait |
night :) |
22:05 |
|
rangi |
cya ropuch |
22:06 |
|
mtj |
morning #koha |
22:06 |
|
mtj |
rangi: do you know anyone that uses a before/after perlcritic check on commits for qa? |
22:07 |
|
rangi |
i run the t/00-perlcritic.t |
22:07 |
|
mtj |
something like Test::Perl::Critic::Progressive |
22:07 |
|
rangi |
nope |
22:07 |
|
rangi |
its not actually a requirement yet |
22:08 |
|
rangi |
if you introduce one into a file thats clean, thats bad, if you dont fix some that already exist i dont think thats a qa fail |
22:09 |
|
rangi |
so getting all files clean is something that people can work on, but carefully, we have busted functionality cleaning code before |
22:09 |
|
rangi |
and thats a particularly horrible thing to do |
22:09 |
|
rangi |
no regressions beats 'clean' code imho |
22:09 |
|
mtj |
sure, i agree |
22:09 |
|
rangi |
so we have to make sure we dont give passing the perlcritic tests to high a priority |
22:10 |
|
cait |
yeah |
22:10 |
|
cait |
please don't break things! |
22:10 |
|
mtj |
test::Perl::Critic::Progressive seems like a win |
22:10 |
|
rangi |
yep |
22:11 |
|
mtj |
it will test your modded files before the commit, and then after too... |
22:11 |
|
rangi |
also, fixes for critic gripes (which dont actually break anything) |
22:11 |
|
rangi |
should be sep to functional changes |
22:11 |
|
rangi |
so that the actual change can be seen |
22:11 |
|
mtj |
agreed :) |
22:12 |
|
rangi |
i think that the perlcritic bug is a good place to keep adding them to |
22:13 |
|
mtj |
im gonna write a perlcritic qa script, to spot newly introduced perlcritic errors for a commit |
22:13 |
|
rangi |
cool |
22:14 |
|
cait |
:) |
22:14 |
|
rangi |
i think a nice thing to do to ease into it, is if you find some, write a quick follow up |
22:14 |
|
rangi |
as a teaching tool |
22:14 |
|
mtj |
i thought i might just check that no-one else has that already |
22:14 |
|
rangi |
then people will learn how to fix them |
22:15 |
|
mtj |
yep, thats a nice idea, rather than just fixing them myself |
22:15 |
|
rangi |
*nod* |
22:15 |
|
mtj |
hi cait :) |
22:16 |
|
cait |
hi mtj :) |
22:16 |
|
jcamins |
mtj: I would love a script like that. |
22:17 |
|
mtj |
yeah, if wanted it for a while now, too... |
22:17 |
|
mtj |
s/if/ive/ |
22:19 |
|
jcamins |
Wow... a 23" monitor running at full resolution is really a wonderful thing. |
22:19 |
|
mtj |
i want a qa script that does 3 things for a commit ... |
22:19 |
|
mtj |
checks for new perlcritic errors, 'perl -c' syntax errors, and t::t errors |
22:19 |
|
jcamins |
Good idea. |
22:19 |
|
rangi |
yep |
22:19 |
|
jcamins |
I want a script that runs perl -c on all .pl files. |
22:20 |
|
jcamins |
I can't figure out how to do that. |
22:20 |
|
rangi |
find file |
22:20 |
|
jcamins |
rangi: has pointed me at examples at several times, but it never seems to work. |
22:20 |
|
rangi |
and then system() it |
22:20 |
|
jcamins |
Sorry, not a script. A test. |
22:21 |
|
mtj |
a test script? :) |
22:21 |
|
rangi |
tests are scripts |
22:21 |
|
jcamins |
Yeah, but one that doesn't make prove angry even when it passes. |
22:23 |
|
jcamins |
(mtj: watch, rangi is going to say this is easy) |
22:23 |
|
rangi |
ok(system(perl -c file)); |
22:23 |
|
jcamins |
... can I really do that? |
22:24 |
|
jcamins |
Cool. |
22:24 |
|
jcamins |
That I could manage. |
22:24 |
|
mtj |
can we start a koha-qa-tool repo on git.kc.org? |
22:24 |
|
jcamins |
mtj: there's release-tools. |
22:24 |
|
jcamins |
I have to talk to gmcharlt about getting push access to that. |
22:24 |
|
rangi |
The return value is the exit status of the program as returned by the wait call. |
22:24 |
|
rangi |
so yep it should work |
22:25 |
|
rangi |
give it a try |
22:25 |
|
jcamins |
rangi: thanks. |
22:25 |
|
jcamins |
I would like to have a set of WWW::Mechanize regression tests that are not in the main Koha repo. |
22:26 |
|
rangi |
hmm maybe not it returns this |
22:26 |
|
rangi |
mainpage.pl syntax OK |
22:26 |
|
rangi |
so |
22:27 |
|
jcamins |
system("perl -c $file") =~ m/syntax OK/ maybe? |
22:28 |
|
rangi |
something yeah that oughta do it something like that |
22:28 |
|
jcamins |
mtj: see, if we did that, we could do really sophisticated things like run the test against a known good version and then compare the results to the new version. |
22:29 |
|
mtj |
that == www::mech tests? |
22:29 |
|
rangi |
ahhh |
22:29 |
|
jcamins |
mtj: that == separate repo |
22:29 |
|
rangi |
0 = pass |
22:29 |
|
rangi |
1 = fail |
22:29 |
|
rangi |
got: '0' |
22:29 |
|
rangi |
so |
22:30 |
|
rangi |
perl -e 'use Test::More; ok(!system("perl -c mainpage.pl"))' |
22:30 |
|
mtj |
hmm, why not in the main repo? |
22:30 |
|
rangi |
ok 1 |
22:31 |
|
jcamins |
mtj: because then we have to have the tests in for the known good versions. |
22:31 |
|
rangi |
which makes sense. perl -c passes if nothing is wrong so 0 exit state |
22:31 |
|
mtj |
rangi++ awesome :) |
22:33 |
|
rangi |
so if you look at t/00-load.t |
22:33 |
|
rangi |
for how to use File::Spec and File::Find |
22:33 |
|
rangi |
should be able to do it like that |
22:33 |
|
jcamins |
Yeah, that's the one I just copied. |
22:36 |
|
jcamins |
Yup, that worked. |
22:36 |
|
jcamins |
Only one problem... it only checks files with the .pl extension. |
22:38 |
|
rangi |
i think you could run 2 loops |
22:39 |
|
rangi |
like it does, one for .pm too |
22:39 |
|
rangi |
althought load.t catches those |
22:39 |
|
jcamins |
Right. But there are also Perl scripts with no extension. |
22:40 |
|
rangi |
ah yep, you might have to spec them manually, and/or fix that :) |
22:40 |
|
jcamins |
Need some interface to file... |
22:40 |
|
rangi |
ie make a an array of their names, (or just give them .pl) |
22:42 |
|
rangi |
probably worth checking why we do that, and if we need to anyway? |
22:42 |
|
jcamins |
Yeah, that's the option I'm going to go with. |
22:42 |
|
jcamins |
We need to in /svc, I think. |
22:42 |
|
jcamins |
Not elsewhere. |
22:42 |
|
rangi |
hmm true |
22:42 |
|
jcamins |
Hey! |
22:42 |
|
rangi |
well we could do Alias /svc/clown /svc/clown.pl |
22:42 |
|
jcamins |
Rewrite rules! |
22:42 |
|
rangi |
yeah or that |
22:43 |
|
jcamins |
/svc/*.pl -> /svc/* |
22:43 |
|
rangi |
yep |
22:43 |
|
rangi |
alias is a little faster |
22:43 |
|
rangi |
but you cant shortcut like that |
22:43 |
|
rangi |
so rewite wins |
22:44 |
|
rangi |
rewrite too |
22:47 |
|
rangi |
ok walking 2 five year olds down the hill to the movie theatre |
22:48 |
|
rangi |
bbl, hopefully :) |
23:22 |
|
jcamins |
Oh, cool! |
23:23 |
|
jcamins |
Test::Strict does this automatically. |