| Time |
S |
Nick |
Message |
| 00:07 |
|
|
mbridge joined #koha |
| 01:07 |
|
|
mbridge joined #koha |
| 01:54 |
|
|
JBoyer joined #koha |
| 02:07 |
|
|
mbridge joined #koha |
| 02:31 |
|
|
alohabot joined #koha |
| 03:07 |
|
|
mbridge joined #koha |
| 04:07 |
|
|
mbridge joined #koha |
| 05:07 |
|
|
mbridge joined #koha |
| 06:07 |
|
|
mbridge joined #koha |
| 06:39 |
|
|
thibaud_g joined #koha |
| 06:42 |
|
|
cait joined #koha |
| 06:51 |
|
|
alex_a joined #koha |
| 07:07 |
|
|
mbridge joined #koha |
| 07:21 |
|
|
alex_a joined #koha |
| 07:41 |
|
|
tcohen joined #koha |
| 08:07 |
|
|
mbridge joined #koha |
| 09:07 |
|
tadzik |
hello #koha. I'm trying to take a stab at signing off bugs, as there seems to be a need for that. I followed the git-bz instructions on the wiki for https://bugs.koha-community.or[…]_bug.cgi?id=35954, and it resulted in reposting the whole patch with my signoff – which makes sense, but it's not quite like what I've seen in some other bugs. What could be the reason for |
| 09:07 |
|
huginn` |
Bug 35954: enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add --status to koha-plack |
| 09:07 |
|
tadzik |
this? Is that to be expected? |
| 09:07 |
|
|
mbridge joined #koha |
| 09:13 |
|
mbridge |
[mattermost] <tadzik> Hello! Reposting this here since the bridge appears to be dead :( |
| 09:14 |
|
mbridge |
[mattermost] <tadzik> I'm trying to take a stab at signing off bugs, as there seems to be a need for that. I followed the git-bz instructions on the wiki for https://bugs.koha-community.or[…]_bug.cgi?id=35954, and it resulted in reposting the whole patch with my signoff – which makes sense, but it's not quite like what I've seen in some other bugs. What could be the reason for this? Is that to be expected? |
| 09:14 |
|
huginn` |
Bug 35954: enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add --status to koha-plack |
| 09:14 |
|
mbridge |
[mattermost] <tadzik> ah, it's only selectively broken :) |
| 09:15 |
|
mbridge |
[mattermost] <jpahd> What do you mean? Looks good to me. |
| 09:16 |
|
mbridge |
[mattermost] <jpahd> But switch to 'Signed Off' in the status. |
| 09:17 |
|
mbridge |
[mattermost] <tadzik> I'm comparing it to https://bugs.koha-community.or[…]_bug.cgi?id=35145 for instance, but I guess in its case people were just smart enough to remove the commit message leaving just the sign-off, leaving bugzilla tidier. Is that's where we differ, and it's just good manners to do that? |
| 09:17 |
|
huginn` |
Bug 35145: enhancement, P5 - low, ---, emily-rose.francoeur, Needs Signoff , Add ability to order patron attributes |
| 09:17 |
|
mbridge |
[mattermost] <tadzik> Done, thanks |
| 09:18 |
|
mbridge |
[mattermost] <jpahd> Honestly you can do that, I never do it. |
| 09:18 |
|
mbridge |
[mattermost] <tadzik> ha, fair enough |
| 09:18 |
|
mbridge |
[mattermost] <jpahd> There's no policy I know of that requires to remove the previous commit message. |
| 09:19 |
|
mbridge |
[mattermost] <tadzik> understood. Thanks for your help! |
| 09:19 |
|
mbridge |
[mattermost] <jpahd> No problem, but remember to set the status to 'Signed Off' please :) |
| 09:19 |
|
mbridge |
[mattermost] <jpahd> Ah you already did. Apologies. |
| 09:20 |
|
mbridge |
[mattermost] <jpahd> Here in the dropdown, not just the line :D : https://chat.koha-community.or[…]GnlcX2T_lgew7KlhQ |
| 09:21 |
|
mbridge |
[mattermost] <jpahd> Sorry for the black box (it's just YouTube :D) |
| 09:21 |
|
mbridge |
[mattermost] <tadzik> ah, grr! If you forget to "Save changes" then it will still pretend it's set correctly after you reload the page to check /o\ |
| 09:22 |
|
mbridge |
[mattermost] <jpahd> Yeah, that's true. |
| 09:22 |
|
mbridge |
[mattermost] <tadzik> should be finally good now :D |
| 09:22 |
|
mbridge |
[mattermost] <jpahd> You can also do it via bz by uncommenting the status line. |
| 09:22 |
|
mbridge |
[mattermost] <jpahd> Wonderful! |
| 09:22 |
|
mbridge |
[mattermost] <tadzik> aha, handy |
| 09:25 |
|
cait |
hi tadzik - we are over on chat.koha-community.org now mostly if you want to join us there |
| 09:26 |
|
mbridge |
[mattermost] <jpahd> Already here :D |
| 09:26 |
|
mbridge |
[mattermost] <jpahd> Look into ~irc-bridge |
| 09:32 |
|
tadzik |
yeah, I tried both places, and it turned out that my first two IRC messages didn't make it to mattermost |
| 09:32 |
|
tadzik |
now it of course works perfectly to make me look silly :P |
| 09:44 |
|
|
cait1 joined #koha |
| 09:45 |
|
mbridge |
[mattermost] <ammopt> @tadzik looking at that bug you mentioned. I don't believe that'd be a good example to follow. |
| 09:45 |
|
mbridge |
[mattermost] <ammopt> It seems the author, intentionally or not, dropped the original patch commit message while rebasing/resubmitting - that contained the test plan. That commit message should've definitely be kept I'd say. |
| 09:46 |
|
tadzik |
nod nod |
| 09:46 |
|
tadzik |
for https://bugs.koha-community.or[…]_bug.cgi?id=36526 I kept the patch as-is, but removed the patch from the bugzilla comment, which looks like the best of both worlds |
| 09:46 |
|
huginn` |
Bug 36526: normal, P5 - low, ---, julian.maurice, Signed Off , Remove circular dependency from Koha::Objects |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> it seems you added a new patch though, which is not usually what happens. |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> Additionally, the patch you added does not start with "Bug XXXX:" and that'll not be allowed. |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> The sign-off is usually done as a line added at the end of the original commit with a "Signed-off by:" line. |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> If you're using k-t-d, for this particular bug, what I'd do is |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> 1) Obsolete your current sign off patch in bugzilla |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> 2) On ktd, on main up to date, run `git bz apply 36526` |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> 3) Signoff, run `git so 1` |
| 09:52 |
|
mbridge |
[mattermost] <ammopt> 4) Resubmit with -e flag to change bug status in cli, run `git bz attach -e 36526 HEAD` |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> it seems you added a new patch though, which is not usually what happens. |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> Additionally, the patch you added does not start with "Bug XXXX:" and that'll not be allowed. |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> The sign-off is usually done as a line added at the end of the original commit with a "Signed-off by:" line. |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> If you're using k-t-d, for this particular bug, what I'd do is |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> 1) Obsolete your current sign off patch in bugzilla |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> 2) On ktd, on main up to date, run `git bz apply 36526` |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> 3) Signoff, run `git so` |
| 09:53 |
|
mbridge |
[mattermost] <ammopt> 4) Resubmit with -e flag to change bug status in cli, run `git bz attach -e 36526 HEAD` |
| 09:59 |
|
tadzik |
I did follow the git-bz instructons on https://wiki.koha-community.or[…]ation#Signing_off |
| 10:00 |
|
tadzik |
and the patch itself is intact: https://bugs.koha-community.or[…]ent.cgi?id=166104 |
| 10:07 |
|
|
mbridge joined #koha |
| 10:10 |
|
mbridge |
[mattermost] <ashimema> interesting.. something a little funky has happened there |
| 10:11 |
|
mbridge |
[mattermost] <ashimema> not your fault tadzik.. I'll double check the docs in a moment |
| 10:11 |
|
mbridge |
[mattermost] <ashimema> we'll work it out between us all |
| 10:19 |
|
tadzik |
note that I did remove all the contents from the BZ comment to make it tidy (perhaps wrongly), I guess that fact confused the attachment aggregator thing |
| 10:20 |
|
tadzik |
perhaps that wasn't the right thing to do; I was trying to find some overlap between the wiki instructions and the signoffs I see popping up in the wild in other bugs |
| 10:24 |
|
mbridge |
[mattermost] <cait> we usually only change the status in the git bz edit step and leave the commit message as is |
| 10:29 |
|
|
oleonard joined #koha |
| 10:40 |
|
|
oleonard joined #koha |
| 10:41 |
|
|
alohabot joined #koha |
| 10:41 |
|
mbridge |
[mattermost] <oleonard> tadzik: It's standard procedure to add your signoff and leave the rest of the patch as-is |
| 10:42 |
|
mbridge |
[mattermost] <oleonard> (sorry that message was redundant I see Mattermost hadn't loaded newer messages) |
| 10:48 |
|
|
dpk__ joined #koha |
| 11:07 |
|
|
mbridge joined #koha |
| 11:25 |
|
|
alex_a joined #koha |
| 12:07 |
|
|
mbridge joined #koha |
| 12:16 |
|
|
mkstephens[m] left #koha |
| 13:05 |
|
|
Dyrcona joined #koha |
| 13:07 |
|
|
mbridge joined #koha |
| 13:39 |
|
|
kellym joined #koha |
| 14:07 |
|
|
mbridge joined #koha |
| 15:00 |
|
|
bag joined #koha |
| 15:07 |
|
|
mbridge joined #koha |
| 16:07 |
|
|
mbridge joined #koha |
| 17:07 |
|
|
mbridge joined #koha |
| 18:07 |
|
|
mbridge joined #koha |
| 19:07 |
|
|
mbridge joined #koha |
| 20:07 |
|
|
mbridge joined #koha |
| 21:07 |
|
|
mbridge joined #koha |
| 22:07 |
|
|
mbridge joined #koha |
| 23:07 |
|
|
mbridge joined #koha |
