Time |
S |
Nick |
Message |
01:01 |
|
|
dpk__ joined #koha |
02:49 |
|
|
thd joined #koha |
04:42 |
|
|
AndroUser2 joined #koha |
05:13 |
|
|
AndroUser2 joined #koha |
07:07 |
|
|
marcelr joined #koha |
07:07 |
|
marcelr |
o/ |
07:35 |
|
|
reiveune joined #koha |
07:35 |
|
reiveune |
hello |
07:48 |
|
Joubu |
ashimema: I think I found a better way for the QA error, can you have a look at !69 of qa-test-tools? |
07:54 |
|
|
lds joined #koha |
08:52 |
|
|
AndroUser2 joined #koha |
08:55 |
|
ashimema |
Sure thing |
08:58 |
|
ashimema |
Seems reasonable. You basically move the code so the old filecheck works . I considered similar but took the lazy approach I suppose. |
08:58 |
|
ashimema |
I don't see how it gets around the issue you were saying around it not testing new files at all though. |
09:05 |
|
domm[m] |
are you doing this chocolate-swap-thing at the HackFest? Or is that only happening at Koha-Con? |
09:16 |
|
|
AndroUser2 joined #koha |
09:24 |
|
domm[m] |
if a patch is in state "failed QA" and I fixed the failure, what state should i set? |
09:25 |
|
domm[m] |
https://bugs.koha-community.or[…]_bug.cgi?id=35345 |
09:25 |
|
huginn` |
Bug 35345: new feature, P5 - low, ---, domm, Failed QA , Pass custom SQL to rebuild_elasticsearch.pl |
09:26 |
|
domm[m] |
where "Failed QA" was caused by too much perltidy |
09:26 |
|
ashimema |
Back to signed off and that will prompt the QA to take another look |
09:27 |
|
ashimema |
I'm away next week but if it's still hanging around after that ping me and I'll take a look myself to get it bumped up the QA pile |
09:31 |
|
domm[m] |
ashimema: thanks! |
09:41 |
|
marcelr |
just about 200 in SO |
09:42 |
|
ashimema |
Yeah, need to get back on the queues.. I've slacked for a couple of weeks whilst I was in meetings and trying to get in top of my own develpments queue |
09:43 |
|
ashimema |
Apologies marcelr |
09:43 |
|
ashimema |
All vow to the QA manager |
09:44 |
|
ashimema |
Mind you.. it's not April yet so I still look ok in the dashboard.. lol |
09:44 |
|
marcelr |
top |
09:45 |
|
marcelr |
time for a break, ashimema |
09:50 |
|
domm[m] |
https://wiki.koha-community.or[…]elopment_workflow does not explain what to do (as a dev) after a patch got Failed QA. Is it OK if I add this to the wiki ("Back to signed off", but elaborated a bit)? |
09:50 |
|
domm[m] |
(eg I wasn't sure if a signed-off patch that failed QA needs to be sigend-off again...) |
09:50 |
|
marcelr |
domm[m]: depending on the change you might switch back to Needs signoff |
09:51 |
|
marcelr |
or the QAer could do it even later |
09:51 |
|
domm[m] |
yeah, I assume, as always the correct answer is "it depends" |
09:51 |
|
Joubu |
if previous status was "signed off" usually it can be set back to signed off |
09:52 |
|
Joubu |
unless you consider that the rebase/fix requires another signoff |
09:53 |
|
marcelr |
^^ |
09:57 |
|
|
AndroUser2 joined #koha |
10:21 |
|
|
AndroUser2 joined #koha |
10:25 |
|
|
cait joined #koha |
10:36 |
|
|
AndroUser2 joined #koha |
10:38 |
|
|
khall joined #koha |
10:57 |
|
|
khall_ joined #koha |
11:00 |
|
|
oleonard joined #koha |
11:12 |
|
|
AndroUser2 joined #koha |
11:33 |
|
|
AndroUser2 joined #koha |
11:38 |
|
|
oleonard joined #koha |
11:58 |
|
|
oleonard joined #koha |
12:22 |
|
|
khall joined #koha |
12:22 |
|
|
AndroUser2 joined #koha |
12:34 |
|
|
oleonard joined #koha |
12:46 |
|
|
AndroUser2 joined #koha |
12:54 |
|
|
lds joined #koha |
13:08 |
|
|
oleonard joined #koha |
13:26 |
|
|
oleonard joined #koha |
13:54 |
|
|
caroline joined #koha |
14:40 |
|
|
oleonard joined #koha |
15:37 |
|
|
AndroUser2 joined #koha |
15:41 |
|
NikolayGospodinov[m] |
Hello. I want to ask something. I have a Koha installation on an Ubuntu virtual server in Microsoft Azure. I want to ask how can I optimize Koha to run as fast as possible. My virtual server has 16 GB RAM. with 4 cores (Size |
15:41 |
|
NikolayGospodinov[m] |
Standard B4ms; vCPUs 4; RAM 16 GiB) |
15:55 |
|
|
AndroUser2 joined #koha |
16:01 |
|
|
khall joined #koha |
16:03 |
|
reiveune |
bye |
16:03 |
|
|
reiveune left #koha |
16:13 |
|
|
AndroUser2 joined #koha |
16:43 |
|
|
AndroUser2 joined #koha |
17:37 |
|
|
khall joined #koha |
18:47 |
|
|
georgew joined #koha |
18:48 |
|
georgew |
Is the Koha Wiki down again today? I can't access it |
18:55 |
|
davidnind |
georgew: it's working for me |
18:56 |
|
georgew |
Thanks, davidnind, it must just be me |
19:02 |
|
davidnind |
8-) |
19:17 |
|
blawlor[m] |
I'm trying to help a co-worker get set up with KTD, and it's mostly working, but she gets an error I have not seen when trying to atach a patch... (full message at <https://matrix.org/_matrix/med[…]rgKklcyypXLBOxEEj>) |
19:24 |
|
davidnind |
blawlor: maybe check that the Bugzilla credentials in the .env file are correct? |
19:38 |
|
blawlor[m] |
We put the bz credentials in the .env file, but good idea to double check |
19:40 |
|
blawlor[m] |
I thought maybe it's somehow configured to use browser cookies instead of the creds. The tricky part is I didn't set everything up with them step by step so I don't know everything in their setup |
19:41 |
|
davidnind |
I put my user name in quotes one time a while ago when I had some issues "GIT_USER_NAME="David Nind", I also had issues with my Bugzilla password (I don't think it liked some of the special characters) |
19:43 |
|
davidnind |
Can you apply a patch OK? (My cheat sheet won't be much help as this starts from the point where you have KTD working correctly https://gitlab.com/-/snippets/1893788) |
19:44 |
|
davidnind |
I normally do attach -e, but the command you have :q |
19:45 |
|
davidnind |
Ignore ^^^, meant I normally do attach -e, but the command you have shown should work if you have a patch to attach to a bug |
19:46 |
|
blawlor[m] |
the one thing I did notice that looks l slightly different is that when she does ktd --shell the prompt didn't show the branch like (master) in yellow like it does for me |
19:48 |
|
davidnind |
Did she access the KTD shell as root? ( ktd --root --shell) For most uses you just need to access "normally" ( ktd --shell) |
19:49 |
|
blawlor[m] |
no she just ran ktd --shell |
19:58 |
|
davidnind |
OK, so "something" is not quite right then 8-) |
20:00 |
|
cait |
have you tried to turn it off and on again? :) |
20:00 |
|
cait |
(meaning ktd down, ktd up again |
20:01 |
|
davidnind |
What user does it show when you do a whoami from the KTD shell? (For me if normal, should show as kohadev-koha) |
20:02 |
|
davidnind |
Happy to help check the system setup if you have time to walk through the steps taken |
20:03 |
|
blawlor[m] |
we tried ktd down, close vs code and all terminals, and restart ktd, but hit the same error |
20:03 |
|
blawlor[m] |
I think we will start from scratch |
20:29 |
|
davidnind |
If using a Linux desktop, then the recommendation is not to use Docker Desktop, just use the Docker server/Docker engine |
20:35 |
|
blawlor[m] |
Thanks! |
20:35 |
|
blawlor[m] |
whoami showed correctly as kohadev-koha |
20:35 |
|
blawlor[m] |
We're using WSL2 and vscode. It's been working perfectly for me, but is one of those things that is tough to help someone set up remotely. On my co-workers machine she can run ktd up and log into Koha, but cannot apply patches, so it seems to be very specific to git bz config |
20:42 |
|
davidnind |
I've never tried to get it working on a Windows desktop with Windows Subsystem for Linux. I would create an issue on koha-testing-docker for the issue you are having and send an email to the developers mailing list to see if anyone has. |
20:42 |
|
caroline |
blawlor[m], it seems ashimema got the same error message a couple of months ago and it was a credentials thing https://ilbot3.kohaaloha.com/k[…]3-11-27#i_2399990 |
20:43 |
|
davidnind |
caroline++ |
20:43 |
|
blawlor[m] |
that's it! |
20:43 |
|
blawlor[m] |
what's this use_git_credential thing mentioned there? |
20:46 |
|
caroline |
not sure... with the underscores, I would think it's something in the env file? |
20:54 |
|
caroline |
no, looks like it's something else https://www.rdocumentation.org[…]s/git_credentials |
20:55 |
|
caroline |
I don,t understand any of this, but maybe you do |
20:59 |
|
blawlor[m] |
Thanks Caroline! if we can't figure it out we will just delete everything and try again :) |
20:59 |
|
caroline |
if it can wait until tuesday, you can ask Joubu or ashimema |
21:01 |
|
caroline |
they're usually around in our morning |
21:03 |
|
blawlor[m] |
mais bien sûr, nous pouvons attendre, merci beaucoup! |
21:04 |
|
caroline |
haha! :D |
21:06 |
|
blawlor[m] |
bonne soirée |
21:07 |
|
caroline |
toi aussi bonne fin de semaine! :) |
22:09 |
|
|
khall joined #koha |
22:19 |
|
|
khall joined #koha |
23:04 |
|
|
AndroUser2 joined #koha |
23:13 |
|
|
AndroUser2 joined #koha |