| Time |
S |
Nick |
Message |
| 00:37 |
|
|
alohabot joined #koha |
| 01:11 |
|
|
schnydszch joined #koha |
| 01:25 |
|
|
eugene_ joined #koha |
| 06:21 |
|
|
Adarsh joined #koha |
| 06:21 |
|
Adarsh |
How to use OAuth2 access token to get biblio in Koha rest API? |
| 06:25 |
|
|
reiveune joined #koha |
| 07:10 |
|
|
marcelr joined #koha |
| 07:10 |
|
marcelr |
o/ |
| 07:31 |
|
magnuse |
\o/ |
| 07:36 |
|
Adarsh |
Hello |
| 08:00 |
|
|
thibaud_g joined #koha |
| 08:09 |
|
|
cait joined #koha |
| 08:11 |
|
cait |
good morning all |
| 08:11 |
|
cait |
Joubu: around? |
| 08:16 |
|
magnuse |
i was today years old when i found out about admin/item_circulation_alerts.pl |
| 08:17 |
|
magnuse |
and had to smile a little when the first bug i found related to it was bug 20401 |
| 08:17 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=20401 enhancement, P5 - low, ---, koha-bugs, NEW , "Item circulation alerts" is overkill and could be removed |
| 08:18 |
|
cait |
you could comment :) |
| 08:18 |
|
cait |
Joubu: around? |
| 08:18 |
|
cait |
ah... I already asked that |
| 08:21 |
|
ashimema |
I sort of agree with him |
| 08:21 |
|
cait |
so... Jenkins is broken, no pushing today. |
| 08:21 |
|
ashimema |
Though I didn't always follow it as a hard rule either |
| 08:22 |
|
cait |
I might this time, I know he is out too |
| 08:22 |
|
ashimema |
Joubu may be able to help get it passing again |
| 08:22 |
|
ashimema |
I took a quick look and nothing was obvious |
| 08:22 |
|
cait |
I can't connect any of these with a change I made really |
| 08:23 |
|
cait |
and I even rean all the selenium tests locally and they passed, so yeah |
| 08:25 |
|
ashimema |
I have a feeling it's actually a Jenkins runner issue |
| 08:25 |
|
ashimema |
I'm going to trigger the build |
| 08:27 |
|
ashimema |
Test builder failing is an interesting one.. that can cause issues down the line |
| 08:28 |
|
ashimema |
As in, when that fails, it can often highlight the root cause.. other tests all rely heavily on testbuilder |
| 08:29 |
|
ashimema |
Build_sample_biblio has encoding issues.. very strange.. |
| 08:31 |
|
marcelr |
hi, i saw these failures already a few days ago too |
| 08:31 |
|
marcelr |
at least some |
| 08:31 |
|
marcelr |
incl build_sample |
| 08:32 |
|
marcelr |
should have a look when i get rid of these laborious flatpickr issues |
| 08:32 |
|
marcelr |
can we stop with date formats ? |
| 08:33 |
|
ashimema |
None of your pushes seem remotely related though.. |
| 08:35 |
|
marcelr |
no, i guess that these failures come already before the last pushes |
| 08:36 |
|
ashimema |
What were you saying about dates.. I'm behind on that |
| 08:36 |
|
ashimema |
The church rules stuff you mean? |
| 08:36 |
|
ashimema |
Circ |
| 08:36 |
|
ashimema |
On phone |
| 08:47 |
|
cait |
some have bugs already: bug 35506 bug 35507 |
| 08:47 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35506 normal, P5 - low, ---, chris, NEW , selenium/regressions.t is failing randomly |
| 08:47 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35507 normal, P5 - low, ---, chris, NEW , TestBuilder.t is failing randomly |
| 08:47 |
|
cait |
so they reappeared, seemingly random |
| 08:47 |
|
cait |
but all the hook related fails weren't there before and there is also a shib one |
| 08:47 |
|
cait |
I am a little puzzled by it - if it failed on all Debians it would make more sense to me? |
| 08:48 |
|
ashimema |
Jenkins doesn't always run all builds now . I think |
| 08:48 |
|
ashimema |
Not sure |
| 08:49 |
|
ashimema |
As in, at some point I think we opted to do an initial build, then trigger the rest after that one succeeds |
| 08:51 |
|
cait |
ah ok, yeah that would make sense |
| 09:03 |
|
cait |
so yes.. any help appreciated to resolve these |
| 09:06 |
|
ashimema |
So yeah, I'm off today and Monday.. but I'll try to find a slot to fit in a deeper look in that time.. hopefully tcohen may beat me to it though |
| 09:06 |
|
ashimema |
I wouldn't worry too much right now though. We'll get it sorted between us all |
| 09:10 |
|
puphaus[m] |
<Adarsh> "How to use OAuth2 access token..." <- Hi Adarsh, to create an OAuth2 access token in Koha, you have to do the following steps:... (full message at <https://matrix.org/_matrix/med[…]fmuzIyTmFbZsTuUBY>) |
| 09:18 |
|
Adarsh |
<puphaus[m]> I had created OAuth access token already with the same steps that you shared. But my question is about using it? |
| 09:22 |
|
ashimema |
It's standard client credentials grant flow |
| 09:23 |
|
ashimema |
You use your key to fetch a token |
| 09:23 |
|
ashimema |
Then use that token in subsequent requests in the Bearer header |
| 09:26 |
|
ashimema |
https://api.koha-community.org[…]ration/tokenOAuth |
| 09:26 |
|
marcelr |
ashimema: could you qa 35341, did too much changing |
| 09:26 |
|
marcelr |
bug 35341 |
| 09:26 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35341 major, P5 - low, ---, m.de.rooy, Signed Off , Circulation rule dates are being overwritten |
| 09:27 |
|
marcelr |
MatthewBlenkinsop[m]++ |
| 09:27 |
|
ashimema |
Certainly, thanks for digging into it marcelr |
| 09:27 |
|
marcelr |
it is horrible |
| 09:28 |
|
puphaus[m] |
Oh sorry! Adarsh Send the Bearer Token with it like ashimema says and special on this endpoint is you have to send a GET Request to <koha-domain>/api/v1/biblios/{biblio_id} with one of the following Accepts Header: "application/marc" / "application/marc-in-json" / "application/marcxml+xml" or "application/json". if you dont send the Accept header with it you will not see biblio record |
| 09:28 |
|
ashimema |
I likely won't get to it today though I'm afraid.. I'm in mobile only at the minute as in theory I've got the day off to Xmas shop with the better half |
| 09:28 |
|
cait |
which you should do- go! |
| 09:28 |
|
ashimema |
puphaus++ |
| 09:28 |
|
cait |
puphaus++ :) |
| 09:37 |
|
marcelr |
ashimema, cait: anyone looking at the TestBuilder fail right now? |
| 09:37 |
|
marcelr |
otherwise i ll switch there now |
| 09:37 |
|
marcelr |
not ok 14 - build_sample_biblio() tests |
| 09:37 |
|
marcelr |
saw it on Dec 4 already |
| 09:40 |
|
ashimema |
I'm not on it right now. |
| 09:40 |
|
marcelr |
ok |
| 09:40 |
|
ashimema |
Be nice to narrow it down a bit if you can |
| 09:40 |
|
ashimema |
It's a weird looking one when I gave it a cursory look from the phone earlier |
| 09:41 |
|
marcelr |
bug 35507 |
| 09:41 |
|
huginn` |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=35507 normal, P5 - low, ---, m.de.rooy, ASSIGNED , TestBuilder.t is failing randomly |
| 09:45 |
|
Adarsh |
<ashimema> What is the field to send token in subsequent requests in the Bearer header? |
| 09:55 |
|
puphaus[m] |
<Adarsh> "<ashimema> What is the field..." <- The Bearer Token is send in the Authorization Header in the following Format: "Bearer <your Bearer Token>" |
| 09:56 |
|
magnuse |
there is no tool or script to export all cover images from the database, right? |
| 10:00 |
|
puphaus[m] |
<Adarsh> "<ashimema> What is the field..." <- To get the bearer token you send an POST request "<api_baseurl>/api/v1/oauth/token"... (full message at <https://matrix.org/_matrix/med[…]JUFjfVcOZkuqxKqHN>) |
| 10:10 |
|
cait |
kidclamp kidclamp kidclamp ? |
| 10:11 |
|
cait |
magnuse: i don't konw of one, did you check bugzilla? |
| 10:12 |
|
cait |
Bug 33163 - Add a command line tool to import many cover images from a zip file (I was thinking of that one, but wrong direction) |
| 10:14 |
|
magnuse |
yeah, can't find anything for exporting |
| 10:22 |
|
cait |
maybe this is more a dbms issue? how to get "blobs" out of a database as files? |
| 10:22 |
|
cait |
could have been solved elsewhere |
| 10:39 |
|
cait |
marcelr: afaik noone looking at the tests right now, please do! |
| 10:42 |
|
marcelr |
yes i am on it, found the cause in Plugins |
| 10:42 |
|
marcelr |
it explains multiple failures with hooks |
| 10:43 |
|
Adarsh |
<puphaus[m]> I did the same for passing bearer token but getting { "error": "Authentication failure." } |
| 10:46 |
|
|
caroline joined #koha |
| 10:56 |
|
cait |
mtj: can you tell why there are no packages for 23.05.04 available? I know .05 is out, I was just wondering |
| 11:05 |
|
cait |
marcelr++ |
| 11:06 |
|
puphaus[m] |
Adarsh: can you show me what your request looked like(with personal infos redacted)? did you do it with perl/python/curl? |
| 11:45 |
|
|
caroline joined #koha |
| 11:55 |
|
|
khall joined #koha |
| 12:03 |
|
paulderscheid[m] |
Can confirm marcelr |
| 12:04 |
|
paulderscheid[m] |
Had failures in TestBuilder the last month most likely caused by plugin hooks |
| 12:11 |
|
tcohen[m] |
cait: I assume we replace packages each release? |
| 12:32 |
|
puphaus[m] |
Ah i now know why you are getting the Error Adarsh you have to set the permissions correctly for the patron. The default user cant access it with the OAuth endpoint. You can set the permissions on the patron page "More" -> "Set Permissions" If you try it again it will work. Another Method without Authentication would be the /api/v1/public/biblios/<biblionumber> Endpoint |
| 12:35 |
|
tcohen[m] |
paulderscheid, marcelr the question would be what changed (making the tests fail) |
| 12:35 |
|
paulderscheid[m] |
That's a good question |
| 13:13 |
|
cait |
tcohen[m]: I got the question from a librry, they were wondering becuse they wanted to set up a new server witht he exact version they wee already using |
| 13:13 |
|
paulderscheid[m] |
I'm currently exploring options to get away from Docker's own products like Docker Desktop, therefore I added a list of already tested options like Rancher which I currently use in a table on the koha-testing-docker wiki page. |
| 13:18 |
|
|
khall joined #koha |
| 13:34 |
|
|
Dyrcona joined #koha |
| 13:37 |
|
puphaus[m] |
<paulderscheid[m]> "I'm currently exploring options..." <- If you just want to get rid off DockerDesktop whats also works quite nice on MacOS is docker + colima. You can both easily install it with homebrew ("brew install docker docker-compose" and "brew install colima") and then its ready without any additional configuration needed :) |
| 13:40 |
|
paulderscheid[m] |
Thanks for the suggestion puphaus. :) |
| 13:40 |
|
paulderscheid[m] |
I was already using colima as well as minikube prior to switching to Rancher Desktop. |
| 13:41 |
|
paulderscheid[m] |
If you want you could add it directly to that table ;D |
| 13:42 |
|
paulderscheid[m] |
The thing is that Rancher Desktop has an option for running non-native compose stacks via Apple's built-in hypervisor, which was the game changer for me. |
| 13:42 |
|
paulderscheid[m] |
QEMU is also fine, but the performance is.. not optimal :D |
| 13:45 |
|
ashimema |
Where's this table paulderscheid: ? |
| 13:45 |
|
paulderscheid[m] |
https://wiki.koha-community.or[…]to_Docker_Desktop ashimema |
| 13:46 |
|
ashimema |
Nice one |
| 13:46 |
|
puphaus[m] |
paulderscheid[m]: Oh i didn't knew this. Sounds really interesting! |
| 13:46 |
|
puphaus[m] |
paulderscheid[m]: Yeah thats absolutely right :D |
| 15:04 |
|
|
schnydszch joined #koha |
| 15:26 |
|
|
reiveune left #koha |
| 15:27 |
|
|
reiveune joined #koha |
| 15:27 |
|
|
reiveune left #koha |
| 16:00 |
|
|
bag joined #koha |
| 16:41 |
|
|
cait left #koha |
| 17:06 |
|
|
cait joined #koha |
| 17:38 |
|
|
khall joined #koha |
| 17:43 |
|
caroline |
is the irc log search broken? https://irc.koha-community.org[…]h.pl?channel=koha |
| 17:51 |
|
davidnind |
it's working OK for me (a little slow, but not bad, I tried a few different searches) |
| 17:52 |
|
caroline |
ok thanks davidnind. It's only giving me "Results page: 1" and if I click on the "1" it just reloads the page... |
| 17:53 |
|
|
khall_ joined #koha |
| 17:53 |
|
caroline |
i was looking for the trick how to not be logged into the ktd opac while being logged into the staff interface, do you know it? |
| 17:53 |
|
caroline |
if I log out of the opac, I'm logged out of the staff interface. It's very annoying |
| 17:55 |
|
tcohen[m] |
If you don't use localhost:port but instead use kohadev.myDNSname.org and kohadev-intra, it works |
| 17:56 |
|
tcohen[m] |
You need to define them on your hosts file |
| 17:56 |
|
caroline |
ah that's it! I knew it was really simple, and I had already asked the question, but couldn't find the answer |
| 17:56 |
|
caroline |
thanks tcohen++ |
| 18:04 |
|
davidnind |
another way is to use localhost for one and 127.0.0.1 for the other |
| 18:10 |
|
cait |
is he hosts file thing described somewhere? |
| 18:10 |
|
cait |
I could never get that to work |
| 18:10 |
|
cait |
I always end up changing the baseurls |
| 18:18 |
|
|
khall joined #koha |
| 18:34 |
|
tcohen[m] |
I don't know, cait |
| 18:49 |
|
tcohen[m] |
We should make it more straight-forward. I have some ideas, but don't want to be a bottle-neck, so if someone has an idea about it, just go ahead. |
| 19:09 |
|
cait |
just a note in the docs would make me happy already :) |
| 19:41 |
|
tcohen[m] |
To do:... (full message at <https://matrix.org/_matrix/med[…]gKvcfdRAoqYodwfof>) |
| 19:55 |
|
|
lukeg joined #koha |
| 20:33 |
|
|
khall joined #koha |
| 20:48 |
|
tcohen[m] |
davidnind: sorry, can you please re-signoff? |
| 20:55 |
|
tcohen[m] |
I only renamed the hook XD |
| 21:16 |
|
davidnind |
no problem - will just finish off the one I'm on now |
| 21:26 |
|
|
alohabot joined #koha |
| 21:27 |
|
davidnind |
done! |
| 21:37 |
|
tcohen[m] |
You're the best! |
| 21:37 |
|
tcohen[m] |
Thanks! |
| 22:24 |
|
|
khall joined #koha |
