| Time |
S |
Nick |
Message |
| 03:15 |
|
|
lari joined #koha |
| 03:16 |
|
|
kivilahtio joined #koha |
| 05:36 |
|
|
fridolin joined #koha |
| 05:37 |
|
fridolin |
yellowwww |
| 05:44 |
|
|
MarkHofstetter1 joined #koha |
| 06:06 |
|
|
cait joined #koha |
| 06:46 |
|
Joubu |
@later tell tcohen how did you fix the "The table 'auth_header' is full" error? |
| 06:46 |
|
huginn |
Joubu: The operation succeeded. |
| 06:53 |
|
|
alex_ joined #koha |
| 06:57 |
|
|
reiveune joined #koha |
| 06:57 |
|
reiveune |
hello |
| 07:00 |
|
|
cait joined #koha |
| 07:01 |
|
cait |
good morning #koha |
| 07:02 |
|
|
thibaud_g joined #koha |
| 07:09 |
|
|
thibaud_g joined #koha |
| 07:34 |
|
|
fridolin1 joined #koha |
| 07:35 |
|
magnuse |
\o/ |
| 07:40 |
|
|
thibaud_g joined #koha |
| 07:54 |
|
cait |
Joubu: around? |
| 07:57 |
|
Joubu |
yes |
| 08:01 |
|
cait |
ah, I was looking at the late orders, I think the active filter will work |
| 08:01 |
|
cait |
commented |
| 08:04 |
|
Joubu |
cait: the second patch is removing the orderstatus condition from filter_by_lates |
| 08:04 |
|
Joubu |
- ( orderstatus => { '-not_in' => ['cancelled', 'complete'] } ), |
| 08:07 |
|
cait |
yes, I was trying to say both variations include "new" |
| 08:07 |
|
cait |
and the is_active is actually better |
| 08:07 |
|
cait |
because it only includes new for stnding orders |
| 08:07 |
|
cait |
which is more correct |
| 08:12 |
|
|
LibraryHU[m] joined #koha |
| 09:35 |
|
cait |
where is my team? |
| 09:35 |
|
ashimema |
present but unavailable |
| 09:36 |
|
cait |
not sure if that counts |
| 09:36 |
|
ashimema |
sorry |
| 09:36 |
|
ashimema |
I have people breathing down my neck to get code written |
| 09:36 |
|
cait |
that sounds rather uncomfortable |
| 09:37 |
|
ashimema |
mm |
| 09:37 |
|
ashimema |
never enough time |
| 09:37 |
|
ashimema |
I really really wanted to get trustedsco finished today |
| 09:37 |
|
ashimema |
but alas. bookings is having to take priority |
| 09:44 |
|
cait |
Joubu++ # reading QA mails and fixing bugs :) (or it could be just coincidence) |
| 09:48 |
|
Joubu |
not a coincidence ;) |
| 09:49 |
|
cait |
:) |
| 09:49 |
|
cait |
do you want to squash 33653? |
| 09:52 |
|
Joubu |
I would keep both patches |
| 09:59 |
|
cait |
ok |
| 10:00 |
|
cait |
I see we just overlapped on bug 32959 - I can't reproduce the issue on master, could you? |
| 10:00 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32959 normal, P5 - low, ---, kyle, Passed QA , Item Templates will apply the same barcode each time template is applied if autobarcode is enabled |
| 10:00 |
|
cait |
only time it prefilled barcode was when I stored the item template with one |
| 10:01 |
|
cait |
off to lunch |
| 10:12 |
|
Joubu |
yes, with autobarcode=incremental |
| 10:14 |
|
|
fridolin1 left #koha |
| 10:20 |
|
|
khall joined #koha |
| 10:25 |
|
Joubu |
mtj: did you rename Koha_Master_OS7 to Koha_Master_OS1? |
| 10:30 |
|
oleonard-away |
jajm around? |
| 11:02 |
|
|
khall_ joined #koha |
| 11:14 |
|
|
marcelr joined #koha |
| 11:14 |
|
marcelr |
o/ |
| 11:16 |
|
tcohen |
hola #koha o/ |
| 11:20 |
|
marcelr |
hi tcohen |
| 11:21 |
|
marcelr |
bug 32894 |
| 11:21 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32894 major, P5 - low, ---, jonathan.druart+koha, Signed Off , Objects cache methods' result without invalidation |
| 11:22 |
|
tcohen |
Joubu it turned out to be a problem with a Jenkins node... |
| 11:22 |
|
tcohen |
I just disbaled it |
| 11:23 |
|
tcohen |
hi marcelr, been keeping an eye on that |
| 11:23 |
|
tcohen |
kidclamp, khall_ any chance you could review 32894 |
| 11:24 |
|
khall_ |
I'll have a look! |
| 11:24 |
|
tcohen |
khall++ |
| 11:24 |
|
tcohen |
thanks for the reminder marcelr |
| 11:24 |
|
tcohen |
marcelr++ |
| 11:24 |
|
tcohen |
Joubu++ |
| 11:25 |
|
marcelr |
tcohen: i was about to do it myself but khall obviously is a better choice :) lol |
| 11:26 |
|
tcohen |
I thought you were asking for QA on it |
| 11:26 |
|
marcelr |
no i was checking the number |
| 11:26 |
|
marcelr |
no problem |
| 11:26 |
|
marcelr |
i pick another one, enough choice :) |
| 11:27 |
|
marcelr |
and something else, anyone ready for testing Statistics? bug 33608 |
| 11:27 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33608 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Allow to get statistics about found/recovered books |
| 11:27 |
|
marcelr |
the last step before saying goodbye to C4::Stats |
| 11:31 |
|
cait |
oh fun |
| 11:32 |
|
cait |
let's have a QA party! |
| 11:32 |
|
marcelr |
qa_party++ |
| 11:32 |
|
cait |
I just had coffee, back on it now :) |
| 11:33 |
|
marcelr |
i start with 33277 |
| 11:33 |
|
cait |
please put QA contact, already clashed with Joubu earlier |
| 11:33 |
|
marcelr |
i am moving them to blocked as well |
| 11:33 |
|
marcelr |
experience |
| 11:40 |
|
cait |
if you are not on it alrey, I might focus on oleonard's for a start, trying to get all those finished |
| 11:42 |
|
marcelr |
great |
| 11:48 |
|
oleonard |
This feels messy but I think it works: |
| 11:48 |
|
oleonard |
[% tx("Details for {title}:", {title = ""}) | html %] [% INCLUDE 'biblio-title-head.inc' %] |
| 11:48 |
|
oleonard |
...since I can't pass the biblio-title include as a parameter, but I want to show the context |
| 11:50 |
|
cait |
oleonard: i am still staring at it... |
| 11:51 |
|
oleonard |
I keep hoping to catch jajm to get his opinion |
| 11:52 |
|
|
khall joined #koha |
| 11:53 |
|
oleonard |
The other issue I'm having trying to leverage the I18N stuff is $KohaDates :( |
| 11:53 |
|
tcohen |
oh, who's that khall_ we asked to QA things |
| 11:54 |
|
cait |
oleonard: there is a JS version of it |
| 11:54 |
|
cait |
woudl that help any? |
| 11:54 |
|
cait |
hm or maybe I am confusing it with the monetary amounts one |
| 11:55 |
|
|
khall joined #koha |
| 11:55 |
|
ashimema |
js-biblio-format.inc |
| 11:56 |
|
magnuse |
qateam++ |
| 11:57 |
|
|
khall joined #koha |
| 11:59 |
|
paxed |
oleonard: couldn't you do something like [% bibtitle = BLOCK %][% INCLUDE 'biblio-title-head.inc' %][% END %][% tx("Details for {title}:", {title = bibtitle}) | html %] |
| 12:00 |
|
paxed |
(off the top of my head, so not tested) |
| 12:00 |
|
|
alex_ joined #koha |
| 12:01 |
|
oleonard |
That works, paxed, thanks! |
| 12:02 |
|
oleonard |
And I can do the same with dates |
| 12:07 |
|
Joubu |
tcohen: how do we make bug 33606 move forward? |
| 12:07 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=33606 blocker, P5 - low, ---, jonathan.druart+koha, In Discussion , Access to ERM requires parameters => 'manage_sysprefs' |
| 12:10 |
|
tcohen |
someone needs to work on a sane structure to return? |
| 12:10 |
|
tcohen |
or if you don't really agree with what I propose, we could make some vote |
| 12:17 |
|
Joubu |
users.json seems overkill in this context. We really need something easy to implement to fix the oerlussui |
| 12:17 |
|
Joubu |
users.json seems overkill in this context. We really need something easy to implement to fix the permission issue* |
| 12:26 |
|
tcohen |
I just mentioned that example as a possible data structure |
| 12:27 |
|
tcohen |
but it could certainly be /config/erm |
| 12:27 |
|
tcohen |
i.e. constrained to specific modules |
| 12:27 |
|
tcohen |
and instead of exposing the sysprefs |
| 12:27 |
|
tcohen |
list enabled modules |
| 12:27 |
|
tcohen |
or components |
| 12:29 |
|
tcohen |
in terms of your solution, it is just a matter of naming things more generically, and consistently |
| 12:53 |
|
mtj |
hi Joubu, yes i renamed to OS1 |
| 12:53 |
|
mtj |
sorry, i realise i broke the dashboard |
| 12:54 |
|
mtj |
happy to fix either jenkins or dash |
| 12:55 |
|
|
khall joined #koha |
| 12:56 |
|
tcohen |
cait, Joubu: shouldn't the ->filter_by_active be implicit instead? |
| 12:56 |
|
tcohen |
I'm not sure if 'late' orders can be not-current |
| 12:56 |
|
cait |
can you explain? |
| 12:56 |
|
cait |
ok, can you rephrase? |
| 12:57 |
|
tcohen |
the original implementation adds an internal filtering on 'active' inside ->filter_by_lates |
| 12:57 |
|
cait |
late orders can only be orders not received or cancelled yet |
| 12:57 |
|
tcohen |
the last patch removes that implicit filter, and calls ->filter_by_lates->filter_by_active |
| 12:57 |
|
cait |
yes |
| 12:57 |
|
cait |
it's the same |
| 12:58 |
|
cait |
just turned around |
| 12:58 |
|
tcohen |
shouldn't ->filter_by_active be called inside ->filter_by_lates |
| 12:58 |
|
cait |
sorry meeting, but joubu might be better to answer this |
| 12:58 |
|
tcohen |
it is exactly what you said cait |
| 12:58 |
|
tcohen |
'late orders can only be orders not received or cancelled yet' |
| 12:58 |
|
tcohen |
the way the last patch does it |
| 12:59 |
|
cait |
is positive checking, has the status... |
| 12:59 |
|
cait |
but it#s better |
| 12:59 |
|
tcohen |
we have a method ->filter_by_lates that might return invalid late orders |
| 12:59 |
|
cait |
because it includes a good limit on standing orders |
| 12:59 |
|
cait |
ah |
| 12:59 |
|
tcohen |
you got it |
| 12:59 |
|
cait |
instead of filtering twice |
| 12:59 |
|
cait |
include the filter in lfilter-by-lats |
| 12:59 |
|
cait |
still have to leave :( |
| 12:59 |
|
tcohen |
pretty much as the original patch did |
| 13:00 |
|
tcohen |
just chaining ->filter_by_active inside |
| 13:00 |
|
tcohen |
I can follow-up |
| 13:03 |
|
|
caroline joined #koha |
| 13:10 |
|
|
Dyrcona joined #koha |
| 13:38 |
|
|
marie-luce joined #koha |
| 13:39 |
|
tcohen |
cait: please review my alternate follow-up |
| 14:01 |
|
aude_c[m] |
Koha Documentation meeting: happening now! https://wiki.koha-community.or[…]eeting_9_May_2023 Join at https://meet.jit.si/moderated/[…]4170d8660bb34205c |
| 14:02 |
|
marie-luce |
Hi all |
| 14:02 |
|
aude_c[m] |
Hi marie-luce Hopefully the Jitsi link works ok for you |
| 14:04 |
|
marie-luce |
it's working well |
| 14:04 |
|
tcohen |
mtj: Docker_3 has been giving weird errors that point to disk space |
| 14:04 |
|
tcohen |
that's why it is disabled |
| 14:10 |
|
aude_c[m] |
Having problems with the Jitsi link above so we are switching the Docs meeting to this one: https://meet.jit.si/Documentat[…]crophoneBrickBird |
| 14:12 |
|
aude_c[m] |
That one works :) |
| 14:14 |
|
mtj |
hi tcohen, hmm, d3 errors are strange?! i dont think its a disk space problem.. :/ |
| 14:15 |
|
mtj |
i have rebooted, and added more ram |
| 14:19 |
|
mtj |
...feel free to enable node and retry |
| 14:21 |
|
tcohen |
this was the failure |
| 14:21 |
|
tcohen |
https://jenkins.koha-community[…]/2494/consoleFull |
| 14:29 |
|
marcelr |
qa_team: anyone for a second look on bug 32730 ? |
| 14:29 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=32730 enhancement, P5 - low, ---, michael.hafen, Signed Off , Add patron lists tab to patron details and circulation pages |
| 14:30 |
|
marcelr |
qa_team? |
| 14:30 |
|
marcelr |
they are all gone :) |
| 14:31 |
|
mtj |
tcohen: aah, i see a full tmpfs in the syslog, have fixed now |
| 14:31 |
|
mtj |
will keep an eye on it |
| 14:37 |
|
tcohen |
mtj: cool I enabled it |
| 14:37 |
|
tcohen |
marcelr: there's you, what else do we need? :-D |
| 14:37 |
|
marcelr |
a lot of qaers |
| 14:38 |
|
marcelr |
or a coin to choose between PQA and FQA |
| 14:38 |
|
tcohen |
I can flip that coin |
| 14:38 |
|
tcohen |
which bug? |
| 14:38 |
|
marcelr |
32730 |
| 14:38 |
|
marcelr |
it feels not good enough.. |
| 14:38 |
|
cait |
sorry, just got out of a meeting |
| 14:40 |
|
tcohen |
I don't like those method names |
| 14:40 |
|
tcohen |
well, name |
| 14:41 |
|
tcohen |
or plain DBIC |
| 14:41 |
|
tcohen |
it needs more work |
| 14:41 |
|
tcohen |
FQA |
| 14:41 |
|
tcohen |
it would be good to give a list of changes |
| 14:41 |
|
tcohen |
to encourage them to keep working on it |
| 14:50 |
|
marcelr |
ok tcohen i'll paste that on the report |
| 14:52 |
|
marcelr |
tcohen: i never tell exactly what someone should do, otherwise i loose my qa token ;) |
| 14:52 |
|
tcohen |
you don't loose it |
| 14:52 |
|
tcohen |
not with me at least |
| 15:00 |
|
|
bag joined #koha |
| 15:01 |
|
marcelr |
tcohen: please check my question on the FQA patch 29185 |
| 15:02 |
|
tcohen |
the latter |
| 15:02 |
|
tcohen |
you are manually quoting something that comes from the record |
| 15:02 |
|
tcohen |
and could in theory contain quote chars |
| 15:02 |
|
marcelr |
ok thats a pointer |
| 15:04 |
|
marcelr |
htg |
| 15:10 |
|
reiveune |
bye |
| 15:10 |
|
|
reiveune left #koha |
| 16:03 |
|
|
cait left #koha |
| 16:38 |
|
|
cait joined #koha |
| 16:47 |
|
aude_c[m] |
Notes from today's Documentation meeting added to the wiki page https://wiki.koha-community.or[…]eeting_9_May_2023 caroline Please do correct if you spot anything wrong! |
| 16:48 |
|
caroline |
It's great thanks aude_c++! |
| 18:10 |
|
tcohen |
no knife? |
| 18:16 |
|
tcohen |
any docs on accesibility in Koha? |
| 18:17 |
|
caroline |
tcohen, not in the manual |
| 18:17 |
|
caroline |
in the wiki maybe? https://wiki.koha-community.or[…]iki/Accessibility |
| 18:18 |
|
caroline |
It's not much |
| 18:18 |
|
caroline |
https://wiki.koha-community.or[…]nes#Accessibility |
| 18:27 |
|
tcohen |
right |
| 18:28 |
|
tcohen |
but we don't have brochure-like information about the accessibility guidelines we adhere to, etc |
| 18:29 |
|
caroline |
not that I know of |
| 18:30 |
|
tcohen |
that's a pity |
| 18:33 |
|
caroline |
I think the UK is pretty advanced/has laws for accessibility on websites, maybe ptfs-e has something? |
| 18:38 |
|
tcohen |
I found a nice video from our beloved ashimema about it |
| 18:39 |
|
tcohen |
https://www.youtube.com/watch?v=ZJVTg-wmp5g |
| 18:40 |
|
ashimema |
We require AA for all public websites now |
| 18:40 |
|
ashimema |
Kohabis not quite there yet |
| 18:40 |
|
caroline |
what is AA? (other than alcoholic anonymous) |
| 18:40 |
|
ashimema |
We were close but have fallen behind a bit again |
| 18:41 |
|
ashimema |
WCAG AA |
| 18:41 |
|
ashimema |
There are three levels.. A, AA and AAA |
| 18:41 |
|
caroline |
ah ok! |
| 18:41 |
|
ashimema |
Our OPAC is almost AA l, the staff client I've not checked in a while |
| 18:42 |
|
ashimema |
I do have a recent assesment I can share as needed.. but these assesments always include people's local customisations.. |
| 18:42 |
|
ashimema |
We're looking at sponsoring an annual or maybe even biannual external assessment |
| 18:42 |
|
ashimema |
But we can't also pick up the tab to always fix everything |
| 18:42 |
|
ashimema |
We spent a lot helping to get us over the line last time |
| 18:49 |
|
|
MarkHofstetter1 joined #koha |
| 20:13 |
|
tcohen |
am I online? |
| 20:13 |
|
tcohen |
yes |
| 20:55 |
|
cait |
no ;) |
| 21:10 |
|
ashimema |
Maybe |
| 21:16 |
|
davidnind |
cait++ (for answering all the mailing list questions!) |
| 21:28 |
|
caroline |
cait++ with such saintly patience too! |
| 21:51 |
|
davidnind |
aude_c++ |
| 21:51 |
|
davidnind |
caroline: apologies for not making the docs meeting (I set my alarm, but it was a long day yesterday...) |
| 22:18 |
|
cait |
davidnind: I have cleaned up the wiki some, I think i got all the pages deleted |
| 22:18 |
|
cait |
not sure what to do about the account pages |
| 22:19 |
|
cait |
but I hope it helps a little bit already |
| 22:21 |
|
davidnind |
cait++ |
| 22:21 |
|
davidnind |
thanks cait! |
| 22:22 |
|
davidnind |
hopefully thd can have a look at the account request settings |
| 22:23 |
|
cait |
i hope he'll see hte comment |
| 22:23 |
|
cait |
we need to shut down the second registration form |
| 22:23 |
|
cait |
good night :) |
