IRC log for #koha, 2022-06-03

All times shown according to UTC.

Time S Nick Message
00:42 koha-jenkins Project Koha_22.05_U22 build #1: SUCCESS in 37 min: https://jenkins.koha-community[…]Koha_22.05_U22/1/
00:43 fridolin joined #koha
00:55 koha-jenkins Yippee, build fixed!
00:55 koha-jenkins Project Koha_22.05_D11 build #3: FIXED in 58 min: https://jenkins.koha-community[…]Koha_22.05_D11/3/
00:55 wahanui Congratulations!
01:00 koha-jenkins Project Koha_22.05_U20 build #1: UNSTABLE in 54 min: https://jenkins.koha-community[…]Koha_22.05_U20/1/
01:22 koha-jenkins Project Koha_22.05_U18 build #1: UNSTABLE in 40 min: https://jenkins.koha-community[…]Koha_22.05_U18/1/
02:04 koha-jenkins Yippee, build fixed!
02:04 koha-jenkins Project Koha_22.05_U20 build #2: FIXED in 1 hr 1 min: https://jenkins.koha-community[…]Koha_22.05_U20/2/
02:04 wahanui Congratulations!
02:30 koha-jenkins Project Koha_22.05_U18 build #2: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]Koha_22.05_U18/2/
03:31 koha-jenkins Project Koha_22.05_D11 build #4: UNSTABLE in 1 hr 11 min: https://jenkins.koha-community[…]Koha_22.05_D11/4/
04:35 koha-jenkins Yippee, build fixed!
04:35 koha-jenkins Project Koha_22.05_D11 build #5: FIXED in 54 min: https://jenkins.koha-community[…]Koha_22.05_D11/5/
04:35 wahanui Congratulations!
04:36 MarkHofstetter joined #koha
05:04 tuxayo Joubu: Hi, thanks for the feedback on bug 30733, if it turns out i18n TT functions are usable, that would be a welcome twist of events. I just need a confirmation and them I could replace those ugly <span> asap :D
05:04 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30733 enhancement, P5 - low, ---, victor, Failed QA , Simplify translatable strings
05:07 koha-jenkins Project Koha_22.05_D11 build #6: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]Koha_22.05_D11/6/
05:07 koha-jenkins Project Koha_22.05_D11 build #7: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]Koha_22.05_D11/7/
05:09 reiveune joined #koha
05:09 reiveune hello
05:15 Joubu tuxayo: why ugly?
05:21 MarkHofstetter joined #koha
05:21 mtj hey peeps, 22.05 packages are pushed
05:26 Joubu # If there is no loan, return and transfer, we show a checkbox.
05:26 Joubu $itemLoopIter->{notforloan} = $itemLoopIter->{notforloan} || 0;
05:26 Joubu what does that mean?!
05:27 Joubu thanks, mtj!
05:46 MarkHofstetter1 joined #koha
05:50 tuxayo mtj++
05:52 tuxayo Joubu: span clutter the templates and dont have explicit string delimitation semantic.
05:54 tuxayo They will seem to make no sense to most people not knowing they are an i18n workaround
05:57 m23 joined #koha
06:12 m23_ joined #koha
06:14 m23 joined #koha
06:19 marcelr joined #koha
06:19 marcelr hi #koha
06:39 magnuse \o/
06:40 marcelr hi magnuse
06:40 magnuse hiya marcelr
06:42 alex_ joined #koha
06:50 marcelr Joubu++ # refactoring phase 2
06:50 marcelr or was it 23
06:53 Joubu marcelr: it's scary to see how many times we are calling GetItemsInfo uselessly
06:54 marcelr i imagine
06:54 marcelr i suppose that after 29697 we need some rebases ?
06:55 marcelr Joubu i have some tests failing but this could be on master already..
06:56 Joubu marcelr: I wrote the patches on top of 29697 :)
06:56 marcelr great
06:56 marcelr at least 29697 passed qa tools now
06:56 Joubu marcelr: ha, I forgot to adjust the number of tests
06:57 marcelr dont touch 29697 now while i am on it
06:57 marcelr i will rewrite it :)
06:57 Joubu rewrite?
06:59 marcelr the smiley warned you
07:00 Joubu ha! :D
07:02 marcelr i saw it this on another report mentioned also: Data too long for column 'lccn'
07:02 lds joined #koha
07:02 marcelr did someone mess up our schema ?
07:03 marcelr new structure or so ?
07:06 Joubu where do you see that?
07:07 Joubu bug 28328
07:07 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=28328 major, P5 - low, ---, koha-bugs, NEW , Editing a record can cause an ISE if data too long for column
07:11 marcelr bug 30896
07:11 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30896 normal, P5 - low, ---, koha-bugs, NEW , DB Error "Data too long for column 'lccn'" coming up here and there
07:13 Joubu marcelr: the test passes for me
07:13 Joubu do you have strict_mode on?
07:14 Joubu hum, maybe not related to strict_mode
07:16 marcelr btw this is on top of 29697 now
07:16 marcelr didnt check pure master yet
07:16 marcelr | lccn                  | varchar(25)  | YES  |     | NULL                |                               |   `lccn` varchar(25) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'library of congress control number (MARC21 010$a)',
07:16 marcelr this looks ok
07:16 marcelr structure and database
07:17 dcook It would be good to know what data is causing the problem...
07:17 Joubu tests also pass on top of 29697 for me
07:17 dcook When I see errors like that, it's usually bad data someone is trying to import..
07:18 Joubu marcelr: your test is failing because the error is not occurring, did you notice?
07:18 marcelr master passes
07:18 marcelr yes i saw it
07:18 marcelr might be strict mode
07:19 marcelr but then i dont understand it too
07:19 marcelr and now it passes on top of 29697..
07:20 marcelr with and without strict
07:20 marcelr so it is a bit random
07:44 Joubu marcelr: (follow-up) Use flag embed_items
07:44 Joubu I found this bug yesterday, the 2 patches must be squashed
07:44 marcelr did you test performance ?
07:44 Joubu this one (the last patch) is just doing 's/$id/$record_id', that's a typo from the first "Use flag embed_items" patch
07:44 marcelr we are now going always to Biblios->find and then metadata ?
07:45 Joubu what we did before
07:45 marcelr i'll squash them
07:45 marcelr sure?
07:45 Joubu we *almost* always fetch the biblio object and then the marc
07:45 marcelr we went to XmlBiblio
07:46 marcelr and that goes directly to metadata
07:46 marcelr so we do more db access here
07:47 marcelr if we go this way, we should remove GetXmlBiblio too
07:47 marcelr on a new report
07:47 marcelr it feels overkill to look for the complete biblio object
07:47 Joubu I am not afraid of perf
07:48 marcelr why
07:48 Joubu we should remove C4 too :D
07:48 Joubu as said before, we are doing a select from biblio already, then we are fetching the marc from metadata
07:48 Joubu that's not different from the current situation
07:49 marcelr ^^  i think we did not always do a select from biblio before
07:49 Joubu unless you are looking at a specific script where we were fetching only the marc?
07:49 marcelr there are such places
07:50 marcelr just glancing thru the second patch
07:50 Joubu C4::AuthoritiesMarc::merge didn't fetch the biblio
07:51 marcelr so thats 50 biblio calls more
07:51 Joubu that's a good point
07:52 Joubu Cannot think about a good place/naming to put that however
07:52 Joubu tcohen: ^^ yet another example
07:54 marcelr Koha::Metadatas->find
07:54 marcelr or something ;)
07:58 Joubu lol, yes
07:58 Joubu we could do that
07:59 Joubu but you will need
07:59 Joubu Koha::Biblio::Metadatas->search({ biblionumber => 42 })->next
07:59 Joubu then ->record
07:59 Joubu You will assume that there is only one row (per record) in the table
08:01 marcelr assumptions are generally dangerous :)
08:01 Joubu actually Koha::Biblio::Metadatas->find({ biblionumber => 42, format => 'marcxml', schema => C4::Context->preference('marcflavour') })
08:01 Joubu that's getting messy a big
08:01 Joubu bit
08:01 marcelr indeed
08:02 Joubu I would keep the biblio fetch :)
08:02 marcelr we could postpone this though
08:02 Joubu it's worth a note on the bug
08:02 marcelr generally the change looks clean
08:02 marcelr i posted a comment already
08:05 Joubu tig
08:05 Joubu oops
08:21 liliputech joined #koha
08:23 liliputech hi koha, i have an issue using k-t-d , exits with errors when checking state of biblios index . can anyone have any issues?
08:23 Joubu what's the error?
08:23 wahanui hmmm... the error is a silent one which is not visible unless i enable verbose logging for zebra
08:23 liliputech (i mean, does anyone other than me have issues with ktd)
08:24 liliputech koha-koha-1       | [903] Checking state of biblios index
08:24 liliputech koha-koha-1 exited with code 1
08:24 Joubu did you extend your RAM? :D
08:24 Joubu you had RAM space problems at the hackfest iirc
08:24 Joubu post the whole output
08:25 liliputech I have 8Gb now... + freed some disk memory (needed for ES)
08:27 liliputech
08:27 liliputech I see a vm.max_map_size error, I'll check this and retry
08:28 liliputech koha-es-1         | [1]: max virtual memory areas vm.max_map_count [65530] is too low, increase to at least [262144]
08:33 Joubu yes, good idea ;)
08:39 cait joined #koha
09:13 marcelr Joubu 29697 found few glitches after PQA
09:15 Joubu marcelr: are you fixing or do you want me to do it?
09:15 marcelr no you are the privileged one
09:15 Joubu ok, I've just replied to the other comments, I will reattach the patchset with the typo fixed
09:16 cait1 joined #koha
09:17 Joubu add more caits!
09:21 magnuse looks like there is sometimes a problem with the upgrade to 21.11.06: bug 30899
09:21 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30899 critical, P5 - low, ---, koha-bugs, NEW , Upgrade sometimes fails at "Upgrade to"
09:31 MarkHofstetter joined #koha
09:32 Joubu marcelr: this one is for you ^^ :)
09:34 marcelr lol
09:34 marcelr will do
09:42 * cait1 waves from a train
09:43 cait1 Joubu: sorry - probably the disconnects from the internet connection here
09:43 cait1 I'll be back Tuesday, we have a holiday on Monday
09:47 magnuse cait1: here too :-)
10:24 oleonard Hi all
10:24 magnuse kia ora oleonard
10:24 oleonard What's the holiday Monday?
10:25 magnuse 2. pinsedag ;-)
10:25 magnuse pentecost?
10:25 magnuse second day of pentecost?
10:29 oleonard That was not one I knew about!
10:30 magnuse i don't think a lot of people here know too much about it either...
10:31 oleonard They know enough to stay home? :)
10:32 MarkHofstetter joined #koha
11:33 oleonard_ joined #koha
11:49 magnuse oleonard: yup, or go to the cottage or something
11:56 liliputech pentecôte in french :)
11:57 oleonard liliputech: Do you have a cottage? :)
11:57 liliputech yay, ktd working again on my machine!
11:58 liliputech oleonard: i don't have a cottage but i rent my flat to other people (i live in the mountains, nice hiking tracks)
12:01 * oleonard loves living in a place with good hiking trails
12:05 * liliputech doesn't do much hiking these days but enjoys the view
12:06 liliputech aha, the pente-cottage, now I get it :')
12:06 * liliputech 's brainzzz is kinda slow on friday
12:07 liliputech how can i run ktd for a specific koha version? 21.11? need to run the tests after applying patch 29828 to 21.11.x branch
12:08 magnuse not the best of forecasts here, sadly...
12:09 oleonard liliputech: I don't know if there's a better way, but I check out 21.11.x and then reset_all. Sometimes I have to install some dependencies required by older versions.
12:09 oleonard liliputech: I don't start up a new ktd or anything, I just use what I've currently got running.
12:09 magnuse sounds too easy :-)
12:10 liliputech got this : Error:  Can't locate JSON/Validator/OpenAPI/ in @INC (you may need to install the JSON::Validator::OpenAPI::Mojolicious module
12:10 liliputech trying to solve with cpanm
12:10 oleonard cpanm Mojolicious::Plugin::OpenAPI@2.16 --force
12:11 oleonard Then of course you have to upgrade it when you switch back to master
12:12 liliputech yep, working better :) thx
12:12 Joubu oleonard, git bisect expert :D
12:13 oleonard I'm a glutton for punishment
12:13 liliputech if all tests are green, i might be ready to push my first rmaint patch by the end of the afternoon ^^
12:13 Joubu liliputech: for rmaint you should use the relevant ktd image!
12:13 liliputech oh?
12:13 wahanui oh are there instructions?
12:14 oleonard Good one wahanui
12:14 Joubu before you start ktd, set KOHA_IMAGE=21.05
12:14 Joubu well, adjust the version
12:14 Joubu KOHA_IMAGE=XX.YY ku
12:14 liliputech Joubu: maybe i should use marc21 instead of unimarc? i have xslt tests failing here, guess it's because of unimarc. my version is 21.11 I think
12:15 liliputech will try
12:15 Joubu and yes, I would use marc21 for rmaint tasks
12:15 liliputech thx for the hint ;)
12:17 liliputech Joubu: ok to apply 29828 to 21.11? no conflict, that was an easy one :) that's the latests i've seen since the 22.05 latest release, so, I guess that's the right patch to cherry-pick?
12:18 Joubu yes, I think it should be backported
12:19 liliputech nice. I've already made the branch and stuff, now doing the tests before merge
12:21 liliputech got fails : #   Failed test 'All directories must be listed in Makefile.PL'
12:21 liliputech #   at xt/check_makefile.t line 39.
12:21 liliputech #          got: '6'
12:21 liliputech #     expected: '0'
12:21 liliputech # $VAR1 = [
12:21 liliputech #           './config.php',
12:21 liliputech #           './node_modules',
12:21 liliputech #           './patches',
12:21 liliputech #           './plugin',
12:21 liliputech #           './xsltintra',
12:21 liliputech #           './xsltopac'
12:21 liliputech #         ];
12:22 liliputech also, when I started ktd, i'm not sure if it took the proper ktd image... how can i check? still missing deps after starting...
12:22 Joubu yes, some tests don't check if the files are from the git repo
12:23 Joubu so they process all the files in the koha src dir, even those that are ignored or not committed
12:24 liliputech false fail you mean?
12:26 Joubu if the files are not part of the git directory (which is the case here), yes you can ignore them
12:26 liliputech fiuuuh. alright.
12:27 liliputech tests seems alright, doing a bit of testing in the interface before merge/push
12:27 liliputech (not sure i do have push rights though)
12:28 Joubu you do
12:28 Joubu if you setup your ssh keys
12:32 liliputech i did. i do have push rights :) i pushed =O
12:32 liliputech (beware of the bugs)
13:07 koha-jenkins Project Koha_21.11_D10 build #101: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_21.11_D10/101/
13:09 liliputech yay
13:15 koha-jenkins Project Koha_21.11_U20 build #87: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_21.11_U20/87/
13:29 lukeg joined #koha
13:36 koha-jenkins Project Koha_21.11_U18 build #91: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]oha_21.11_U18/91/
13:37 magnuse liliputech++
13:41 koha-jenkins Project Koha_21.11_U22 build #21: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_21.11_U22/21/
13:42 lukeg hello
13:42 liliputech hi lukeg
13:42 koha-jenkins Project Koha_21.11_D11 build #113: UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]ha_21.11_D11/113/
13:51 koha-jenkins Project Koha_21.11_D9 build #79: SUCCESS in 1 hr 16 min: https://jenkins.koha-community[…]Koha_21.11_D9/79/
14:00 koha-jenkins Project Koha_21.11_D12 build #74: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_21.11_D12/74/
14:00 Dyrcona joined #koha
14:13 koha-jenkins Project Koha_22.05_D11 build #8: ABORTED in 49 sec: https://jenkins.koha-community[…]Koha_22.05_D11/8/
14:16 m23 joined #koha
14:51 liliputech 'd evening koha
15:00 bag joined #koha
15:20 reiveune bye
15:20 reiveune left #koha
15:23 koha-jenkins Project Koha_22.05_D11 build #9: UNSTABLE in 1 hr 10 min: https://jenkins.koha-community[…]Koha_22.05_D11/9/
15:56 caroline joined #koha
16:57 oleonard Anyone awake?
16:57 * kidclamp blinks
16:57 oleonard kidclamp: Do you know anything about how we format dates in JavaScript, generally speaking?
17:01 bag mm/dd/yyyy :P
17:01 * bag ducks
17:01 oleonard !bang
17:02 bag ha!
17:02 kidclamp I am not sure
17:03 kidclamp bug 30059
17:03 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30059 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Add a JS equivalent to Koha::Patron->get_age
17:03 kidclamp may have a hint
17:05 oleonard I will blunder about as usual
17:59 tcohen hi all
18:27 fridolin joined #koha
19:32 lukeg joined #koha
19:52 dpk__ joined #koha
19:55 m23 joined #koha
20:11 m23 joined #koha
20:11 lukeg joined #koha
20:28 davidnind joined #koha
20:34 cait joined #koha
22:11 cait joined #koha
23:19 koha-jenkins Project Koha_Master build #2044: STILL UNSTABLE in 42 min: https://jenkins.koha-community[…]Koha_Master/2044/
23:22 alohabot 🎁 🐮 Koha '20.11.x' packages pushed to 'koha' repo  ðŸ…🌍🚀
23:42 alohabot 🎁 🐯 Koha '20.11.x' packages pushed to 'koha' repo  ðŸ…🌍🚀

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary