Time |
S |
Nick |
Message |
00:08 |
|
koha-jenkins |
Yippee, build fixed! |
00:08 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #871: FIXED in 56 min: https://jenkins.koha-community[…]1_MDB_Latest/871/ |
00:08 |
|
wahanui |
Congratulations! |
00:14 |
|
koha-jenkins |
Yippee, build fixed! |
00:14 |
|
koha-jenkins |
Project Koha_Master_Sid build #18: FIXED in 1 hr 2 min: https://jenkins.koha-community[…]ha_Master_Sid/18/ |
00:14 |
|
wahanui |
Congratulations! |
00:15 |
|
alohabot |
🎠🦄 Koha 'master' packages pushed to 'koha-staging' repo ðŸ„ðŸŒðŸŒ |
00:15 |
|
koha-jenkins |
Project Koha_Master_U22 build #24: STILL UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]ha_Master_U22/24/ |
00:26 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #802: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]ster_D11_My8/802/ |
00:28 |
|
|
davidnind joined #koha |
00:33 |
|
|
davidnind1 joined #koha |
00:43 |
|
koha-jenkins |
Project Koha_Master_D9 build #1933: STILL UNSTABLE in 45 min: https://jenkins.koha-community[…]a_Master_D9/1933/ |
01:02 |
|
koha-jenkins |
Project Koha_Master_D12 build #131: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_D12/131/ |
01:14 |
|
|
davidnind joined #koha |
01:14 |
|
|
davidnind left #koha |
01:15 |
|
koha-jenkins |
Project Koha_Master_U20 build #371: STILL UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]a_Master_U20/371/ |
01:22 |
|
koha-jenkins |
Project Koha_Master_D10 build #607: STILL UNSTABLE in 1 hr 7 min: https://jenkins.koha-community[…]a_Master_D10/607/ |
01:24 |
|
koha-jenkins |
Project Koha_Master_U21 build #153: ABORTED in 28 min: https://jenkins.koha-community[…]a_Master_U21/153/ |
01:28 |
|
koha-jenkins |
Project Koha_Master_D10 build #608: ABORTED in 2 min 20 sec: https://jenkins.koha-community[…]a_Master_D10/608/ |
01:30 |
|
koha-jenkins |
Project Koha_Master_Sid build #19: UNSTABLE in 46 min: https://jenkins.koha-community[…]ha_Master_Sid/19/ |
01:34 |
|
koha-jenkins |
Project Koha_Master_D10 build #609: ABORTED in 3 min 11 sec: https://jenkins.koha-community[…]a_Master_D10/609/ |
01:34 |
|
koha-jenkins |
Project Koha_Master_U21 build #154: ABORTED in 12 sec: https://jenkins.koha-community[…]a_Master_U21/154/ |
01:43 |
|
|
hayley joined #koha |
01:43 |
|
koha-jenkins |
Project Koha_Master_D9 build #1934: STILL UNSTABLE in 40 min: https://jenkins.koha-community[…]a_Master_D9/1934/ |
02:18 |
|
koha-jenkins |
Project Koha_Master_U22 build #25: STILL UNSTABLE in 1 hr 2 min: https://jenkins.koha-community[…]ha_Master_U22/25/ |
02:22 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #872: UNSTABLE in 55 min: https://jenkins.koha-community[…]1_MDB_Latest/872/ |
02:23 |
|
koha-jenkins |
Project Koha_Master_U21 build #155: UNSTABLE in 45 min: https://jenkins.koha-community[…]a_Master_U21/155/ |
02:30 |
|
koha-jenkins |
Project Koha_Master build #1991: STILL UNSTABLE in 1 hr 8 min: https://jenkins.koha-community[…]Koha_Master/1991/ |
05:46 |
|
|
fridolin joined #koha |
06:14 |
|
|
marcelr joined #koha |
06:14 |
|
marcelr |
o/ |
06:16 |
|
|
alex_ joined #koha |
06:17 |
|
alex_ |
Bonjour |
06:17 |
|
wahanui |
niihau, alex_ |
06:21 |
|
|
reiveune joined #koha |
06:22 |
|
reiveune |
hello |
06:22 |
|
wahanui |
kia ora, reiveune |
06:37 |
|
matts |
hi! |
06:55 |
|
Joubu |
no fridolin? |
06:55 |
|
wahanui |
well, no fridolin is indeed, but maybe not on RMaint for both 17.11 and 17.05 |
06:56 |
|
Joubu |
@later tell fridolin did you push 30373 on purpose? It will have side-effects, like unimarc sandboxes won't be setup correctly |
06:56 |
|
huginn |
Joubu: The operation succeeded. |
06:56 |
|
Joubu |
@later tell fridolin misc4dev needs to be adjusted, we should have coordinated the push together |
06:56 |
|
huginn |
Joubu: The operation succeeded. |
06:58 |
|
marcelr |
hi Joubu |
06:58 |
|
wahanui |
hi Joubu are you around? |
06:58 |
|
marcelr |
how about 28998 ? |
06:59 |
|
ashimema |
bug 28998 |
06:59 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28998 enhancement, P5 - low, ---, jonathan.druart+koha, Failed QA , Encrypt borrowers.secret |
06:59 |
|
* ashimema |
is still looking at it.. but I think we need some sort of cleaner failure mode for when the config is not set? |
07:00 |
|
Joubu |
marcelr: I have to fix misc4dev before anything else today... |
07:00 |
|
marcelr |
Joubu: let me take a look then |
07:00 |
|
marcelr |
hi ashimema its the one you set to FQA :) |
07:01 |
|
ashimema |
indeed it is |
07:01 |
|
Joubu |
IIRC there is a warning on the about page if the config entry is missing |
07:01 |
|
marcelr |
thx for so ashimema++ |
07:01 |
|
Joubu |
that should be enough |
07:01 |
|
Joubu |
then, I strongly think it should be part of 22.05 |
07:01 |
|
marcelr |
yes it should |
07:01 |
|
Joubu |
and we shouldn't need to deal with and upgrade step |
07:01 |
|
huginn |
News from kohagit: Bug 27253: DBRev 21.12.00.037 <https://git.koha-community.org[…]ed0895268ac5e4a59> |
07:01 |
|
huginn |
News from kohagit: Bug 30373: (follow-up) Fix license <https://git.koha-community.org[…]21fa4a75ada2f0ac5> |
07:01 |
|
huginn |
News from kohagit: Bug 30446: (follow-up) Remove warning <https://git.koha-community.org[…]7052563a7816dc77c> |
07:01 |
|
huginn |
News from kohagit: Bug 30531: Add mock of UseRecalls to Search.t <https://git.koha-community.org[…]c241d492e830c0a62> |
07:01 |
|
huginn |
News from kohagit: Bug 30512: Staff interface search results template error <https://git.koha-community.org[…]821c6c87dd2519ede> |
07:01 |
|
huginn |
News from kohagit: Bug 30446: Add a test for GetTagsLabels <https://git.koha-community.org[…]02c2e621b017fef28> |
07:01 |
|
huginn |
News from kohagit: Bug 27253: Fix definition of updated_on in borrowers and deletedborrowers <https://git.koha-community.org[…]9256db9c910341ab6> |
07:01 |
|
ashimema |
there is.. but it also explodes really badly if it's not set |
07:02 |
|
ashimema |
I'm thinking a warning on the page where the user sets up 2FA |
07:02 |
|
ashimema |
that would do the trick if people agree |
07:02 |
|
marcelr |
thats a good one |
07:02 |
|
Joubu |
yep ok |
07:02 |
|
|
fridolin joined #koha |
07:02 |
|
ashimema |
also.. we've not thought about the case where a secret may have leaked |
07:02 |
|
ashimema |
as in the config key |
07:03 |
|
marcelr |
we have more 'secrets' now in koha-conf |
07:03 |
|
ashimema |
I'm sure I've seen an array of encryption keys somewhere.. where we work from newest to oldest for comparisons |
07:03 |
|
ashimema |
maybe it's mojo secrets |
07:03 |
|
marcelr |
trial and error ? |
07:04 |
|
ashimema |
there aught to be some sort of upgrade path for where you want to change encryption key down the line |
07:04 |
|
ashimema |
mm.. I can't remember the specifics |
07:04 |
|
ashimema |
I reckon lets add the warning for now.. I can do that.. |
07:04 |
|
marcelr |
its a good point but it is larger than that patch |
07:04 |
|
ashimema |
then I'm going to work on the bug that moves secrets into their own table.. |
07:04 |
|
marcelr |
i will do it, let you qa it again |
07:04 |
|
ashimema |
and in that one I'm considering using phc for storage |
07:05 |
|
ashimema |
awesome, thanks marcelr |
07:05 |
|
ashimema |
it was so close.. but I'm kinda glad I came back after screwing up my config and spotted the horrible 500 explosion |
07:05 |
|
ashimema |
haha |
07:05 |
|
|
lds joined #koha |
07:05 |
|
marcelr |
i considered setting tomas as assignee for the new one ;) |
07:05 |
|
ashimema |
no worries |
07:05 |
|
ashimema |
I'm on it. |
07:05 |
|
ashimema |
I'm also keen on he expiring passwords bug |
07:05 |
|
marcelr |
right |
07:06 |
|
ashimema |
I think with the changes in notices no longer allowing plain text passwords to be sent out, the requirement to reset password stuff is pretty reasonable |
07:06 |
|
marcelr |
it is a welcome feature |
07:06 |
|
marcelr |
we needed it for some time |
07:06 |
|
ashimema |
though I'm tempted to not set a temporary password at all but rather set a reset link with token instead |
07:07 |
|
ashimema |
yup |
07:07 |
|
ashimema |
I feel like all this stuff should be released in the same cycle though.. it's all related |
07:07 |
|
marcelr |
yeah remove the temp pwd would be a good follwoup |
07:07 |
|
ashimema |
hense my throwing time at it. |
07:07 |
|
marcelr |
lets do all the things in two weeks ! |
07:07 |
|
ashimema |
hehe |
07:08 |
|
marcelr |
and vacation right after that |
07:08 |
|
ashimema |
one for next cycle.. but I'm also considering.. should we start the migration from bcrypt to argon2 early next cycle |
07:08 |
|
ashimema |
for our password hashes |
07:08 |
|
marcelr |
sounds good |
07:09 |
|
ashimema |
keeping up with security is a pain aye 😉 |
07:09 |
|
marcelr |
i love secu patches |
07:19 |
|
alohabot |
🎠🦄 Koha 'master' packages pushed to 'koha-staging' repo ðŸ•ðŸ†ðŸ¥ž |
07:22 |
|
Joubu |
fridolin: ? |
07:23 |
|
fridolin |
Joubu: yep ? |
07:23 |
|
fridolin |
I"m actually on meeting |
07:28 |
|
Joubu |
fridolin: 30373 shouldn't have been pushed without coordination between us (I let a comment on the bug about that I think). misc4dev needs to be adjusted to fix UNIMARC |
07:28 |
|
Joubu |
fr-FR will also needs to be removed, all 3 should have been pushed at the same time. |
07:29 |
|
Joubu |
don't revert, I am on it (but I had other priorities for today...) |
07:29 |
|
Joubu |
I will certainly need to push the fr-FR removal at some point |
07:29 |
|
fridolin |
Joubu: ah sorry i did not get that |
07:29 |
|
fridolin |
tel me if i can help |
07:40 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #803: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]ster_D11_My8/803/ |
07:49 |
|
koha-jenkins |
Yippee, build fixed! |
07:49 |
|
koha-jenkins |
Project Koha_Master_U22 build #26: FIXED in 46 min: https://jenkins.koha-community[…]ha_Master_U22/26/ |
07:49 |
|
wahanui |
Congratulations! |
07:52 |
|
|
cait joined #koha |
07:55 |
|
|
severine_q joined #koha |
07:59 |
|
severine_q |
Hello #koha :) |
08:01 |
|
koha-jenkins |
Yippee, build fixed! |
08:01 |
|
koha-jenkins |
Project Koha_Master_U21 build #156: FIXED in 58 min: https://jenkins.koha-community[…]a_Master_U21/156/ |
08:01 |
|
wahanui |
Congratulations! |
08:03 |
|
fridolin |
ahhhhh |
08:06 |
|
koha-jenkins |
Yippee, build fixed! |
08:06 |
|
koha-jenkins |
Project Koha_Master_Sid build #20: FIXED in 1 hr 3 min: https://jenkins.koha-community[…]ha_Master_Sid/20/ |
08:06 |
|
wahanui |
Congratulations! |
08:17 |
|
koha-jenkins |
Project Koha_Master_U20 build #372: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_U20/372/ |
08:18 |
|
marcelr |
ashimema: 28998 is yours |
08:22 |
|
koha-jenkins |
Project Koha_Master_D9 build #1935: STILL UNSTABLE in 1 hr 18 min: https://jenkins.koha-community[…]a_Master_D9/1935/ |
08:28 |
|
ashimema |
ta |
08:31 |
|
Joubu |
marcelr: 2fa selenium tests are failing on top of 29894 |
08:31 |
|
Joubu |
Unable to locate element: //div[@class="dialog error"][contains(text(), "Invalid two-factor code")] |
08:32 |
|
Joubu |
hum wait, I didn't reset_all after my unimarc tests |
08:32 |
|
|
cait joined #koha |
08:33 |
|
marcelr |
ashimema: the 2fa test still needs attention on 28998 |
08:37 |
|
marcelr |
ashimema: added two mocks in last patch |
08:37 |
|
Joubu |
ashimema: confirmed, the test is failing after 29894 |
08:38 |
|
ashimema |
haha.. I was just about to run those |
08:38 |
|
ashimema |
thanks for the heads up |
08:38 |
|
marcelr |
Joubu i cant test these selenium ones |
08:39 |
|
Joubu |
ktd then prove, and it's working :) |
08:39 |
|
marcelr |
im not in ktd |
08:39 |
|
cait |
have a nice weekend all :) |
08:39 |
|
marcelr |
hi cait |
08:40 |
|
marcelr |
ashimema: the last patch changed |
08:40 |
|
ashimema |
doh.. I just bz attached when I didn't mean to.. curse my fingers |
08:40 |
|
ashimema |
ta |
08:40 |
|
Joubu |
marcelr: what problem do you have? selenium version mismatch? |
08:41 |
|
marcelr |
tried it recently, but did not spend enough time on it |
08:42 |
|
marcelr |
not sure where i stranded |
08:42 |
|
ashimema |
i can take a look if you like |
08:42 |
|
marcelr |
yes |
08:43 |
|
ashimema |
oop.. kul doesn't start selenium of course.. |
08:43 |
|
severine_q |
question for you wonderful koha folk :) |
08:44 |
|
ashimema |
that would be why all selenium tests are failing for me.. haha |
08:44 |
|
Joubu |
ha but the test should actually fail on master |
08:44 |
|
severine_q |
is there a way usig the batch item modification and regex to duplicate a data in an other field ? |
08:44 |
|
Joubu |
fridolin: Koha_Master not green for the last month?! |
08:44 |
|
Joubu |
great... |
08:44 |
|
ashimema |
yes |
08:45 |
|
Joubu |
7 failing tests, lol |
08:45 |
|
ashimema |
pulling full k-t-d now.. did you already fix misc4dev |
08:45 |
|
Joubu |
waiting for me to fix them I guess... |
08:45 |
|
ashimema |
I started fixing some Joubu |
08:45 |
|
Joubu |
ashimema: nope, but it's only broken for unimarc |
08:45 |
|
ashimema |
but master kept moving |
08:45 |
|
ashimema |
ah cool |
08:45 |
|
ashimema |
so k-t-d should still start for me.. haha |
08:46 |
|
ashimema |
we can split the failing tests if you like.. or I can work through them if your busy with other things |
08:47 |
|
* ashimema |
would really like to see dashboard green again... it's been a rough few days for reds |
08:47 |
|
Joubu |
severine_q: Salut! I don't think it's possible |
08:48 |
|
Joubu |
ashimema: which ones did you fix? |
08:48 |
|
marcelr |
ashimema: did you plan to change status on 28998 too? |
08:48 |
|
ashimema |
I think the current set none.. |
08:49 |
|
ashimema |
as fast as I fixed tests last week we'd push more bugs and new failures would appear |
08:49 |
|
Joubu |
I am on the 2fa selenium failure, almost fix I think |
08:49 |
|
ashimema |
er.. didn't mean to |
08:49 |
|
marcelr |
will add your signoff on the last patch |
08:49 |
|
ashimema |
no.. it's still at signed off |
08:49 |
|
ashimema |
i'm just re-running all the tests marcelr |
08:49 |
|
ashimema |
I attached before I meant to.. I hadn't run the tests yet 😉 |
08:50 |
|
ashimema |
it looks good. but running tests always makes me happier 😉 |
08:50 |
|
marcelr |
good |
08:50 |
|
marcelr |
you need probably follow-up on selenium one |
08:50 |
|
ashimema |
yup |
08:50 |
|
ashimema |
I just grabed the patchset afresh |
08:50 |
|
severine_q |
Hello Joubu ! Damn it... Hard days to come if I need to do all my modification by hand o_O Thanks for answering and sorry to disturb your talk :) |
08:51 |
|
ashimema |
darn.. of course.. k-t-d wont start now because of the missing dep |
08:51 |
|
marcelr |
maybe move all those selenium ones to the end and squash them, ashimema ? |
08:51 |
|
* ashimema |
checks out master to start k-t-d so he can cpan it |
08:51 |
|
ashimema |
yeah.. I reckon that's a good plan |
08:51 |
|
ashimema |
anywho.. leave it with me for now 😜 |
08:51 |
|
marcelr |
i wont touch it now |
08:51 |
|
marcelr |
(anymore) |
08:52 |
|
ashimema |
🙂 |
08:54 |
|
koha-jenkins |
Project Koha_Master_D12 build #132: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_D12/132/ |
08:55 |
|
Joubu |
@later tell fridolin follow-up on 28786 should fix selenium/authentication_2fa.t |
08:55 |
|
huginn |
Joubu: The operation succeeded. |
08:57 |
|
Joubu |
@later tell fridolin IMO you should stop pushing enh until we reach a green state on jenkins |
08:57 |
|
huginn |
Joubu: The operation succeeded. |
08:58 |
|
marcelr |
Joubu you are riding in the wheels of ashimema now |
08:58 |
|
marcelr |
He is working on that test on the followup |
08:59 |
|
marcelr |
we are overriding each other's changes |
08:59 |
|
ashimema |
actually.. right now I'm not |
08:59 |
|
marcelr |
ok |
08:59 |
|
ashimema |
right now I just spotted that 't/db_dependent/Koha/Patron.t' is failing |
08:59 |
|
Joubu |
no, I told him here that I was working on it |
08:59 |
|
ashimema |
so I'm on that one |
08:59 |
|
Joubu |
and master is broken, follow-up attached on the correct bug |
08:59 |
|
marcelr |
great |
08:59 |
|
Joubu |
I am on selenium/patrons_search.t |
08:59 |
|
ashimema |
brill |
08:59 |
|
ashimema |
we're not clashing 🙂 |
09:00 |
|
marcelr |
no clash on the crash |
09:02 |
|
fridolin |
Joubu: oki seen your messages |
09:02 |
|
fridolin |
some jobs are now green |
09:02 |
|
fridolin |
i'll dig that tomorrow |
09:02 |
|
|
fridolin left #koha |
09:03 |
|
marcelr |
mañana is a good day for digging |
09:06 |
|
ashimema |
this encryption stuff.. did we deliberately stick to the default, now defunct, passphrase-based key derivation function |
09:07 |
|
ashimema |
i.e. -pbkdf defaulting to 'opensslv1' which is default but recommended against? |
09:07 |
|
ashimema |
Joubu, marcelr, can you see any reason I shouldn't increase this to the now common pbkdf2 (as supported since OpenSSL v1.1.1) |
09:09 |
|
marcelr |
good question |
09:09 |
|
marcelr |
sounds good |
09:09 |
|
* ashimema |
spotted the warnings spat out from the module |
09:10 |
|
marcelr |
do we need to check deps and versions etc ? for older distros? |
09:10 |
|
koha-jenkins |
Yippee, build fixed! |
09:10 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #873: FIXED in 1 hr 4 min: https://jenkins.koha-community[…]1_MDB_Latest/873/ |
09:10 |
|
wahanui |
Congratulations! |
09:10 |
|
ashimema |
>2.35 Sun Jan 31 22:02:42 EST 2021 |
09:10 |
|
ashimema |
- Add support for PBKDF2 key derivation algorithm |
09:10 |
|
ashimema |
- New dependencies: Digest::SHA, Crypt::PBKDF2, Crypt::Cipher::AES |
09:10 |
|
ashimema |
so looks like to use the now recommended derivation algorithm you need 2.35 and those other dependancies |
09:11 |
|
koha-jenkins |
Project Koha_Master_D10 build #610: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]a_Master_D10/610/ |
09:12 |
|
ashimema |
dang.. 2.33 is all that's packaged for debian in general |
09:12 |
|
ashimema |
so perhaps we just stick to the old derivation for now. |
09:14 |
|
marcelr |
too bad |
09:16 |
|
koha-jenkins |
Yippee, build fixed! |
09:16 |
|
koha-jenkins |
Project Koha_Master_D10 build #611: FIXED in 53 min: https://jenkins.koha-community[…]a_Master_D10/611/ |
09:16 |
|
wahanui |
Congratulations! |
09:18 |
|
Joubu |
kidclamp: around? |
09:30 |
|
Joubu |
kidclamp: nevermind |
09:43 |
|
Joubu |
@later tell fridolin bug 30595 to fix update_child_to_adult.t |
09:43 |
|
huginn |
Joubu: The operation succeeded. |
09:51 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #874: UNSTABLE in 41 min: https://jenkins.koha-community[…]1_MDB_Latest/874/ |
09:58 |
|
Joubu |
@later tell tcohen bug 30596 please? |
09:58 |
|
huginn |
Joubu: The operation succeeded. |
10:02 |
|
Joubu |
@later tell fridolin don't forget to run the QA script before your pushes! |
10:02 |
|
huginn |
Joubu: The operation succeeded. |
10:03 |
|
Joubu |
@later tell fridolin and another follow-up on 30373 |
10:03 |
|
huginn |
Joubu: The operation succeeded. |
10:03 |
|
Joubu |
@later tell fridolin t/db_dependent/Koha/Pseudonymization.t failure can be ignored for now |
10:03 |
|
huginn |
Joubu: The operation succeeded. |
10:07 |
|
* ashimema |
grabs tea before running tests against his next bug |
10:18 |
|
koha-jenkins |
Project Koha_Master build #1992: STILL UNSTABLE in 1 hr 7 min: https://jenkins.koha-community[…]Koha_Master/1992/ |
10:25 |
|
ashimema |
did I just imagine severine_q said something |
10:25 |
|
ashimema |
think my irc client is playing up |
10:25 |
|
koha-jenkins |
Project Koha_Master_U20 build #373: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_U20/373/ |
10:26 |
|
oleonard |
o/ |
10:27 |
|
ashimema |
yowsers.. the notification came hours later and out of order.. |
10:28 |
|
ashimema |
my client notified me just now about her appearance 3hours ago1 |
10:28 |
|
ashimema |
morning oleonard |
10:44 |
|
koha-jenkins |
Project Koha_Master_U22 build #27: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]ha_Master_U22/27/ |
11:01 |
|
oleonard |
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Incorrect datetime value: '1970-01-01 00:00:00' for column `koha_kohadev`.`borrowers`.`updated_on` at row 4739 at /kohadevbox/koha/C4/Installer.pm line 738 |
11:01 |
|
oleonard |
error from updatedatabase ^^ |
11:01 |
|
ashimema |
ooh.. |
11:01 |
|
ashimema |
how did that get into your database |
11:03 |
|
oleonard |
It isn't |
11:03 |
|
ashimema |
oh.. |
11:03 |
|
ashimema |
that's even more weird |
11:04 |
|
severine_q |
I didn't 'said' but 'asked ashimema :) |
11:07 |
|
tcohen |
hola #koha, happy friday |
11:08 |
|
ashimema |
hehe |
11:09 |
|
ashimema |
it's really annoying having to reset data after running a selenium test |
11:09 |
|
ashimema |
I've got so used to rollbacks |
11:10 |
|
ashimema |
oh.. it's just when the tests fail |
11:10 |
|
ashimema |
I see |
11:20 |
|
ashimema |
time for a walk.. I'm either imagining things or TT split doesn't work when there's only one thing in the string and no separator.. |
11:20 |
|
Joubu |
ashimema: yes, only when the tests fail, and yes it's very annoying |
11:21 |
|
ashimema |
oh really |
11:21 |
|
ashimema |
so it is a bug in TT? |
11:21 |
|
ashimema |
ah no.. |
11:21 |
|
ashimema |
sorry.. misread |
11:21 |
|
oleonard |
Ah, some unusual dateenrolled values in borrowers... 1199-06-12, 1200-09-29, 1200-09-30, 1200-12-11 |
11:22 |
|
oleonard |
Some patrons just LOVE the illuminated manuscript section |
11:34 |
|
oleonard |
Fixing those doesn't fix my error though... |
11:35 |
|
Joubu |
which db rev? |
11:35 |
|
oleonard |
"Fix definition of borrowers.updated_on and deletedborrowers.updated_on" |
11:36 |
|
Joubu |
are you testing 27253? |
11:37 |
|
Joubu |
ha, it's pushed |
11:37 |
|
Joubu |
@later tell fridolin 27253 pushed but status is not updated |
11:37 |
|
huginn |
Joubu: The operation succeeded. |
11:42 |
|
Joubu |
oleonard: I let a comment on the bug |
11:42 |
|
Joubu |
oleonard: can you post your error as well? |
11:43 |
|
oleonard |
Yes |
11:44 |
|
Joubu |
select borrowernumber from borrowers where updated_on is null and date_renewed is null and dateenrolled is null and lastseen is null; |
11:44 |
|
Joubu |
oleonard: can you confirm this query returns something? |
11:46 |
|
oleonard |
Returns 3 rows |
11:47 |
|
Joubu |
if you want to workaround it you can set lastseen=FROM_UNIXTIME(1) for those 3 patrons, then run again updatedatabase |
11:49 |
|
oleonard |
Thanks |
11:59 |
|
Joubu |
is the patron search broken again? |
12:01 |
|
Joubu |
ha oops, the 0000 date in DB breaks the API response |
12:41 |
|
Joubu |
oleonard: I am about to PQA 30224 but I would like you to have a look at it to make sure I am not missing something, do you have a couple of min? |
12:41 |
|
oleonard |
Yes. |
12:42 |
|
kidclamp |
how do I get koha testing docker to launch with GoogleAuth? |
12:42 |
|
Joubu |
kidclamp: pull the latest ktd images |
12:42 |
|
kidclamp |
I did, or so I thought |
12:43 |
|
Joubu |
try again :D |
12:43 |
|
Joubu |
harder |
12:43 |
|
kidclamp |
docker-compse pull --hard |
12:43 |
|
oleonard |
ouch |
12:43 |
|
Joubu |
Is KOHA_IMAGE=master? |
12:44 |
|
kidclamp |
explicity, but the pull that didn't do stuff last time, did this time |
12:44 |
|
kidclamp |
indded, I needed to try 'harder' |
12:44 |
|
kidclamp |
computers-- |
12:44 |
|
Joubu |
:) |
12:54 |
|
oleonard |
Joubu: I cannot reproduce the problem described in Bug 30224 |
12:54 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30224 minor, P5 - low, ---, adam.styles, Signed Off , Wrong important field shown in cataloguing validation |
12:55 |
|
koha-jenkins |
Yippee, build fixed! |
12:55 |
|
koha-jenkins |
Project Koha_Master_D9 build #1936: FIXED in 40 min: https://jenkins.koha-community[…]a_Master_D9/1936/ |
12:55 |
|
wahanui |
Congratulations! |
12:55 |
|
* ashimema |
is back |
12:59 |
|
koha-jenkins |
Project Koha_Master_D10 build #612: SUCCESS in 45 min: https://jenkins.koha-community[…]a_Master_D10/612/ |
12:59 |
|
oleonard |
Joubu: Were you able to reproduce? |
13:00 |
|
|
khall_ joined #koha |
13:01 |
|
Joubu |
oleonard: trying to, I thought I did but cannot longer recreate the problem |
13:01 |
|
|
Dyrcona joined #koha |
13:01 |
|
Joubu |
I bet I only tried with the patch applied |
13:02 |
|
Joubu |
ok I have it |
13:02 |
|
Joubu |
on master, 250 and 260 marked as important |
13:02 |
|
Joubu |
I am seeing: |
13:02 |
|
Joubu |
Field 260 is important, at least one of its subfields must be filled. Field 260 is important, at least one of its subfields must be filled. |
13:02 |
|
Joubu |
twice the same number |
13:03 |
|
Joubu |
with the patch it's ok, I am seeing 250 and 260 |
13:03 |
|
Joubu |
the "go to" link is correct however, hence the confusion |
13:03 |
|
Joubu |
so yes, the patch totally makes sense |
13:05 |
|
oleonard |
Ah, I was testing wrong. The bug is with tags marked important, not subfields |
13:10 |
|
|
khall joined #koha |
13:12 |
|
Joubu |
nevermind oleonard, I am confident with the patch now. Thanks! |
13:47 |
|
Joubu |
@later tell marcelr did you already try to remove the new warning? |
13:47 |
|
huginn |
Joubu: The operation succeeded. |
13:47 |
|
Joubu |
@later tell marcelr Use of uninitialized value in string eq at /kohadevbox/koha/C4/Context.pm line 784 |
13:47 |
|
huginn |
Joubu: The operation succeeded. |
14:17 |
|
alohabot |
🎠🵠Koha '21.05.x' packages pushed to 'koha-staging' repo 🥟🥨🉠|
14:23 |
|
koha-jenkins |
Project Koha_21.05_U20 build #183: UNSTABLE in 39 min: https://jenkins.koha-community[…]ha_21.05_U20/183/ |
14:38 |
|
koha-jenkins |
Project Koha_21.05_D10 build #255: SUCCESS in 53 min: https://jenkins.koha-community[…]ha_21.05_D10/255/ |
14:41 |
|
huginn |
News from kohagit: Bug 28786: Fix 2FA selenium tests <https://git.koha-community.org[…]7f0c0f552f0c21a7b> |
14:53 |
|
oleonard |
I can't seem to receive the *second* issue of a serial. The first one works fine. |
14:55 |
|
koha-jenkins |
Project Koha_21.05_U18 build #174: SUCCESS in 36 min: https://jenkins.koha-community[…]ha_21.05_U18/174/ |
14:57 |
|
koha-jenkins |
Project Koha_21.05_U16 build #184: STILL UNSTABLE in 1 hr 11 min: https://jenkins.koha-community[…]ha_21.05_U16/184/ |
15:05 |
|
koha-jenkins |
Project Koha_21.05_D9 build #180: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_21.05_D9/180/ |
15:15 |
|
alohabot |
🎠🦄 Koha 'master' packages pushed to 'koha-staging' repo 🎂ðŸ¦ðŸŒ® |
15:22 |
|
reiveune |
bye |
15:22 |
|
oleonard-away |
Anyone around who works with serials? |
15:22 |
|
|
reiveune left #koha |
15:29 |
|
alohabot |
🎠🦠Koha '21.05.x' packages pushed to 'koha-staging' repo ðŸ”ðŸ’🌠|
15:35 |
|
koha-jenkins |
Project Koha_21.05_D12 build #109: SUCCESS in 57 min: https://jenkins.koha-community[…]ha_21.05_D12/109/ |
15:40 |
|
koha-jenkins |
Project Koha_21.05_D11 build #207: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]ha_21.05_D11/207/ |
15:48 |
|
koha-jenkins |
Project Koha_Master_U20 build #374: STILL UNSTABLE in 43 min: https://jenkins.koha-community[…]a_Master_U20/374/ |
15:59 |
|
ashimema |
time to call it a day |
15:59 |
|
ashimema |
have a great weekend #koha |
16:06 |
|
koha-jenkins |
Project Koha_21.05_U18 build #175: SUCCESS in 1 hr 9 min: https://jenkins.koha-community[…]ha_21.05_U18/175/ |
16:09 |
|
koha-jenkins |
Project Koha_21.05_D10 build #256: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_21.05_D10/256/ |
16:28 |
|
koha-jenkins |
Yippee, build fixed! |
16:28 |
|
koha-jenkins |
Project Koha_21.05_U20 build #184: FIXED in 39 min: https://jenkins.koha-community[…]ha_21.05_U20/184/ |
16:28 |
|
wahanui |
Congratulations! |
16:38 |
|
koha-jenkins |
Project Koha_Master_D12 build #133: STILL UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]a_Master_D12/133/ |
17:14 |
|
koha-jenkins |
Project Koha_Master_Sid build #21: SUCCESS in 46 min: https://jenkins.koha-community[…]ha_Master_Sid/21/ |
17:17 |
|
koha-jenkins |
Project Koha_21.05_U16 build #185: STILL UNSTABLE in 1 hr 11 min: https://jenkins.koha-community[…]ha_21.05_U16/185/ |
17:21 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #804: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]ster_D11_My8/804/ |
17:26 |
|
koha-jenkins |
Project Koha_Master_U21 build #157: SUCCESS in 55 min: https://jenkins.koha-community[…]a_Master_U21/157/ |
17:41 |
|
koha-jenkins |
Project Koha_Master_U22 build #28: UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]ha_Master_U22/28/ |
17:44 |
|
oleonard |
Serials always makes my brain hurt |
17:58 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #875: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]1_MDB_Latest/875/ |
18:01 |
|
koha-jenkins |
Project Koha_Master_D9 build #1937: SUCCESS in 46 min: https://jenkins.koha-community[…]a_Master_D9/1937/ |
18:10 |
|
koha-jenkins |
Project Koha_Master_D10 build #613: SUCCESS in 53 min: https://jenkins.koha-community[…]a_Master_D10/613/ |
18:32 |
|
koha-jenkins |
Project Koha_21.05_U20 build #185: SUCCESS in 34 min: https://jenkins.koha-community[…]ha_21.05_U20/185/ |
18:33 |
|
koha-jenkins |
Project Koha_Master build #1993: STILL UNSTABLE in 1 hr 6 min: https://jenkins.koha-community[…]Koha_Master/1993/ |
18:35 |
|
|
fridolin joined #koha |
18:36 |
|
fridolin |
yelllow |
18:40 |
|
koha-jenkins |
Project Koha_21.05_D9 build #181: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_D9/181/ |
18:43 |
|
* fridolin |
shaking jenkins branches to get green fruits ;) |
19:03 |
|
koha-jenkins |
Project Koha_Master_D10 build #614: SUCCESS in 52 min: https://jenkins.koha-community[…]a_Master_D10/614/ |
19:09 |
|
koha-jenkins |
Project Koha_Master_U21 build #158: SUCCESS in 36 min: https://jenkins.koha-community[…]a_Master_U21/158/ |
19:15 |
|
alohabot |
🎠🸠Koha '21.11.x' packages pushed to 'koha-staging' repo 🌯ðŸ™ðŸ¡ |
19:27 |
|
koha-jenkins |
Project Koha_21.11_D12 build #56: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_21.11_D12/56/ |
19:39 |
|
koha-jenkins |
Yippee, build fixed! |
19:39 |
|
koha-jenkins |
Project Koha_21.11_D11 build #87: FIXED in 1 hr 6 min: https://jenkins.koha-community[…]oha_21.11_D11/87/ |
19:39 |
|
wahanui |
Congratulations! |
19:41 |
|
koha-jenkins |
Project Koha_21.11_D9 build #59: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]Koha_21.11_D9/59/ |
19:44 |
|
koha-jenkins |
Project Koha_21.11_U21 build #59: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_21.11_U21/59/ |
19:54 |
|
koha-jenkins |
Project Koha_21.11_U20 build #65: UNSTABLE in 50 min: https://jenkins.koha-community[…]oha_21.11_U20/65/ |
20:11 |
|
koha-jenkins |
Yippee, build fixed! |
20:11 |
|
koha-jenkins |
Project Koha_21.11_U22 build #2: FIXED in 43 min: https://jenkins.koha-community[…]Koha_21.11_U22/2/ |
20:11 |
|
wahanui |
Congratulations! |
20:16 |
|
huginn |
News from kohagit: Revert "Bug 30373: (follow-up) Fix license" <https://git.koha-community.org[…]9caf9b0893f0dad15> |
20:16 |
|
huginn |
News from kohagit: Bug 30373: Fix xt/find-license-problems.t <https://git.koha-community.org[…]704fafe75673c1019> |
20:16 |
|
huginn |
News from kohagit: Bug 30595: Prevent update_child_to_adult.t to fail randomly <https://git.koha-community.org[…]68ee83a9654e5cfaa> |
20:16 |
|
huginn |
News from kohagit: Bug 30373: Fix unimarc authorised values <https://git.koha-community.org[…]fa198f1369cbce779> |
20:36 |
|
koha-jenkins |
Project Koha_21.11_U18 build #71: SUCCESS in 57 min: https://jenkins.koha-community[…]oha_21.11_U18/71/ |
20:37 |
|
koha-jenkins |
Project Koha_21.11_D10 build #80: SUCCESS in 56 min: https://jenkins.koha-community[…]oha_21.11_D10/80/ |
20:55 |
|
koha-jenkins |
Yippee, build fixed! |
20:55 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #876: FIXED in 44 min: https://jenkins.koha-community[…]1_MDB_Latest/876/ |
20:55 |
|
wahanui |
Congratulations! |
21:00 |
|
koha-jenkins |
Project Koha_Master_D10 build #615: UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_D10/615/ |
21:14 |
|
alohabot |
🎠🦄 Koha 'master' packages pushed to 'koha-staging' repo ðŸžðŸ¯ðŸ› |
21:21 |
|
koha-jenkins |
Yippee, build fixed! |
21:21 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #805: FIXED in 37 min: https://jenkins.koha-community[…]ster_D11_My8/805/ |
21:21 |
|
wahanui |
Congratulations! |
21:34 |
|
koha-jenkins |
Project Koha_Master_Sid build #22: UNSTABLE in 57 min: https://jenkins.koha-community[…]ha_Master_Sid/22/ |
21:41 |
|
koha-jenkins |
Project Koha_Master_U22 build #29: STILL UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]ha_Master_U22/29/ |
21:41 |
|
koha-jenkins |
Project Koha_Master_U21 build #159: SUCCESS in 46 min: https://jenkins.koha-community[…]a_Master_U21/159/ |
21:59 |
|
koha-jenkins |
Project Koha_Master_U20 build #375: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_U20/375/ |
22:20 |
|
koha-jenkins |
Project Koha_Master_D9 build #1938: SUCCESS in 1 hr 20 min: https://jenkins.koha-community[…]a_Master_D9/1938/ |
22:24 |
|
wizzyrea |
? |
22:28 |
|
koha-jenkins |
Yippee, build fixed! |
22:28 |
|
koha-jenkins |
Project Koha_Master_D12 build #134: FIXED in 46 min: https://jenkins.koha-community[…]a_Master_D12/134/ |
22:28 |
|
wahanui |
Congratulations! |
22:36 |
|
koha-jenkins |
Yippee, build fixed! |
22:36 |
|
koha-jenkins |
Project Koha_Master_Sid build #23: FIXED in 37 min: https://jenkins.koha-community[…]ha_Master_Sid/23/ |
22:36 |
|
wahanui |
Congratulations! |
22:40 |
|
koha-jenkins |
Project Koha_21.11_U22 build #3: SUCCESS in 59 min: https://jenkins.koha-community[…]Koha_21.11_U22/3/ |
22:44 |
|
koha-jenkins |
Yippee, build fixed! |
22:44 |
|
koha-jenkins |
Project Koha_Master_D10 build #616: FIXED in 1 hr 10 min: https://jenkins.koha-community[…]a_Master_D10/616/ |
22:44 |
|
wahanui |
Congratulations! |
23:51 |
|
koha-jenkins |
Project Koha_Master build #1994: STILL UNSTABLE in 1 hr 7 min: https://jenkins.koha-community[…]Koha_Master/1994/ |