| Time |
S |
Nick |
Message |
| 00:37 |
|
|
dcook joined #koha |
| 00:54 |
|
huginn |
News from kohagit: Bug 29277: Compiled CSS <https://git.koha-community.org[…]87faf6e17116820ac> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history <https://git.koha-community.org[…]7a27935d23fa04807> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29832: Use KohaTable <https://git.koha-community.org[…]8dad6de0611d9bb93> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page <https://git.koha-community.org[…]304b2f750e4fe51dc> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29525: Make Koha::Hold->fill anonymize if required <https://git.koha-community.org[…]cdbbc8d8fe8c287e1> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve <https://git.koha-community.org[…]3694471f0341a64fc> |
| 00:54 |
|
huginn |
News from kohagit: Bug 7374: Add remote image option for authorized values <https://git.koha-community.org[…]17d46b4e6ab991e14> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29867: (follow-up) Add markup comments <https://git.koha-community.org[…]1c2ab909ec5d6d095> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29867: Reindent authorized values administration template <https://git.koha-community.org[…]dbec21b200ddbe021> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29843: Use in tools/cleanborrowers.pl <https://git.koha-community.org[…]e54557c64e1aac284> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29843: Use in opac/opac-privacy.pl <https://git.koha-community.org[…]ec44c2bcbccbdb9cc> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29843: Use in batch_anonymise.pl <https://git.koha-community.org[…]6c0922205043ffa05> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts <https://git.koha-community.org[…]44a594aca02795e31> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29843: Unit tests <https://git.koha-community.org[…]029acdd3a51fca3d2> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29832: Make library column in desk list sortable <https://git.koha-community.org[…]cc9ce14b291a09c1f> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty <https://git.koha-community.org[…]95e9dc05715d958ee> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29526: (follow-up) Put delete buttons in HTML table <https://git.koha-community.org[…]a360c1027eb4e7006> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29526: Add a way for patrons to delete their hold history <https://git.koha-community.org[…]3585d74a040df6650> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29397: Use kohaSelect for pickup locations <https://git.koha-community.org[…]de6dc738c4024424e> |
| 00:54 |
|
huginn |
News from kohagit: Bug 29397: Add function documentation <https://git.koha-community.org[…]b98ba9df5b11063c5> |
| 01:00 |
|
|
jzairo joined #koha |
| 01:19 |
|
alohabot |
🎠🶠Koha 'master' packages pushed to 'koha-staging' repo |
| 01:28 |
|
koha-jenkins |
Project Koha_Master_D11_CPAN build #529: SUCCESS in 35 min: https://jenkins.koha-community[…]ter_D11_CPAN/529/ |
| 01:30 |
|
|
dpk joined #koha |
| 01:36 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #744: SUCCESS in 43 min: https://jenkins.koha-community[…]ster_D11_My8/744/ |
| 01:45 |
|
koha-jenkins |
Project Koha_Master_U20 build #298: SUCCESS in 51 min: https://jenkins.koha-community[…]a_Master_U20/298/ |
| 01:55 |
|
koha-jenkins |
Project Koha_Master_U21 build #86: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]ha_Master_U21/86/ |
| 02:07 |
|
koha-jenkins |
Project Koha_Master_D9 build #1870: SUCCESS in 38 min: https://jenkins.koha-community[…]a_Master_D9/1870/ |
| 02:08 |
|
koha-jenkins |
Project Koha_Master build #1911: STILL UNSTABLE in 1 hr 14 min: https://jenkins.koha-community[…]Koha_Master/1911/ |
| 02:19 |
|
koha-jenkins |
Project Koha_Master_D10 build #527: SUCCESS in 42 min: https://jenkins.koha-community[…]a_Master_D10/527/ |
| 02:32 |
|
|
bag joined #koha |
| 02:44 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #792: SUCCESS in 37 min: https://jenkins.koha-community[…]1_MDB_Latest/792/ |
| 02:54 |
|
koha-jenkins |
Project Koha_Master_D12 build #73: SUCCESS in 58 min: https://jenkins.koha-community[…]ha_Master_D12/73/ |
| 03:05 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #375: UNSTABLE in 45 min: https://jenkins.koha-community[…]ter_U_Stable/375/ |
| 03:24 |
|
koha-jenkins |
Project Koha_Master_D9 build #1871: UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_D9/1871/ |
| 03:55 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #793: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]1_MDB_Latest/793/ |
| 04:33 |
|
|
bshum_ joined #koha |
| 05:03 |
|
|
logbot joined #koha |
| 05:03 |
|
|
Topic for #koha is now Welcome to #koha this channel is for discussion of the Koha project and software https://koha-community.org |
| 06:04 |
|
|
tuxayo joined #koha |
| 06:05 |
|
|
JBoyer joined #koha |
| 06:14 |
|
|
chriss joined #koha |
| 06:16 |
|
|
ChristerSkogKouvolaKyyti[m] left #koha |
| 06:21 |
|
|
fridolin joined #koha |
| 06:29 |
|
koha-jenkins |
Yippee, build fixed! |
| 06:29 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #147: FIXED in 33 min: https://jenkins.koha-community[…].05_U_Stable/147/ |
| 06:56 |
|
|
thibaud_glt joined #koha |
| 07:14 |
|
|
marion joined #koha |
| 07:30 |
|
|
reiveune joined #koha |
| 07:30 |
|
reiveune |
hello |
| 07:43 |
|
|
alex_a joined #koha |
| 07:43 |
|
alex_a |
Bonjour |
| 07:45 |
|
matts |
hi ! |
| 07:56 |
|
|
cait joined #koha |
| 07:57 |
|
|
sodesvaux joined #koha |
| 07:58 |
|
Joubu |
fridolin: around? |
| 07:59 |
|
Joubu |
You should follow the additional_work bz keyword! |
| 07:59 |
|
Joubu |
There is a follow-up patch on bug 29458 that hasn't been pushed |
| 07:59 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29458 enhancement, P5 - low, ---, m.de.rooy, RESOLVED FIXED, Show login button consistently in relation to login instructions, reset and register links |
| 08:00 |
|
magnuse |
\o/ |
| 08:01 |
|
|
cait1 joined #koha |
| 08:04 |
|
fridolin |
ah sure i"ll look more often |
| 08:06 |
|
|
lds joined #koha |
| 08:07 |
|
|
jajm joined #koha |
| 08:07 |
|
|
Jeremy_b joined #koha |
| 08:09 |
|
|
jajm joined #koha |
| 08:10 |
|
Joubu |
fridolin: you should get notifications from bugz by email as well |
| 08:14 |
|
fridolin |
indeed, i do read them daily |
| 08:14 |
|
|
alex_a joined #koha |
| 08:15 |
|
fridolin |
but i'll run the search with additional_work_needed periodicaly |
| 08:19 |
|
cait1 |
fridolin: you can also see them on hte dashboard I think https://dashboard.koha-community.org/ |
| 08:20 |
|
cait1 |
hm but it appears to be broken, Needs more work should show 1 for bug 29844, shouldn't it? |
| 08:20 |
|
Joubu |
this search is wrong |
| 08:20 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=29844 enhancement, P5 - low, ---, tomascohen, Pushed to master , Remove uses of wantarray in Koha::Objects |
| 08:20 |
|
Joubu |
it does not contain the "pushed to *" |
| 08:21 |
|
cait1 |
hm maybe it should and we just remove the kexword when fixed |
| 08:21 |
|
Joubu |
yes, that's how it is supposed to work |
| 08:22 |
|
Joubu |
actually the keyword is useful for the "pushed to *" statuses, not much of others :) |
| 08:22 |
|
cait1 |
yep |
| 08:23 |
|
cait1 |
another training, bbl |
| 08:23 |
|
fridolin |
ah i will recreate a search |
| 08:23 |
|
Joubu |
There is one already |
| 08:24 |
|
Joubu |
https://bugs.koha-community.or[…]l%20work%20needed |
| 08:24 |
|
Joubu |
This is "mine" I think |
| 08:24 |
|
Joubu |
And it is shared already |
| 08:26 |
|
fridolin |
ah oki this one is correct, cool |
| 08:46 |
|
Joubu |
How bad would it be to remove the "overdues/checkouts" and "fines" columns from the patron search table? |
| 08:47 |
|
Joubu |
We could access the info clicking a "more info" button that would open a popup |
| 08:50 |
|
cait1 |
i think bad |
| 08:51 |
|
cait1 |
people like it, I like it |
| 08:51 |
|
cait1 |
you want to see immediately who has something,... not check by clicking |
| 08:52 |
|
Joubu |
That is complicating everything in the code :-/ |
| 08:53 |
|
cait1 |
you asked... |
| 08:53 |
|
cait1 |
it's always a big hit in training |
| 08:53 |
|
Joubu |
yep |
| 08:53 |
|
Joubu |
ok |
| 08:53 |
|
cait1 |
often asked to be able to sort by it too, which doesn't work right now |
| 09:29 |
|
|
fridolin left #koha |
| 09:31 |
|
|
MarkHofstetter1 joined #koha |
| 09:47 |
|
ashimema |
I can imagine that being challenging to get at via the API's |
| 09:47 |
|
ashimema |
fun |
| 09:48 |
|
* ashimema |
can't remember if we support asking for specific fields via the API.. or whether once you embed something, you get the lot |
| 09:48 |
|
ashimema |
regardless |
| 09:57 |
|
Joubu |
you can get the 'count' with +count |
| 10:01 |
|
|
MarkHofstetter1 joined #koha |
| 10:10 |
|
* cait1 |
waves |
| 10:19 |
|
ashimema |
very true |
| 10:21 |
|
ashimema |
dash |
| 10:22 |
|
ashimema |
thanks for jumping on all the failing tests Joubu.. I just read the mail and was about to start looking when your reply came through to say you'd handled them all 🙂 |
| 10:51 |
|
|
khall_ joined #koha |
| 11:03 |
|
tcohen |
Joubu can't you allow embedding checkouts+count? |
| 11:04 |
|
magnuse |
Joubu++ |
| 11:05 |
|
tcohen |
you need overdue_checkouts |
| 11:05 |
|
tcohen |
Joubu++ # always |
| 11:06 |
|
* ashimema |
is currently testing Joubu's work to date 🙂 |
| 11:06 |
|
ashimema |
it's nice |
| 11:06 |
|
* ashimema |
compares side by side now |
| 11:08 |
|
tcohen |
ashimema++ |
| 11:08 |
|
tcohen |
cait++ |
| 11:08 |
|
tcohen |
fridolin++ |
| 11:08 |
|
tcohen |
khall++ |
| 11:08 |
|
ashimema |
tcohen++ |
| 11:08 |
|
tcohen |
kidclamp++ |
| 11:09 |
|
tcohen |
tuxayo++ |
| 11:09 |
|
tcohen |
andrewfh++ |
| 11:14 |
|
|
oleonard joined #koha |
| 11:14 |
|
ashimema |
hmm, getting 404's on the API |
| 11:14 |
|
ashimema |
fun times.. wonder what I've got screwed up on my system now |
| 11:15 |
|
ashimema |
there's some seriously interesting queries going on here. |
| 11:16 |
|
ashimema |
silly question.. why do we stick to query params in the datatables wrapper rather than putting the search in the request body? |
| 11:16 |
|
ashimema |
Joubu, tcohen? |
| 11:16 |
|
ashimema |
makes for some pretty impressive URI's |
| 11:17 |
|
tcohen |
I added the header_filter for that option |
| 11:17 |
|
tcohen |
as far as I can tell, browsers forbid request body on GET |
| 11:17 |
|
tcohen |
for ajax at least |
| 11:18 |
|
ashimema |
that's as good a reason as any |
| 11:18 |
|
ashimema |
lol |
| 11:18 |
|
ashimema |
I knew I'd asked that question before and felt just as stupid when you told me the answer last time : |
| 11:18 |
|
tcohen |
using the header is a nice alternative |
| 11:18 |
|
tcohen |
I think parcel.tt does that |
| 11:18 |
|
ashimema |
indeed.. we support header, query or body |
| 11:19 |
|
ashimema |
>?_page=1&_per_page=20&q=%7B%22-and%22%3A%5B%7B%7D%2C%5B%5B%7B%22me.cardnumber%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%5D%2C%5B%7B%22me.firstname%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.surname%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%5D%2C%5B%7B%22me.category_id%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%5D%2C%5B%7B%22me.library_id%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%5D%2C%5B%7B%22me.date_of_birth%22%3A%7B%22l |
| 11:19 |
|
ashimema |
ike%22%3A%22%25david%25%22%7D%7D%5D%2C%5B%7B%22me.street_number%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.address%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.address2%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.city%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.state%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.postal_code%22%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%2C%7B%22me.country%22 |
| 11:19 |
|
ashimema |
%3A%7B%22like%22%3A%22%25david%25%22%7D%7D%5D%5D%5D%7D&_match=contains&_order_by=%2Bme.firstname%2C%2Bme.surname |
| 11:19 |
|
ashimema |
that's one funky query.. of course, chrome inspector does output it way more nicely if you look at payload.. |
| 11:19 |
|
ashimema |
but I do sometimes wonder about all the escaping |
| 11:20 |
|
tcohen |
https://git.koha-community.org[…]ui/parcel.tt#L384 |
| 11:20 |
|
tcohen |
it is as easy as that |
| 11:20 |
|
ashimema |
Joubu, was it a deliberate choice to add the filter bar at the top of the datatable in your patchset.. that's a change of functionality as far as I can tell |
| 11:20 |
|
* ashimema |
is looking at guaruntor searches as his starting point. |
| 11:20 |
|
ashimema |
ha, nice |
| 11:21 |
|
|
khall joined #koha |
| 11:21 |
|
ashimema |
oh wow.. so our wrapper already supports it.. we just default to query param |
| 11:21 |
|
ashimema |
interesting. |
| 11:25 |
|
tcohen |
power hasn't come back... battery is about to pass |
| 11:25 |
|
ashimema |
oh noes |
| 11:27 |
|
oleonard |
tcohen: Write code by candlelight and mail us the result. We'll make the patches. |
| 11:28 |
|
tcohen |
hahaha |
| 11:28 |
|
* tcohen |
remembers an exam with 2 pages of handwritten assembler... |
| 11:29 |
|
oleonard |
Yikes |
| 11:29 |
|
* tcohen |
blames bgkriegel, a.k.a. the teacher |
| 11:29 |
|
ashimema |
yowsers |
| 11:29 |
|
* ashimema |
has never written assembler |
| 11:29 |
|
* ashimema |
has never had any formal coding education come to think of it |
| 11:30 |
|
tcohen |
in one of my jobs (a POS device for charging bus RFID cards) |
| 11:30 |
|
* ashimema |
is a scientist by education, physicist to be exact |
| 11:30 |
|
tcohen |
I recall we had a weird error... that ended up being a compiler bug... so I had to find it in the generated assembler |
| 11:31 |
|
ashimema |
yikes |
| 11:31 |
|
ashimema |
I wouldn't even know where to start with that |
| 11:31 |
|
tcohen |
it was an inexpensive Motorola microcontroller |
| 11:31 |
|
ashimema |
tcohen, do you think we should start pushing harder for jsdoc updates the way we try to push for POD updates? |
| 11:32 |
|
tcohen |
and the company didn't pay for the updated toolkit |
| 11:32 |
|
tcohen |
ashimema yes! |
| 11:32 |
|
ashimema |
Joubu adds some extra stuff to the 'default_filters' option of the kohaTable wrapper.. I think we should document the extra signature options |
| 11:32 |
|
ashimema |
brill |
| 11:34 |
|
Joubu |
ashimema: yes, I wanted the filter at the top of each colum |
| 11:35 |
|
Joubu |
please don't provide too many follow-ups, the stack is continuing to grow ;) |
| 11:36 |
|
Joubu |
I have started to remove the C4::Utils::DT::Members and so the general patron search |
| 11:47 |
|
ashimema |
no worries |
| 11:47 |
|
ashimema |
I shan't add follow-up in here.. just comments to make sure we're all on the same page whilst I test.. |
| 11:47 |
|
ashimema |
we can do any further refinements down the line as distinct bugs |
| 11:58 |
|
koha-jenkins |
Project Koha_21.11_U20 build #27: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_21.11_U20/27/ |
| 12:03 |
|
koha-jenkins |
Project Koha_21.11_D9 build #27: SUCCESS in 43 min: https://jenkins.koha-community[…]Koha_21.11_D9/27/ |
| 12:04 |
|
koha-jenkins |
Project Koha_21.11_D11 build #42: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]oha_21.11_D11/42/ |
| 12:05 |
|
Joubu |
Do we already have a format_prices JS function? |
| 12:07 |
|
ashimema |
Joubu, looks like 'acquisitions_baskets.yaml' is missing from the patchset |
| 12:07 |
|
Joubu |
yes |
| 12:07 |
|
Joubu |
koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc: Number.prototype.format_price = function( value, params ) { |
| 12:07 |
|
Joubu |
lol I wrote that |
| 12:08 |
|
Joubu |
2014 whaou |
| 12:08 |
|
ashimema |
yup |
| 12:09 |
|
ashimema |
yup |
| 12:09 |
|
ashimema |
looks like you missed the file in 'Bug 30055: Use /acquisitions/baskets/managers for basket's manager' |
| 12:09 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30055 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rewrite some of the patron searches to make them use the REST API routes |
| 12:09 |
|
ashimema |
🙂 |
| 12:09 |
|
ashimema |
bet it's lying around in uncommmited files |
| 12:11 |
|
Joubu |
ashimema: oops, attached now! |
| 12:11 |
|
ashimema |
nice one |
| 12:14 |
|
ashimema |
hmm |
| 12:14 |
|
ashimema |
now I'm seeing |
| 12:14 |
|
ashimema |
GET /api/v1/patrons: unhandled exception (DBIx::Class::Exception)<<SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: Supplying an empty left hand side argument is not supported in array-pairs at /usr/share/perl5/Data/Page.pm |
| 12:15 |
|
ashimema |
on a gauruntors search |
| 12:15 |
|
Joubu |
didn't see that one |
| 12:17 |
|
alohabot |
🎠🷠Koha '21.11.x' packages pushed to 'koha-staging' repo |
| 12:18 |
|
Joubu |
ashimema: retried and found something I didn't attach to this bug, but it's not related |
| 12:18 |
|
Joubu |
it's attached now but it's related to a JS error |
| 12:19 |
|
Joubu |
ashimema: did you specify a search? |
| 12:19 |
|
ashimema |
I did.. |
| 12:20 |
|
Joubu |
how do I recreate? :) |
| 12:20 |
|
ashimema |
so far I've only tried searching to add a guarantor |
| 12:21 |
|
ashimema |
so new user, 'Add guarantor' |
| 12:21 |
|
ashimema |
all searches cause he failure for me |
| 12:23 |
|
Joubu |
hum weird, I don't recreate |
| 12:23 |
|
Joubu |
did you regenerate the dbic schema? |
| 12:23 |
|
Joubu |
there is a new PK somewhere |
| 12:23 |
|
koha-jenkins |
Project Koha_21.11_U_Stable build #33: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]1.11_U_Stable/33/ |
| 12:24 |
|
* ashimema |
tries that.. think I did, but no harm doing it again |
| 12:24 |
|
Joubu |
did you check the JS console? |
| 12:24 |
|
ashimema |
yup.. just the 500 error |
| 12:25 |
|
Joubu |
ashimema: https://paste.koha-community.org/7710 |
| 12:25 |
|
Joubu |
this is what I have on top of master |
| 12:26 |
|
ashimema |
snap |
| 12:27 |
|
ashimema |
right.. refreshed and rebuild schema |
| 12:27 |
|
ashimema |
all working now |
| 12:27 |
|
ashimema |
must have been the schema build I reckon |
| 12:28 |
|
ashimema |
my bad |
| 12:29 |
|
ashimema |
interesting.. there are additional fields in the datatable now.. makes it so I have to horizontal scroll the window |
| 12:30 |
|
|
jzairo joined #koha |
| 12:32 |
|
koha-jenkins |
Project Koha_21.11_D10 build #42: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_21.11_D10/42/ |
| 12:32 |
|
Joubu |
are you on a 800x600 screen? :D |
| 12:32 |
|
ashimema |
nope |
| 12:32 |
|
ashimema |
the popup window is small |
| 12:32 |
|
ashimema |
always has been |
| 12:33 |
|
Joubu |
I have a tiling window manager so it's taking halt the screen, ~950px |
| 12:33 |
|
Joubu |
and all columns are displayed |
| 12:34 |
|
Joubu |
I had to force the display of the categories and libraries as we have the filter at the top |
| 12:34 |
|
Joubu |
s/halt/half |
| 12:34 |
|
ashimema |
i see |
| 12:35 |
|
Joubu |
maybe we could increase the width? |
| 12:37 |
|
ashimema |
wonder how the width was fixed in the first place |
| 12:37 |
|
Joubu |
from the opener window |
| 12:38 |
|
ashimema |
indeed |
| 12:38 |
|
Joubu |
200 var newin = window.open('/cgi-bin/koha/members/search.pl?columns=cardnumber,name,category,branch,dateofbirth,address,action','popup','width=800,height=600,resizable=no,toolbar=false,scrollbars=yes,top' ); |
| 12:38 |
|
Joubu |
from js/member.js |
| 12:38 |
|
Joubu |
from js/members.js |
| 12:38 |
|
ashimema |
of course.. i see them now |
| 12:38 |
|
Joubu |
can you try 900? |
| 12:39 |
|
Joubu |
well, it will depend on the size of the selects anyway |
| 12:39 |
|
ashimema |
i wonder if there was a reason to set it at 600x800 |
| 12:39 |
|
ashimema |
indeed it will |
| 12:39 |
|
* ashimema |
generally find popout windows jarring.. but that's just me |
| 12:39 |
|
Joubu |
10y ago there was a reason, yes ;) |
| 12:40 |
|
ashimema |
lol |
| 12:40 |
|
Joubu |
We can imagine moving it to a modal |
| 12:40 |
|
Joubu |
that would be better in term of ux I think |
| 12:42 |
|
ashimema |
I dunno.. I think I suggested that once before and it got shot down for usability.. people like to be able to move the window out of the way and use it distinctly I think? |
| 12:42 |
|
koha-jenkins |
Project Koha_21.11_U18 build #30: SUCCESS in 1 hr 18 min: https://jenkins.koha-community[…]oha_21.11_U18/30/ |
| 12:42 |
|
ashimema |
size wise.. as 800x600 is SVGA.. should we stick to that line and go for 1024x768 (XGA) |
| 12:43 |
|
Joubu |
oleonard: do you have an opinion on this? |
| 12:43 |
|
oleonard |
Which popup window is this? |
| 12:44 |
|
oleonard |
(I agree that 800x600 is very small now) |
| 12:44 |
|
Joubu |
guarantor search specifically but the question would be for all the popups |
| 12:45 |
|
oleonard |
I remember discussion of putting the Z39.50 search popup into a modal and hearing pushback about that. I'm not sure anyone has talked about this particular interface. |
| 12:45 |
|
ashimema |
1024x768 does the trick |
| 12:46 |
|
oleonard |
I think a modal for this situation would make sense |
| 12:46 |
|
ashimema |
interesting.. date of birth isn't getting populated |
| 12:46 |
|
* ashimema |
checks the console |
| 12:47 |
|
koha-jenkins |
Project Koha_21.11_U21 build #26: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_21.11_U21/26/ |
| 12:48 |
|
Joubu |
working for me, with the age |
| 12:48 |
|
ashimema |
ooh.. the actual results of the search are really different too |
| 12:48 |
|
ashimema |
I did a simple search on 'david' |
| 12:48 |
|
ashimema |
same database |
| 12:48 |
|
Joubu |
that's not expected :D |
| 12:48 |
|
ashimema |
totally different results using the API |
| 12:49 |
|
Joubu |
can you identify the difference? |
| 12:50 |
|
Joubu |
is the number of results different as well? |
| 12:50 |
|
ashimema |
well.. at the moment it appears that the actual filter isn't getting applied at all |
| 12:50 |
|
ashimema |
it gave me back all users |
| 12:50 |
|
ashimema |
3711 results vs 83 |
| 12:50 |
|
* ashimema |
digs |
| 12:50 |
|
|
marion joined #koha |
| 12:51 |
|
Joubu |
ashimema: How it is supposed to work: If you click the search button from the top, it will reuse the 3 filters from the top (general, category, library) but the filters you previously set in the table will be removed |
| 12:52 |
|
Joubu |
then, if you use the filters from the table, and modify the filters from the top, the filters from the top won't be reused until you click the search button |
| 12:52 |
|
Joubu |
About the "first letter", it is the same. It will be "sticky" (and there is no visual feedback about that, we should remove the link from the selected letter) |
| 12:52 |
|
Joubu |
until you click search again |
| 12:53 |
|
ashimema |
first letter? |
| 12:53 |
|
Joubu |
""Browse by last name |
| 12:53 |
|
ashimema |
oh yes |
| 12:54 |
|
ashimema |
I haven't got to test that yet |
| 12:55 |
|
ashimema |
so.. |
| 12:58 |
|
ashimema |
right.. |
| 12:59 |
|
ashimema |
the 'Search' input used to go to 'searchmember' |
| 12:59 |
|
ashimema |
which appeared to do a cardnumber search |
| 12:59 |
|
ashimema |
followed by the DataTables search if nothing matched |
| 13:02 |
|
ashimema |
right.... |
| 13:02 |
|
ashimema |
https://git.koha-community.org[…]s/Members.pm#L116 |
| 13:02 |
|
ashimema |
I think we've dropped that? |
| 13:02 |
|
ashimema |
unless you can point me to where that now happens using the API wrapper? |
| 13:03 |
|
Joubu |
we should still search on all the "default fields" |
| 13:03 |
|
Joubu |
look at the generate q |
| 13:03 |
|
ashimema |
i.e. the query I'm seeing if searching against lots and lots of fields |
| 13:03 |
|
Joubu |
you should see them all |
| 13:04 |
|
Joubu |
230 "data": "me.firstname:me.surname", |
| 13:04 |
|
Joubu |
no you are correct, we are missing some there |
| 13:04 |
|
ashimema |
>[[{"me.cardnumber":{"like":"%david%"}}],[{"me.firstname":{"like":"%david%"}},{"me.surname":{"like":"%david%"}}],[{"me.category_id":{"like":"%david%"}}],[{"me.library_id":{"like":"%david%"}}],[{"me.date_of_birth":{"like":"%david%"}}],[{"me.street_number":{"like":"%david%"}},{"me.address":{"like":"%david%"}},{"me.address2":{"like":"%david%"}},{"me.city":{"like":"%david%"}},{"me.state":{"like":"%david%"}},{"me.postal_code":{"like":"%david%"}},{"me. |
| 13:04 |
|
ashimema |
country":{"like":"%david%"}}],[{"extended_attributes.value":{"like":"%david%"}},{"extended_attributes.code":["ACTIVEC","CAT1","COURSECODE","FACULTY","LOSTCARD","NEWS","SMART","SRC","T_J_PAT","TEST"]}]] |
| 13:04 |
|
Joubu |
well, othernames is missing |
| 13:04 |
|
ashimema |
that's what I see in the new one |
| 13:04 |
|
Joubu |
search.tt |
| 13:04 |
|
Joubu |
230 "data": "me.firstname:me.surname:me:othernames", |
| 13:05 |
|
Joubu |
try that |
| 13:05 |
|
ashimema |
when I only enter 'david' in the Search box |
| 13:07 |
|
ashimema |
makes no different |
| 13:07 |
|
ashimema |
difference. even |
| 13:07 |
|
Joubu |
ashimema: pm |
| 13:07 |
|
ashimema |
but still.. what I'm seeing I think is the opposite.. I have loads more results in the new code.. not less.. |
| 13:10 |
|
koha-jenkins |
Project Koha_21.11_U18 build #31: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_21.11_U18/31/ |
| 13:17 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:17 |
|
koha-jenkins |
Project Koha_21.11_D11 build #43: FIXED in 1 hr 12 min: https://jenkins.koha-community[…]oha_21.11_D11/43/ |
| 13:17 |
|
alohabot |
🎠🵠Koha '21.05.x' packages pushed to 'koha-staging' repo |
| 13:22 |
|
koha-jenkins |
Project Koha_21.11_U20 build #28: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.11_U20/28/ |
| 13:29 |
|
|
Dyrcona joined #koha |
| 13:30 |
|
koha-jenkins |
Project Koha_21.11_D9 build #28: SUCCESS in 42 min: https://jenkins.koha-community[…]Koha_21.11_D9/28/ |
| 13:32 |
|
koha-jenkins |
Project Koha_21.11_D10 build #43: SUCCESS in 50 min: https://jenkins.koha-community[…]oha_21.11_D10/43/ |
| 13:44 |
|
koha-jenkins |
Project Koha_21.11_U_Stable build #34: SUCCESS in 34 min: https://jenkins.koha-community[…]1.11_U_Stable/34/ |
| 14:04 |
|
|
marie-luce joined #koha |
| 14:13 |
|
koha-jenkins |
Project Koha_21.11_U21 build #27: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_21.11_U21/27/ |
| 14:19 |
|
koha-jenkins |
Project Koha_21.11_D10 build #44: SUCCESS in 57 min: https://jenkins.koha-community[…]oha_21.11_D10/44/ |
| 14:23 |
|
koha-jenkins |
Project Koha_21.11_D11 build #44: UNSTABLE in 1 hr 6 min: https://jenkins.koha-community[…]oha_21.11_D11/44/ |
| 14:23 |
|
|
khall_ joined #koha |
| 14:45 |
|
koha-jenkins |
Project Koha_21.05_U18 build #141: SUCCESS in 1 hr 12 min: https://jenkins.koha-community[…]ha_21.05_U18/141/ |
| 14:47 |
|
|
lukeg joined #koha |
| 14:50 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #148: SUCCESS in 33 min: https://jenkins.koha-community[…].05_U_Stable/148/ |
| 14:56 |
|
koha-jenkins |
Project Koha_21.05_U16 build #152: UNSTABLE in 43 min: https://jenkins.koha-community[…]ha_21.05_U16/152/ |
| 14:56 |
|
|
lari joined #koha |
| 15:19 |
|
koha-jenkins |
Project Koha_21.05_D9 build #148: SUCCESS in 59 min: https://jenkins.koha-community[…]oha_21.05_D9/148/ |
| 15:21 |
|
|
caroline joined #koha |
| 15:23 |
|
oleonard |
Grrrr I hate it when git blames ME |
| 15:23 |
|
koha-jenkins |
Project Koha_21.05_D10 build #220: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_21.05_D10/220/ |
| 15:24 |
|
koha-jenkins |
Project Koha_21.05_D11 build #174: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]ha_21.05_D11/174/ |
| 15:31 |
|
oleonard |
Bug 30082 |
| 15:31 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=30082 normal, P5 - low, ---, oleonard, Needs Signoff , Bibliographic details tab missing when user can't add local cover image |
| 15:35 |
|
koha-jenkins |
Project Koha_21.05_U20 build #151: SUCCESS in 49 min: https://jenkins.koha-community[…]ha_21.05_U20/151/ |
| 15:38 |
|
reiveune |
bye |
| 15:38 |
|
|
reiveune left #koha |
| 16:00 |
|
|
bag joined #koha |
| 16:00 |
|
koha-jenkins |
Project Koha_21.05_D9 build #149: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_21.05_D9/149/ |
| 16:16 |
|
alohabot |
🎠🲠Koha '21.05.x' packages pushed to 'koha-staging' repo |
| 16:18 |
|
koha-jenkins |
Yippee, build fixed! |
| 16:18 |
|
koha-jenkins |
Project Koha_21.05_U16 build #153: FIXED in 59 min: https://jenkins.koha-community[…]ha_21.05_U16/153/ |
| 16:23 |
|
|
cait1 left #koha |
| 16:27 |
|
koha-jenkins |
Project Koha_21.05_D11 build #175: UNSTABLE in 1 hr 2 min: https://jenkins.koha-community[…]ha_21.05_D11/175/ |
| 16:37 |
|
koha-jenkins |
Project Koha_21.05_U16 build #154: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_21.05_U16/154/ |
| 16:57 |
|
koha-jenkins |
Project Koha_21.05_U18 build #142: SUCCESS in 1 hr 12 min: https://jenkins.koha-community[…]ha_21.05_U18/142/ |
| 17:04 |
|
koha-jenkins |
Project Koha_21.05_D10 build #221: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D10/221/ |
| 17:11 |
|
|
MarkHofstetter1 joined #koha |
| 17:11 |
|
koha-jenkins |
Project Koha_21.05_U20 build #152: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_21.05_U20/152/ |
| 17:17 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #149: SUCCESS in 58 min: https://jenkins.koha-community[…].05_U_Stable/149/ |
| 17:27 |
|
caroline |
Is there a way on sandboxes to run a script (e.g. fines.pl)? |
| 17:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 17:28 |
|
koha-jenkins |
Project Koha_21.05_D11 build #176: FIXED in 1 hr 0 min: https://jenkins.koha-community[…]ha_21.05_D11/176/ |
| 17:43 |
|
|
MarkHofstetter1 joined #koha |
| 17:46 |
|
koha-jenkins |
Project Koha_21.05_U20 build #153: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U20/153/ |
| 17:50 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #150: SUCCESS in 33 min: https://jenkins.koha-community[…].05_U_Stable/150/ |
| 17:53 |
|
tuxayo |
caroline: I don't think so |
| 18:10 |
|
koha-jenkins |
Project Koha_21.05_D9 build #150: SUCCESS in 1 hr 12 min: https://jenkins.koha-community[…]oha_21.05_D9/150/ |
| 18:14 |
|
|
MarkHofstetter1 joined #koha |
| 18:27 |
|
|
fridolin joined #koha |
| 18:32 |
|
|
MarkHofstetter1 joined #koha |
| 18:37 |
|
oleonard |
Advanced MARC editor broken in master? |
| 18:38 |
|
oleonard |
It tries to call this URL which triggers an error: http://127.0.0.1:8081/cgi-bin/[…]=&callback=define |
| 18:39 |
|
|
domm joined #koha |
| 18:59 |
|
|
lukeg joined #koha |
| 19:00 |
|
koha-jenkins |
Project Koha_21.05_U20 build #154: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U20/154/ |
| 19:07 |
|
koha-jenkins |
Project Koha_21.05_D10 build #222: SUCCESS in 48 min: https://jenkins.koha-community[…]ha_21.05_D10/222/ |
| 19:16 |
|
huginn |
News from kohagit: Bug 29859: Fix currencies display <https://git.koha-community.org[…]c0f26a684f3630cd6> |
| 19:16 |
|
huginn |
News from kohagit: Bug 29859: (follow-up) Use iterator instead of as_list <https://git.koha-community.org[…]27a39c021d3d7aade> |
| 19:16 |
|
huginn |
News from kohagit: Bug 29844: Fix selenium/administration_tasks.t <https://git.koha-community.org[…]ebff9e2188fb0475a> |
| 19:16 |
|
huginn |
News from kohagit: Bug 29779: Fix unit tests count <https://git.koha-community.org[…]b85831b60f3046ce6> |
| 19:16 |
|
huginn |
News from kohagit: Bug 29458: Fix selenium test <https://git.koha-community.org[…]3a14cdf14f036afce> |
| 19:17 |
|
koha-jenkins |
Project Koha_21.05_D9 build #151: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]oha_21.05_D9/151/ |
| 19:17 |
|
alohabot |
🎠🵠Koha '21.05.x' packages pushed to 'koha-staging' repo |
| 19:21 |
|
koha-jenkins |
Project Koha_21.05_D11 build #177: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]ha_21.05_D11/177/ |
| 19:25 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #151: UNSTABLE in 32 min: https://jenkins.koha-community[…].05_U_Stable/151/ |
| 19:42 |
|
koha-jenkins |
Project Koha_21.05_U18 build #143: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_21.05_U18/143/ |
| 19:50 |
|
tcohen |
tuxayo would you consider bug 28932 for 20.11? thanks |
| 19:50 |
|
huginn |
Bug https://bugs.koha-community.or[…]_bug.cgi?id=28932 major, P5 - low, ---, andrew.isherwood, Pushed to oldstable , Backend overriding status_graph element causes duplicate actions |
| 19:58 |
|
koha-jenkins |
Project Koha_21.05_D10 build #223: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_21.05_D10/223/ |
| 20:15 |
|
alohabot |
🎠🹠Koha 'master' packages pushed to 'koha-staging' repo |
| 20:20 |
|
tuxayo |
tcohen: sure :) |
| 20:20 |
|
koha-jenkins |
Project Koha_21.05_U16 build #155: SUCCESS in 1 hr 12 min: https://jenkins.koha-community[…]ha_21.05_U16/155/ |
| 20:22 |
|
koha-jenkins |
Project Koha_21.05_U20 build #155: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_21.05_U20/155/ |
| 20:24 |
|
koha-jenkins |
Project Koha_21.05_D11 build #178: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]ha_21.05_D11/178/ |
| 20:24 |
|
|
lukeg joined #koha |
| 20:32 |
|
koha-jenkins |
Project Koha_Master_D10 build #528: SUCCESS in 34 min: https://jenkins.koha-community[…]a_Master_D10/528/ |
| 20:34 |
|
|
MarkHofstetter1 joined #koha |
| 20:39 |
|
|
lukeg joined #koha |
| 21:05 |
|
koha-jenkins |
Project Koha_Master_D11_MDB_Latest build #794: SUCCESS in 43 min: https://jenkins.koha-community[…]1_MDB_Latest/794/ |
| 21:08 |
|
koha-jenkins |
Project Koha_21.05_D9 build #152: SUCCESS in 36 min: https://jenkins.koha-community[…]oha_21.05_D9/152/ |
| 21:14 |
|
koha-jenkins |
Project Koha_Master_D12 build #74: SUCCESS in 59 min: https://jenkins.koha-community[…]ha_Master_D12/74/ |
| 21:20 |
|
koha-jenkins |
Project Koha_Master_U21 build #87: SUCCESS in 55 min: https://jenkins.koha-community[…]ha_Master_U21/87/ |
| 21:32 |
|
|
SushiJames[m] joined #koha |
| 21:45 |
|
koha-jenkins |
Project Koha_Master_D11_My8 build #745: SUCCESS in 36 min: https://jenkins.koha-community[…]ster_D11_My8/745/ |
| 21:49 |
|
koha-jenkins |
Yippee, build fixed! |
| 21:49 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #376: FIXED in 43 min: https://jenkins.koha-community[…]ter_U_Stable/376/ |
| 22:16 |
|
koha-jenkins |
Project Koha_Master_D11_CPAN build #530: SUCCESS in 56 min: https://jenkins.koha-community[…]ter_D11_CPAN/530/ |
| 22:19 |
|
koha-jenkins |
Yippee, build fixed! |
| 22:19 |
|
koha-jenkins |
Project Koha_Master_D9 build #1872: FIXED in 1 hr 4 min: https://jenkins.koha-community[…]a_Master_D9/1872/ |
| 22:19 |
|
koha-jenkins |
Yippee, build fixed! |
| 22:19 |
|
koha-jenkins |
Project Koha_21.05_U_Stable build #152: FIXED in 34 min: https://jenkins.koha-community[…].05_U_Stable/152/ |
| 22:25 |
|
koha-jenkins |
Project Koha_Master_U20 build #299: SUCCESS in 51 min: https://jenkins.koha-community[…]a_Master_U20/299/ |
| 22:28 |
|
koha-jenkins |
Project Koha_21.05_U20 build #156: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_21.05_U20/156/ |
| 22:54 |
|
koha-jenkins |
Project Koha_Master_U_Stable build #377: SUCCESS in 34 min: https://jenkins.koha-community[…]ter_U_Stable/377/ |
| 23:10 |
|
koha-jenkins |
Project Koha_Master_U20 build #300: SUCCESS in 41 min: https://jenkins.koha-community[…]a_Master_U20/300/ |
| 23:17 |
|
koha-jenkins |
Project Koha_Master_D11_CPAN build #531: SUCCESS in 51 min: https://jenkins.koha-community[…]ter_D11_CPAN/531/ |
| 23:19 |
|
|
MarkHofstetter joined #koha |
| 23:21 |
|
koha-jenkins |
Project Koha_Master_U21 build #88: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]ha_Master_U21/88/ |
| 23:26 |
|
koha-jenkins |
Yippee, build fixed! |
| 23:26 |
|
koha-jenkins |
Project Koha_Master build #1912: FIXED in 1 hr 9 min: https://jenkins.koha-community[…]Koha_Master/1912/ |
