| Time |
S |
Nick |
Message |
| 00:14 |
|
|
inlibro joined #koha |
| 01:15 |
|
|
inlibro joined #koha |
| 01:45 |
|
|
khall joined #koha |
| 02:15 |
|
|
inlibro joined #koha |
| 02:46 |
|
davidnind |
alexbuckley: will retest shortly, nearly finished re-testing the recalls feature |
| 03:15 |
|
|
inlibro joined #koha |
| 04:15 |
|
|
inlibro joined #koha |
| 04:16 |
|
alexbuckley |
thanks davidnind! |
| 04:17 |
|
pastebot |
"davidnind" at 127.0.0.1 pasted "aleisha: test fail and qa output for bug 19532" (424 lines) at http://paste.koha-community.org/26033 |
| 04:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19532 new feature, P1 - high, ---, aleisha, Needs Signoff , Recalls for Koha |
| 05:15 |
|
|
inlibro joined #koha |
| 05:30 |
|
|
josef_moravec joined #koha |
| 05:44 |
|
davidnind |
@later tell alexbuckley success, and bug 25560 now signed off! |
| 05:44 |
|
huginn |
davidnind: The operation succeeded. |
| 06:11 |
|
|
chriss joined #koha |
| 06:15 |
|
|
inlibro joined #koha |
| 06:17 |
|
|
Minski joined #koha |
| 06:52 |
|
|
minski joined #koha |
| 07:02 |
|
|
did joined #koha |
| 07:16 |
|
|
inlibro joined #koha |
| 07:21 |
|
|
fridolin joined #koha |
| 07:22 |
|
|
severine_q joined #koha |
| 07:23 |
|
severine_q |
mornin' #koha ! |
| 07:28 |
|
|
alex_a joined #koha |
| 07:29 |
|
alex_a |
Bonjour |
| 07:32 |
|
|
jonrog joined #koha |
| 07:33 |
|
|
lmstrand joined #koha |
| 07:34 |
|
jonrog |
Does anyone know how to edit the CSS-settings for the overdue notices etc that is exported with gather_print_notices.pl? |
| 07:34 |
|
jonrog |
Is there any "default" css that will be included automatically? |
| 07:35 |
|
ashimema |
just reminding myself how it works jonrog |
| 07:35 |
|
ashimema |
then will try to give you an answer |
| 07:36 |
|
ashimema |
right |
| 07:36 |
|
ashimema |
it's in the NoticeCSS system preference |
| 07:37 |
|
jonrog |
Ahh, thanks ashimema. Is there a default NoticeCSS file if you dont put anything there yourself? |
| 07:37 |
|
ashimema |
and you have a small standard set at the top of the default template too |
| 07:37 |
|
ashimema |
just grabbing a github link for you |
| 07:38 |
|
ashimema |
https://github.com/Koha-Commun[…]/print-notices.tt |
| 07:38 |
|
ashimema |
having said that.. re-reading that it looks like the hard coded set is all commented |
| 07:39 |
|
ashimema |
so it's just what's in the 'stylesheet' variable.. which works back to NoticeCSS preference.. |
| 07:39 |
|
ashimema |
so.. looks like there is nothing by default to me |
| 07:39 |
|
ashimema |
hope that helps.. I need to run now to drop the kids at school |
| 07:39 |
|
jonrog |
Perfect, thanks for your help ashimema ! |
| 07:40 |
|
ashimema |
be back in around an hour. but I'm sure there are others here happy to help too :) |
| 07:48 |
|
magnuse |
that's weird. upgraded to 20.05.05 last night, and now when i try to look at a single patron i get "Template process failed: plugin error - Borrowers: plugin not found at /home/kohaadmin/kohaclone/C4/Templates.pm line 122" |
| 07:50 |
|
magnuse |
it's a gitified install |
| 07:53 |
|
magnuse |
ah, forgot the translation steps |
| 07:54 |
|
minski |
Trying to create sandbox for master, not working. Is there a build error or something? |
| 07:56 |
|
|
lds joined #koha |
| 08:04 |
|
|
cait joined #koha |
| 08:04 |
|
davidnind |
minski: I just spun one up on ByWater Solutions sandboxes, all seems to be working for me |
| 08:04 |
|
davidnind |
maybe delete and start again... |
| 08:05 |
|
davidnind |
or Actions > Renew sandbox |
| 08:05 |
|
davidnind |
you are welcome to use the one I created |
| 08:06 |
|
minski |
davidnind: thanks, i have tried now several times and it won't work. Maybe doing something wrong. I will use yours at this point. |
| 08:10 |
|
davidnind |
no worries, to get master you just leave the bug number empty - I just entered my name, email address, sandbox name (and the "secret" code for the last question) |
| 08:10 |
|
magnuse |
davidnind++ |
| 08:11 |
|
|
cait1 joined #koha |
| 08:12 |
|
Joubu |
minski: are you trying Bywater's or ptfs-e's sandboxes? |
| 08:16 |
|
|
inlibro joined #koha |
| 08:18 |
|
davidnind |
Joubu: minski is using ByWaters' ones - I got one to work, but I didn't manage to get a PTFS-Europe one working |
| 08:18 |
|
cait1 |
davidnind: best to let ashimema know |
| 08:19 |
|
jonrog |
For some reason we're getting font-family monospace when we export notices from Koha 18.11 |
| 08:19 |
|
davidnind |
cait1: I think he had the same issue when he was doing his live coding video the other day |
| 08:20 |
|
ashimema |
PTFS-Europe and Bywater sandboxes both have a random failure at the moment.. sometimes they work sometimes they don't.. I'm trying to pin it down |
| 08:22 |
|
davidnind |
thanks ashimema! (the worst sort of problem...) |
| 08:22 |
|
magnuse |
ugh, had some errors related to issuing rules during the 20.05.05 upgrade last night |
| 08:23 |
|
pastebot |
"magnuse" at 127.0.0.1 pasted "Cannot add or update a child row" (5 lines) at http://paste.koha-community.org/26034 |
| 08:25 |
|
ashimema |
Indeed, it's infuriating. |
| 08:25 |
|
cait1 |
magnuse: did ou see the emails to the mailing listß |
| 08:25 |
|
cait1 |
? |
| 08:26 |
|
ashimema |
Dang.. your bug magnuse .. I think I saw a fix for that go into matter yesterday |
| 08:26 |
|
ashimema |
I'll dig it out once in back from the school run |
| 08:27 |
|
Joubu |
bug 26911: |
| 08:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26911 critical, P5 - low, ---, jonathan.druart, Pushed to master , Update for 18936 can cause data loss if constraints are violated |
| 08:27 |
|
cait1 |
yeah i am looking |
| 08:27 |
|
cait1 |
ah thx Joubu :) |
| 08:27 |
|
magnuse |
cait1: i thought i saw some emails, but have not dug them out yet |
| 08:27 |
|
cait1 |
team_work++ |
| 08:27 |
|
ashimema |
Searching bugzilla on mobile whilst holding the dog isn't optimal |
| 08:27 |
|
cait1 |
could also someone answer Father Vlasie before he tried a downgrade? |
| 08:27 |
|
ashimema |
Year team |
| 08:27 |
|
cait1 |
he just needs to make the biblionumber visible in the frameworks |
| 08:27 |
|
cait1 |
but I am on the wrong computer |
| 08:27 |
|
magnuse |
someone said that i think |
| 08:27 |
|
magnuse |
Joubu++ |
| 08:27 |
|
Joubu |
cait1: I answered few min ago |
| 08:28 |
|
ashimema |
You guys are awesome |
| 08:28 |
|
cait1 |
oh thx! |
| 08:38 |
|
|
bshum joined #koha |
| 08:52 |
|
davidnind |
cait1++ |
| 08:53 |
|
cait1 |
small wins :) |
| 09:16 |
|
|
inlibro joined #koha |
| 09:19 |
|
fridolin |
Bug 26860 is hot ;) |
| 09:19 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26860 enhancement, P5 - low, ---, fridolin.somers, Needs Signoff , Add search limit for records without items |
| 09:21 |
|
magnuse |
shiny! |
| 09:23 |
|
|
Stefan joined #koha |
| 09:25 |
|
fridolin |
magnuse: thanks ;) and if i get candies it can evole again (pokemon) |
| 09:25 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:25 |
|
wahanui |
Congratulations! |
| 09:25 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #434: FIXED in 51 min: https://jenkins.koha-community[…]9_MDB_Latest/434/ |
| 09:26 |
|
Stefan |
This is really a long shot, but I try anyway. Is there anyone here who know how to present the AF field from the SIP2 protocol on a Bibliotecha self service automat? (This isn't really a Koha question, but I can't find an answer anywhere) |
| 09:28 |
|
|
nlegrand joined #koha |
| 09:28 |
|
nlegrand |
boker tov #koha! |
| 09:39 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:39 |
|
wahanui |
Congratulations! |
| 09:39 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #456: FIXED in 1 hr 2 min: https://jenkins.koha-community[…]aster_D9_My8/456/ |
| 09:41 |
|
Joubu |
ashimema: do you know, off the top of your head, what are the commands used by koha-sandboxes-docker to update the template for a new language? |
| 09:41 |
|
Joubu |
ashimema: nevermind, it's not possible! |
| 09:44 |
|
matts |
Stefan, hi. Isn't something that you would have to configure on the automat itself ? |
| 09:51 |
|
|
liliputech_asu joined #koha |
| 09:54 |
|
liliputech_asu |
hi there :) |
| 09:57 |
|
|
stefan joined #koha |
| 09:58 |
|
stefan |
matts one would think that, but now the AF field isn't presented |
| 09:59 |
|
stefan |
I was logged out for a while. hope I didn't miss anyone trying to help me. (can't see the history) |
| 10:01 |
|
matts |
stefan, did you check that Koha returns the AF field as it should ? |
| 10:03 |
|
stefan |
I tried it in the test environment with a "test sip client". haven't been able to try it in production |
| 10:04 |
|
matts |
Well, if Koha returns the AF field and the automat doesn't display it... You'll have to ask the automat's manufacturer why, I guess. |
| 10:04 |
|
magnuse |
sounds reasonable |
| 10:04 |
|
ashimema |
not sure I followed that question Joubu |
| 10:04 |
|
ashimema |
were you trying to install a new language in koha-sandboxes-docker |
| 10:05 |
|
stefan |
matts i guess so. there just so slow. I thought maybe someone here knew if there's some configuration I missed or something, but I guess I have to wait for bibliotecha |
| 10:05 |
|
ashimema |
oooh.. |
| 10:05 |
|
stefan |
there = they are |
| 10:06 |
|
ashimema |
we don't allow selection of a language at install time on the docker sandboxes.. |
| 10:06 |
|
ashimema |
how did I miss that! |
| 10:06 |
|
Joubu |
ashimema: I thought that "actions" had a "update template" for a given language. But it does not |
| 10:06 |
|
ashimema |
I should really add support for that.. |
| 10:06 |
|
ashimema |
well.. once I have the darn sandboxes working again at all! |
| 10:06 |
|
ashimema |
also Joubu.. |
| 10:07 |
|
ashimema |
do you think we should move koha-sandboxes-docker to the community gitlab? |
| 10:07 |
|
ashimema |
it's really just been khall and I maintaining it between us with merge requests going in both directions (with a few from you now) |
| 10:07 |
|
ashimema |
feels like perhaps it's time to have it more in the community domain |
| 10:08 |
|
* ashimema |
is happy to continue working on it of course |
| 10:08 |
|
matts |
stefan, there is no specific configuration in Koha for the AF field that I know of... |
| 10:08 |
|
ashimema |
just makes it more transparent etc |
| 10:08 |
|
stefan |
matts no, I meant in the bibliotech automate config (yes longshot) |
| 10:08 |
|
Joubu |
ashimema: we could. But the github has lot of issues reported |
| 10:08 |
|
Joubu |
we could move them.. |
| 10:08 |
|
ashimema |
yeah |
| 10:09 |
|
ashimema |
I was just reading through teh issues |
| 10:09 |
|
matts |
stefan, yes, I guess you will have to wait for Bibliotheca's answer, unless someone here knows better. |
| 10:09 |
|
ashimema |
I disabled issues on our 'fork' so at least they sohuld all have been reported in one place |
| 10:10 |
|
ashimema |
stick with gitlab/github issues or add a component in bugzilla perhaps? |
| 10:10 |
|
ashimema |
I must admit.. I miss the github issues.. keep forgetting they're there |
| 10:10 |
|
Joubu |
we decided that side-projects should have their own issues tracker |
| 10:10 |
|
|
nlegrand joined #koha |
| 10:11 |
|
ashimema |
so stick with gitlab (if we move to centralise this repo into community gitlab) |
| 10:11 |
|
ashimema |
rather than add to `Project Infrastructure` in bugzilla |
| 10:12 |
|
Joubu |
yes, like all other side-projects ;) |
| 10:16 |
|
|
inlibro joined #koha |
| 10:23 |
|
|
kohaputti joined #koha |
| 10:32 |
|
|
AndroUser joined #koha |
| 10:33 |
|
|
AndroUser left #koha |
| 10:38 |
|
|
davidnind left #koha |
| 10:40 |
|
|
WaylonR joined #koha |
| 10:40 |
|
WaylonR |
Hello all! long time no see. are there any gotcha's with upgrading a koha 17 install to koha 20? |
| 10:44 |
|
Joubu |
yes |
| 10:44 |
|
Joubu |
bug 26911 |
| 10:44 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26911 critical, P5 - low, ---, jonathan.druart, Pushed to master , Update for 18936 can cause data loss if constraints are violated |
| 10:44 |
|
Joubu |
this is not backported into 20.05 yet |
| 10:48 |
|
cait1 |
out of the blue question because we arae a little stuck: how do we enable basicauth for REST? |
| 10:53 |
|
Joubu |
it's a pref |
| 10:53 |
|
cait1 |
RESTBasicAuth system preference, not mentioned int he test plans for the feature |
| 10:53 |
|
cait1 |
people please... if we expect anyone outside of Koha to use these some basic docs on the authentication would be really nice :( |
| 10:55 |
|
cait1 |
Joubu just pointed out: https://wiki.koha-community.or[…]the_Koha_REST_API |
| 10:55 |
|
cait1 |
i am going to add some links in the wiki |
| 11:01 |
|
cait1 |
done - thx Joubu and sorry people - been a long week |
| 11:01 |
|
magnuse |
yeah, more examples would be awesome! |
| 11:16 |
|
|
khall joined #koha |
| 11:16 |
|
|
inlibro joined #koha |
| 11:28 |
|
|
oleonard joined #koha |
| 11:39 |
|
|
khall joined #koha |
| 11:41 |
|
oleonard |
Hi #koha |
| 11:47 |
|
tuxayo |
hi o/ |
| 11:52 |
|
kohaputti |
Joubu, did you test the emails by any chance with non-ascii chars, like ä ? |
| 11:53 |
|
kohaputti |
Joubu, I'm guessing the double encoding issue might not happen then because the MIME encoding might not come into play |
| 11:53 |
|
Joubu |
of course |
| 11:54 |
|
Joubu |
always testing anything with "â¤" |
| 11:54 |
|
kohaputti |
Joubu, there was some follow-ups for other notices to remove the double encoding I think, so maybe you tested those? |
| 11:54 |
|
Joubu |
yes |
| 11:54 |
|
|
magnuse joined #koha |
| 11:55 |
|
Joubu |
my concern is that maybe your patch is breaking the ones we fixed earlier |
| 11:55 |
|
kohaputti |
would be great to have tests for this but I have to solve some more bugs in master (we use it in prod :D) |
| 11:55 |
|
ashimema |
is this your 'SLIP' vs 'Email' utf8 encoding issues kohaputti |
| 11:55 |
|
Joubu |
(as you are fixing things at low level in _send_by_email) |
| 11:55 |
|
ashimema |
that was next on my list to try and understand :) |
| 11:56 |
|
Joubu |
lol, crazy people |
| 12:02 |
|
kohaputti |
Would love to talk more about using master in prod at another time (it's actually pretty great). Regarding the double encoding thing it might also be that the subject needs exceed certain length for the MIME encoding to come into play and cause issues (if you follow the test plan and don't notice difference this might be it) |
| 12:05 |
|
kohaputti |
ashimema, bug 22343 |
| 12:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22343 new feature, P5 - low, ---, tomascohen, Pushed to master , Add configuration options for SMTP servers |
| 12:05 |
|
ashimema |
brave |
| 12:08 |
|
ashimema |
am I reading this right.. |
| 12:08 |
|
tcohen |
ok, does someone have a friday playlist? |
| 12:09 |
|
ashimema |
it's the encoding in the DB and thus the display in the client that's incorrect at the moment.. email stuffer then corrects it on send.. |
| 12:09 |
|
ashimema |
so you're change is to encode it properly earlier and then drop the email stuffer side |
| 12:09 |
|
ashimema |
me is behind trying to understand the problem |
| 12:09 |
|
ashimema |
firday playlist.. great idea |
| 12:09 |
|
Joubu |
tcohen: Switched-On Bach |
| 12:10 |
|
tcohen |
Joubu++ |
| 12:11 |
|
tcohen |
Maybe Switched-On by Stereolab :-P |
| 12:12 |
|
ashimema |
++ |
| 12:13 |
|
tcohen |
Koha/Patron/Password/Recovery.pm: my $num_letters_attempted = C4::Letters::SendQueuedMessages( { |
| 12:13 |
|
tcohen |
misc/cronjobs/process_message_queue.pl:C4::Letters::SendQueuedMessages( |
| 12:13 |
|
tcohen |
opac/opac-memberentry.pl: my $num_letters_attempted = C4::Letters::SendQueuedMessages( { |
| 12:14 |
|
Joubu |
tcohen: https://www.wikiwand.com/en/Switched-On_Bach |
| 12:16 |
|
|
inlibro joined #koha |
| 12:18 |
|
kohaputti |
As far as I understand all the letters prepared that go to _send_message_by_email must not be encoded with MIME encoding because the Email::Stuffer does it so we cannot do it twice, and given it was encoded already in _send_message_by_email before the patch I attached I think it cannot hurt any other emails that get sent by this |
| 12:18 |
|
kohaputti |
because those emails would have been garbled already before this patch |
| 12:19 |
|
tcohen |
kohaputti lets do the right thing in Letters.pm |
| 12:19 |
|
tcohen |
and we will need to revisit side effects in the placse EnqueueLetter is called |
| 12:25 |
|
tcohen |
kohaputti SendAlerts seems safe |
| 12:26 |
|
Joubu |
oleonard: I confirm that it fixes the problem for me as well |
| 12:26 |
|
Joubu |
was for kohaputti |
| 12:26 |
|
kohaputti |
Ok |
| 12:26 |
|
Joubu |
however I don't understand why it happens for this notification and not the others |
| 12:26 |
|
kohaputti |
we should also verify that the attachment encoding in EnqueueLetter is correct |
| 12:26 |
|
kohaputti |
(if not done already by someone) |
| 12:27 |
|
kohaputti |
Joubu, what other notification it doesn't happen? |
| 12:27 |
|
Joubu |
I verified it |
| 12:27 |
|
kohaputti |
but if you go execute the code in your mind you can see it is clearly wrong to MIME encode twice |
| 12:27 |
|
tcohen |
I've got a refgression test |
| 12:27 |
|
Joubu |
when I tested this bug I focus on sending basket and list, because they have an attachment |
| 12:28 |
|
Joubu |
and it was working correctly |
| 12:28 |
|
kohaputti |
also wrong to UTF-8 encode twice |
| 12:28 |
|
pastebot |
"tcohen" at 127.0.0.1 pasted "regression test" (17 lines) at http://paste.koha-community.org/26040 |
| 12:29 |
|
kohaputti |
Joubu, reading https://bugs.koha-community.or[…]11048&action=diff the basket email sending is not handled by this |
| 12:29 |
|
kohaputti |
It has it's own way of calling Koha::Email |
| 12:29 |
|
tcohen |
those are send directly from the controllers |
| 12:30 |
|
Joubu |
you are right kohaputti, it's sent directly |
| 12:32 |
|
kohaputti |
tcohen, thanks for the regression test :) |
| 12:33 |
|
tcohen |
I'm not sure ti is correct |
| 12:33 |
|
tcohen |
I expected the faiilure to be the other way around |
| 12:34 |
|
kohaputti |
hmm, what do you mean other way around? |
| 12:35 |
|
kohaputti |
ah, the test doesn't work with the patch |
| 12:35 |
|
tcohen |
it feels it demonstrates things are working |
| 12:35 |
|
kohaputti |
hmm well it doesn't work a) without the patch b) with the patch |
| 12:36 |
|
tcohen |
is( $messages->[0]->{content}, decode_utf8($my_message->{letter}->{content}), 'EnqueueLetter stores the content correctly' ); |
| 12:36 |
|
kohaputti |
maybe "Wide character in print at /usr/share/perl5/Test2/Formatter/TAP.pm line 105." is caused by some other issue, like in how perl handles characters |
| 12:36 |
|
kohaputti |
maybe in the perl file you need to declare the code is utf8 |
| 12:37 |
|
kohaputti |
otherwise it might not allow that character in source code |
| 12:37 |
|
kohaputti |
use utf8; |
| 12:37 |
|
kohaputti |
(I have not yet tried it) |
| 12:38 |
|
kohaputti |
that fixed the perl warning |
| 12:39 |
|
tcohen |
ok, yes |
| 12:39 |
|
tcohen |
but it doesn't fail without your patch |
| 12:40 |
|
kohaputti |
also it doesn't fail with it so that's good :P |
| 12:41 |
|
Joubu |
tcohen: 'EnqueueLetter stores the content correctly' => this is not the problem |
| 12:41 |
|
Joubu |
the problem is when the email is sent |
| 12:41 |
|
tcohen |
oh |
| 12:41 |
|
kohaputti |
yes, this test seems to be unrelated |
| 12:41 |
|
Joubu |
The table content is correct |
| 12:42 |
|
tcohen |
we are mocking send_or_die |
| 12:42 |
|
tcohen |
I think it is the only method I used |
| 12:45 |
|
Joubu |
when do we send an email with attachment? Apart from basket and list |
| 12:48 |
|
tcohen |
reports |
| 12:48 |
|
tcohen |
run_reports.pl |
| 12:48 |
|
|
sophie_m joined #koha |
| 12:50 |
|
tcohen |
is it just about attachments? |
| 12:50 |
|
tcohen |
I don't reproduce in the tests |
| 12:50 |
|
|
enkidu joined #koha |
| 12:50 |
|
tcohen |
look for the tests on $email_object |
| 12:51 |
|
tcohen |
in Letters.t |
| 12:52 |
|
Joubu |
run_reports does not go to the table iirc |
| 12:53 |
|
tcohen |
I need to step back |
| 12:53 |
|
tcohen |
ping me if you need me to review anything, kohaputti Joubu |
| 13:01 |
|
Joubu |
tcohen: I need you to review the ktd merge request |
| 13:09 |
|
Joubu |
kidclamp: are you aware of a bug caused by preventDoubleFormSubmit if there is a form validation error on the first click? |
| 13:09 |
|
kidclamp |
I am not |
| 13:10 |
|
Joubu |
so basically the form submision is blocked if there is a validation error... |
| 13:10 |
|
Joubu |
that's bad |
| 13:12 |
|
ashimema |
this is 'fun' |
| 13:13 |
|
ashimema |
seems I introduce one of the first cases where we use the two things together |
| 13:13 |
|
* ashimema |
tries to find another example to see if anyone has already fixed it before |
| 13:16 |
|
kohaputti |
Joubu, is it better idea for me to create always a new bug report for issues spotted in bug reports (even if they are only few days ago pushed, and not backported yet)? Just wondering what is best for your processes as RM. |
| 13:17 |
|
|
inlibro joined #koha |
| 13:17 |
|
* kohaputti |
is thinking about bug 26627 |
| 13:17 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26627 normal, P5 - low, ---, kyle, Pushed to master , Print and confirming a hold can cause an infinite loop |
| 13:17 |
|
kidclamp |
is there a bug with instructions somewhere joubu? |
| 13:17 |
|
Joubu |
kohaputti: it depends :D on 1. the size, 2. how you are confident with the follow-up, etc. |
| 13:18 |
|
Joubu |
usually I am ok with reviewing the follow-up patch myself and push it |
| 13:18 |
|
ashimema |
I'm working on it kidclamp ;) |
| 13:18 |
|
kohaputti |
ookay, will try to use my best judgment :D |
| 13:18 |
|
Joubu |
always better to add the "additional_work_needed" bz kw, to not forget it |
| 13:18 |
|
ashimema |
it's exposed by one of my bugs which is PQA at the minute and Joubu spotted it |
| 13:18 |
|
ashimema |
in short |
| 13:19 |
|
kohaputti |
Joubu, though it might not be always good idea use your time for reviewing given you already have bunch of things to do with merging patches, and processing the bug reports |
| 13:19 |
|
Joubu |
kohaputti: if the follow-up is tiny I prefer a follow-up n the same bug |
| 13:19 |
|
ashimema |
have a form that requires validation using jQuery validator.. and add preventDoubleSubmit on the submit button |
| 13:19 |
|
kohaputti |
Joubu, ok |
| 13:20 |
|
ashimema |
then.. when you hit submit with an invalid form it triggers the 'waiting' class from the preventDbouleSubmit and then triggers the validation failure preventing submission... so even once you fix the validation issue you still have the 'waiting' class on the submit button so are unable to re-submit the form |
| 13:20 |
|
ashimema |
fun times |
| 13:32 |
|
|
Dyrcona joined #koha |
| 13:48 |
|
|
khall joined #koha |
| 14:10 |
|
Joubu |
kidclamp: FYI ashimema came up with that fix: https://bugs.koha-community.or[…]ent.cgi?id=113251 |
| 14:10 |
|
Joubu |
it's not global, so keep it in mind when it will appear somewhere else! |
| 14:13 |
|
kidclamp |
will file it awat |
| 14:14 |
|
kidclamp |
away, and hopefully remember |
| 14:16 |
|
ashimema |
hehe |
| 14:16 |
|
* ashimema |
is likely to run into it again some time and completely forget I've fixed it once already in the past ;) |
| 14:17 |
|
|
inlibro joined #koha |
| 14:55 |
|
|
oleonard_ joined #koha |
| 14:56 |
|
|
oleonar__ joined #koha |
| 14:56 |
|
huginn |
News from kohagit: Bug 14866: DBRev 20.06.00.063 <http://git.koha-community.org/[…]69b1042474fce0604> |
| 14:56 |
|
huginn |
News from kohagit: Bug 23091: DBRev 20.06.00.062 <http://git.koha-community.org/[…]4ffd29d8eb42343c4> |
| 14:56 |
|
huginn |
News from kohagit: Bug 24412: DBRev 20.06.00.061 <http://git.koha-community.org/[…]0995b94e3c16ac7a1> |
| 14:56 |
|
huginn |
News from kohagit: Bug 24412: DBIC schema changes <http://git.koha-community.org/[…]6ac6191e409098284> |
| 14:56 |
|
huginn |
News from kohagit: Bug 24412: (follow-up) prevent js injection <http://git.koha-community.org/[…]cc70772e1793a5d43> |
| 14:56 |
|
huginn |
News from kohagit: Bug 24412: (follow-up) prevent request.pl from failing <http://git.koha-community.org/[…]1d7af284d6059e7bf> |
| 14:56 |
|
huginn |
News from kohagit: Bug 26627: (QA follow-up) Remove barcode input by id <http://git.koha-community.org/[…]a46126e5d8eda72da> |
| 14:56 |
|
huginn |
News from kohagit: Bug 14866: Trivial code simplification <http://git.koha-community.org/[…]54772507c3492a6c3> |
| 14:56 |
|
huginn |
News from kohagit: Bug 14866: (QA follow-up) Add hint to system preferences <http://git.koha-community.org/[…]51e05275548d59f46> |
| 14:56 |
|
huginn |
News from kohagit: Bug 23091: (QA follow-up) POD fixes <http://git.koha-community.org/[…]edce2eabb0fe0f128> |
| 14:56 |
|
huginn |
News from kohagit: Bug 23091: Simplify tests by turning off AccountAutoReconcile <http://git.koha-community.org/[…]320f0890396b3d27f> |
| 14:56 |
|
huginn |
News from kohagit: Bug 23091: Add tests for \->credits and \->debits <http://git.koha-community.org/[…]fde8884f4f14ff4d9> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Move _Restore to Koha::Item store trigger <http://git.koha-community.org/[…]8489182ae13b899a5> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Unit Tests <http://git.koha-community.org/[…]db28421f3886cb2db> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Make relations more explicit <http://git.koha-community.org/[…]7c29a2777e015a106> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Add tests for _RestoreOverdueForLostAndFound <http://git.koha-community.org/[…]b2ac71753c76778ce> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Add template handling for new messages <http://git.koha-community.org/[…]2ba29299228dba949> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Update unit test <http://git.koha-community.org/[…]fd0aac48ddd613b35> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Database update <http://git.koha-community.org/[…]2169f439acc42da94> |
| 14:57 |
|
huginn |
News from kohagit: Bug 14866: Make high holds work with different item types <http://git.koha-community.org/[…]d5fc29ff535fd13a2> |
| 14:57 |
|
huginn |
News from kohagit: Bug 23091: Add handling for new lostreturn rules <http://git.koha-community.org/[…]5c024917d141129ad> |
| 15:17 |
|
|
inlibro joined #koha |
| 15:21 |
|
caroline |
oleonard: is it in the plans to eventually move the staff interface customizable sections to news also? |
| 15:27 |
|
tcohen |
how can I do this in JavaScript? |
| 15:27 |
|
tcohen |
columns_filters.push( { item: { "like": this.value+'%' } } ); |
| 15:27 |
|
tcohen |
where item is a variable |
| 15:27 |
|
tcohen |
it keeps puting the 'item' keyword |
| 15:35 |
|
Joubu |
SO says [item] |
| 15:39 |
|
ashimema |
caroline, I think so yes |
| 15:40 |
|
ashimema |
but.. I also think the News stuff all needs a bit of work to make it work a bit more cleanly.. |
| 15:40 |
|
ashimema |
which I think josef was working on last I looked |
| 15:43 |
|
|
JesseM joined #koha |
| 15:44 |
|
JesseM |
Hello all |
| 15:46 |
|
|
fridolin left #koha |
| 15:49 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #435: UNSTABLE in 50 min: https://jenkins.koha-community[…]9_MDB_Latest/435/ |
| 15:51 |
|
koha-jenkins |
Project Koha_Master_D9 build #1489: UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_D9/1489/ |
| 15:51 |
|
oleonard |
caroline are you just thinking ahead or do you have a concern about it? |
| 15:51 |
|
oleonard |
(sorry, was afk) |
| 15:51 |
|
caroline |
oleonard: no, just thinking ahead |
| 15:51 |
|
koha-jenkins |
Project Koha_Master_U20 build #136: UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_U20/136/ |
| 15:52 |
|
caroline |
I was working on this monster https://gitlab.com/koha-commun[…]ges/appendix-opac and wondering if we should do the same for the intranet |
| 15:52 |
|
koha-jenkins |
Project Koha_Master_U18 build #939: FAILURE in 1 min 20 sec: https://jenkins.koha-community[…]a_Master_U18/939/ |
| 15:54 |
|
oleonard |
Luckily for you caroline the options are fewer in the staff interface :) |
| 15:54 |
|
caroline |
haha yeah! |
| 15:55 |
|
oleonard |
tcohen: I spent an entire day fighting with columns settings this week and was defeated, so I don't think I can answer your question :( |
| 15:56 |
|
oleonard |
(Bug 22276) |
| 15:56 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22276 enhancement, P5 - low, ---, oleonard, ASSIGNED , Add client storage of user-selected DataTables configuration |
| 15:56 |
|
tcohen |
oooook |
| 15:56 |
|
tcohen |
what table were you playing with? |
| 15:57 |
|
oleonard |
The items table on additem.pl |
| 15:58 |
|
|
bdonnahue3 joined #koha |
| 16:01 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #457: UNSTABLE in 1 hr 4 min: https://jenkins.koha-community[…]aster_D9_My8/457/ |
| 16:17 |
|
|
inlibro joined #koha |
| 16:30 |
|
|
AndroUser joined #koha |
| 16:38 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #129: UNSTABLE in 49 min: https://jenkins.koha-community[…]ter_D10_Deps/129/ |
| 16:39 |
|
koha-jenkins |
Project Koha_Master_D11 build #135: STILL UNSTABLE in 46 min: https://jenkins.koha-community[…]a_Master_D11/135/ |
| 16:39 |
|
oleonard |
Bug 26958... bringin' back the hits. |
| 16:39 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26958 enhancement, P5 - low, ---, oleonard, Needs Signoff , Move Elasticsearch mapping template JS to the footer |
| 16:40 |
|
koha-jenkins |
Project Koha_Master_D10 build #398: UNSTABLE in 48 min: https://jenkins.koha-community[…]a_Master_D10/398/ |
| 16:40 |
|
|
enkidu joined #koha |
| 16:55 |
|
Joubu |
have a great weekend #koha! |
| 16:58 |
|
koha-jenkins |
Project Koha_Master_U16 build #121: UNSTABLE in 56 min: https://jenkins.koha-community[…]a_Master_U16/121/ |
| 17:06 |
|
|
khall joined #koha |
| 17:17 |
|
caroline |
For some reason, when I click on the input field for the PatronDuplicateMatchingAddFields syspref, there is nothing in the modal. Is there something I should activate to see the column names? |
| 17:17 |
|
|
inlibro joined #koha |
| 17:22 |
|
oleonard |
I wouldn't think so caroline... It looks okay to me in master |
| 17:25 |
|
caroline |
ok thanks for checking |
| 17:28 |
|
koha-jenkins |
Project Koha_Master_U2010 build #42: UNSTABLE in 48 min: https://jenkins.koha-community[…]_Master_U2010/42/ |
| 17:32 |
|
|
cait joined #koha |
| 18:17 |
|
|
inlibro joined #koha |
| 19:07 |
|
|
josef_moravec joined #koha |
| 19:17 |
|
|
enkidu joined #koha |
| 19:18 |
|
|
inlibro joined #koha |
| 19:42 |
|
|
davidnind joined #koha |
| 20:18 |
|
|
inlibro joined #koha |
| 20:57 |
|
|
cait joined #koha |
| 21:18 |
|
|
inlibro joined #koha |
| 21:46 |
|
tuxayo |
The new permalink button to a syspref is great! :D |
| 21:51 |
|
davidnind |
I agree, although I thought it was a bookmark initially... |
| 21:55 |
|
tuxayo |
That allows to easily bookmark |
| 21:55 |
|
tuxayo |
^^ |
| 22:12 |
|
|
did joined #koha |
| 22:16 |
|
caroline |
@later tell kathryn if the offer to have these images done nicer still stands, I'd take you up on it https://gitlab.com/koha-commun[…]ges/appendix-opac |
| 22:16 |
|
huginn |
caroline: The operation succeeded. |
| 22:17 |
|
caroline |
have a nice weekend everyone! |
| 22:18 |
|
|
inlibro joined #koha |
| 22:48 |
|
|
AndroUser2 joined #koha |
| 23:05 |
|
|
AndroUser2 joined #koha |
| 23:09 |
|
|
AndroUser2 joined #koha |
| 23:18 |
|
|
inlibro joined #koha |
| 23:58 |
|
|
AndroUser2 joined #koha |
