| Time |
S |
Nick |
Message |
| 00:06 |
|
koha-jenkins |
Project Koha_19.05_D9_MDB10.3 build #10: SUCCESS in 31 min: https://jenkins.koha-community[…]05_D9_MDB10.3/10/ |
| 00:07 |
|
|
AndrewFH joined #koha |
| 00:33 |
|
|
bigbrovar joined #koha |
| 00:51 |
|
|
inlibro joined #koha |
| 01:03 |
|
tuxayo |
@later tell rangi the call for translators to fix the few invalid translations was not in vain! :D 1 issue fixed, 1 marked as fuzzy (good for RMaint at least) and maybe 2 other fixed, not sure. |
| 01:03 |
|
huginn |
tuxayo: The operation succeeded. |
| 01:24 |
|
rangi |
tuxayo: ooh thats good news |
| 01:33 |
|
|
cait1 joined #koha |
| 01:39 |
|
|
Jane joined #koha |
| 01:40 |
|
Jane |
Hello. Can anyone tell me if it is feasible to use Koha to run a library system in an environment where there is no internet? |
| 01:40 |
|
tuxayo |
Jane: I heard about a few libraries that do it. |
| 01:42 |
|
Jane |
OK. That is good to know. Do you happen to remember what libraries were doing that? It would be great to talk with them. |
| 01:43 |
|
rangi |
you need a network, it doesnt need to be connected to the internet |
| 01:44 |
|
tuxayo |
Unfortunately no but it seemed clear that nothing in particular had to be done. |
| 01:44 |
|
Jane |
OK. Thanks tuxayo |
| 01:44 |
|
Jane |
Rangi, what do you mean by a network in this case? |
| 01:45 |
|
rangi |
if you want to use it on two computers, then those computers need to be connected with a network |
| 01:45 |
|
|
amoyano left #koha |
| 01:45 |
|
rangi |
(two or more that is) |
| 01:45 |
|
Jane |
OK. I am thinking of a single standalone computer that is managing one single collection |
| 01:45 |
|
tuxayo |
Also possible :) |
| 01:45 |
|
rangi |
and everyone uses that one computer |
| 01:46 |
|
rangi |
yep |
| 01:47 |
|
Jane |
Yes. One operator for one collection |
| 01:47 |
|
Jane |
On one computer |
| 01:47 |
|
rangi |
then yep, you just install it, and its done :) |
| 01:47 |
|
tuxayo |
However having an internet connection to install Koha would help a lot. Other that would be a pain, right rangi ? |
| 01:48 |
|
Jane |
Excellent. Is it easy to instal by someone who is not technical and has no access to a techie person? |
| 01:48 |
|
rangi |
yeah, you can do it, you would need to download everythign to a usb and copy it, much easier to be connected to the internet to install, then disconnect |
| 01:48 |
|
Jane |
Ah! So you need an internet connection to download the software |
| 01:48 |
|
Jane |
I expect you would! |
| 01:49 |
|
rangi |
you can download everything else somewhere and copy it, but thats pretty hard |
| 01:49 |
|
Jane |
OK. But it can be done from a USB |
| 01:49 |
|
Jane |
I am trying to get an LMS to run inside a prison. There is no internet at all. |
| 01:50 |
|
rangi |
yep |
| 01:50 |
|
rangi |
you it would be eaiser to use the livedvd i think |
| 01:50 |
|
Jane |
What is that? |
| 01:50 |
|
rangi |
i have a meeting now, but i will be back later |
| 01:50 |
|
Jane |
OK. Thanks so much |
| 01:51 |
|
|
inlibro joined #koha |
| 01:51 |
|
tuxayo |
rangi++ |
| 01:51 |
|
tuxayo |
I didn't know about, look great! (I'm sending the links here) |
| 01:52 |
|
tuxayo |
https://sourceforge.net/projects/kohalivedvd/ |
| 01:52 |
|
tuxayo |
https://vimal0212.wordpress.com/koha-live-dvd/ |
| 01:52 |
|
Jane |
Thanks tuxayo |
| 01:52 |
|
tuxayo |
https://wiki.koha-community.org/wiki/Koha_LiveCD (the Koha version mentionned on the wiki page isn't up to date) |
| 02:03 |
|
koha-jenkins |
Project Koha_19.05_D9_MDB10.3 build #11: SUCCESS in 44 min: https://jenkins.koha-community[…]05_D9_MDB10.3/11/ |
| 02:07 |
|
koha-jenkins |
Project Koha_19.05_D9 build #261: SUCCESS in 46 min: https://jenkins.koha-community[…]oha_19.05_D9/261/ |
| 02:07 |
|
koha-jenkins |
Project Koha_19.05_U18 build #264: SUCCESS in 45 min: https://jenkins.koha-community[…]ha_19.05_U18/264/ |
| 02:09 |
|
tuxayo |
Jane: have a good read :) I hope that can be a good way towards your goal given the constraints. |
| 02:10 |
|
tuxayo |
However if there is a way to get help from a technical person, that would have the benefit to have a more standard installation. |
| 02:10 |
|
tuxayo |
Also being able to get internet from a phone for the install or get the computer out of jail just for the install would help. |
| 02:11 |
|
dcook |
Bug 26048 |
| 02:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26048 normal, P5 - low, ---, dcook, NEW , Apache does not use /cgi-bin/koha/errors/500.pl if Perl script dies |
| 02:11 |
|
tuxayo |
These are the "only" things needed to make the whole process and result like any other Koha. And thus it's would be possible to upgrade to future versions if needed. |
| 02:11 |
|
tuxayo |
Otherwise you could have a Koha stuck forever on the same version as the install. It would work. |
| 02:11 |
|
tuxayo |
Hi dcook :) |
| 02:11 |
|
dcook |
Heya tuxayo |
| 02:12 |
|
dcook |
While I am super verbose, I think that bug might interest people |
| 02:15 |
|
tuxayo |
Indeed, I remember that at BibLibre I worked with fridolin to handle 5XX error more gracefully. Not sure how much was specific to out setup |
| 02:16 |
|
dcook |
:o |
| 02:16 |
|
tuxayo |
@later tell fridolin Hi :) is Bug 26048 relevant to what we started to gracefully handle errors? |
| 02:16 |
|
huginn |
tuxayo: The operation succeeded. |
| 02:16 |
|
dcook |
That's really interesting |
| 02:17 |
|
dcook |
I'll add Frido as a CC |
| 02:17 |
|
dcook |
I have a few proposed solutions there, but not sure which would be best |
| 02:17 |
|
dcook |
Or... which would be more acceptable to the community rather |
| 02:18 |
|
dcook |
I love working on issues like these heh |
| 02:18 |
|
tuxayo |
This is great :D |
| 02:18 |
|
tuxayo |
dcook++ |
| 02:18 |
|
tuxayo |
These issue need love |
| 02:18 |
|
tuxayo |
*issues |
| 02:18 |
|
dcook |
Agreed |
| 02:19 |
|
dcook |
I'm on a bit of an error-handling streak at the moment as well |
| 02:19 |
|
dcook |
I have a different project where the originally designed error-handling worked but actually created other errors |
| 02:19 |
|
dcook |
Machine-to-machine systems are hard O_O |
| 02:19 |
|
dcook |
But also fun >_> |
| 02:24 |
|
tuxayo |
^^ |
| 02:26 |
|
Jane |
Thanks everyone! |
| 02:34 |
|
tuxayo |
Jane: Don't hesitate to come here (and contact the makers of the Live DVD if you use that), I hope all your constraints won't get you too much struggle. |
| 02:34 |
|
tuxayo |
And the mailing lists are good places to get help. |
| 02:36 |
|
Jane |
Lovely! Thanks so much, tuxayo |
| 02:38 |
|
|
bdonnahue1 joined #koha |
| 02:39 |
|
tuxayo |
Jane: no problem, thanks for working about a prison library. It's useful to make the place actually help people. |
| 02:44 |
|
koha-jenkins |
Project Koha_19.05_D9 build #262: UNSTABLE in 37 min: https://jenkins.koha-community[…]oha_19.05_D9/262/ |
| 02:45 |
|
koha-jenkins |
Project Koha_19.05_U18 build #265: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_19.05_U18/265/ |
| 02:46 |
|
dcook |
Oh snap... |
| 02:46 |
|
dcook |
Jane: I might be able to help you Jane |
| 02:47 |
|
dcook |
Actually, looks like you were well taken care of |
| 02:47 |
|
dcook |
I have a client that uses Koha in a prison library |
| 02:48 |
|
dcook |
Could always put you in touch with them |
| 02:49 |
|
dcook |
Ah, but they do have technical staff. |
| 02:51 |
|
dcook |
At some point, I want to play with Koha on WSL2... although that would require setting up the computer with an Internet connection and removing it later. |
| 02:51 |
|
|
inlibro joined #koha |
| 02:56 |
|
Jane |
dcook I would be interested in getting touch with your prison contact, if that is OK? |
| 02:57 |
|
dcook |
Sure, I'll send you some details in a private message |
| 02:58 |
|
Jane |
Thank you! |
| 02:58 |
|
dcook |
No worries! |
| 02:58 |
|
dcook |
For what it's worth, I've done a few Koha instances where we put together the computers in our offices, and then we sent them to their destinations where they didn't have Internet access |
| 02:59 |
|
dcook |
The other computers in those organisations then either used Ethernet cables or WiFi to talk with the computer that had Koha |
| 03:25 |
|
koha-jenkins |
Project Koha_19.05_U18 build #266: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_19.05_U18/266/ |
| 03:27 |
|
koha-jenkins |
Project Koha_19.05_D9 build #263: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]oha_19.05_D9/263/ |
| 03:34 |
|
koha-jenkins |
Project Koha_19.05_D9_MDB10.3 build #12: SUCCESS in 44 min: https://jenkins.koha-community[…]05_D9_MDB10.3/12/ |
| 03:51 |
|
|
inlibro joined #koha |
| 04:04 |
|
mtj |
hi hayley, i emailed you back |
| 04:06 |
|
hayley |
thanks mtj! |
| 04:10 |
|
mtj |
np, hope the workaround does the trick :) |
| 04:14 |
|
hayley |
yep it looks like it has! thanks :) |
| 04:19 |
|
mtj |
swwet, ill send that email to the dev list |
| 04:21 |
|
|
kathryn joined #koha |
| 04:51 |
|
|
inlibro joined #koha |
| 05:14 |
|
|
aleisha_ joined #koha |
| 05:32 |
|
dcook |
Oh hey mtj still around? |
| 05:32 |
|
dcook |
No worries if not. Just thinking about libhttp-oai-perl versions.. |
| 05:33 |
|
mtj |
hi dcook, still about for a bit |
| 05:33 |
|
dcook |
cool |
| 05:33 |
|
dcook |
mtj: What versions of Debian do we target? |
| 05:34 |
|
dcook |
I know someone on Koha 19.11 and HTTP::OAI 4.10 (from CPAN I assume), and it wasn't working at all until I had them downgrade to 3.27 (the version in Jessie) |
| 05:34 |
|
dcook |
I think Koha is working on stretch and buster? So guessing those versions (4.03 and 4.08) are OK |
| 05:35 |
|
dcook |
But curious about bullseye which uses 4.10... |
| 05:35 |
|
dcook |
That said, I think the Debian team have patched HTTP::OAI in libhttp-oai-perl, so might not be relevant |
| 05:35 |
|
|
cait joined #koha |
| 05:35 |
|
dcook |
Tim Brody abandoned HTTP::OAI at 4.03, but Patrick Hochstenbach started maintaining it in HTTP::OAI 4.04 |
| 05:36 |
|
dcook |
(about 3 years between those versions) |
| 05:36 |
|
* dcook |
double checks what OAI unit tests there are.. |
| 05:37 |
|
mtj |
do we have some tests to detect problems with the OAI stuff? |
| 05:37 |
|
dcook |
Looking now but it's not looking great to me |
| 05:39 |
|
mtj |
koha stable basically runs on deb 11 thru to 8 |
| 05:39 |
|
dcook |
At least in terms of the unit tests? |
| 05:39 |
|
mtj |
(according to jenkins) |
| 05:39 |
|
mtj |
yeah |
| 05:40 |
|
dcook |
Yeah I think the unit tests probably aren't sufficient to test the usage of HTTP::OAI at this point |
| 05:40 |
|
dcook |
I'll open a bug report |
| 05:40 |
|
dcook |
Thanks for the info :) |
| 05:40 |
|
mtj |
dcook: whats the old BZ that describes the OAI problem? |
| 05:41 |
|
dcook |
Hmm good question |
| 05:41 |
|
dcook |
There are a couple it seems |
| 05:42 |
|
dcook |
bug 19732 |
| 05:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19732 critical, P1 - high, ---, koha-bugs, RESOLVED DUPLICATE, Koha does not work with latest versions of HTTP::OAI |
| 05:42 |
|
dcook |
bug 17704 |
| 05:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17704 normal, P5 - low, ---, koha-bugs, NEW , Fix OAI breakage when using HTTP::OAI 4.03+ |
| 05:42 |
|
dcook |
bug 20437 |
| 05:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20437 major, P5 - low, ---, tomascohen, CLOSED FIXED, Force requirement for HTTP::OAI 3.27 |
| 05:42 |
|
dcook |
That last one has some good info from Tomas.. |
| 05:45 |
|
dcook |
I guess 17704 would be the one to hang off |
| 05:45 |
|
mtj |
hmm, tldr... OAI is busted until 4.07 is released |
| 05:46 |
|
dcook |
Nah, I think that's wrong |
| 05:46 |
|
dcook |
I think that's just the latest info they had at that time |
| 05:46 |
|
dcook |
As it was still busted with 4.10 today |
| 05:46 |
|
mtj |
https://lists.koha-community.o[…]ruary/044302.html |
| 05:47 |
|
dcook |
Yeah, looks like more thought needs to go into this one |
| 05:49 |
|
mtj |
dcook: whats the test to determine if its busted with OAI 4.10? |
| 05:50 |
|
dcook |
That's a good question |
| 05:50 |
|
mtj |
it wont build via cpan? or something else? |
| 05:50 |
|
dcook |
Admittedly, I use a slightly modified Koha::OAI::Server::Repository locally |
| 05:50 |
|
dcook |
Today, even loading /cgi-bin/koha/oai.pl would cause an error |
| 05:51 |
|
dcook |
Hmm |
| 05:51 |
|
dcook |
Actually oai.pl doesn't do anything too special |
| 05:51 |
|
dcook |
Just Koha::OAI::Server::Repository->new() |
| 05:51 |
|
dcook |
And that should be covered by t/db_dependent/OAI/Server.t |
| 05:52 |
|
|
inlibro joined #koha |
| 05:52 |
|
dcook |
So I think I was mistaken about the unit tests |
| 05:52 |
|
dcook |
I think they may be sufficient after all |
| 05:54 |
|
mtj |
i think we need to get some good tests to determine whats busted, and whats not |
| 05:54 |
|
mtj |
https://bugs.koha-community.or[…]g.cgi?id=17704#c8 |
| 05:54 |
|
huginn |
Bug 17704: normal, P5 - low, ---, koha-bugs, NEW , Fix OAI breakage when using HTTP::OAI 4.03+ |
| 05:55 |
|
mtj |
Tomas says " Currently 4.06 is released, but 4.07 should be used once released, as it contains the fix for the ->xslt |
| 05:55 |
|
mtj |
method missing." |
| 05:55 |
|
dcook |
Yeah I saw him mention that |
| 05:55 |
|
dcook |
But I don't think he's right |
| 05:56 |
|
dcook |
This is the error we got when htiting oai.pl today |
| 05:56 |
|
dcook |
Can't call method "processing_instruction" on an undefined value at /usr/local/share/perl/5.28.1/HTTP/OAI/Response.pm line 115. |
| 05:56 |
|
dcook |
So something else is going on there |
| 05:56 |
|
dcook |
I'll look at the source code |
| 05:57 |
|
|
enkidu joined #koha |
| 05:57 |
|
dcook |
https://github.com/LibreCat/perl-oai-lib |
| 05:57 |
|
dcook |
That's related to the driver |
| 05:58 |
|
dcook |
This wasn't a package install of course.. |
| 05:58 |
|
dcook |
Oh wait yeah that makes sense then |
| 05:58 |
|
dcook |
We'd still need Tomas's patch |
| 05:59 |
|
dcook |
As generate() needs the $driver argument |
| 05:59 |
|
mtj |
would be good to test on a packaged koha, as a control |
| 05:59 |
|
dcook |
Without that patch, I think it'll fail |
| 06:00 |
|
dcook |
Hmm 4pm here. Yeah maybe I have time to work on this heh |
| 06:00 |
|
mtj |
dcook: if its not a packaged version, what is it? |
| 06:01 |
|
dcook |
I think it's a "single" source install |
| 06:01 |
|
mtj |
..and a bunch of cpan modules? |
| 06:01 |
|
dcook |
Yup |
| 06:01 |
|
dcook |
We've been switching over hosted instances to package installs |
| 06:01 |
|
dcook |
But this isn't a hosted install, so more arm's length |
| 06:02 |
|
dcook |
Most modules are find being CPANed but HTTP::OAI never is |
| 06:02 |
|
dcook |
Actually, it would be good if Koha refused to work with too high of a HTTP::OAI.. |
| 06:02 |
|
mtj |
dcook: can you add the steps to hit your oai.pl bug to a BZ |
| 06:03 |
|
dcook |
Yeah, I'll add details to bug 17704 |
| 06:03 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17704 normal, P5 - low, ---, koha-bugs, NEW , Fix OAI breakage when using HTTP::OAI 4.03+ |
| 06:04 |
|
dcook |
Ooof "apt-get install libhttp-oai-perl" is definitely not the way to go.. |
| 06:05 |
|
dcook |
"cpanm HTTP::OAI" it is.. |
| 06:07 |
|
|
lmstrand joined #koha |
| 06:08 |
|
mtj |
dcook: whats the problem with apt-get? |
| 06:08 |
|
dcook |
debian/control doesn't allow >= 4.0 for libhttp-oai-perl |
| 06:09 |
|
dcook |
So installing libhttp-oai-perl >= 4.0 will uninstall koha-common |
| 06:10 |
|
dcook |
That might explain an issue with an upgrade I noticed recently... |
| 06:10 |
|
dcook |
Upgrading from Jessie to Stretch uninstalled Koha |
| 06:10 |
|
dcook |
I didn't do the upgrade. It was someone else's server and Ops staff |
| 06:10 |
|
dcook |
But I wonder if they didn't have the Koha community repo enabled... and accidentally installed libhttp-oai-perl or something.. |
| 06:11 |
|
dcook |
libhttp-oai-perl (<< 4.0) or liblwp-protocol-https-perl|libwww-perl (<<6.02) |
| 06:12 |
|
mtj |
easy fix -> 'debian/control doesn't allow >= 4.0 for libhttp-oai-perl' |
| 06:13 |
|
mtj |
https://metacpan.org/changes/d[…]ribution/HTTP-OAI |
| 06:13 |
|
mtj |
4.07 2018-05-28 15:14:54 CEST |
| 06:13 |
|
mtj |
- Fixed adding XSLT stylesheet process instructions #4 |
| 06:14 |
|
mtj |
seems that the following error was fixed in 4.07... |
| 06:14 |
|
mtj |
"Can't call method "processing_instruction"" |
| 06:19 |
|
|
did joined #koha |
| 06:26 |
|
dcook |
? |
| 06:26 |
|
dcook |
Not following mtj |
| 06:26 |
|
dcook |
Btw, looks like a few modules which caused koha-common to be installed between Jessie and Stretch... |
| 06:28 |
|
mtj |
hmm, seems to be working ok for me via KTD - koha-stable on debian-stable |
| 06:29 |
|
mtj |
http://xen1-lan.kohaaloha.com:[…]ataPrefix=marcxml |
| 06:30 |
|
mtj |
https://ibb.co/Xp1Zb1Z |
| 06:31 |
|
dcook |
mtj: How did you install HTTP::OAI? |
| 06:31 |
|
dcook |
(I've mostly switched tasks now heh) |
| 06:32 |
|
dcook |
Ok I've updated my HTTP::OAI using cpanm in koha-testing-docker... |
| 06:33 |
|
dcook |
http://localhost:8080/cgi-bin/koha/oai.pl |
| 06:33 |
|
dcook |
"Internal Server Error" in browser |
| 06:33 |
|
dcook |
In plack-error.log: "Can't call method "processing_instruction" on an undefined value at /usr/local/share/perl/5.24.1/HTTP/OAI/Response.pm line 115." |
| 06:39 |
|
Joubu |
aleisha: are you around? |
| 06:40 |
|
|
reiveune joined #koha |
| 06:40 |
|
dcook |
koha-common being uninstalled during the upgrade was weird.. |
| 06:40 |
|
reiveune |
hello |
| 06:41 |
|
|
alex_a joined #koha |
| 06:42 |
|
mtj |
dcook: oops, i was testing ok with oai 3.27 |
| 06:42 |
|
alex_a |
Bonjour |
| 06:44 |
|
dcook |
mtj: That'll happen heh |
| 06:49 |
|
dcook |
mtj: I'll make a note to myself to review Tomas's patch and possibly write my own |
| 06:50 |
|
dcook |
I think he said his might be non-functional but it looks like it's nearly there |
| 06:52 |
|
|
inlibro joined #koha |
| 06:52 |
|
mtj |
dcook: yes, it looks very close to me |
| 06:53 |
|
mtj |
+ my $driver = HTTP::OAI::SAX::Driver->new( |
| 06:53 |
|
mtj |
+ Handler => my $builder = XML::LibXML::SAX::Builder->new() |
| 06:53 |
|
mtj |
+ ); |
| 06:56 |
|
dcook |
Yeah, there's a bit more to it, but that's the core bit |
| 06:56 |
|
* dcook |
does not like SAX |
| 06:56 |
|
dcook |
But looks like HTTP::OAI only supports SAX |
| 06:56 |
|
dcook |
But it's 4:56 so I think this one will wait until tomorrow |
| 06:56 |
|
dcook |
Joubu: Nice one with Plack::Middleware::ErrorDocument. That looks great. |
| 06:56 |
|
mtj |
patch applies, and works ok |
| 06:56 |
|
dcook |
Oh? That's great! |
| 06:56 |
|
dcook |
I'll try it now |
| 06:57 |
|
dcook |
Might need to uncomment that xslt line so that the xslt works agian with the OAI but that should probably be fine so long as ew're using 4.07+ |
| 06:57 |
|
mtj |
dcook: https://ibb.co/GnzL8sT |
| 06:57 |
|
dcook |
So >= buster |
| 06:57 |
|
dcook |
Cool :) |
| 06:58 |
|
|
fridolin joined #koha |
| 06:59 |
|
dcook |
Yeah http://localhost:8080/cgi-bin/[…]ataPrefix=marcxml is looking good with Tomas's patch |
| 06:59 |
|
|
cait1 joined #koha |
| 07:00 |
|
|
cait2 joined #koha |
| 07:00 |
|
dcook |
Yep that XSLT line is good too |
| 07:00 |
|
dcook |
I'll send a follow-up |
| 07:00 |
|
Joubu |
dcook: I discussed that problem with Tomas 3y ago, looks like it got lost |
| 07:00 |
|
Joubu |
dcook: in my notes I also have Plack::Middleware::DiePretty |
| 07:01 |
|
dcook |
Joubu: Oh DiePretty looks nice too |
| 07:02 |
|
mtj |
dcook: 5pm beckons |
| 07:02 |
|
dcook |
Maybe even preferable really.. |
| 07:02 |
|
dcook |
mtj: That it does.. |
| 07:02 |
|
dcook |
I'll post that follow-up now |
| 07:02 |
|
dcook |
I'm not 100% sure of some of Tomas's code there but so long as it works... |
| 07:03 |
|
mtj |
dcook: fyi, i forced the debian/buster oai 4.08 like... |
| 07:03 |
|
mtj |
dpkg --purge --force-depends libhttp-oai-3.27-perl |
| 07:03 |
|
mtj |
apt-get download libhttp-oai-perl |
| 07:03 |
|
mtj |
dpkg --force-all -i libhttp-oai-perl_4.08-1_all.deb |
| 07:03 |
|
dcook |
Joubu: And that'll happen. I think I've commented on so many Bugzilla issues today that I can't keep track of them all.. |
| 07:03 |
|
Joubu |
dcook: I think we are fighting 2 different things |
| 07:03 |
|
dcook |
Joubu: Oh? |
| 07:03 |
|
wahanui |
Oh are there instructions? |
| 07:03 |
|
dcook |
mtj: That's interesting |
| 07:04 |
|
mtj |
i'll add it to the bz |
| 07:04 |
|
Joubu |
the original one, reported by Rudolf, is specific about "bad data" (24574). As I said in comment 5, we deal with that "our way", catching the problem on the detail view and with a script |
| 07:07 |
|
Joubu |
the detail view is handling it quite ok, with a check at the beginning of the page (seen 23846, right?) |
| 07:08 |
|
Joubu |
the other way we have to catch bad things/low level issues like that is C4::Output::output_and_exit and the "blocking_error" TT params (see blocking_errors.inc) |
| 07:09 |
|
Joubu |
that's is the first point, the errors that we are catching/handling correctly |
| 07:09 |
|
Joubu |
the second point you are trying to fix is for the errors we don't catch: display a nice 500 page |
| 07:10 |
|
Joubu |
but in my understanding Rudolf wanted "us" to deal with incorrect encoding/data the first way |
| 07:11 |
|
Joubu |
(slow typing, I was super slow to find the bug numbers and correct filenames) |
| 07:12 |
|
dcook |
Joubu: Oh I totally agree with you there |
| 07:12 |
|
dcook |
Or rather... I think they're 2 different things, but it's not 100% clear to me which Rudolf is referring too for ISBDdetail.pl and MARCdetail.pl |
| 07:12 |
|
dcook |
I think what you've said makes sense though |
| 07:12 |
|
dcook |
We've fixed the normal view, and I think that's sufficient in terms of caught errors |
| 07:13 |
|
dcook |
I think a user friendly 500 page for ISBDdetial.pl and MARCdetail.pl should be sufficient |
| 07:13 |
|
dcook |
Unless he wants to submit a patch or persuades someone else to |
| 07:13 |
|
dcook |
Sorry for all my comments there heh |
| 07:13 |
|
Joubu |
yes, a frienldy 500 would be good, not for devs however |
| 07:14 |
|
dcook |
That's true |
| 07:14 |
|
dcook |
It would make things worse for devs |
| 07:15 |
|
Joubu |
are you going to investigate the 2 modules? :) |
| 07:16 |
|
dcook |
Joubu: I'd be willing |
| 07:16 |
|
dcook |
At this point, I'd like a bit of feedback for preferred approaches, but since you're RM, your feedback matters most heh |
| 07:17 |
|
dcook |
Basically, I don't want to invest time in something that people will decide isn't the right approach |
| 07:17 |
|
dcook |
But if we think a Plack middleware is good, then I'm happy to write some patches and test plans |
| 07:17 |
|
dcook |
Perhaps we don't have to fix the CGI situation and just let it languish.. |
| 07:19 |
|
Joubu |
It's something that fell down at the bottom of my list, and I am wondering why (it's a 3y old topic). Maybe the plakc middleware did not work, cannot remember |
| 07:19 |
|
Joubu |
but I'd start to double check that first |
| 07:19 |
|
Joubu |
looks like the good direction |
| 07:21 |
|
dcook |
Cool I agree |
| 07:21 |
|
dcook |
I've made a note to revisit it tomorrow |
| 07:21 |
|
dcook |
That one and the OAI one |
| 07:22 |
|
|
alex_a_ joined #koha |
| 07:22 |
|
dcook |
And I signed off Frido's patch at 19261 |
| 07:22 |
|
dcook |
Bug 19261 |
| 07:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19261 normal, P5 - low, ---, fridolin.somers, Signed Off , never hide biblionumber field in view policy |
| 07:22 |
|
dcook |
Joubu: Tomorrow I can sign off your patch on bug 25826 as well |
| 07:22 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25826 critical, P3, ---, tomascohen, NEW , Hiding biblionumber in the frameworks breaks links in result list |
| 07:22 |
|
dcook |
Although we might want to rename the bug, if only for the release notes |
| 07:23 |
|
Joubu |
I think it's not ready for so |
| 07:23 |
|
dcook |
Oh? |
| 07:23 |
|
wahanui |
Oh are there instructions? |
| 07:23 |
|
Joubu |
Tomas is going to attach another patch |
| 07:23 |
|
dcook |
Ah ok |
| 07:23 |
|
dcook |
You mean for yours or Frido's? |
| 07:23 |
|
Joubu |
he wants to have a list of fields we cannot hide from the interface |
| 07:23 |
|
dcook |
Ahh |
| 07:23 |
|
dcook |
Yeah that does make sense |
| 07:23 |
|
dcook |
Wise |
| 07:24 |
|
fridolin |
hiiiii |
| 07:24 |
|
dcook |
Speaking of wise, I'm overtime now, so I'm going to go spend time with my wonderful girlfriend and have some dinner |
| 07:24 |
|
dcook |
salut fridolin :D |
| 07:24 |
|
dcook |
and ciao everyone |
| 07:24 |
|
dcook |
Have a good day! |
| 07:24 |
|
tuxayo |
o/ |
| 07:24 |
|
fridolin |
dcook: le bonjour ;) |
| 07:25 |
|
fridolin |
tuxayo: Bug 26048 whao i like that |
| 07:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26048 normal, P5 - low, ---, dcook, NEW , Apache does not use /cgi-bin/koha/errors/500.pl if Perl script dies |
| 07:26 |
|
fridolin |
cause if your google "internal server error" you find all Koha sites ;) |
| 07:26 |
|
fridolin |
i'll test with Nginx |
| 07:26 |
|
tuxayo |
XD |
| 07:26 |
|
Joubu |
enjoy your evening dcook |
| 07:34 |
|
Joubu |
mtj: have you seen bug 25792 comment 15? |
| 07:34 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25792 major, P5 - low, ---, mtj, Pushed to master , Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 |
| 07:36 |
|
tuxayo |
ashimema++ for the very nice version table on the Koha wikipedia article ^^ |
| 07:36 |
|
tuxayo |
https://en.wikipedia.org/wiki/[…]oftware)#Releases |
| 07:37 |
|
Joubu |
gmcharlt: Hi Galen, Mason sent an email to koha-devel about debian.k-c.org - https://lists.koha-community.o[…]-July/045884.html Are you the one to contact for such request? |
| 07:42 |
|
Joubu |
mtj: this is actually a ktd issue, I am reporting it now |
| 07:46 |
|
Joubu |
quick signoff needed on bug 26033 please |
| 07:46 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26033 normal, P5 - low, ---, jonathan.druart, Needs Signoff , framapic is closing |
| 07:52 |
|
|
inlibro joined #koha |
| 07:56 |
|
Joubu |
@later tell rangi there are some koha-dashboard's PRs waiting for you ;) https://gitlab.com/koha-commun[…]/-/merge_requests |
| 07:56 |
|
huginn |
Joubu: The operation succeeded. |
| 08:02 |
|
|
kohaputti joined #koha |
| 08:04 |
|
kohaputti |
mtj, hi, in case there is nothing else on debian.kc.org than apache that serves the files reprepro generated it should probably be pretty easy to upgrade to stable |
| 08:04 |
|
kohaputti |
mtj, we just need to go to 8 -> 9 -> 10 |
| 08:05 |
|
Joubu |
looks like it's the same server as the wiki |
| 08:05 |
|
kohaputti |
oh noes |
| 08:05 |
|
Joubu |
https://wiki.koha-community.or[…]nistration#debian.koha-community.org |
| 08:05 |
|
Joubu |
I pinged Galen earlier here |
| 08:06 |
|
kohaputti |
ok, I wonder how mediawiki is instaleld |
| 08:06 |
|
Joubu |
I don't want to know |
| 08:06 |
|
Joubu |
:D |
| 08:07 |
|
* ashimema |
wonders if we can get rid of the warning on the wikipedia page about references being too closely associated with the subject |
| 08:07 |
|
ashimema |
I wouldn't say it really applies any more |
| 08:07 |
|
Joubu |
there is a current X year attempt to upgrade the wiki to a newest version, so I guess it's a mess there |
| 08:09 |
|
ashimema |
I wasn talking about wikipedia rather than our own wiki |
| 08:10 |
|
ashimema |
ah.. |
| 08:10 |
|
* ashimema |
read back |
| 08:13 |
|
kohaputti |
if you are in touch with the current sysadmins, and they need help with the upgrade just let me know. |
| 08:14 |
|
kohaputti |
but I guess this upgrade won't be coming without some major downtime, maybe 6 hours minimum. |
| 08:15 |
|
kohaputti |
(if we do the 8 -> 9 -> 10 upgrade) |
| 08:18 |
|
Joubu |
sounds better to install it on a separate server |
| 08:18 |
|
ashimema |
+1 |
| 08:21 |
|
kohaputti |
surely good, but do the current sysadmins have time to do that? Is there configuration management? |
| 08:21 |
|
Joubu |
ashimema: are you familiar with the "move prefs to news block" code? |
| 08:22 |
|
Joubu |
we are going to wait for gmcharlt's answer first :) |
| 08:23 |
|
koha-jenkins |
Yippee, build fixed! |
| 08:23 |
|
wahanui |
Congratulations! |
| 08:23 |
|
koha-jenkins |
Project Koha_Master_D10 build #304: FIXED in 36 min: https://jenkins.koha-community[…]a_Master_D10/304/ |
| 08:23 |
|
ashimema |
Erm.. |
| 08:24 |
|
ashimema |
Familiar enough that I wish I'd not let it in.. |
| 08:24 |
|
ashimema |
It needs a good clean up before more things move across in my opinion.. |
| 08:24 |
|
ashimema |
Joubu |
| 08:25 |
|
ashimema |
I did start on such a clean up.. but haven't got far yet |
| 08:25 |
|
Joubu |
I have 3 more moves that are PQA |
| 08:25 |
|
Joubu |
I am only wondering about: |
| 08:25 |
|
Joubu |
Koha/Template/Plugin/KohaNews.pm |
| 08:25 |
|
Joubu |
what is "blocktitle"? |
| 08:26 |
|
Joubu |
koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt:[% SET OpacHeader = KohaNews.get( location => "opacheader", lang => lang, library => branchcode, blocktitle => 0 ) %] |
| 08:26 |
|
Joubu |
but the TT plugin is not doing anything useful with it |
| 08:31 |
|
ashimema |
it's a mess |
| 08:31 |
|
ashimema |
that's not a part of it I'd noticed yet |
| 08:41 |
|
koha-jenkins |
Yippee, build fixed! |
| 08:41 |
|
wahanui |
Congratulations! |
| 08:41 |
|
koha-jenkins |
Project Koha_20.05_U20 build #29: FIXED in 52 min: https://jenkins.koha-community[…]oha_20.05_U20/29/ |
| 08:43 |
|
fridolin |
oh https://catalog.bywatersolutio[…]iblionumber=42639 |
| 08:43 |
|
fridolin |
looks broken |
| 08:52 |
|
|
inlibro joined #koha |
| 09:03 |
|
janncis |
hello, can someone please explain me how api items searching is done? |
| 09:18 |
|
Joubu |
same as biblios, what's your question exactly? |
| 09:25 |
|
Joubu |
fridolin: Salut Frido! About 25765, why: |
| 09:25 |
|
Joubu |
- <h3>All available funds[% IF LoginBranchname %] for [% LoginBranchname | html %][% END %]</h3> |
| 09:25 |
|
fridolin |
Bug 25765 |
| 09:25 |
|
Joubu |
+ <h3>All available funds</h3> |
| 09:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25765 normal, P5 - low, ---, fridolin.somers, Passed QA , Replace LoginBranchname and LoginBranchcode with use of Branches template plugin |
| 09:25 |
|
Joubu |
in acqui-home? |
| 09:26 |
|
Joubu |
sorry, it's in the commit message! |
| 09:27 |
|
fridolin |
oki i dont remember ;) |
| 09:28 |
|
Joubu |
I am not sure it's correct |
| 09:30 |
|
Joubu |
well maybe, I created a fund for another library and it's displayed |
| 09:31 |
|
fridolin |
ah ok In acqui/acqui-home.tt, I choose to remove a useless display of current branch and also because table of founds contains a filter on library. |
| 09:32 |
|
fridolin |
I'm quite a noob in acquisition |
| 09:49 |
|
huginn |
News from kohagit: Bug 5087: Add server-side check <http://git.koha-community.org/[…]de663f8d3f3a354be> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: DBIC schema changes <http://git.koha-community.org/[…]d896be516dc318743> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: Apply DB changes to kohastructure.sql <http://git.koha-community.org/[…]e790b4a9d7b6044fe> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: DBRev 20.06.00.015 <http://git.koha-community.org/[…]a59ee68f92dd54df9> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: DBRev 20.06.00.014 <http://git.koha-community.org/[…]9b1867ebdbd8d6a7f> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23796: DBRev 20.06.00.013 <http://git.koha-community.org/[…]2049608474e09fb15> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23795: DBRev 20.06.00.012 <http://git.koha-community.org/[…]2b614543724fefbbf> |
| 09:49 |
|
huginn |
News from kohagit: Bug 5087: DBRev 20.06.00.011 <http://git.koha-community.org/[…]e2454a30a9b5e0e04> |
| 09:49 |
|
huginn |
News from kohagit: Bug 25765: (QA follow-up) Use method directly in cleanborrowers <http://git.koha-community.org/[…]884620bf24e29068b> |
| 09:49 |
|
huginn |
News from kohagit: Bug 25765: (QA follow-up) Save a DB hit <http://git.koha-community.org/[…]e80fc6a038fa5ce51> |
| 09:49 |
|
huginn |
News from kohagit: Bug 5087: (QA follow-up) Fix leakage in opac-downloadshelf.pl <http://git.koha-community.org/[…]47cb87c5e51952cd2> |
| 09:49 |
|
huginn |
News from kohagit: Bug 5087: (QA follow-up) used_for deserves an index <http://git.koha-community.org/[…]9f962fa5166f15770> |
| 09:49 |
|
huginn |
News from kohagit: Bug 5087: (QA follow-up) Rename the attribute to fit later API usage <http://git.koha-community.org/[…]05044e4bd3bbfeecd> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: (follow-up) Enable OpacLoginInstructions in header <http://git.koha-community.org/[…]5659f553f39dc466b> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: (follow-up) Increase the size of opac_news.lang <http://git.koha-community.org/[…]76223e883deef9937> |
| 09:49 |
|
huginn |
News from kohagit: Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template... <http://git.koha-community.org/[…]7920e0fb3f290dfb4> |
| 09:49 |
|
huginn |
News from kohagit: Bug 25765: Add GetLoggedInBranchname method <http://git.koha-community.org/[…]0b808e875c6ea5814> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23797: Convert OpacLoginInstructions system preference to news block <http://git.koha-community.org/[…]8a93c5ecf3f5d9dbf> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23796: Convert OpacCustomSearch system preference to news block <http://git.koha-community.org/[…]06ccbabe31c45d1c7> |
| 09:49 |
|
huginn |
News from kohagit: Bug 23795: Convert opaccredits system preference to news block <http://git.koha-community.org/[…]374ba004f41198ed0> |
| 09:52 |
|
|
inlibro joined #koha |
| 10:17 |
|
huginn |
News from kohagit: Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' <http://git.koha-community.org/[…]72922ded77e9d5217> |
| 10:17 |
|
janncis |
in api where you search /items how to make it serch by book title |
| 10:17 |
|
janncis |
for example |
| 10:29 |
|
|
cait joined #koha |
| 10:30 |
|
koha-jenkins |
Project Koha_Master_D9 build #1389: SUCCESS in 40 min: https://jenkins.koha-community[…]a_Master_D9/1389/ |
| 10:31 |
|
|
vfernandes joined #koha |
| 10:31 |
|
vfernandes |
hi #koha |
| 10:34 |
|
koha-jenkins |
Project Koha_Master_D10 build #305: SUCCESS in 44 min: https://jenkins.koha-community[…]a_Master_D10/305/ |
| 10:36 |
|
koha-jenkins |
Yippee, build fixed! |
| 10:36 |
|
wahanui |
Congratulations! |
| 10:36 |
|
koha-jenkins |
Project Koha_Master_U20 build #44: FIXED in 47 min: https://jenkins.koha-community[…]ha_Master_U20/44/ |
| 10:38 |
|
|
khall joined #koha |
| 10:41 |
|
Joubu |
janncis: you don't think you can do that right now. You need to know the biblionumber of the bibliographic record |
| 10:41 |
|
Joubu |
I* |
| 10:42 |
|
vfernandes |
hi #koha |
| 10:42 |
|
janncis |
well this is bad then. More fun with perl :( |
| 10:42 |
|
vfernandes |
how I can force ES reindex for records with biblionumber greater than X? |
| 10:46 |
|
Joubu |
vfernandes: you cannot |
| 10:46 |
|
koha-jenkins |
Project Koha_Master_U18 build #843: SUCCESS in 56 min: https://jenkins.koha-community[…]a_Master_U18/843/ |
| 10:46 |
|
Joubu |
it's not implemented in rebuild_elasticsearch.pl |
| 10:47 |
|
Joubu |
please open a bug report |
| 10:47 |
|
Joubu |
vfernandes: maybe bug 20384 |
| 10:47 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20384 enhancement, P5 - low, ---, axel.amghar, Needs Signoff , Elasticsearch rebuild script improvements - options for indexing |
| 10:49 |
|
vfernandes |
thanks Joubu |
| 10:52 |
|
|
inlibro joined #koha |
| 10:53 |
|
ashimema |
erm.. is 'notransfer' means to do anything in the circ/returns.tt template.. I'm not seeing it referred to in any controller |
| 10:55 |
|
koha-jenkins |
Project Koha_Master_D11 build #42: STILL UNSTABLE in 1 hr 4 min: https://jenkins.koha-community[…]ha_Master_D11/42/ |
| 11:09 |
|
koha-jenkins |
Project Koha_Master_U16 build #25: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_Master_U16/25/ |
| 11:20 |
|
|
oleonard joined #koha |
| 11:20 |
|
oleonard |
Hi #koha |
| 11:26 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #372: SUCCESS in 51 min: https://jenkins.koha-community[…]aster_D9_My8/372/ |
| 11:26 |
|
oleonard |
@later tell tcohen https://classic.yarnpkg.com/en[…]oc-required-files |
| 11:26 |
|
huginn |
oleonard: The operation succeeded. |
| 11:27 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #348: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]9_MDB_Latest/348/ |
| 11:30 |
|
Joubu |
ashimema: if you click it it will (certainly) close the modal |
| 11:39 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #30: SUCCESS in 52 min: https://jenkins.koha-community[…]ster_D10_Deps/30/ |
| 11:41 |
|
|
bigbrovar joined #koha |
| 11:50 |
|
koha-jenkins |
Project Koha_Master_D9 build #1390: SUCCESS in 40 min: https://jenkins.koha-community[…]a_Master_D9/1390/ |
| 11:51 |
|
oleonard |
Joubu did you find the answer about the Koha News "blocktitle" parameter? |
| 11:53 |
|
|
inlibro joined #koha |
| 11:53 |
|
|
khall joined #koha |
| 11:57 |
|
ashimema |
it closes the modal yes Joubu, but it doesn't actually seem to trigger any action.. so it just leaves a transfer lurking in the system I believe |
| 11:58 |
|
koha-jenkins |
Project Koha_Master_U20 build #45: UNSTABLE in 1 hr 2 min: https://jenkins.koha-community[…]ha_Master_U20/45/ |
| 12:08 |
|
|
fridolin joined #koha |
| 12:10 |
|
koha-jenkins |
Project Koha_Master_D10 build #306: SUCCESS in 44 min: https://jenkins.koha-community[…]a_Master_D10/306/ |
| 12:12 |
|
Joubu |
ashimema: in my understand it's either "yes" and you transfer or "no" and it's a noop. But the transfer does not exist yet. |
| 12:12 |
|
Joubu |
(just reading the code, I did not test) |
| 12:15 |
|
koha-jenkins |
Project Koha_Master_U18 build #844: UNSTABLE in 47 min: https://jenkins.koha-community[…]a_Master_U18/844/ |
| 12:16 |
|
cait2 |
thx oleonard++ :) |
| 12:17 |
|
oleonard |
:) |
| 12:18 |
|
janncis |
in rest/v1/items.pm is function list, I fial to understand how it could search anything by $items_set can anyone explain me how it works?\ |
| 12:22 |
|
tcohen |
janncis take a look at the objects.search helper, defined in Koha::REST::Plugins::Objects |
| 12:24 |
|
|
gveranis joined #koha |
| 12:24 |
|
gveranis |
hi #koha ! |
| 12:25 |
|
tcohen |
janncis it takes a resultset, and acts on top of it |
| 12:25 |
|
gveranis |
I would like to ask if someone knows if we can close authority Z3950 server of Koha |
| 12:25 |
|
tcohen |
close? |
| 12:25 |
|
gveranis |
not send back data |
| 12:26 |
|
gveranis |
we open public z3950 server for biblios , but also they can search to our authorities |
| 12:26 |
|
gveranis |
it is feasible to stop it ? without close the publicserver of Z3950 ? |
| 12:26 |
|
caroline |
it would be in the configuration file |
| 12:27 |
|
gveranis |
can you please tell me which file ? |
| 12:27 |
|
wahanui |
i guess which file is it? |
| 12:27 |
|
caroline |
You should have a line for biblios and a line for authorities, you can comment the line for authorities |
| 12:27 |
|
gveranis |
ok but which file? koha_conf ? |
| 12:27 |
|
caroline |
yes |
| 12:27 |
|
gveranis |
the authorityserver ? |
| 12:28 |
|
caroline |
yes |
| 12:28 |
|
tcohen |
publicserver |
| 12:28 |
|
tcohen |
how are you exposing your Z39.50 server ? |
| 12:28 |
|
caroline |
there is biblioserver and authorityserver |
| 12:28 |
|
gveranis |
though publicserver |
| 12:28 |
|
gveranis |
*through |
| 12:29 |
|
gveranis |
ok , If I comment authorityserver then they cannot search on them ? |
| 12:29 |
|
|
bigbrovar joined #koha |
| 12:31 |
|
caroline |
I would assume so |
| 12:31 |
|
gveranis |
so, if i comment that line : <listen id="authorityserver" >unix:/var/run/koha/libspa/authoritysocket</listen> |
| 12:31 |
|
gveranis |
then it will stop ? |
| 12:31 |
|
janncis |
tcohen I will refrase it then, how it gets its result set and how I can search in it lets say by title or part of it. I see params and atributes, but they say nothing on how it searches in it. Does param is colom name and atribute its value? |
| 12:31 |
|
koha-jenkins |
Project Koha_Master_D11 build #43: STILL UNSTABLE in 52 min: https://jenkins.koha-community[…]ha_Master_D11/43/ |
| 12:32 |
|
tcohen |
that question deserves 2 hr webinar he |
| 12:32 |
|
tcohen |
items, right? |
| 12:33 |
|
tcohen |
the items route has very limited capabilities at the moment, you can only search by barcode |
| 12:33 |
|
tcohen |
which is called 'external_id' on the API |
| 12:33 |
|
Joubu |
tcohen: janncis asked this "morning" how to list items from a biblio's title |
| 12:33 |
|
Joubu |
those routes are very limited |
| 12:33 |
|
Joubu |
it's not possible to search by biblio's attributes apparently |
| 12:34 |
|
tcohen |
there's no route to list biblios |
| 12:34 |
|
janncis |
Yee Im trying to understand them and think of way to get searching done by them |
| 12:34 |
|
tcohen |
you can only get a biblio if you know the id |
| 12:34 |
|
tcohen |
the 'future' of the API searching |
| 12:34 |
|
tcohen |
can be seen |
| 12:34 |
|
Joubu |
but, even with the biblionumber it seems that we cannot list items for a given biblio |
| 12:34 |
|
tcohen |
on the cities route |
| 12:34 |
|
tcohen |
and the 'q' param |
| 12:35 |
|
janncis |
I dont mind making new api route |
| 12:36 |
|
tcohen |
there's a wiki page: https://wiki.koha-community.or[…]iki/REST_api_RFCs |
| 12:36 |
|
tcohen |
there you propose a route |
| 12:36 |
|
tcohen |
it gets voted |
| 12:36 |
|
tcohen |
and you need to get the RM attention |
| 12:37 |
|
tcohen |
there's a proposal for getting some biblio's items |
| 12:37 |
|
tcohen |
https://wiki.koha-community.or[…]tems_endpoint_RFC |
| 12:38 |
|
tcohen |
if you want to implement that, you have my full support |
| 12:38 |
|
tcohen |
count on me |
| 12:38 |
|
tcohen |
seems pretty trivial to do |
| 12:39 |
|
|
Marie-Luce joined #koha |
| 12:40 |
|
janncis |
Im making route, right now it just do the same and returns biblio by id, I could do: my $biblio = Koha::Biblios->find( |
| 12:40 |
|
janncis |
{ title => $c->validation->param('title')}, |
| 12:40 |
|
janncis |
{prefetch => ['metadata']}); |
| 12:41 |
|
janncis |
but it doesnt feel right, nor it will find by partial name |
| 12:42 |
|
|
bigbrovar joined #koha |
| 12:43 |
|
tcohen |
the biblios route is a bit complex in the sense that it depends on the Accept header |
| 12:43 |
|
tcohen |
what the resource representation is |
| 12:43 |
|
tcohen |
if you want to add searching capabilities, you should add the q param as the one I pointed you at |
| 12:44 |
|
tcohen |
and you shouldn't handle it manually |
| 12:44 |
|
tcohen |
that's solved |
| 12:44 |
|
tcohen |
objects.search will read the query parameters and act accordingly |
| 12:44 |
|
tcohen |
GET /biblios?q=<query> |
| 12:45 |
|
tcohen |
where <query> is a stringified and URI encoded JSON structure representing a DBIC query on biblios+biblioitems attributes |
| 12:45 |
|
tcohen |
you picked a not so simple example |
| 12:48 |
|
janncis |
the things my boss wants from koha isnt simple, and this is fairly simple comparing what he wants out of it |
| 12:53 |
|
|
inlibro joined #koha |
| 12:53 |
|
tcohen |
good luck, janncis |
| 13:01 |
|
|
khall_ joined #koha |
| 13:11 |
|
|
alex_a_ joined #koha |
| 13:27 |
|
|
bdonnahue1 joined #koha |
| 13:42 |
|
ashimema |
remind me of our policy on db column name consistency |
| 13:43 |
|
Joubu |
There_isNoCon_sistency! |
| 13:43 |
|
caroline |
lol! |
| 13:44 |
|
caroline |
maybe this? https://wiki.koha-community.or[…]aming_conventions |
| 13:44 |
|
Joubu |
for a date, should end with _on |
| 13:44 |
|
Joubu |
or _date, apparently |
| 13:44 |
|
caroline |
if above link is not good, let me know and I'll add a warning saying this is not accurate |
| 13:46 |
|
caroline |
I don't know for you, but I feel like no column should ever be called just "id", but somethingid, so that it's the same in all tables |
| 13:53 |
|
|
inlibro joined #koha |
| 13:56 |
|
ashimema |
I wrote that guideline I think |
| 13:56 |
|
ashimema |
oh.. maybe not.. maybe I wrote the corresponding api one |
| 13:57 |
|
ashimema |
I prefer _on.. but don't really like inconsistency within a table |
| 13:57 |
|
ashimema |
but I also don't want to update other fields in the table |
| 13:57 |
|
ashimema |
grr |
| 13:57 |
|
ashimema |
as for 'id' |
| 13:57 |
|
ashimema |
I like every table to have a consistently named 'id' column and then for foreign keys to have `table_id` |
| 13:58 |
|
ashimema |
I don't like `somthingid` caroline ;) |
| 13:58 |
|
|
bigbrovar joined #koha |
| 13:58 |
|
ashimema |
maybe that's because I know how DBIC dump will name things and recomments db's to be |
| 13:58 |
|
caroline |
it just makes queries easier b/c you can use USING (somethingid) if the name is the same everywhere |
| 13:59 |
|
ashimema |
so how would you name foreign keys |
| 13:59 |
|
ashimema |
something_somthingid |
| 14:00 |
|
caroline |
I guess, I don't ever create tables, so I wouldn't know |
| 14:00 |
|
caroline |
but currently that's the case? b/c id is not as widely used as somethingid |
| 14:00 |
|
caroline |
afaik |
| 14:03 |
|
ashimema |
koha is just a mess ;) |
| 14:04 |
|
caroline |
I guess there is no consensus, so I'll mark the wiki page as... not inaccurate... but I'll find a word |
| 14:04 |
|
oleonard |
ashimema: We're bailing out this leaky dinghy as fast as we can! |
| 14:43 |
|
ashimema |
lol |
| 14:44 |
|
* ashimema |
looks at one of his bug trees and wonders whether to merge them all into one monster bug for easier testing or whether to leave them as a tree of related bugs for which most of them the test is 'run the unit tests' |
| 14:46 |
|
|
margaret joined #koha |
| 14:48 |
|
|
AndrewFH joined #koha |
| 14:53 |
|
|
inlibro joined #koha |
| 14:54 |
|
|
lukeG1 joined #koha |
| 15:00 |
|
|
bdonnahue1 joined #koha |
| 15:03 |
|
|
rhamby joined #koha |
| 15:03 |
|
|
phasefx_ joined #koha |
| 15:09 |
|
|
bigbrovar joined #koha |
| 15:24 |
|
|
alex_a joined #koha |
| 15:28 |
|
|
alex_a__ joined #koha |
| 15:31 |
|
|
fridolin left #koha |
| 15:43 |
|
|
bigbrovar joined #koha |
| 15:52 |
|
ashimema |
Bug 23091 |
| 15:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23091 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Add options to charge new or restore forgiven overdues when a lost item is returned |
| 15:53 |
|
ashimema |
Bug 23092 |
| 15:53 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23092 enhancement, P5 - low, ---, martin.renvoize, Passed QA , Transfers should record 'requested' as well as 'sent' and 'arrived' dates |
| 15:53 |
|
|
inlibro joined #koha |
| 16:26 |
|
reiveune |
bye |
| 16:26 |
|
|
reiveune left #koha |
| 16:31 |
|
|
khall joined #koha |
| 16:45 |
|
|
koha-jenkins joined #koha |
| 16:53 |
|
|
inlibro joined #koha |
| 16:55 |
|
|
khall_ joined #koha |
| 17:54 |
|
|
inlibro joined #koha |
| 18:06 |
|
|
bigbrovar joined #koha |
| 18:21 |
|
tuxayo |
ashimema: «wonders whether to merge them all into one monster bug for easier testing or whether to leave them as a tree of related bugs for which most of them the test is 'run the unit tests'» |
| 18:21 |
|
tuxayo |
Both approaches give the impression of have the advantage for testing. |
| 18:31 |
|
|
cait2 left #koha |
| 18:36 |
|
|
bigbrovar joined #koha |
| 18:54 |
|
|
inlibro joined #koha |
| 19:22 |
|
|
cait joined #koha |
| 19:26 |
|
|
cait joined #koha |
| 19:43 |
|
|
kathryn joined #koha |
| 19:49 |
|
|
lukeG1 joined #koha |
| 19:49 |
|
lukeG1 |
oleonard++ |
| 19:49 |
|
lukeG1 |
thanks for the follow ups on 22660! |
| 19:53 |
|
oleonard |
You bet |
| 19:54 |
|
|
inlibro joined #koha |
| 20:41 |
|
|
bigbrovar joined #koha |
| 20:44 |
|
caroline |
when using anonymouspatron, do you have to create that anonymous patron? |
| 20:45 |
|
caroline |
I noticed 0 doesnt seem to work even though that is the default value of the pref |
| 20:45 |
|
cait |
yes |
| 20:45 |
|
cait |
:) |
| 20:46 |
|
cait |
i think if you don't have it it evens shows a warning on system information tab. but not totally sure |
| 20:46 |
|
caroline |
I don't think so... I added 666 as anonymouspatron and I don't have a 666 patron, and there is no warning |
| 20:46 |
|
caroline |
There is only a warning if it's 0 or empty |
| 20:47 |
|
caroline |
So when you create a new Koha install, do you automatically create an anonymous patron along with an admin? |
| 20:48 |
|
caroline |
they could be patrons 1 and 2 :) |
| 20:50 |
|
cait |
yep |
| 20:50 |
|
cait |
we have an sql script to add us and the anon one |
| 20:51 |
|
caroline |
with set_password? |
| 20:51 |
|
cait |
set_password? |
| 20:52 |
|
caroline |
in misc/admin |
| 20:52 |
|
cait |
ah no, just sql |
| 20:52 |
|
cait |
we are cheating |
| 20:52 |
|
caroline |
that's what I use to create my user |
| 20:53 |
|
caroline |
and their name is "anonymous"? |
| 20:53 |
|
cait |
in German, but yes |
| 20:53 |
|
cait |
Anonymer Benutzer |
| 20:53 |
|
caroline |
ok good to know |
| 20:54 |
|
cait |
we sometimes throw a "dont delete me" in somewhere |
| 20:54 |
|
cait |
but it hasn't happened so far i thnk |
| 20:54 |
|
aleisha |
hello |
| 20:54 |
|
|
inlibro joined #koha |
| 20:54 |
|
cait |
hi aleisha :) |
| 20:55 |
|
aleisha |
hi cait |
| 21:02 |
|
koha-jenkins |
Yippee, build fixed! |
| 21:02 |
|
wahanui |
Congratulations! |
| 21:02 |
|
koha-jenkins |
Project Koha_19.05_D9 build #264: FIXED in 37 min: https://jenkins.koha-community[…]oha_19.05_D9/264/ |
| 21:04 |
|
|
alexbuckley joined #koha |
| 21:05 |
|
koha-jenkins |
Project Koha_19.05_U18 build #267: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_19.05_U18/267/ |
| 21:14 |
|
koha-jenkins |
Project Koha_19.05_D9_MDB10.3 build #13: SUCCESS in 44 min: https://jenkins.koha-community[…]05_D9_MDB10.3/13/ |
| 21:14 |
|
|
hayley joined #koha |
| 21:54 |
|
|
inlibro joined #koha |
| 22:19 |
|
tuxayo |
caroline: around? |
| 22:52 |
|
koha-jenkins |
Project Koha_19.05_D9 build #265: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_19.05_D9/265/ |
| 22:55 |
|
|
inlibro joined #koha |
| 22:55 |
|
koha-jenkins |
Project Koha_19.05_U18 build #268: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_19.05_U18/268/ |
| 22:58 |
|
koha-jenkins |
Project Koha_19.05_D9_MDB10.3 build #14: SUCCESS in 44 min: https://jenkins.koha-community[…]05_D9_MDB10.3/14/ |
| 23:11 |
|
gmcharlt |
taking the wiki/APT/perldoc server down for about an hour for upgrades |
| 23:14 |
|
dcook |
Whoa haven't seen gmcharlt in ages |
| 23:14 |
|
dcook |
Good to know |
| 23:18 |
|
* cait |
waves |
| 23:29 |
|
koha-jenkins |
Project Koha_19.05_D9 build #266: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_19.05_D9/266/ |
| 23:32 |
|
tuxayo |
gmcharlt++ |
| 23:32 |
|
tuxayo |
:D |
| 23:33 |
|
koha-jenkins |
Project Koha_19.05_U18 build #269: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_19.05_U18/269/ |
| 23:43 |
|
koha-jenkins |
Project Koha_19.05_D9_MDB10.3 build #15: SUCCESS in 44 min: https://jenkins.koha-community[…]05_D9_MDB10.3/15/ |
| 23:55 |
|
|
inlibro joined #koha |
| 23:55 |
|
dcook |
Looking forward to looking more into Bug 26055 |
| 23:55 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26055 normal, P5 - low, ---, dcook, NEW , Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records |
| 23:55 |
|
dcook |
hey cait |
| 23:55 |
|
dcook |
and tuxayo :D |
| 23:56 |
|
dcook |
Of course, I'm busy for the next 3.5 hours.. |
| 23:56 |
|
dcook |
Too many things I want to do heh |
| 23:58 |
|
tuxayo |
I have yet to see Rancor I think ^^" |
