| Time |
S |
Nick |
Message |
| 00:01 |
|
|
khall joined #koha |
| 00:17 |
|
|
khall joined #koha |
| 00:19 |
|
|
bdonnahue1 joined #koha |
| 00:20 |
|
|
khall_ joined #koha |
| 00:25 |
|
|
inlibro joined #koha |
| 01:01 |
|
|
bob joined #koha |
| 01:22 |
|
|
kathryn joined #koha |
| 01:22 |
|
|
khall joined #koha |
| 01:24 |
|
|
hayleymapley_ joined #koha |
| 01:26 |
|
|
inlibro joined #koha |
| 01:58 |
|
|
hayleymapley__ joined #koha |
| 01:58 |
|
|
kathryn_ joined #koha |
| 02:26 |
|
|
inlibro joined #koha |
| 02:30 |
|
|
hayleymapley_ joined #koha |
| 02:51 |
|
|
hayleymapley__ joined #koha |
| 02:52 |
|
koha-jenkins |
Project Koha_19.11_D9 build #206: UNSTABLE in 41 min: https://jenkins.koha-community[…]oha_19.11_D9/206/ |
| 02:54 |
|
koha-jenkins |
Yippee, build fixed! |
| 02:54 |
|
wahanui |
Congratulations! |
| 02:54 |
|
koha-jenkins |
Project Koha_19.11_D10 build #39: FIXED in 41 min: https://jenkins.koha-community[…]oha_19.11_D10/39/ |
| 02:58 |
|
koha-jenkins |
Project Koha_19.11_U20 build #15: STILL UNSTABLE in 47 min: https://jenkins.koha-community[…]oha_19.11_U20/15/ |
| 03:05 |
|
koha-jenkins |
Project Koha_19.11_U18 build #202: SUCCESS in 50 min: https://jenkins.koha-community[…]ha_19.11_U18/202/ |
| 03:26 |
|
|
inlibro joined #koha |
| 03:27 |
|
koha-jenkins |
Project Koha_19.11_D10 build #40: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_19.11_D10/40/ |
| 03:33 |
|
koha-jenkins |
Yippee, build fixed! |
| 03:33 |
|
wahanui |
Congratulations! |
| 03:33 |
|
koha-jenkins |
Project Koha_19.11_D8 build #209: FIXED in 40 min: https://jenkins.koha-community[…]oha_19.11_D8/209/ |
| 03:55 |
|
koha-jenkins |
Project Koha_19.11_U18 build #203: UNSTABLE in 50 min: https://jenkins.koha-community[…]ha_19.11_U18/203/ |
| 03:56 |
|
|
cait joined #koha |
| 04:08 |
|
koha-jenkins |
Project Koha_19.11_D8 build #210: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_19.11_D8/210/ |
| 04:09 |
|
|
bob joined #koha |
| 04:20 |
|
|
did joined #koha |
| 04:25 |
|
|
did joined #koha |
| 04:26 |
|
|
inlibro joined #koha |
| 05:26 |
|
|
inlibro joined #koha |
| 06:06 |
|
|
lmstrand joined #koha |
| 06:09 |
|
|
marcelr joined #koha |
| 06:09 |
|
marcelr |
hi #koha |
| 06:12 |
|
|
cait joined #koha |
| 06:14 |
|
|
cait1 joined #koha |
| 06:18 |
|
|
cait2 joined #koha |
| 06:22 |
|
cait2 |
good morning #koha |
| 06:26 |
|
|
kohaputti joined #koha |
| 06:27 |
|
|
inlibro joined #koha |
| 06:27 |
|
|
reiveune joined #koha |
| 06:28 |
|
reiveune |
hello |
| 06:28 |
|
wahanui |
salut, reiveune |
| 06:29 |
|
Guest3415 |
hmm Giest3415 |
| 06:29 |
|
Guest3415 |
u |
| 06:32 |
|
|
kohaputti_ joined #koha |
| 06:33 |
|
|
did joined #koha |
| 06:34 |
|
|
marcelr joined #koha |
| 06:53 |
|
|
fridolin joined #koha |
| 06:54 |
|
|
alex_a joined #koha |
| 06:55 |
|
alex_a |
Bonjour |
| 07:01 |
|
|
sophie_m joined #koha |
| 07:14 |
|
|
Nemo_bis joined #koha |
| 07:27 |
|
|
inlibro joined #koha |
| 07:32 |
|
|
bob joined #koha |
| 07:42 |
|
|
davidnind joined #koha |
| 07:53 |
|
|
enkidu joined #koha |
| 07:57 |
|
|
fridolin joined #koha |
| 08:27 |
|
|
inlibro joined #koha |
| 08:53 |
|
|
marcelr joined #koha |
| 09:27 |
|
|
inlibro joined #koha |
| 09:33 |
|
|
vfernandes joined #koha |
| 09:42 |
|
|
sophie_m1 joined #koha |
| 09:49 |
|
ashimema |
mornin' |
| 10:11 |
|
|
fridolin left #koha |
| 10:27 |
|
|
inlibro joined #koha |
| 11:06 |
|
|
cait joined #koha |
| 11:25 |
|
|
davidnind left #koha |
| 11:25 |
|
|
cait joined #koha |
| 11:27 |
|
|
inlibro joined #koha |
| 11:32 |
|
|
khall joined #koha |
| 11:39 |
|
|
khall_ joined #koha |
| 11:45 |
|
oleonard |
Hi all |
| 11:47 |
|
|
khall joined #koha |
| 12:22 |
|
tcohen |
kia ora #koha |
| 12:28 |
|
|
inlibro joined #koha |
| 12:49 |
|
ashimema |
did I imagine a bug updating jQuery on the opac |
| 12:49 |
|
oleonard |
Not very recently ashimema |
| 12:50 |
|
oleonard |
We're at 3.4.1, current is 3.5.1 |
| 12:50 |
|
ashimema |
yeah.. |
| 12:50 |
|
ashimema |
I thought I'd spotted one to update to 3.5.1 |
| 12:50 |
|
ashimema |
no worries |
| 12:51 |
|
oleonard |
Not unless I missed it |
| 12:53 |
|
|
Marie-Luce joined #koha |
| 12:55 |
|
cait2 |
was it bootstap? we are updating? |
| 12:57 |
|
tcohen |
yes! |
| 13:00 |
|
ashimema |
I did see bootstrap.. I thought I also saw jQuery. |
| 13:00 |
|
ashimema |
we just got a pen test report in and the first things they highlight are all our outdated dependancies.. loads of them :( |
| 13:01 |
|
oleonard |
ashimema: share? |
| 13:03 |
|
ashimema |
it's not a great report.. doesn't really go into specifics so much as just says "you're out of date" |
| 13:04 |
|
oleonard |
...which may or may not be a problem if there aren't security fixes |
| 13:04 |
|
|
kohaputti joined #koha |
| 13:05 |
|
ashimema |
jQuery 3.4.1 -> 3.5.1, jQeury Migrate 3.1.0 -> 3.3.1, Bootstrap 2.3.1 -> 4.5.0, Fontfaceobserver 2.0.13 -> 2.1.0, Emoji-picker 1.1.5 is known vulnerable, jQuery.cookie 1.4.1 is known vulnerable, Enquire.js 2.0.2 -> 2.1.6, jQuery.flipster 1.1.2 -> 1.1.4, |
| 13:05 |
|
ashimema |
that's the full list |
| 13:06 |
|
oleonard |
Upgrading Emoji-picker should be simple I hope. We're already trying to replace jQuery.cookie |
| 13:06 |
|
ashimema |
looks like they just ran this: https://www.immuniweb.com/free/ |
| 13:06 |
|
ashimema |
so easy enough to point it at a demo koha somewhere and get a report by the looks |
| 13:07 |
|
kohaputti |
ashimema, care to add quick follow up for fixing tools/newHolidays.pl in https://bugs.koha-community.or[…]ent.cgi?id=105968 ? |
| 13:07 |
|
kohaputti |
I could qa today |
| 13:08 |
|
ashimema |
er.. |
| 13:08 |
|
ashimema |
I'll take a quick look now.. let me just stash my current work |
| 13:09 |
|
kohaputti |
also, wondering if we should somehow mark the sign-off somehow to those commit messages |
| 13:10 |
|
ashimema |
Emma's SO you mean? |
| 13:10 |
|
ashimema |
I had.. but it seems in a rebase I lost it.. |
| 13:11 |
|
ashimema |
I'll try restoring them in a moment ;) |
| 13:11 |
|
kohaputti |
you commented "Tested and signed off by Heart of England NHS Trust." |
| 13:13 |
|
kohaputti |
ashimema, when I started reading the commits first I was first like oh noe, more hacky sql added and then you had the refactoring commit in the end which save the whole thing :) |
| 13:14 |
|
oleonard |
No new version of Emoji-picker (now or ever, probably). Also no clue where any vulnerability is documented |
| 13:15 |
|
ashimema |
I think it's inside jQuery |
| 13:16 |
|
oleonard |
? |
| 13:16 |
|
ashimema |
https://snipboard.io/RfzNe4.jpg |
| 13:17 |
|
ashimema |
that's all we get in the report.. and the links aren't helpful either |
| 13:17 |
|
ashimema |
kohaputti, I tried to do it in smaller bugs but Joubu wanted it as one bigger bug |
| 13:18 |
|
ashimema |
and I tried to break it down into small steps so you could see the mental process |
| 13:22 |
|
ashimema |
kohaputti, what do you mean by a followup to fix newHolidays? |
| 13:22 |
|
kohaputti |
it removes the cache clearing |
| 13:22 |
|
ashimema |
by design yes |
| 13:22 |
|
ashimema |
it's code cleanup |
| 13:22 |
|
kohaputti |
ok, then I clean up the import too :) |
| 13:23 |
|
kohaputti |
Let me dig deeper in the code why it's not needed |
| 13:23 |
|
ashimema |
unless I missed something each and every call inside add_holiday already clears the cache internally so there's no need to clear it here |
| 13:23 |
|
ashimema |
I might well have missed something of course.. in which case great catch ;) |
| 13:28 |
|
|
inlibro joined #koha |
| 13:28 |
|
ashimema |
pushed up new patches with the SO line restored and my own SO on kidclamps followup |
| 13:34 |
|
kohaputti |
ashimema, if there a follow-up bug report coming to refactor these to koha objects? :P Would make a lot easier to spot cache bugs |
| 13:35 |
|
|
bdonnahue1 joined #koha |
| 13:37 |
|
kohaputti |
ashimema, now there are two patches with the title "Handle holiday and exception on" |
| 13:37 |
|
kohaputti |
both with different contents |
| 13:38 |
|
kohaputti |
I assume the new one you pushed is the correct one and the one from nick can be obsoleted? |
| 13:43 |
|
kohaputti |
ah, the difference seem to be only with whitespace |
| 13:44 |
|
ashimema |
odd |
| 13:44 |
|
ashimema |
I didn't deliberately do anything with whitespace.. maybe our gits are setup differently |
| 13:45 |
|
kohaputti |
yup, the koha wiki had some instructions to add default git config that removes whitespace if I remember correctly |
| 13:45 |
|
ashimema |
I believe I have that in mine. |
| 13:46 |
|
kohaputti |
I obsoleted the earlier one now, will continue forward with qa and adding one tiny follow-up |
| 13:48 |
|
ashimema |
ta |
| 13:48 |
|
kohaputti |
actually... The oneline difference in whitespace was there intentionally |
| 13:48 |
|
kohaputti |
nick put in the commit message it fixes qa tool error |
| 13:48 |
|
ashimema |
ah.. that's annoying |
| 13:48 |
|
ashimema |
so my git autofixed out a deliberate fix |
| 13:48 |
|
ashimema |
hmm |
| 13:48 |
|
kohaputti |
:D |
| 13:50 |
|
ashimema |
and yes.. it would be great to refactor this into being Koha::Objects.. I just didn't have enough time to do that on top here. ;) |
| 13:51 |
|
kohaputti |
I'm attaching the commit from nick again |
| 13:51 |
|
kohaputti |
with the whitespace |
| 13:52 |
|
|
khall joined #koha |
| 13:53 |
|
kohaputti |
strange that I don't get the qa-tool error |
| 13:53 |
|
kohaputti |
maybe it depends on the os version running |
| 14:01 |
|
oleonard |
Bug 26005 is a trivial fix for a bad error. If anyone can give it a quick look I'd be grateful. |
| 14:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26005 critical, P5 - low, ---, oleonard, Needs Signoff , OPAC cart display fails with error |
| 14:04 |
|
|
sophie_m joined #koha |
| 14:06 |
|
kohaputti |
ashimema, https://wiki.koha-community.or[…]lines#Indentation if you have that git config then git doesn't remove the trailing newline in the end of file |
| 14:07 |
|
|
khall joined #koha |
| 14:07 |
|
ashimema |
this is indeed what's in my gitconfig |
| 14:08 |
|
ashimema |
just double checked |
| 14:08 |
|
kohaputti |
strange, since when I added this to my git config the git commit didn't remove anymore the blank line |
| 14:08 |
|
kohaputti |
if I didn't have this it removed |
| 14:08 |
|
ashimema |
interesting |
| 14:08 |
|
kohaputti |
maybe you have conflicting global and local git config? |
| 14:08 |
|
ashimema |
hmm |
| 14:09 |
|
kohaputti |
did you check .git/config in the koha repo? |
| 14:09 |
|
ashimema |
yup |
| 14:09 |
|
kohaputti |
I would guess that takes precedence over ~/.gitconfig |
| 14:09 |
|
ashimema |
not in there |
| 14:09 |
|
kohaputti |
so that's the issue? |
| 14:10 |
|
kohaputti |
if you have core there but no this line then it probably uses git defaults |
| 14:10 |
|
ashimema |
I would have expected the global one to have been used |
| 14:10 |
|
kohaputti |
do you have [core] in the koha git repo config? |
| 14:11 |
|
ashimema |
yup |
| 14:11 |
|
ashimema |
that might be it |
| 14:11 |
|
ashimema |
I'll add it just in case |
| 14:11 |
|
ashimema |
but.. I thought the behaviour was to fall back to global .gitconfig before falling back to defaults |
| 14:12 |
|
kohaputti |
ashimema, yup, anyway, the patches are missing test plan, what things in addition to unit tests should be done? Just to get general idea |
| 14:12 |
|
ashimema |
so I'm surprised |
| 14:12 |
|
ashimema |
hmm.. |
| 14:12 |
|
kohaputti |
add single holidays I guess |
| 14:12 |
|
kohaputti |
:D |
| 14:12 |
|
kohaputti |
and check caches |
| 14:12 |
|
ashimema |
updating holidays (to check the caches get flushed), issuing and returning (to check the holidays are taken account of) |
| 14:13 |
|
ashimema |
setting the config to 'useCalendar' first of course ;) |
| 14:17 |
|
kohaputti |
ashimema, hmm, if I type a long single holiday name it doesn't get save |
| 14:18 |
|
kohaputti |
"sfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfadsfad" |
| 14:18 |
|
cait2 |
cat? |
| 14:18 |
|
kohaputti |
ashimema, FQA? :D |
| 14:18 |
|
ashimema |
fun.. |
| 14:18 |
|
kohaputti |
maybe it was broken before already |
| 14:18 |
|
cait2 |
my guess would be it was |
| 14:18 |
|
ashimema |
I've never tried to be honest |
| 14:19 |
|
cait2 |
the calendar code allows some entries that don't work |
| 14:19 |
|
cait2 |
like you can add a range end date when you don't use a range option and the like |
| 14:19 |
|
cait2 |
room for improvement |
| 14:19 |
|
ashimema |
Yeah.. I reckon it was probably broken before and should be it's own bug.. but if I introduced it here I should fix it here. |
| 14:19 |
|
kohaputti |
I will test with master |
| 14:20 |
|
kohaputti |
yeah, it has been broken before |
| 14:23 |
|
ashimema |
:) |
| 14:23 |
|
* ashimema |
currently has his sleeves rolled up and is deep in Circulation code.. |
| 14:24 |
|
ashimema |
I feel like MarkLostItemAsReturned isn't working in all cases :( |
| 14:28 |
|
|
inlibro joined #koha |
| 14:35 |
|
reiveune |
bye |
| 14:35 |
|
|
reiveune left #koha |
| 14:47 |
|
|
koha-jenkins joined #koha |
| 14:48 |
|
* oleonard |
should not be patching the OPAC while Bug 20168 is waiting, but is a dummy |
| 14:49 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20168 enhancement, P5 - low, ---, oleonard, Needs Signoff , Update of the OPAC bootstrap template to bootstrap v4 |
| 14:49 |
|
kohaputti |
ashimema, libdatetime-set-perl debian dependency can be removed too? |
| 14:49 |
|
kohaputti |
Wondering if my QA powers allow me to just push such a patch, it all looks okay to me but would like someone to sign-off such a patch |
| 14:50 |
|
koha-jenkins |
Project Koha_Master_D11 build #30: FAILURE in 8.3 sec: https://jenkins.koha-community[…]ha_Master_D11/30/ |
| 14:51 |
|
koha-jenkins |
Project Koha_Master_D11 build #31: STILL FAILING in 0.73 sec: https://jenkins.koha-community[…]ha_Master_D11/31/ |
| 14:56 |
|
koha-jenkins |
Project Koha_Master_D11 build #32: STILL FAILING in 0.78 sec: https://jenkins.koha-community[…]ha_Master_D11/32/ |
| 15:00 |
|
kohaputti |
well, it's submitted now to bugzilla |
| 15:06 |
|
ashimema |
erm.. did I not remove the libdatetime-set-perl dependancy? |
| 15:07 |
|
ashimema |
ah.. no you remove that from the cpanfile.. then a script catches it for the debian.control file I believe |
| 15:25 |
|
* ashimema |
is happy after a seeing a couple of his more evil bugs moving forward today.. thanks guys :) |
| 15:28 |
|
|
inlibro joined #koha |
| 15:41 |
|
|
margaret joined #koha |
| 15:53 |
|
|
fridolin joined #koha |
| 16:06 |
|
|
fridolin left #koha |
| 16:12 |
|
koha-jenkins |
Project Koha_Master_D11 build #33: NOW UNSTABLE in 1 hr 10 min: https://jenkins.koha-community[…]ha_Master_D11/33/ |
| 16:28 |
|
|
inlibro joined #koha |
| 16:41 |
|
|
khall joined #koha |
| 16:49 |
|
|
sophie_m joined #koha |
| 17:28 |
|
|
inlibro joined #koha |
| 17:43 |
|
|
koha-jenkins joined #koha |
| 17:55 |
|
|
khall joined #koha |
| 18:04 |
|
|
JesseM joined #koha |
| 18:14 |
|
|
cait2 left #koha |
| 18:15 |
|
|
khall joined #koha |
| 18:24 |
|
tcohen |
oleonard-away minor rebase issues on your branch |
| 18:24 |
|
tcohen |
(bootstrap v4) |
| 18:24 |
|
* oleonard |
isn't surprised... |
| 18:24 |
|
tcohen |
datatables.js :-D |
| 18:25 |
|
tcohen |
oleonard do you think the nodejs version in KTD might be a reason for problems? |
| 18:25 |
|
tcohen |
it seems way outdated |
| 18:26 |
|
oleonard |
No idea, I didn't get very far in my investigation before I was distracted by shiny things. |
| 18:26 |
|
tcohen |
hehe |
| 18:26 |
|
tcohen |
been there |
| 18:26 |
|
tcohen |
am there |
| 18:26 |
|
tcohen |
:-D |
| 18:29 |
|
|
inlibro joined #koha |
| 18:29 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:29 |
|
wahanui |
Congratulations! |
| 18:29 |
|
koha-jenkins |
Project Koha_20.05_D9 build #33: FIXED in 42 min: https://jenkins.koha-community[…]Koha_20.05_D9/33/ |
| 18:37 |
|
|
khall joined #koha |
| 18:38 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:38 |
|
wahanui |
Congratulations! |
| 18:38 |
|
koha-jenkins |
Project Koha_20.05_D9_My8 build #25: FIXED in 51 min: https://jenkins.koha-community[…]_20.05_D9_My8/25/ |
| 18:41 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:41 |
|
wahanui |
Congratulations! |
| 18:41 |
|
koha-jenkins |
Project Koha_20.05_D10 build #31: FIXED in 51 min: https://jenkins.koha-community[…]oha_20.05_D10/31/ |
| 18:41 |
|
tcohen |
20.05++ |
| 18:45 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:45 |
|
wahanui |
Congratulations! |
| 18:45 |
|
koha-jenkins |
Project Koha_20.05_U16 build #23: FIXED in 57 min: https://jenkins.koha-community[…]oha_20.05_U16/23/ |
| 18:52 |
|
|
cait joined #koha |
| 18:58 |
|
|
enkidu joined #koha |
| 18:59 |
|
koha-jenkins |
Yippee, build fixed! |
| 18:59 |
|
wahanui |
Congratulations! |
| 18:59 |
|
koha-jenkins |
Project Koha_20.05_U20 build #22: FIXED in 1 hr 9 min: https://jenkins.koha-community[…]oha_20.05_U20/22/ |
| 19:09 |
|
koha-jenkins |
Yippee, build fixed! |
| 19:09 |
|
wahanui |
Congratulations! |
| 19:09 |
|
koha-jenkins |
Project Koha_20.05_U18 build #27: FIXED in 39 min: https://jenkins.koha-community[…]oha_20.05_U18/27/ |
| 19:17 |
|
|
khall joined #koha |
| 19:29 |
|
|
inlibro joined #koha |
| 19:52 |
|
|
khall joined #koha |
| 19:53 |
|
|
lukeG joined #koha |
| 20:18 |
|
|
andreashm joined #koha |
| 20:29 |
|
|
inlibro joined #koha |
| 20:29 |
|
|
khall joined #koha |
| 20:42 |
|
koha-jenkins |
Project Koha_20.05_D10 build #32: SUCCESS in 42 min: https://jenkins.koha-community[…]oha_20.05_D10/32/ |
| 20:43 |
|
koha-jenkins |
Project Koha_20.05_D9_My8 build #26: SUCCESS in 41 min: https://jenkins.koha-community[…]_20.05_D9_My8/26/ |
| 20:51 |
|
koha-jenkins |
Project Koha_20.05_U16 build #24: UNSTABLE in 48 min: https://jenkins.koha-community[…]oha_20.05_U16/24/ |
| 21:01 |
|
koha-jenkins |
Project Koha_20.05_D9 build #34: UNSTABLE in 59 min: https://jenkins.koha-community[…]Koha_20.05_D9/34/ |
| 21:09 |
|
koha-jenkins |
Project Koha_20.05_U20 build #23: SUCCESS in 1 hr 6 min: https://jenkins.koha-community[…]oha_20.05_U20/23/ |
| 21:11 |
|
|
andreashm joined #koha |
| 21:14 |
|
cait |
hm is gitlab down? |
| 21:21 |
|
oleonard |
Seems to be for me cait |
| 21:21 |
|
cait |
i just wanted to submit a manual patch - first in forever |
| 21:21 |
|
* cait |
is to blam |
| 21:21 |
|
cait |
e |
| 21:24 |
|
koha-jenkins |
Project Koha_20.05_D11 build #29: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]oha_20.05_D11/29/ |
| 21:27 |
|
koha-jenkins |
Project Koha_20.05_U18 build #28: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_20.05_U18/28/ |
| 21:29 |
|
|
inlibro joined #koha |
| 21:29 |
|
koha-jenkins |
Project Koha_20.05_U18 build #29: FAILURE in 2 min 5 sec: https://jenkins.koha-community[…]oha_20.05_U18/29/ |
| 21:38 |
|
cait |
it's back |
| 21:53 |
|
cait |
caroline: :) |
| 21:57 |
|
caroline |
:D |
| 22:29 |
|
|
inlibro joined #koha |
| 23:30 |
|
|
inlibro joined #koha |
