| Time |
S |
Nick |
Message |
| 00:00 |
|
|
alexbuckley joined #koha |
| 00:06 |
|
|
inlibro joined #koha |
| 00:48 |
|
|
tosca joined #koha |
| 01:06 |
|
|
inlibro joined #koha |
| 01:08 |
|
|
kathryn_ joined #koha |
| 01:46 |
|
|
tosca_ joined #koha |
| 02:06 |
|
|
inlibro joined #koha |
| 03:06 |
|
|
inlibro joined #koha |
| 03:44 |
|
|
tosca joined #koha |
| 04:07 |
|
|
inlibro joined #koha |
| 05:07 |
|
|
inlibro joined #koha |
| 06:04 |
|
|
did joined #koha |
| 06:07 |
|
|
inlibro joined #koha |
| 06:11 |
|
|
cait joined #koha |
| 06:35 |
|
|
reiveune joined #koha |
| 06:37 |
|
reiveune |
hello |
| 06:53 |
|
|
cait joined #koha |
| 06:54 |
|
|
cait1 joined #koha |
| 06:57 |
|
|
andreashm joined #koha |
| 06:59 |
|
|
alex_a joined #koha |
| 07:00 |
|
alex_a |
Bonjour |
| 07:01 |
|
|
cait2 joined #koha |
| 07:07 |
|
|
inlibro joined #koha |
| 07:10 |
|
|
cait joined #koha |
| 07:10 |
|
|
cait1 joined #koha |
| 07:29 |
|
magnuse |
\o/ |
| 07:32 |
|
|
cait joined #koha |
| 07:45 |
|
|
cait joined #koha |
| 07:47 |
|
|
cait1 joined #koha |
| 08:02 |
|
eythian |
hi |
| 08:02 |
|
|
cait joined #koha |
| 08:07 |
|
|
inlibro joined #koha |
| 08:12 |
|
|
SoniaB joined #koha |
| 08:12 |
|
SoniaB |
Hello :) |
| 08:12 |
|
magnuse |
bonjour |
| 08:12 |
|
wahanui |
bidet, magnuse |
| 09:07 |
|
|
inlibro joined #koha |
| 09:29 |
|
ashimema |
anyone else finding they can't save overduerules in master at the moment? |
| 09:33 |
|
Joubu |
looks ok for me |
| 09:33 |
|
ashimema |
Bug 25049 |
| 09:33 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25049 enhancement, P5 - low, ---, koha-bugs, NEW , Changes to overduerules.pl are not being saved |
| 09:34 |
|
ashimema |
David and I just tested that on a fresh sandbox at bywater |
| 09:36 |
|
Joubu |
did you select a letter template? |
| 09:38 |
|
cait1 |
hi all - sorry can't test right now |
| 09:38 |
|
ashimema |
yup we did |
| 09:40 |
|
magnuse |
works for me |
| 09:41 |
|
ashimema |
Hmm |
| 09:41 |
|
ashimema |
Wonder if it's sandbox specific |
| 09:41 |
|
ashimema |
Grr |
| 09:42 |
|
magnuse |
if i do not enter a digit for delay i get the behaviour described in the bug report |
| 09:44 |
|
ashimema |
aha.. that's it |
| 09:44 |
|
ashimema |
we didn't as we didn't want a delay |
| 09:46 |
|
magnuse |
"If you want Koha to trigger an action (send a letter or restrict a member), a delay value is required." |
| 09:46 |
|
ashimema |
what if you don't want any delay |
| 09:47 |
|
ashimema |
i.e you want it to send immediately |
| 09:47 |
|
ashimema |
it won't accept '0' |
| 09:47 |
|
ashimema |
also.. we should give some meaningful feedback |
| 09:49 |
|
magnuse |
true |
| 09:53 |
|
magnuse |
ashimema: if you want 0 delay you use the "Item due" that you can enable from the "Patron messaging preferences" on the category/individual patron? |
| 09:54 |
|
ashimema |
fair point |
| 09:54 |
|
ashimema |
I think David wanted to use 0 for testing another bug |
| 09:54 |
|
Joubu |
what magnuse said, it's not the same settings, not the same script, letter, etc. :) |
| 09:54 |
|
ashimema |
I'll tell him to backdate the due date or something |
| 09:55 |
|
ashimema |
but yeah.. we should still give a better warning there |
| 09:56 |
|
|
vfernandes joined #koha |
| 10:01 |
|
|
fridolin joined #koha |
| 10:07 |
|
cait1 |
I think there are bugs for the dealy thing |
| 10:07 |
|
cait1 |
i came across them in my big bug review |
| 10:08 |
|
|
inlibro joined #koha |
| 10:08 |
|
cait1 |
but I agree that it's probably mostly the lack of feedback |
| 10:20 |
|
|
khall joined #koha |
| 11:08 |
|
|
inlibro joined #koha |
| 11:20 |
|
|
fridolin left #koha |
| 11:42 |
|
oleonard |
Hi #koha |
| 11:47 |
|
cait1 |
hi oleonard |
| 11:47 |
|
wahanui |
hi oleopard |
| 11:48 |
|
* ashimema |
is happy with bug 25040 now |
| 11:48 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25040 blocker, P5 - low, ---, martin.renvoize, Needs Signoff , Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader |
| 11:49 |
|
|
sophie_m joined #koha |
| 12:08 |
|
|
inlibro joined #koha |
| 12:14 |
|
|
Dyrcona joined #koha |
| 12:36 |
|
|
fridolin joined #koha |
| 12:42 |
|
|
fridolin left #koha |
| 12:50 |
|
|
andreashm joined #koha |
| 13:08 |
|
|
inlibro joined #koha |
| 13:10 |
|
|
SoniaB joined #koha |
| 13:29 |
|
huginn |
News from kohagit: Bug 25010: DBRev 19.12.00.062 <http://git.koha-community.org/[…]6fab014a8602a5cfc> |
| 13:29 |
|
huginn |
News from kohagit: Bug 24996: Compiled CSS <http://git.koha-community.org/[…]57585caa128d5bb61> |
| 13:29 |
|
huginn |
News from kohagit: Bug 9422: (RM follow-up) Rebase Correction <http://git.koha-community.org/[…]8793139758adc0ce5> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25024: Do not escape $ <http://git.koha-community.org/[…]44f3e11212ce9555f> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25004: Search results place hold button not enabled when checking result checkbox... <http://git.koha-community.org/[…]67cc8aa405b8983f0> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25022: Display problem in authority editor with repeatable field <http://git.koha-community.org/[…]74021c8f7a4479f23> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25024: Make grep match full string <http://git.koha-community.org/[…]e94c6dcc800b9f49a> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25020: Preserve time part when batch extending due dates <http://git.koha-community.org/[…]ca211931e21689fad> |
| 13:29 |
|
huginn |
News from kohagit: Bug 19475: Clear the caches at the end of the tests <http://git.koha-community.org/[…]eaba1926a20ec8ba8> |
| 13:29 |
|
huginn |
News from kohagit: Bug 24941: Serials - Fix link to basket from acquisition details information <http://git.koha-community.org/[…]a74c9192f543ca7bb> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options <http://git.koha-community.org/[…]7fba2e31843759408> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25013: Fix capitalization: Edit Items on batch item edit <http://git.koha-community.org/[…]dac46e58fb87ac3dd> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25012: Fix class on OPAC view link in staff detail page <http://git.koha-community.org/[…]4ea5dfe179267289d> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields <http://git.koha-community.org/[…]fa1d2e5937a6c3eaf> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25006: Regression tests <http://git.koha-community.org/[…]d30cbf2f4fcb14417> |
| 13:29 |
|
huginn |
News from kohagit: Bug 24996: Unwanted CSS change unhides OPAC results sorting button <http://git.koha-community.org/[…]8f19905af302097ec> |
| 13:29 |
|
huginn |
News from kohagit: Bug 17938: Fix display of label for repeated MARC 583 - Action note fields <http://git.koha-community.org/[…]a9146faa40b89d86e> |
| 13:29 |
|
huginn |
News from kohagit: Bug 25010: Fix typo 'rewewal' in debit types <http://git.koha-community.org/[…]ded7c694207c2c3bf> |
| 13:29 |
|
huginn |
News from kohagit: Bug 19475: Add unit tests <http://git.koha-community.org/[…]d6c2ff960ce897335> |
| 13:29 |
|
huginn |
News from kohagit: Bug 19475: Don't copy holiday if it already exists in target calendar <http://git.koha-community.org/[…]144da6d1d10b82c9c> |
| 13:30 |
|
ashimema |
incoming... |
| 13:31 |
|
* oleonard |
fears for when we need ashimema to warn us of a REAL threat! |
| 13:31 |
|
cait1 |
too late or more? :) |
| 13:32 |
|
ashimema |
looks like my irc is slow.. |
| 13:32 |
|
ashimema |
I'm nto seeing most of what I just pushed yet |
| 13:33 |
|
ashimema |
yup.. my irc is laggy |
| 13:33 |
|
ashimema |
too late |
| 13:34 |
|
|
andreash_ joined #koha |
| 13:38 |
|
magnuse |
super cool if someone more code savvy than me could take a look at my comment 4 on bug 22005 |
| 13:38 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=22005 enhancement, P5 - low, ---, koha-bugs, NEW , System preference DecreaseLoanHighHolds incorrectly counts the number of holds |
| 13:38 |
|
* magnuse |
wishes #koha a fine weekend |
| 13:38 |
|
|
andreash_ joined #koha |
| 13:59 |
|
ashimema |
jajm around? |
| 14:00 |
|
jajm |
ashimema, yes |
| 14:01 |
|
ashimema |
I'm adding some comments to bug 24975.. would love to see that progres.. I just wanted to check if you might have the time/inclination to chase it through this cycle? |
| 14:01 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24975 enhancement, P5 - low, ---, julian.maurice, Needs Signoff , Refactor database translations |
| 14:02 |
|
ashimema |
I've added a comment for now |
| 14:04 |
|
jajm |
ashimema, i can only promise i will try :) |
| 14:08 |
|
|
eythian_ joined #koha |
| 14:08 |
|
|
inlibro joined #koha |
| 14:09 |
|
cait1 |
also interested |
| 14:09 |
|
cait1 |
not sure where to continue testing currently |
| 14:09 |
|
Joubu |
24975 first |
| 14:09 |
|
jajm |
quick answer to your comment: 1/ should be easy to fix, i'll do it 2/ i had performance in mind (but i did not measure it), but also, some parts of Koha use DBIx::Class directly, so by putting the code at DBIX::Class level it should work whether you use dbix::class or koha::objects |
| 14:09 |
|
cait1 |
bug 24975 |
| 14:09 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24975 enhancement, P5 - low, ---, julian.maurice, Needs Signoff , Refactor database translations |
| 14:09 |
|
cait1 |
ok, so we go this route |
| 14:11 |
|
ashimema |
ok. for 2/ I'm happy with it as is.. we can revisit moving to Koha::Object based later if we decide to try and make koha more self consistent.. generally I'd be keen to use our own objects for consistency but I like your approach of using components and the likes and don't want to hold it up. |
| 14:11 |
|
ashimema |
1/ is really the only actual issue I've found in reality.. the upgrade I did went seamlessly. |
| 14:11 |
|
ashimema |
cait, there's a test plan in the first commit.. :) |
| 14:12 |
|
ashimema |
then the AV stuff will be rebuild atop this.. the code does seems easier to follow this way to me so far |
| 14:37 |
|
jajm |
ashimema, i do not reproduce (1). I removed all langage directories from koha-tmpl/, emptied l10n_target, and i have no errors |
| 14:38 |
|
ashimema |
Oh.. that's interesting |
| 14:39 |
|
ashimema |
I get a 500 on the ajax request |
| 14:39 |
|
ashimema |
Which results in a word popup from datatables |
| 14:40 |
|
jajm |
ashimema, i had a 500 error caused by a missing Koha::Schema::Result::L10nSource, could it be your problem too ? |
| 14:40 |
|
ashimema |
Ah.. that could totally be it |
| 14:41 |
|
ashimema |
Yup, totally forgot the run the schema build on my second round of testing.. i.e. without translations before applying the patches |
| 14:41 |
|
ashimema |
Ooos |
| 14:42 |
|
ashimema |
Thanks for looking at it.. I'll happily add an SO 😀 |
| 14:44 |
|
ashimema |
Over to QA :) |
| 14:44 |
|
ashimema |
right.. on that note i think it's time to start the weekend :) |
| 14:46 |
|
oleonard |
Happy weekend ashimema! |
| 14:49 |
|
cait1 |
happy weekend :) |
| 14:49 |
|
cait1 |
leaving soon too |
| 15:03 |
|
|
cait1 left #koha |
| 15:04 |
|
|
SoniaB left #koha |
| 15:08 |
|
|
inlibro joined #koha |
| 15:19 |
|
|
margaret joined #koha |
| 15:43 |
|
reiveune |
bye |
| 15:43 |
|
|
reiveune left #koha |
| 15:52 |
|
|
cait joined #koha |
| 16:09 |
|
|
inlibro joined #koha |
| 17:09 |
|
|
inlibro joined #koha |
| 18:09 |
|
|
inlibro joined #koha |
| 19:09 |
|
|
inlibro joined #koha |
| 20:04 |
|
|
tcohen joined #koha |
| 20:05 |
|
|
andreashm joined #koha |
| 20:09 |
|
|
inlibro joined #koha |
| 20:10 |
|
|
amoyano joined #koha |
| 21:10 |
|
|
inlibro joined #koha |
| 21:32 |
|
|
davidnind joined #koha |
| 22:10 |
|
|
inlibro joined #koha |
| 22:59 |
|
|
lukeG1 left #koha |
| 23:10 |
|
|
inlibro joined #koha |
